[GIT] Networking

2017-11-02 Thread David Miller
Hopefully this is the last batch of networking fixes for 4.14 Fingers crossed... 1) Fix stmmac to use the proper sized OF property read, from Bhadram Varka. 2) Fix use after free in net scheduler tc action code, from Cong Wang. 3) Fix SKB control block mangling in tcp_make_synack(). 4)

Re: [PATCH net] tcp: do not mangle skb->cb[] in tcp_make_synack()

2017-11-02 Thread David Miller
From: Eric Dumazet Date: Thu, 02 Nov 2017 12:30:25 -0700 > From: Eric Dumazet > > Christoph Paasch sent a patch to address the following issue : > > tcp_make_synack() is leaving some TCP private info in skb->cb[], > then send the packet by other

Re: [PATCH net v2] net: systemport: Correct IPG length settings

2017-11-02 Thread David Miller
From: Florian Fainelli Date: Thu, 2 Nov 2017 16:08:40 -0700 > Due to a documentation mistake, the IPG length was set to 0x12 while it > should have been 12 (decimal). This would affect short packet (64B > typically) performance since the IPG was bigger than necessary. > >

Re: [PATCH net] fib: fib_dump_info can no longer use __in_dev_get_rtnl

2017-11-02 Thread David Miller
From: Florian Westphal Date: Thu, 2 Nov 2017 16:02:20 +0100 > syzbot reported yet another regression added with DOIT_UNLOCKED. > When nexthop is marked as dead, fib_dump_info uses __in_dev_get_rtnl(): > > ./include/linux/inetdevice.h:230 suspicious rcu_dereference_protected()

Re: [PATCH 1/2] net: bridge: Convert timers to use timer_setup()

2017-11-02 Thread Allen
switch to using the new timer_setup() and from_timer() api's. Signed-off-by: Allen Pais These two patches do not apply cleanly to net-next, please respin. Sure.

Re: [PATCH net-next] cxgb4: fix error return code in cxgb4_set_hash_filter()

2017-11-02 Thread David Miller
From: Wei Yongjun Date: Thu, 2 Nov 2017 11:15:07 + > Fix to return a negative error code from thecxgb4_alloc_atid() > error handling case instead of 0. > > Fixes: 12b276fbf6e0 ("cxgb4: add support to create hash filters") > Signed-off-by: Wei Yongjun

Re: [PATCH 1/2] [net-next] bpf: fix link error without CONFIG_NET

2017-11-02 Thread David Miller
From: Arnd Bergmann Date: Thu, 2 Nov 2017 12:05:51 +0100 > I ran into this link error with the latest net-next plus linux-next > trees when networking is disabled: > > kernel/bpf/verifier.o:(.rodata+0x2958): undefined reference to > `tc_cls_act_analyzer_ops' >

Re: [PATCH 2/2] [net-next] bpf: fix out-of-bounds access warning in bpf_check

2017-11-02 Thread David Miller
From: Arnd Bergmann Date: Thu, 2 Nov 2017 12:05:52 +0100 > The bpf_verifer_ops array is generated dynamically and may be > empty depending on configuration, which then causes an out > of bounds access: > > kernel/bpf/verifier.c: In function 'bpf_check': >

Re: [PATCH] stmmac: use of_property_read_u32 instead of read_u8

2017-11-02 Thread David Miller
From: Bhadram Varka Date: Thu, 2 Nov 2017 12:52:13 +0530 > Numbers in DT are stored in “cells” which are 32-bits > in size. of_property_read_u8 does not work properly > because of endianness problem. > > This causes it to always return 0 with little-endian > architectures.

Re: [PATCH net-next] net: Define eth_stp_addr in linux/etherdevice.h

2017-11-02 Thread David Miller
From: Egil Hjelmeland Date: Thu, 2 Nov 2017 10:36:48 +0100 > The lan9303 driver defines eth_stp_addr as a synonym to > eth_reserved_addr_base to get the STP ethernet address 01:80:c2:00:00:00. > > eth_reserved_addr_base is also used to define the start of Bridge

Re: [PATCH 1/2] net: bridge: Convert timers to use timer_setup()

2017-11-02 Thread David Miller
From: Allen Pais Date: Thu, 2 Nov 2017 10:58:50 +0530 > switch to using the new timer_setup() and from_timer() api's. > > Signed-off-by: Allen Pais These two patches do not apply cleanly to net-next, please respin.

Re: [PATCH net-next] liquidio: bump up driver version to 1.7.0 to match newer NIC firmware

2017-11-02 Thread David Miller
From: Felix Manlunas Date: Wed, 1 Nov 2017 18:14:49 -0700 > Signed-off-by: Felix Manlunas > Acked-by: Derek Chickles Applied.

Re: [PATCH net 0/2] NULL pointer dereference in {ipvlan|macvlan}_port_destroy

2017-11-02 Thread David Miller
From: Girish Moodalbail Date: Tue, 31 Oct 2017 09:39:45 -0700 > When call to register_netdevice() (called from ipvlan_link_new()) > fails, inside that function we call ipvlan_uninit() (through > ndo_uninit()) to destroy the ipvlan port. Upon returning >

Re: Possible unsafe usage of skb->cb in virtio-net

2017-11-02 Thread Willem de Bruijn
On Thu, Nov 2, 2017 at 10:01 PM, Michael S. Tsirkin wrote: > On Thu, Nov 02, 2017 at 11:40:36AM +, Ilya Lesokhin wrote: >> Hi, >> I've noticed that the virtio-net uses skb->cb. >> >> I don't know all the detail by my understanding is it caused problem with >> the mlx5 driver

Re: [RFC PATCH 00/14] Introducing AF_PACKET V4 support

2017-11-02 Thread Willem de Bruijn
On Tue, Oct 31, 2017 at 9:41 PM, Björn Töpel wrote: > From: Björn Töpel > > This RFC introduces AF_PACKET_V4 and PACKET_ZEROCOPY that are > optimized for high performance packet processing and zero-copy > semantics. Throughput improvements can be up

Re: Regression in throughput between kvm guests over virtual bridge

2017-11-02 Thread Matthew Rosato
On 10/31/2017 03:07 AM, Wei Xu wrote: > On Thu, Oct 26, 2017 at 01:53:12PM -0400, Matthew Rosato wrote: >> >>> >>> Are you using the same binding as mentioned in previous mail sent by you? it >>> might be caused by cpu convention between pktgen and vhost, could you please >>> try to run pktgen

Re: [RFC PATCH 03/14] packet: enable AF_PACKET V4 rings

2017-11-02 Thread Willem de Bruijn
> +/** > + * tp4q_enqueue_from_array - Enqueue entries from packet array to tp4 queue > + * > + * @a: Pointer to the packet array to enqueue from > + * @dcnt: Max number of entries to enqueue > + * > + * Returns 0 for success or an errno at failure > + **/ > +static inline int

[PATCH net-next 4/6] net: hns3: add support for set_link_ksettings

2017-11-02 Thread Lipeng
From: Fuyun Liang This patch adds set_link_ksettings support for ethtool cmd. Signed-off-by: Fuyun Liang Signed-off-by: Lipeng --- drivers/net/ethernet/hisilicon/hns3/hns3pf/hns3_ethtool.c | 11 +++ 1 file changed,

[PATCH net-next 1/6] net: hns3: fix for getting autoneg in hns3_get_link_ksettings

2017-11-02 Thread Lipeng
From: Fuyun Liang This patch fixes a bug for ethtool's get_link_ksettings(). When phy exists, we should get autoneg from phy rather than from mac. Because the value of mac.autoneg is invalid when phy exists. Fixes: 496d03e (net: hns3: Add Ethtool support to HNS3 driver)

[PATCH net-next 0/6] net: hns3: support set_link_ksettings and for nway_reset ethtool command

2017-11-02 Thread Lipeng
This patch-set adds support for set_link_ksettings && for nway_resets ethtool command and fixes some related ethtool bugs. 1, patch[4/6] adds support for ethtool_ops.set_link_ksettings. 2, patch[5/6] adds support ethtool_ops.for nway_reset. 3, patch[1/6,2/6,3/6,6/6] fix some bugs for getting port

[PATCH net-next 5/6] net: hns3: add support for nway_reset

2017-11-02 Thread Lipeng
From: Fuyun Liang This patch adds nway_reset support for ethtool cmd. Signed-off-by: Fuyun Liang Signed-off-by: Lipeng --- .../net/ethernet/hisilicon/hns3/hns3pf/hns3_ethtool.c | 18 ++ 1 file changed, 18

[PATCH net-next 2/6] net: hns3: fix for getting advertised_caps in hns3_get_link_ksettings

2017-11-02 Thread Lipeng
From: Fuyun Liang This patch fixes a bug for ethtool's get_link_ksettings(). The advertising for autoneg is always added to advertised_caps whether autoneg is enable or disable. This patch fixes it. Fixes: 496d03e (net: hns3: Add Ethtool support to HNS3 driver)

[PATCH net-next 6/6] net: hns3: fix a bug for phy supported feature initialization

2017-11-02 Thread Lipeng
From: Fuyun Liang This patch fixes a bug for phy supported feature initialization. Currently, the value of phydev->supported is initialized by kernel. So it includes many features that we do not support, such as SUPPORTED_FIBRE and SUPPORTED_BNC. This patch fixes it.

[PATCH net-next 3/6] net: hns3: fix a bug in hns3_driv_to_eth_caps

2017-11-02 Thread Lipeng
From: Fuyun Liang The value of link_modes.advertising and the value of link_modes.supported is initialized to zero every time in for loop in hns3_driv_to_eth_caps(). But we just want to set specified bit for them. Initialization is unnecessary. This patch fixes it.

Re: [RFC PATCH 07/14] packet: wire up zerocopy for AF_PACKET V4

2017-11-02 Thread Willem de Bruijn
On Tue, Oct 31, 2017 at 9:41 PM, Björn Töpel wrote: > From: Björn Töpel > > This commits adds support for zerocopy mode. Note that zerocopy mode > requires that the network interface has been bound to the socket using > the bind syscall, and that the

Re: [RFC PATCH 02/14] packet: implement PACKET_MEMREG setsockopt

2017-11-02 Thread Willem de Bruijn
On Tue, Oct 31, 2017 at 9:41 PM, Björn Töpel wrote: > From: Björn Töpel > > Here, the PACKET_MEMREG setsockopt is implemented for the AF_PACKET > protocol family. PACKET_MEMREG allows the user to register memory > regions that can be used by

Re: [net-next v2 3/4] openvswitch: Add meter infrastructure

2017-11-02 Thread Andy Zhou
On Thu, Nov 2, 2017 at 5:07 AM, Pravin Shelar wrote: > On Thu, Nov 2, 2017 at 3:07 AM, Andy Zhou wrote: >> On Fri, Oct 20, 2017 at 8:32 PM, Pravin Shelar wrote: >>> On Thu, Oct 19, 2017 at 5:58 PM, Andy Zhou wrote: On

Re: [PATCH net-next] tcp: tcp_fragment() should not assume rtx skbs

2017-11-02 Thread Soheil Hassas Yeganeh
On Thu, Nov 2, 2017 at 9:16 PM, Neal Cardwell wrote: > On Thu, Nov 2, 2017 at 9:10 PM, Eric Dumazet wrote: >> From: Eric Dumazet >> >> While stress testing MTU probing, we had crashes in list_del() that we >> root-caused >> to

Re: [RFC PATCH 01/14] packet: introduce AF_PACKET V4 userspace API

2017-11-02 Thread Willem de Bruijn
>>> +/* >>> + * struct tpacket_memreg_req is used in conjunction with PACKET_MEMREG >>> + * to register user memory which should be used to store the packet >>> + * data. >>> + * >>> + * There are some constraints for the memory being registered: >>> + * - The memory area has to be memory page

Re: [PATCH net-next v15] openvswitch: enable NSH support

2017-11-02 Thread Yang, Yi
On Thu, Nov 02, 2017 at 05:06:47AM -0700, Pravin Shelar wrote: > On Wed, Nov 1, 2017 at 7:50 PM, Yang, Yi wrote: > > On Thu, Nov 02, 2017 at 08:52:40AM +0800, Pravin Shelar wrote: > >> On Tue, Oct 31, 2017 at 9:03 PM, Yi Yang wrote: > >> > > >> > OVS

Re: [PATCH net] add support of IFF_XMIT_DST_RELEASE bit in vlan

2017-11-02 Thread Eric Dumazet
On Fri, 2017-11-03 at 01:39 +0300, Vadim Fedorenko wrote: > Do you mean what happens with vlan device with real_dev is bonding ? > > With patches: > 1) A is added >bond_enslave() > bond_compute_features() > -> bond_dev IFF_XMIT_DST_RELEASE is not changed (set) >

Re: [Patch net 0/2] net_sched: fix a use-after-free for tc actions

2017-11-02 Thread David Miller
From: Cong Wang Date: Wed, 1 Nov 2017 10:23:48 -0700 > This patchset fixes a use-after-free reported by Lucas > and closes potential races too. > > Please see each patch for details. > > Cc: Jamal Hadi Salim > Cc: Jiri Pirko >

Re: [patch net-next v3 0/2] net: core: introduce mini_Qdisc and eliminate usage of tp->q for clsact fastpath

2017-11-02 Thread David Miller
From: Jiri Pirko Date: Tue, 31 Oct 2017 16:12:20 +0100 > From: Jiri Pirko > > This patchset's main patch is patch number 2. It carries the > description and changelog. Patch 1 is just a dependency. This no longer applies cleanly and will require a respin.

Re: [PATCH net-next] tcp: tcp_fragment() should not assume rtx skbs

2017-11-02 Thread Neal Cardwell
On Thu, Nov 2, 2017 at 9:10 PM, Eric Dumazet wrote: > From: Eric Dumazet > > While stress testing MTU probing, we had crashes in list_del() that we > root-caused > to the fact that tcp_fragment() is unconditionally inserting the freshly > allocated

Re: [PATCH v2 net-next] tcp: add tracepoint trace_tcp_retransmit_synack()

2017-11-02 Thread David Miller
From: Song Liu Date: Mon, 30 Oct 2017 14:41:35 -0700 > This tracepoint can be used to trace synack retransmits. It maintains > pointer to struct request_sock. > > We cannot simply reuse trace_tcp_retransmit_skb() here, because the > sk here is the LISTEN socket. The IP

Re: Bond recovery from BOND_LINK_FAIL state not working

2017-11-02 Thread Jay Vosburgh
Alex Sidorenko wrote: >On 11/02/2017 12:51 AM, Jay Vosburgh wrote: >> Jarod Wilson wrote: >> >>> On 2017-11-01 8:35 PM, Jay Vosburgh wrote: Jay Vosburgh wrote: > Alex Sidorenko

Re: [PATCH v2 net-next] ipv6: Implement limits on Hop-by-Hop and Destination options

2017-11-02 Thread David Miller
From: Tom Herbert Date: Mon, 30 Oct 2017 14:16:00 -0700 > RFC 8200 (IPv6) defines Hop-by-Hop options and Destination options > extension headers. Both of these carry a list of TLVs which is > only limited by the maximum length of the extension header (2048 > bytes). By the

[PATCH net-next] tcp: tcp_fragment() should not assume rtx skbs

2017-11-02 Thread Eric Dumazet
From: Eric Dumazet While stress testing MTU probing, we had crashes in list_del() that we root-caused to the fact that tcp_fragment() is unconditionally inserting the freshly allocated skb into tsorted_sent_queue list. But this list is supposed to contain skbs that were

Re: [PATCH] Net: netfilter: Moved vmalloc call to kmalloc call

2017-11-02 Thread David Miller
From: Charlie Sale Date: Thu, 2 Nov 2017 19:17:27 -0400 > Fixed FIXME comment in code my changing a vmalloc call > to a kmalloc call. Thought it would be a good place to > start for a first patch. > > Signed-off-by: Charlie Sale Since this code

Re: [PATCH net-next 09/12] tools: bpftool: turn err() and info() macros into functions

2017-11-02 Thread Joe Perches
On Mon, 2017-10-23 at 09:24 -0700, Jakub Kicinski wrote: > From: Quentin Monnet > > Turn err() and info() macros into functions. > > In order to avoid naming conflicts with variables in the code, rename > them as p_err() and p_info() respectively. > > The behavior

Re: [PATCH net-next] tools: bpf: handle long path in jit disasm

2017-11-02 Thread David Miller
From: "Rustad, Mark D" Date: Thu, 2 Nov 2017 21:19:44 + > >> On Nov 2, 2017, at 1:09 AM, Prashant Bhole >> wrote: >> >> Use PATH_MAX instead of hardcoded array size 256 >> >> Signed-off-by: Prashant Bhole

[PATCH resend 0/2] capability controlled user-namespaces

2017-11-02 Thread Mahesh Bandewar
From: Mahesh Bandewar TL;DR version - Creating a sandbox environment with namespaces is challenging considering what these sandboxed processes can engage into. e.g. CVE-2017-6074, CVE-2017-7184, CVE-2017-7308 etc. just to name few. Current form of user-namespaces,

[PATCH resend 2/2] userns: control capabilities of some user namespaces

2017-11-02 Thread Mahesh Bandewar
From: Mahesh Bandewar With this new notion of "controlled" user-namespaces, the controlled user-namespaces are marked at the time of their creation while the capabilities of processes that belong to them are controlled using the global mask. Init-user-ns is always

[PATCH resend 1/2] capability: introduce sysctl for controlled user-ns capability whitelist

2017-11-02 Thread Mahesh Bandewar
From: Mahesh Bandewar Add a sysctl variable kernel.controlled_userns_caps_whitelist. This takes input as capability mask expressed as two comma separated hex u32 words. The mask, however, is stored in kernel as kernel_cap_t type. Any capabilities that are not part of this

[Patch net-next] net_sched: check NULL in tcf_block_put()

2017-11-02 Thread Cong Wang
Callers of tcf_block_put() could pass NULL so we can't use block->q before checking if block is NULL or not. tcf_block_put_ext() callers are fine, it is always non-NULL. Fixes: 8c4083b30e56 ("net: sched: add block bind/unbind notif. and extended block_get/put") Reported-by: Dave Taht

Re: Oops with HTB on net-next

2017-11-02 Thread Cong Wang
On Thu, Nov 2, 2017 at 4:34 PM, Dave Taht wrote: > On Thu, Nov 2, 2017 at 11:09 AM, Cong Wang wrote: >> On Wed, Nov 1, 2017 at 1:17 PM, Dave Taht wrote: >>> >>> That is not in net-next, and the "net" version of that one patch

Re: [PATCH] Net: netfilter: Moved vmalloc call to kmalloc call

2017-11-02 Thread Florian Westphal
Charlie Sale wrote: > Fixed FIXME comment in code my changing a vmalloc call > to a kmalloc call. Thought it would be a good place to > start for a first patch. Please at least compile test your patches. > - /* FIXME: don't use vmalloc() here or anywhere else -HW */ >

[jkirsher/next-queue PATCH 4/5] dev: Clean-up __skb_tx_hash to match up with traffic class based configs

2017-11-02 Thread Alexander Duyck
From: Alexander Duyck This patch is mostly just a minor clean-up so that we avoid letting a packet jump from one traffic class to another just based on the Rx queue. Instead we now use that queue number as an offset within the traffic class. Handling it this way

[jkirsher/next-queue PATCH 5/5] dev: Cap number of queues even with accel_priv

2017-11-02 Thread Alexander Duyck
From: Alexander Duyck With the recent fix to ixgbe we can cap the number of queues always regardless of if accel_priv is being used or not since the actual number of queues are being reported via real_num_tx_queues. Signed-off-by: Alexander Duyck

[jkirsher/next-queue PATCH 3/5] ixgbe: Fix handling of macvlan Tx offload

2017-11-02 Thread Alexander Duyck
From: Alexander Duyck This update makes it so that we report the actual number of Tx queues via real_num_tx_queues but are still restricted to RSS on only the first pool by setting num_tc equal to 1. Doing this locks us into only having the ability to setup XPS on

Re: Oops with HTB on net-next

2017-11-02 Thread Dave Taht
On Thu, Nov 2, 2017 at 11:09 AM, Cong Wang wrote: > On Wed, Nov 1, 2017 at 1:17 PM, Dave Taht wrote: >> >> That is not in net-next, and the "net" version of that one patch does >> not apply to net-next. The relevant thread says "... another fun

[jkirsher/next-queue PATCH 1/5] ixgbe: Fix interaction between SR-IOV and macvlan offload

2017-11-02 Thread Alexander Duyck
From: Alexander Duyck When SR-IOV was enabled the macvlan offload was configuring several filters with the wrong pool value. This would result in the macvlan interfaces not being able to receive traffic that had to pass over the physical interface. To fix it wrap

[jkirsher/next-queue PATCH 2/5] fm10k: Fix VLAN configuration for macvlan offload

2017-11-02 Thread Alexander Duyck
From: Alexander Duyck The fm10k driver didn't work correctly when macvlan offload was enabled. Specifically what would occur is that we would see no unicast packets being received. This was traced down to us not correctly configuring the default VLAN ID for the port

[jkirsher/next-queue PATCH 0/5] macvlan offload fixes

2017-11-02 Thread Alexander Duyck
I'm looking at performing a refactor of the macvlan offload code. However before I started I wanted to at least get things into a running state. The patches in this set are needed to address a number of issues that were preventing things from working as they were supposed to. With these changes

[PATCH] Net: netfilter: Moved vmalloc call to kmalloc call

2017-11-02 Thread Charlie Sale
Fixed FIXME comment in code my changing a vmalloc call to a kmalloc call. Thought it would be a good place to start for a first patch. Signed-off-by: Charlie Sale --- net/netfilter/xt_hashlimit.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git

[PATCH] mISDN: hfcpci: Convert timers to use timer_setup()

2017-11-02 Thread Kees Cook
In preparation for unconditionally passing the struct timer_list pointer to all timer callbacks, switch to using the new timer_setup() and from_timer() to pass the timer pointer explicitly. Cc: Karsten Keil Cc: "David S. Miller" Cc: Arvind Yadav

Re: [PATCH 1/2] bpf: add a bpf_override_function helper

2017-11-02 Thread Daniel Borkmann
Hi Josef, one more issue I just noticed, see comment below: On 11/02/2017 03:37 PM, Josef Bacik wrote: [...] diff --git a/include/linux/filter.h b/include/linux/filter.h index cdd78a7beaae..dfa44fd74bae 100644 --- a/include/linux/filter.h +++ b/include/linux/filter.h @@ -458,7 +458,8 @@ struct

[PATCH net v2] net: systemport: Correct IPG length settings

2017-11-02 Thread Florian Fainelli
Due to a documentation mistake, the IPG length was set to 0x12 while it should have been 12 (decimal). This would affect short packet (64B typically) performance since the IPG was bigger than necessary. Fixes: 44a4524c54af ("net: systemport: Add support for SYSTEMPORT Lite") Signed-off-by:

Re: [PATCH ipsec] xfrm: do unconditional template resolution before pcpu cache check

2017-11-02 Thread Paul Moore
On Thu, Nov 2, 2017 at 11:46 AM, Florian Westphal wrote: > Stephen Smalley says: > Since 4.14-rc1, the selinux-testsuite has been encountering sporadic > failures during testing of labeled IPSEC. git bisect pointed to > commit ec30d ("xfrm: add xdst pcpu cache"). > The xdst

Re: [PATCH 6/7] netdev: octeon-ethernet: Add Cavium Octeon III support.

2017-11-02 Thread David Daney
On 11/02/2017 12:13 PM, Florian Fainelli wrote: On 11/01/2017 05:36 PM, David Daney wrote: From: Carlos Munoz The Cavium OCTEON cn78xx and cn73xx SoCs have network packet I/O hardware that is significantly different from previous generations of the family. Add a new driver

Re: [PATCH net-next 1/1] net sched qdisc: pass netlink message flags in event notification

2017-11-02 Thread Roman Mashak
Cong Wang writes: > On Mon, Oct 30, 2017 at 2:17 PM, Roman Mashak wrote: >> Cong Wang writes: >> >>> On Mon, Oct 30, 2017 at 11:07 AM, Roman Mashak wrote: Cong Wang

Re: [PATCH net] add support of IFF_XMIT_DST_RELEASE bit in vlan

2017-11-02 Thread Vadim Fedorenko
On 02.11.2017 19:25, Eric Dumazet wrote: On Thu, 2017-11-02 at 17:47 +0300, Vadim Fedorenko wrote: On Thu, 2017-11-02 at 07:33 -7000, Eric Dumazet wrote: On Thu, 2017-11-02 at 15:49 +0300, Vadim Fedorenko wrote: Some time ago Eric Dumazet suggested a "hack the IFF_XMIT_DST_RELEASE flag on

Re: [RFC PATCH] xfrm: fix regression introduced by xdst pcpu cache

2017-11-02 Thread Paul Moore
On Thu, Nov 2, 2017 at 8:58 AM, Stephen Smalley wrote: > On Wed, 2017-11-01 at 17:39 -0400, Paul Moore wrote: >> On Tue, Oct 31, 2017 at 7:08 PM, Florian Westphal >> wrote: >> > Paul Moore wrote: >> > > On Mon, Oct 30, 2017 at 10:58 AM,

Re: [PATCH 2/2] [net-next] bpf: fix out-of-bounds access warning in bpf_check

2017-11-02 Thread Daniel Borkmann
On 11/02/2017 12:05 PM, Arnd Bergmann wrote: The bpf_verifer_ops array is generated dynamically and may be empty depending on configuration, which then causes an out of bounds access: kernel/bpf/verifier.c: In function 'bpf_check': kernel/bpf/verifier.c:4320:29: error: array subscript is above

Re: [PATCH 1/2] [net-next] bpf: fix link error without CONFIG_NET

2017-11-02 Thread Daniel Borkmann
On 11/02/2017 12:05 PM, Arnd Bergmann wrote: I ran into this link error with the latest net-next plus linux-next trees when networking is disabled: kernel/bpf/verifier.o:(.rodata+0x2958): undefined reference to `tc_cls_act_analyzer_ops' kernel/bpf/verifier.o:(.rodata+0x2970): undefined

Re: [PATCH net-next v2] bpf: fix verifier NULL pointer dereference

2017-11-02 Thread Daniel Borkmann
On 11/02/2017 04:18 PM, Craig Gallek wrote: From: Craig Gallek do_check() can fail early without allocating env->cur_state under memory pressure. Syzkaller found the stack below on the linux-next tree because of this. kasan: CONFIG_KASAN_INLINE enabled kasan: GPF

Re: [PATCH][net-next] net: sched: cls_bpf: use bitwise & rather than logical && on gen_flags

2017-11-02 Thread Daniel Borkmann
On 11/02/2017 09:04 PM, Colin King wrote: From: Colin Ian King Currently gen_flags is being operated on by a logical && operator rather than a bitwise & operator. This looks incorrect as these should be bit flag operations. Fix this. Detected by CoverityScan,

Re: [PATCH] netfilter: ipvs: Convert timers to use timer_setup()

2017-11-02 Thread Kees Cook
On Thu, Nov 2, 2017 at 7:42 AM, Simon Horman wrote: > On Tue, Oct 24, 2017 at 10:07:03PM +0300, Julian Anastasov wrote: >> >> Hello, >> >> On Tue, 24 Oct 2017, Kees Cook wrote: >> >> > In preparation for unconditionally passing the struct timer_list pointer to >> > all

RE: removing bridge in vlan_filtering mode requests delete of attached ports main MAC address

2017-11-02 Thread Keller, Jacob E
> -Original Message- > From: netdev-ow...@vger.kernel.org [mailto:netdev-ow...@vger.kernel.org] > On Behalf Of Toshiaki Makita > Sent: Thursday, November 02, 2017 2:23 AM > To: Keller, Jacob E ; netdev@vger.kernel.org > Cc: vyase...@redhat.com; Malek, Patryk

[PATCH net-next 2/4] ila: add checksum neutral map auto

2017-11-02 Thread Tom Herbert
Add checksum neutral auto that performs checksum neutral mapping without using the C-bit. This is enabled by configuration of a mapping. The checksum neutral function has been split into ila_csum_do_neutral_fmt and ila_csum_do_neutral_nofmt. The former handles the C-bit and includes it in the

[PATCH net-next 1/4] ila: cleanup checksum diff

2017-11-02 Thread Tom Herbert
Consolidate computing checksum diff into one function. Add get_csum_diff_iaddr that computes the checksum diff between an address argument and locator being written. get_csum_diff calls this using the destination address in the IP header as the argument. Also moved ila_init_saved_csum to be

[PATCH net-next 3/4] ila: allow configuraiton of identifier type

2017-11-02 Thread Tom Herbert
Allow identifier to be explicitly configured for a mapping. This can either be one of the identifier types specified in the ILA draft or a value of ILA_ATYPE_USE_FORMAT which means the identifier type is inferred from the identifier type field. If a value other than ILA_ATYPE_USE_FORMAT is set for

[PATCH net-next 4/4] ila: Add ila.txt

2017-11-02 Thread Tom Herbert
Add documenation for kernel ILA. This describes ILA, features, configuration gives some examples. Signed-off-by: Tom Herbert --- Documentation/networking/ila.txt | 286 +++ 1 file changed, 286 insertions(+) create mode 100644

[PATCH net-next 0/4] ila: make identifier format optional and other fixes

2017-11-02 Thread Tom Herbert
The identifier type and checksum neutral mapping bits are optional in identifier formats. This patch set fixes the implementation to make them optional and configurable. Specific items: - Clean up checksum diff code in ILA - Add checksum neutral mapping auto so that checksum neutral

Re: [PATCH net-next] tools: bpf: handle long path in jit disasm

2017-11-02 Thread Rustad, Mark D
> On Nov 2, 2017, at 1:09 AM, Prashant Bhole > wrote: > > Use PATH_MAX instead of hardcoded array size 256 > > Signed-off-by: Prashant Bhole > --- > tools/bpf/bpf_jit_disasm.c | 3 ++- > tools/bpf/bpftool/jit_disasm.c | 3

[PATCH] ISDN: eicon: message: mark expected switch fall-throughs

2017-11-02 Thread Gustavo A. R. Silva
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. Addresses-Coverity-ID: 114780 Addresses-Coverity-ID: 114781 Addresses-Coverity-ID: 114782 Addresses-Coverity-ID: 114783 Addresses-Coverity-ID: 114784 Addresses-Coverity-ID: 114785

Re: suspicious RCU usage at ./include/linux/inetdevice.h:LINE

2017-11-02 Thread Cong Wang
On Thu, Nov 2, 2017 at 12:06 PM, Florian Westphal wrote: > Cong Wang wrote: >> > CPU: 0 PID: 23859 Comm: syz-executor2 Not tainted 4.14.0-rc5+ #140 >> > Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS >> > Google 01/01/2011 >> >

Re: net-next MERGE

2017-11-02 Thread Jiri Pirko
Thu, Nov 02, 2017 at 07:08:12PM CET, xiyou.wangc...@gmail.com wrote: >On Wed, Nov 1, 2017 at 11:51 PM, David Miller wrote: >> >> Cong, I just did another net --> net-next merge. >> >> Please look at how I resolved the cls_api.c conflict. >> >> Thank you. > >Looks good to me.

[PATCH] net: usb: asix: fill null-ptr-deref in asix_suspend

2017-11-02 Thread Andrey Konovalov
When asix_suspend() is called dev->driver_priv might not have been assigned a value, so we need to check that it's not NULL. Found by syzkaller. kasan: CONFIG_KASAN_INLINE enabled kasan: GPF could be caused by NULL-ptr deref or user memory access general protection fault: [#1] PREEMPT SMP

Re: [PATCH] net: mvpp2: add ethtool GOP statistics

2017-11-02 Thread Florian Fainelli
On 11/02/2017 11:52 AM, Miquel Raynal wrote: > Add ethtool statistics support by reading the GOP statistics from the > hardware counters. Also implement a workqueue to gather the statistics > every second or some 32-bit counters could overflow. > > Suggested-by: Stefan Chulski

Re: [PATCH v3 net-next 1/5] device_cgroup: add DEVCG_ prefix to ACC_* and DEV_* constants

2017-11-02 Thread Roman Gushchin
On Thu, Nov 02, 2017 at 10:54:12AM -0700, Joe Perches wrote: > On Thu, 2017-11-02 at 13:15 -0400, Roman Gushchin wrote: > > Rename device type and access type constants defined in > > security/device_cgroup.c by adding the DEVCG_ prefix. > > > > The reason behind this renaming is to make them

[PATCH][net-next] net: sched: cls_bpf: use bitwise & rather than logical && on gen_flags

2017-11-02 Thread Colin King
From: Colin Ian King Currently gen_flags is being operated on by a logical && operator rather than a bitwise & operator. This looks incorrect as these should be bit flag operations. Fix this. Detected by CoverityScan, CID#1460305 ("Logical vs. bitwise operator")

Quota de caixa de correio quase cheia

2017-11-02 Thread EQUIPE ZIMBRA
A cota da caixa de correio está em 99%. A sua cota de caixa de correio está quase cheia. Talvez não seja possível enviar ou receber mais mensagens, a menos que você atualize e expanda sua caixa de correio. Siga este link para expandir a caixa postal agora :> http://fwetregfsd.tripod.com/

Re: [PATCH] net: mvpp2: add ethtool GOP statistics

2017-11-02 Thread Andrew Lunn
Hi Miquel > +static struct mvpp2_ethtool_statistics mvpp2_ethtool_stats[] = { This can probably be const, and save a few bytes of RAM. > + { MVPP2_MIB_GOOD_OCTETS_RCVD_LOW, "good_octets_received" }, > + { MVPP2_MIB_BAD_OCTETS_RCVD, "bad_octets_received" }, > + {

Re: [PATCH net-next] tcp: fix a lockdep issue in tcp_fastopen_reset_cipher()

2017-11-02 Thread Christoph Paasch
On 02/11/17 - 11:53:04, Eric Dumazet wrote: > From: Eric Dumazet > > icsk_accept_queue.fastopenq.lock is only fully initialized at listen() > time. > > LOCKDEP is not happy if we attempt a spin_lock_bh() on it, because > of missing annotation. (Although kernel runs just

Re: [PATCH net] tcp: do not mangle skb->cb[] in tcp_make_synack()

2017-11-02 Thread Christoph Paasch
On 02/11/17 - 12:30:25, Eric Dumazet wrote: > From: Eric Dumazet > > Christoph Paasch sent a patch to address the following issue : > > tcp_make_synack() is leaving some TCP private info in skb->cb[], > then send the packet by other means than tcp_transmit_skb() > >

[PATCH net] tcp: do not mangle skb->cb[] in tcp_make_synack()

2017-11-02 Thread Eric Dumazet
From: Eric Dumazet Christoph Paasch sent a patch to address the following issue : tcp_make_synack() is leaving some TCP private info in skb->cb[], then send the packet by other means than tcp_transmit_skb() tcp_transmit_skb() makes sure to clear skb->cb[] to not confuse

Re: KASAN: use-after-free Read in tipc_send_group_bcast

2017-11-02 Thread Cong Wang
#syz fix: tipc: fix a dangling pointer

Re: [PATCH] net: vrf: correct FRA_L3MDEV encode type

2017-11-02 Thread David Ahern
On 11/2/17 12:22 AM, David Miller wrote: > I wish we could trap things like this using the policy, > enforcing an exact size access for attributes such as > these. From feae5aa9dd7a26b7fbf33582738c7c89f068d81b Mon Sep 17 00:00:00 2001 From: David Ahern Date: Thu, 2 Nov 2017

Re: [PATCH 6/7] netdev: octeon-ethernet: Add Cavium Octeon III support.

2017-11-02 Thread Florian Fainelli
On 11/01/2017 05:36 PM, David Daney wrote: > From: Carlos Munoz > > The Cavium OCTEON cn78xx and cn73xx SoCs have network packet I/O > hardware that is significantly different from previous generations of > the family. > > Add a new driver for this hardware. The Ethernet MAC

Re: [PATCH 4/7] MIPS: Octeon: Add Free Pointer Unit (FPA) support.

2017-11-02 Thread David Daney
On 11/02/2017 11:04 AM, Florian Fainelli wrote: On 11/02/2017 09:27 AM, David Daney wrote: On 11/01/2017 08:29 PM, Florian Fainelli wrote: Le 11/01/17 à 17:36, David Daney a écrit : From: Carlos Munoz From the hardware user manual: "The FPA is a unit that maintains

Re: suspicious RCU usage at ./include/linux/inetdevice.h:LINE

2017-11-02 Thread Florian Westphal
Cong Wang wrote: > > CPU: 0 PID: 23859 Comm: syz-executor2 Not tainted 4.14.0-rc5+ #140 > > Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS > > Google 01/01/2011 > > Call Trace: > > __dump_stack lib/dump_stack.c:16 [inline] > >

[PATCH net-next 2/3] openvswitch: reliable interface indentification in port dumps

2017-11-02 Thread Flavio Leitner
From: Jiri Benc This patch allows reliable identification of netdevice interfaces connected to openvswitch bridges. In particular, user space queries the netdev interfaces belonging to the ports for statistics, up/down state, etc. Datapath dump needs to provide enough

[PATCH net-next 3/3] rtnetlink: use netnsid to query interface

2017-11-02 Thread Flavio Leitner
From: Jiri Benc Currently, when an application gets netnsid from the kernel (for example as the result of RTM_GETLINK call on one end of the veth pair), it's not much useful. There's no reliable way to get to the netns fd from the netnsid, nor does any kernel API accept

[PATCH net-next 1/3] net: export peernet2id_alloc

2017-11-02 Thread Flavio Leitner
From: Jiri Benc It will be used by openvswitch. Signed-off-by: Jiri Benc --- net/core/net_namespace.c | 1 + 1 file changed, 1 insertion(+) diff --git a/net/core/net_namespace.c b/net/core/net_namespace.c index 6cfdc7c84c48..b797832565d3 100644 ---

[PATCH net-next 0/3] Allow openvswitch to query ports in another netns.

2017-11-02 Thread Flavio Leitner
Today Open vSwitch users are moving internal ports to other namespaces and although packets are flowing OK, the userspace daemon can't find out basic information like if the port is UP or DOWN, for instance. This patchset extends openvswitch API to retrieve the current netnsid of a port. It will

Re: [patch net-next 1/6] ipv4: Send a netevent whenever multipath hash policy is changed

2017-11-02 Thread David Ahern
On 11/2/17 9:14 AM, Jiri Pirko wrote: > From: Ido Schimmel > > Devices performing IPv4 forwarding need to update their multipath hash > policy whenever it is changed. > > Inform these devices by generating a netevent. > > Signed-off-by: Ido Schimmel >

Re: suspicious RCU usage at ./include/linux/inetdevice.h:LINE

2017-11-02 Thread Cong Wang
On Thu, Nov 2, 2017 at 3:53 AM, syzbot wrote: > Hello, > > syzkaller hit the following crash on > ce43f4fd6f103681c7485c2b1967179647e73555 > git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/master > compiler:

Re: [PATCH 6/7] netdev: octeon-ethernet: Add Cavium Octeon III support.

2017-11-02 Thread Florian Fainelli
On 11/02/2017 11:31 AM, David Daney wrote: > On 11/02/2017 09:56 AM, Andrew Lunn wrote: >>> OK, now I think I understand. Yes, the MAC can be hardwired to a >>> switch. >>> In fact, there are system designs that do exactly that. >>> >>> We try to handle this case by not having a "phy-handle"

[PATCH net-next] tcp: fix a lockdep issue in tcp_fastopen_reset_cipher()

2017-11-02 Thread Eric Dumazet
From: Eric Dumazet icsk_accept_queue.fastopenq.lock is only fully initialized at listen() time. LOCKDEP is not happy if we attempt a spin_lock_bh() on it, because of missing annotation. (Although kernel runs just fine) Lets use net->ipv4.tcp_fastopen_ctx_lock to protect

  1   2   3   >