Re: [PATCH net-next v2 0/6] bpf: Fix bugs in sock_ops samples

2017-11-10 Thread David Miller
From: Lawrence Brakmo Date: Fri, 10 Nov 2017 22:19:49 -0800 > The programs were returning -1 in some cases when they should > only return 0 or 1. Changes in the verifier now catch this > issue and the programs fail to load. This is now fixed. Series applied, thanks Lawrence.

Re: [PATCH net-next 0/6] net: dsa: simplify switchdev prepare phase

2017-11-10 Thread David Miller
From: Vivien Didelot Date: Wed, 8 Nov 2017 12:19:11 -0500 > This patch series brings no functional changes. > > It removes the unused switchdev_trans arguments from the dsa_switch_ops > for both MDB and VLAN operations, and provides function to prepare and

Re: [PATCH net] net: dsa: return after mdb prepare phase

2017-11-10 Thread David Miller
From: Vivien Didelot Date: Wed, 8 Nov 2017 10:49:56 -0500 > The current code does not return after successfully preparing the MDB > addition on every ports member of a multicast group. Fix this. > > Fixes: a1a6b7ea7f2d ("net: dsa: add cross-chip multicast

Re: [PATCH net] net: dsa: return after vlan prepare phase

2017-11-10 Thread David Miller
From: Vivien Didelot Date: Wed, 8 Nov 2017 10:50:10 -0500 > The current code does not return after successfully preparing the VLAN > addition on every ports member of a it. Fix this. > > Fixes: 1ca4aa9cd4cc ("net: dsa: check VLAN capability of every

Re: [net-next v2 1/1] tipc: improve link resiliency when rps is activated

2017-11-10 Thread David Miller
From: Jon Maloy Date: Wed, 8 Nov 2017 09:59:26 +0100 > Currently, the TIPC RPS dissector is based only on the incoming packets' > source node address, hence steering all traffic from a node to the same > core. We have seen that this makes the links vulnerable to

Re: [PATCH v2 0/2] net: macb: add error handling on probe and

2017-11-10 Thread David Miller
From: Michael Grzeschik Date: Wed, 8 Nov 2017 09:56:33 +0100 > This series adds more error handling to the macb driver. Series applied to net-next, thanks.

[PATCH net v3 04/12] net/sonic: Clean up and modernize log messages

2017-11-10 Thread Finn Thain
Add missing printk severity levels by adopting pr_foo() calls for the platform_driver and dev_foo() calls for the nubus_driver. Avoid KERN_CONT usage as per advice from checkpatch. Avoid #ifdef around printk calls. Cc: Thomas Bogendoerfer Cc: Chris Zankel

[PATCH net v3 03/12] net/mac8390: Convert to nubus_driver

2017-11-10 Thread Finn Thain
Tested-by: Stan Johnson Signed-off-by: Finn Thain --- drivers/net/Space.c | 3 -- drivers/net/ethernet/8390/mac8390.c | 105 ++-- include/net/Space.h | 1 - 3 files changed, 53

[PATCH net v3 02/12] net/mac89x0: Convert to platform_driver

2017-11-10 Thread Finn Thain
Apparently these Dayna cards don't have a pseudoslot declaration ROM which means they can't be probed like NuBus cards. Cc: Geert Uytterhoeven Signed-off-by: Finn Thain --- arch/m68k/mac/config.c| 4 +++ drivers/net/Space.c

[PATCH net v3 00/12] Fixes, cleanup and modernization for some legacy ethernet NIC drivers

2017-11-10 Thread Finn Thain
This patch series adds support for the Linux Driver Model for Mac NIC drivers, fixes some logging bugs, removes dead code, and adopts netif_* calls to reduce code duplication. All up, about 100 lines of code are eliminated. This patch series has been tested on a variety of Macs, with coverage

[PATCH net v3 06/12] net/mac89x0: Remove dead or unreachable code

2017-11-10 Thread Finn Thain
Signed-off-by: Finn Thain --- drivers/net/ethernet/cirrus/mac89x0.c | 31 --- 1 file changed, 31 deletions(-) diff --git a/drivers/net/ethernet/cirrus/mac89x0.c b/drivers/net/ethernet/cirrus/mac89x0.c index 8a23d2fc0e28..c1a3d1aed037

[PATCH net v3 05/12] net/sonic: Replace custom debug logging with netif_* calls

2017-11-10 Thread Finn Thain
Eliminate duplicated debug code by moving it into the core driver. Don't log the only valid silicon revision number (it's in the source). Cc: Thomas Bogendoerfer Cc: Chris Zankel Tested-by: Stan Johnson Signed-off-by: Finn Thain

[PATCH net v3 08/12] net/mac89x0: Replace custom debug logging with netif_* calls

2017-11-10 Thread Finn Thain
Signed-off-by: Finn Thain --- drivers/net/ethernet/cirrus/mac89x0.c | 52 --- 1 file changed, 18 insertions(+), 34 deletions(-) diff --git a/drivers/net/ethernet/cirrus/mac89x0.c b/drivers/net/ethernet/cirrus/mac89x0.c index

[PATCH net v3 07/12] net/mac89x0: Fix and modernize log messages

2017-11-10 Thread Finn Thain
Fix log message fragments which no longer produce the desired output (since the behaviour of printk() was changed). Add missing printk severity levels. Drop deprecated "out of memory" message as per checkpatch advice. Signed-off-by: Finn Thain ---

[PATCH net v3 01/12] net/macsonic: Convert to nubus_driver

2017-11-10 Thread Finn Thain
Tested-by: Stan Johnson Signed-off-by: Finn Thain --- drivers/net/ethernet/natsemi/macsonic.c | 170 ++-- 1 file changed, 118 insertions(+), 52 deletions(-) diff --git a/drivers/net/ethernet/natsemi/macsonic.c

Re: [PATCH net-next] net: mvpp2: fix GOP statistics loop start and stop conditions

2017-11-10 Thread David Miller
From: Miquel Raynal Date: Wed, 8 Nov 2017 08:59:40 +0100 > GOP statistics from all ports of one instance of the driver are gathered > with one work recalled in loop in a workqueue. The loop is started when > a port is up, and stopped when a port is down. This

[PATCH net v3 11/12] net/macmace: Fix and clean up log messages

2017-11-10 Thread Finn Thain
Don't log unexpanded "eth%d". Log the chip revision in the probe message (consistent with mace.c). Drop redundant debug messages for FIFO events recorded in the interface statistics (also consistent with mace.c). Tested-by: Stan Johnson Signed-off-by: Finn Thain

[PATCH net v3 12/12] net/smc9194: Remove bogus CONFIG_MAC reference

2017-11-10 Thread Finn Thain
AFAIK the only version of smc9194.c with Mac support is the one in the linux-mac68k CVS repo, which never made it to the mainline. Despite that, as of v2.3.45, arch/m68k/config.in listed CONFIG_SMC9194 under CONFIG_MAC. This mistake got carried over into Kconfig in v2.5.55. (See pre-git era

[PATCH net v3 09/12] net/8390: Fix redundant code

2017-11-10 Thread Finn Thain
The patch which introduced the 8390 core module parameter 'msg_enable' failed to do anything useful with it: it merely causes an ancient version string to be logged. Remove the other code that logs the same string. Use the msg_enable module parameter as the default value for ei_local->msg_enable.

[PATCH net v3 10/12] net/mac8390: Fix log messages

2017-11-10 Thread Finn Thain
Use dev_foo() and log the slot number instead of the unexpanded "eth%d". Disambiguate the two identical "Card type %s is unsupported" messages. Tested-by: Stan Johnson Signed-off-by: Finn Thain --- drivers/net/ethernet/8390/mac8390.c | 36

[PATCH net-next v2 1/6] bpf: Fix tcp_synrto_kern.c sample program

2017-11-10 Thread Lawrence Brakmo
The program was returning -1 in some cases which is not allowed by the verifier any longer. Fixes: 390ee7e29fc8 ("bpf: enforce return code for cgroup-bpf programs") Signed-off-by: Lawrence Brakmo --- samples/bpf/tcp_synrto_kern.c | 6 -- 1 file changed, 4 insertions(+), 2

Re: [PATCH net-next 0/2] net: hns3: Bug fixes & Code improvements in HNS3 driver

2017-11-10 Thread David Miller
From: Lipeng Date: Wed, 8 Nov 2017 15:52:21 +0800 > This patch-set introduces some bug fixes and code improvements. > As [patch 1/2] depends on the patch {5392902 net: hns3: Consistently using > GENMASK in hns3 driver}, which exists in net-next, not exists in net, so > push

[PATCH net-next v2 5/6] bpf: Fix tcp_iw_kern.c sample program

2017-11-10 Thread Lawrence Brakmo
The program was returning -1 in some cases which is not allowed by the verifier any longer. Fixes: 390ee7e29fc8 ("bpf: enforce return code for cgroup-bpf programs") Signed-off-by: Lawrence Brakmo --- samples/bpf/tcp_iw_kern.c | 14 -- 1 file changed, 8 insertions(+),

[PATCH net-next v2 0/6] bpf: Fix bugs in sock_ops samples

2017-11-10 Thread Lawrence Brakmo
The programs were returning -1 in some cases when they should only return 0 or 1. Changes in the verifier now catch this issue and the programs fail to load. This is now fixed. [PATCH net-next v2 1/6] bpf: Fix tcp_synrto_kern.c sample program [PATCH net-next v2 2/6] bpf: Fix tcp_rwnd_kern.c

[PATCH net-next v2 3/6] bpf: Fix tcp_bufs_kern.c sample program

2017-11-10 Thread Lawrence Brakmo
The program was returning -1 in some cases which is not allowed by the verifier any longer. Fixes: 390ee7e29fc8 ("bpf: enforce return code for cgroup-bpf programs") Signed-off-by: Lawrence Brakmo --- samples/bpf/tcp_bufs_kern.c | 14 -- 1 file changed, 8

[PATCH net-next v2 6/6] bpf: Fix tcp_clamp_kern.c sample program

2017-11-10 Thread Lawrence Brakmo
The program was returning -1 in some cases which is not allowed by the verifier any longer. Fixes: 390ee7e29fc8 ("bpf: enforce return code for cgroup-bpf programs") Signed-off-by: Lawrence Brakmo --- samples/bpf/tcp_clamp_kern.c | 24 +--- 1 file changed, 13

[PATCH net-next v2 2/6] bpf: Fix tcp_rwnd_kern.c sample program

2017-11-10 Thread Lawrence Brakmo
The program was returning -1 in some cases which is not allowed by the verifier any longer. Fixes: 390ee7e29fc8 ("bpf: enforce return code for cgroup-bpf programs") Signed-off-by: Lawrence Brakmo --- samples/bpf/tcp_rwnd_kern.c | 6 -- 1 file changed, 4 insertions(+), 2

[PATCH net-next v2 4/6] bpf: Fix tcp_cong_kern.c sample program

2017-11-10 Thread Lawrence Brakmo
The program was returning -1 in some cases which is not allowed by the verifier any longer. Fixes: 390ee7e29fc8 ("bpf: enforce return code for cgroup-bpf programs") Signed-off-by: Lawrence Brakmo --- samples/bpf/tcp_cong_kern.c | 6 -- 1 file changed, 4 insertions(+), 2

Re: [PATCH v2 net-next] net: netlink: Update attr validation to require exact length for some types

2017-11-10 Thread David Miller
From: David Ahern Date: Tue, 7 Nov 2017 21:59:40 -0800 > Attributes using NLA_U* and NLA_S* (where * is 8, 16,32 and 64) are > expected to be an exact length. Split these data types from > nla_attr_minlen into nla_attr_len and update validate_nla to require > the attribute to

[PATCH 12/14] nubus: Rename struct nubus_dev

2017-11-10 Thread Finn Thain
It is misleading to use "dev" to mean a functional resource. And in adopting the Linux Driver Model, struct nubus_board will embed a struct device. Drivers will then bind with boards, not with functional resources. Rename struct nubus_dev as struct nubus_functional_resource. This is the vendor's

[PATCH 13/14] nubus: Add expansion_type values for various Mac models

2017-11-10 Thread Finn Thain
Add an expansion slot attribute to allow drivers to properly handle cards like Comm Slot cards and PDS cards without declaration ROMs. Tested-by: Stan Johnson Signed-off-by: Finn Thain --- arch/m68k/include/asm/macintosh.h | 9 ++-

Re: [PATCH] net: ipv6: sysctl to specify IPv6 ND traffic class

2017-11-10 Thread David Miller
From: Maciej Żenczykowski Date: Tue, 7 Nov 2017 21:52:09 -0800 > From: Maciej Żenczykowski > > Add a per-device sysctl to specify the default traffic class to use for > kernel originated IPv6 Neighbour Discovery packets. > > Currently this includes: >

Re: [PATCH net-next 2/2] net/ncsi: Don't return error on normal response

2017-11-10 Thread David Miller
From: Samuel Mendoza-Jonas Date: Wed, 8 Nov 2017 16:30:45 +1100 > Several response handlers return EBUSY if the data corresponding to the > command/response pair is already set. There is no reason to return an > error here; the channel is advertising something as enabled

Re: [PATCH net-next 1/2] net/ncsi: Improve general state logging

2017-11-10 Thread David Miller
From: Samuel Mendoza-Jonas Date: Wed, 8 Nov 2017 16:30:44 +1100 > The NCSI driver is mostly silent which becomes a headache when trying to > determine what has occurred on the NCSI connection. This adds additional > logging in a few key areas such as state transitions and

WireGuard Upstreaming Roadmap (November 2017)

2017-11-10 Thread Jason A. Donenfeld
Hi folks, This relates to WireGuard [0]. Following a very nice conference with the Linux kernel networking subsystem community [1,2], I thought it might be a good idea to spell out the roadmap for the coming months and the trajectory into upstream, based on my discussions with several developers

Re: [PATCH net-next] bpf: expose sk_priority through struct bpf_sock_ops

2017-11-10 Thread Alexei Starovoitov
On 11/11/17 6:07 AM, Daniel Borkmann wrote: On 11/10/2017 08:17 PM, Vlad Dumitrescu wrote: From: Vlad Dumitrescu Allows BPF_PROG_TYPE_SOCK_OPS programs to read sk_priority. Signed-off-by: Vlad Dumitrescu --- include/uapi/linux/bpf.h | 1 +

Re: [PATCH net-next V4 0/3] tools: bpftool: show filenames of pinned objects

2017-11-10 Thread David Miller
From: Prashant Bhole Date: Wed, 8 Nov 2017 13:55:46 +0900 > This patchset adds support to show pinned objects in object details. > > Patch1 adds a funtionality to open a path in bpf-fs regardless of its object > type. > > Patch2 adds actual functionality by

Re: [PATCH] tcp: Export to userspace the TCP state names for the trace events

2017-11-10 Thread Steven Rostedt
On Sat, 11 Nov 2017 02:06:00 + Yafang Shao wrote: > 2017-11-10 15:07 GMT+00:00 Steven Rostedt : > > On Fri, 10 Nov 2017 12:56:06 +0800 > > Yafang Shao wrote: > > > >> Could the macro tcp_state_name() be renamed ? > >> If is

Re: [PATCH 1/1] bnx2x: fix slowpath null crash

2017-11-10 Thread David Miller
From: Zhu Yanjun Date: Tue, 7 Nov 2017 21:56:21 -0500 > + /*When ret value shows failure of allocation failure, > + *the nic is rebooted again. If open still fails, a error > + *message to notify the user. > + */ Please

Re: [PATCH 0/2][v5] Add the ability to do BPF directed error injection

2017-11-10 Thread David Miller
From: Josef Bacik Date: Tue, 7 Nov 2017 15:28:41 -0500 > I'm sending this through Dave since it'll conflict with other BPF changes in > his > tree, but since it touches tracing as well Dave would like a review from > somebody on the tracing side. ... > A lot of our error

Re: [PATCH v4] af_netlink: ensure that NLMSG_DONE never fails in dumps

2017-11-10 Thread Jason A. Donenfeld
On Sat, Nov 11, 2017 at 11:37 AM, David Miller wrote: > Jason I'm already pushing my luck as-is with the pull request I made > yesterday. > > I've seen your original requst to get this in, you don't have to say > it multiple times. > > We can get this into the merge window

Re: [PATCH v4] af_netlink: ensure that NLMSG_DONE never fails in dumps

2017-11-10 Thread David Miller
From: "Jason A. Donenfeld" Date: Sat, 11 Nov 2017 11:26:12 +0900 > IIRC, 4.14 comes tomorrow-ish? If possible, it would be nice to get > this in 4.14 before then, so it doesn't have to take time to trickle > down through stable. Jason I'm already pushing my luck as-is with the

Re: [PATCH v4] af_netlink: ensure that NLMSG_DONE never fails in dumps

2017-11-10 Thread Jason A. Donenfeld
IIRC, 4.14 comes tomorrow-ish? If possible, it would be nice to get this in 4.14 before then, so it doesn't have to take time to trickle down through stable. Jason On Thu, Nov 9, 2017 at 1:04 PM, Jason A. Donenfeld wrote: > The way people generally use netlink_dump is that they

Hello Friend

2017-11-10 Thread Wang Jianlin
I intend to give you a portion of my wealth as a free-will financial donation to you, Respond to partake. Wang Jianlin Wanda Group

[PATCH net-next 1/1] forcedeth: remove redudant assignments in xmit

2017-11-10 Thread Zhu Yanjun
In xmit process, the variables are set many times. In fact, it is enough for these variables to be set once. After a long time test, the throughput performance is better than before. CC: Srinivas Eeda CC: Joe Jin CC: Junxiao Bi

Re: [PATCH] tcp: Export to userspace the TCP state names for the trace events

2017-11-10 Thread Yafang Shao
2017-11-10 15:07 GMT+00:00 Steven Rostedt : > On Fri, 10 Nov 2017 12:56:06 +0800 > Yafang Shao wrote: > >> Could the macro tcp_state_name() be renamed ? >> If is included in include/net/tcp.h, it will > > Ideally, you don't want to include

Re: [net-next v5 0/4] Openvswitch meter action

2017-11-10 Thread Pravin Shelar
On Sat, Nov 11, 2017 at 1:39 AM, Andy Zhou wrote: > This patch series is the first attempt to add openvswitch > meter support. We have previously experimented with adding > metering support in nftables. However 1) It was not clear > how to expose a named nftables object cleanly,

Re: ​​Assalam Alaikum

2017-11-10 Thread Eiman Yousef M A Al-muzafar
Assalam Alaikum, I am Eiman Yousef M A Al-muzafar, a Muslim woman from Qatar, I am contacting you regarding a relationship of trust and confidence for an inheritance. Please contact me on my private email for more details: eimanyou...@hotmail.com

[GIT] [4.15] NFC update

2017-11-10 Thread Samuel Ortiz
Hi David, This is the NFC pull request for 4.15. We have: - A new netlink command for explicitly deactivating NFC targets - i2c constification for all NFC drivers - One NFC device allocation error path fix The following changes since commit 2798b80b385384d51a81832556ee9ad25d175f9b: Merge

Re: [PATCH net-next 1/4] net: dsa: Pass a port to get_tag_protocol()

2017-11-10 Thread Vivien Didelot
Florian Fainelli writes: > A number of drivers want to check whether the configured CPU port is a > possible configuration for enabling tagging, pass down the CPU port > number so they verify that. > > Signed-off-by: Florian Fainelli Reviewed-by:

Re: [PATCH v2 5/6] firmware: Add request_firmware_prefer_user() function

2017-11-10 Thread Luis R. Rodriguez
On Fri, Nov 10, 2017 at 10:08:19PM +0100, Pali Rohár wrote: > On Friday 10 November 2017 21:26:01 Luis R. Rodriguez wrote: > > On Fri, Nov 10, 2017 at 12:38:27AM +0100, Pali Rohár wrote: > > > This function works pretty much like request_firmware(), but it prefer > > > usermode helper. If usermode

[PATCH net-next 3/4] net: dsa: Support prepended Broadcom tag

2017-11-10 Thread Florian Fainelli
Add a new type: DSA_TAG_PROTO_PREPEND which allows us to support for the 4-bytes Broadcom tag that we already support, but in a format where it is pre-pended to the packet instead of located between the MAC SA and the Ethertyper (DSA_TAG_PROTO_BRCM). Signed-off-by: Florian Fainelli

[PATCH net-next 1/4] net: dsa: Pass a port to get_tag_protocol()

2017-11-10 Thread Florian Fainelli
A number of drivers want to check whether the configured CPU port is a possible configuration for enabling tagging, pass down the CPU port number so they verify that. Signed-off-by: Florian Fainelli --- drivers/net/dsa/b53/b53_common.c | 32

[PATCH net-next 4/4] net: dsa: b53: Support prepended Broadcom tags

2017-11-10 Thread Florian Fainelli
On BCM58xx devices (Northstar Plus), there is an accelerator attached to port 8 which would only work if we use prepended Broadcom tags. Resolve that difference in our get_tag_protocol() function by setting the appropriate tagging protocol in that case. We need to change b53_brcm_hdr_setup() a

[PATCH net-next 0/4] net: dsa: b53: Support prepended Broadcom tags

2017-11-10 Thread Florian Fainelli
Hi all, This patch series adds support for prepended 4-bytes Broadcom tags that we already support. This type of tag will typically be used when interfaced to a SoC like BCM58xx (NorthStar Plus) which supports a Flow Accelerator (WIP). In that case, we need to support a slightly different tagging

[PATCH net-next 2/4] net: dsa: tag_brcm: Prepare for supporting prepended tag

2017-11-10 Thread Florian Fainelli
In preparation for supporting the same Broadcom tag format, but instead of inserted between the MAC SA and EtherType, prepended to the Ethernet frame, restructure the code a little bit to make that possible and take an offset parameter. Signed-off-by: Florian Fainelli ---

[patch 1/1] net/sched/sch_red.c: work around gcc-4.4.4 anon union initializer issue

2017-11-10 Thread akpm
From: Andrew Morton Subject: net/sched/sch_red.c: work around gcc-4.4.4 anon union initializer issue gcc-4.4.4 (at lest) has issues with initializers and anonymous unions: net/sched/sch_red.c: In function 'red_dump_offload': net/sched/sch_red.c:282: error: unknown

[PATCH iproute2] man: Clarify idleslope calculation for tc-cbs

2017-11-10 Thread Jesus Sanchez-Palencia
In order to calculate the idleSlope parameter of CBS correctly, users must take into account the entire packet size, including the overhead from all layers. Add some more details to the man page to clarify that, giving one simple example and pointing users to the correct 802.1Q section for

Re: [kernel-hardening] [PATCH v4] scripts: add leaking_addresses.pl

2017-11-10 Thread Frank Rowand
Hi Michael, Tobin, On 11/08/17 04:10, Michael Ellerman wrote: > "Tobin C. Harding" writes: >> Currently we are leaking addresses from the kernel to user space. This >> script is an attempt to find some of those leakages. Script parses >> `dmesg` output and /proc and /sys files for

[PATCH] net: Remove unused skb_shared_info member

2017-11-10 Thread Mat Martineau
ip6_frag_id was only used by UFO, which has been removed. ipv6_proxy_select_ident() only existed to set ip6_frag_id and has no in-tree callers. Signed-off-by: Mat Martineau --- include/linux/skbuff.h | 1 - include/net/ipv6.h | 1 -

Re: [run_timer_softirq] BUG: unable to handle kernel paging request at 0000000000010007

2017-11-10 Thread Thomas Gleixner
On Fri, 10 Nov 2017, Linus Torvalds wrote: > On Wed, Nov 8, 2017 at 9:19 PM, Fengguang Wu wrote: > > > > Yes it's accessing the list. Here is the faddr2line output. > > Ok, so it's a corrupted timer list. Which is not a big surprise. > > It's > >

Re: [PATCH 1/8] dt-bindings: can: rcar_can: document r8a774[35] can support

2017-11-10 Thread Rob Herring
On Tue, Nov 07, 2017 at 03:10:42PM +, Fabrizio Castro wrote: > Document "renesas,can-r8a7743" and "renesas,can-r8a7745" compatible > strings. Since the fallback compatible string ("renesas,rcar-gen2-can") > activates the right code in the driver, no driver change is needed. > > Signed-off-by:

Re: [PATCH net-next 1/6] bpf: Fix tcp_synrto_kern.c sample program

2017-11-10 Thread Daniel Borkmann
On 11/10/2017 09:42 PM, Lawrence Brakmo wrote: The program was returning -1 in some cases which is not allowed by the verifier any longer. Fixes: 8550f328f45d ("bpf: Support for per connection SYN/SYN-ACK RTOs") Hmm, for most of the series (if not all), I think Fixes tag is: 390ee7e29fc8

Re: [PATCH v2 5/6] firmware: Add request_firmware_prefer_user() function

2017-11-10 Thread Pali Rohár
On Friday 10 November 2017 21:26:01 Luis R. Rodriguez wrote: > On Fri, Nov 10, 2017 at 12:38:27AM +0100, Pali Rohár wrote: > > This function works pretty much like request_firmware(), but it prefer > > usermode helper. If usermode helper fails then it fallback to direct > > access. Useful for

Re: [PATCH net-next] bpf: expose sk_priority through struct bpf_sock_ops

2017-11-10 Thread Daniel Borkmann
On 11/10/2017 08:17 PM, Vlad Dumitrescu wrote: From: Vlad Dumitrescu Allows BPF_PROG_TYPE_SOCK_OPS programs to read sk_priority. Signed-off-by: Vlad Dumitrescu --- include/uapi/linux/bpf.h | 1 + net/core/filter.c | 11 +++

[PATCH net-next 2/3] l2tp: avoid using ->tunnel_sock for getting session's parent tunnel

2017-11-10 Thread Guillaume Nault
Sessions don't need to use l2tp_sock_to_tunnel(xxx->tunnel_sock) for accessing their parent tunnel. They have the .tunnel field in the l2tp_session structure for that. Furthermore, in all these cases, the session is registered, so we're guaranteed that .tunnel isn't NULL and that the session

[PATCH net-next 0/3] l2tp: avoid aliasing tunnels socket pointer

2017-11-10 Thread Guillaume Nault
We don't need to copy the tunnel's socket pointer in the pseudo-wire specific session structures. This uselessly complicates the code and hampers evolution. This series was part of an effort to protect tunnels socket pointer with RCU. But since it provides nice cleanup, I submit it separately.

[PATCH net-next 3/3] l2tp: remove the .tunnel_sock field from struct pppol2tp_session

2017-11-10 Thread Guillaume Nault
The last user of .tunnel_sock is pppol2tp_connect() which defensively uses it to verify internal data consistency. This check isn't necessary: l2tp_session_get() guarantees that the returned session belongs to the tunnel passed as parameter. And .tunnel_sock is never updated, so checking that it

[PATCH net-next 1/3] l2tp: remove .tunnel_sock from struct l2tp_eth

2017-11-10 Thread Guillaume Nault
This field has never been used. Signed-off-by: Guillaume Nault --- net/l2tp/l2tp_eth.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/net/l2tp/l2tp_eth.c b/net/l2tp/l2tp_eth.c index 3e2dec1fb0f5..5c366ecfa1cb 100644 --- a/net/l2tp/l2tp_eth.c +++ b/net/l2tp/l2tp_eth.c

[PATCH net-next 6/6] bpf: Fix tcp_clamp_kern.c sample program

2017-11-10 Thread Lawrence Brakmo
The program was returning -1 in some cases which is not allowed by the verifier any longer. Fixes: 6c4a01b27852 ("bpf: Sample bpf program to set sndcwnd clamp") Signed-off-by: Lawrence Brakmo --- samples/bpf/tcp_clamp_kern.c | 24 +--- 1 file changed, 13

[PATCH net-next 3/6] bpf: Fix tcp_bufs_kern.c sample program

2017-11-10 Thread Lawrence Brakmo
The program was returning -1 in some cases which is not allowed by the verifier any longer. Fixes: d9925368a641 ("bpf: Sample BPF program to set buffer sizes") Signed-off-by: Lawrence Brakmo --- samples/bpf/tcp_bufs_kern.c | 14 -- 1 file changed, 8 insertions(+), 6

[PATCH net-next 4/6] bpf: Fix tcp_cong_kern.c sample program

2017-11-10 Thread Lawrence Brakmo
The program was returning -1 in some cases which is not allowed by the verifier any longer. Fixes: bb56d4449d8b ("bpf: Sample BPF program to set congestion control") Signed-off-by: Lawrence Brakmo --- samples/bpf/tcp_cong_kern.c | 6 -- 1 file changed, 4 insertions(+), 2

[PATCH net-next 5/6] bpf: Fix tcp_iw_kern.c sample program

2017-11-10 Thread Lawrence Brakmo
The program was returning -1 in some cases which is not allowed by the verifier any longer. Fixes: 7bc62e285479 ("bpf: Sample BPF program to set initial cwnd") Signed-off-by: Lawrence Brakmo --- samples/bpf/tcp_iw_kern.c | 14 -- 1 file changed, 8 insertions(+), 6

[PATCH net-next 2/6] bpf: Fix tcp_rwnd_kern.c sample program

2017-11-10 Thread Lawrence Brakmo
The program was returning -1 in some cases which is not allowed by the verifier any longer. Fixes: c400296bf63d ("bpf: Sample bpf program to set initial window") Signed-off-by: Lawrence Brakmo --- samples/bpf/tcp_rwnd_kern.c | 6 -- 1 file changed, 4 insertions(+), 2

[PATCH net-next 1/6] bpf: Fix tcp_synrto_kern.c sample program

2017-11-10 Thread Lawrence Brakmo
The program was returning -1 in some cases which is not allowed by the verifier any longer. Fixes: 8550f328f45d ("bpf: Support for per connection SYN/SYN-ACK RTOs") Signed-off-by: Lawrence Brakmo --- samples/bpf/tcp_synrto_kern.c | 6 -- 1 file changed, 4 insertions(+), 2

[PATCH net-next 0/6] bpf: Fix bugs in sock_ops samples In-Reply-To:

2017-11-10 Thread Lawrence Brakmo
The programs were returning -1 in some cases when they should only return 0 or 1. Changes in the verifier now catch this issue and the programs fail to load. This is now fixed. [PATCH net-next 1/6] bpf: Fix tcp_synrto_kern.c sample program [PATCH net-next 2/6] bpf: Fix tcp_rwnd_kern.c sample

Re: [PATCH net-next v3 3/3] net: dsa: b53: Turn on Broadcom tags

2017-11-10 Thread Andrew Lunn
On Fri, Nov 10, 2017 at 11:33:27AM -0800, Florian Fainelli wrote: > Enable Broadcom tags for b53 devices, except 5325 and 5365 which use a > different Broadcom tag format not yet supported by net/dsa/tag_brcm.c. > > We also make sure that we can turn on Broadcom tags on a CPU port number > that

Re: [PATCH net-next v3 2/3] net: dsa: b53: Stop using dev->cpu_port incorrectly

2017-11-10 Thread Andrew Lunn
On Fri, Nov 10, 2017 at 11:33:26AM -0800, Florian Fainelli wrote: > dev->cpu_port is the driver local information that should only be used > to look up register offsets for a particular port, when they differ > (e.g: IMP port override), but it should certainly not be used in place > of the DSA

Re: [PATCH net-next v3 1/3] net: bgmac: Pad packets to a minimum size

2017-11-10 Thread Andrew Lunn
On Fri, Nov 10, 2017 at 11:33:25AM -0800, Florian Fainelli wrote: > In preparation for enabling Broadcom tags with b53, pad packets to a > minimum size of 64 bytes (sans FCS) in order for the Broadcom switch to > accept ingressing frames. Without this, we would typically be able to > DHCP, but not

Re: [PATCH v2 5/6] firmware: Add request_firmware_prefer_user() function

2017-11-10 Thread Luis R. Rodriguez
On Fri, Nov 10, 2017 at 12:26 PM, Luis R. Rodriguez wrote: > even if you *leave* the flag in place and a driver required > this, but the kernel was compiled without CONFIG_FW_LOADER_USER_HELPER then > calling fw_load_from_user_helper would just already return -ENOENT, as such

Re: [PATCH v2 5/6] firmware: Add request_firmware_prefer_user() function

2017-11-10 Thread Luis R. Rodriguez
On Fri, Nov 10, 2017 at 12:38:27AM +0100, Pali Rohár wrote: > This function works pretty much like request_firmware(), but it prefer > usermode helper. If usermode helper fails then it fallback to direct > access. Useful for dynamic or model specific firmware data. > > Signed-off-by: Pali Rohár

Re:Partnership Request.

2017-11-10 Thread Albrecht Lutz
Good day My name is Lutz Albrecht, an attorney, I have searched for several years to locate any possible relative of a late client of mine who died intestate but left a huge financial estate. I am contacting you because you have the same last name to present you as the beneficiary of the

[net-next v5 4/4] openvswitch: Add meter action support

2017-11-10 Thread Andy Zhou
Implements OVS kernel meter action support. Signed-off-by: Andy Zhou --- include/uapi/linux/openvswitch.h | 3 +++ net/openvswitch/actions.c| 6 ++ net/openvswitch/datapath.h | 1 + net/openvswitch/flow_netlink.c | 6 ++ 4 files changed, 16 insertions(+)

[net-next v5 3/4] openvswitch: Add meter infrastructure

2017-11-10 Thread Andy Zhou
OVS kernel datapath so far does not support Openflow meter action. This is the first stab at adding kernel datapath meter support. This implementation supports only drop band type. Signed-off-by: Andy Zhou --- net/openvswitch/Makefile | 1 + net/openvswitch/datapath.c | 14

[net-next v5 2/4] openvswitch: export get_dp() API.

2017-11-10 Thread Andy Zhou
Later patches will invoke get_dp() outside of datapath.c. Export it. Signed-off-by: Andy Zhou --- net/openvswitch/datapath.c | 29 - net/openvswitch/datapath.h | 31 +++ 2 files changed, 31 insertions(+), 29 deletions(-)

[net-next v5 0/4] Openvswitch meter action

2017-11-10 Thread Andy Zhou
This patch series is the first attempt to add openvswitch meter support. We have previously experimented with adding metering support in nftables. However 1) It was not clear how to expose a named nftables object cleanly, and 2) the logic that implements metering is quite small, < 100 lines of

[net-next v5 1/4] openvswitch: Add meter netlink definitions

2017-11-10 Thread Andy Zhou
Meter has its own netlink family. Define netlink messages and attributes for communicating with the user space programs. Signed-off-by: Andy Zhou --- include/uapi/linux/openvswitch.h | 51 1 file changed, 51 insertions(+) diff --git

Re: [run_timer_softirq] BUG: unable to handle kernel paging request at 0000000000010007

2017-11-10 Thread Linus Torvalds
On Wed, Nov 8, 2017 at 9:19 PM, Fengguang Wu wrote: > > Yes it's accessing the list. Here is the faddr2line output. Ok, so it's a corrupted timer list. Which is not a big surprise. It's next->pprev = pprev; in __hlist_del(), and the trapping instruction

Re: [Patch net] vlan: fix a use-after-free in vlan_device_event()

2017-11-10 Thread Linus Torvalds
On Fri, Nov 10, 2017 at 3:50 AM, Fengguang Wu wrote: > It works, thank you for fixing this ancient bug! > > Tested-by: Fengguang Wu Thanks for all the 0day work to make people finally figure this out. Linus

Re: [PATCH iproute2 2/2] devlink: add batch command support

2017-11-10 Thread Leon Romanovsky
On Fri, Nov 10, 2017 at 08:10:43AM +0100, Ivan Vecera wrote: > On 10.11.2017 07:57, Leon Romanovsky wrote: > > On Fri, Nov 10, 2017 at 07:20:14AM +0100, Ivan Vecera wrote: > >> The patch adds support to batch devlink commands. > >> > >> Cc: Jiri Pirko > >> Cc: Arkadi

[PATCH net-next v3 2/3] net: dsa: b53: Stop using dev->cpu_port incorrectly

2017-11-10 Thread Florian Fainelli
dev->cpu_port is the driver local information that should only be used to look up register offsets for a particular port, when they differ (e.g: IMP port override), but it should certainly not be used in place of the DSA configured CPU port. Since the DSA switch layer calls port_vlan_{add,del}()

[PATCH net-next v3 3/3] net: dsa: b53: Turn on Broadcom tags

2017-11-10 Thread Florian Fainelli
Enable Broadcom tags for b53 devices, except 5325 and 5365 which use a different Broadcom tag format not yet supported by net/dsa/tag_brcm.c. We also make sure that we can turn on Broadcom tags on a CPU port number that is capable of that: 5, 7 or 8. Signed-off-by: Florian Fainelli

[PATCH net-next v3 0/3] net: dsa: b53: Turn on Broadcom tags

2017-11-10 Thread Florian Fainelli
Hi all, This was long overdue, with this patch series, the b53 driver now turns on Broadcom tags except for 5325 and 5365 which use an older format that we do not support yet (TBD). First patch is necessary in order for bgmac, used on BCM5301X and Northstar Plus to work correctly and

[PATCH net-next v3 1/3] net: bgmac: Pad packets to a minimum size

2017-11-10 Thread Florian Fainelli
In preparation for enabling Broadcom tags with b53, pad packets to a minimum size of 64 bytes (sans FCS) in order for the Broadcom switch to accept ingressing frames. Without this, we would typically be able to DHCP, but not resolve with ARP because packets are too small and get rejected by the

[PATCH net-next v1] xen-netback: make copy batch size configurable

2017-11-10 Thread Joao Martins
Commit eb1723a29b9a ("xen-netback: refactor guest rx") refactored Rx handling and as a result decreased max grant copy ops from 4352 to 64. Before this commit it would drain the rx_queue (while there are enough slots in the ring to put packets) then copy to all pages and write responses on the

Re: Secure Server Message

2017-11-10 Thread Webmail Internet Service
Warning!!! Account Owner Upgrade is needed by our member use due to network error, Your email was detected by Unknown IP Address 712.54.5.837 and We discovered something unusual about your email account in our computer date-base System. For Security reasons to enable automatic clean up to

[PATCH net-next] bpf: expose sk_priority through struct bpf_sock_ops

2017-11-10 Thread Vlad Dumitrescu
From: Vlad Dumitrescu Allows BPF_PROG_TYPE_SOCK_OPS programs to read sk_priority. Signed-off-by: Vlad Dumitrescu --- include/uapi/linux/bpf.h | 1 + net/core/filter.c | 11 +++ tools/include/uapi/linux/bpf.h | 1 + 3 files

Re: [PATCH] [net-next,v3] ibmvnic: Feature implementation of Vital Product Data (VPD) for the ibmvnic driver

2017-11-10 Thread Desnes Augusto Nunes do Rosário
On 11/10/2017 12:54 PM, Nathan Fontenot wrote: On 11/10/2017 08:41 AM, Desnes Augusto Nunes do Rosário wrote: On 11/09/2017 06:31 PM, Nathan Fontenot wrote: On 11/09/2017 01:00 PM, Desnes Augusto Nunes do Rosario wrote: This patch implements and enables VDP support for the ibmvnic driver.

Re: KASAN: use-after-free Read in worker_thread (2)

2017-11-10 Thread Cong Wang
On Wed, Nov 8, 2017 at 5:00 AM, Dmitry Vyukov wrote: > On Wed, Nov 8, 2017 at 1:58 PM, syzbot > > wrote: >> Hello, >> >> syzkaller hit the following crash on >> 7dfaa7bc99498da1c6c4a48bee8d2d5265161a8c >>

Re: [net-next v4 4/4] openvswitch: Add meter action support

2017-11-10 Thread Andy Zhou
On Thu, Nov 9, 2017 at 12:50 AM, Pravin Shelar wrote: > On Thu, Nov 9, 2017 at 11:00 AM, Andy Zhou wrote: >> Implements OVS kernel meter action support. >> >> Signed-off-by: Andy Zhou >> --- > I could not apply this patch on latest net-next. I will

  1   2   >