Re: kernel BUG at crypto/asymmetric_keys/public_key.c:80

On Thu, 2017-11-23 at 09:47 -0800, Florian Fainelli wrote: > Absolutely, please find it enclosed. Thanks. This is a bit odd. I didn't think the most likely reason is that you have CONFIG_CRYPTO_SHA256=m but everything else built-in. Thus, when loading the certificate, there's no way to

Re: [RFC net-next 4/6] netdevsim: add software driver for testing offloads

On Thu, Nov 23, 2017 at 11:24 PM, Jiri Pirko wrote: > Fri, Nov 24, 2017 at 03:36:11AM CET, jakub.kicin...@netronome.com wrote: >>To be able to run selftests without any hardware required we >>need a software model. The model can also serve as an example >>implementation for

Re: [RFC net-next 0/6] xdp: make stack perform remove and tests

Fri, Nov 24, 2017 at 03:36:07AM CET, jakub.kicin...@netronome.com wrote: >Hi! > >The purpose of this series is to add a software model of BPF offloads >to make it easier for everyone to test them and make some of the more >arcane rules and assumptions more clear. > >The series starts with 3

Re: [RFC net-next 4/6] netdevsim: add software driver for testing offloads

Fri, Nov 24, 2017 at 03:36:11AM CET, jakub.kicin...@netronome.com wrote: >To be able to run selftests without any hardware required we >need a software model. The model can also serve as an example >implementation for those implementing actual HW offloads. >The dummy driver have previously been

Re: [PATCH 1/6] perf: Add new type PERF_TYPE_PROBE

On 11/23/17 2:02 AM, Peter Zijlstra wrote: On Wed, Nov 15, 2017 at 09:23:33AM -0800, Song Liu wrote: Note: We use type __u64 for pointer probe_desc instead of __aligned_u64. The reason here is to avoid changing the size of struct perf_event_attr, and breaking new-kernel-old-utility scenario.

Re: [PATCH] net-sysfs: export gso_max_size attribute

On Wed, 22 Nov 2017 16:30:41 -0800 Solio Sarabia wrote: > The netdevice gso_max_size is exposed to allow users fine-control on > systems with multiple NICs with different GSO buffer sizes, and where > the virtual devices like bridge and veth, need to be aware of the GSO

Re: [PATCH iproute2/master] bpf: initialize the verifier log

On Wed, 22 Nov 2017 17:00:53 -0800 Jakub Kicinski wrote: > If program loading fails before verifier prints its first > message, the verifier log will not be initialized. Always > set the first character of the log buffer to zero to make > sure we don't dump

Re: [PATCH] r8152: disable rx checksum offload on Dell TB dock

> On 23 Nov 2017, at 5:24 PM, Greg KH wrote: > > On Thu, Nov 23, 2017 at 04:53:41PM +0800, Kai Heng Feng wrote: >> >> What I want to do here is to finding this connection: >> Realtek r8153 <-> SMSC hub (USD ID: 0424:5537) <-> >> ASMedia XHCI controller (PCI ID:

[RFC net-next 1/6] net: xdp: avoid output parameters when querying XDP prog

The output parameters will get unwieldy if we want to add more information about the program. Simply pass the entire struct netdev_bpf in. Signed-off-by: Jakub Kicinski Reviewed-by: Simon Horman --- include/linux/netdevice.h | 3 ++-

[RFC net-next 0/6] xdp: make stack perform remove and tests

Hi! The purpose of this series is to add a software model of BPF offloads to make it easier for everyone to test them and make some of the more arcane rules and assumptions more clear. The series starts with 3 patches aiming to make XDP handling in the drivers less error prone. Currently driver

[RFC net-next 6/6] selftests/bpf: add offload test based on netdevsim

Add a test of BPF offload control path interfaces based on just-added netdevsim driver. Perform various checks of both the stack and the expected driver behaviour. Signed-off-by: Jakub Kicinski Reviewed-by: Simon Horman ---

[RFC net-next 2/6] net: xdp: report flags program was installed with on query

Some drivers enforce that flags on program replacement and removal must match the flags passed on install. This leaves the possibility open to enable simultaneous loading of XDP programs both to HW and DRV. Allow such drivers to report the flags back to the stack. Signed-off-by: Jakub Kicinski

[RFC net-next 4/6] netdevsim: add software driver for testing offloads

To be able to run selftests without any hardware required we need a software model. The model can also serve as an example implementation for those implementing actual HW offloads. The dummy driver have previously been extended to test SR-IOV, but the general consensus seems to be against adding

[RFC net-next 3/6] net: xdp: make the stack take care of the tear down

Since day one of XDP drivers had to remember to free the program on the remove path. This leads to code duplication and is error prone. Make the stack query the installed programs on unregister and if something is installed, remove the program. Because the remove will now be called before

[RFC net-next 5/6] netdevsim: add bpf offload support

Add support for loading programs for netdevsim devices and expose the related information via DebugFS. Both offload of XDP and cls_bpf programs is supported. Signed-off-by: Jakub Kicinski Reviewed-by: Simon Horman ---

Re: [PATCH] dsa: dsa2: fix compile error for !CONFIG_OF

On Thu, Nov 23, 2017 at 08:27:48PM +0100, Arend Van Spriel wrote: > + Arnd > > On Thu, Nov 23, 2017 at 8:12 PM, Arend Van Spriel > wrote: > > On Thu, Nov 23, 2017 at 3:04 PM, Andrew Lunn wrote: > >> On Thu, Nov 23, 2017 at 01:00:51PM +0100, Arend

[PATCH iproute2/master 04/11] bpf: split parse from program loading

Parsing command line is currently done together with potentially loading a new eBPF program. This makes it more difficult to provide additional parameters for loading (which may come after the eBPF program info on the command line). Split the two (only internally for now). Verbose parameter has

[PATCH iproute2/master 05/11] bpf: rename bpf_parse_common() to bpf_parse_and_load_common()

bpf_parse_common() parses and loads the program. Rename it accordingly. Signed-off-by: Jakub Kicinski Reviewed-by: Quentin Monnet Acked-by: Daniel Borkmann --- include/bpf_util.h| 4 ++-- ip/iplink_xdp.c

[PATCH iproute2/master 03/11] bpf: allocate opcode table in struct bpf_cfg_in

struct bpf_cfg_in already carries a pointer to sock_filter ops. It's currently set to a local variable in bpf_parse_opt_tbl(), shared between parsing and loading stages. Move the array entirely to struct bpf_cfg_in, this will allow us to split parsing and loading. Signed-off-by: Jakub Kicinski

[PATCH iproute2/master 08/11] {f,m}_bpf: don't allow specifying multiple bpf programs

Both BPF filter and action will allow users to specify run multiple times, and only the last one will be considered by the kernel. Explicitly refuse such command lines. Signed-off-by: Jakub Kicinski Reviewed-by: Quentin Monnet

[PATCH iproute2/master 11/11] iplink: communicate ifindex for xdp offload

When xdpoffload option is used, communicate the ifindex down to the kernel to trigger device-specific load. Signed-off-by: Jakub Kicinski Reviewed-by: Quentin Monnet Acked-by: Daniel Borkmann --- ip/iplink.c

[PATCH iproute2/master 00/11] bpf: pass ifindex for bpf offload

Hi! This series allows us to pass ifindex automatically when we set up TC cls_bpf or XDP offload. There is a fair bit of refactoring to separate the parse and load stages of lib/bpf.c. In case of TC the skip_sw flag may come after the program arguments (e.g. "bpf obj prog.o da skip_sw"), so we

[PATCH iproute2/master 01/11] bpf: pass program type in struct bpf_cfg_in

Program type is needed both for parsing and loading of the program. Parsing may also induce the type based on signatures from __bpf_prog_meta. Instead of passing the type around keep it in struct bpf_cfg_in. Signed-off-by: Jakub Kicinski Reviewed-by: Quentin

[PATCH iproute2/master 10/11] f_bpf: communicate ifindex for eBPF offload

Split parsing and loading of the eBPF program and if skip_sw is set load the program for ifindex, to which the qdisc is attached. Note that the ifindex will be ignored for programs which are already loaded (e.g. when using pinned programs), but in that case we just trust the user knows what he's

[PATCH iproute2/master 06/11] bpf: expose bpf_parse_common() and bpf_load_common()

Expose bpf_parse_common() and bpf_load_common() functions for those users who may want to modify the parameters to load after parsing is done. Signed-off-by: Jakub Kicinski Reviewed-by: Quentin Monnet Acked-by: Daniel Borkmann

[PATCH iproute2/master 07/11] bpf: allow loading programs for a specific ifindex

For BPF offload we need to specify the ifindex when program is loaded now. Extend the bpf common code to accommodate that. Signed-off-by: Jakub Kicinski Reviewed-by: Quentin Monnet Acked-by: Daniel Borkmann ---

[PATCH iproute2/master 02/11] bpf: keep parsed program mode in struct bpf_cfg_in

bpf_parse() will parse command line arguments to find out the program mode. This mode will later be needed at loading time. Instead of keeping it locally add it to struct bpf_cfg_in, this will allow splitting parsing and loading stages. enum bpf_mode has to be moved to the header file, because C

[PATCH iproute2/master 09/11] tc_filter: resolve device name before parsing filter

Move resolving device name into an ifindex before calling filter specific callbacks. This way if filters need the ifindex, they can read it from the request. Signed-off-by: Jakub Kicinski Reviewed-by: Quentin Monnet Acked-by: Daniel

Re: [PATCH] net: usb: hso.c: remove unneeded DRIVER_LICENSE #define

On Thu, 2017-11-23 at 15:30 -0800, Joe Perches wrote: > --- /dev/null 2017-11-23 06:19:12.943046739 -0800 > +++ single_use_module.pl 2017-11-23 15:23:11.729812156 -0800 > @@ -0,0 +1,15 @@ [] > +$data =~ s~$var~$string~; this needs to be: $data =~ s~\b$var\b~$string~;

Re: [PATCH] net: usb: hso.c: remove unneeded DRIVER_LICENSE #define

On Wed, 2017-11-22 at 18:12 +0100, Greg Kroah-Hartman wrote: > On Wed, Nov 22, 2017 at 09:05:36AM -0800, Joe Perches wrote: > > On Fri, 2017-11-17 at 15:19 +0100, Greg Kroah-Hartman wrote: > > > There is no need to #define the license of the driver, just put it in > > > the MODULE_LICENSE() line

Re: [PATCH net] net: qmi_wwan: add support for Cinterion PLS8

On Thu, Nov 23, 2017 at 07:15:37PM +0100, Bjørn Mork wrote: > Oliver Graute writes: > > On 23/11/17, Bjørn Mork wrote: > >> Oliver Graute writes: > >> > >> > When the PLS8 devices show up with PID 0x0061 they will expose both a > >> >

Re: [PATCH] net-sysfs: export gso_max_size attribute

On Wed, Nov 22, 2017 at 04:30:41PM -0800, Solio Sarabia wrote: > The netdevice gso_max_size is exposed to allow users fine-control on > systems with multiple NICs with different GSO buffer sizes, and where > the virtual devices like bridge and veth, need to be aware of the GSO > size of the

Re: [PATCH iproute2 1/1] actions: Add support for user cookies

On Sat, 22 Apr 2017 08:36:23 -0400 Jamal Hadi Salim wrote: > + > fprintf(f, "\tAction statistics:\n"); > print_tcstats2_attr(f, tb[TCA_ACT_STATS], "\t", NULL); > + if (tb[TCA_ACT_COOKIE]) { > + int strsz =

Re: [PATCH iproute2 1/1] actions: Add support for user cookies

On Sat, 22 Apr 2017 08:36:23 -0400 Jamal Hadi Salim wrote: > + > + if (*argv && strcmp(*argv, "cookie") == 0) { > + size_t slen; > + > + NEXT_ARG(); > + slen =

[PATCH v2 0/2] seq_file, Bluetooth: introduce DEFINE_SHOW_ATTRIBUTE()

Introduce a helper macro for attributes that have only ->show() defined. P.S. I have few more clean ups locally, thus it would be nice to have an immutable branch for the rest patches which would like to utilize the new macro. In v2: - introduce for all users followed by an example clean up of

[PATCH v2 1/2] seq_file: Introduce DEFINE_SHOW_ATTRIBUTE() helper macro

The DEFINE_SHOW_ATTRIBUTE() helper macro would be useful for current users, which are many of them, and for new comers to decrease code duplication. Signed-off-by: Andy Shevchenko --- include/linux/seq_file.h | 13 + 1 file changed, 13

[PATCH v2 2/2] Bluetooth: Re-use DEFINE_SHOW_ATTRIBUTE() macro

...instead of open coding file operations followed by custom ->open() callbacks per each attribute. Signed-off-by: Andy Shevchenko --- net/bluetooth/hci_debugfs.c | 193 1 file changed, 16 insertions(+), 177

[GIT] Networking

1) Fix PCI IDs of 9000 series iwlwifi devices, from Luca Coelho. 2) bpf offload bug fixes from Jakub Kicinski. 3) Fix bpf verifier to NOP out code which is dead at run time because due to branch pruning the verifier will not explore such instructions. From Alexei Starovoitov. 4) Fix

[PATCH net v3] net: thunderx: Fix TCP/UDP checksum offload for IPv6 pkts

From: Sunil Goutham Don't offload IP header checksum to NIC. This fixes a previous patch which enabled checksum offloading for both IPv4 and IPv6 packets. So L3 checksum offload was getting enabled for IPv6 pkts. And HW is dropping these pkts as it assumes the pkt is IPv4

[PATCH net v3] net: thunderx: Fix TCP/UDP checksum offload for IPv6 pkts

From: Sunil Goutham Don't offload IP header checksum to NIC. This fixes a previous patch which enabled checksum offloading for both IPv4 and IPv6 packets. So L3 checksum offload was getting enabled for IPv6 pkts. And HW is dropping these pkts as it assumes the pkt is IPv4

Re: [PATCH] dsa: dsa2: fix compile error for !CONFIG_OF

+ Arnd On Thu, Nov 23, 2017 at 8:12 PM, Arend Van Spriel wrote: > On Thu, Nov 23, 2017 at 3:04 PM, Andrew Lunn wrote: >> On Thu, Nov 23, 2017 at 01:00:51PM +0100, Arend van Spriel wrote: >>> Compilation fails building on x86_64 platform which does

Re: b53 tags on bpi-r1 (bcm53125)

Hi Florian, With Broadcom tags (or any type of switch tagging protocol), eth0 becomes a conduit interface and no longer a "normal" network device for applications/socket to use. This means that if you were obtaining an IP address through a DHCP client using e.g: dhclient eth0, this now needs to

Re: [PATCH] dsa: dsa2: fix compile error for !CONFIG_OF

On Thu, Nov 23, 2017 at 3:04 PM, Andrew Lunn wrote: > On Thu, Nov 23, 2017 at 01:00:51PM +0100, Arend van Spriel wrote: >> Compilation fails building on x86_64 platform which does not >> have CONFIG_OF enabled. >> >> Signed-off-by: Arend van Spriel

Re: [PATCH net v2] net: thunderx: Fix TCP/UDP checksum offload for IPv6 pkts

From: Aleksey Makarov Date: Thu, 23 Nov 2017 17:41:56 +0300 > From: Sunil Goutham > > Don't offload IP header checksum to NIC. > > This fixes a previous patch which enabled checksum offloading > for both IPv4 and IPv6 packets. So L3 checksum

Re: [PATCH net 0/2] ipvlan: Fix insufficient skb linear check

From: gfree.w...@vip.163.com Date: Thu, 23 Nov 2017 11:47:10 +0800 > From: Gao Feng > > The current ipvlan codes use pskb_may_pull to get the skb linear header in > func ipvlan_get_L3_hdr, but the size isn't enough for arp and ipv6 icmp. > So it may access the unexpected

Re: [PATCH net] geneve: only configure or fill UDP_ZERO_CSUM6_RX/TX info when CONFIG_IPV6

From: Hangbin Liu Date: Thu, 23 Nov 2017 11:27:24 +0800 > Stefano pointed that configure or show UDP_ZERO_CSUM6_RX/TX info doesn't > make sense if we haven't enabled CONFIG_IPV6. Fix it by adding > if IS_ENABLED(CONFIG_IPV6) check. > > Signed-off-by: Hangbin Liu

Re: [PATCH net] net: qmi_wwan: add support for Cinterion PLS8

Oliver Graute writes: > On 23/11/17, Bjørn Mork wrote: >> Oliver Graute writes: >> >> > When the PLS8 devices show up with PID 0x0061 they will expose both a >> > QMI port and a WWAN interface. >> >> >> Please remove the indentation. >

Re: [PATCH net v2] net: thunderx: Fix TCP/UDP checksum offload for IPv6 pkts

On Thu, 2017-11-23 at 17:41 +0300, Aleksey Makarov wrote: > From: Sunil Goutham > > Don't offload IP header checksum to NIC. > > This fixes a previous patch which enabled checksum offloading > for both IPv4 and IPv6 packets.  So L3 checksum offload was > getting enabled for

Re: [PATCH 00/11] net: ethernet: ti: cpsw/ale clean up and optimization

From: Grygorii Strashko Date: Wed, 22 Nov 2017 15:25:46 -0600 > This is set of non critical clean ups and optimizations for TI > CPSW and ALE drivers. The net-next tree is closed, please resubmit this when the net-next tree opens back up. Thank you.

Re: pull-request: wireless-drivers 2017-11-22

From: Kalle Valo Date: Wed, 22 Nov 2017 17:27:22 +0200 > here's the first pull request to net tree for 4.15. Please let me know > if there are any problems. Pulled, thanks Kalle!

Re: [net 00/13][pull request] Intel Wired LAN Driver Fixes 2017-11-21

From: Jeff Kirsher Date: Wed, 22 Nov 2017 00:31:07 -0800 > This series contains fixes for igb/vf, ixgbe/vf, i40e/vf and fm10k. Pulled, thanks a lot Jeff!

Re: [PATCH iproute2 1/1] actions: Add support for user cookies

Thu, Nov 23, 2017 at 06:32:38PM CET, j...@mojatatu.com wrote: >On 17-11-23 11:36 AM, Jiri Pirko wrote: >> Sat, Apr 22, 2017 at 02:36:23PM CEST, j...@mojatatu.com wrote: >> >> [...] >> > >[..] >> >> Jamal, is there any particular reason that you print cookie only in case >> you show stats? What

Re: [PATCH net] net: dsa: bcm_sf2: Clear IDDQ_GLOBAL_PWR bit for PHY

From: Florian Fainelli Date: Tue, 21 Nov 2017 17:37:46 -0800 > The PHY on BCM7278 has an additional bit that needs to be cleared: > IDDQ_GLOBAL_PWR, without doing this, the PHY remains stuck in reset out > of suspend/resume cycles. > > Fixes: 0fe9933804eb ("net: dsa:

Re: kernel BUG at crypto/asymmetric_keys/public_key.c:80

On 11/23/2017 06:24 AM, Johannes Berg wrote: > On Wed, 2017-11-22 at 15:07 -0800, Florian Fainelli wrote: >> On 11/22/2017 10:42 AM, Johannes Berg wrote: >>> On Wed, 2017-11-22 at 19:29 +0100, Arend van Spriel wrote: + Johannes >>> BUG_ON(!sig->digest);

Re: pull-request: bpf 2017-11-23

From: Daniel Borkmann Date: Thu, 23 Nov 2017 13:01:35 +0100 > The following pull-request contains BPF updates for your *net* tree. ... > Please consider pulling these changes from: > > git://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf.git Pulled, thanks Daniel!

Re: [PATCH iproute2 1/1] actions: Add support for user cookies

On 17-11-23 11:36 AM, Jiri Pirko wrote: Sat, Apr 22, 2017 at 02:36:23PM CEST, j...@mojatatu.com wrote: [...] [..] Jamal, is there any particular reason that you print cookie only in case you show stats? What is the relation between cookie and stats? -s has been thus far used to imply

Re: [PATCH] bnxt_en: Fix an error handling path in 'bnxt_get_module_eeprom()'

From: Christophe JAILLET Date: Tue, 21 Nov 2017 20:46:49 +0100 > Error code returned by 'bnxt_read_sfp_module_eeprom_info()' is handled a > few lines above when reading the A0 portion of the EEPROM. > The same should be done when reading the A2 portion of the

Re: b53 tags on bpi-r1 (bcm53125)

Hi Jochen, On 11/23/2017 09:05 AM, Jochen Friedrich wrote: > Hi Florian, > > >> OK, because this is a 53125S, it should support Broadcom tags correctly, >> not clear yet what is happening. Just to make sure, you are using >> arch/arm/boot/dts/sun7i-a20-lamobo-r1.dts as the DTS for this

Re: b53 tags on bpi-r1 (bcm53125)

Hi Florian, OK, because this is a 53125S, it should support Broadcom tags correctly, not clear yet what is happening. Just to make sure, you are using arch/arm/boot/dts/sun7i-a20-lamobo-r1.dts as the DTS for this platform, right? Yes, that's the DTS I'm using. If so, can you provide the

Re: [PATCH net v2] net: accept UFO datagrams from tuntap and packet

From: Willem de Bruijn Date: Tue, 21 Nov 2017 10:22:25 -0500 > From: Willem de Bruijn > > Tuntap and similar devices can inject GSO packets. Accept type > VIRTIO_NET_HDR_GSO_UDP, even though not generating UFO natively. > > Processes are

Re: [RESEND PATCH] net: realtek: r8169: implement set_link_ksettings()

From: Tobias Jakobi Date: Tue, 21 Nov 2017 16:15:57 +0100 > Commit 6fa1ba61520576cf1346c4ff09a056f2950cb3bf partially > implemented the new ethtool API, by replacing get_settings() > with get_link_ksettings(). This breaks ethtool, since the > userspace tool

Re: [PATCH iproute2 1/1] actions: Add support for user cookies

Sat, Apr 22, 2017 at 02:36:23PM CEST, j...@mojatatu.com wrote: [...] >@@ -274,8 +302,17 @@ tc_print_one_action(FILE *f, struct rtattr *arg) > return err; > > if (show_stats && tb[TCA_ACT_STATS]) { >+ > fprintf(f, "\tAction statistics:\n"); >

Re: [PATCH net 0/2] net/smc: fixes for smc buffer handling

From: Ursula Braun Date: Tue, 21 Nov 2017 13:23:52 +0100 > here are 2 cleanup patches for smc buffer handling. Series applied, thanks.

Re: [PATCH net] net: ipv6: Fixup device for anycast routes during copy

From: David Ahern Date: Tue, 21 Nov 2017 07:08:57 -0800 > Florian reported a breakage with anycast routes due to commit > 4832c30d5458 ("net: ipv6: put host and anycast routes on device with > address"). Prior to this commit anycast routes were added against the > loopback

Re: [PATCH] VSOCK: Don't call vsock_stream_has_data in atomic context

From: Jorgen Hansen Date: Tue, 21 Nov 2017 02:46:24 -0800 > When using the host personality, VMCI will grab a mutex for any > queue pair access. In the detach callback for the vmci vsock > transport, we call vsock_stream_has_data while holding a spinlock, > and

Re: [PATCH v2] net: sched: fix crash when deleting secondary chains

From: Roman Kapl Date: Mon, 20 Nov 2017 22:21:13 +0100 > If you flush (delete) a filter chain other than chain 0 (such as when > deleting the device), the kernel may run into a use-after-free. The > chain refcount must not be decremented unless we are sure we are done > with the

Re: [PATCH net] ipv6: Do not consider linkdown nexthops during multipath

From: Ido Schimmel Date: Tue, 21 Nov 2017 09:50:12 +0200 > When the 'ignore_routes_with_linkdown' sysctl is set, we should not > consider linkdown nexthops during route lookup. > > While the code correctly verifies that the initially selected route > ('match') has a

Re: [PATCH] net: phy: cortina: add missing MODULE_DESCRIPTION/AUTHOR/LICENSE

From: Jesse Chan Date: Mon, 20 Nov 2017 12:57:42 -0800 > This change resolves a new compile-time warning > when built as a loadable module: > > WARNING: modpost: missing MODULE_LICENSE() in drivers/net/phy/cortina.o > see include/linux/module.h for more information > > This

[PATCH v1] brcmfmac: Avoid build error with make W=1

When I run make W=1 on gcc (Debian 7.2.0-16) 7.2.0 I got an error for the first run, all next ones are okay. CC [M] drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.o drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c:2078: error: Cannot parse struct or union!

Re: [PATCH net] net: qmi_wwan: add support for Cinterion PLS8

On 23/11/17, Bjørn Mork wrote: > Oliver Graute writes: > > > When the PLS8 devices show up with PID 0x0061 they will expose both a > > QMI port and a WWAN interface. > > > Please remove the indentation. will do after we clarifed if this patch is really needed

[PATCH net v2] net: thunderx: Fix TCP/UDP checksum offload for IPv6 pkts

From: Sunil Goutham Don't offload IP header checksum to NIC. This fixes a previous patch which enabled checksum offloading for both IPv4 and IPv6 packets. So L3 checksum offload was getting enabled for IPv6 pkts. And HW is dropping these pkts as it assumes the pkt is IPv4

Re: kernel BUG at crypto/asymmetric_keys/public_key.c:80

On Wed, 2017-11-22 at 15:07 -0800, Florian Fainelli wrote: > On 11/22/2017 10:42 AM, Johannes Berg wrote: > > On Wed, 2017-11-22 at 19:29 +0100, Arend van Spriel wrote: > > > + Johannes > > > > > > >>> BUG_ON(!sig->digest); > > > BUG_ON(!sig->s); > > > > I *think* this is the same

[PATCHv2] xen-netfront: remove warning when unloading module

v2: * Replace busy wait with wait_event()/wake_up_all() * Cannot garantee that at the time xennet_remove is called, the xen_netback state will not be XenbusStateClosed, so added a condition for that * There's a small chance for the xen_netback state is XenbusStateUnknown by the time

Re: [PATCH] dsa: dsa2: fix compile error for !CONFIG_OF

On Thu, Nov 23, 2017 at 01:00:51PM +0100, Arend van Spriel wrote: > Compilation fails building on x86_64 platform which does not > have CONFIG_OF enabled. > > Signed-off-by: Arend van Spriel > --- > After rebasing my branch to v4.14 I attempted to build the kernel

Re: [PATCH net] net: qmi_wwan: add support for Cinterion PLS8

Oliver Graute writes: > When the PLS8 devices show up with PID 0x0061 they will expose both a > QMI port and a WWAN interface. Please remove the indentation. > Signed-off-by: Oliver Graute > --- > drivers/net/usb/qmi_wwan.c | 1 + >

Re: [patch net-next RFC v2 08/11] mlxsw: spectrum_dpipe: Connect dpipe tables to resources

On 11/19/2017 05:58 PM, David Ahern wrote: > On 11/19/17 2:16 AM, Arkadi Sharshevsky wrote: >> >> >> On 11/18/2017 09:19 PM, David Ahern wrote: >>> On 11/14/17 9:18 AM, Jiri Pirko wrote: From: Arkadi Sharshevsky Connect current dpipe tables to resources. The

[PATCH net] net: qmi_wwan: add support for Cinterion PLS8

When the PLS8 devices show up with PID 0x0061 they will expose both a QMI port and a WWAN interface. Signed-off-by: Oliver Graute --- drivers/net/usb/qmi_wwan.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/usb/qmi_wwan.c

Re: [PATCH v1] Bluetooth: introduce DEFINE_SHOW_ATTRIBUTE() macro

On Wed, 2017-11-22 at 14:13 -0800, Randy Dunlap wrote: > On 11/22/2017 02:04 PM, Randy Dunlap wrote: > > On 11/22/2017 01:15 PM, Andy Shevchenko wrote: > > > This macro deduplicates a lot of similar code across the > > > hci_debugfs.c > > > module. Targeting to be moved to seq_file.h eventually >

Re: [PATCH net] geneve: only configure or fill UDP_ZERO_CSUM6_RX/TX info when CONFIG_IPV6

On Thu, Nov 23, 2017 at 01:35:26PM +0100, Stefano Brivio wrote: > On Thu, 23 Nov 2017 11:27:24 +0800 > Hangbin Liu wrote: > > > Stefano pointed that configure or show UDP_ZERO_CSUM6_RX/TX info doesn't > > make sense if we haven't enabled CONFIG_IPV6. Fix it by adding > > if

Re: [PATCH net] geneve: only configure or fill UDP_ZERO_CSUM6_RX/TX info when CONFIG_IPV6

On Thu, 23 Nov 2017 11:27:24 +0800 Hangbin Liu wrote: > Stefano pointed that configure or show UDP_ZERO_CSUM6_RX/TX info doesn't > make sense if we haven't enabled CONFIG_IPV6. Fix it by adding > if IS_ENABLED(CONFIG_IPV6) check. Thanks for fixing this. I would add:

DMA coalescing - ethtool vs. kernel

Hello, while digging through the interface between ethtool and kernel, I noticed that ethtool commit 5dd7bfbc5079 ("ethtool: Add DMA Coalescing support") added new member dmac into struct ethtool_coalesce which is part of kernel UAPI but there is no kernel counterpart to this change in master,

Re: [patch net-next RFC v2 02/11] devlink: Add support for resource abstraction

[...] + + resource = devlink_resource_find(devlink, NULL, resource_id); + if (!resource) + return -EINVAL; + + if (!resource->resource_ops->size_validate) + return -EINVAL; >>> >>> genl_info has extack; please add user messages for the above

pull-request: bpf 2017-11-23

Hi David, The following pull-request contains BPF updates for your *net* tree. The main changes are: 1) Several BPF offloading fixes, from Jakub. Among others: - Limit offload to cls_bpf and XDP program types only. - Move device validation into the driver and don't make any

[PATCH] bna: remove redundant self assignment of 'i'

From: Colin Ian King The assignment of variable i to itself is redundant and can be removed. Detected with Coccinelle. Signed-off-by: Colin Ian King --- drivers/net/ethernet/brocade/bna/bna_enet.c | 4 ++-- 1 file changed, 2 insertions(+), 2

Re: [PATCH 1/6] perf: Add new type PERF_TYPE_PROBE

On Wed, Nov 15, 2017 at 09:23:33AM -0800, Song Liu wrote: > A new perf type PERF_TYPE_PROBE is added to allow creating [k,u]probe > with perf_event_open. These [k,u]probe are associated with the file > decriptor created by perf_event_open, thus are easy to clean when > the file descriptor is

Re: [PATCH v2 net] bpf: fix branch pruning logic

On 11/23/2017 01:42 AM, Alexei Starovoitov wrote: > when the verifier detects that register contains a runtime constant > and it's compared with another constant it will prune exploration > of the branch that is guaranteed not to be taken at runtime. > This is all correct, but malicious program

Re: [PATCH 3/6] perf: implement kprobe support to PERF_TYPE_PROBE

On Wed, Nov 15, 2017 at 09:23:36AM -0800, Song Liu wrote: > +int perf_probe_init(struct perf_event *p_event) > +{ > + __aligned_u64 aligned_probe_desc; > + > + /* > + * attr.probe_desc may not be 64-bit aligned on 32-bit systems. > + * Make an aligned copy of it to before

Re: [PATCH 1/6] perf: Add new type PERF_TYPE_PROBE

On Wed, Nov 15, 2017 at 09:23:33AM -0800, Song Liu wrote: > Note: We use type __u64 for pointer probe_desc instead of __aligned_u64. > The reason here is to avoid changing the size of struct perf_event_attr, > and breaking new-kernel-old-utility scenario. To avoid alignment problem > with the

Re: [PATCH] VSOCK: Don't call vsock_stream_has_data in atomic context

On Tue, Nov 21, 2017 at 10:46 AM, Jorgen Hansen wrote: > When using the host personality, VMCI will grab a mutex for any > queue pair access. In the detach callback for the vmci vsock > transport, we call vsock_stream_has_data while holding a spinlock, > and

Re: [PATCH 0/6] enable creating [k,u]probe with perf_event_open

On Thu, Nov 23, 2017 at 01:02:00AM -0800, Christoph Hellwig wrote: > Just curious: why do you want to overload a multiplexer syscall even > more instead of adding explicit syscalls? Mostly because perf provides much of what they already want; fd-based lifetime and bpf integration.

Re: [PATCH iproute2/master] bpf: initialize the verifier log

On 11/23/2017 02:00 AM, Jakub Kicinski wrote: > If program loading fails before verifier prints its first > message, the verifier log will not be initialized. Always > set the first character of the log buffer to zero to make > sure we don't dump non-printable characters to the terminal. > >

Re: [PATCH] r8152: disable rx checksum offload on Dell TB dock

On Thu, Nov 23, 2017 at 04:53:41PM +0800, Kai Heng Feng wrote: > > > On 23 Nov 2017, at 3:58 PM, Greg KH wrote: > > > > On Thu, Nov 23, 2017 at 01:38:38AM -0500, Kai-Heng Feng wrote: > >> r8153 on Dell TB dock corrupts rx packets. > >> > >> The root cause is not

Re: [PATCH 0/6] enable creating [k,u]probe with perf_event_open

Just curious: why do you want to overload a multiplexer syscall even more instead of adding explicit syscalls?

Re: [PATCH] r8152: disable rx checksum offload on Dell TB dock

> On 23 Nov 2017, at 3:58 PM, Greg KH wrote: > > On Thu, Nov 23, 2017 at 01:38:38AM -0500, Kai-Heng Feng wrote: >> r8153 on Dell TB dock corrupts rx packets. >> >> The root cause is not found yet, but disabling rx checksumming can >> workaround the issue. We can use