Re: [PATCH v5 next 1/5] modules:capabilities: add request_module_cap()

2017-11-28 Thread Michal Kubecek
On Tue, Nov 28, 2017 at 11:48:49PM +0100, Luis R. Rodriguez wrote: > On Tue, Nov 28, 2017 at 02:18:18PM -0800, Kees Cook wrote: > > On Tue, Nov 28, 2017 at 2:12 PM, Luis R. Rodriguez > > wrote: > > > On Tue, Nov 28, 2017 at 01:39:58PM -0800, Kees Cook wrote: > > >> On Tue, Nov

Re: fec driver and two micrel phys

2017-11-28 Thread Oliver Graute
On 28/11/17, Andrew Lunn wrote: > On Tue, Nov 28, 2017 at 04:28:15PM +0100, Oliver Graute wrote: > > Hello list, > > > > I try to get two Micrel KSZ8041 Phys working with the fec driver from > > Kernel 4.14. But it looks that something with the mii_bus probing is not > > working here. I expect

Re: [PATCH v2 06/35] nds32: MMU fault handling and page table management

2017-11-28 Thread Greentime Hu
Hi, Mark: 2017-11-27 21:51 GMT+08:00 Mark Rutland : > Hi, > > On Mon, Nov 27, 2017 at 08:27:53PM +0800, Greentime Hu wrote: >> +void do_page_fault(unsigned long entry, unsigned long addr, >> +unsigned int error_code, struct pt_regs *regs) >> +{ > >> + /*

Re: [PATCH net] net: phylink: fix link state on phy-connect

2017-11-28 Thread Antoine Tenart
Hi Russell, On Tue, Nov 28, 2017 at 03:56:11PM +, Russell King wrote: > Oh, and lastly, please send patches to li...@armlinux.org.uk or the > address I use in the sign-offs - sending them to r...@armlinux.org.uk > is for personal non-Linux mail only, and has resulted in _all_ of > these

[PATCH net-next 1/2] bpf/tracing: allow user space to query prog array on the same tp

2017-11-28 Thread Yonghong Song
Commit e87c6bc3852b ("bpf: permit multiple bpf attachments for a single perf event") added support to attach multiple bpf programs to a single perf event. Commit 2541517c32be ("tracing, perf: Implement BPF programs attached to kprobes") utilized the existing perf ioctl interface and added the

[PATCH net-next 2/2] bpf/tracing: add a bpf test for new ioctl query interface

2017-11-28 Thread Yonghong Song
Added a subtest in test_progs. The tracepoint is sched/sched_switch. Multiple bpf programs are attached to this tracepoint and the query interface is exercised. Signed-off-by: Yonghong Song --- tools/include/uapi/linux/perf_event.h| 6 ++ tools/testing/selftests/bpf/Makefile

[PATCH net-next 0/2] bpf/tracing: allow user space to query prog array on the same tp

2017-11-28 Thread Yonghong Song
Commit e87c6bc3852b ("bpf: permit multiple bpf attachments for a single perf event") added support to attach multiple bpf programs to a single perf event. Given a perf event (kprobe, uprobe, or kernel tracepoint), the perf ioctl interface is used to query bpf programs attached to the same trace

where can I find netdev2.2 slides?

2017-11-28 Thread Wang Jian
Hi all, Sorry for broadcast. Just a query, where can I find netdev2.2 slides? Seems they are not uploaded to netdev websites.

Re: [5/8] crypto: remove unused hardirq.h

2017-11-28 Thread Herbert Xu
On Sat, Nov 18, 2017 at 07:02:18AM +0800, Yang Shi wrote: > Preempt counter APIs have been split out, currently, hardirq.h just > includes irq_enter/exit APIs which are not used by crypto at all. > > So, remove the unused hardirq.h. > > Signed-off-by: Yang Shi > Cc:

Re: [crypto v3 2/2] chcr: Add support for Inline IPSec

2017-11-28 Thread Herbert Xu
On Thu, Nov 16, 2017 at 04:57:08PM +0530, Atul Gupta wrote: > register xfrmdev_ops callbacks, Send IPsec tunneled data > to HW for inline processing. > The driver use hardware crypto accelerator to encrypt and > generate ICV for the transmitted packet in Inline mode. > > Signed-off-by: Atul Gupta

Re: [crypto v3 1/2] cxgb4: Add support for Inline IPSec Tx

2017-11-28 Thread Herbert Xu
On Thu, Nov 16, 2017 at 04:56:39PM +0530, Atul Gupta wrote: > Added Tx routine for ULD > - define interface for ULD Tx. > > Export routines used for Tx data > - Routines common for data transmit are used by cxgb4 and chcr > drivers. > - EXPORT routines enable transmit from chcr driver. > >

Re: [PATCH net,stable] vhost: fix skb leak in handle_rx()

2017-11-28 Thread Wei Xu
On Tue, Nov 28, 2017 at 07:53:33PM +0200, Michael S. Tsirkin wrote: > On Tue, Nov 28, 2017 at 12:17:16PM -0500, w...@redhat.com wrote: > > From: Wei Xu > > > > Matthew found a roughly 40% tcp throughput regression with commit > > c67df11f(vhost_net: try batch dequing from skb

Re: [PATCH net,stable] vhost: fix skb leak in handle_rx()

2017-11-28 Thread Wei Xu
On Tue, Nov 28, 2017 at 07:50:58PM +0200, Michael S. Tsirkin wrote: > On Tue, Nov 28, 2017 at 12:17:16PM -0500, w...@redhat.com wrote: > > From: Wei Xu > > > > Matthew found a roughly 40% tcp throughput regression with commit > > c67df11f(vhost_net: try batch dequing from skb

Re: [PATCH v2 31/35] earlycon: add reg-offset to physical address before mapping

2017-11-28 Thread Greentime Hu
2017-11-28 22:25 GMT+08:00 Greg KH : > On Mon, Nov 27, 2017 at 08:28:18PM +0800, Greentime Hu wrote: >> From: Greentime Hu >> >> It will get the wrong virtual address because port->mapbase is not added >> the correct reg-offset yet. We have to update it

Re: [PATCH net,stable] vhost: fix skb leak in handle_rx()

2017-11-28 Thread Wei Xu
On Wed, Nov 29, 2017 at 01:06:28PM +0800, Jason Wang wrote: > > > On 2017年11月29日 09:53, Jason Wang wrote: > > > > > > On 2017å¹´11月29æ—¥ 01:17, w...@redhat.com wrote: > > > From: Wei Xu > > > > > > Matthew found a roughly 40% tcp throughput regression with commit > > >

Re: [PATCH net,stable] vhost: fix skb leak in handle_rx()

2017-11-28 Thread Jason Wang
On 2017年11月29日 09:53, Jason Wang wrote: On 2017å¹´11月29æ—¥ 01:17, w...@redhat.com wrote: From: Wei Xu Matthew found a roughly 40% tcp throughput regression with commit c67df11f(vhost_net: try batch dequing from skb array) as discussed in the following thread:

[PATCH net] myri10ge: Update MAINTAINERS

2017-11-28 Thread Hyong-Youb Kim
Change the maintainer to Chris Lee who has access to Myricom hardware and can test/review. Update the website URL. Signed-off-by: Hyong-Youb Kim --- MAINTAINERS | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index

Re: [PATCH V11 4/5] vsprintf: add printk specifier %px

2017-11-28 Thread Tobin C. Harding
On Tue, Nov 28, 2017 at 06:29:02PM -0800, Linus Torvalds wrote: > On Tue, Nov 28, 2017 at 6:05 PM, Tobin C. Harding wrote: > > > >Let's add specifier %px as a > > clear, opt-in, way to print a pointer and maintain some level of > > isolation from all the other hex integer

Re: [PATCH V11 2/5] vsprintf: refactor %pK code out of pointer()

2017-11-28 Thread Tobin C. Harding
On Tue, Nov 28, 2017 at 09:39:57PM -0500, Steven Rostedt wrote: > On Wed, 29 Nov 2017 13:05:02 +1100 > "Tobin C. Harding" wrote: > > > + /* > > +* kptr_restrict==1 cannot be used in IRQ context > > +* because its test for CAP_SYSLOG would be

Re: [PATCH] sched/deadline: fix one-bit signed bitfields to be unsigned

2017-11-28 Thread Jakub Kicinski
On Tue, 28 Nov 2017 12:36:19 -0800, Jeff Kirsher wrote: > From: Jacob Keller > > Commit 799ba82de01e ("sched/deadline: Use C bitfields for the state > flags", 2017-10-10) introduced the use of C bitfields for these > variables. However, sparse complains about them: > >

Re: [PATCH v4 1/8] dt-bindings: Add Cavium Octeon Common Ethernet Interface.

2017-11-28 Thread David Daney
On 11/28/2017 06:01 PM, Andrew Lunn wrote: On Tue, Nov 28, 2017 at 04:55:33PM -0800, David Daney wrote: From: Carlos Munoz Add bindings for Common Ethernet Interface (BGX) block. Acked-by: Rob Herring Signed-off-by: Carlos Munoz

Re: [PATCH V11 2/5] vsprintf: refactor %pK code out of pointer()

2017-11-28 Thread Steven Rostedt
On Wed, 29 Nov 2017 13:05:02 +1100 "Tobin C. Harding" wrote: > + /* > + * kptr_restrict==1 cannot be used in IRQ context > + * because its test for CAP_SYSLOG would be meaningless. > + */ > + if (in_irq() ||

Re: [PATCH V11 4/5] vsprintf: add printk specifier %px

2017-11-28 Thread Linus Torvalds
On Tue, Nov 28, 2017 at 6:05 PM, Tobin C. Harding wrote: > >Let's add specifier %px as a > clear, opt-in, way to print a pointer and maintain some level of > isolation from all the other hex integer output within the Kernel. Yes, I like this model. It's easy and it's obvious

Re: [iproute2 -net-next] build broken ...

2017-11-28 Thread Stephen Hemminger
On Wed, 29 Nov 2017 02:05:09 +0100 Daniel Borkmann wrote: > Hi Stephen, > > after merge of master into net-next branch the build is now broken > for BPF loader as follows: > > # make > > lib > make[1]: Entering directory '/home/darkstar/iproute2/lib' > CC

Re: [iproute2 -net-next] build broken ...

2017-11-28 Thread Stephen Hemminger
On Wed, 29 Nov 2017 02:05:09 +0100 Daniel Borkmann wrote: > Hi Stephen, > > after merge of master into net-next branch the build is now broken > for BPF loader as follows: > > # make > > lib > make[1]: Entering directory '/home/darkstar/iproute2/lib' > CC

[PATCH V11 2/5] vsprintf: refactor %pK code out of pointer()

2017-11-28 Thread Tobin C. Harding
Currently code to handle %pK is all within the switch statement in pointer(). This is the wrong level of abstraction. Each of the other switch clauses call a helper function, pK should do the same. Refactor code out of pointer() to new function restricted_pointer(). Signed-off-by: Tobin C.

[PATCH V11 1/5] docs: correct documentation for %pK

2017-11-28 Thread Tobin C. Harding
Current documentation indicates that %pK prints a leading '0x'. This is not the case. Correct documentation for printk specifier %pK. Signed-off-by: Tobin C. Harding --- Documentation/printk-formats.txt | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git

[PATCH V11 0/5] hash addresses printed with %p

2017-11-28 Thread Tobin C. Harding
Currently there exist approximately 14 000 places in the Kernel where addresses are being printed using an unadorned %p. This potentially leaks sensitive information regarding the Kernel layout in memory. Many of these calls are stale, instead of fixing every call lets hash the address by default

[PATCH V11 3/5] printk: hash addresses printed with %p

2017-11-28 Thread Tobin C. Harding
Currently there exist approximately 14 000 places in the kernel where addresses are being printed using an unadorned %p. This potentially leaks sensitive information regarding the Kernel layout in memory. Many of these calls are stale, instead of fixing every call lets hash the address by default

[PATCH V11 5/5] kasan: use %px to print addresses instead of %p

2017-11-28 Thread Tobin C. Harding
Pointers printed with %p are now hashed by default. Kasan needs the actual address. We can use the new printk specifier %px for this purpose. Use %px instead of %p to print addresses. Signed-off-by: Tobin C. Harding --- mm/kasan/report.c | 8 1 file changed, 4

[PATCH V11 4/5] vsprintf: add printk specifier %px

2017-11-28 Thread Tobin C. Harding
printk specifier %p now hashes all addresses before printing. Sometimes we need to see the actual unmodified address. This can be achieved using %lx but then we face the risk that if in future we want to change the way the Kernel handles printing of pointers we will have to grep through the

Re: [PATCH v4 1/8] dt-bindings: Add Cavium Octeon Common Ethernet Interface.

2017-11-28 Thread Andrew Lunn
On Tue, Nov 28, 2017 at 04:55:33PM -0800, David Daney wrote: > From: Carlos Munoz > > Add bindings for Common Ethernet Interface (BGX) block. > > Acked-by: Rob Herring > Signed-off-by: Carlos Munoz > Signed-off-by: Steven J. Hill

Re: [PATCH net,stable] vhost: fix skb leak in handle_rx()

2017-11-28 Thread Jason Wang
On 2017年11月29日 01:17, w...@redhat.com wrote: From: Wei Xu Matthew found a roughly 40% tcp throughput regression with commit c67df11f(vhost_net: try batch dequing from skb array) as discussed in the following thread:

[PATCH net 6/6] tools: bpftool: declare phony targets as such

2017-11-28 Thread Jakub Kicinski
From: Quentin Monnet In the Makefile, targets install, doc and doc-install should be added to .PHONY. Let's fix this. Fixes: 71bb428fe2c1 ("tools: bpf: add bpftool") Signed-off-by: Quentin Monnet Acked-by: Jakub Kicinski

[PATCH net 0/6] tools: bpftool: fix a minor issues with JSON and Makefiles

2017-11-28 Thread Jakub Kicinski
Quentin says: First commit in this series fixes a crash that occurs when incorrect arguments are passed to bpftool after the `--json` option. It comes from the usage() function trying to use the JSON writer, although the latter has not been created yet at that point. Other patches add

[PATCH net 5/6] tools: bpftool: unify installation directories

2017-11-28 Thread Jakub Kicinski
From: Quentin Monnet Programs and documentation not managed by package manager are generally installed under /usr/local/, instead of the user's home directory. In particular, `man` is generally able to find manual pages under `/usr/local/share/man`. bpftool

[PATCH net 1/6] tools: bpftool: fix crash on bad parameters with JSON

2017-11-28 Thread Jakub Kicinski
From: Quentin Monnet If bad or unrecognised parameters are specified after JSON output is requested, `usage()` will try to output null JSON object before the writer is created. To prevent this, create the writer as soon as the `--json` option is parsed. Fixes:

[PATCH net 3/6] tools: bpftool: make error message from getopt_long() JSON-friendly

2017-11-28 Thread Jakub Kicinski
From: Quentin Monnet If `getopt_long()` meets an unknown option, it prints its own error message to standard error output. While this does not strictly break JSON output, it is the only case bpftool prints something to standard error output if JSON output is

[PATCH net 4/6] tools: bpftool: remove spurious line break from error message

2017-11-28 Thread Jakub Kicinski
From: Quentin Monnet The end-of-line character inside the string would break JSON compliance. Remove it, `p_err()` already adds a '\n' character for plain output anyway. Fixes: 9a5ab8bf1d6d ("tools: bpftool: turn err() and info() macros into functions")

[PATCH net 2/6] tools: bpftool: clean up the JSON writer before exiting in usage()

2017-11-28 Thread Jakub Kicinski
From: Quentin Monnet The writer is cleaned at the end of the main function, but not if the program exits sooner in usage(). Let's keep it clean and destroy the writer before exiting. Destruction and actual call to exit() are moved to another function so that clean

RE: fec driver and two micrel phys

2017-11-28 Thread Andy Duan
From: Oliver Graute Sent: Tuesday, November 28, 2017 11:28 PM >Hello list, > >I try to get two Micrel KSZ8041 Phys working with the fec driver from Kernel >4.14. But it looks that something with the mii_bus probing is not working here. >I expect the Phys on address 01

Re: [PATCH 11/17] cls_bpf: Convert to use idr_alloc_u32

2017-11-28 Thread Jakub Kicinski
On Tue, 28 Nov 2017 13:33:06 -0800, Matthew Wilcox wrote: > + ret = idr_alloc_u32(>handle_idr, prog, , > + INT_MAX, GFP_KERNEL); > + } else if (!oldprog) { > + ret = idr_alloc_u32(>handle_idr, prog, , > +

[iproute2 -net-next] build broken ...

2017-11-28 Thread Daniel Borkmann
Hi Stephen, after merge of master into net-next branch the build is now broken for BPF loader as follows: # make lib make[1]: Entering directory '/home/darkstar/iproute2/lib' CC libgenl.o CC ll_map.o CC libnetlink.o libnetlink.c:120:2: warning: #warning "libmnl

[PATCH v4 2/8] MIPS: Octeon: Enable LMTDMA/LMTST operations.

2017-11-28 Thread David Daney
From: Carlos Munoz LMTDMA/LMTST operations move data between cores and I/O devices: * LMTST operations can send an address and a variable length (up to 128 bytes) of data to an I/O device. * LMTDMA operations can send an address and a variable length (up to 128) of data

[PATCH v4 0/8] Cavium OCTEON-III network driver.

2017-11-28 Thread David Daney
We are adding the Cavium OCTEON-III network driver. But since interacting with the input and output queues is done via special CPU local memory, we also need to add support to the MIPS/Octeon architecture code. Aren't SoCs nice in this way? The first six patches add the SoC support needed by

[PATCH v4 3/8] MIPS: Octeon: Add a global resource manager.

2017-11-28 Thread David Daney
From: Carlos Munoz Add a global resource manager to manage tagged pointers within bootmem allocated memory. This is used by various functional blocks in the Octeon core like the FPA, Ethernet nexus, etc. Signed-off-by: Carlos Munoz Signed-off-by: Steven J.

[PATCH v4 1/8] dt-bindings: Add Cavium Octeon Common Ethernet Interface.

2017-11-28 Thread David Daney
From: Carlos Munoz Add bindings for Common Ethernet Interface (BGX) block. Acked-by: Rob Herring Signed-off-by: Carlos Munoz Signed-off-by: Steven J. Hill Signed-off-by: David Daney ---

[PATCH v4 5/8] MIPS: Octeon: Automatically provision CVMSEG space.

2017-11-28 Thread David Daney
Remove CONFIG_CAVIUM_OCTEON_CVMSEG_SIZE and automatically calculate the amount of CVMSEG space needed. 1st 128-bytes: Use by IOBDMA 2nd 128-bytes: Reserved by kernel for scratch/TLS emulation. 3rd 128-bytes: OCTEON-III LMTLINE New config variable CONFIG_CAVIUM_OCTEON_EXTRA_CVMSEG provisions

[PATCH v4 4/8] MIPS: Octeon: Add Free Pointer Unit (FPA) support.

2017-11-28 Thread David Daney
From: Carlos Munoz >From the hardware user manual: "The FPA is a unit that maintains pools of pointers to free L2/DRAM memory. To provide QoS, the pools are referenced indirectly through 1024 auras. Both core software and hardware units allocate and free pointers."

[PATCH v4 6/8] staging: octeon: Remove USE_ASYNC_IOBDMA macro.

2017-11-28 Thread David Daney
Previous patch sets USE_ASYNC_IOBDMA to 1 unconditionally. Remove USE_ASYNC_IOBDMA from all if statements. Remove dead code caused by the change. Signed-off-by: David Daney --- drivers/staging/octeon/ethernet-defines.h | 6 --- drivers/staging/octeon/ethernet-rx.c

[PATCH v4 8/8] MAINTAINERS: Add entry for drivers/net/ethernet/cavium/octeon/octeon3-*

2017-11-28 Thread David Daney
Signed-off-by: David Daney --- MAINTAINERS | 6 ++ 1 file changed, 6 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index aa71ab52fd76..e9239ff3cf05 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -3249,6 +3249,12 @@ W: http://www.cavium.com S:

Re: [PATCH 2/8] fs: pstore: remove unused hardirq.h

2017-11-28 Thread Kees Cook
On Fri, Nov 17, 2017 at 3:02 PM, Yang Shi wrote: > Preempt counter APIs have been split out, currently, hardirq.h just > includes irq_enter/exit APIs which are not used by pstore at all. > > So, remove the unused hardirq.h. > > Signed-off-by: Yang Shi

Re: [PATCHv2 2/2] userns: control capabilities of some user namespaces

2017-11-28 Thread महेश बंडेवार
On Tue, Nov 28, 2017 at 3:04 PM, Serge E. Hallyn wrote: > Quoting Mahesh Bandewar (महेश बंडेवार) (mahe...@google.com): > ... >> >> diff --git a/security/commoncap.c b/security/commoncap.c >> >> index fc46f5b85251..89103f16ac37 100644 >> >> --- a/security/commoncap.c >> >> +++

Re: Sending 802.1Q packets using AF_PACKET socket on filtered bridge forwards with wrong MAC addresses

2017-11-28 Thread Brandon Carpenter
I tracked down the function responsible for changing the MAC header. It is skb_vlan_untag() called from __allowed_ingress() in net/bridge/br_vlan.c. Before skb_vlan_untag() is called, the MAC headers are perfect and afterward they are altered as previously described. I'll continue digging into

Re: bpf trees integration for linux-next

2017-11-28 Thread Daniel Borkmann
On 11/28/2017 11:52 PM, Stephen Rothwell wrote: [...] > Added from today. I used the master branch in each case. You might > consider adding your trees to the MAINTAINERS file. Great, thanks Stephen! Yep, we'll do a doc update round some time this week. > Thanks for adding your subsystem tree

Re: [PATCHv2 2/2] userns: control capabilities of some user namespaces

2017-11-28 Thread Serge E. Hallyn
Quoting Mahesh Bandewar (महेश बंडेवार) (mahe...@google.com): ... > >> diff --git a/security/commoncap.c b/security/commoncap.c > >> index fc46f5b85251..89103f16ac37 100644 > >> --- a/security/commoncap.c > >> +++ b/security/commoncap.c > >> @@ -73,6 +73,14 @@ int cap_capable(const struct cred

Re: [PATCH v5 next 1/5] modules:capabilities: add request_module_cap()

2017-11-28 Thread Djalal Harouni
On Tue, Nov 28, 2017 at 11:18 PM, Luis R. Rodriguez wrote: > On Tue, Nov 28, 2017 at 10:33:27PM +0100, Djalal Harouni wrote: >> On Tue, Nov 28, 2017 at 10:16 PM, Luis R. Rodriguez >> wrote: >> > On Tue, Nov 28, 2017 at 12:11:34PM -0800, Kees Cook wrote: >>

Re: bpf trees integration for linux-next

2017-11-28 Thread Stephen Rothwell
Hi Daniel, On Tue, 28 Nov 2017 16:33:00 +0100 Daniel Borkmann wrote: > > Alexei (Cc) and myself are maintaining the bpf and bpf-next tree for > upstream: > >https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf.git/ >

Re: [PATCH] leds: trigger: Introduce a NETDEV trigger

2017-11-28 Thread Andrew Lunn
> What LEDs do LED triggers manipulate? I.e., where are they? Any LEDs which the LED subsystem controls. This is emulating what PHYs can do with there LEDs, but using generic LEDs. Andrew

Re: [PATCH v5 next 1/5] modules:capabilities: add request_module_cap()

2017-11-28 Thread Luis R. Rodriguez
On Tue, Nov 28, 2017 at 02:18:18PM -0800, Kees Cook wrote: > On Tue, Nov 28, 2017 at 2:12 PM, Luis R. Rodriguez wrote: > > On Tue, Nov 28, 2017 at 01:39:58PM -0800, Kees Cook wrote: > >> On Tue, Nov 28, 2017 at 1:16 PM, Luis R. Rodriguez > >> wrote: > >> >

Re: [PATCH] leds: trigger: Introduce a NETDEV trigger

2017-11-28 Thread Randy Dunlap
On 11/28/2017 01:54 PM, Ben Whitten wrote: > diff --git a/drivers/leds/trigger/Kconfig b/drivers/leds/trigger/Kconfig > index 3f9ddb9..4ec1853 100644 > --- a/drivers/leds/trigger/Kconfig > +++ b/drivers/leds/trigger/Kconfig > @@ -126,4 +126,11 @@ config LEDS_TRIGGER_PANIC > a different

Re: [PATCH] [RFC v3] packet: experimental support for 64-bit timestamps

2017-11-28 Thread Willem de Bruijn
On Tue, Nov 28, 2017 at 3:32 PM, Arnd Bergmann wrote: > As I noticed in my previous patch to remove the 'timespec' usage in > the packet socket, the timestamps in the packet socket are slightly > inefficient as they convert a nanosecond value into seconds/nanoseconds > or

Re: [PATCH v5 next 1/5] modules:capabilities: add request_module_cap()

2017-11-28 Thread Luis R. Rodriguez
On Tue, Nov 28, 2017 at 10:33:27PM +0100, Djalal Harouni wrote: > On Tue, Nov 28, 2017 at 10:16 PM, Luis R. Rodriguez wrote: > > On Tue, Nov 28, 2017 at 12:11:34PM -0800, Kees Cook wrote: > >> On Tue, Nov 28, 2017 at 11:14 AM, Luis R. Rodriguez > >> wrote:

Re: [PATCH v5 next 1/5] modules:capabilities: add request_module_cap()

2017-11-28 Thread Kees Cook
On Tue, Nov 28, 2017 at 2:12 PM, Luis R. Rodriguez wrote: > On Tue, Nov 28, 2017 at 01:39:58PM -0800, Kees Cook wrote: >> On Tue, Nov 28, 2017 at 1:16 PM, Luis R. Rodriguez wrote: >> > And *all* auto-loading uses aliases? What's the difference between >> >

Re: [PATCH v5 next 1/5] modules:capabilities: add request_module_cap()

2017-11-28 Thread Luis R. Rodriguez
On Tue, Nov 28, 2017 at 01:39:58PM -0800, Kees Cook wrote: > On Tue, Nov 28, 2017 at 1:16 PM, Luis R. Rodriguez wrote: > > And *all* auto-loading uses aliases? What's the difference between > > auto-loading > > and direct-loading? > > The difference is the process privileges.

[PATCH] leds: trigger: Introduce a NETDEV trigger

2017-11-28 Thread Ben Whitten
This commit introduces a NETDEV trigger for named device activity. Available triggers are link, rx, and tx. Signed-off-by: Ben Whitten --- .../ABI/testing/sysfs-class-led-trigger-netdev | 45 +++ drivers/leds/trigger/Kconfig | 7 +

[PATCH] Introduce a NETDEV LED trigger

2017-11-28 Thread Ben Whitten
It's quite useful to be able to trigger LEDs based on network activity, similar mechanisms exist in routers and gateway devices. I am looking to mainline a patch that has existed out of tree for some time in OpenWRT/LEDE. The patch has been updated and restructured and most of the issues raised in

Re: pull request: Cavium Octeon III firmware

2017-11-28 Thread Steven J. Hill
On 11/28/2017 11:30 AM, Ben Hutchings wrote: > > The diffstat in your original pull request said that WHENCE wasn't > updated. Maybe you corrected that after sending the pull request. > Ben, The updated patch is ready for you to pull. Cheers. Steve

Re: [PATCH net-next] vmxnet3: increase default rx ring sizes

2017-11-28 Thread Shrikrishna Khare
On Tue, 28 Nov 2017, Andrew Lunn wrote: > > /* > > * Version numbers > > */ > > -#define VMXNET3_DRIVER_VERSION_STRING "1.4.a.0-k" > > +#define VMXNET3_DRIVER_VERSION_STRING "1.4.11.0-k" > > > > /* a 32-bit int, each byte encode a verion number in > > VMXNET3_DRIVER_VERSION */ > >

Re: [PATCH v5 next 1/5] modules:capabilities: add request_module_cap()

2017-11-28 Thread Djalal Harouni
On Tue, Nov 28, 2017 at 10:16 PM, Luis R. Rodriguez wrote: > On Tue, Nov 28, 2017 at 12:11:34PM -0800, Kees Cook wrote: >> On Tue, Nov 28, 2017 at 11:14 AM, Luis R. Rodriguez >> wrote: >> > kmod is just a helper to poke userpsace to load a module, that's

[PATCH 16/17] idr: Rename idr_for_each_entry_ext

2017-11-28 Thread Matthew Wilcox
From: Matthew Wilcox Match idr_alloc_ul with idr_get_next_ul and idr_for_each_entry_ul. Also add kernel-doc. Signed-off-by: Matthew Wilcox --- include/linux/idr.h | 17 ++--- lib/idr.c | 20 +++-

[PATCH 01/17] idr: Fix build

2017-11-28 Thread Matthew Wilcox
From: Matthew Wilcox The IDR calls WARN_ON without including Signed-off-by: Matthew Wilcox --- include/linux/idr.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/linux/idr.h b/include/linux/idr.h index 7c3a365f7e12..dd048cf456b7

Re: [PATCH v5 next 1/5] modules:capabilities: add request_module_cap()

2017-11-28 Thread Kees Cook
On Tue, Nov 28, 2017 at 1:16 PM, Luis R. Rodriguez wrote: > And *all* auto-loading uses aliases? What's the difference between > auto-loading > and direct-loading? The difference is the process privileges. Unprivilged autoloading (e.g. int n_hdlc = N_HDLC; ioctl(fd, TIOCSETD,

[PATCH 17/17] idr: Warn if old iterators see large IDs

2017-11-28 Thread Matthew Wilcox
From: Matthew Wilcox Now that the IDR can be used to store large IDs, it is possible somebody might only partially convert their old code and use the iterators which can only handle IDs up to INT_MAX. It's probably unwise to show them a truncated ID, so settle for

[PATCH 03/17] idr test suite: Fix ida_test_random()

2017-11-28 Thread Matthew Wilcox
From: Matthew Wilcox The test was checking the wrong errno; ida_get_new_above() returns EAGAIN, not ENOMEM on memory allocation failure. Double the number of threads to increase the chance that we actually exercise this path during the test suite (it was a bit sporadic

[PATCH 04/17] IDR test suite: Check handling negative end correctly

2017-11-28 Thread Matthew Wilcox
From: Matthew Wilcox One of the charming quirks of the idr_alloc() interface is that you can pass a negative end and it will be interpreted as "maximum". Ensure we don't break that. Signed-off-by: Matthew Wilcox ---

[PATCH 05/17] idr: Delete idr_remove_ext function

2017-11-28 Thread Matthew Wilcox
From: Matthew Wilcox Simply changing idr_remove's 'id' argument to 'unsigned long' suffices for all callers. Signed-off-by: Matthew Wilcox --- include/linux/idr.h| 7 +-- net/sched/act_api.c| 2 +- net/sched/cls_basic.c | 6 +++---

[PATCH 14/17] cls_u32: Convert to idr_alloc_u32

2017-11-28 Thread Matthew Wilcox
From: Matthew Wilcox No real benefit to this classifier, but since we're allocating a u32 anyway, we should use this function. Signed-off-by: Matthew Wilcox --- net/sched/cls_u32.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-)

[PATCH 13/17] cls_u32: Reinstate cyclic allocation

2017-11-28 Thread Matthew Wilcox
From: Matthew Wilcox Commit e7614370d6f0 ("net_sched: use idr to allocate u32 filter handles) converted htid allocation to use the IDR. The ID allocated by this scheme changes; it used to be cyclic, but now always allocates the lowest available. The IDR supports cyclic

[PATCH 08/17] idr: Add idr_alloc_u32 helper

2017-11-28 Thread Matthew Wilcox
From: Matthew Wilcox All current users of idr_alloc_ext() actually want to allocate a u32 and it's a little painful for them to use idr_alloc_ext(). This convenience function makes it simple. Signed-off-by: Matthew Wilcox ---

[PATCH 07/17] idr: Delete idr_find_ext function

2017-11-28 Thread Matthew Wilcox
From: Matthew Wilcox Simply changing idr_remove's 'id' argument to 'unsigned long' works for all callers. Signed-off-by: Matthew Wilcox --- include/linux/idr.h| 7 +-- net/sched/act_api.c| 2 +- net/sched/cls_flower.c | 2 +- 3 files

[PATCH 00/17] IDR patches for 4.15

2017-11-28 Thread Matthew Wilcox
From: Matthew Wilcox The patches here are of three types: - Enhancing the test suite (fixing the build, adding a couple of new tests, fixing a bug in the test) - Replacing the 'extended' IDR API - Fixing some low-probability bugs As far as the 'extended' IDR API

[PATCH 09/17] net sched actions: Convert to use idr_alloc_u32

2017-11-28 Thread Matthew Wilcox
From: Matthew Wilcox Use the new helper. Also untangle the error path, and in so doing noticed that estimator generator failure would lead to us leaking an ID. Fix that bug. Signed-off-by: Matthew Wilcox --- net/sched/act_api.c | 60

[PATCH 10/17] cls_basic: Convert to use idr_alloc_u32

2017-11-28 Thread Matthew Wilcox
From: Matthew Wilcox Use the new helper which saves a temporary variable and a few lines of code. Signed-off-by: Matthew Wilcox --- net/sched/cls_basic.c | 25 ++--- 1 file changed, 10 insertions(+), 15 deletions(-) diff

[PATCH 06/17] idr: Delete idr_replace_ext function

2017-11-28 Thread Matthew Wilcox
From: Matthew Wilcox Changing idr_replace's 'id' argument to 'unsigned long' works for all callers. Callers which passed a negative ID now get -ENOENT instead of -EINVAL. No callers relied on this error value. Signed-off-by: Matthew Wilcox ---

[PATCH 12/17] cls_flower: Convert to idr_alloc_u32

2017-11-28 Thread Matthew Wilcox
From: Matthew Wilcox Use the new helper which saves a temporary variable and a few lines of code. Signed-off-by: Matthew Wilcox --- net/sched/cls_flower.c | 26 ++ 1 file changed, 10 insertions(+), 16 deletions(-) diff

[PATCH 02/17] radix tree test suite: Remove ARRAY_SIZE

2017-11-28 Thread Matthew Wilcox
From: Matthew Wilcox This is now defined in tools/include/linux/kernel.h, so our definition generates a warning. Signed-off-by: Matthew Wilcox --- tools/testing/radix-tree/linux/kernel.h | 2 -- 1 file changed, 2 deletions(-) diff --git

[PATCH 15/17] idr: Rename idr_alloc_ext to idr_alloc_ul

2017-11-28 Thread Matthew Wilcox
From: Matthew Wilcox idr_alloc_ul fits better with other parts of the Linux kernel where we need to name a function based on the types it operates on. It uses a 'nextid' pointer argument instead of separate minimum ID and output assigned ID, (like idr_get_next), reducing

[PATCH 11/17] cls_bpf: Convert to use idr_alloc_u32

2017-11-28 Thread Matthew Wilcox
From: Matthew Wilcox Use the new helper. This has a modest reduction in both lines of code and compiled code size. Signed-off-by: Matthew Wilcox --- net/sched/cls_bpf.c | 24 ++-- 1 file changed, 10 insertions(+), 14

Re: [PATCH net-next] vmxnet3: increase default rx ring sizes

2017-11-28 Thread Andrew Lunn
> /* > * Version numbers > */ > -#define VMXNET3_DRIVER_VERSION_STRING "1.4.a.0-k" > +#define VMXNET3_DRIVER_VERSION_STRING "1.4.11.0-k" > > /* a 32-bit int, each byte encode a verion number in VMXNET3_DRIVER_VERSION > */ > -#define VMXNET3_DRIVER_VERSION_NUM 0x01040a00 >

[PATCH net-next] vmxnet3: increase default rx ring sizes

2017-11-28 Thread Shrikrishna Khare
We often notice rx packet drops due to small default rx ring sizes and solve the problem by increasing the ring sizes. This patch increases the default rx ring sizes thereby reducing the probability of rx packet drops out of the box. Signed-off-by: Shrikrishna Khare Acked-by:

Re: [PATCHv2 2/2] userns: control capabilities of some user namespaces

2017-11-28 Thread महेश बंडेवार
On Sat, Nov 25, 2017 at 10:40 PM, Serge E. Hallyn wrote: > Quoting Mahesh Bandewar (mah...@bandewar.net): >> From: Mahesh Bandewar >> >> With this new notion of "controlled" user-namespaces, the controlled >> user-namespaces are marked at the time of their

Re: [PATCH v5 next 1/5] modules:capabilities: add request_module_cap()

2017-11-28 Thread Luis R. Rodriguez
On Tue, Nov 28, 2017 at 12:11:34PM -0800, Kees Cook wrote: > On Tue, Nov 28, 2017 at 11:14 AM, Luis R. Rodriguez wrote: > > kmod is just a helper to poke userpsace to load a module, that's it. > > > > The old init_module() and newer finit_module() do the real handy work or > >

Re: [patch net resend] net: sched: cbq: create block for q->link.block

2017-11-28 Thread David Miller
From: Jiri Pirko Date: Mon, 27 Nov 2017 18:37:21 +0100 > From: Jiri Pirko > > q->link.block is not initialized, that leads to EINVAL when one tries to > add filter there. So initialize it properly. > > This can be reproduced by: > $ tc qdisc add dev eth0

Re: [PATCH] atm: suni: remove extraneous space to fix indentation

2017-11-28 Thread David Miller
From: Colin King Date: Mon, 27 Nov 2017 13:47:22 + > From: Colin Ian King > > Remove a leading space, fixes indentation > > Signed-off-by: Colin Ian King Applied.

Re: [PATCH] atm: lanai: use %p to format kernel addresses instead of %x

2017-11-28 Thread David Miller
From: Colin King Date: Mon, 27 Nov 2017 13:39:32 + > From: Colin Ian King > > Don't use %x and casting to print out a kernel address, instead use %p > and remove the casting. Cleans up smatch warnings: > > drivers/atm/lanai.c:1589

Re: [PATCH] VSOCK: Don't set sk_state to TCP_CLOSE before testing it

2017-11-28 Thread David Miller
From: Jorgen Hansen Date: Mon, 27 Nov 2017 05:29:32 -0800 > A recent commit (3b4477d2dcf2) converted the sk_state to use > TCP constants. In that change, vmci_transport_handle_detach > was changed such that sk->sk_state was set to TCP_CLOSE before > we test whether it is

Re: [PATCH] atm: fore200e: use %pK to format kernel addresses instead of %x

2017-11-28 Thread David Miller
From: Colin King Date: Mon, 27 Nov 2017 13:24:15 + > From: Colin Ian King > > Don't use %x and casting to print out a kernel address, instead use the > %pK and remove the casting. Cleans up smatch warning: > >

Re: [PATCH] ambassador: fix incorrect indentation of assignment statement

2017-11-28 Thread David Miller
From: Colin King Date: Mon, 27 Nov 2017 13:06:10 + > From: Colin Ian King > > Remove one extraneous level of indentation on assignment statement. > > Signed-off-by: Colin Ian King Applied, thanks Colin.

Re: [PATCH net] vxlan: use __be32 type for the param vni in __vxlan_fdb_delete

2017-11-28 Thread David Miller
From: Xin Long Date: Sun, 26 Nov 2017 21:19:05 +0800 > All callers of __vxlan_fdb_delete pass vni with __be32 type, and > this param should be declared as __be32 type. > > Fixes: 3ad7a4b141eb ("vxlan: support fdb and learning in COLLECT_METADATA > mode") > Signed-off-by:

  1   2   3   >