Re: [PATCH 1/3] vhost: fix skb leak in handle_rx()

2017-12-03 Thread Jason Wang
On 2017年12月01日 22:37, Michael S. Tsirkin wrote: On Fri, Dec 01, 2017 at 03:11:05PM +0800, Jason Wang wrote: On 2017年12月01日 13:54, w...@redhat.com wrote: From: Wei Xu Matthew found a roughly 40% tcp throughput regression with commit c67df11f(vhost_net: try batch dequing

Re: [PATCH 1/3] dt-bindings: Add optional nvmem MAC address bindings to ti,wlink-st

2017-12-03 Thread Marcel Holtmann
Hi David, > This adds optional nvmem consumer properties to the ti,wlink-st device tree > bindings to allow specifying the Bluetooth MAC address. > > Signed-off-by: David Lechner > --- > Documentation/devicetree/bindings/net/ti,wilink-st.txt | 4 > 1 file changed, 4

Re: [PATCH 3/3] bluetooth: hci_ll: Add optional nvmem MAC address source

2017-12-03 Thread Marcel Holtmann
Hi David, > This adds an optional nvmem consumer to get a MAC address from an external > source. The MAC address is then set in the Bluetooth chip after the > firmware has been loaded. > > This has been tested working with a TI CC2560A chip (in a LEGO MINDSTORMS > EV3). > > Signed-off-by: David

[PATCH net-next 3/6] net: qualcomm: rmnet: Allow only one rmnet dev per muxid per real dev

2017-12-03 Thread Subash Abhinov Kasiviswanathan
Upon de-multiplexing data from one real dev, the packets can be sent to an unique rmnet device for a given mux id. Signed-off-by: Subash Abhinov Kasiviswanathan --- drivers/net/ethernet/qualcomm/rmnet/rmnet_vnd.c | 3 +++ 1 file changed, 3 insertions(+) diff --git

[PATCH net-next 2/6] net: qualcomm: rmnet: Remove the some redundant macros

2017-12-03 Thread Subash Abhinov Kasiviswanathan
Multiplexing is always enabled when transmiting from a rmnet device, so remove the redundant egress macros. De-multiplexing is always enabled when receiving packets from a rmnet device, so remove those ingress macros. Signed-off-by: Subash Abhinov Kasiviswanathan ---

[PATCH net-next 4/6] net: qualcomm: rmnet: Process packets over ethernet

2017-12-03 Thread Subash Abhinov Kasiviswanathan
Add support to send and receive packets over ethernet. An example of usage is testing the data path on UML. This can be achieved by setting up two UML instances in multicast mode and associating rmnet over the UML ethernet device. Signed-off-by: Subash Abhinov Kasiviswanathan

[PATCH net-next 5/6] net: qualcomm: rmnet: Allow to configure flags for new devices

2017-12-03 Thread Subash Abhinov Kasiviswanathan
Add an option to configure the rmnet aggregation and command features on device creation. This is achieved by using the vlan flags option. Signed-off-by: Subash Abhinov Kasiviswanathan --- drivers/net/ethernet/qualcomm/rmnet/rmnet_config.c | 16 +--- 1 file

[PATCH net-next 6/6] net: qualcomm: rmnet: Allow to configure flags for existing devices

2017-12-03 Thread Subash Abhinov Kasiviswanathan
Add an option to configure the mux id, aggregation and commad feature for existing rmnet devices. Implement the changelink netlink operation for this. Signed-off-by: Subash Abhinov Kasiviswanathan --- drivers/net/ethernet/qualcomm/rmnet/rmnet_config.c | 40

[PATCH net-next 0/6] net: qualcomm: rmnet: Configuration options

2017-12-03 Thread Subash Abhinov Kasiviswanathan
This series adds support for configuring features on rmnet devices. The rmnet specific features to be configured here are aggregation and control commands. Patch 1 is a cleanup of return codes in the transmit path. Patch 2 removes some redundant ingress and egress macros. Patch 3 restricts the

[PATCH net-next 1/6] net: qualcomm: rmnet: Remove the rmnet_map_results enum

2017-12-03 Thread Subash Abhinov Kasiviswanathan
Only the success and consumed entries were actually in use. Use standard error codes instead. Signed-off-by: Subash Abhinov Kasiviswanathan --- .../net/ethernet/qualcomm/rmnet/rmnet_handlers.c| 21 -

Re: linux-next: build warning after merge of the net-next tree

2017-12-03 Thread Heiner Kallweit
Am 04.12.2017 um 01:02 schrieb Stephen Rothwell: > Hi all, > > After merging the net-next tree, today's linux-next build (arm > multi_v7_defconfig) produced this warning: > > drivers/net/phy/broadcom.c:391:12: warning: 'bcm5482_read_status' defined but > not used [-Wunused-function] > static

Re: [PATCH 2/3] bluetooth: hci_ll: add constant for vendor-specific command

2017-12-03 Thread Marcel Holtmann
Hi David, > This adds a #define for the vendor-specific HCI command to set the > baudrate instead of using the bare 0xff36 multiple times. > > Signed-off-by: David Lechner > --- > drivers/bluetooth/hci_ll.c | 10 -- > 1 file changed, 8 insertions(+), 2 deletions(-)

Re: [Bridge] [PATCH net-next] bridge: ebtables: Avoid resetting limit rule state

2017-12-03 Thread Linus Lüssing
On Mon, Dec 04, 2017 at 05:53:35AM +0100, Linus Lüssing wrote: > And so, no I do not have this patch. I looked at it now, but it > does not seem to have any relation with .matchinfo, does it? Relation between .usersize and .checkentry I ment, not .usersize and .matchinfo.

Re: [PATCH 1/1] timecounter: Make cyclecounter struct part of timecounter struct

2017-12-03 Thread Sagar Arun Kamble
On 12/2/2017 11:34 PM, Richard Cochran wrote: On Sat, Dec 02, 2017 at 10:01:35AM +0530, Sagar Arun Kamble wrote: There is no real need for the users of timecounters to define cyclecounter and timecounter variables separately. Since timecounter will always be based on cyclecounter, have

Re: [PATCH net-next] bridge: ebtables: Avoid resetting limit rule state

2017-12-03 Thread Linus Lüssing
Hi Pablo, Thanks for your reply! On Tue, Nov 28, 2017 at 12:30:08AM +0100, Pablo Neira Ayuso wrote: > [...] > > diff --git a/net/bridge/netfilter/ebt_limit.c > > b/net/bridge/netfilter/ebt_limit.c > > index 61a9f1be1263..f74b48633feb 100644 > > --- a/net/bridge/netfilter/ebt_limit.c > > +++

Re: [PATCH 1/5] bpf: correct broken uapi for BPF_PROG_TYPE_PERF_EVENT program type

2017-12-03 Thread kbuild test robot
Hi Hendrik, Thank you for the patch! Yet something to improve: [auto build test ERROR on linus/master] [also build test ERROR on v4.15-rc2] [cannot apply to tip/perf/core] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

[Patch net] tipc: fix a null pointer deref on error path

2017-12-03 Thread Cong Wang
In tipc_topsrv_kern_subscr() when s->tipc_conn_new() fails we call tipc_close_conn() to clean up, but in this case con->usr_data is NULL, tipc_subscrb_delete() should be skipped. This fixes the folllowing crash: kasan: GPF could be caused by NULL-ptr deref or user memory access general

[PATCH 1/3] dt-bindings: Add optional nvmem MAC address bindings to ti,wlink-st

2017-12-03 Thread David Lechner
This adds optional nvmem consumer properties to the ti,wlink-st device tree bindings to allow specifying the Bluetooth MAC address. Signed-off-by: David Lechner --- Documentation/devicetree/bindings/net/ti,wilink-st.txt | 4 1 file changed, 4 insertions(+) diff --git

[PATCH 3/3] bluetooth: hci_ll: Add optional nvmem MAC address source

2017-12-03 Thread David Lechner
This adds an optional nvmem consumer to get a MAC address from an external source. The MAC address is then set in the Bluetooth chip after the firmware has been loaded. This has been tested working with a TI CC2560A chip (in a LEGO MINDSTORMS EV3). Signed-off-by: David Lechner

[PATCH 2/3] bluetooth: hci_ll: add constant for vendor-specific command

2017-12-03 Thread David Lechner
This adds a #define for the vendor-specific HCI command to set the baudrate instead of using the bare 0xff36 multiple times. Signed-off-by: David Lechner --- drivers/bluetooth/hci_ll.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git

[PATCH 0/3] bluetooth: hci_ll: Get MAC address from NVMEM

2017-12-03 Thread David Lechner
This series adds supporting getting the MAC address from a NVMEM provider for "LL" HCI controllers (Texas Instruments). The second patch is just cleaning things up before I add another similar vendor-specific HCI command constant in the final patch. David Lechner (3): dt-bindings: Add optional

[PATCH 1/1] gianfar: fix a flooded alignment reports because of padding issue.

2017-12-03 Thread Zumeng Chen
According to LS1021A RM, the value of PAL can be set so that the start of the IP header in the receive data buffer is aligned to a 32-bit boundary. Normally, setting PAL = 2 provides minimal padding to ensure such alignment of the IP header. However every incoming packet's 8-byte time stamp will

Re: [PATCH net-next 3/4] net: use rtnl_register_module where needed

2017-12-03 Thread David Ahern
On 12/3/17 7:56 PM, David Ahern wrote: > On 12/2/17 1:44 PM, Florian Westphal wrote: >> all of these can be compiled as a module, so use new >> _module version to make sure module can no longer be removed >> while callback/dump is in use. >> >> Signed-off-by: Florian Westphal >>

Re: [PATCH net-next 3/4] net: use rtnl_register_module where needed

2017-12-03 Thread David Ahern
On 12/2/17 1:44 PM, Florian Westphal wrote: > all of these can be compiled as a module, so use new > _module version to make sure module can no longer be removed > while callback/dump is in use. > > Signed-off-by: Florian Westphal > --- > net/bridge/br_mdb.c | 6 +++--- >

Re: [PATCH net-next 2/2] veth: allow configuring GSO maximums

2017-12-03 Thread David Ahern
On 12/1/17 1:11 PM, Stephen Hemminger wrote: > diff --git a/drivers/net/veth.c b/drivers/net/veth.c > index f5438d0978ca..510c058ba227 100644 > --- a/drivers/net/veth.c > +++ b/drivers/net/veth.c > @@ -410,6 +410,26 @@ static int veth_newlink(struct net *src_net, struct > net_device *dev, >

Re: general protection fault in __lock_acquire (2)

2017-12-03 Thread Cong Wang
On Sun, Dec 3, 2017 at 4:33 PM, syzbot wrote: > syzkaller has found reproducer for the following crash on > fb7516d42478ebc8e2f00efb76ef96f7b68fd8d3 > git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git/master >

[PATCH V2 net-next 2/3] net: hns3: Add reset service task for handling reset requests

2017-12-03 Thread Salil Mehta
Existing common service task was being used to service the reset requests. This patch tries to make the handling of reset cleaner by separating task to handle the reset requests. This might in turn help in adapting similar handling approach for other interrupt events like mailbox, sharing vector 0

[PATCH V2 net-next 3/3] net: hns3: Refactors the requested reset & pending reset handling code

2017-12-03 Thread Salil Mehta
In exisiting code, the way to detect if driver/client reset should be executed or if hardware should be be soft resetted was overly complex. Existing code use to read the interrupt status register from task context to figure out if the interrupt source event was reset and then use clear the

[PATCH V2 net-next 0/3] net: hns3: Refactors "reset" handling code in HCLGE layer of HNS3 driver

2017-12-03 Thread Salil Mehta
This patch refactors the code of the reset feature in HCLGE layer of HNS3 PF driver. Prime motivation to do this change is: 1. To reduce the time for which common miscellaneous Vector 0 interrupt is disabled because of the reset. Simplification of the common miscellaneous interrupt handler

[PATCH V2 net-next 1/3] net: hns3: Refactor of the reset interrupt handling logic

2017-12-03 Thread Salil Mehta
The reset interrupt event shares common miscellaneous interrupt Vector 0. In the existing reset interrupt handling we disable the Vector 0 interrupt in misc interrupt handler and re-enable them later in context to common service task. This also means other event sources like mailbox would also be

[bisected] x86 boot still broken on -rc2

2017-12-03 Thread Jakub Kicinski
Same thing on rc2, bisected down to: commit b4c0a7326f5dc0ef7a64128b0ae7d081f4b2cbd1 (refs/bisect/bad) Author: Prarit Bhargava Date: Tue Nov 14 07:42:57 2017 -0500 x86/smpboot: Fix __max_logical_packages estimate A system booted with a small number of cores

Re: [PATCH net-next RFC 0/9] net: dsa: PTP timestamping for mv88e6xxx

2017-12-03 Thread Richard Cochran
On Tue, Nov 07, 2017 at 07:23:27PM -0800, Richard Cochran wrote: > The application does join that group on the external (slave) > interface. I'll find out why the delay request mechanism isn't > working... Looking back, I now recall that the series lets the HW embed the time stamps into the

Re: [PATCH v2 35/35] dt-bindings: timer: Add andestech atcpit100 timer binding doc

2017-12-03 Thread 陳建志
2017-12-01 20:19 GMT+08:00 Linus Walleij : > On Mon, Nov 27, 2017 at 1:28 PM, Greentime Hu wrote: > >> From: Rick Chen >> >> Add a document to describe Andestech atcpit100 timer and >> binding information. >> >> Signed-off-by:

linux-next: build warning after merge of the net-next tree

2017-12-03 Thread Stephen Rothwell
Hi all, After merging the net-next tree, today's linux-next build (arm multi_v7_defconfig) produced this warning: drivers/net/phy/broadcom.c:391:12: warning: 'bcm5482_read_status' defined but not used [-Wunused-function] static int bcm5482_read_status(struct phy_device *phydev) ^

Re: [PATCH net-next 2/2 v6] net: ethernet: Add a driver for Gemini gigabit ethernet

2017-12-03 Thread David Miller
From: Linus Walleij Date: Sat, 2 Dec 2017 12:06:40 +0100 > +struct gmac_txq { > + GMAC_TXDESC_T *ring; Please don't create struct based typedef's, express this using a straight "struct gmac_rxdesc_t", and also make it lowercase. Uppercase names are reserved for

[PATCH iproute2 net-next] Add support for cake qdisc

2017-12-03 Thread Dave Taht
sch_cake is intended to squeeze the most bandwidth and latency out of even the slowest ISP links and routers, while presenting an API simple enough that even an ISP can configure it. Example of use on a cable ISP uplink: tc qdisc add dev eth0 cake bandwidth 20Mbit nat docsis ack-filter To shape

[PATCH iproute2 net-next] Add support and man page for cake qdisc

2017-12-03 Thread Dave Taht
Add support and man page for cake qdisc. Dave Taht (1): Add support for cake qdisc man/man8/tc-cake.8 | 678 ++ tc/Makefile| 1 + tc/q_cake.c| 771 + 3 files changed, 1450

RE: [PATCH net v2 2/3] xfrm: Add an activate() offload dev op

2017-12-03 Thread Yossi Kuperman
> -Original Message- > From: Shannon Nelson [mailto:shannon.nel...@oracle.com] > Sent: Sunday, December 3, 2017 12:11 AM > To: Aviv Heller ; Steffen Klassert > > Cc: Herbert Xu ; Boris Pismenny >

[PATCH net-next 1/3] pkt_sched.h: add support for sch_cake API

2017-12-03 Thread Dave Taht
Signed-off-by: Dave Taht --- include/uapi/linux/pkt_sched.h | 58 ++ 1 file changed, 58 insertions(+) diff --git a/include/uapi/linux/pkt_sched.h b/include/uapi/linux/pkt_sched.h index af3cc2f..ed7c111 100644 ---

[PATCH net-next 0/3] Add Common Applications Kept Enhanced (cake) qdisc

2017-12-03 Thread Dave Taht
sch_cake is intended to squeeze the most bandwidth and latency out of even the slowest ISP links and routers, while presenting an API simple enough that even an ISP can configure it. Example of use on a cable ISP uplink: tc qdisc add dev eth0 cake bandwidth 20Mbit nat docsis ack-filter To shape

[PATCH net-next 3/3] Add support for building the new cake qdisc

2017-12-03 Thread Dave Taht
Hook up sch_cake to the build system. Signed-off-by: Dave Taht --- net/sched/Kconfig | 11 +++ net/sched/Makefile | 1 + 2 files changed, 12 insertions(+) diff --git a/net/sched/Kconfig b/net/sched/Kconfig index c03d86a..3ea22e5 100644 --- a/net/sched/Kconfig +++

[PATCH net-next 2/3] Add Common Applications Kept Enhanced (cake) qdisc

2017-12-03 Thread Dave Taht
sch_cake is intended to squeeze the most bandwidth and latency out of even the slowest ISP links and routers, while presenting an API simple enough that even an ISP can configure it. Example of use on a cable ISP uplink: tc qdisc add dev eth0 cake bandwidth 20Mbit nat docsis ack-filter To shape

[PATCH] cfg80211: fix kernel-doc warnings

2017-12-03 Thread Randy Dunlap
From: Randy Dunlap Drop kernel-doc comment for this value since this value was dropped in a previous commit. Fixes >100 of these warnings: ../include/net/cfg80211.h:3278: warning: Excess enum value 'WIPHY_FLAG_SUPPORTS_SCHED_SCAN' description in 'wiphy_flags' Fixes:

Re: [PATCH] leds: trigger: Introduce a NETDEV trigger

2017-12-03 Thread Jacek Anaszewski
Hi Ben, Thanks for the patch. I have some comments in the code below. Please take a look. On 11/28/2017 10:54 PM, Ben Whitten wrote: > This commit introduces a NETDEV trigger for named device > activity. Available triggers are link, rx, and tx. > > Signed-off-by: Ben Whitten

RE: [PATCH net v2 2/3] xfrm: Add an activate() offload dev op

2017-12-03 Thread Yossi Kuperman
> -Original Message- > From: Shannon Nelson [mailto:shannon.nel...@oracle.com] > Sent: Sunday, December 3, 2017 2:38 AM > To: Yossi Kuperman ; Steffen Klassert > > Cc: Aviv Heller ; Herbert Xu >

Re: kernel BUG at net/key/af_key.c:LINE!

2017-12-03 Thread Eric Biggers
On Wed, Nov 15, 2017 at 12:29:19PM +0100, Steffen Klassert wrote: > On Fri, Nov 10, 2017 at 02:14:06PM +1100, Herbert Xu wrote: > > On Fri, Nov 10, 2017 at 01:30:38PM +1100, Herbert Xu wrote: > > > > > > I found the problem. This crap is coming from clone_policy. Now > > > let me where this

Re: [Patch net-next] net_sched: get rid of rcu_barrier() in tcf_block_put_ext()

2017-12-03 Thread Cong Wang
On Sat, Dec 2, 2017 at 1:21 AM, Jiri Pirko wrote: > Sat, Dec 02, 2017 at 01:18:04AM CET, xiyou.wangc...@gmail.com wrote: >>Both Eric and Paolo noticed the rcu_barrier() we use in >>tcf_block_put_ext() could be a performance bottleneck when >>we have lots of filters. > > The

Re: BUG: unable to handle kernel NULL pointer dereference

2017-12-03 Thread Eric Biggers
On Sun, Dec 03, 2017 at 04:37:01AM -0800, syzbot wrote: > BUG: KASAN: use-after-free in skcipher_request_set_tfm > include/crypto/skcipher.h:499 [inline] > BUG: KASAN: use-after-free in crypto_aead_copy_sgl crypto/algif_aead.c:85 > [inline] > BUG: KASAN: use-after-free in _aead_recvmsg

Re: [PATCH net-next] bpf: Add access to snd_cwnd and others in sock_ops

2017-12-03 Thread Alexei Starovoitov
On Fri, Dec 01, 2017 at 10:15:04AM -0800, Lawrence Brakmo wrote: > Adds read access to snd_cwnd and srtt_us fields of tcp_sock. Since these > fields are only valid if the socket associated with the sock_ops program > call is a full socket, the field is_fullsock is also added to the > bpf_sock_ops

[GIT] Networking

2017-12-03 Thread David Miller
1) Various TCP control block fixes, including one that crashes with SELINUX, from David Ahern and Eric Dumazet. 2) Fix ACK generation in rxrpc, from David Howells. 3) ipvlan doesn't set the mark properly in the ipv4 route lookup key, from Gao Feng. 4) SIT configuration doesn't take on

Re: pull-request: bpf 2017-12-02

2017-12-03 Thread David Miller
From: Daniel Borkmann Date: Sat, 2 Dec 2017 02:05:04 +0100 > The following pull-request contains BPF updates for your *net* tree. Pulled, thanks a lot Daniel.

Re: [PATCH 1/5] bpf: correct broken uapi for BPF_PROG_TYPE_PERF_EVENT program type

2017-12-03 Thread Alexei Starovoitov
On Fri, Dec 01, 2017 at 03:19:04PM +0100, Hendrik Brueckner wrote: > Commit 0515e5999a466dfe ("bpf: introduce BPF_PROG_TYPE_PERF_EVENT > program type") introduced the bpf_perf_event_data structure which > exports the pt_regs structure. This is OK for multiple architectures > but fail for s390 and

Re: [PATCH net 0/2] tcp: add tcp_v4_fill_cb()/tcp_v4_restore_cb()

2017-12-03 Thread David Miller
From: Eric Dumazet Date: Sun, 3 Dec 2017 09:32:58 -0800 > James Morris reported kernel stack corruption bug that > we tracked back to commit 971f10eca186 ("tcp: better TCP_SKB_CB > layout to reduce cache line misses") > > First patch needs to be backported to kernels >=

Re: [RFC] virtio-net: help live migrate SR-IOV devices

2017-12-03 Thread Stephen Hemminger
On Sun, 3 Dec 2017 11:14:37 +0200 achiad shochat wrote: > On 3 December 2017 at 07:05, Michael S. Tsirkin wrote: > > On Fri, Dec 01, 2017 at 12:08:59PM -0800, Shannon Nelson wrote: > >> On 11/30/2017 6:11 AM, Michael S. Tsirkin wrote: > >> > On

[PATCH net 0/2] tcp: add tcp_v4_fill_cb()/tcp_v4_restore_cb()

2017-12-03 Thread Eric Dumazet
James Morris reported kernel stack corruption bug that we tracked back to commit 971f10eca186 ("tcp: better TCP_SKB_CB layout to reduce cache line misses") First patch needs to be backported to kernels >= 3.18, while second patch needs to be backported to kernels >= 4.9, since this was the time

Re: [PATCH net 0/2] tcp: fix SELinux/Smack corruptions

2017-12-03 Thread Eric Dumazet
On Sun, 2017-12-03 at 10:42 -0500, David Miller wrote: > From: Eric Dumazet > Date: Fri,  1 Dec 2017 15:08:11 -0800 > > > James Morris reported kernel stack corruption bug that > > we tracked back to commit 971f10eca186 ("tcp: better TCP_SKB_CB > > layout to reduce cache

[PATCH net 2/2] tcp: use IPCB instead of TCP_SKB_CB in inet_exact_dif_match()

2017-12-03 Thread Eric Dumazet
From: David Ahern After this fix : ("tcp: add tcp_v4_fill_cb()/tcp_v4_restore_cb()"), socket lookups happen while skb->cb[] has not been mangled yet by TCP. Fixes: a04a480d4392 ("net: Require exact match for TCP socket lookups if dif is l3mdev") Signed-off-by: David Ahern

[PATCH net 1/2] tcp: add tcp_v4_fill_cb()/tcp_v4_restore_cb()

2017-12-03 Thread Eric Dumazet
James Morris reported kernel stack corruption bug [1] while running the SELinux testsuite, and bisected to a recent commit bffa72cf7f9d ("net: sk_buff rbnode reorg") We believe this commit is fine, but exposes an older bug. SELinux code runs from tcp_filter() and might send an ICMP, expecting IP

Re: [PATCH v3 1/6] perf: prepare perf_event.h for new types perf_kprobe and perf_uprobe

2017-12-03 Thread Alexei Starovoitov
On Thu, Nov 30, 2017 at 03:50:18PM -0800, Song Liu wrote: > Two new perf types, perf_kprobe and perf_uprobe, will be added to allow > creating [k,u]probe with perf_event_open. These [k,u]probe are associated > with the file decriptor created by perf_event_open, thus are easy to > clean when the

Re: [PATCH v5 net-next,mips 6/7] netdev: octeon-ethernet: Add Cavium Octeon III support.

2017-12-03 Thread David Miller
From: David Daney Date: Fri, 1 Dec 2017 15:18:06 -0800 > +static char *mix_port; > +module_param(mix_port, charp, 0444); > +MODULE_PARM_DESC(mix_port, "Specifies which ports connect to MIX > interfaces."); > + > +static char *pki_port; > +module_param(pki_port, charp,

Re: [PATCH v2 net-next] netlink: optimize err assignment

2017-12-03 Thread David Miller
From: Eric Dumazet Date: Sun, 03 Dec 2017 07:20:09 -0800 > On Sun, 2017-12-03 at 21:10 +0800, yuan linyu wrote: >> From: yuan linyu >> >> Signed-off-by: yuan linyu >> --- >> v2: fix kbuild test warning

Re: [PATCH net-next V2 1/2] net-next: use five-tuple hash for sk_txhash

2017-12-03 Thread Tom Herbert
On Sun, Dec 3, 2017 at 7:38 AM, David Miller wrote: > From: Shaohua Li > Date: Fri, 1 Dec 2017 13:00:43 -0800 > >> This causes our router doesn't correctly close tcp connection. > > Then please fix your router. > > How many times do I have to say this...

Re: [PATCH net 0/2] tcp: fix SELinux/Smack corruptions

2017-12-03 Thread David Miller
From: Eric Dumazet Date: Fri, 1 Dec 2017 15:08:11 -0800 > James Morris reported kernel stack corruption bug that > we tracked back to commit 971f10eca186 ("tcp: better TCP_SKB_CB > layout to reduce cache line misses") > > First patch needs to be backported to kernels >=

Re: [PATCH net-next V2 1/2] net-next: use five-tuple hash for sk_txhash

2017-12-03 Thread David Miller
From: Shaohua Li Date: Fri, 1 Dec 2017 13:00:43 -0800 > This causes our router doesn't correctly close tcp connection. Then please fix your router. How many times do I have to say this... The flowlabel is not part of the socket connection identity, therefore you cannot use

Re: [PATCH v2 net-next] netlink: optimize err assignment

2017-12-03 Thread Eric Dumazet
On Sun, 2017-12-03 at 21:10 +0800, yuan linyu wrote: > From: yuan linyu > > Signed-off-by: yuan linyu > --- > v2: fix kbuild test warning > --- >  net/netlink/af_netlink.c | 52 >

Re: [PATCH v2 net-next 0/4] tcp: Add a 2nd listener hashtable (port+addr)

2017-12-03 Thread David Miller
From: Martin KaFai Lau Date: Fri, 1 Dec 2017 12:52:28 -0800 > This patch set adds a 2nd listener hashtable. It is to resolve > the performance issue when a process is listening at many IP > addresses with the same port (e.g. [IP1]:443, [IP2]:443... [IPN]:443) > > v2: > - Move the

Re: [PATCH net-next] enic: add sw timestamp support

2017-12-03 Thread David Miller
From: Govindarajulu Varadarajan Date: Fri, 1 Dec 2017 10:21:40 -0800 > Add ethtool ops to advertise sw timestamping. > Call skb_tx_timestamp() just before ringing the wq doorbell. > > Signed-off-by: Govindarajulu Varadarajan ... > diff --git

Re: [PATCH net-next 0/6] hv_netvsc: minor optimizations

2017-12-03 Thread David Miller
From: Stephen Hemminger Date: Fri, 1 Dec 2017 11:01:43 -0800 > These are a set of local optimizations the Hyper-V networking driver. > Also include a vmbus patch in this set, because it depends on the > netvsc that last used that function. Series applied. For the

Re: [PATCH net] rxrpc: Fix the MAINTAINERS record

2017-12-03 Thread David Miller
From: David Howells Date: Fri, 01 Dec 2017 11:10:37 + > Fix the MAINTAINERS record so that it's more obvious who the maintainer for > AF_RXRPC is. > > Reported-by: Joe Perches > Reported-by: David Miller > Signed-off-by: David

Re: [PATCH net] rxrpc: Use correct netns source in rxrpc_release_sock()

2017-12-03 Thread David Miller
From: David Howells Date: Fri, 01 Dec 2017 11:09:53 + > In rxrpc_release_sock() there may be no rx->local value to access, so we > can't unconditionally follow it to the rxrpc network namespace information > to poke the connection reapers. > > Instead, use the socket's

Re: [PATCH] liquidio: fix incorrect indentation of assignment statement

2017-12-03 Thread David Miller
From: Colin King Date: Fri, 1 Dec 2017 12:38:11 + > From: Colin Ian King > > Remove one extraneous level of indentation on assignment statement. > > Signed-off-by: Colin Ian King Applied.

Re: pull-request: can 2017-12-01

2017-12-03 Thread David Miller
From: Marc Kleine-Budde Date: Fri, 1 Dec 2017 15:17:30 +0100 > this is a pull for net consisting of nine patches. > > The first three patches are by Jimmy Assarsson for the kvaser_usb driver > and add the missing free()s in some error path, a signed/unsigned > comparison

Re: [PATCH net-next 00/11] SFP/phylink updates

2017-12-03 Thread David Miller
From: Russell King - ARM Linux Date: Fri, 1 Dec 2017 10:23:07 + > This series, which follows on from the fixes posted earlier, improves > the phylink/sfp support. Changes included here are: Ok, I'll merge this in the next time I get 'net' into 'net-next'.

Re: [PATCH net] stmmac: reset last TSO segment size after device open

2017-12-03 Thread David Miller
From: Lars Persson Date: Fri, 1 Dec 2017 11:12:44 +0100 > The mss variable tracks the last max segment size sent to the TSO > engine. We do not update the hardware as long as we receive skb:s with > the same value in gso_size. > > During a network device down/up cycle

Re: [PATCH net-next] ipvlan: Add new func ipvlan_is_valid_dev instead of duplicated codes

2017-12-03 Thread David Miller
From: gfree.w...@vip.163.com Date: Fri, 1 Dec 2017 16:33:03 +0800 > From: Gao Feng > > There are multiple duplicated condition checks in the current codes, so > I add the new func ipvlan_is_valid_dev instead of the duplicated codes to > check if the netdev is real

Re: [PATCH net] ipvlan: Add the skb->mark as flow4's member to lookup route

2017-12-03 Thread David Miller
From: gfree.w...@vip.163.com Date: Fri, 1 Dec 2017 09:58:42 +0800 > From: Gao Feng > > Current codes don't use skb->mark to assign flowi4_mark, it would > make the policy route rule with fwmark doesn't work as expected. > > Signed-off-by: Gao Feng

Re: [PATCH net-next 0/5] Realtek Ethernet PHY driver improvements

2017-12-03 Thread David Miller
From: Martin Blumenstingl Date: Sat, 2 Dec 2017 22:51:23 +0100 > This series provides some small improvements and cleanups for the > Realtek Ethernet PHY driver. > None of the patches in this series should change any functionality. > The goal is to make the

RE: [PATCH net v2 2/3] xfrm: Add an activate() offload dev op

2017-12-03 Thread Yossi Kuperman
> -Original Message- > From: Boris Pismenny > Sent: Sunday, December 3, 2017 1:29 PM > To: Yossi Kuperman ; Steffen Klassert > > Cc: Aviv Heller ; Herbert Xu > ; Yevgeny Kliteynik

Re: [PATCH net-next 0/8] Hisilicon Network Subsystem 3 VF Ethernet Driver

2017-12-03 Thread Or Gerlitz
On Sun, Dec 3, 2017 at 2:32 PM, Salil Mehta wrote: > This patch-set contains the support of the HNS3 (Hisilicon Network Subsystem > 3) > Virtual Function Ethernet driver for hip08 family of SoCs. The Physical > Function > driver is already part of the Linux mainline. > >

[PATCH v2 net-next] netlink: optimize err assignment

2017-12-03 Thread yuan linyu
From: yuan linyu Signed-off-by: yuan linyu --- v2: fix kbuild test warning --- net/netlink/af_netlink.c | 52 1 file changed, 22 insertions(+), 30 deletions(-) diff --git

[PATCH net-next 1/8] net: hns3: Add HNS3 VF IMP(Integrated Management Proc) cmd interface

2017-12-03 Thread Salil Mehta
This patch adds support of command interface for communication with the IMP(Integrated Management Processor) for HNS3 Virtual Function Driver. Each VF has support of CQP(Command Queue Pair) ring interface. Each CQP consis of send queue CSQ and receive queue CRQ. There are various commands a VF

[PATCH net-next 2/8] net: hns3: Add mailbox support to VF driver

2017-12-03 Thread Salil Mehta
This patch adds the support of the mailbox to the VF driver. The mailbox shall be used as an interface to communicate with the PF driver for various purposes like {set|get} MAC related operations, reset, link status etc. The mailbox supports both synchronous and asynchronous command send to PF

[PATCH net-next 5/8] net: hns3: Unified HNS3 {VF|PF} Ethernet Driver for hip08 SoC

2017-12-03 Thread Salil Mehta
Most of the NAPI handling interface, skb buffer management, management of the RX/TX descriptors, ethool interface etc. has quite a bit of code which is common to VF and PF driver. This patch makes the exisitng PF's HNS3 ENET driver as the common ENET driver for both Virtual & Physical Function.

[PATCH net-next 4/8] net: hns3: Add HNS3 VF driver to kernel build framework

2017-12-03 Thread Salil Mehta
This patch introduces the new Makefiles and updates existing Makefiles required to build the HNS3 Virtual Function driver. This also updates the Kconfig for introduction of new menuconfig entries related to VF driver. Signed-off-by: Salil Mehta Signed-off-by: lipeng

[PATCH net-next 7/8] net: hns3: Change PF to add ring-vect binding & resetQ to mailbox

2017-12-03 Thread Salil Mehta
This patch is required to support ring-vector binding and reset of TQPs requested by the VF driver to the PF driver. Mailbox handler is added with corresponding VF commands/messages to handle the request. Signed-off-by: Salil Mehta Signed-off-by: lipeng

[PATCH net-next 6/8] net: hns3: Add mailbox support to PF driver

2017-12-03 Thread Salil Mehta
Command queue provides the provision of Mailbox command which can be used for communication between PF and VF. PF handles messages from various VFs for fetching various information like, queue, vlan, link status related etc. It also handles the request from various VFs to perform certain

[PATCH net-next 8/8] net: hns3: Add mailbox interrupt handling to PF driver

2017-12-03 Thread Salil Mehta
All PF mailbox events are conveyed through a common interrupt (vector 0). This interrupt vector is shared by reset and mailbox. This patch adds the handling of mailbox interrupt event and its deferred processing in context to a separate mailbox task. Signed-off-by: Salil Mehta

[PATCH net-next 3/8] net: hns3: Add HNS3 VF HCL(Hardware Compatibility Layer) Support

2017-12-03 Thread Salil Mehta
This patch adds the support of hardware compatibiltiy layer to the HNS3 VF Driver. This layer implements various {set|get} operations over MAC address for a virtual port, RSS related configuration, fetches the link status info from PF, does various VLAN related configuration over the virtual port,

[PATCH net-next 0/8] Hisilicon Network Subsystem 3 VF Ethernet Driver

2017-12-03 Thread Salil Mehta
This patch-set contains the support of the HNS3 (Hisilicon Network Subsystem 3) Virtual Function Ethernet driver for hip08 family of SoCs. The Physical Function driver is already part of the Linux mainline. This VF driver has its Hardware Compatibility Layer and has commom/unified ENET

Re: [PATCH 1/3] dt-bindings: net: Add DT bindings for Socionext Netsec

2017-12-03 Thread Jassi Brar
On Fri, Dec 1, 2017 at 2:42 PM, Ard Biesheuvel wrote: > Hi Jassi, > > On 30 November 2017 at 16:12, wrote: >> From: Jassi Brar >> >> This patch adds documentation for Device-Tree bindings for the >> Socionext NetSec

Re: Linux 4.14 - regression: broken tun/tap / bridge network with virtio - bisected

2017-12-03 Thread Andreas Hartmann
On 12/01/2017 at 11:11 AM Andreas Hartmann wrote: > Hello! > > I hopefully could get rid of both of my problems (hanging network w/ > virtio) and endless hanging qemu-process on VM shutdown by upgrading > qemu from 2.6.2 to 2.10.1. I hope it will persist. It didn't persist. 10h later - same

RE: [PATCH net v2 2/3] xfrm: Add an activate() offload dev op

2017-12-03 Thread Boris Pismenny
> -Original Message- > From: Yossi Kuperman > Sent: Sunday, December 03, 2017 00:34 > To: Steffen Klassert > Cc: Aviv Heller ; Herbert Xu > ; Boris Pismenny ; > Yevgeny Kliteynik

Re: [PATCH net-next v4 2/2] net: ethernet: socionext: add AVE ethernet driver

2017-12-03 Thread kbuild test robot
Hi Kunihiko, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/Kunihiko-Hayashi/dt-bindings-net-add-DT-bindings-for-Socionext-UniPhier-AVE/20171203-095248 config: ia64-allyesconfig (attached

Re: [RFC] virtio-net: help live migrate SR-IOV devices

2017-12-03 Thread achiad shochat
On 3 December 2017 at 07:05, Michael S. Tsirkin wrote: > On Fri, Dec 01, 2017 at 12:08:59PM -0800, Shannon Nelson wrote: >> On 11/30/2017 6:11 AM, Michael S. Tsirkin wrote: >> > On Thu, Nov 30, 2017 at 10:08:45AM +0200, achiad shochat wrote: >> > > Re. problem #2: >> > > Indeed

Re: [PATCH] ethtool: Add ETHTOOL_RESET support via --reset command

2017-12-03 Thread Gal Pressman
On 30-Nov-17 21:24, Scott Branden wrote: > Add ETHTOOL_RESET support via --reset command. > > ie. ethtool --reset DEVNAME > > flagnames currently match the ETH_RESET_xxx names: > mgmt,irq,dma,filter,offload,mac,phy,ram,dedicated,all > > Alternatively, you can specific component