RE: [PATCH net-next v4 4/5] bnx2x: Use NETIF_F_GRO_HW.

> -Original Message- > From: Michael Chan [mailto:michael.c...@broadcom.com] > Sent: Thursday, December 14, 2017 2:16 AM > To: Chopra, Manish > Cc: da...@davemloft.net; netdev@vger.kernel.org; > andrew.gospoda...@broadcom.com; Elior, Ariel

Re: [PATCH ipsec-next] xfrm: check for xdo_dev_state_free

Hi Shannon, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on ipsec-next/master] url: https://github.com/0day-ci/linux/commits/Shannon-Nelson/xfrm-check-for-xdo_dev_state_free/20171214-150202 base:

Re: [PATCH v3 net-next 6/9] net: Generic resolver backend

Hi Tom, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/Tom-Herbert/net-Generic-network-resolver-backend-and-ILA-resolver/20171214-142440 config: i386-randconfig-x016-201750 (attached as

Re: [PATCH v9 0/5] Add the ability to do BPF directed error injection

On Wed, 13 Dec 2017 13:57:45 -0500 Josef Bacik wrote: > On Wed, Dec 13, 2017 at 10:07:32AM -0800, Darrick J. Wong wrote: > > On Wed, Dec 13, 2017 at 01:03:57PM -0500, Josef Bacik wrote: > > > On Tue, Dec 12, 2017 at 03:11:50PM -0800, Darrick J. Wong wrote: > > > > On Mon,

Re: [bpf-next V1-RFC PATCH 02/14] xdp/mlx5: setup xdp_rxq_info and extend with qtype

On Wed, 13 Dec 2017 15:03:33 -0800 Saeed Mahameed wrote: > >>> @@ -707,6 +714,8 @@ static void mlx5e_free_rq(struct mlx5e_rq *rq) > >>> if (rq->xdp_prog) > >>> bpf_prog_put(rq->xdp_prog); > >>> > >>> + xdp_rxq_info_unreg(>xdp_rxq); > >>> + >

Re: [PATCH ipsec-next] xfrm: check for xdo_dev_state_free

On Mon, Dec 11, 2017 at 12:57:22PM -0800, Shannon Nelson wrote: > The current XFRM code assumes that we've implemented the > xdo_dev_state_free() callback, even if it is meaningless to the driver. > This patch adds a check for it before calling, as done in other APIs, > and is done for the

Re: [PATCH 1/2] hp100: Fix a possible sleep-in-atomic bug in hp100_login_to_vg_hub

Sorry, I think I know your meaning now. Maybe we can unlock the spinlock before "schedule_timeout_interruptible" and then lock again? Like: spin_unlock(...); schedule_timeout_interruptible(1); spin_lock(...); Best wishes, Jia-Ju Bai On 2017/12/14 11:34, David Miller wrote:

Re: [PATCH 1/2] hp100: Fix a possible sleep-in-atomic bug in hp100_login_to_vg_hub

From: Jia-Ju Bai Date: Thu, 14 Dec 2017 11:13:15 +0800 > Thanks for reply :) > I think I should use "udelay(10/HZ)" instead, do you think it is > right? The delay is too long, please do not ignore that part of my critique of your change. You cannot delay so long

Re: [PATCH 1/2] hp100: Fix a possible sleep-in-atomic bug in hp100_login_to_vg_hub

Sorry, I made a mistake in last e-mail. Maybe "mdelay(1000/HZ)" or "udelay(100/HZ)" . Which one do you think is right? Thanks, Jia-Ju Bai On 2017/12/14 11:13, Jia-Ju Bai wrote: Thanks for reply :) I think I should use "udelay(10/HZ)" instead, do you think it is right? Thanks,

[PATCH v4 13/14] nubus: Add expansion_type values for various Mac models

Add an expansion slot attribute to allow drivers to properly handle cards like Comm Slot cards and PDS cards without declaration ROMs. This clarifies the logic for the Centris 610 model which has no Comm Slot but has an optional on-board SONIC device. Cc: "David S. Miller"

[PATCH v4 12/14] nubus: Adopt standard linked list implementation

This increases code re-use and improves readability. Cc: "David S. Miller" Cc: Bartlomiej Zolnierkiewicz Acked-by: Bartlomiej Zolnierkiewicz Tested-by: Stan Johnson Signed-off-by: Finn Thain

[PATCH v4 11/14] nubus: Rename struct nubus_dev

It is misleading to call a functional resource a "device". In adopting the Linux Driver Model, the struct device will be embedded in struct nubus_board. That will compound the terminlogy problem because drivers will bind with boards, not with functional resources. Avoid this by renaming struct

Re: [PATCH 1/2] hp100: Fix a possible sleep-in-atomic bug in hp100_login_to_vg_hub

Thanks for reply :) I think I should use "udelay(10/HZ)" instead, do you think it is right? Thanks, Jia-Ju Bai On 2017/12/14 5:20, David Miller wrote: I want you to review all of your patches and resend them after you have checked them carefully. The first patch I even looked at, this

Re: [BUG] skge: a possible sleep-in-atomic bug in skge_remove

On 2017/12/14 0:50, Stephen Hemminger wrote: On Wed, 13 Dec 2017 15:42:56 +0800 Jia-Ju Bai wrote: On 2017/12/13 13:18, Stephen Hemminger wrote: On Tue, 12 Dec 2017 20:57:01 -0500 (EST) David Miller wrote: From: Stephen Hemminger

[PATCH v2] ARM64: dts: meson-axg: add ethernet mac controller

Add DT info for the stmmac ethernet MAC which found in the Amlogic's Meson-AXG SoC, also describe the ethernet pinctrl & clock information here. This is tested in the S400 dev board which use a RTL8211F PHY, and the pins connect to the 'eth_rgmii_y_pins' group. Reviewed-by: Neil Armstrong

Re: [bpf-next V1-RFC PATCH 08/14] nfp: setup xdp_rxq_info

On Wed, 13 Dec 2017 12:20:01 +0100, Jesper Dangaard Brouer wrote: > Driver hook points for xdp_rxq_info: > * init+reg: nfp_net_rx_ring_alloc > * unreg : nfp_net_rx_ring_free > > In struct nfp_net_rx_ring moved member @size into a hole on 64-bit. > Thus, the size remaines the same after adding

Re: [bpf-next V1-RFC PATCH 01/14] xdp: base API for new XDP rx-queue info concept

On 12/13/17 4:19 AM, Jesper Dangaard Brouer wrote: > + > +void xdp_rxq_info_unreg(struct xdp_rxq_info *xdp_rxq) > +{ > + xdp_rxq->reg_state = REG_STATE_UNREGISTRED; > +} > +EXPORT_SYMBOL_GPL(xdp_rxq_info_unreg); > + > +void xdp_rxq_info_init(struct xdp_rxq_info *xdp_rxq) > +{ > + if

Re: [PATCH iproute2] ip: add vxcan to help text

On Wed, 13 Dec 2017 21:21:28 +0100 Oliver Hartkopp wrote: > Add missing tag 'vxcan' inside the help text which was missing in commit > efe459c76d35f ('ip: link add vxcan support'). > > Signed-off-by: Oliver Hartkopp Applied. Could you also fix

Re: [patch iproute2] tc: fix json array closing

On Wed, 13 Dec 2017 20:56:16 +0100 Jiri Pirko wrote: > From: Jiri Pirko > > Fixes: 2704bd625583 ("tc: jsonify actions core") > Signed-off-by: Jiri Pirko Good catch. Applied

Re: [PATCH net-next 0/4] ERSPAN version 2 (type III) support

On Wed, Dec 13, 2017 at 5:54 PM, Stephen Hemminger wrote: > On Wed, 13 Dec 2017 16:38:54 -0800 > William Tu wrote: > >> ERSPAN has two versions, v1 (type II) and v2 (type III). This patch >> series add support for erspan v2 based on existing

Re: [PATCH net-next 0/4] ERSPAN version 2 (type III) support

On Wed, 13 Dec 2017 16:38:54 -0800 William Tu wrote: > ERSPAN has two versions, v1 (type II) and v2 (type III). This patch > series add support for erspan v2 based on existing erspan v1 > implementation. The first patch refactors the existing erspan v1's > header structure,

Re: [PATCH 1/2] hp100: Fix a possible sleep-in-atomic bug in hp100_login_to_vg_hub

On Wed, 2017-12-13 at 17:47 +0800, Jia-Ju Bai wrote: > The driver may sleep under a spinlock. > The function call path is: > hp100_set_multicast_list (acquire the spinlock) > hp100_login_to_vg_hub > schedule_timeout_interruptible --> may sleep > > To fix it, schedule_timeout_interruptible

Re: [PATCH v6 2/3] sock: Move the socket inuse to namespace.

On Wed, Dec 13, 2017 at 2:04 AM, Cong Wang wrote: > On Sun, Dec 10, 2017 at 7:12 AM, Tonghao Zhang > wrote: >> diff --git a/net/core/net_namespace.c b/net/core/net_namespace.c >> index b797832..6c191fb 100644 >> --- a/net/core/net_namespace.c

Re: [patch net-next v3 05/10] net: sched: keep track of offloaded filters and check tc offload feature

On Wed, 13 Dec 2017 16:10:33 +0100, Jiri Pirko wrote: > From: Jiri Pirko > > During block bind, we need to check tc offload feature. If it is > disabled yet still the block contains offloaded filters, forbid the > bind. Also forbid to register callback for a block that already

Re: [PATCH] openvswitch: Trim off padding before L3 conntrack processing

On Tue, Dec 12, 2017 at 8:17 AM, Ed Swierk wrote: > A short IPv4 packet may have up to 6 bytes of padding following the IP > payload when received on an Ethernet device. > > In the normal IPv4 receive path, ip_rcv() trims the packet to > ip_hdr->tot_len before invoking

Re: [PATCH net] vxlan: Restore initial MTU setting based on lower device

On 12/14/2017 01:31 AM, Stefano Brivio wrote: > On Thu, 14 Dec 2017 01:25:40 +0100 > Matthias Schiffer wrote: > >> On 12/14/2017 01:10 AM, Stefano Brivio wrote: >>> On Thu, 14 Dec 2017 00:57:32 +0100 >>> Matthias Schiffer wrote:

Re: [patch net-next v3 00/10] net: sched: allow qdiscs to share filter block instances

On Wed, 13 Dec 2017 19:42:41 +0100, Jiri Pirko wrote: > I plan to do it as a follow-up patch. But this is how things are done > now and have to continue to work. > >>> > >>> Why is that? You are introducing the notion of a shared block with this > >>> patch set. What is the legacy "how

[PATCH net-next 0/4] ERSPAN version 2 (type III) support

ERSPAN has two versions, v1 (type II) and v2 (type III). This patch series add support for erspan v2 based on existing erspan v1 implementation. The first patch refactors the existing erspan v1's header structure, making it extensible to put additional v2's header. The second and third patch

[PATCH net-next 2/4] net: erspan: introduce erspan v2 for ip_gre

The patch adds support for erspan version 2. Not all features are supported in this patch. The SGT (security group tag), GRA (timestamp granularity), FT (frame type) are set to fixed value. Only hardware ID and direction are configurable. Optional subheader is also not supported.

[PATCH net-next 4/4] samples/bpf: add erspan v2 sample code

Extend the existing tests for ipv4 ipv6 erspan version 2. Signed-off-by: William Tu --- samples/bpf/tcbpf2_kern.c | 77 +- samples/bpf/test_tunnel_bpf.sh | 38 +++-- 2 files changed, 96 insertions(+), 19

[PATCH net-next 1/4] net: erspan: refactor existing erspan code

The patch refactors the existing erspan implementation in order to support erspan version 2, which has additional metadata. So, in stead of having one 'struct erspanhdr' holding erspan version 1, breaks it into 'struct erspan_base_hdr' and 'struct erspan_metadata'. Signed-off-by: William Tu

[PATCH net-next 3/4] ip6_gre: add erspan v2 support

Similar to support for ipv4 erspan, this patch adds erspan v2 to ip6erspan tunnel. Signed-off-by: William Tu --- include/net/ip6_tunnel.h | 3 ++ net/ipv6/ip6_gre.c | 120 --- 2 files changed, 107 insertions(+), 16

Re: [PATCH net] vxlan: Restore initial MTU setting based on lower device

On Thu, 14 Dec 2017 01:25:40 +0100 Matthias Schiffer wrote: > On 12/14/2017 01:10 AM, Stefano Brivio wrote: > > On Thu, 14 Dec 2017 00:57:32 +0100 > > Matthias Schiffer wrote: > > > >> As you note, there is another occurrence of

[PATCH iproute2 net-next] erspan: add erspan version II support

The patch adds support for configuring the erspan v2, for both ipv4 and ipv6 erspan implementation. Three additional fields are added: 'erspan_ver' for distinguishing v1 or v2, 'erspan_dir' for specifying direction of the mirrored traffic, and 'erspan_hwid' for users to set ERSPAN engine ID

Re: [PATCH net] vxlan: Restore initial MTU setting based on lower device

On 12/14/2017 01:10 AM, Stefano Brivio wrote: > On Thu, 14 Dec 2017 00:57:32 +0100 > Matthias Schiffer wrote: > >> As you note, there is another occurrence of this calculation in >> vxlan_config_apply(): >> >> >> [...] >> if (lowerdev) { >> [...] >>

Re: [PATCH net] vxlan: Restore initial MTU setting based on lower device

On Thu, 14 Dec 2017 00:57:32 +0100 Matthias Schiffer wrote: > As you note, there is another occurrence of this calculation in > vxlan_config_apply(): > > > [...] > if (lowerdev) { > [...] > max_mtu = lowerdev->mtu - (use_ipv6 ?

Re: [PATCH net] vxlan: Restore initial MTU setting based on lower device

On 12/13/2017 11:37 PM, Stefano Brivio wrote: > Commit a985343ba906 ("vxlan: refactor verification and > application of configuration") introduced a change in the > behaviour of initial MTU setting: earlier, the MTU for a link > created on top of a given lower device, without an initial MTU >

Re: [PATCH] net: thunderx: add support for rgmii internal delay

On Wed, Dec 13, 2017 at 3:10 AM, Andrew Lunn wrote: >> +void xcv_init_hw(int phy_mode) >> { >> u64 cfg; >> >> @@ -81,12 +81,31 @@ void xcv_init_hw(void) >> /* Wait for DLL to lock */ >> msleep(1); >> >> - /* Configure DLL - enable or bypass >> - * TX

Re: [PATCH net] vxlan: Restore initial MTU setting based on lower device

On Wed, 13 Dec 2017 23:37:00 +0100 Stefano Brivio wrote: > Commit a985343ba906 ("vxlan: refactor verification and > application of configuration") introduced a change in the > behaviour of initial MTU setting: earlier, the MTU for a link > created on top of a given lower

Re: BUG REPORT: iproute2 seems to have bug with dsfield/tos in ip-rule and ip-route

On 12/13/17 3:52 PM, Daniel Lakeland wrote: > On 12/13/2017 02:40 PM, David Ahern wrote: >> >> In fib4_rule_configure, this the check that is failing: >> >> if (frh->tos & ~IPTOS_TOS_MASK) >> goto errout; >> >> and EINVAL is returned. >> >> IPv4 routes has not checking on tos -- it

Re: [bpf-next V1-RFC PATCH 02/14] xdp/mlx5: setup xdp_rxq_info and extend with qtype

On 12/13/2017 5:44 AM, Jesper Dangaard Brouer wrote: On Wed, 13 Dec 2017 14:27:08 +0200 Tariq Toukan wrote: Hi Jesper, Thanks for taking care of the drop RQ. In general, mlx5 part looks ok to me. Find a few comments below. Mostly pointing out some typos. On 13/12/2017

Re: BUG REPORT: iproute2 seems to have bug with dsfield/tos in ip-rule and ip-route

On 12/13/2017 02:40 PM, David Ahern wrote: In fib4_rule_configure, this the check that is failing: if (frh->tos & ~IPTOS_TOS_MASK) goto errout; and EINVAL is returned. IPv4 routes has not checking on tos -- it is passed from user and rtm_tos to fc_tos to fib alias tos. it

Re: [bpf-next V1-RFC PATCH 12/14] xdp: generic XDP handling of xdp_rxq_info

On 12/13/2017 3:20 AM, Jesper Dangaard Brouer wrote: Hook points for xdp_rxq_info: * init+reg: netif_alloc_rx_queues * unreg : netif_free_rx_queues The net_device have some members (num_rx_queues + real_num_rx_queues) and data-area (dev->_rx with struct netdev_rx_queue's) that were

[PATCH net-next 1/2] nfp: extend NSP infrastructure for configurable timeouts

From: Dirk van der Merwe The firmware flashing NSP operation takes longer to execute than the current default timeout. We need a mechanism to set a longer timeout for some commands. This patch adds the infrastructure to this. The default timeout is still 30

[PATCH net-next 2/2] nfp: implement firmware flashing

From: Dirk van der Merwe Firmware flashing takes around 60s (specified to not take more than 70s). Prevent hogging the RTNL lock in this time and make use of the longer timeout for the NSP command. The timeout is set to 2.5 * 70 seconds. We only allow flashing

[PATCH net-next 0/2] nfp: ethtool flash updates

Dirk says: This series adds the ability to update the control FW with ethtool. It should be noted that the locking scheme here is to release the RTNL lock before the flashing operation and to take it again afterwards to ensure consistent state from the core code point of view. In this time, we

[PATCH next 1/2] Revert "ipvlan: add L2 check for packets arriving via virtual devices"

From: Mahesh Bandewar This reverts commit 92ff42645028fa6f9b8aa767718457b9264316b4. Even though the check added is not that taxing, it's not really needed. First of all this will be per packet cost and second thing is that the eth_type_trans() already does this correctly.

[PATCH next 0/2] ipvlan: packet scrub

From: Mahesh Bandewar While crossing namespace boundary IPvlan aggressively scrubs packets. This is creating problems. First thing is that scrubbing changes the packet type in skb meta-data to PACKET_HOST. This causes erroneous packet delivery when dev_forward_skb() has

[PATCH next 2/2] ipvlan: remove excessive packet scrubbing

From: Mahesh Bandewar IPvlan currently scrubs packets at every location where packets may be crossing namespace boundary. Though this is desirable, currently IPvlan does it more than necessary. e.g. packets that are going to take dev_forward_skb() path will get scrubbed so no

Re: BUG REPORT: iproute2 seems to have bug with dsfield/tos in ip-rule and ip-route

On 12/13/17 12:05 PM, Daniel Lakeland wrote: > Following up my previous email with output from the machine: > Note that like some of those other people I was able to get ip rule to > accept tos values with just low order bits set > > Here is example of how ip rule accepts low order dsfield bits

[PATCH net] vxlan: Restore initial MTU setting based on lower device

Commit a985343ba906 ("vxlan: refactor verification and application of configuration") introduced a change in the behaviour of initial MTU setting: earlier, the MTU for a link created on top of a given lower device, without an initial MTU specification, was set to the MTU of the lower device minus

Re: pull-request: bpf 2017-12-13

From: Daniel Borkmann Date: Wed, 13 Dec 2017 23:19:12 +0100 > The following pull-request contains BPF updates for your *net* tree. > > The main changes are: > > 1) Addition of explicit scheduling points to map alloc/free >in order to avoid having to hold the CPU for

Re: [PATCH v2 net-next 0/7] net: speedup netns create/delete time

On Wed, Dec 13, 2017 at 1:52 PM, Eric Dumazet wrote: > On Wed, 2017-12-13 at 13:43 -0800, Dmitry Torokhov wrote: >> Hi Eric, >> >> On Thu, Oct 19, 2017 at 7:11 AM, Eric Dumazet wrote: >> > >> > On Thu, Oct 19, 2017 at 4:48 AM, Tariq Toukan

pull-request: bpf 2017-12-13

Hi David, The following pull-request contains BPF updates for your *net* tree. The main changes are: 1) Addition of explicit scheduling points to map alloc/free in order to avoid having to hold the CPU for too long, from Eric. 2) Fixing of a corruption in overlapping perf_event_output

Re: [PATCH v4 net-next 4/4] bpftool: implement cgroup bpf operations

On Wed, 13 Dec 2017 15:18:54 +, Roman Gushchin wrote: > This patch adds basic cgroup bpf operations to bpftool: > cgroup list, attach and detach commands. > > Usage is described in the corresponding man pages, > and examples are provided. > > Syntax: > $ bpftool cgroup list CGROUP > $

Re: [PATCH v2 net-next 0/7] net: speedup netns create/delete time

On Wed, 2017-12-13 at 13:43 -0800, Dmitry Torokhov wrote: > Hi Eric, > > On Thu, Oct 19, 2017 at 7:11 AM, Eric Dumazet wrote: > > > > On Thu, Oct 19, 2017 at 4:48 AM, Tariq Toukan wrote: > > > > > > Hi Eric, > > > > > > I just wanted to check if this

Re: [PATCH net-next v2] bpf/tracing: fix kernel/events/core.c compilation error

On 12/13/2017 07:35 PM, Yonghong Song wrote: > Commit f371b304f12e ("bpf/tracing: allow user space to > query prog array on the same tp") introduced a perf > ioctl command to query prog array attached to the > same perf tracepoint. The commit introduced a > compilation error under certain config

Re: [PATCH v2 net-next 0/7] net: speedup netns create/delete time

Hi Eric, On Thu, Oct 19, 2017 at 7:11 AM, Eric Dumazet wrote: > > On Thu, Oct 19, 2017 at 4:48 AM, Tariq Toukan wrote: > > > > Hi Eric, > > > > I just wanted to check if this is solved already, as I don't want to keep an > > unnecessary revert patch in

Re: [PATCH net V2 0/3] mlx4 misc fixes

From: Tariq Toukan Date: Wed, 13 Dec 2017 18:12:08 +0200 > This patchset contains misc bug fixes from the team > to the mlx4 Core and Eth drivers. > > Patch 1 by Eugenia fixes an MTU issue in selftest. > Patch 2 by Eran fixes an accounting issue in the resource tracker. >

Re: [PATCH 2/5] VSOCK: extract connect/accept functions from vsock_diag_test.c

From: Stefan Hajnoczi Date: Wed, 13 Dec 2017 14:49:08 + > +#include > +#include "../../../include/uapi/linux/vm_sockets.h" > + ... > -#include "../../../include/uapi/linux/vm_sockets.h" > #include "../../../include/uapi/linux/vm_sockets_diag.h" This really should

Re: [PATCH v2 net-next] net: dsa: lan9303: Introduce lan9303_read_wait

From: Egil Hjelmeland Date: Wed, 13 Dec 2017 15:42:50 +0100 > Simplify lan9303_indirect_phy_wait_for_completion() > and lan9303_switch_wait_for_completion() by using a new function > lan9303_read_wait() > > Changes v1 -> v2: > - param 'mask' type u32 > - removed

Re: [PATCH net-next 2/2] net/sched: act_csum: don't use spinlock in the fast path

From: Davide Caratti Date: Wed, 13 Dec 2017 10:48:38 +0100 > Then, in the data path, use READ_ONCE() to > read those values, to avoid lock contention among multiple readers. ... > @@ -544,14 +543,12 @@ static int tcf_csum(struct sk_buff *skb, const struct > tc_action *a, >

Re: [PATCH 1/2] hp100: Fix a possible sleep-in-atomic bug in hp100_login_to_vg_hub

I want you to review all of your patches and resend them after you have checked them carefully. The first patch I even looked at, this one, is buggy. You changed a schedule_timeout_interruptible(1) into a udelay(10) That's not right. schedule_timeout_interruptible() takes a "jiffies"

Re: [PATCH] net: phy: marvell: avoid pause mode on SGMII-to-Copper for 88e151x

From: Russell King Date: Wed, 13 Dec 2017 09:22:09 + > @@ -924,6 +924,16 @@ static int m88e1510_config_init(struct phy_device > *phydev) > err = marvell_set_page(phydev, MII_MARVELL_COPPER_PAGE); > if (err < 0) >

Re: [PATCH net] dwc-xlgmac: Add co-maintainer

From: Jie Deng Date: Wed, 13 Dec 2017 12:04:12 +0800 > Jose Abreu will join to maintain dwc-xlgmac. > He will help with new feature development for > this driver. Thanks Jose and welcome on board! > > Signed-off-by: Jie Deng Applied.

Re: [PATCH] net: phy: marvell: avoid configuring fiber page for SGMII-to-Copper

From: Russell King Date: Wed, 13 Dec 2017 09:22:03 + > When in SGMII-to-Copper mode, the fiber page is used for the MAC facing > link, and does not require configuration of the fiber auto-negotiation > settings. Avoid trying. > > Signed-off-by: Russell King

Re: Huge memory leak with 4.15.0-rc2+

On 12/12/2017 09:57 AM, Paweł Staszewski wrote: > > > W dniu 2017-12-11 o 23:27, Paweł Staszewski pisze: >> >> >> W dniu 2017-12-11 o 23:15, John Fastabend pisze: >>> On 12/11/2017 01:48 PM, Paweł Staszewski wrote: W dniu 2017-12-11 o 22:23, Paweł Staszewski pisze: > Hi > >

Re: [PATCH net] tcp: refresh tcp_mstamp from timers callbacks

From: Eric Dumazet Date: Tue, 12 Dec 2017 18:22:52 -0800 > From: Eric Dumazet > > Only the retransmit timer currently refreshes tcp_mstamp > > We should do the same for delayed acks and keepalives. > > Even if RFC 7323 does not request it, this is

Re: net: phy: consolidate PHY reset in phy_init_hw()

On 12/13/2017 12:35 PM, Andrew Lunn wrote: On Wed, Dec 13, 2017 at 10:46:02AM -0800, Daniel Walker wrote: Hi, https://sjc-apl-grt32.cisco.com:8081/gitweb?p=xe-linux/kernel.git;a=commit;h=87aa9f9c61ad56d505641681812e92ad976f8608 Hi Daniel This is a 4 year old patch, so i'm kind of surprised

Re: [PATCH net] tcp: fix potential underestimation on rcv_rtt

From: Wei Wang Date: Tue, 12 Dec 2017 16:28:58 -0800 > From: Wei Wang > > When ms timestamp is used, current logic uses 1us in > tcp_rcv_rtt_update() when the real rcv_rtt is within 1 - 999us. > This could cause rcv_rtt underestimation. > Fix it by always

Re: [PATCH net-next 0/6] hv_netvsc: minor changes

From: Stephen Hemminger Date: Tue, 12 Dec 2017 16:48:34 -0800 > This includes minor cleanup of code in send and receive path and > also a new statistic to check for allocation failures. This also > eliminates some of the extra RCU when not needed. > > There is a

Re: [PATCH net-next v2 0/5] PHYLINK preparatory patches for DSA

From: Florian Fainelli Date: Tue, 12 Dec 2017 16:00:24 -0800 > In preparation for having DSA migrate to PHYLINK, I had to come up with a > number of preparatory patches: > > - we need to be able to pass phy_flags from an external component calling >

Re: [PATH net-next] tcp: pause Fast Open globally after third consecutive timeout

From: Yuchung Cheng Date: Tue, 12 Dec 2017 13:10:40 -0800 > Prior to this patch, active Fast Open is paused on a specific > destination IP address if the previous connections to the > IP address have experienced recurring timeouts . But recent > experiments by Microsoft

Re: [PATCH v3 net-next] net: ethernet: ti: cpdma: correct error handling for chan create

From: Ivan Khoronzhuk Date: Tue, 12 Dec 2017 23:06:35 +0200 > It's not correct to return NULL when that is actually an error and > function returns errors in any other wrong case. In the same time, > the cpsw driver and davinci emac doesn't check error case while >

Re: [PATCH net-next] cxgb4: Add support for ethtool i2c dump

From: Ganesh Goudar Date: Wed, 13 Dec 2017 01:04:05 +0530 > From: Arjun Vynipadath > > Adds support for ethtool get_module_info() and get_module_eeprom() > callbacks that will dump necessary information for a SFP. > > Signed-off-by: Arjun Vynipadath

Re: [PATCH net] skge: remove redundunt free_irq under spinlock

From: Stephen Hemminger Date: Tue, 12 Dec 2017 10:30:29 -0800 > The code to handle multi-port SKGE boards was freeing IRQ > twice. The first one was under lock and might sleep. > > Signed-off-by: Stephen Hemminger > --- > Given that

Re: [PATCH net-next v4 4/5] bnx2x: Use NETIF_F_GRO_HW.

On Wed, Dec 13, 2017 at 1:08 AM, Chopra, Manish wrote: > > Hi Michael, There seems a behavioral change here. This driver support two HW > aggregation modes [LRO and GRO] > With the changes, Interfaces come with HW GRO enabled and LRO disabled by > default as opposed

Re: net: phy: consolidate PHY reset in phy_init_hw()

On Wed, Dec 13, 2017 at 10:46:02AM -0800, Daniel Walker wrote: > > Hi, > > https://sjc-apl-grt32.cisco.com:8081/gitweb?p=xe-linux/kernel.git;a=commit;h=87aa9f9c61ad56d505641681812e92ad976f8608 Hi Daniel This is a 4 year old patch, so i'm kind of surprised nobody noticed this before. How did

[PATCH] Fix handling of verdicts after NF_QUEUE

A verdict of NF_STOLEN after NF_QUEUE will cause an incorrect return value and a potential kernel panic via double free of skb's This was broken by commit 7034b566a4e7 ("netfilter: fix nf_queue handling") and subsequently fixed in v4.10 by commit c63cbc460419 ("netfilter: use switch() to handle

[PATCH iproute2] ip: add vxcan to help text

Add missing tag 'vxcan' inside the help text which was missing in commit efe459c76d35f ('ip: link add vxcan support'). Signed-off-by: Oliver Hartkopp --- ip/ipaddress.c | 2 +- ip/iplink.c| 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git

Re: [PATCH iproute2] Show 'external' link mode in output

On Tue, 12 Dec 2017 12:23:19 -0800 Phil Dibowitz wrote: > Recently `external` support was added to the tunnel drivers, but there is no > way > to introspect this from userspace. This adds support for that. > > Now `ip -details link` shows it: > > ``` > 7: tunl60@NONE: mtu 1452

Re: [PATCH net-next] net: avoid skb_warn_bad_offload on IS_ERR

From: Willem de Bruijn Date: Tue, 12 Dec 2017 11:39:04 -0500 > From: Willem de Bruijn > > skb_warn_bad_offload warns when packets enter the GSO stack that > require skb_checksum_help or vice versa. Do not warn on arbitrary > bad packets.

Re: [PATCH net] sock: free skb in skb_complete_tx_timestamp on error

On Wed, 2017-12-13 at 14:41 -0500, Willem de Bruijn wrote: > From: Willem de Bruijn > > skb_complete_tx_timestamp must ingest the skb it is passed. Call > kfree_skb if the skb cannot be enqueued. > > Fixes: b245be1f4db1 ("net-timestamp: no-payload only sysctl") > Fixes:

Re: [PATCH net-next] net: sk_pacing_shift_update() helper

From: Eric Dumazet Date: Tue, 12 Dec 2017 06:34:19 -0800 > From: Eric Dumazet > > In commit 3a9b76fd0db9 ("tcp: allow drivers to tweak TSQ logic") > I gave a code sample to set sk->sk_pacing_shift that was not complete. > > Better add a helper that

Re: [PATCH 1/3] net: phy: add support to detect 100BASE-T1 capability

On Wed, Dec 13, 2017 at 06:37:49PM +0100, Lucas Stach wrote: > 100BASE-T1 is the automotive ethernet standard 802.3bw-2015. Currently > we don't detect any valid modes for PHYs, which only support this > standard. Add support to detect the common 100Mbit full-duplex mode. > > Signed-off-by: Lucas

Re: [PATCH net-next] net: bridge: use rhashtable for fdbs

From: Nikolay Aleksandrov Date: Tue, 12 Dec 2017 16:02:50 +0200 > Before this patch the bridge used a fixed 256 element hash table which > was fine for small use cases (in my tests it starts to degrade > above 1000 entries), but it wasn't enough for medium or large >

Re: [PATCH net-next v2] ip6_vti: adjust vti mtu according to mtu of output device

From: Alexey Kodanev Date: Tue, 12 Dec 2017 16:53:32 +0300 > + if (tdev) { > + dev->mtu = max_t(int, tdev->mtu - dev->hard_header_len, > + IPV6_MIN_MTU); > + } Please don't use curly braces for a single-statement basic

Re: [RFC PATCH] reuseport: compute the ehash only if needed

From: Paolo Abeni Date: Tue, 12 Dec 2017 14:09:28 +0100 > When a reuseport socket group is using a BPF filter to distribute > the packets among the sockets, we don't need to compute any hash > value, but the current reuseport_select_sock() requires the > caller to compute such

Re: [PATCH][next] net: phy: meson-gxl: make function meson_gxl_read_status static

From: Colin King Date: Tue, 12 Dec 2017 13:03:11 + > From: Colin Ian King > > The function meson_gxl_read_status is local to the source and does > not need to be in global scope, so make it static. > > Cleans up sparse warning: > symbol

Re: [PATCH net-next] net: phy: marvell10g: remove XGMII as an option for 88x3310

From: Russell King Date: Tue, 12 Dec 2017 12:53:18 + > Remove XGMII as an option for the 88x3310 PHY driver, as the PHY doesn't > support XGMII's 32-bit data lanes. It supports USXGMII, which is not > XGMII, but a single-lane serdes interface - see >

Re: [PATCH] of_mdio / mdiobus: ensure mdio devices have fwnode correctly populated

From: Russell King Date: Tue, 12 Dec 2017 10:49:15 + > Ensure that all mdio devices populate the struct device fwnode pointer > as well as the of_node pointer to allow drivers that wish to use > fwnode APIs to work. > > Signed-off-by: Russell King

Re: [PATCH net] net: phy: fix resume handling

From: Russell King Date: Tue, 12 Dec 2017 10:45:36 + > When a PHY has the BMCR_PDOWN bit set, it may decide to ignore writes > to other registers, or reset the registers to power-on defaults. > Micrel PHYs do this for their interrupt registers. > > The current

Re: [PATCH 1/2] net: dsa: allow XAUI phy interface mode

From: Russell King Date: Tue, 12 Dec 2017 09:29:46 + > XGMII is a 32-bit bus plus two clock signals per direction. XAUI is > four serial lanes per direction. The 88e6190 supports XAUI but not > XGMII as it doesn't have enough pins. The same is true of 88e6176.

Re: [PATCH 2/2] ARM: dts: vf610-zii-dev: use XAUI for DSA link ports

From: Russell King Date: Tue, 12 Dec 2017 09:29:51 + > Use XAUI rather than XGMII for DSA link ports, as this is the interface > mode that the switches actually use. XAUI is the 4 lane bus with clock > per direction, whereas XGMII is a 32 bit bus with clock. > >

Re: x86 boot broken on -rc1?

On Wed, 13 Dec 2017 20:37:02 +0100, Björn Töpel wrote: > 2017-12-02 1:39 GMT+01:00 Jakub Kicinski: > > [5.777076] ---[ end Kernel panic - not syncing: Attempted to kill init! > > exitcode=0x0009 > > Yes, I'm getting that as well (v4.15-rc2-772-gcdc0974f10cf). > > Did you bisect it? I

[patch iproute2] tc: fix json array closing

From: Jiri Pirko Fixes: 2704bd625583 ("tc: jsonify actions core") Signed-off-by: Jiri Pirko --- tc/m_action.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tc/m_action.c b/tc/m_action.c index 13f942b..8185819 100644 ---

Re: [PATCH] hippi: Fix a Fix a possible sleep-in-atomic bug in rr_close

From: Jia-Ju Bai Date: Tue, 12 Dec 2017 16:49:52 +0800 > The driver may sleep under a spinlock. > The function call path is: > rr_close (acquire the spinlock) > free_irq --> may sleep > > To fix it, free_irq is moved to the place without holding the spinlock. > > This

Re: [PATCH v2 0/3] r8169: extend PCI core and switch to device-managed functions in probe

From: Heiner Kallweit Date: Tue, 12 Dec 2017 07:34:26 +0100 > Probe error path and remove callback can be significantly simplified > by using device-managed functions. To be able to do this in the r8169 > driver we need a device-managed version of pci_set_mwi first. > >

Re: thunderx sgmii interface hang

> The nic appears to work fine (pings, TCP etc) up until a performance > test is attempted. > When an iperf bandwidth test is attempted the nic ends up in a state > where truncated-ip packets are being sent out (per a tcpdump from > another board): Hi Tim Are pause frames supported? Have you

[PATCH net] sock: free skb in skb_complete_tx_timestamp on error

From: Willem de Bruijn skb_complete_tx_timestamp must ingest the skb it is passed. Call kfree_skb if the skb cannot be enqueued. Fixes: b245be1f4db1 ("net-timestamp: no-payload only sysctl") Fixes: 9ac25fc06375 ("net: fix socket refcounting in skb_complete_tx_timestamp()")

  1   2   3   >