Re: [PATCH net-next 1/2] net: erspan: fix wrong return value

2017-12-15 Thread 严海双
> On 2017年12月16日, at 上午6:27, William Tu wrote: > > If pskb_may_pull return failed, return PACKET_REJECT > instead of -ENOMEM. > > Fixes: 94d7d8f29287 ("ip6_gre: add erspan v2 support") > Fixes: f551c91de262 ("net: erspan: introduce erspan v2 for ip_gre") > Signed-off-by:

Re: [PATCH v2 net-next 2/4] net: tracepoint: replace tcp_set_state tracepoint with sock_set_state tracepoint

2017-12-15 Thread Yafang Shao
2017-12-16 6:47 GMT+08:00 Song Liu : > >> On Dec 15, 2017, at 9:56 AM, Yafang Shao wrote: >> >> As sk_state is a common field for struct sock, so the state >> transition should not be a TCP specific feature. >> So I rename tcp_set_state tracepoint to

[net-next:master 353/390] drivers/net/ethernet/hisilicon/hns3/hns3vf/hclgevf_main.c:1290:37-38: Unneeded semicolon

2017-12-15 Thread kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git master head: 28dc4c8f4557d82e9be020e85e2362239270e704 commit: e963cb789a29b890678b58ef7da5d7c497510b7e [353/390] net: hns3: Add HNS3 VF driver to kernel build framework coccinelle warnings: (new ones prefixed by >>)

[PATCH v4 1/2] ARM64: dts: meson-axg: add ethernet mac controller

2017-12-15 Thread Yixun Lan
Add DT info for the stmmac ethernet MAC which found in the Amlogic's Meson-AXG SoC, also describe the ethernet pinctrl & clock information here. Reviewed-by: Neil Armstrong Signed-off-by: Yixun Lan --- arch/arm64/boot/dts/amlogic/meson-axg.dtsi |

[PATCH v4 0/2] Add ethernet support for Meson-AXG SoC

2017-12-15 Thread Yixun Lan
This series try to add support for the ethernet MAC controller found in Meson-AXG SoC, and also enable it in the S400 board. Hi Kevin: You still need to at least merge the clock patch[3] in order to compile the DTS, or just merge the tag from meson-clock's tree[6] - the tag is

[PATCH v4 2/2] ARM64: dts: meson-axg: enable ethernet for A113D S400 board

2017-12-15 Thread Yixun Lan
This is tested in the S400 dev board which use a RTL8211F PHY, and the pins connect to the 'eth_rgmii_y_pins' group. Reviewed-by: Neil Armstrong Signed-off-by: Yixun Lan --- arch/arm64/boot/dts/amlogic/meson-axg-s400.dts | 7 +++ 1 file

Re: [PATCH v3 1/2] ARM64: dts: meson-axg: add ethernet mac controller

2017-12-15 Thread Yixun Lan
HI Kevin On 12/16/2017 03:29 AM, Kevin Hilman wrote: > Yixun Lan writes: > >> Add DT info for the stmmac ethernet MAC which found in >> the Amlogic's Meson-AXG SoC, also describe the ethernet >> pinctrl & clock information here. >> >> Reviewed-by: Neil Armstrong

[PATCH v2,net-next 2/2] ip6_gre: fix error path when ip6erspan_rcv failed

2017-12-15 Thread Haishuang Yan
Same as ipv4 code, when ip6erspan_rcv call return PACKET_REJECT, we should call icmpv6_send to send icmp unreachable message in error path. Fixes: 5a963eb61b7c ("ip6_gre: Add ERSPAN native tunnel support") Acked-by: William Tu Cc: William Tu

[PATCH v2,net-next 1/2] ip_gre: fix error path when erspan_rcv failed

2017-12-15 Thread Haishuang Yan
When erspan_rcv call return PACKET_REJECT, we shoudn't call ipgre_rcv to process packets again, instead send icmp unreachable message in error path. Fixes: 84e54fe0a5ea ("gre: introduce native tunnel support for ERSPAN") Acked-by: William Tu Cc: William Tu

[PATCH v2,net-next 2/2] ip6_gre: fix potential memory leak in ip6erspan_rcv

2017-12-15 Thread Haishuang Yan
If md is NULL, tun_dst must be freed, otherwise it will cause memory leak. Fixes: ef7baf5e083c ("ip6_gre: add ip6 erspan collect_md mode") Cc: William Tu Signed-off-by: Haishuang Yan Change since v2: * Rebase on latest master branch. *

[PATCH v2,net-next 1/2] ip_gre: fix potential memory leak in erspan_rcv

2017-12-15 Thread Haishuang Yan
If md is NULL, tun_dst must be freed, otherwise it will cause memory leak. Fixes: 1a66a836da6 ("gre: add collect_md mode to ERSPAN tunnel") Cc: William Tu Signed-off-by: Haishuang Yan Change since v2: * Rebase on latest master branch.

[PATCH] trace: reenable preemption if we modify the ip

2017-12-15 Thread Josef Bacik
From: Josef Bacik Things got moved around between the original bpf_override_return patches and the final version, and now the ftrace kprobe dispatcher assumes if you modified the ip that you also enabled preemption. Make a comment of this and enable preemption, this fixes the

[PATCH v2,net-next] ip6_gre: fix a pontential issue in ip6erspan_rcv

2017-12-15 Thread Haishuang Yan
pskb_may_pull() can change skb->data, so we need to load ipv6h/ershdr at the right place. Fixes: 5a963eb61b7c ("ip6_gre: Add ERSPAN native tunnel support") Acked-by: William Tu Cc: William Tu Signed-off-by: Haishuang Yan

Re: [PATCH] ip6_gre: fix a pontential issue in ip6erspan_rcv

2017-12-15 Thread 严海双
> On 2017年12月16日, at 上午3:11, David Miller wrote: > > From: Haishuang Yan > Date: Fri, 15 Dec 2017 10:46:38 +0800 > >> pskb_may_pull() can change skb->data, so we need to load ipv6h/ershdr at >> the right place. >> >> Fixes:

[PATCH v2 iproute2 net-next] erspan: add erspan version II support

2017-12-15 Thread William Tu
The patch adds support for configuring the erspan v2, for both ipv4 and ipv6 erspan implementation. Three additional fields are added: 'erspan_ver' for distinguishing v1 or v2, 'erspan_dir' for specifying direction of the mirrored traffic, and 'erspan_hwid' for users to set ERSPAN engine ID

Re: [PATCH v2 iproute2 net-next] erspan: add erspan version II support

2017-12-15 Thread William Tu
On Fri, Dec 15, 2017 at 3:58 PM, Roman Mashak wrote: > William Tu writes: > >> The patch adds support for configuring the erspan v2, for both >> ipv4 and ipv6 erspan implementation. Three additional fields >> are added: 'erspan_ver' for distinguishing v1

BUG: unable to handle kernel NULL pointer dereference in fdb_find_rcu

2017-12-15 Thread Andrei Vagin
Hi, We run criu tests for linux-next and today we get this bug: The kernel version is 4.15.0-rc3-next-20171215 [ 235.397328] BUG: unable to handle kernel NULL pointer dereference at 000c [ 235.398624] IP: fdb_find_rcu+0x3c/0x130 [ 235.399365] PGD 51970067 P4D 51970067 PUD

[PATCH ethtool] ethtool: Support for FEC encoding control

2017-12-15 Thread Jakub Kicinski
From: Dustin Byford As FEC settings and different FEC modes are mandatory and configurable across various interfaces of 25G/50G/100G/40G, the lack of FEC encoding control and reporting today is a source for interoperability issues for many vendors set-fec/show-fec

[PATCH bpf-next] nfp: set flags in the correct member of netdev_bpf

2017-12-15 Thread Jakub Kicinski
netdev_bpf.flags is the input member for installing the program. netdev_bpf.prog_flags is the output member for querying. Set the correct one on query. Fixes: 92f0292b35a0 ("net: xdp: report flags program was installed with on query") Signed-off-by: Jakub Kicinski

[PATCH bpf-next] libbpf: fix Makefile exit code if libelf not found

2017-12-15 Thread Jakub Kicinski
/bin/sh's exit does not recognize -1 as a number, leading to the following error message: /bin/sh: 1: exit: Illegal number: -1 Use 1 as the exit code. Signed-off-by: Jakub Kicinski Reviewed-by: Quentin Monnet ---

Re: [PATCH v2 iproute2 net-next] erspan: add erspan version II support

2017-12-15 Thread Roman Mashak
William Tu writes: > The patch adds support for configuring the erspan v2, for both > ipv4 and ipv6 erspan implementation. Three additional fields > are added: 'erspan_ver' for distinguishing v1 or v2, 'erspan_dir' > for specifying direction of the mirrored traffic, and

Re: [PATCH 1/2] dt-bindings: net: add TI CC2560 Bluetooth chip

2017-12-15 Thread Rob Herring
On Tue, Dec 12, 2017 at 06:29:30PM -0600, David Lechner wrote: > This adds a compatible string for the Texas Instruments CC2560 Bluetooth > chip to the existing TI WiLink shared transport bindings. These chips are > similar enough that the same bindings work for both. The file is renamed > to

[PATCH] qed: Remove unused QED_RDMA_DEV_CAP_* symbols and dev->dev_caps

2017-12-15 Thread Bjorn Helgaas
From: Bjorn Helgaas The QED_RDMA_DEV_CAP_* symbols are only used to set bits in dev->dev_caps. Nobody ever looks at those bits. Remove the symbols and dev_caps itself. Note that if these are ever used and added back, it looks incorrect to set QED_RDMA_DEV_CAP_ATOMIC_OP

[PATCH] cxgb4: Simplify PCIe Completion Timeout setting

2017-12-15 Thread Bjorn Helgaas
From: Bjorn Helgaas Simplify PCIe Completion Timeout setting by using the pcie_capability_clear_and_set_word() interface. No functional change intended. Signed-off-by: Bjorn Helgaas --- drivers/net/ethernet/chelsio/cxgb4/t4_hw.c | 21

Re: [RFC v3 0/4] flow_dissector: Provide basic batman-adv unicast handling

2017-12-15 Thread Willem de Bruijn
On Fri, Dec 15, 2017 at 1:23 PM, Sven Eckelmann wrote: > Hi, > > we are currently starting to use batman-adv as mesh protocol on multicore > embedded devices. These usually don't have a lot of CPU power per core but > are reasonable fast when using multiple cores. > >

Re: [PATCH v2 net-next 2/4] net: tracepoint: replace tcp_set_state tracepoint with sock_set_state tracepoint

2017-12-15 Thread Song Liu
> On Dec 15, 2017, at 9:56 AM, Yafang Shao wrote: > > As sk_state is a common field for struct sock, so the state > transition should not be a TCP specific feature. > So I rename tcp_set_state tracepoint to sock_set_state tracepoint with > some minor changes and move it

[PATCH net-next 2/2] net: erspan: reload pointer after pskb_may_pull

2017-12-15 Thread William Tu
pskb_may_pull() can change skb->data, so we need to re-load pkt_md and ershdr at the right place. Fixes: 94d7d8f29287 ("ip6_gre: add erspan v2 support") Fixes: f551c91de262 ("net: erspan: introduce erspan v2 for ip_gre") Signed-off-by: William Tu Cc: Haishuang Yan

[PATCH net-next 0/2] net: erspan: a couple fixes

2017-12-15 Thread William Tu
Haishuang Yan reports a couple of issues (wrong return value, pskb_may_pull) on erspan V1. Since erspan V2 is in net-next, this series fix the similar issues on v2. William Tu (2): net: erspan: fix wrong return value net: erspan: reload pointer after pskb_may_pull net/ipv4/ip_gre.c | 6

[PATCH net-next 1/2] net: erspan: fix wrong return value

2017-12-15 Thread William Tu
If pskb_may_pull return failed, return PACKET_REJECT instead of -ENOMEM. Fixes: 94d7d8f29287 ("ip6_gre: add erspan v2 support") Fixes: f551c91de262 ("net: erspan: introduce erspan v2 for ip_gre") Signed-off-by: William Tu Cc: Haishuang Yan

Re: [PATCH net-next v5 1/4] phylib: Add device reset delay support

2017-12-15 Thread Rob Herring
On Mon, Dec 11, 2017 at 01:16:57PM +0100, Richard Leitner wrote: > From: Richard Leitner > > Some PHYs need a minimum time after the reset gpio was asserted and/or > deasserted. To ensure we meet these timing requirements add two new > optional devicetree parameters

[PATCH] net: phy: xgene: disable clk on error paths

2017-12-15 Thread Alexey Khoroshilov
There are several error paths in xgene_mdio_probe(), where clk is left undisabled. The patch fixes them. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Alexey Khoroshilov --- drivers/net/phy/mdio-xgene.c | 21 +++-- 1 file

Re: [PATCH net-next 1/2 v8] net: ethernet: Add DT bindings for the Gemini ethernet

2017-12-15 Thread Rob Herring
On Sun, Dec 10, 2017 at 11:45:57PM +0100, Linus Walleij wrote: > This adds the device tree bindings for the Gemini ethernet > controller. It is pretty straight-forward, using standard > bindings and modelling the two child ports as child devices > under the parent ethernet controller device. > >

[PATCH v2 iproute2 net-next] erspan: add erspan version II support

2017-12-15 Thread William Tu
The patch adds support for configuring the erspan v2, for both ipv4 and ipv6 erspan implementation. Three additional fields are added: 'erspan_ver' for distinguishing v1 or v2, 'erspan_dir' for specifying direction of the mirrored traffic, and 'erspan_hwid' for users to set ERSPAN engine ID

[PATCH] tg3: Fix rx hang on MTU change with 5717/5719

2017-12-15 Thread Brian King
This fixes a hang issue seen when changing the MTU size from 1500 MTU to 9000 MTU on both 5717 and 5719 chips. In discussion with Broadcom, they've indicated that these chipsets have the same phy as the 57766 chipset, so the same workarounds apply. This has been tested by IBM on both Power 8 and

Re: [Intel-wired-lan] [PATCH v2 next-queue 08/10] ixgbe: process the Tx ipsec offload

2017-12-15 Thread kbuild test robot
Hi Shannon, Thank you for the patch! Yet something to improve: [auto build test ERROR on v4.15-rc3] [also build test ERROR on next-20171215] [cannot apply to jkirsher-next-queue/dev-queue] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url

Re: [PATCH bpf-next] nfp: bpf: correct printk formats for size_t

2017-12-15 Thread Daniel Borkmann
On 12/15/2017 07:39 PM, Jakub Kicinski wrote: > Build bot reported warning about invalid printk formats on 32bit > architectures. Use %zu for size_t and %zd ptr diff. > > Signed-off-by: Jakub Kicinski Applied to bpf-next, thanks Jakub.

[GIT] Networking

2017-12-15 Thread David Miller
' of git://git.kernel.org/.../jberg/mac80211 Merge git://git.kernel.org/.../pablo/nf Merge branch 'mlx4-misc-fixes' Merge git://git.kernel.org/.../bpf/bpf Merge tag 'batadv-net-for-davem-20171215' of git://git.open-mesh.org/linux-merge Merge branch 's390-fixes

Re: [Intel-wired-lan] [PATCH v2 next-queue 08/10] ixgbe: process the Tx ipsec offload

2017-12-15 Thread Shannon Nelson
On 12/15/2017 12:10 PM, kbuild test robot wrote: [...] drivers/net/ethernet/intel/ixgbe/ixgbe_main.c: In function 'ixgbe_xmit_frame_ring': drivers/net/ethernet/intel/ixgbe/ixgbe_main.c:8563:11: error: 'struct sk_buff' has no member named 'sp'; did you mean 'sk'? if (skb->sp &&

Re: [PATCH v10 3/5] bpf: add a bpf_override_function helper

2017-12-15 Thread Daniel Borkmann
On 12/15/2017 09:34 PM, Alexei Starovoitov wrote: [...] > Also how big is the v9-v10 change ? > May be do it as separate patch, since previous set already sitting > in bpf-next and there are patches on top? +1

Re: [PATCH] net: qcom/emac: Reduce timeout for mdio read/write

2017-12-15 Thread David Miller
From: Hemanth Puranik Date: Fri, 15 Dec 2017 20:05:58 +0530 > Currently mdio read/write takes around ~115us as the timeout > between status check is set to 100us. > By reducing the timeout to 1us mdio read/write takes ~15us to > complete. This improves the link up event

Re: [patch net 2/2] net: sched: fix static key imbalance in case of ingress/clsact_init error

2017-12-15 Thread David Miller
From: Jiri Pirko Date: Fri, 15 Dec 2017 12:40:13 +0100 > From: Jiri Pirko > > Move static key increments to the beginning of the init function > so they pair 1:1 with decrements in ingress/clsact_destroy, > which is called in case ingress/clsact_init fails.

Re: [patch net 1/2] net: sched: fix clsact init error path

2017-12-15 Thread David Miller
From: Jiri Pirko Date: Fri, 15 Dec 2017 12:40:12 +0100 > From: Jiri Pirko > > Since in qdisc_create, the destroy op is called when init fails, we > don't do cleanup in init and leave it up to destroy. > This fixes use-after-free when trying to put already

Re: [PATCH net-next] net: phy: broadcom: Add entry for 5395 switch PHYs

2017-12-15 Thread David Miller
From: Florian Fainelli Date: Thu, 14 Dec 2017 17:48:16 -0800 > Add an entry for the builtin PHYs present in the Broadcom BCM5395 switch. This > allows us to retrieve the PHY statistics among other things. > > Signed-off-by: Florian Fainelli Applied,

Re: [PATCH v10 3/5] bpf: add a bpf_override_function helper

2017-12-15 Thread Alexei Starovoitov
On 12/15/17 11:12 AM, Josef Bacik wrote: +#ifdef CONFIG_BPF_KPROBE_OVERRIDE +BPF_CALL_2(bpf_override_return, struct pt_regs *, regs, unsigned long, rc) +{ + __this_cpu_write(bpf_kprobe_override, 1); + regs_set_return_value(regs, rc); +

Re: net-next lan9303 and CONFIG_NET_DSA_LEGACY

2017-12-15 Thread Egil Hjelmeland
Den 15. des. 2017 21:06, skrev Florian Fainelli: On December 15, 2017 6:51:45 AM PST, Egil Hjelmeland wrote: Hi I found that our lan9303 board is unable to receive network data unless CONFIG_NET_DSA_LEGACY is set. Is that a problem with the driver, or our DTS?

Re: [Intel-wired-lan] [PATCH v2 next-queue 08/10] ixgbe: process the Tx ipsec offload

2017-12-15 Thread kbuild test robot
Hi Shannon, Thank you for the patch! Yet something to improve: [auto build test ERROR on v4.15-rc3] [also build test ERROR on next-20171215] [cannot apply to jkirsher-next-queue/dev-queue] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url

Re: [PATCH net-next] net: phy: broadcom: Add entry for 5395 switch PHYs

2017-12-15 Thread Florian Fainelli
On December 15, 2017 1:10:44 AM PST, Andrew Lunn wrote: >On Thu, Dec 14, 2017 at 05:48:16PM -0800, Florian Fainelli wrote: >> Add an entry for the builtin PHYs present in the Broadcom BCM5395 >switch. This >> allows us to retrieve the PHY statistics among other things. > >>

Re: net-next lan9303 and CONFIG_NET_DSA_LEGACY

2017-12-15 Thread Florian Fainelli
On December 15, 2017 6:51:45 AM PST, Egil Hjelmeland wrote: >Hi >I found that our lan9303 board is unable to receive network data unless > >CONFIG_NET_DSA_LEGACY is set. Is that a problem with the driver, or our > >DTS? (imx28) > >ahb@8008 { > mac0:

[PATCH v16 1/4] block: DAC960: Replace PCI pool old API

2017-12-15 Thread Romain Perier
From: Romain Perier The PCI pool API is deprecated. This commit replaces the PCI pool old API by the appropriate function with the DMA pool API. Signed-off-by: Romain Perier Acked-by: Peter Senna Tschudin

[PATCH v16 2/4] net: e100: Replace PCI pool old API

2017-12-15 Thread Romain Perier
From: Romain Perier The PCI pool API is deprecated. This commit replaces the PCI pool old API by the appropriate function with the DMA pool API. Signed-off-by: Romain Perier Acked-by: Peter Senna Tschudin

[PATCH v16 4/4] PCI: Remove PCI pool macro functions

2017-12-15 Thread Romain Perier
From: Romain Perier Now that all the drivers use dma pool API, we can remove the macro functions for PCI pool. Signed-off-by: Romain Perier Reviewed-by: Peter Senna Tschudin Acked-by: Bjorn Helgaas

Re: [PATCH v3 2/2] ARM64: dts: meson-axg: enable ethernet for A113D S400 board

2017-12-15 Thread Kevin Hilman
Yixun Lan writes: > This is tested in the S400 dev board which use a RTL8211F PHY, > and the pins connect to the 'eth_rgmii_y_pins' group. > > Reviewed-by: Neil Armstrong > Signed-off-by: Yixun Lan > --- >

[PATCH v16 3/4] hinic: Replace PCI pool old API

2017-12-15 Thread Romain Perier
From: Romain Perier The PCI pool API is deprecated. This commit replaces the PCI pool old API by the appropriate function with the DMA pool API. Signed-off-by: Romain Perier --- drivers/net/ethernet/huawei/hinic/hinic_hw_cmdq.c | 10

[PATCH v16 0/4] Replace PCI pool by DMA pool API

2017-12-15 Thread Romain Perier
by the dma pool API and remove the defines. Changes in v16: - Rebased series onto next-20171215 - I have fixed patch 04/04, so it can be applied - Added Acked-by for Bjorn Helgaas on patch 04/04 Changes in v15: - Rebased series onto next-20171120 - Added patch 04/05 for mpt3sas scsi driver Changes

Re: [PATCH v3 1/2] ARM64: dts: meson-axg: add ethernet mac controller

2017-12-15 Thread Kevin Hilman
Yixun Lan writes: > Add DT info for the stmmac ethernet MAC which found in > the Amlogic's Meson-AXG SoC, also describe the ethernet > pinctrl & clock information here. > > Reviewed-by: Neil Armstrong > Signed-off-by: Yixun Lan

Re: [Intel-wired-lan] [PATCH v2 next-queue 08/10] ixgbe: process the Tx ipsec offload

2017-12-15 Thread Jesse Brandeburg
On Tue, 12 Dec 2017 21:45:13 -0800 Shannon Nelson wrote: > > Also you are still setting the TCP flag for these packets. I'm > > wondering if the TCP flag is really needed. I get that your current > > setup only runs on TCP flows but what about other types of flows? > >

Re: [patch net 2/2] net: sched: fix static key imbalance in case of ingress/clsact_init error

2017-12-15 Thread Cong Wang
On Fri, Dec 15, 2017 at 3:40 AM, Jiri Pirko wrote: > From: Jiri Pirko > > Move static key increments to the beginning of the init function > so they pair 1:1 with decrements in ingress/clsact_destroy, > which is called in case ingress/clsact_init fails. > >

Re: [patch net 1/2] net: sched: fix clsact init error path

2017-12-15 Thread Cong Wang
On Fri, Dec 15, 2017 at 3:40 AM, Jiri Pirko wrote: > From: Jiri Pirko > > Since in qdisc_create, the destroy op is called when init fails, we > don't do cleanup in init and leave it up to destroy. > This fixes use-after-free when trying to put already freed

[PATCH v10 1/5] add infrastructure for tagging functions as error injectable

2017-12-15 Thread Josef Bacik
From: Josef Bacik Using BPF we can override kprob'ed functions and return arbitrary values. Obviously this can be a bit unsafe, so make this feature opt-in for functions. Simply tag a function with KPROBE_ERROR_INJECT_SYMBOL in order to give BPF access to that function for error

[PATCH v10 5/5] btrfs: allow us to inject errors at io_ctl_init

2017-12-15 Thread Josef Bacik
From: Josef Bacik This was instrumental in reproducing a space cache bug. Signed-off-by: Josef Bacik Acked-by: Ingo Molnar --- fs/btrfs/free-space-cache.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/fs/btrfs/free-space-cache.c

[PATCH v10 4/5] samples/bpf: add a test for bpf_override_return

2017-12-15 Thread Josef Bacik
From: Josef Bacik This adds a basic test for bpf_override_return to verify it works. We override the main function for mounting a btrfs fs so it'll return -ENOMEM and then make sure that trying to mount a btrfs fs will fail. Acked-by: Alexei Starovoitov

[PATCH v10 2/5] btrfs: make open_ctree error injectable

2017-12-15 Thread Josef Bacik
From: Josef Bacik This allows us to do error injection with BPF for open_ctree. Signed-off-by: Josef Bacik Acked-by: Ingo Molnar --- fs/btrfs/disk-io.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/fs/btrfs/disk-io.c

[PATCH v10 3/5] bpf: add a bpf_override_function helper

2017-12-15 Thread Josef Bacik
From: Josef Bacik Error injection is sloppy and very ad-hoc. BPF could fill this niche perfectly with it's kprobe functionality. We could make sure errors are only triggered in specific call chains that we care about with very specific situations. Accomplish this with the

[PATCH v10 0/5] Add the ability to do BPF directed error injection

2017-12-15 Thread Josef Bacik
Just one last go around I hope, fixed the preemption thing that Darrick reported. v9->v10: - the kprobe dispather now requires us to re-enable preemption if we change the ip ourselves, so do that. v8->v9: - rebased onto the bpf tree. v7->v8: - removed the _ASM_KPROBE_ERROR_INJECT since it was

Re: [PATCH] ip6_gre: fix a pontential issue in ip6erspan_rcv

2017-12-15 Thread David Miller
From: Haishuang Yan Date: Fri, 15 Dec 2017 10:46:38 +0800 > pskb_may_pull() can change skb->data, so we need to load ipv6h/ershdr at > the right place. > > Fixes: 5a963eb61b7c ("ip6_gre: Add ERSPAN native tunnel support") > Cc: William Tu

Re: [PATCH] ip_gre: fix wrong return value of erspan_rcv

2017-12-15 Thread David Miller
From: Haishuang Yan Date: Fri, 15 Dec 2017 10:46:16 +0800 > If pskb_may_pull return failed, return PACKET_REJECT instead of -ENOMEM. > > Fixes: 84e54fe0a5ea ("gre: introduce native tunnel support for ERSPAN") > Cc: William Tu >

Re: v4.15-rc2 on thinkpad x60: ethernet stopped working

2017-12-15 Thread Pavel Machek
Hi! > > > > Any ideas ? > > > > > > Yes , 19110cfbb34d4af0cdfe14cd243f3b09dc95b013 broke it. > > > > > > See: > > > https://bugzilla.kernel.org/show_bug.cgi?id=198047 > > > > > > Fix there : > > > https://marc.info/?l=linux-kernel=151272209903675=2 > > > > > > Regards, > > > > > > Gabriel C > >

Re: [PATCHv2 net-next 0/8] sctp: Implement Stream Interleave: Interaction with Other SCTP Extensions

2017-12-15 Thread David Miller
From: Xin Long Date: Fri, 15 Dec 2017 00:41:24 +0800 > Stream Interleave would be implemented in two Parts: > >1. The I-DATA Chunk Supporting User Message Interleaving >2. Interaction with Other SCTP Extensions > > Overview in section 2.3 of RFC8260 for Part 2: >

Re: [PATCH net-next] net: phy: phylink: Handle NULL fwnode_handle

2017-12-15 Thread David Miller
From: Florian Fainelli Date: Thu, 14 Dec 2017 15:57:58 -0800 > Unlike the various of_* routines to fetch properties, fwnode_* routines can > have an early check against a NULL fwnode_handle reference which makes them > return -EINVAL (see fwnode_call_int_op), thus making it

[net-next:master 355/378] drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_mbx.c:236:16: sparse: restricted __le16 degrades to integer

2017-12-15 Thread kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git master head: 82f67bc6beb27120e8ccd1de8bd704edf3f79813 commit: dde1a86e93cadf9b17ec0a95a78c99505c48fd83 [355/378] net: hns3: Add mailbox support to PF driver reproduce: # apt-get install sparse git

Re: [PATCH net-next] qmi_wwan: set FLAG_SEND_ZLP to avoid network initiated disconnect

2017-12-15 Thread David Miller
From: Bjørn Mork Date: Thu, 14 Dec 2017 19:55:50 +0100 > It has been reported that the dummy byte we add to avoid > ZLPs can be forwarded by the modem to the PGW/GGSN, and that > some operators will drop the connection if this happens. > > In theory, QMI devices are based on CDC

Re: [PATCH] net/tls: Fix inverted error codes to avoid endless loop

2017-12-15 Thread David Miller
From: r.her...@avm.de Date: Thu, 14 Dec 2017 19:55:14 +0100 > sendfile() calls can hang endless with using Kernel TLS if a socket error > occurs. > Socket error codes must be inverted by Kernel TLS before returning because > they are stored with positive sign. If returned non-inverted they are >

Re: [PATCH 1/1] net: usb: qmi_wwan: add Telit ME910 PID 0x1101 support

2017-12-15 Thread David Miller
From: Daniele Palmas Date: Thu, 14 Dec 2017 16:56:14 +0100 > This patch adds support for Telit ME910 PID 0x1101. > > Signed-off-by: Daniele Palmas Applied, thanks.

Re: [PATCH net-next v3] ip6_vti: adjust vti mtu according to mtu of output device

2017-12-15 Thread David Miller
From: Alexey Kodanev Date: Thu, 14 Dec 2017 18:37:50 +0300 Two minor pieces of feedback: > LTP/udp6_ipsec_vti tests fail when sending large UDP datagrams that > require fragmentation and the underlying device has MTU <= 1500. This > happens because ip6_vti sets mtu to

[PATCH bpf-next] nfp: bpf: correct printk formats for size_t

2017-12-15 Thread Jakub Kicinski
Build bot reported warning about invalid printk formats on 32bit architectures. Use %zu for size_t and %zd ptr diff. Signed-off-by: Jakub Kicinski --- drivers/net/ethernet/netronome/nfp/bpf/main.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff

Re: [PATCH net 0/3] net: sched: Make qdisc offload uapi uniform

2017-12-15 Thread David Miller
From: Yuval Mintz Date: Thu, 14 Dec 2017 15:54:28 +0200 > Several qdiscs can already be offloaded to hardware, but there's an > inconsistecy in regard to the uapi through which they indicate such > an offload is taking place - indication is passed to the user via >

[PATCH v4 net-next 1/6] lwt: Add net to build_state argument

2017-12-15 Thread Tom Herbert
Users of LWT need to know net if they want to have per net operations in LWT. Signed-off-by: Tom Herbert --- include/net/lwtunnel.h| 6 +++--- net/core/lwt_bpf.c| 2 +- net/core/lwtunnel.c | 4 ++-- net/ipv4/fib_semantics.c | 13 -

[PATCH v4 net-next 6/6] ila: Route notify

2017-12-15 Thread Tom Herbert
Implement RTM notifications for ILA routers. This adds support to ILA LWT to send a netlink RTM message when a router is uses. THe ILA notify mechanism can be used in two contexts: - On an ILA forwarding cache a route prefix can be configured to do an ILA notification. This method is used when

[PATCH v4 net-next 3/6] ila: Call library function alloc_bucket_locks

2017-12-15 Thread Tom Herbert
To allocate the array of bucket locks for the hash table we now call library function alloc_bucket_spinlocks. Signed-off-by: Tom Herbert --- net/ipv6/ila/ila_xlat.c | 22 +- 1 file changed, 5 insertions(+), 17 deletions(-) diff --git

[PATCH v4 net-next 4/6] ila: create main ila source file

2017-12-15 Thread Tom Herbert
Create a main ila file that contains the module initialization functions as well as netlink definitions. Previously these were defined in ila_xlat and ila_common. This approach allows better extensibility. Signed-off-by: Tom Herbert --- net/ipv6/ila/Makefile | 2 +-

Re: [PATCH] net: alteon: acenic: clean up indentation issue

2017-12-15 Thread David Miller
From: Colin King Date: Thu, 14 Dec 2017 11:40:21 + > From: Colin Ian King > > There is a hunk of code that is incorrectly indented with spaces > and rather than a tab. Clean this up. > > Signed-off-by: Colin Ian King

[PATCH v4 net-next 5/6] ila: Flush netlink command to clear xlat table

2017-12-15 Thread Tom Herbert
Add ILA_CMD_FLUSH netlink command to clear the ILA translation table. Signed-off-by: Tom Herbert --- include/uapi/linux/ila.h | 1 + net/ipv6/ila/ila.h | 1 + net/ipv6/ila/ila_main.c | 6 + net/ipv6/ila/ila_xlat.c | 62

[PATCH v4 net-next 0/6] net: ILA notification mechanism and fixes

2017-12-15 Thread Tom Herbert
This patch set adds support to get netlink notifications for ILA routes when a route is used. This is done to support ILA forwarding cache address resolution as well as ILA router redirect mechanisms. This patch set contains: - The ILA route notification mechanism - Routing messages are used

[PATCH v4 net-next 2/6] ila: Fix use of rhashtable walk in ila_xlat.c

2017-12-15 Thread Tom Herbert
Perform better EAGAIN handling, handle case where ila_dump_info fails and we missed objects in the dump, and add a skip index to skip over ila entires in a list on a rhashtable node that have already been visited (by a previous call to ila_nl_dump). Signed-off-by: Tom Herbert

Re: [PATCHv2] ipv6: ip6mr: Recalc UDP checksum before forwarding

2017-12-15 Thread David Miller
From: Brendan McGrath Date: Thu, 14 Dec 2017 22:37:03 +1100 > Currently, when forwarding a multicast packet originating from a > Virtual Interface on a Multicast Router to one of its Physical > Interfaces, ip_summed is set to a value of CHECKSUM_UNNECESSARY and > the

[RFC v3 1/4] batman-adv: Let packet.h include its headers directly

2017-12-15 Thread Sven Eckelmann
The headers used by packet.h should also be included by it directly. main.h is currently dealing with it in batman-adv, but this will no longer work when this header is moved to include/uapi/linux/. Signed-off-by: Sven Eckelmann --- net/batman-adv/main.h | 2 --

[RFC v3 3/4] batman-adv: Convert packet.h to uapi header

2017-12-15 Thread Sven Eckelmann
The header file is used by different userspace programs to inject packets or to decode sniffed packets. It should therefore be available to them as userspace header. Also other components in the kernel (like the flow dissector) require access to the packet definitions to be able to decode

Re: [PATCH 0/2] Add SFF module support

2017-12-15 Thread David Miller
From: Russell King - ARM Linux Date: Thu, 14 Dec 2017 10:27:13 + > Add support for SFF modules. SFF modules are similar to SFP modules, > but they have fewer control signals, and are soldered down rather than > pluggable. > > They also have different IDs in the

[RFC v3 2/4] batman-adv: Remove usage of BIT(x) in packet.h

2017-12-15 Thread Sven Eckelmann
The BIT(x) macro is no longer available for uapi headers because it is defined outside of it (linux/bitops.h). The use of it must therefore be avoided and replaced by an appropriate other representation. Signed-off-by: Sven Eckelmann --- net/batman-adv/packet.h | 23

[RFC v3 4/4] flow_dissector: Parse batman-adv unicast headers

2017-12-15 Thread Sven Eckelmann
The batman-adv unicast packets contain a full layer 2 frame in encapsulated form. The flow dissector must therefore be able to parse the batman-adv unicast header to reach the layer 2+3 information. ++ | ip(v6)hdr | ++ | inner ethhdr

[RFC v3 0/4] flow_dissector: Provide basic batman-adv unicast handling

2017-12-15 Thread Sven Eckelmann
Hi, we are currently starting to use batman-adv as mesh protocol on multicore embedded devices. These usually don't have a lot of CPU power per core but are reasonable fast when using multiple cores. It was noticed that sending was working very well but receiving was basically only using on CPU

[net-next:master 353/371] drivers/net/ethernet/hisilicon/hns3/hns3vf/hclgevf_mbx.c:162:39: sparse: cast to restricted __le16

2017-12-15 Thread kbuild test robot
Hi Salil, First bad commit (maybe != root cause): tree: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git master head: 9463b2f72eadf93132815e7ee8e54b4f46e39be9 commit: e963cb789a29b890678b58ef7da5d7c497510b7e [353/371] net: hns3: Add HNS3 VF driver to kernel build

[PATCH v2 net-next 1/4] tcp: Export to userspace the TCP state names for the trace events

2017-12-15 Thread Yafang Shao
From: "Steven Rostedt (VMware)" The TCP trace events (specifically tcp_set_state), maps emums to symbol names via __print_symbolic(). But this only works for reading trace events from the tracefs trace files. If perf or trace-cmd were to record these events, the event format

[PATCH v2 net-next 2/4] net: tracepoint: replace tcp_set_state tracepoint with sock_set_state tracepoint

2017-12-15 Thread Yafang Shao
As sk_state is a common field for struct sock, so the state transition should not be a TCP specific feature. So I rename tcp_set_state tracepoint to sock_set_state tracepoint with some minor changes and move it into file trace/events/sock.h. Two helpers are introduced to trace sk_state transition

Re: [PATCH net-next v6 2/2] net: ethernet: socionext: add AVE ethernet driver

2017-12-15 Thread David Miller
From: Kunihiko Hayashi Date: Thu, 14 Dec 2017 19:05:10 +0900 > +static void ave_desc_write(struct net_device *ndev, enum desc_id id, > +int entry, int offset, u32 val) > +{ > + struct ave_private *priv = netdev_priv(ndev); > + u32

[PATCH v2 net-next 4/4] net: tracepoint: using sock_set_state tracepoint to trace SCTP state transition

2017-12-15 Thread Yafang Shao
With changes in inet_ files, SCTP state transitions are traced with sockt_set_state tracepoint. Signed-off-by: Yafang Shao --- net/sctp/endpointola.c | 2 +- net/sctp/sm_sideeffect.c | 4 ++-- net/sctp/socket.c| 12 ++-- 3 files changed, 9

[PATCH v2 net-next 3/4] net: tracepoint: using sock_set_state tracepoint to trace DCCP state transition

2017-12-15 Thread Yafang Shao
With changes in inet_ files, DCCP state transitions are traced with sock_set_state tracepoint. Signed-off-by: Yafang Shao --- net/dccp/proto.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/dccp/proto.c b/net/dccp/proto.c index 9d43c1f..2874faf

[PATCH v2 net-next 0/4] replace tcp_set_state tracepoint with sock_set_state tracepoint

2017-12-15 Thread Yafang Shao
Hi, According to the discussion in the mail thread https://patchwork.kernel.org/patch/10099243/, tcp_set_state tracepoint is renamed to sock_set_state tracepoint and is moved to include/trace/events/sock.h. Using this new tracepoint to trace TCP/DCCP/SCTP state transition. v1->v2: Steven's

Re: [PATCH v2 net-next 0/4] replace tcp_set_state tracepoint with

2017-12-15 Thread David Miller
From: Yafang Shao Date: Sat, 16 Dec 2017 01:50:12 +0800 > 2017-12-16 1:43 GMT+08:00 David Miller : >> >> Your Subject line here is incomplete, "replace tcp_set_state >> tracepoint with" what? > > Oh Sorry. > > The subject should be > > "replace

Re: [PATCH v2 net-next 0/4] replace tcp_set_state tracepoint with

2017-12-15 Thread Yafang Shao
2017-12-16 1:43 GMT+08:00 David Miller : > > Your Subject line here is incomplete, "replace tcp_set_state > tracepoint with" what? Oh Sorry. The subject should be "replace tcp_set_state tracepoint with sock_set_state tracepoint" Thanks Yafang

  1   2   3   >