RE: [PATCH v3 net-next 3/6] net: Add SW fallback infrastructure for offloaded sockets

On Monday, December 18, 2017 9:18 PM, Marcelo Ricardo Leitner wrote: > > + > > + if (sk && sk_fullsock(sk) && sk->sk_offload_check) > > Isn't this going to hurt the fast path, checking for sk fields here? > We do add code to the fast path but it seems unavoidable if you want to have SW

RE: [PATCH v3 net-next 6/6] tls: Add generic NIC offload infrastructure.

On Mon, Monday, December 18, 2017 9:54 PM, Marcelo Ricardo Leitner wrote: > On Mon, Dec 18, 2017 at 01:10:33PM +0200, Ilya Lesokhin wrote: > > This patch adds a generic infrastructure to offload TLS crypto to a > > network devices. It enables the kernel TLS socket to skip encryption > > and

Re: [alsa-devel] [trivial PATCH] treewide: Align function definition open/close braces

On Mon, 18 Dec 2017 01:28:44 +0100, Joe Perches wrote: > > Some functions definitions have either the initial open brace and/or > the closing brace outside of column 1. > > Move those braces to column 1. > > This allows various function analyzers like gnu complexity to work > properly for these

Re: [PATCH v3 net-next 6/6] tls: Add generic NIC offload infrastructure.

Hi Ilya, I love your patch! Yet something to improve: [auto build test ERROR on net-next/master] url: https://github.com/0day-ci/linux/commits/Ilya-Lesokhin/tls-Add-generic-NIC-offload-infrastructure/20171219-140819 config: tile-allmodconfig (attached as .config) compiler: tilegx-linux-gcc

Re: [PATCH v3 net-next 6/6] tls: Add generic NIC offload infrastructure.

Hi Ilya, I love your patch! Perhaps something to improve: [auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/Ilya-Lesokhin/tls-Add-generic-NIC-offload-infrastructure/20171219-140819 config: xtensa-allmodconfig (attached as .config) compiler:

Re: [PATCH v3 07/33] nds32: MMU initialization

Hi, Guo Ren: 2017-12-18 20:22 GMT+08:00 Guo Ren : > On Mon, Dec 18, 2017 at 07:21:30PM +0800, Greentime Hu wrote: >> Hi, Guo Ren: >> >> 2017-12-18 17:08 GMT+08:00 Guo Ren : >> > Hi Greentime, >> > >> > On Fri, Dec 08, 2017 at 05:11:50PM +0800, Greentime Hu

Re: [PATCH v10 3/5] bpf: add a bpf_override_function helper

On Mon, 18 Dec 2017 16:09:30 +0100 Daniel Borkmann wrote: > On 12/18/2017 10:51 AM, Masami Hiramatsu wrote: > > On Fri, 15 Dec 2017 14:12:54 -0500 > > Josef Bacik wrote: > >> From: Josef Bacik > >> > >> Error injection is sloppy and

[patch iproute2] tc: add -bs option for batch mode

Currently in tc batch mode, only one command is read from the batch file and sent to kernel to process. With this patch, we can accumulate several commands before sending to kernel. The batch size is specified using option -bs or -batchsize. To accumulate the commands in tc, we allocate an array

Re: [PATCH v2 2/3] vsprintf: print if symbol not found

On Mon, Dec 18, 2017 at 10:18:27PM -0800, Joe Perches wrote: > On Tue, 2017-12-19 at 14:28 +1100, Tobin C. Harding wrote: > > Depends on: commit 40eee173a35e ("kallsyms: don't leak address when > > symbol not found") > > > > Currently vsprintf for specifiers %p[SsB] relies on the behaviour of > >

Re: [PATCH v10 1/5] add infrastructure for tagging functions as error injectable

On Fri, 15 Dec 2017 14:12:52 -0500 Josef Bacik wrote: > From: Josef Bacik > > Using BPF we can override kprob'ed functions and return arbitrary > values. Obviously this can be a bit unsafe, so make this feature opt-in > for functions. Simply tag a

Re: pull-request: bpf-next 2017-12-18

On Mon, Dec 18, 2017 at 10:51:53AM -0500, David Miller wrote: > From: Daniel Borkmann > Date: Mon, 18 Dec 2017 01:33:07 +0100 > > > The following pull-request contains BPF updates for your *net-next* tree. > > > > The main changes are: > > > > 1) Allow arbitrary function

[PATCH bpf 07/11] bpf: Add support for reading sk_state and more

Add support for reading many more tcp_sock fields state,same as sk->sk_state rtt_min same as sk->rtt_min.s[0].v (current rtt_min) snd_ssthresh rcv_nxt snd_nxt snd_una mss_cache ecn_flags rate_delivered rate_interval_us packets_out retrans_out total_retrans

[PATCH bpf 08/11] bpf: Add sock_ops R/W access to tclass & sk_txhash

Adds direct R/W access to sk_txhash and access to tclass for ipv6 flows through getsockopt and setsockopt. Sample usage for tclass: bpf_getsockopt(skops, SOL_IPV6, IPV6_TCLASS, , sizeof(v)) where skops is a pointer to the ctx (struct bpf_sock_ops). Signed-off-by: Lawrence Brakmo

[PATCH bpf 10/11] bpf: Add BPF_SOCK_OPS_STATE_CB

Adds support for calling sock_ops BPF program when there is a TCP state change. Two arguments are used; one for the old state and another for the new state. New op: BPF_SOCK_OPS_STATE_CB. Signed-off-by: Lawrence Brakmo --- include/uapi/linux/bpf.h | 4

[PATCH bpf 09/11] bpf: Add BPF_SOCK_OPS_RETRANS_CB

Adds support for calling sock_ops BPF program when there is a retransmission. Two arguments are used; one for the sequence number and other for the number of segments retransmitted. Does not include syn-ack retransmissions. New op: BPF_SOCK_OPS_RETRANS_CB. Signed-off-by: Lawrence Brakmo

[PATCH bpf 0/11] bpf: more sock_ops callbacks

This patchset adds support for: - direct R or R/W access to many tcp_sock fields - passing up to 4 arguments to sock_ops BPF functions - tcp_sock field bpf_sock_ops_flags for controlling callbacks - optionally calling sock_ops BPF program when RTO fires - optionally calling sock_ops BPF program

[PATCH bpf 05/11] bpf: Adds field bpf_sock_ops_flags to tcp_sock

Adds field bpf_sock_ops_flags to tcp_sock and bpf_sock_ops. Its primary use is to determine if there should be calls to sock_ops bpf program at various points in the TCP code. The field is initialized to zero, disabling the calls. A sock_ops BPF program can set, per connection and as necessary,

[PATCH bpf 11/11] bpf: add selftest for tcpbpf

Added a selftest for tcpbpf (sock_ops) that checks that the appropriate callbacks occured and that it can access tcp_sock fields and that their values are correct. Signed-off-by: Lawrence Brakmo --- tools/include/uapi/linux/bpf.h | 45 -

[PATCH bpf 03/11] bpf: Add write access to tcp_sock and sock fields

This patch adds a macro, SOCK_OPS_SET_FIELD, for writing to struct tcp_sock or struct sock fields. This required adding a new field "temp" to struct bpf_sock_ops_kern for temporary storage that is used by sock_ops_convert_ctx_access. It is used to store and recover the contents of a register, so

[PATCH bpf 04/11] bpf: Support passing args to sock_ops bpf function

Adds support for passing up to 4 arguments to sock_ops bpf functions. It reusues the reply union, so the bpf_sock_ops structures are not increased in size. Signed-off-by: Lawrence Brakmo --- include/linux/filter.h | 1 + include/net/tcp.h| 64

[PATCH bpf 06/11] bpf: Add sock_ops RTO callback

Adds an optional call to sock_ops BPF program based on whether the BPF_SOCK_OPS_RTO_CB_FLAG is set in bpf_sock_ops_flags. The BPF program is passed 2 arguments: icsk_retransmits and whether the RTO has expired. Signed-off-by: Lawrence Brakmo --- include/uapi/linux/bpf.h | 5 +

[PATCH bpf 01/11] bpf: Make SOCK_OPS_GET_TCP size independent

Make SOCK_OPS_GET_TCP helper macro size independent (before only worked with 4-byte fields. Signed-off-by: Lawrence Brakmo --- net/core/filter.c | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/net/core/filter.c b/net/core/filter.c index

[PATCH bpf 02/11] bpf: Make SOCK_OPS_GET_TCP struct independent

Changed SOCK_OPS_GET_TCP to SOCK_OPS_GET_FIELD and added a new argument so now it can also work with struct sock fields. Previous: SOCK_OPS_GET_TCP(FIELD_NAME) New: SOCK_OPS_GET_FIELD(FIELD_NAME, OBJ) Where OBJ is either "struct tcp_sock" or "struct sock" (without quotation). Assumes

Re: [PATCH v2 2/3] vsprintf: print if symbol not found

On Tue, 2017-12-19 at 14:28 +1100, Tobin C. Harding wrote: > Depends on: commit 40eee173a35e ("kallsyms: don't leak address when > symbol not found") > > Currently vsprintf for specifiers %p[SsB] relies on the behaviour of > kallsyms (sprint_symbol()) and prints the actual address if a symbol is

net/wireless/certs/*.x509 binary files

This is just an FYI/acknowledgment that net/wireless/certs/*.x509 binary file(s) practically kills use of Linux kernel tarballs. Of course, someone can always enable EXPERT and CFG80211_CERTIFICATION_ONUS and disable the REGDB kconfig symbols to get around this. Oh, and then chmod +x

Re: r8169 regression: UDP packets dropped intermittantly

Hi again This is a follow up to my earlier message. On Tue, Dec 19, 2017 at 09:02:25AM +1030, Jonathan Woithe wrote: > On Mon, Dec 18, 2017 at 02:38:53PM +0100, Holger Hoffstätte wrote: > > Since I've seen your postings several times now with no comment or > > resolution > > I've decided to try

[PATCH V4 14/26] pch_gbe: deprecate pci_get_bus_and_slot()

pci_get_bus_and_slot() is restrictive such that it assumes domain=0 as where a PCI device is present. This restricts the device drivers to be reused for other domain numbers. Getting ready to remove pci_get_bus_and_slot() function in favor of pci_get_domain_bus_and_slot(). Use the domain

[PATCH V4 13/26] bnx2x: deprecate pci_get_bus_and_slot()

pci_get_bus_and_slot() is restrictive such that it assumes domain=0 as where a PCI device is present. This restricts the device drivers to be reused for other domain numbers. Getting ready to remove pci_get_bus_and_slot() function in favor of pci_get_domain_bus_and_slot(). Introduce

Re: [PATCH v4 25/36] nds32: Miscellaneous header files

Hi, Arnd: 2017-12-18 19:13 GMT+08:00 Arnd Bergmann : > On Mon, Dec 18, 2017 at 7:46 AM, Greentime Hu wrote: >> From: Greentime Hu >> >> This patch introduces some miscellaneous header files. > >> +static inline void __delay(unsigned

Re: Linux ECN Handling

Hi Neal, I started looking into this receiver ACKing issue today. Strangely, when I tried adding printk statements at the top of the tcp_v4_do_rcv(), tcp_rcv_established(), __tcp_ack_snd_check() and tcp_send_delayed_ack() functions they were never executed on the machine running the iperf3 server

Re: [Patch net-next] net_sched: properly check for empty skb array on error path

On 12/18/2017 08:31 PM, Cong Wang wrote: > On Mon, Dec 18, 2017 at 7:58 PM, John Fastabend > wrote: >> On 12/18/2017 06:20 PM, Cong Wang wrote: >>> On Mon, Dec 18, 2017 at 5:25 PM, John Fastabend >>> wrote: On 12/18/2017 02:34 PM, Cong

RE: [PATCH net-next] netdevsim: correctly check return value of debugfs_create_dir

> From: Jakub Kicinski [mailto:jakub.kicin...@netronome.com] > > On Mon, 11 Dec 2017 13:46:48 +0900, Prashant Bhole wrote: > > > From: David Miller [mailto:da...@davemloft.net] > > > > > > From: Prashant Bhole > > > Date: Fri, 8 Dec 2017 09:52:50 +0900 > > > >

Re: [Patch net-next] net_sched: properly check for empty skb array on error path

On Mon, Dec 18, 2017 at 7:58 PM, John Fastabend wrote: > On 12/18/2017 06:20 PM, Cong Wang wrote: >> On Mon, Dec 18, 2017 at 5:25 PM, John Fastabend >> wrote: >>> On 12/18/2017 02:34 PM, Cong Wang wrote: First, the check of >ring.queue

Re: [PATCH 3/3] trace: print address if symbol not found

On Mon, Dec 18, 2017 at 10:37:38PM -0500, Steven Rostedt wrote: > On Tue, 19 Dec 2017 14:00:11 +1100 > "Tobin C. Harding" wrote: > > > I ran through these as outlined here for the new version (v4). This hits > > the modified code but doesn't test symbol look up failure. > >

[PATCH bpf] bpf: do not allow root to mangle valid pointers

Do not allow root to convert valid pointers into unknown scalars. In particular disallow: ptr &= reg ptr <<= reg ptr += ptr and explicitly allow: ptr -= ptr since pkt_end - pkt == length 1. This minimizes amount of address leaks root can do. In the future may need to further tighten the leaks

[PATCH bpf 9/9] selftests/bpf: add tests for recent bugfixes

From: Jann Horn These tests should cover the following cases: - MOV with both zero-extended and sign-extended immediates - implicit truncation of register contents via ALU32/MOV32 - implicit 32-bit truncation of ALU32 output - oversized register source operand for ALU32

[PATCH bpf 2/9] bpf: fix incorrect sign extension in check_alu_op()

From: Jann Horn Distinguish between BPF_ALU64|BPF_MOV|BPF_K (load 32-bit immediate, sign-extended to 64-bit) and BPF_ALU|BPF_MOV|BPF_K (load 32-bit immediate, zero-padded to 64-bit); only perform sign extension in the first case. Starting with v4.14, this is exploitable by

[PATCH bpf 4/9] bpf: fix 32-bit ALU op verification

From: Jann Horn 32-bit ALU ops operate on 32-bit values and have 32-bit outputs. Adjust the verifier accordingly. Fixes: f1174f77b50c ("bpf/verifier: rework value tracking") Signed-off-by: Jann Horn Signed-off-by: Alexei Starovoitov ---

[PATCH bpf 5/9] bpf: fix missing error return in check_stack_boundary()

From: Jann Horn Prevent indirect stack accesses at non-constant addresses, which would permit reading and corrupting spilled pointers. Fixes: f1174f77b50c ("bpf/verifier: rework value tracking") Signed-off-by: Jann Horn Signed-off-by: Alexei Starovoitov

[PATCH bpf 1/9] bpf/verifier: fix bounds calculation on BPF_RSH

From: Edward Cree Incorrect signed bounds were being computed. If the old upper signed bound was positive and the old lower signed bound was negative, this could cause the new upper signed bound to be too low, leading to security issues. Fixes: b03c9f9fdc37 ("bpf/verifier:

[PATCH bpf 7/9] bpf: don't prune branches when a scalar is replaced with a pointer

From: Jann Horn This could be made safe by passing through a reference to env and checking for env->allow_ptr_leaks, but it would only work one way and is probably not worth the hassle - not doing it will not directly lead to program rejection. Fixes: f1174f77b50c

[PATCH bpf 6/9] bpf: force strict alignment checks for stack pointers

From: Jann Horn Force strict alignment checks for stack pointers because the tracking of stack spills relies on it; unaligned stack accesses can lead to corruption of spilled registers, which is exploitable. Fixes: f1174f77b50c ("bpf/verifier: rework value tracking")

[PATCH bpf 8/9] bpf: fix integer overflows

There were various issues related to the limited size of integers used in the verifier: - `off + size` overflow in __check_map_access() - `off + reg->off` overflow in check_mem_access() - `off + reg->var_off.value` overflow or 32-bit truncation of `reg->var_off.value` in check_mem_access()

[PATCH bpf 0/9] bpf: verifier security fixes

This patch set addresses a set of security vulnerabilities in bpf verifier logic discovered by Jann Horn. All of the patches are candidates for 4.14 stable. Alexei Starovoitov (1): bpf: fix integer overflows Edward Cree (1): bpf/verifier: fix bounds calculation on BPF_RSH Jann Horn (7):

[PATCH bpf 3/9] bpf: fix incorrect tracking of register size truncation

From: Jann Horn Properly handle register truncation to a smaller size. The old code first mirrors the clearing of the high 32 bits in the bitwise tristate representation, which is correct. But then, it computes the new arithmetic bounds as the intersection between the old

Re: [PATCH net] sctp: add SCTP_CID_RECONF conversion in sctp_cname

On Mon, Dec 18, 2017 at 9:08 PM, Marcelo Ricardo Leitner wrote: > On Mon, Dec 18, 2017 at 02:13:17PM +0800, Xin Long wrote: >> Whenever a new type of chunk is added, the corresp conversion in >> sctp_cname should be added. Otherwise, in some places, pr_debug >> will

Re: [Patch net-next] net_sched: properly check for empty skb array on error path

On 12/18/2017 06:20 PM, Cong Wang wrote: > On Mon, Dec 18, 2017 at 5:25 PM, John Fastabend > wrote: >> On 12/18/2017 02:34 PM, Cong Wang wrote: >>> First, the check of >ring.queue against NULL is wrong, it >>> is always false. We should check the value rather than the

[PATCH V2 net-next 14/17] net: hns3: add Asym Pause support to phy default features

From: Fuyun Liang commit c4fb2cdf575d ("net: hns3: fix a bug for phy supported feature initialization") adds default supported features for phy, but our hardware also supports Asym Pause. This patch adds Asym Pause support to phy default features to prevent Asym Pause can

[PATCH V2 net-next 10/17] net: hns3: cleanup mac auto-negotiation state query

From: Fuyun Liang When checking whether auto-negotiation is on, driver only needs to check the value of mac.autoneg(SW) directly, and does not need to query it from hardware. Because this value is always synchronized with the auto-negotiation state of hardware. This

[PATCH V2 net-next 06/17] net: hns3: Add a mask initialization for mac_vlan table

This patch sets vlan masked, in order to avoid the received packets being filtered. Signed-off-by: Shenjian Signed-off-by: Lipeng --- .../net/ethernet/hisilicon/hns3/hns3pf/hclge_cmd.h | 10 ++ .../ethernet/hisilicon/hns3/hns3pf/hclge_main.c

Re: [PATCH 3/3] trace: print address if symbol not found

On Tue, 19 Dec 2017 14:00:11 +1100 "Tobin C. Harding" wrote: > I ran through these as outlined here for the new version (v4). This hits > the modified code but doesn't test symbol look up failure. stacktrace shouldn't post non kernel values, unless there's a frame pointer that

[PATCH V2 net-next 17/17] net: hns3: change TM sched mode to TC-based mode when SRIOV enabled

TC-based sched mode supports SRIOV enabled and SRIOV disabled. This patch change the TM sched mode to TC-based mode in initialization process. Fixes: cc9bb43ab394 ("net: hns3: Add tc-based TM support for sriov enabled port") Signed-off-by: Lipeng ---

[PATCH V2 net-next 11/17] net: hns3: fix for getting auto-negotiation state in hclge_get_autoneg

From: Fuyun Liang When phy exists, we use the value of phydev.autoneg to represent the auto-negotiation state of hardware. Otherwise, we use the value of mac.autoneg to represent it. This patch fixes for getting a error value of auto-negotiation state in

[PATCH V2 net-next 15/17] net: hns3: add support for querying advertised pause frame by ethtool ethx

This patch adds support for querying advertised pause frame by using ethtool command(ethtool ethx). Fixes: 496d03e960ae ("net: hns3: Add Ethtool support to HNS3 driver") Signed-off-by: Fuyun Liang Signed-off-by: Lipeng ---

[PATCH V2 net-next 08/17] net: hns3: Add ethtool related offload command

This patch adds offload command related to "ethtool -K". Signed-off-by: Shenjian Signed-off-by: Lipeng --- drivers/net/ethernet/hisilicon/hns3/hnae3.h | 3 +++ drivers/net/ethernet/hisilicon/hns3/hns3_enet.c | 16

[PATCH V2 net-next 09/17] net: hns3: Add handling vlan tag offload in bd

This patch deals with the vlan tag information between sk_buff and rx/tx bd. Signed-off-by: Shenjian Signed-off-by: Lipeng --- drivers/net/ethernet/hisilicon/hns3/hns3_enet.c | 83 +++-- 1 file changed, 78 insertions(+), 5

[PATCH V2 net-next 16/17] net: hns3: Increase the default depth of bucket for TM shaper

Burstiness of a flow is determined by the depth of a bucket, When the upper rate of shaper is large, the current depth of a bucket is not enough. The default upper rate of shaper is 100G, so increase the depth of a bucket according to UM. Signed-off-by: Yunsheng Lin

Re: Shutting down a VM with Kernel 4.14 will sometime hang and a reboot is the only way to recover.

On 2017年12月12日 11:53, David Hill wrote: On 2017-12-08 01:03 PM, David Hill wrote: On 2017-12-07 12:13 AM, Jason Wang wrote: On 2017年12月07日 12:42, David Hill wrote: On 2017-12-06 11:34 PM, David Hill wrote: On 2017-12-04 02:51 PM, David Hill wrote: On 2017-12-03 11:08 PM, Jason

[PATCH V2 net-next 07/17] net: hns3: Add vlan offload config command

This patch adds vlan offload config commands, initializes the rules of tx/rx vlan tag handle for hw. Signed-off-by: Shenjian Signed-off-by: Lipeng --- .../net/ethernet/hisilicon/hns3/hns3pf/hclge_cmd.h | 45 ++

[PATCH V2 net-next 12/17] net: hns3: add support for set_pauseparam

This patch adds set_pauseparam support for ethtool cmd. Signed-off-by: Fuyun Liang Signed-off-by: Lipeng --- drivers/net/ethernet/hisilicon/hns3/hns3_ethtool.c | 13 .../ethernet/hisilicon/hns3/hns3pf/hclge_main.c| 83

[PATCH V2 net-next 01/17] net: hns3: add support to query tqps number

This patch adds the support to query tqps number for PF driver by using ehtool -l command. Signed-off-by: qumingguang Signed-off-by: Lipeng --- drivers/net/ethernet/hisilicon/hns3/hnae3.h | 2 ++

[PATCH V2 net-next 05/17] net: hns3: Get rss_size_max from configuration but not hardcode

From: qumingguang Add configuration for rss_size_max in hdev but not hardcode it. Signed-off-by: qumingguang Signed-off-by: Lipeng --- drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_cmd.h | 2 ++

[PATCH V2 net-next 04/17] net: hns3: Free the ring_data structrue when change tqps

This patch fixes a memory leak problems in change tqps process, the function hns3_uninit_all_ring and hns3_init_all_ring may be called many times. Signed-off-by: qumingguang Signed-off-by: Lipeng --- drivers/net/ethernet/hisilicon/hns3/hns3_enet.c

[PATCH V2 net-next 02/17] net: hns3: add support to modify tqps number

This patch add the support to change tqps number for PF driver by using ehtool -L command. Signed-off-by: qumingguang Signed-off-by: Lipeng --- drivers/net/ethernet/hisilicon/hns3/hnae3.h| 3 +

[PATCH V2 net-next 13/17] net: hns3: add support to update flow control settings after autoneg

When auto-negotiation is enabled, the MAC flow control settings is based on the flow control negotiation result. And it should be configured after a valid link has been established. This patch adds support to update flow control settings after auto-negotiation has completed. Signed-off-by: Fuyun

[PATCH V2 net-next 00/17] add some features and fix some bugs for HNS3 driver

This patchset adds some new feature support and fixes some bugs: [Patch 1/17 - 5/17] add the support to modify/query the tqp number through ethtool -L/l command, and also fix some related bugs for change tqp number. [Patch 6/17 - 9-17] add support vlan tag offload on tx& direction for pf, and fix

[PATCH V2 net-next 03/17] net: hns3: change the returned tqp number by ethtool -x

This patch modifies the return data of get_rxnfc, it will return the current handle's rss_size but not the total tqp number. because the tc_size has been change to the log2 of roundup power of two of rss_size. Signed-off-by: qumingguang Signed-off-by: Lipeng

Re: [trivial PATCH] treewide: Align function definition open/close braces

Joe, > Some functions definitions have either the initial open brace and/or > the closing brace outside of column 1. > > Move those braces to column 1. SCSI bits look OK. Acked-by: Martin K. Petersen -- Martin K. Petersen Oracle Linux Engineering

[PATCH v2 2/3] vsprintf: print if symbol not found

Depends on: commit 40eee173a35e ("kallsyms: don't leak address when symbol not found") Currently vsprintf for specifiers %p[SsB] relies on the behaviour of kallsyms (sprint_symbol()) and prints the actual address if a symbol is not found. Previous patch changes this behaviour so that

[PATCH v2 1/3] kallsyms: don't leak address when symbol not found

Currently if kallsyms_lookup() fails to find the symbol then the address is printed. This potentially leaks sensitive information but is useful for debugging. We would like to stop the leak but keep the current behaviour when needed for debugging. To achieve this we can add a command-line

[PATCH v2 3/3] trace: print address if symbol not found

Fixes behaviour modified by: commit 40eee173a35e ("kallsyms: don't leak address when symbol not found") Previous patch changed behaviour of kallsyms function sprint_symbol() to return an error code instead of printing the address if a symbol was not found. Ftrace relies on the original behaviour.

[PATCH v2 0/3] kallsyms: don't leak address

This set plugs a kernel address leak that occurs if kallsyms symbol look up fails. This set was prompted by a leaking address found using scripts/leaking_addresses.pl on a PowerPC machine in the wild. $ perl scripts/leaking_addresses.pl [address sanitized] ...

Re: [PATCH v7 2/3] sock: Move the socket inuse to namespace.

From: Cong Wang Date: Mon, 18 Dec 2017 13:38:39 -0800 > On Mon, Dec 18, 2017 at 11:30 AM, David Miller wrote: >> From: Tonghao Zhang >> Date: Thu, 14 Dec 2017 05:51:58 -0800 >> >>> In some case, we want to know how many

Re: [PATCH 3/3] trace: print address if symbol not found

On Tue, Dec 19, 2017 at 02:00:11PM +1100, Tobin C. Harding wrote: > On Mon, Dec 18, 2017 at 06:51:43PM -0500, Steven Rostedt wrote: > > On Tue, 19 Dec 2017 08:16:14 +1100 > > "Tobin C. Harding" wrote: > > > > > > > #endif /* _LINUX_KERNEL_TRACE_H */ > > > > > diff --git

Re: [PATCH 3/3] trace: print address if symbol not found

On Mon, Dec 18, 2017 at 06:51:43PM -0500, Steven Rostedt wrote: > On Tue, 19 Dec 2017 08:16:14 +1100 > "Tobin C. Harding" wrote: > > > > > #endif /* _LINUX_KERNEL_TRACE_H */ > > > > diff --git a/kernel/trace/trace_events_hist.c > > > > b/kernel/trace/trace_events_hist.c > > > >

[PATCH net] net: always reevalulate autoflowlabel setting for reset packet

From: Shaohua Li ipv6_pinfo.autoflowlabel is set in sock creation. Later if we change sysctl.ip6.auto_flowlabels, the ipv6_pinfo.autoflowlabel isn't changed, so the sock will keep the old behavior in terms of auto flowlabel. Reset packet is suffering from this problem, because reset

Re: [Patch net-next] net_sched: properly check for empty skb array on error path

On Mon, Dec 18, 2017 at 5:25 PM, John Fastabend wrote: > On 12/18/2017 02:34 PM, Cong Wang wrote: >> First, the check of >ring.queue against NULL is wrong, it >> is always false. We should check the value rather than the address. >> > > Thanks. > >> Secondly, we need the

RE: [Patch v2] net: phy: marvell: Limit 88m1101 autoneg errata to 88E1145 as well.

From: David Miller Date: Tue, 19 Dec 2017 2:20AM > -Original Message- > From: David Miller [mailto:da...@davemloft.net] > Sent: Tuesday, December 19, 2017 2:20 AM > To: Qiang Zhao > Cc: netdev@vger.kernel.org > Subject: Re: [Patch v2] net: phy:

Re: [PATCH v4 16/36] nds32: System calls handling

2017-12-18 19:19 GMT+08:00 Arnd Bergmann : > On Mon, Dec 18, 2017 at 7:46 AM, Greentime Hu wrote: > > >> new file mode 100644 >> index 000..90da745 >> --- /dev/null >> +++ b/arch/nds32/include/uapi/asm/unistd.h >> @@ -0,0 +1,12 @@ >> +//

[PATCH net-next v2] cxgb4: RSS table is 4k for T6

RSS table is 4k for T6 and later cards, add check for the same. Signed-off-by: Ganesh Goudar --- v2: Not a series, It is single patch --- drivers/net/ethernet/chelsio/cxgb4/cudbg_lib.c | 5 ++-- drivers/net/ethernet/chelsio/cxgb4/cxgb4.h | 1 +

Re: [PATCH net-next 17/17] net: hns3: change TM sched mode to TC-based mode when SRIOV enabled

On 2017/12/18 17:08, Sergei Shtylyov wrote: On 12/18/2017 12:31 PM, Lipeng wrote: TC-based sched mode supports SRIOV enabled and SRIOV disabled. This patch change the TM sched mode to TC-based mode in initialization process. Fixes: cc9bb43 (net: hns3: Add tc-based TM support for sriov

Re: [PATCH net-next 14/17] net: hns3: add Asym Pause support to phy default features

On 2017/12/18 17:07, Sergei Shtylyov wrote: Hello! On 12/18/2017 12:31 PM, Lipeng wrote: From: Fuyun Liang commit c4fb2cdf575d (net: hns3: fix a bug for phy supported feature initialization) adds default supported features for phy, but our hardware Ten cited

[PATCH net-next 1/2] cxgb4: RSS table is 4k for T6

RSS table is 4k for T6 and later cards, add check for the same. Signed-off-by: Ganesh Goudar --- drivers/net/ethernet/chelsio/cxgb4/cudbg_lib.c | 5 ++-- drivers/net/ethernet/chelsio/cxgb4/cxgb4.h | 1 + drivers/net/ethernet/chelsio/cxgb4/cxgb4_cudbg.c | 2

Re: [v2 PATCH -tip 3/6] net: sctp: Add SCTP ACK tracking trace event

On Mon, 18 Dec 2017 12:05:16 -0500 Steven Rostedt wrote: > On Mon, 18 Dec 2017 17:12:15 +0900 > Masami Hiramatsu wrote: > > > Add SCTP ACK tracking trace event to trace the changes of SCTP > > association state in response to incoming packets. > > It

Re: [Patch net-next] net_sched: properly check for empty skb array on error path

On 12/18/2017 02:34 PM, Cong Wang wrote: > First, the check of >ring.queue against NULL is wrong, it > is always false. We should check the value rather than the address. > Thanks. > Secondly, we need the same check in pfifo_fast_reset() too, > as both ->reset() and ->destroy() are called in

linux-next: manual merge of the net-next tree with the net tree

Hi all, Today's linux-next merge of the net-next tree got a conflict in: drivers/net/phy/marvell.c between commit: c505873eaece ("net: phy: marvell: Limit 88m1101 autoneg errata to 88E1145 as well.") from the net tree and commit: 80274abafc60 ("net: phy: remove generic settings for

Re: [PATCH net-next] bpf/cgroup: fix a verification error for a CGROUP_DEVICE type prog

On 12/18/2017 07:13 PM, Yonghong Song wrote: > The tools/testing/selftests/bpf test program > test_dev_cgroup fails with the following error > when compiled with llvm 6.0. (I did not try > with earlier versions.) > > libbpf: load bpf program failed: Permission denied > libbpf: -- BEGIN DUMP

[RFC PATCH] virtio_net: Extend virtio to use VF datapath when available

This patch enables virtio to switch over to a VF datapath when a VF netdev is present with the same MAC address. It allows live migration of a VM with a direct attached VF without the need to setup a bond/team between a VF and virtio net device in the guest. The hypervisor needs to unplug the VF

Re: [PATCH] bpf: make function xdp_do_generic_redirect_map() static

On 12/19/2017 12:17 AM, Xiongwei Song wrote: > The function xdp_do_generic_redirect_map() is only used in this file, so > make it static. > > Clean up sparse warning: > net/core/filter.c:2687:5: warning: no previous prototype > for 'xdp_do_generic_redirect_map' [-Wmissing-prototypes] > >

Re: [PATCH bpf-next] selftests/bpf: add netdevsim to config

On 12/19/2017 12:11 AM, Jakub Kicinski wrote: > BPF offload tests (test_offload.py) will require netdevsim > to be built, add it to config. > > Signed-off-by: Jakub Kicinski > Reviewed-by: Quentin Monnet Applied to bpf-next, thanks

Re: [PATCH bpf-next] bpf: arm64: fix uninitialized variable

On 12/18/2017 07:36 PM, Alexei Starovoitov wrote: > On 12/18/17 10:19 AM, Daniel Borkmann wrote: >> On 12/18/2017 07:09 PM, Alexei Starovoitov wrote: >>> From: Alexei Starovoitov >>> >>> fix the following issue: >>> arch/arm64/net/bpf_jit_comp.c: In function 'bpf_int_jit_compile':

Re: [PATCH][next] bpf: make function skip_callee static and return NULL rather than 0

On 12/18/2017 06:47 PM, Colin King wrote: > From: Colin Ian King > > Function skip_callee is local to the source and does not need to > be in global scope, so make it static. Also return NULL rather than 0. > Cleans up two sparse warnings: > > symbol 'skip_callee' was

Re: [PATCH][next] bpf: fix spelling mistake: "funcation"-> "function"

On 12/18/2017 03:03 PM, Colin King wrote: > From: Colin Ian King > > Trivial fix to spelling mistake in error message text. > > Signed-off-by: Colin Ian King Applied to bpf-next, thanks Colin!

Re: [PATCH 1/3] kallsyms: don't leak address when symbol not found

On Mon, Dec 18, 2017 at 06:43:24PM -0500, Steven Rostedt wrote: > On Tue, 19 Dec 2017 09:41:29 +1100 > "Tobin C. Harding" wrote: > > > Current suggestion on list is to remove this function. Do you have a use > > case in mind where debugging will break? We could add a fix to this >

Re: [PATCH 3/3] trace: print address if symbol not found

On Mon, Dec 18, 2017 at 06:51:43PM -0500, Steven Rostedt wrote: > On Tue, 19 Dec 2017 08:16:14 +1100 > "Tobin C. Harding" wrote: > > > > > #endif /* _LINUX_KERNEL_TRACE_H */ > > > > diff --git a/kernel/trace/trace_events_hist.c > > > > b/kernel/trace/trace_events_hist.c > > > >

Re: [PATCH] bpf: fix broken BPF selftest build on s390

On 12/18/2017 02:09 PM, Hendrik Brueckner wrote: > With 720f228e8d31 ("bpf: fix broken BPF selftest build") the > inclusion of arch-specific header files changed. Including the > asm/bpf_perf_event.h on s390, correctly includes the s390 specific > header file. This header file tries then to

Re: [PATCH 3/3] trace: print address if symbol not found

On Tue, 19 Dec 2017 08:16:14 +1100 "Tobin C. Harding" wrote: > > > #endif /* _LINUX_KERNEL_TRACE_H */ > > > diff --git a/kernel/trace/trace_events_hist.c > > > b/kernel/trace/trace_events_hist.c > > > index 1e1558c99d56..3e28522a76f4 100644 > > > ---

Re: [PATCH 1/3] kallsyms: don't leak address when symbol not found

On Tue, 19 Dec 2017 09:41:29 +1100 "Tobin C. Harding" wrote: > Current suggestion on list is to remove this function. Do you have a use > case in mind where debugging will break? We could add a fix to this > series if so. Otherwise next version will likely drop >

Re: [PATCH 2/3] rhashtable: Add rhashtable_walk_curr

On Mon, Dec 18, 2017 at 02:31:21PM +0100, Andreas Gruenbacher wrote: > When iterating through an rhashtable is stopped with > rhashtable_walk_stop and then resumed with rhashtable_walk_start, there > currently is no way to get back to the current object and thus revisit > the object

[PATCH] bpf: make function xdp_do_generic_redirect_map() static

The function xdp_do_generic_redirect_map() is only used in this file, so make it static. Clean up sparse warning: net/core/filter.c:2687:5: warning: no previous prototype for 'xdp_do_generic_redirect_map' [-Wmissing-prototypes] Signed-off-by: Xiongwei Song ---

  1   2   3   4   >