Re: [PATCH bpf-next 12/13] bpf: arm64: add JIT support for multi-function programs

2017-12-18 Thread Daniel Borkmann
ialization > >> prog->bpf_func = (void *)ctx.image; >> prog->jited = 1; >> prog->jited_len = image_size; > > so we now get a warning here, starting with linux-next-20171218: > > arch/arm64/net/bpf_jit_comp.c: In function 'bpf_int_jit_

Re: pull-request: bpf-next 2017-12-18

2017-12-18 Thread David Miller
From: Daniel Borkmann Date: Mon, 18 Dec 2017 01:33:07 +0100 > The following pull-request contains BPF updates for your *net-next* tree. > > The main changes are: > > 1) Allow arbitrary function calls from one BPF function to another BPF > function. >As of today when

Re: [net 1/1] tipc: remove leaving group member from all lists

2017-12-18 Thread David Miller
From: Jon Maloy Date: Mon, 18 Dec 2017 18:13:34 +0100 > A group member going into state LEAVING should never go back to any > other state before it is finally deleted. However, this might happen > if the socket needs to send out a RECLAIM message during this interval. >

Re: [net 1/1] tipc: fix lost member events bug

2017-12-18 Thread David Miller
From: Jon Maloy Date: Mon, 18 Dec 2017 17:34:16 +0100 > Group messages are not supposed to be returned to sender when the > destination socket disappears. This is done correctly for regular > traffic messages, by setting the 'dest_droppable' bit in the header. > But we

Re: [PATCH net-next 0/6] sfc: Initial X2000-series (Medford2) support

2017-12-18 Thread David Miller
From: Edward Cree Date: Mon, 18 Dec 2017 16:54:29 + > Basic PCI-level changes to support X2000-series NICs. > Also fix unexpected-PTP-event log messages, since the timestamp format has > been changed in these NICs and that causes us to fail to probe PTP (but we >

Re: [bpf-next V1-RFC PATCH 01/14] xdp: base API for new XDP rx-queue info concept

2017-12-18 Thread Jesper Dangaard Brouer
On Mon, 18 Dec 2017 06:23:40 -0700 David Ahern wrote: > On 12/18/17 3:55 AM, Jesper Dangaard Brouer wrote: > > > > Handling return-errors in the drivers complicated the driver code, as it > > involves unraveling and deallocating other RX-rings etc (that were > > already

[PATCH net-next] bpf/cgroup: fix a verification error for a CGROUP_DEVICE type prog

2017-12-18 Thread Yonghong Song
The tools/testing/selftests/bpf test program test_dev_cgroup fails with the following error when compiled with llvm 6.0. (I did not try with earlier versions.) libbpf: load bpf program failed: Permission denied libbpf: -- BEGIN DUMP LOG --- libbpf: 0: (61) r2 = *(u32 *)(r1 +4) 1: (b7)

[PATCH bpf-next] bpf: arm64: fix uninitialized variable

2017-12-18 Thread Alexei Starovoitov
From: Alexei Starovoitov fix the following issue: arch/arm64/net/bpf_jit_comp.c: In function 'bpf_int_jit_compile': arch/arm64/net/bpf_jit_comp.c:982:18: error: 'image_size' may be used uninitialized in this function [-Werror=maybe-uninitialized] Fixes: db496944fdaa ("bpf: arm64:

Re: [PATCH v2 0/5] Support for generalized use of make C={1,2} via a wrapper program

2017-12-18 Thread Bart Van Assche
On Mon, 2017-12-18 at 10:46 -0700, Jason Gunthorpe wrote: > On Sun, Dec 17, 2017 at 10:00:17PM -0800, Joe Perches wrote: > > > > Today when we run checkers we get so many warnings it is too hard to > > > make any sense of it. > > > > Here is a list of the checkpatch messages for

Re: [RFC ipsec-next 3/4] net: xfrm: support multiple VTI tunnels

2017-12-18 Thread David Miller
From: Lorenzo Colitti Date: Tue, 19 Dec 2017 01:16:55 +0900 > - ICMP errors are similar to input, except the search is for the > outbound XFRM state, because the only data that is available is > the outbound SPI. Thus, ICMP errors are only processed if the > ikey is the

Re: [PATCH bpf-next 12/13] bpf: arm64: add JIT support for multi-function programs

2017-12-18 Thread Alexei Starovoitov
prog->jited = 1; prog->jited_len = image_size; so we now get a warning here, starting with linux-next-20171218: arch/arm64/net/bpf_jit_comp.c: In function 'bpf_int_jit_compile': arch/arm64/net/bpf_jit_comp.c:982:18: error: 'image_size' may be used uninitialized in t

Re: [PATCH v2 0/5] Support for generalized use of make C={1,2} via a wrapper program

2017-12-18 Thread Joe Perches
On Mon, 2017-12-18 at 10:46 -0700, Jason Gunthorpe wrote: > On Sun, Dec 17, 2017 at 10:00:17PM -0800, Joe Perches wrote: > > > > Today when we run checkers we get so many warnings it is too hard to > > > make any sense of it. > > > > Here is a list of the checkpatch messages for

[PATCH] ss: fix crash with invalid command input file

2017-12-18 Thread Stephen Hemminger
If given an invalid input file with -F flag, ss would crash. Examples of invalid input are line to long, or null file. Signed-off-by: Stephen Hemminger --- misc/ssfilter.y | 20 ++-- 1 file changed, 14 insertions(+), 6 deletions(-) diff --git

Re: [PATCH v2 0/5] Support for generalized use of make C={1,2} via a wrapper program

2017-12-18 Thread Jason Gunthorpe
On Mon, Dec 18, 2017 at 02:05:15PM +0100, Knut Omang wrote: > https://github.com/torvalds/linux/compare/master...knuto:runchecks Several of these to rdma/core do not look so big, you should think about sending them.. Jason

[PATCH iproute2 2/3] link_ip6tnl: Use IN6ADDR_ANY_INIT to initialize local/remote endpoints

2017-12-18 Thread Serhey Popovych
Use specialized helper to initialize endpoint addresses with zeros instead of open coding this. This unifies initialization style with other ipv6 tunnel variants (i.e. gre6 and vti6). Signed-off-by: Serhey Popovych --- ip/link_ip6tnl.c |4 ++-- 1 file changed, 2

[PATCH iproute2 1/3] ip/tunnel: Use tnl_parse_key() to parse tunnel key

2017-12-18 Thread Serhey Popovych
It is added with commit a7ed1520ee96 (ip/tunnel: introduce tnl_parse_key()) to avoid code duplication in ip6?tunnel.c. Reuse it for gre/gre6 and vti/vti6 tunnel rtnl configuration interface with the same purpose it is used in tunnel ioctl interface in ip6?tunnel.c. While there change type of key

[PATCH iproute2 3/3] link_vti6: Always add local/remote endpoint attributes

2017-12-18 Thread Serhey Popovych
All tunnels already support for parsing/adding zero endpoints and vti6 isn't an exception. This check was added as part of commit 2a80154fde40 (vti6: fix local/remote any addr handling) and looks too restrictive as purpose of change is to avoid endpoint configuration from uninitialized data.

[PATCH iproute2 0/3] ip/tunnels: Reuse code, vti6 zero endpoint support and minor cleanup

2017-12-18 Thread Serhey Popovych
In this series I present next set of improvements: 1) Use tnl_parse_key() to avoid code duplication in tunnel configuration via netlink code. 2) Trivial: use IN6ADDR_ANY_INIT instead of open coded initialization of local/remote endpoint in ip6tnl code. 3) Trivial: drop

[PATCH][next] bpf: make function skip_callee static and return NULL rather than 0

2017-12-18 Thread Colin King
From: Colin Ian King Function skip_callee is local to the source and does not need to be in global scope, so make it static. Also return NULL rather than 0. Cleans up two sparse warnings: symbol 'skip_callee' was not declared. Should it be static? Using plain integer

Re: [PATCH v2 0/5] Support for generalized use of make C={1,2} via a wrapper program

2017-12-18 Thread Jason Gunthorpe
On Sun, Dec 17, 2017 at 10:00:17PM -0800, Joe Perches wrote: > > Today when we run checkers we get so many warnings it is too hard to > > make any sense of it. > > Here is a list of the checkpatch messages for drivers/infiniband > sorted by type. > > Many of these might be corrected by using >

Re: [rds-devel] BUG: unable to handle kernel NULL pointer dereference in rds_send_xmit

2017-12-18 Thread Sowmini Varadhan
> From: Santosh Shilimkar > Date: Mon, 18 Dec 2017 08:28:05 -0800 : > > Looks like another one tripping on empty transport. Mostly below > > should > > address it but we will test it if it does. that was my first thought, but it cannot be the case here:

Re: BUG: unable to handle kernel NULL pointer dereference in rds_send_xmit

2017-12-18 Thread Santosh Shilimkar
On 12/18/2017 9:12 AM, David Miller wrote: From: Santosh Shilimkar Date: Mon, 18 Dec 2017 08:28:05 -0800 On 12/18/2017 12:43 AM, syzbot wrote: Hello, syzkaller hit the following crash on 6084b576dca2e898f5c101baef151f7bfdbb606d

Re: Linux 4.14 - regression: broken tun/tap / bridge network with virtio - bisected

2017-12-18 Thread Andreas Hartmann
On 12/17/2017 at 11:33 PM Willem de Bruijn wrote: > On Fri, Dec 15, 2017 at 1:05 AM, Andreas Hartmann > wrote: >> On 12/14/2017 at 11:17 PM Willem de Bruijn wrote: > Well, the patch does not fix hanging VMs, which have been shutdown and > can't be killed any

RE: [Intel-wired-lan] v4.15-rc2 on thinkpad x60: ethernet stopped working

2017-12-18 Thread Fujinaka, Todd
Jeff was out sick last week. It might take him a bit to catch up. I'll remind him when I see him next (which I hope is soon). Todd Fujinaka Software Application Engineer Datacenter Engineering Group Intel Corporation todd.fujin...@intel.com -Original Message- From: Intel-wired-lan

[net 1/1] tipc: remove leaving group member from all lists

2017-12-18 Thread Jon Maloy
A group member going into state LEAVING should never go back to any other state before it is finally deleted. However, this might happen if the socket needs to send out a RECLAIM message during this interval. Since we forget to remove the leaving member from the group's 'active' or 'pending' list,

Re: BUG: unable to handle kernel NULL pointer dereference in rds_send_xmit

2017-12-18 Thread David Miller
From: Santosh Shilimkar Date: Mon, 18 Dec 2017 08:28:05 -0800 > On 12/18/2017 12:43 AM, syzbot wrote: >> Hello, >> syzkaller hit the following crash on >> 6084b576dca2e898f5c101baef151f7bfdbb606d >>

Re: [PATCH v3 net-next 0/6] tls: Add generic NIC offload infrastructure

2017-12-18 Thread Jiri Pirko
Mon, Dec 18, 2017 at 12:10:27PM CET, il...@mellanox.com wrote: >Changes from v2: >- Fix sk use after free and possible netdev use after free >- tls device now keeps a refernce on the offloading netdev >- tls device registers to the netdev notifer. > Upon a NETDEV_DOWN event, offload is stopped

Re: [v2 PATCH -tip 3/6] net: sctp: Add SCTP ACK tracking trace event

2017-12-18 Thread Steven Rostedt
On Mon, 18 Dec 2017 17:12:15 +0900 Masami Hiramatsu wrote: > Add SCTP ACK tracking trace event to trace the changes of SCTP > association state in response to incoming packets. > It is used for debugging SCTP congestion control algorithms, > and will replace sctp_probe

Re: BUG: spinlock bad magic (2)

2017-12-18 Thread Dmitry Vyukov
On Mon, Dec 18, 2017 at 5:46 PM, Santosh Shilimkar wrote: > On 12/18/2017 4:36 AM, syzbot wrote: >> >> Hello, >> >> syzkaller hit the following crash on >> 6084b576dca2e898f5c101baef151f7bfdbb606d >>

[PATCH net-next 6/6] sfc: populate the timer reload field

2017-12-18 Thread Edward Cree
From: Bert Kenward The timer mode register now has a separate field for the reload value. Since we always use this timer with the reload (for interrupt moderation) we set this to the same as the initial value. Previous hardware ignores this field, so we can safely set

[PATCH net-next 5/6] sfc: update EF10 register definitions

2017-12-18 Thread Edward Cree
From: Bert Kenward The RX_L4_CLASS field has shrunk from 3 bits to 2 bits. The upper bit was never used in previous hardware, so we can use the new definition throughout. The TSO OUTER_IPID field was previously spelt differently from the external definitions.

[PATCH net-next 4/6] sfc: improve PTP error reporting

2017-12-18 Thread Edward Cree
Log a message if PTP probing fails; if we then, unexpectedly, get PTP events, only log a message for the first one on each device. Signed-off-by: Edward Cree --- drivers/net/ethernet/sfc/ef10.c | 9 - drivers/net/ethernet/sfc/net_driver.h | 2 ++

[PATCH net-next 2/6] sfc: support VI strides other than 8k

2017-12-18 Thread Edward Cree
Medford2 can also have 16k or 64k VI stride. This is reported by MCDI in GET_CAPABILITIES, which fortunately is called before the driver does anything sensitive to the VI stride (such as accessing or even allocating VIs past the zeroth). Signed-off-by: Edward Cree ---

[PATCH net-next 3/6] sfc: add Medford2 (SFC9250) PCI Device IDs

2017-12-18 Thread Edward Cree
Signed-off-by: Edward Cree --- drivers/net/ethernet/sfc/efx.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/net/ethernet/sfc/efx.c b/drivers/net/ethernet/sfc/efx.c index e50049cba50b..7bcbedce07a5 100644 --- a/drivers/net/ethernet/sfc/efx.c +++

[PATCH net-next 1/6] sfc: make mem_bar a function rather than a constant

2017-12-18 Thread Edward Cree
Support using BAR 0 on SFC9250, even though the driver doesn't bind to such devices yet. Signed-off-by: Edward Cree --- drivers/net/ethernet/sfc/ef10.c | 26 +++--- drivers/net/ethernet/sfc/efx.c| 4 ++-- drivers/net/ethernet/sfc/efx.h

[PATCH net-next 0/6] sfc: Initial X2000-series (Medford2) support

2017-12-18 Thread Edward Cree
Basic PCI-level changes to support X2000-series NICs. Also fix unexpected-PTP-event log messages, since the timestamp format has been changed in these NICs and that causes us to fail to probe PTP (but we still get the PPS events). Bert Kenward (2): sfc: update EF10 register definitions sfc:

Re: [PATCH 3/3] trace: print address if symbol not found

2017-12-18 Thread Steven Rostedt
On Mon, 18 Dec 2017 10:53:32 +1100 "Tobin C. Harding" wrote: > Fixes behaviour modified by: commit bd6b239cdbb2 ("kallsyms: don't leak > address when symbol not found") > > Previous patch changed behaviour of kallsyms function sprint_symbol() to > return an error code instead of

Re: [PATCH v2 0/5] Support for generalized use of make C={1,2} via a wrapper program

2017-12-18 Thread Knut Omang
On Mon, 2017-12-18 at 07:30 -0800, Joe Perches wrote: > On Mon, 2017-12-18 at 14:05 +0100, Knut Omang wrote: > > > Here is a list of the checkpatch messages for drivers/infiniband > > > sorted by type. > > > > > > Many of these might be corrected by using > > > > > > $ ./scripts/checkpatch.pl -f

Re: BUG: spinlock bad magic (2)

2017-12-18 Thread Santosh Shilimkar
On 12/18/2017 4:36 AM, syzbot wrote: Hello, syzkaller hit the following crash on 6084b576dca2e898f5c101baef151f7bfdbb606d git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/master compiler: gcc (GCC) 7.1.1 20170620 .config is attached Raw console output is attached.

[net 1/1] tipc: fix lost member events bug

2017-12-18 Thread Jon Maloy
Group messages are not supposed to be returned to sender when the destination socket disappears. This is done correctly for regular traffic messages, by setting the 'dest_droppable' bit in the header. But we forget to do that in group protocol messages. This has the effect that such messages may

[RFC ipsec-next 4/4] net: xfrm: don't pass tunnel objects to xfrm6_rcv_spi.

2017-12-18 Thread Lorenzo Colitti
This change removes the tunnel parameter from xfrm6_rcv_spi and deletes xfrm6_rcv_tnl. These were only used by the VTI code and are now unused. Signed-off-by: Lorenzo Colitti --- include/net/xfrm.h | 4 +--- net/ipv4/ip_vti.c | 4 ++-- net/ipv6/ip6_vti.c |

[RFC ipsec-next 3/4] net: xfrm: support multiple VTI tunnels

2017-12-18 Thread Lorenzo Colitti
This commit allows the creation of multiple VTI tunnels with the same src+dst pair, via a new VTI_KEYED flag. This makes it possible to maintain multiple IPsec tunnels to the same security gateway, with the tunnels distinguished by SPI. The new semantics are as follows: - The output path is the

[RFC ipsec-next 1/4] met: xfrm: Add an xfrm lookup that ignores the mark.

2017-12-18 Thread Lorenzo Colitti
The xfrm inbound and ICMP error paths can match inbound XFRM states that have a mark, but only if the skb mark is already correctly set to match the state mark. This typically requires iptables rules (potentially even per SA iptables rules), which impose configuration complexity. In some cases,

Re: BUG: unable to handle kernel NULL pointer dereference in rds_send_xmit

2017-12-18 Thread Santosh Shilimkar
On 12/18/2017 12:43 AM, syzbot wrote: Hello, syzkaller hit the following crash on 6084b576dca2e898f5c101baef151f7bfdbb606d git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/master compiler: gcc (GCC) 7.1.1 20170620 .config is attached Raw console output is attached.

[RFC ipsec-next 2/4] net: xfrm: find VTI interfaces from xfrm_input

2017-12-18 Thread Lorenzo Colitti
Currently, the VTI input path works by first looking up the VTI by its IP addresses, then setting the tunnel pointer in the XFRM_TUNNEL_SKB_CB, and then having xfrm_input override the mark with the mark in the tunnel. This patch changes the order so that the tunnel is found by a callback from

[PATCH 4.14 121/178] l2tp: cleanup l2tp_tunnel_delete calls

2017-12-18 Thread Greg Kroah-Hartman
4.14-stable review patch. If anyone has any objections, please let me know. -- From: Jiri Slaby [ Upstream commit 4dc12ffeaeac939097a3f55c881d3dc3523dff0c ] l2tp_tunnel_delete does not return anything since commit 62b982eeb458 ("l2tp: fix race condition in

[RFC ipsec-next 0/4]: Support multiple VTIs with the same src+dst pair

2017-12-18 Thread Lorenzo Colitti
When using IPsec tunnel mode, VTIs provide many benefits compared to direct configuration of xfrm policies / states. However, one limitation is that there can only be one VTI between a given pair of IP addresses. This does not allow configuring multiple IPsec tunnels to the same security gateway.

Re: [PATCH] net: qcom/emac: Change the order of mac up and sgmii open

2017-12-18 Thread Timur Tabi
On 12/17/2017 11:57 PM, Hemanth Puranik wrote: This patch fixes the order of mac_up and sgmii_open for the reasons noted below: - If open takes more time(if the SGMII block is not responding or if we want to do some delay based task) in this situation we will hit NETDEV watchdog - The

[PATCH 4.9 151/177] l2tp: cleanup l2tp_tunnel_delete calls

2017-12-18 Thread Greg Kroah-Hartman
4.9-stable review patch. If anyone has any objections, please let me know. -- From: Jiri Slaby [ Upstream commit 4dc12ffeaeac939097a3f55c881d3dc3523dff0c ] l2tp_tunnel_delete does not return anything since commit 62b982eeb458 ("l2tp: fix race condition in

[PATCH 4.4 095/115] l2tp: cleanup l2tp_tunnel_delete calls

2017-12-18 Thread Greg Kroah-Hartman
4.4-stable review patch. If anyone has any objections, please let me know. -- From: Jiri Slaby [ Upstream commit 4dc12ffeaeac939097a3f55c881d3dc3523dff0c ] l2tp_tunnel_delete does not return anything since commit 62b982eeb458 ("l2tp: fix race condition in

[PATCH net v2] net: bridge: fix early call to br_stp_change_bridge_id and plug newlink leaks

2017-12-18 Thread Nikolay Aleksandrov
The early call to br_stp_change_bridge_id in bridge's newlink can cause a memory leak if an error occurs during the newlink because the fdb entries are not cleaned up if a different lladdr was specified, also another minor issue is that it generates fdb notifications with ifindex = 0. Another

Re: [PATCH v2 0/5] Support for generalized use of make C={1,2} via a wrapper program

2017-12-18 Thread Joe Perches
On Mon, 2017-12-18 at 14:05 +0100, Knut Omang wrote: > > Here is a list of the checkpatch messages for drivers/infiniband > > sorted by type. > > > > Many of these might be corrected by using > > > > $ ./scripts/checkpatch.pl -f --fix-inplace --types= \ > > $(git ls-files drivers/infiniband/)

Re: [PATCH bpf-next 12/13] bpf: arm64: add JIT support for multi-function programs

2017-12-18 Thread Arnd Bergmann
prog->jited_len = image_size; so we now get a warning here, starting with linux-next-20171218: arch/arm64/net/bpf_jit_comp.c: In function 'bpf_int_jit_compile': arch/arm64/net/bpf_jit_comp.c:982:18: error: 'image_size' may be used uninitialized in this function [-Werror=maybe-uninitialized

Re: [PATCH v10 3/5] bpf: add a bpf_override_function helper

2017-12-18 Thread Daniel Borkmann
On 12/18/2017 10:51 AM, Masami Hiramatsu wrote: > On Fri, 15 Dec 2017 14:12:54 -0500 > Josef Bacik wrote: >> From: Josef Bacik >> >> Error injection is sloppy and very ad-hoc. BPF could fill this niche >> perfectly with it's kprobe functionality. We could

[PATCH][next] ath10k: wmi: remove redundant integer fc

2017-12-18 Thread Colin King
From: Colin Ian King Variable fc is being assigned but never used, so remove it. Cleans up the clang warning: warning: Value stored to 'fc' is never read Signed-off-by: Colin Ian King --- drivers/net/wireless/ath/ath10k/wmi-tlv.c | 2 -- 1

Re: [PATCH net-next 2/2 v9] net: ethernet: Add a driver for Gemini gigabit ethernet

2017-12-18 Thread Russell King - ARM Linux
On Mon, Dec 18, 2017 at 03:48:17PM +0100, Michał Mirosław wrote: > On Mon, Dec 18, 2017 at 02:57:37PM +0100, Linus Walleij wrote: > > On Sat, Dec 16, 2017 at 8:39 PM, Linus Walleij > > wrote: > > > > > The Gemini ethernet has been around for years as an out-of-tree > >

Re: [PATCH net-next 2/2 v9] net: ethernet: Add a driver for Gemini gigabit ethernet

2017-12-18 Thread Michał Mirosław
On Mon, Dec 18, 2017 at 02:57:37PM +0100, Linus Walleij wrote: > On Sat, Dec 16, 2017 at 8:39 PM, Linus Walleij > wrote: > > > The Gemini ethernet has been around for years as an out-of-tree > > patch used with the NAS boxen and routers built on StorLink > > SL3512 and

[PATCH RESEND] Bluetooth: Prevent stack info leak from the EFS element.

2017-12-18 Thread Greg Kroah-Hartman
From: Ben Seri In the function l2cap_parse_conf_rsp and in the function l2cap_parse_conf_req the following variable is declared without initialization: struct l2cap_conf_efs efs; In addition, when parsing input configuration parameters in both of these functions, the switch

Re: [PATCH net-next] udp: handle gro_receive only when necessary

2017-12-18 Thread Paolo Abeni
On Mon, 2017-12-18 at 20:09 +0800, zhangliping wrote: > My test case is very simple, two VMs were connected via ovs + dpdk. > Inside VM, rps is enabled. Then one VM runs "iperf -s -u &", another > VM runs "iperf -c 1.1.1.2 -P 12 -u -b 10Gbps -l 40 -t 36000". Understood, thanks. Still the time

Re: [PATCH net] sctp: add SCTP_CID_RECONF conversion in sctp_cname

2017-12-18 Thread Neil Horman
On Mon, Dec 18, 2017 at 02:13:17PM +0800, Xin Long wrote: > Whenever a new type of chunk is added, the corresp conversion in > sctp_cname should be added. Otherwise, in some places, pr_debug > will print it as "unknown chunk". > > Fixes: cc16f00f6529 ("sctp: add support for generating stream

Re: [PATCH] wil6210: fix build warnings without CONFIG_PM

2017-12-18 Thread Kalle Valo
Arnd Bergmann writes: > The #ifdef checks are hard to get right, in this case some functions > should have been left inside a CONFIG_PM_SLEEP check as seen by this > message: > > drivers/net/wireless/ath/wil6210/pcie_bus.c:489:12: error: > 'wil6210_pm_resume' defined but not used

Re: [PATCH net] sctp: fix the issue that a __u16 variable may overflow in sctp_ulpq_renege

2017-12-18 Thread Neil Horman
On Mon, Dec 18, 2017 at 02:07:25PM +0800, Xin Long wrote: > Now when reneging events in sctp_ulpq_renege(), the variable freed > could be increased by a __u16 value twice while freed is of __u16 > type. It means freed may overflow at the second addition. > > This patch is to fix it by using __u32

Re: [PATCH net] net: bridge: fix early call to br_stp_change_bridge_id

2017-12-18 Thread Nikolay Aleksandrov
On 12/18/2017 04:22 PM, Nikolay Aleksandrov wrote: > On 12/18/2017 04:24 AM, Toshiaki Makita wrote: >> On 2017/12/16 20:31, Nikolay Aleksandrov wrote: > [snip] >> ... >>> err = br_changelink(dev, tb, data, extack); >>> - if (err) >>> + if (err) { >>> + /* clean possible fdbs from

Re: [PATCH net] net: bridge: fix early call to br_stp_change_bridge_id

2017-12-18 Thread Nikolay Aleksandrov
On 12/18/2017 04:24 AM, Toshiaki Makita wrote: > On 2017/12/16 20:31, Nikolay Aleksandrov wrote: [snip] > ... >> err = br_changelink(dev, tb, data, extack); >> -if (err) >> +if (err) { >> +/* clean possible fdbs from br_stp_change_bridge_id above */ >> +

pull-request: wireless-drivers-next 2017-12-18

2017-12-18 Thread Kalle Valo
Hi Dave, a pull request for 4.16 to net-next tree. This is a big one, but on the other hand most of the stuff here has been some time on linux-next so hopefully there are no nasty surprises. Even though Arnd just send a patch[1] five minutes ago about fixing a wcn36xx build warning, but I don't

[PATCH net-next] cxgb4: Report tid start range correctly for T6

2017-12-18 Thread Ganesh Goudar
For T6, tid start range should be read from LE_DB_ACTIVE_TABLE_START_INDEX_A register. Signed-off-by: Arjun Vynipadath Signed-off-by: Ganesh Goudar --- drivers/net/ethernet/chelsio/cxgb4/cxgb4_debugfs.c | 11 --- 1 file changed, 8 insertions(+),

RE: [PATCH 25/27] qede: Use timecounter_reset interface

2017-12-18 Thread Kalluru, Sudarsana
Acked-by: Sudarsana Kalluru -Original Message- From: Sagar Arun Kamble [mailto:sagar.a.kam...@intel.com] Sent: 15 December 2017 13:09 To: linux-ker...@vger.kernel.org Cc: Sagar Arun Kamble ; Richard Cochran

RE: [PATCH 18/27] bnx2x: Use timecounter_reset interface

2017-12-18 Thread Kalluru, Sudarsana
Acked-by: Sudarsana Kalluru -Original Message- From: Sagar Arun Kamble [mailto:sagar.a.kam...@intel.com] Sent: 15 December 2017 13:09 To: linux-ker...@vger.kernel.org Cc: Sagar Arun Kamble ; Richard Cochran

Re: [net-next: PATCH 0/8] Armada 7k/8k PP2 ACPI support

2017-12-18 Thread Rafael J. Wysocki
On 12/18/2017 10:17 AM, Marcin Wojtas wrote: Hi, This patchset introduces ACPI support in mvpp2 and mvmdio drivers. First three patches introduce fwnode helpers for obtaining PHY information from nodes and also MDIO fwnode API for registering the bus with its PHY/devices. Following patches

[PATCH][next] bpf: fix spelling mistake: "funcation"-> "function"

2017-12-18 Thread Colin King
From: Colin Ian King Trivial fix to spelling mistake in error message text. Signed-off-by: Colin Ian King --- kernel/bpf/verifier.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/bpf/verifier.c

Re: [PATCH net-next 2/2 v9] net: ethernet: Add a driver for Gemini gigabit ethernet

2017-12-18 Thread Linus Walleij
On Sat, Dec 16, 2017 at 8:39 PM, Linus Walleij wrote: > The Gemini ethernet has been around for years as an out-of-tree > patch used with the NAS boxen and routers built on StorLink > SL3512 and SL3516, later Storm Semiconductor, later Cortina > Systems. These ASICs are

Re: BUG: unable to handle kernel NULL pointer dereference in rds_send_xmit

2017-12-18 Thread Sowmini Varadhan
On (12/18/17 00:43), syzbot wrote: > BUG: unable to handle kernel NULL pointer dereference at 0028 > program syz-executor6 is using a deprecated SCSI ioctl, please convert it to > SG_IO > IP: rds_send_xmit+0x80/0x930 net/rds/send.c:186 conn->c_trans is at offset 0x28. Both this and

Re: Wifi RTL8723bu driver test: failed to scan

2017-12-18 Thread Mylene JOSSERAND
Hello Jes, Le Tue, 28 Nov 2017 11:14:10 -0500, Jes Sorensen a écrit : > On 11/22/2017 04:51 AM, Mylene JOSSERAND wrote: > > Hello Jes Sorensen, > > > > I am currently testing a LM811 Wifi/BT USB dongle [1] on a Sinlinx > > SinA33 Allwinner SoC board [2]. I saw that I

[PATCH] wil6210: fix build warnings without CONFIG_PM

2017-12-18 Thread Arnd Bergmann
The #ifdef checks are hard to get right, in this case some functions should have been left inside a CONFIG_PM_SLEEP check as seen by this message: drivers/net/wireless/ath/wil6210/pcie_bus.c:489:12: error: 'wil6210_pm_resume' defined but not used [-Werror=unused-function]

Re: [PATCH v2 0/5] Support for generalized use of make C={1,2} via a wrapper program

2017-12-18 Thread Knut Omang
On Sun, 2017-12-17 at 22:00 -0700, Jason Gunthorpe wrote: > On Sun, Dec 17, 2017 at 03:14:10AM +0100, Knut Omang wrote: > > > > I like the ability to add more checkers and keep then in the main > > > upstream tree. But adding overrides for specific subsystems goes against > > > the policy that

Re: r8169 regression: UDP packets dropped intermittantly

2017-12-18 Thread Holger Hoffstätte
On 12/18/17 06:49, Jonathan Woithe wrote: > Resend to netdev. LKML CCed in case anyone in the wider kernel community > can suggest a way forward. Please CC responses if replying only to LKML. > > It seems that this 4+ year old regression in the r8169 driver (documented in > this thread on

[PATCH 2/3] rhashtable: Add rhashtable_walk_curr

2017-12-18 Thread Andreas Gruenbacher
When iterating through an rhashtable is stopped with rhashtable_walk_stop and then resumed with rhashtable_walk_start, there currently is no way to get back to the current object and thus revisit the object rhashtable_walk_next has previously returned. This functionality is useful when dumping an

RE: [PATCH] qed: Remove unused QED_RDMA_DEV_CAP_* symbols and dev->dev_caps

2017-12-18 Thread Amrani, Ram
> From: Bjorn Helgaas > > The QED_RDMA_DEV_CAP_* symbols are only used to set bits in dev->dev_caps. > Nobody ever looks at those bits. Remove the symbols and dev_caps itself. > > Note that if these are ever used and added back, it looks incorrect to set >

Re: [bpf-next V1-RFC PATCH 01/14] xdp: base API for new XDP rx-queue info concept

2017-12-18 Thread David Ahern
On 12/18/17 3:55 AM, Jesper Dangaard Brouer wrote: > > Handling return-errors in the drivers complicated the driver code, as it > involves unraveling and deallocating other RX-rings etc (that were > already allocated) if the reg fails. (Also notice next patch will allow > dev == NULL, if right

[PATCH] bpf: fix broken BPF selftest build on s390

2017-12-18 Thread Hendrik Brueckner
With 720f228e8d31 ("bpf: fix broken BPF selftest build") the inclusion of arch-specific header files changed. Including the asm/bpf_perf_event.h on s390, correctly includes the s390 specific header file. This header file tries then to include the s390 asm/ptrace.h and the build fails with: cc

Re: [PATCH v2 0/5] Support for generalized use of make C={1,2} via a wrapper program

2017-12-18 Thread Knut Omang
On Sun, 2017-12-17 at 22:00 -0800, Joe Perches wrote: > On Sun, 2017-12-17 at 22:00 -0700, Jason Gunthorpe wrote: > > On Sun, Dec 17, 2017 at 03:14:10AM +0100, Knut Omang wrote: > > > > > > I like the ability to add more checkers and keep then in the main > > > > upstream tree. But adding

Re: [PATCH net] sctp: add SCTP_CID_RECONF conversion in sctp_cname

2017-12-18 Thread Marcelo Ricardo Leitner
On Mon, Dec 18, 2017 at 02:13:17PM +0800, Xin Long wrote: > Whenever a new type of chunk is added, the corresp conversion in > sctp_cname should be added. Otherwise, in some places, pr_debug > will print it as "unknown chunk". > > Fixes: cc16f00f6529 ("sctp: add support for generating stream

Re: [Intel-wired-lan] [bpf-next V1-RFC PATCH 03/14] i40e: setup xdp_rxq_info

2017-12-18 Thread Jesper Dangaard Brouer
On Mon, 18 Dec 2017 11:52:08 +0100 Björn Töpel wrote: > > + /* Flow director side channel does not invoke XDP/bpf */ > > + if (rx_ring->vsi->type == I40E_VSI_FDIR) > > + xdp_rxq_info_type(_ring->xdp_rxq, RXQ_TYPE_SINK); > > For me, it doesn't

Re: [PATCH v3 07/33] nds32: MMU initialization

2017-12-18 Thread Guo Ren
On Mon, Dec 18, 2017 at 07:21:30PM +0800, Greentime Hu wrote: > Hi, Guo Ren: > > 2017-12-18 17:08 GMT+08:00 Guo Ren : > > Hi Greentime, > > > > On Fri, Dec 08, 2017 at 05:11:50PM +0800, Greentime Hu wrote: > > [...] > >> > >> diff --git a/arch/nds32/mm/highmem.c

Re: [trivial PATCH] treewide: Align function definition open/close braces

2017-12-18 Thread Andy Shevchenko
On Mon, Dec 18, 2017 at 2:28 AM, Joe Perches wrote: > Some functions definitions have either the initial open brace and/or > the closing brace outside of column 1. > > Move those braces to column 1. > > This allows various function analyzers like gnu complexity to work >

Re: [PATCH net-next] udp: handle gro_receive only when necessary

2017-12-18 Thread zhangliping
Hi, At 2017-12-18 18:26:28, "Paolo Abeni" wrote: >Hi, > >On Mon, 2017-12-18 at 12:11 +0800, zhangliping wrote: >> From: zhangliping >> >> Under our udp pressure performance test, after gro is disabled, rx rate >> will be improved from ~2500kpps to

Re: BUG: 4.14.6 unable to handle kernel NULL pointer dereference at xfrm_output_resume

2017-12-18 Thread Steffen Klassert
On Mon, Dec 18, 2017 at 01:50:10PM +0200, Darius Ski wrote: > Hi, > > running 4.14.6 with 3 IPSec tunnels via Racoon/setkey and today woke up to > this: > > [Mon Dec 18 07:26:15 2017] [ cut here ] > [Mon Dec 18 07:26:15 2017] WARNING: CPU: 0 PID: 10555 at >

Re: [Intel-wired-lan] v4.15-rc2 on thinkpad x60: ethernet stopped working

2017-12-18 Thread Pavel Machek
On Mon 2017-12-18 13:24:40, Neftin, Sasha wrote: > On 12/18/2017 12:26, Pavel Machek wrote: > >Hi! > > > >In v4.15-rc2+, network manager can not see my ethernet card, and > >manual attempts to ifconfig it up did not really help, either. > > > >Card is: > > > >02:00.0

BUG: 4.14.6 unable to handle kernel NULL pointer dereference at xfrm_output_resume

2017-12-18 Thread Darius Ski
Hi, running 4.14.6 with 3 IPSec tunnels via Racoon/setkey and today woke up to this: [Mon Dec 18 07:26:15 2017] [ cut here ] [Mon Dec 18 07:26:15 2017] WARNING: CPU: 0 PID: 10555 at ./include/net/dst.h:256 xfrm_resolve_and_create_bundle+0x97e/0x9b0 [Mon Dec 18 07:26:15

Re: [PATCH v4 13/36] nds32: Device specific operations

2017-12-18 Thread Greentime Hu
2017-12-18 19:26 GMT+08:00 Arnd Bergmann : > On Mon, Dec 18, 2017 at 7:46 AM, Greentime Hu wrote: > >> +#define __ASM_NDS32_IO_H >> + >> +extern void iounmap(void __iomem *addr); > > The prototype here should probably include 'volatile' to avoid warnings in an >

Re: [PATCH v4 13/36] nds32: Device specific operations

2017-12-18 Thread Arnd Bergmann
On Mon, Dec 18, 2017 at 7:46 AM, Greentime Hu wrote: > +#define __ASM_NDS32_IO_H > + > +extern void iounmap(void __iomem *addr); The prototype here should probably include 'volatile' to avoid warnings in an allmodconfig build. Arnd

Re: [PATCH v3 07/33] nds32: MMU initialization

2017-12-18 Thread Greentime Hu
Hi, Guo Ren: 2017-12-18 17:08 GMT+08:00 Guo Ren : > Hi Greentime, > > On Fri, Dec 08, 2017 at 05:11:50PM +0800, Greentime Hu wrote: > [...] >> >> diff --git a/arch/nds32/mm/highmem.c b/arch/nds32/mm/highmem.c > [...] >> +void *kmap(struct page *page) >> +{ >> + unsigned

Re: [PATCH v4 16/36] nds32: System calls handling

2017-12-18 Thread Arnd Bergmann
On Mon, Dec 18, 2017 at 7:46 AM, Greentime Hu wrote: > new file mode 100644 > index 000..90da745 > --- /dev/null > +++ b/arch/nds32/include/uapi/asm/unistd.h > @@ -0,0 +1,12 @@ > +// SPDX-License-Identifier: GPL-2.0 > +// Copyright (C) 2005-2017 Andes Technology

Re: [PATCH v4 25/36] nds32: Miscellaneous header files

2017-12-18 Thread Arnd Bergmann
On Mon, Dec 18, 2017 at 7:46 AM, Greentime Hu wrote: > From: Greentime Hu > > This patch introduces some miscellaneous header files. > +static inline void __delay(unsigned long loops) > +{ > + __asm__ __volatile__(".align 2\n" > +

[PATCH v3 net-next 4/6] net: Add TLS offload netdev ops

2017-12-18 Thread Ilya Lesokhin
Add new netdev ops to add and delete tls context Signed-off-by: Boris Pismenny Signed-off-by: Ilya Lesokhin Signed-off-by: Aviad Yehezkel --- include/linux/netdevice.h | 23 +++ 1 file changed, 23 insertions(+)

[PATCH v3 net-next 6/6] tls: Add generic NIC offload infrastructure.

2017-12-18 Thread Ilya Lesokhin
This patch adds a generic infrastructure to offload TLS crypto to a network devices. It enables the kernel TLS socket to skip encryption and authentication operations on the transmit side of the data path. Leaving those computationally expensive operations to the NIC. The NIC offload

[PATCH v3 net-next 3/6] net: Add SW fallback infrastructure for offloaded sockets

2017-12-18 Thread Ilya Lesokhin
Offloaded sockets rely on the netdev to transform the transmitted packets before sending them over the network. When a packet from an offloaded socket is looped back or rerouted to a different device we need to detect it and do the transformation in software Signed-off-by: Ilya Lesokhin

[PATCH v3 net-next 5/6] net: Add TLS TX offload features

2017-12-18 Thread Ilya Lesokhin
This patch adds a netdev feature to configure TLS TX offloads. Signed-off-by: Boris Pismenny Signed-off-by: Ilya Lesokhin Signed-off-by: Aviad Yehezkel --- include/linux/netdev_features.h | 2 ++ net/core/ethtool.c |

[PATCH v3 net-next 1/6] tcp: Add clean acked data hook

2017-12-18 Thread Ilya Lesokhin
Called when a TCP segment is acknowledged. Could be used by application protocols who hold additional metadata associated with the stream data This is required by TLS device offload to release metadata associated with acknowledged TLS records. Signed-off-by: Boris Pismenny

[PATCH v3 net-next 2/6] net: Rename and export copy_skb_header

2017-12-18 Thread Ilya Lesokhin
copy_skb_header is renamed to skb_copy_header and exported. Exposing this function give more flexibility in copying SKBs. skb_copy and skb_copy_expand do not give enough control over which parts are copied. Signed-off-by: Ilya Lesokhin Signed-off-by: Boris Pismenny

<    1   2   3   4   >