Re: RCU callback crashes

On Wed, Dec 20, 2017 at 4:50 PM, Jakub Kicinski wrote: > On Wed, 20 Dec 2017 16:41:14 -0800, Jakub Kicinski wrote: >> Just as I hit send... :) but this looks unrelated, "Comm: sshd" - >> so probably from the management interface. >> >> [ 154.604041] >>

Re: RCU callback crashes

On Wed, Dec 20, 2017 at 4:37 PM, Jakub Kicinski wrote: > On Wed, 20 Dec 2017 16:03:49 -0800, Cong Wang wrote: >> On Wed, Dec 20, 2017 at 10:31 AM, Cong Wang wrote: >> > On Wed, Dec 20, 2017 at 10:17 AM, Cong Wang >> > wrote:

[Patch net] net_sched: fix a missing rcu barrier in mini_qdisc_pair_swap()

The rcu_barrier_bh() in mini_qdisc_pair_swap() is to wait for flying RCU callback installed by a previous mini_qdisc_pair_swap(), however we miss it on the tp_head==NULL path, which leads to that the RCU callback still uses miniq_old->rcu after it is freed together with qdisc in qdisc_graft(). So

Re: [PATCH v3 next-queue 00/10] ixgbe: Add ipsec offload

On 2017/12/21 14:39, Yanjun Zhu wrote: On 2017/12/20 7:59, Shannon Nelson wrote: This is an implementation of the ipsec hardware offload feature for the ixgbe driver and Intel's 10Gbe series NICs: x540, x550, 82599. Hi, Nelson I notice that the ipsec feature is based on x540, x550, 82599.

Re: [Intel-wired-lan] v4.15-rc2 on thinkpad x60: ethernet stopped working

On 20/12/2017 18:01, Pavel Machek wrote: On Wed 2017-12-20 16:54:21, Pavel Machek wrote: Hi! Before ask for reverting 19110cfbb..., please, check if follow patch of Benjamin work for you http://patchwork.ozlabs.org/patch/846825/ Pavel, before ask for revert - let's check Benjamin's patch

[PATCH V4 net-next 00/17] add some features and fix some bugs for HNS3 driver

This patchset adds some new feature support and fixes some bugs: [Patch 1/17 - 5/17] add the support to modify/query the tqp number through ethtool -L/l command, and also fix some related bugs for change tqp number. [Patch 6/17 - 9-17] add support vlan tag offload on tx& direction for pf, and fix

[PATCH V4 net-next 08/17] net: hns3: add ethtool related offload command

This patch adds offload command related to "ethtool -K". Signed-off-by: Lipeng Signed-off-by: Jian Shen --- drivers/net/ethernet/hisilicon/hns3/hnae3.h | 3 +++ drivers/net/ethernet/hisilicon/hns3/hns3_enet.c | 16

[PATCH V4 net-next 01/17] net: hns3: add support to query tqps number

This patch adds the support to query tqps number for PF driver by using ehtool -l command. Signed-off-by: Lipeng Signed-off-by: Mingguang Qu --- drivers/net/ethernet/hisilicon/hns3/hnae3.h | 2 ++

[PATCH V4 net-next 13/17] net: hns3: add support to update flow control settings after autoneg

When auto-negotiation is enabled, the MAC flow control settings is based on the flow control negotiation result. And it should be configured after a valid link has been established. This patch adds support to update flow control settings after auto-negotiation has completed. Signed-off-by: Lipeng

[PATCH V4 net-next 11/17] net: hns3: fix for getting auto-negotiation state in hclge_get_autoneg

From: Fuyun Liang When phy exists, we use the value of phydev.autoneg to represent the auto-negotiation state of hardware. Otherwise, we use the value of mac.autoneg to represent it. This patch fixes for getting a error value of auto-negotiation state in

[PATCH V4 net-next 02/17] net: hns3: add support to modify tqps number

This patch adds the support to change tqps number for PF driver by using ehtool -L command. Signed-off-by: Lipeng Signed-off-by: Mingguang Qu --- drivers/net/ethernet/hisilicon/hns3/hnae3.h| 3 +

[PATCH V4 net-next 17/17] net: hns3: change TM sched mode to TC-based mode when SRIOV enabled

TC-based sched mode supports SRIOV enabled and SRIOV disabled. This patch change the TM sched mode to TC-based mode in initialization process. Fixes: cc9bb43ab394 ("net: hns3: Add tc-based TM support for sriov enabled port") Signed-off-by: Lipeng ---

[PATCH V4 net-next 03/17] net: hns3: change the returned tqp number by ethtool -x

This patch modifies the return data of get_rxnfc, it will return the current handle's rss_size but not the total tqp number. because the tc_size has been change to the log2 of roundup power of two of rss_size. Signed-off-by: Lipeng Signed-off-by: Mingguang Qu

[PATCH V4 net-next 05/17] net: hns3: get rss_size_max from configuration but not hardcode

Add configuration for rss_size_max in hdev but not hardcode it. Signed-off-by: Lipeng Signed-off-by: Mingguang Qu --- drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_cmd.h | 2 ++ drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c | 6 +-

[PATCH V4 net-next 09/17] net: hns3: add handling vlan tag offload in bd

This patch deals with the vlan tag information between sk_buff and rx/tx bd. Signed-off-by: Lipeng Signed-off-by: Jian Shen --- drivers/net/ethernet/hisilicon/hns3/hns3_enet.c | 83 +++-- 1 file changed, 78 insertions(+), 5

[PATCH V4 net-next 07/17] net: hns3: add vlan offload config command

This patch adds vlan offload config commands, initializes the rules of tx/rx vlan tag handle for hw. Signed-off-by: Lipeng Signed-off-by: Jian Shen --- .../net/ethernet/hisilicon/hns3/hns3pf/hclge_cmd.h | 45 ++

[PATCH V4 net-next 14/17] net: hns3: add Asym Pause support to phy default features

From: Fuyun Liang commit c4fb2cdf575d ("net: hns3: fix a bug for phy supported feature initialization") adds default supported features for phy, but our hardware also supports Asym Pause. This patch adds Asym Pause support to phy default features to prevent Asym Pause can

[PATCH V4 net-next 15/17] net: hns3: add support for querying advertised pause frame by ethtool ethx

This patch adds support for querying advertised pause frame by using ethtool command(ethtool ethx). Fixes: 496d03e960ae ("net: hns3: Add Ethtool support to HNS3 driver") Signed-off-by: Lipeng Signed-off-by: Fuyun Liang ---

[PATCH V4 net-next 06/17] net: hns3: add a mask initialization for mac_vlan table

This patch sets vlan masked, in order to avoid the received packets being filtered. Signed-off-by: Lipeng Signed-off-by: Jian Shen --- .../net/ethernet/hisilicon/hns3/hns3pf/hclge_cmd.h | 10 ++ .../ethernet/hisilicon/hns3/hns3pf/hclge_main.c

[PATCH V4 net-next 12/17] net: hns3: add support for set_pauseparam

This patch adds set_pauseparam support for ethtool cmd. Signed-off-by: Lipeng Signed-off-by: Fuyun Liang --- drivers/net/ethernet/hisilicon/hns3/hns3_ethtool.c | 13 .../ethernet/hisilicon/hns3/hns3pf/hclge_main.c| 83

Re: [PATCH V3 net-next 00/17] add some features and fix some bugs for HNS3 driver

On 2017/12/21 12:04, David Miller wrote: From: "lipeng (Y)" Date: Thu, 21 Dec 2017 09:30:01 +0800 On 2017/12/21 3:28, David Miller wrote: From: Lipeng Date: Wed, 20 Dec 2017 16:43:02 +0800 This patchset adds some new feature support and fixes

Re: [Intel-wired-lan] [PATCH] e1000e: Fix e1000_check_for_copper_link_ich8lan return value.

On 11/12/2017 9:26, Benjamin Poirier wrote: e1000e_check_for_copper_link() and e1000_check_for_copper_link_ich8lan() are the two functions that may be assigned to mac.ops.check_for_link when phy.media_type == e1000_media_type_copper. Commit 19110cfbb34d ("e1000e: Separate signaling for link

[PATCH V4 net-next 10/17] net: hns3: cleanup mac auto-negotiation state query

From: Fuyun Liang When checking whether auto-negotiation is on, driver only needs to check the value of mac.autoneg(SW) directly, and does not need to query it from hardware. Because this value is always synchronized with the auto-negotiation state of hardware. This

[PATCH V4 net-next 04/17] net: hns3: free the ring_data structrue when change tqps

This patch fixes a memory leak problems in change tqps process, the function hns3_uninit_all_ring and hns3_init_all_ring may be called many times. Signed-off-by: Lipeng Signed-off-by: Mingguang Qu --- drivers/net/ethernet/hisilicon/hns3/hns3_enet.c

[PATCH V4 net-next 16/17] net: hns3: Increase the default depth of bucket for TM shaper

Burstiness of a flow is determined by the depth of a bucket, When the upper rate of shaper is large, the current depth of a bucket is not enough. The default upper rate of shaper is 100G, so increase the depth of a bucket according to UM. Signed-off-by: Lipeng

[PATCH net] l2tp: fix missing print session offset info

Fixes: 309795f4bec ("l2tp: Add netlink control API for L2TP") Reported-by: Jianlin Shi Signed-off-by: Hangbin Liu --- net/l2tp/l2tp_netlink.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/net/l2tp/l2tp_netlink.c b/net/l2tp/l2tp_netlink.c index

Re: [PATCH v3 next-queue 00/10] ixgbe: Add ipsec offload

On 2017/12/20 7:59, Shannon Nelson wrote: This is an implementation of the ipsec hardware offload feature for the ixgbe driver and Intel's 10Gbe series NICs: x540, x550, 82599. Hi, Nelson I notice that the ipsec feature is based on x540, x550, 82599.  But this ixgbe driver will also work

Re: [PATCH RFC v2 0/5] Support asynchronous crypto for IPsec GSO.

On Fri, Dec 15, 2017 at 10:13:03AM +0100, Steffen Klassert wrote: > This patchset implements asynchronous crypto handling > in the layer 2 TX path. With this we can allow IPsec > ESP GSO for software crypto. This also merges the IPsec > GSO and non-GSO paths to both use validate_xmit_xfrm(). > >

Re: [pull request][for-next 00/11] Mellanox, mlx5 E-Switch updates 2017-12-19

On Wed, 2017-12-20 at 12:56 -0500, David Miller wrote: > From: Saeed Mahameed > Date: Tue, 19 Dec 2017 12:33:29 -0800 > > > This patchset is based on rc4 and I see that net-next is still on > > rc3, i hope > > this is not a problem. > > If it doesn't pull cleanly into

Re: [B.A.T.M.A.N.] [PATCH 00/19] pull request for net-next: batman-adv 2017-12-20

On Mittwoch, 20. Dezember 2017 14:39:46 CET David Miller wrote: [...] > Pulled, but there was a minor docbook annotation conflict I had to > address. > > This pull added () to the function names in the docbook comments, > but this overlapped with the fix of a variable name in the docbook > info

[PATCH net-next] net: dwc-xlgmac: Get rid of custom hex_dump_to_buffer()

Get rid of custom hex_dump_to_buffer(). The output is slightly changed, i.e. each byte followed by white space. Note, we don't use print_hex_dump() here since the original code uses nedev_dbg(). Signed-off-by: Andy Shevchenko Signed-off-by: Jie Deng

Re: [RFC PATCH] virtio_net: Extend virtio to use VF datapath when available

On Wed, 20 Dec 2017 18:16:30 -0800, Siwei Liu wrote: > > The plan is to remove the delay and do the naming in the kernel. > > This was suggested by Lennart since udev is only doing naming policy > > because kernel names were not repeatable. > > > > This makes the VF show up as "ethN_vf" on Hyper-V

Re: pull-request: bpf 2017-12-21

From: Daniel Borkmann Date: Thu, 21 Dec 2017 03:57:47 +0100 > The following pull-request contains BPF updates for your *net* tree. ... > Please consider pulling these changes from: > > git://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf.git Pulled, thanks Daniel.

Re: [PATCH net-next v4 0/6] net: tcp: sctp: dccp: Replace jprobe usage with trace events

From: Masami Hiramatsu Date: Thu, 21 Dec 2017 11:36:57 +0900 > Could you share your .config file? You never need to ask me this question. All of my test builds are with "allmodconfig".

Re: [PATCH V3 net-next 00/17] add some features and fix some bugs for HNS3 driver

From: "lipeng (Y)" Date: Thu, 21 Dec 2017 09:30:01 +0800 > > > On 2017/12/21 3:28, David Miller wrote: >> From: Lipeng >> Date: Wed, 20 Dec 2017 16:43:02 +0800 >> >>> This patchset adds some new feature support and fixes some bugs: >>> [Patch 1/17 -

Re: [PATCH v3 next-queue 05/10] ixgbe: add ipsec offload add and remove SA

On 12/20/2017 6:21 PM, Marcelo Ricardo Leitner wrote: On Wed, Dec 20, 2017 at 05:39:13PM -0800, Shannon Nelson wrote: On 12/20/2017 5:17 PM, Marcelo Ricardo Leitner wrote: Hi, On Tue, Dec 19, 2017 at 03:59:57PM -0800, Shannon Nelson wrote: +} + +static const struct xfrmdev_ops

Re: [PATCH bpf-next] tools/bpf: adjust rlimit RLIMIT_MEMLOCK for test_dev_cgroup

On Wed, Dec 20, 2017 at 10:37:08AM -0800, Yonghong Song wrote: > The default rlimit RLIMIT_MEMLOCK is 64KB. In certain cases, > e.g. in a test machine mimicking our production system, this test may > fail due to unable to charge the required memory for prog load: > > $ ./test_dev_cgroup >

Re: [PATCH net-next v4 0/6] net: tcp: sctp: dccp: Replace jprobe usage with trace events

On Thu, 21 Dec 2017 11:36:57 +0900 Masami Hiramatsu wrote: > On Wed, 20 Dec 2017 14:24:24 -0500 (EST) > David Miller wrote: > > > From: David Miller > > Date: Wed, 20 Dec 2017 14:20:40 -0500 (EST) > > > > > From: Masami

pull-request: bpf 2017-12-21

Hi David, The following pull-request contains BPF updates for your *net* tree. The main changes are: 1) Fix multiple security issues in the BPF verifier mostly related to the value and min/max bounds tracking rework in 4.14. Issues range from incorrect bounds calculation in some BPF_RSH

Re: [PATCH net] ipv6: Honor specified parameters in fibmatch lookup

On 12/20/17 3:28 AM, Ido Schimmel wrote: > @@ -4327,6 +4321,15 @@ static int inet6_rtm_getroute(struct sk_buff *in_skb, > struct nlmsghdr *nlh, > goto errout; > } > > + if (fibmatch && rt->dst.from) { > + struct rt6_info *ort = container_of(rt->dst.from, > +

Re: [PATCH V3 net-next 00/17] add some features and fix some bugs for HNS3 driver

On 2017/12/21 10:27, lipeng (Y) wrote: > > > On 2017/12/21 3:28, David Miller wrote: >> From: Lipeng >> Date: Wed, 20 Dec 2017 16:43:02 +0800 >> >>> This patchset adds some new feature support and fixes some bugs: >>> [Patch 1/17 - 5/17] add the support to modify/query the

Re: [PATCH net-next v4 0/6] net: tcp: sctp: dccp: Replace jprobe usage with trace events

On Wed, 20 Dec 2017 14:24:24 -0500 (EST) David Miller wrote: > From: David Miller > Date: Wed, 20 Dec 2017 14:20:40 -0500 (EST) > > > From: Masami Hiramatsu > > Date: Wed, 20 Dec 2017 13:14:11 +0900 > > > >> This series is v4 of

Re: [PATCH V3 net-next 00/17] add some features and fix some bugs for HNS3 driver

On 2017/12/21 3:28, David Miller wrote: From: Lipeng Date: Wed, 20 Dec 2017 16:43:02 +0800 This patchset adds some new feature support and fixes some bugs: [Patch 1/17 - 5/17] add the support to modify/query the tqp number through ethtool -L/l command, and also fix

Re: [PATCH v3 next-queue 05/10] ixgbe: add ipsec offload add and remove SA

On Wed, Dec 20, 2017 at 05:39:13PM -0800, Shannon Nelson wrote: > On 12/20/2017 5:17 PM, Marcelo Ricardo Leitner wrote: > > Hi, > > > > On Tue, Dec 19, 2017 at 03:59:57PM -0800, Shannon Nelson wrote: > > > +} > > > + > > > +static const struct xfrmdev_ops ixgbe_xfrmdev_ops = { > > > +

Re: [PATCH bpf 0/9] bpf: verifier security fixes

On 12/19/2017 05:11 AM, Alexei Starovoitov wrote: > This patch set addresses a set of security vulnerabilities > in bpf verifier logic discovered by Jann Horn. > All of the patches are candidates for 4.14 stable. > > Alexei Starovoitov (1): > bpf: fix integer overflows > > Edward Cree (1): >

Re: [PATCH bpf] bpf: do not allow root to mangle valid pointers

On 12/19/2017 05:15 AM, Alexei Starovoitov wrote: > Do not allow root to convert valid pointers into unknown scalars. > In particular disallow: > ptr &= reg > ptr <<= reg > ptr += ptr > and explicitly allow: > ptr -= ptr > since pkt_end - pkt == length > > 1. > This minimizes amount of

Re: [RFC PATCH] virtio_net: Extend virtio to use VF datapath when available

On Tue, Dec 19, 2017 at 10:41 AM, Stephen Hemminger wrote: > On Tue, 19 Dec 2017 13:21:17 -0500 (EST) > David Miller wrote: > >> From: Stephen Hemminger >> Date: Tue, 19 Dec 2017 09:55:48 -0800 >> >> > could be 10ms,

Re: [PATCH bpf-next 0/2] bpftool improvements for xlated dump

On Wed, Dec 20, 2017 at 01:42:55PM +0100, Daniel Borkmann wrote: > This work adds correlation of maps and calls into the bpftool > xlated dump in order to help debugging and introspection of > loaded BPF progs. First patch makes kallsyms work on subprogs > with bpf calls, and second implements the

Re: [PATCH net-next] virtio_net: Add ethtool stats

On 2017/12/20 17:13, Jason Wang wrote: > On 2017年12月20日 12:40, Toshiaki Makita wrote: >> The main purpose of this patch is adding a way of checking per-queue >> stats. >> It's useful to debug performance problems on multiqueue environment. >> >> $ ethtool -S ens10 >> NIC statistics: >>  

tracepoint_probe_register and bpf. Was: [PATCH tip 0/3] Improvements of scheduler related Tracepoints

On Mon, Dec 18, 2017 at 10:11:57AM +0100, Peter Zijlstra wrote: > On Fri, Dec 15, 2017 at 09:09:51AM -0800, Alexei Starovoitov wrote: > > > yeah. Currently bpf progs are called at the end of > > perf_trace_##call() > > { > > .. regular tracepoint copy craft > > perf_trace_run_bpf_submit(

Re: [PATCH v3 next-queue 05/10] ixgbe: add ipsec offload add and remove SA

On 12/20/2017 5:17 PM, Marcelo Ricardo Leitner wrote: Hi, On Tue, Dec 19, 2017 at 03:59:57PM -0800, Shannon Nelson wrote: +} + +static const struct xfrmdev_ops ixgbe_xfrmdev_ops = { + .xdo_dev_state_add = ixgbe_ipsec_add_sa, + .xdo_dev_state_delete = ixgbe_ipsec_del_sa, +}; +

RE: [patch iproute2] tc: add -bs option for batch mode

> -Original Message- > From: Stephen Hemminger [mailto:step...@networkplumber.org] > Sent: Wednesday, December 20, 2017 11:18 PM > To: Chris Mi > Cc: netdev@vger.kernel.org; gerlitz...@gmail.com > Subject: Re: [patch iproute2] tc: add -bs option for batch mode > > On

Re: [PATCH V3 net-next 00/17] add some features and fix some bugs for HNS3 driver

On 2017/12/21 3:28, David Miller wrote: From: Lipeng Date: Wed, 20 Dec 2017 16:43:02 +0800 This patchset adds some new feature support and fixes some bugs: [Patch 1/17 - 5/17] add the support to modify/query the tqp number through ethtool -L/l command, and also fix

Re: [PATCH v3 next-queue 05/10] ixgbe: add ipsec offload add and remove SA

Hi, On Tue, Dec 19, 2017 at 03:59:57PM -0800, Shannon Nelson wrote: > +} > + > +static const struct xfrmdev_ops ixgbe_xfrmdev_ops = { > + .xdo_dev_state_add = ixgbe_ipsec_add_sa, > + .xdo_dev_state_delete = ixgbe_ipsec_del_sa, > +}; > + This struct is only declared if XFRM_OFFLOAD is

Re: RCU callback crashes

On Wed, 20 Dec 2017 16:41:14 -0800, Jakub Kicinski wrote: > Just as I hit send... :) but this looks unrelated, "Comm: sshd" - > so probably from the management interface. > > [ 154.604041] > == > [ 154.612245] BUG: KASAN:

Re: [-next PATCH 4/4] treewide: Use DEVICE_ATTR_WO

On Tue, 2017-12-19 at 10:15 -0800, Joe Perches wrote: > Convert DEVICE_ATTR uses to DEVICE_ATTR_WO where possible. > > Done with perl script: > > $ git grep -w --name-only DEVICE_ATTR | \ >   xargs perl -i -e 'local $/; while (<>) { >

[PATCH] net: phy: micrel: ksz9031: reconfigure autoneg after phy autoneg workaround

Under some circumstances driver will perform PHY reset in ksz9031_read_status() to fix autoneg failure case (idle error count = 0xFF). When this happens ksz9031 will not detect link status change any more when connecting to Netgear 1G switch (link can be recovered sometimes by restarting netdevice

Re: RCU callback crashes

On Wed, 20 Dec 2017 16:37:10 -0800, Jakub Kicinski wrote: > On Wed, 20 Dec 2017 16:03:49 -0800, Cong Wang wrote: > > On Wed, Dec 20, 2017 at 10:31 AM, Cong Wang > > wrote: > > > On Wed, Dec 20, 2017 at 10:17 AM, Cong Wang > > > wrote: >

Re: RCU callback crashes

On Wed, 20 Dec 2017 16:03:49 -0800, Cong Wang wrote: > On Wed, Dec 20, 2017 at 10:31 AM, Cong Wang wrote: > > On Wed, Dec 20, 2017 at 10:17 AM, Cong Wang > > wrote: > >> > >> I guess it is q->miniqp which is freed in qdisc_graft() without

Re: [RFC PATCH] virtio_net: Extend virtio to use VF datapath when available

On Thu, 21 Dec 2017 02:15:31 +0200, Michael S. Tsirkin wrote: > On Wed, Dec 20, 2017 at 02:33:34PM -0800, Jakub Kicinski wrote: > > On Mon, 18 Dec 2017 16:40:36 -0800, Sridhar Samudrala wrote: > > > +static int virtio_netdev_event(struct notifier_block *this, > > > +

Re: [RFC PATCH] virtio_net: Extend virtio to use VF datapath when available

On Wed, Dec 20, 2017 at 02:33:34PM -0800, Jakub Kicinski wrote: > On Mon, 18 Dec 2017 16:40:36 -0800, Sridhar Samudrala wrote: > > +static int virtio_netdev_event(struct notifier_block *this, > > + unsigned long event, void *ptr) > > +{ > > + struct net_device *event_dev

Re: [RFC PATCH] virtio_net: Extend virtio to use VF datapath when available

On Mon, Dec 18, 2017 at 04:40:36PM -0800, Sridhar Samudrala wrote: > This patch enables virtio to switch over to a VF datapath when a VF netdev > is present with the same MAC address. I prefer saying "a passthrough device" here. Does not have to be a VF at all. > It allows live migration of a

Re: [patch iproute2] tc: add -bs option for batch mode

On 12/20/17 8:17 AM, Stephen Hemminger wrote: > On Wed, 20 Dec 2017 09:23:34 + > Chris Mi wrote: > >>> Your real performance win is just not asking for ACK for every rule. >> No. Even if batch_size > 1, we ack every rule. The real performance win is >> to send multiple

Re: [PATCH net-next v4 0/6] net: tcp: sctp: dccp: Replace jprobe usage with trace events

On Wed, 20 Dec 2017 14:24:24 -0500 (EST) David Miller wrote: > From: David Miller > Date: Wed, 20 Dec 2017 14:20:40 -0500 (EST) > > > From: Masami Hiramatsu > > Date: Wed, 20 Dec 2017 13:14:11 +0900 > > > >> This series is v4 of

Re: RCU callback crashes

On Wed, 20 Dec 2017 16:03:49 -0800, Cong Wang wrote: > On Wed, Dec 20, 2017 at 10:31 AM, Cong Wang wrote: > > On Wed, Dec 20, 2017 at 10:17 AM, Cong Wang > > wrote: > >> > >> I guess it is q->miniqp which is freed in qdisc_graft() without

Re: RCU callback crashes

On Wed, Dec 20, 2017 at 10:31 AM, Cong Wang wrote: > On Wed, Dec 20, 2017 at 10:17 AM, Cong Wang wrote: >> >> I guess it is q->miniqp which is freed in qdisc_graft() without properly >> waiting for rcu readers? > > It is probably so, the

Re: linux-next: build failure after merge of the net-next tree

On Thu, 21 Dec 2017 10:43:04 +1100, Stephen Rothwell wrote: > Hi all, > > After merging the net-next tree, today's linux-next build (x86_64 > allmodconfig) failed like this: > > drivers/net/netdevsim/bpf.c: In function 'nsim_bpf_setup_tc_block_cb': > drivers/net/netdevsim/bpf.c:127:7: error:

linux-next: build failure after merge of the net-next tree

Hi all, After merging the net-next tree, today's linux-next build (x86_64 allmodconfig) failed like this: drivers/net/netdevsim/bpf.c: In function 'nsim_bpf_setup_tc_block_cb': drivers/net/netdevsim/bpf.c:127:7: error: 'TC_CLSBPF_REPLACE' undeclared (first use in this function) case

Re: [PATCH] net: Revert "net_sched: no need to free qdisc in RCU callback"

On 12/20/2017 01:59 PM, Jakub Kicinski wrote: > On Wed, 20 Dec 2017 12:09:19 -0800, John Fastabend wrote: >> RCU grace period is needed for lockless qdiscs added in the commit >> c5ad119fb6c09 ("net: sched: pfifo_fast use skb_array"). >> >> It is needed now that qdiscs may be lockless otherwise we

Re: [net] Revert "net: core: maybe return -EEXIST in __dev_alloc_name"

On Tue, Dec 19 2017, Michael Ellerman wrote: > Hi Johannes, > >> From: Johannes Berg >> >> This reverts commit d6f295e9def0; some userspace (in the case > > This revert seems to have broken networking on one of my powerpc > machines,

Re: [PATCH] net: Revert "net_sched: no need to free qdisc in RCU callback"

On 12/20/2017 03:23 PM, Cong Wang wrote: > On Wed, Dec 20, 2017 at 3:05 PM, John Fastabend > wrote: >> On 12/20/2017 02:41 PM, Cong Wang wrote: >>> On Wed, Dec 20, 2017 at 12:09 PM, John Fastabend >>> wrote: RCU grace period is needed for

Re: [PATCH] net: Revert "net_sched: no need to free qdisc in RCU callback"

On Wed, Dec 20, 2017 at 3:05 PM, John Fastabend wrote: > On 12/20/2017 02:41 PM, Cong Wang wrote: >> On Wed, Dec 20, 2017 at 12:09 PM, John Fastabend >> wrote: >>> RCU grace period is needed for lockless qdiscs added in the commit >>>

[PATCH net-next] phylink: avoid attaching more than one PHY

Attaching more than one PHY to phylink is bad news, as we store a pointer to the PHY in a single location. Error out if more than one PHY is attempted to be attached. Signed-off-by: Russell King --- drivers/net/phy/phylink.c | 3 +++ 1 file changed, 3 insertions(+)

[PATCH net] phylink: ensure AN is enabled

Ensure that we mark AN as enabled at boot time, rather than leaving it disabled. This is noticable if your SFP module is fiber, and you it supports faster speeds than 1G with 2.5G support in place. Signed-off-by: Russell King --- drivers/net/phy/phylink.c | 1 + 1

[PATCH net] phylink: ensure the PHY interface mode is appropriately set

When setting the ethtool settings, ensure that the validated PHY interface mode is propagated to the current link settings, so that 2500BaseX can be selected. Signed-off-by: Russell King --- drivers/net/phy/phylink.c | 1 + 1 file changed, 1 insertion(+) diff --git

Re: [PATCH v2] net: ibm: emac: support RGMII-[RX|TX]ID phymode

On Wed, 2017-12-20 at 22:07 +0100, Christian Lamparter wrote: > > > will read this and say "Oh the function tests against these weird > > PHY_MODE_* aliases, but the helper function phy_interface_mode_is_rgmii() > > tests against PHY_INTERFACE_MODE_*, what is going on?" > > > > I hate to do this

Re: [PATCH] net: Revert "net_sched: no need to free qdisc in RCU callback"

On 12/20/2017 02:41 PM, Cong Wang wrote: > On Wed, Dec 20, 2017 at 12:09 PM, John Fastabend > wrote: >> RCU grace period is needed for lockless qdiscs added in the commit >> c5ad119fb6c09 ("net: sched: pfifo_fast use skb_array"). >> >> It is needed now that qdiscs may be

linux-next: manual merge of the net-next tree with the net tree

Hi all, Today's linux-next merge of the net-next tree got a conflict in: drivers/net/ethernet/netronome/nfp/bpf/main.c between commit: d3f89b98e391 ("nfp: bpf: keep track of the offloaded program") from the net tree and commit: bd0b2e7fe611 ("net: xdp: make the stack take care of the

[PATCH v5 iproute2 net-next] erspan: add erspan version II support

The patch adds support for configuring the erspan v2, for both ipv4 and ipv6 erspan implementation. Three additional fields are added: 'erspan_ver' for distinguishing v1 or v2, 'erspan_dir' for specifying direction of the mirrored traffic, and 'erspan_hwid' for users to set ERSPAN engine ID

Re: Linux 4.14 - regression: broken tun/tap / bridge network with virtio - bisected

On Wed, Dec 20, 2017 at 10:56 AM, Andreas Hartmann wrote: > On 12/18/2017 at 06:11 PM Andreas Hartmann wrote: >> On 12/17/2017 at 11:33 PM Willem de Bruijn wrote: > [...] >>> I have been able to reproduce the hang by sending a UFO packet >>> between two guests

Re: [PATCH] net: Revert "net_sched: no need to free qdisc in RCU callback"

On Wed, Dec 20, 2017 at 12:09 PM, John Fastabend wrote: > RCU grace period is needed for lockless qdiscs added in the commit > c5ad119fb6c09 ("net: sched: pfifo_fast use skb_array"). > > It is needed now that qdiscs may be lockless otherwise we risk > free'ing a qdisc

Re: RCU callback crashes

On Wed, Dec 20, 2017 at 12:23 PM, John Fastabend wrote: > I'm trying to see how removing that rcu grace period was safe in the > first place. The datapath is using rcu_read critical section to protect > the qdisc but the control path (a) doesn't use rcu grace period and

[PATCH net 0/2] zerocopy fixes

From: Willem de Bruijn The removal of UFO hardware offload support exposed a bug in segmentation of zerocopy skbs. The reference counting mechanism for msg_zerocopy was incorrectly applied to vhost_net zerocopy packets. The other issue observed through analysis. We do not

[PATCH net 1/2] skbuff: orphan frags before zerocopy clone

From: Willem de Bruijn Call skb_zerocopy_clone after skb_orphan_frags, to avoid duplicate calls to skb_uarg(skb)->callback for the same data. skb_zerocopy_clone associates skb_shinfo(skb)->uarg from frag_skb with each segment. This is only safe for uargs that do refcounting,

[PATCH net 2/2] skbuff: skb_copy_ubufs must release uarg even without user frags

From: Willem de Bruijn skb_copy_ubufs creates a private copy of frags[] to release its hold on user frags, then calls uarg->callback to notify the owner. Call uarg->callback even when no frags exist. This edge case can happen when zerocopy_sg_from_iter finds enough room in

[PATCH] hv_netvsc: update VF after name has changed.

Since commit 6123c66854c1 ("netvsc: delay setup of VF device") the automatic bring up of the VF is delayed to allow userspace (udev) a chance to rename the device. This delay is problematic because it delays boot and may not be long enough for some cases. Instead, use the rename can be used to

Re: [RFC PATCH] virtio_net: Extend virtio to use VF datapath when available

On Mon, 18 Dec 2017 16:40:36 -0800, Sridhar Samudrala wrote: > +static int virtio_netdev_event(struct notifier_block *this, > +unsigned long event, void *ptr) > +{ > + struct net_device *event_dev = netdev_notifier_info_to_dev(ptr); > + > + /* Skip our own

Re: RCU callback crashes

On Wed, Dec 20, 2017 at 12:14 PM, John Fastabend wrote: > > Hi, > > Just sent a patch to complete qdisc_destroy from rcu callback. This > is needed to resolve a race with the lockless qdisc patches. > > But I guess it should fix the miniq issue as well? If you ever

Re: [PATCH v5 3/6] perf: implement pmu perf_kprobe

> On Dec 20, 2017, at 1:25 PM, Peter Zijlstra wrote: > > On Wed, Dec 20, 2017 at 06:10:11PM +, Song Liu wrote: >> I think there is one more thing to change: > > OK, folded that too; it should all be at: > >

[PATCH v3 2/3] net: ibm: emac: replace custom PHY_MODE_* macros

The ibm_emac driver predates the PHY_INTERFACE_MODE_* enums by a few years. And while the driver has been retrofitted to use the PHYLIB, the old definitions have stuck around to this day. This patch replaces all occurences of PHY_MODE_* with the respective equivalent PHY_INTERFACE_MODE_* enum.

[PATCH v3 3/3] net: ibm: emac: support RGMII-[RX|TX]ID phymode

The RGMII spec allows compliance for devices that implement an internal delay on TXC and/or RXC inside the transmitter. This patch adds the necessary RGMII_[RX|TX]ID mode code to handle such PHYs with the emac driver. Signed-off-by: Christian Lamparter --- v3: - replace

[PATCH v3 1/3] net: ibm: emac: replace custom rgmii_mode_name with phy_modes

phy_modes() in the common phy.h already defines the same phy mode names in lower case. The deleted rgmii_mode_name() is used only in one place and for a "notice-level" printk. Hence, it will not be missed. Signed-off-by: Christian Lamparter ---

Re: [PATCH] net: Revert "net_sched: no need to free qdisc in RCU callback"

On Wed, 20 Dec 2017 12:09:19 -0800, John Fastabend wrote: > RCU grace period is needed for lockless qdiscs added in the commit > c5ad119fb6c09 ("net: sched: pfifo_fast use skb_array"). > > It is needed now that qdiscs may be lockless otherwise we risk > free'ing a qdisc that is still in use from

Re: [RFC PATCH net-next] tools/bpftool: use version from the kernel source tree

On Wed, 20 Dec 2017 20:53:41 +, Roman Gushchin wrote: > On Wed, Dec 20, 2017 at 12:29:21PM -0800, Jakub Kicinski wrote: > > On Wed, 20 Dec 2017 20:19:43 +, Roman Gushchin wrote: > > > Bpftool determines it's own version based on the kernel > > > version, which is picked from the

Re: [patch net-next 00/10] Add support for resource abstraction

On 12/20/17 1:03 PM, Jiri Pirko wrote: >>> Userspace part prototype can be found at >>> https://github.com/arkadis/iproute2/ >>> at resource_dev branch. My devlink command getting no output is because you forgot to update that iproute2 tree with a version that works with the patches that were

Re: [PATCH v5 3/6] perf: implement pmu perf_kprobe

On Wed, Dec 20, 2017 at 06:10:11PM +, Song Liu wrote: > I think there is one more thing to change: OK, folded that too; it should all be at: git://git.kernel.org/pub/scm/linux/kernel/git/peterz/queue.git perf/core Can you verify it all looks/works right?

Re: [PATCH v2] net: ibm: emac: support RGMII-[RX|TX]ID phymode

From: Christian Lamparter Date: Wed, 20 Dec 2017 22:07:43 +0100 > Yeah, I can do that. no problem. > > Question is, should I also replace the rgmii_mode_name() with phy_modes() too? > > The only user of rgmii_mode_name() is this notice printk in rgmii_attach(): >

[PATCH bpf-next 10/11] bpf: Add BPF_SOCK_OPS_STATE_CB

Adds support for calling sock_ops BPF program when there is a TCP state change. Two arguments are used; one for the old state and another for the new state. New op: BPF_SOCK_OPS_STATE_CB. Signed-off-by: Lawrence Brakmo --- include/uapi/linux/bpf.h | 4

[PATCH bpf-next 09/11] bpf: Add BPF_SOCK_OPS_RETRANS_CB

Adds support for calling sock_ops BPF program when there is a retransmission. Two arguments are used; one for the sequence number and other for the number of segments retransmitted. Does not include syn-ack retransmissions. New op: BPF_SOCK_OPS_RETRANS_CB. Signed-off-by: Lawrence Brakmo

[PATCH bpf-next 07/11] bpf: Add support for reading sk_state and more

Add support for reading many more tcp_sock fields state,same as sk->sk_state rtt_min same as sk->rtt_min.s[0].v (current rtt_min) snd_ssthresh rcv_nxt snd_nxt snd_una mss_cache ecn_flags rate_delivered rate_interval_us packets_out retrans_out total_retrans

  1   2   3   4   >