Re: [RFT net-next v3 0/5] dwmac-meson8b: RGMII clock fixes for Meson8b

2017-12-28 Thread Martin Blumenstingl
On Fri, Dec 29, 2017 at 8:48 AM, Martin Blumenstingl wrote: > Hi Emiliano, > > On Fri, Dec 29, 2017 at 2:31 AM, Emiliano Ingrassia > wrote: >> Hi Martin, Hi Dave, >> >> On Thu, Dec 28, 2017 at 11:21:23PM +0100, Martin Blumenstingl

Re: [RFT net-next v3 0/5] dwmac-meson8b: RGMII clock fixes for Meson8b

2017-12-28 Thread Martin Blumenstingl
Hi Emiliano, On Fri, Dec 29, 2017 at 2:31 AM, Emiliano Ingrassia wrote: > Hi Martin, Hi Dave, > > On Thu, Dec 28, 2017 at 11:21:23PM +0100, Martin Blumenstingl wrote: >> Hi Dave, >> >> please do not apply this series until it got a Tested-by from Emiliano. >> >> >> Hi

Re: [PATCH net 3/3] eet: ena: invoke netif_carrier_off() only after netdev registered

2017-12-28 Thread Jakub Kicinski
On Thu, 28 Dec 2017 21:30:20 +, neta...@amazon.com wrote: > From: Netanel Belgazal > > netif_carrier_off() should be called only after register netdev. > Move the function's call after the registration. By "should" you mean in your driver, right? I think calling

Re: [PATCH][next] wcn36xx: remove redundant assignment to msg_body.min_ch_time

2017-12-28 Thread Loic Poulain
Hi Colin, Bjorn, On 26 December 2017 at 21:13, Bjorn Andersson wrote: > On Tue 19 Dec 09:04 PST 2017, Colin King wrote: > >> From: Colin Ian King >> >> msg_body.min_ch_time is being assigned twice; remove the redundant >> first assignment.

Re: [RFC PATCH bpf-next v2 4/4] error-injection: Support fault injection framework

2017-12-28 Thread Masami Hiramatsu
On Thu, 28 Dec 2017 17:11:31 -0800 Alexei Starovoitov wrote: > On 12/27/17 11:51 PM, Masami Hiramatsu wrote: > > > > Then what happen if the user set invalid retval to those functions? > > even if we limit the injectable functions, it can cause a problem, > > > > for example, > > >

[PATCH RESEND 1/3] net: Fix possible race in peernet2id_alloc()

2017-12-28 Thread Kirill Tkhai
peernet2id_alloc() is racy without rtnl_lock() as atomic_read(>count) under net->nsid_lock does not guarantee, peer is alive: rcu_read_lock() peernet2id_alloc().. spin_lock_bh(>nsid_lock) .. atomic_read(>count) == 1 .. ..

[PATCH RESEND 3/3] net: Remove spinlock from get_net_ns_by_id()

2017-12-28 Thread Kirill Tkhai
idr_find() is safe under rcu_read_lock() and maybe_get_net() guarantees that net is alive. Signed-off-by: Kirill Tkhai --- net/core/net_namespace.c |2 -- 1 file changed, 2 deletions(-) diff --git a/net/core/net_namespace.c b/net/core/net_namespace.c index

[PATCH RESEND 2/3] net: Add BUG_ON() to get_net()

2017-12-28 Thread Kirill Tkhai
Since people may mistakenly obtain destroying net from net_namespace_list and from net::netns_ids without checking for its net::counter, let's protect against such situations and insert BUG_ON() to stop move on after this. Panic is better, than memory corruption and undefined behavior.

[PATCH net-next] cxgb4: Check alignment constraint for T6

2017-12-28 Thread Ganesh Goudar
Update the check for setting IPV4 filters and align filter_id to multiple of 2, only for IPv6 filters in case of T6. Signed-off-by: Arjun Vynipadath Signed-off-by: Ganesh Goudar --- drivers/net/ethernet/chelsio/cxgb4/cxgb4_filter.c | 17

Re: [PATCH v6 0/6] Add M_CAN Support for Dra76 platform

2017-12-28 Thread Yang, Wenyou
On 2017/12/22 21:31, Faiz Abbas wrote: This patch series adds support for M_CAN on the TI Dra76 platform. Device tree patches will be sent separately. A bunch of patches were sent before by Franklin Cooper . I have clubbed the series together and rebased to the latest kernel.

Re: [PATCH net-next] virtio_net: implement VIRTIO_CONFIG_S_NEEDS_RESET

2017-12-28 Thread Jason Wang
On 2017年12月29日 03:11, Willem de Bruijn wrote: On Mon, Oct 16, 2017 at 11:44 PM, Michael S. Tsirkin wrote: On Tue, Oct 17, 2017 at 11:05:07AM +0800, Jason Wang wrote: On 2017年10月17日 06:34, Willem de Bruijn wrote: On Mon, Oct 16, 2017 at 12:38 PM, Michael S. Tsirkin

[PATCH net-next v7 6/6] net: dccp: Remove dccpprobe module

2017-12-28 Thread Masami Hiramatsu
Remove DCCP probe module since jprobe has been deprecated. That function is now replaced by dccp/dccp_probe trace-event. You can use it via ftrace or perftools. Signed-off-by: Masami Hiramatsu --- Changes in v5: - Fix a conflict with previous change in Makefile. ---

[PATCH net-next v7 4/6] net: sctp: Remove debug SCTP probe module

2017-12-28 Thread Masami Hiramatsu
Remove SCTP probe module since jprobe has been deprecated. That function is now replaced by sctp/sctp_probe and sctp/sctp_probe_path trace-events. You can use it via ftrace or perftools. Signed-off-by: Masami Hiramatsu --- net/sctp/Kconfig | 12 --- net/sctp/Makefile |

[PATCH net-next v7 5/6] net: dccp: Add DCCP sendmsg trace event

2017-12-28 Thread Masami Hiramatsu
Add DCCP sendmsg trace event (dccp/dccp_probe) for replacing dccpprobe. User can trace this event via ftrace or perftools. Signed-off-by: Masami Hiramatsu --- Changes in v5: - Fix to add local directory to include for trace.h. Thanks Steven! Changes in v7: -

[PATCH net-next v7 3/6] net: sctp: Add SCTP ACK tracking trace event

2017-12-28 Thread Masami Hiramatsu
Add SCTP ACK tracking trace event to trace the changes of SCTP association state in response to incoming packets. It is used for debugging SCTP congestion control algorithms, and will replace sctp_probe module. Note that this event a bit tricky. Since this consists of 2 events (sctp_probe and

[PATCH net-next v7 2/6] net: tcp: Remove TCP probe module

2017-12-28 Thread Masami Hiramatsu
Remove TCP probe module since jprobe has been deprecated. That function is now replaced by tcp/tcp_probe trace-event. You can use it via ftrace or perftools. Signed-off-by: Masami Hiramatsu --- net/Kconfig | 17 --- net/ipv4/Makefile|1

[PATCH net-next v7 1/6] net: tcp: Add trace events for TCP congestion window tracing

2017-12-28 Thread Masami Hiramatsu
This adds an event to trace TCP stat variables with slightly intrusive trace-event. This uses ftrace/perf event log buffer to trace those state, no needs to prepare own ring-buffer, nor custom user apps. User can use ftrace to trace this event as below; # cd /sys/kernel/debug/tracing # echo

[PATCH net-next v7 0/6] net: tcp: sctp: dccp: Replace jprobe usage with trace events

2017-12-28 Thread Masami Hiramatsu
Hi, This series is v7 of the replacement of jprobe usage with trace events. This version fixes net/dccp/trace.h to avoid sparse warning. Since the TP_STORE_ADDR_PORTS macro can be shared with trace/events/tcp.h, it also introduce a new common header file and move the definition of that macro.

[PATCH net-next 2/2] tun: allow to attach ebpf socket filter

2017-12-28 Thread Jason Wang
This patch allows userspace to attach eBPF filter to tun. This will allow to implement VM dataplane filtering in a more efficient way compared to cBPF filter. Signed-off-by: Jason Wang --- drivers/net/tun.c | 26 ++

[PATCH net-next 0/2] tun: allow to attach eBPF filter

2017-12-28 Thread Jason Wang
Hi all: This series tries to implement eBPF socket filter for tun. This could be used for implementing efficient virtio-net receive filter for vhost-net. Thanks Jason Wang (2): tuntap: rename struct tun_steering_prog to struct tun_prog tun: allow to attach ebpf socket filter

[PATCH net-next 1/2] tuntap: rename struct tun_steering_prog to struct tun_prog

2017-12-28 Thread Jason Wang
To be reused by other eBPF program other than queue selection. Signed-off-by: Jason Wang --- drivers/net/tun.c | 32 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/drivers/net/tun.c b/drivers/net/tun.c index

[GIT] Networking

2017-12-28 Thread David Miller
1) IPv6 gre tunnels end up with different default features enabled depending upon whether netlink or ioctls are used to bring them up. Fix from Alexey Kodanev. 2) Fix read past end of user control message in RDS< from Avinash Repaka. 3) Missing RCU barrier in mini qdisc code, from

Re: [RFT net-next v3 0/5] dwmac-meson8b: RGMII clock fixes for Meson8b

2017-12-28 Thread Emiliano Ingrassia
Hi Martin, Hi Dave, On Thu, Dec 28, 2017 at 11:21:23PM +0100, Martin Blumenstingl wrote: > Hi Dave, > > please do not apply this series until it got a Tested-by from Emiliano. > > > Hi Emiliano, > > you reported [0] that you couldn't get dwmac-meson8b to work on your > Odroid-C1. With your

Re: [RFC PATCH bpf-next v2 4/4] error-injection: Support fault injection framework

2017-12-28 Thread Alexei Starovoitov
On 12/27/17 11:51 PM, Masami Hiramatsu wrote: Then what happen if the user set invalid retval to those functions? even if we limit the injectable functions, it can cause a problem, for example, obj = func_return_object(); if (!obj) { handling_error...; } obj->field = x; In this case,

Re: [RFC PATCH bpf-next v2 1/4] tracing/kprobe: bpf: Check error injectable event is on function entry

2017-12-28 Thread Alexei Starovoitov
On 12/28/17 12:20 AM, Masami Hiramatsu wrote: On Wed, 27 Dec 2017 20:32:07 -0800 Alexei Starovoitov wrote: On 12/27/17 8:16 PM, Steven Rostedt wrote: On Wed, 27 Dec 2017 19:45:42 -0800 Alexei Starovoitov wrote: I don't think that's the case. My reading of current

Re: [pull request][for-next V3 00/11] Mellanox, mlx5 E-Switch updates 2017-12-19

2017-12-28 Thread David Miller
From: Saeed Mahameed Date: Fri, 29 Dec 2017 01:23:03 +0200 > == > This series includes updates for mlx5 E-Switch infrastructures, > to be merged into net-next and rdma-next trees. > > Mark's patches provide E-Switch refactoring that generalize the mlx5 >

Re: [PATCH net-next v6 0/6] net: tcp: sctp: dccp: Replace jprobe usage with trace events

2017-12-28 Thread Masami Hiramatsu
On Thu, 28 Dec 2017 12:06:13 -0500 (EST) David Miller wrote: > From: Masami Hiramatsu > Date: Thu, 28 Dec 2017 15:10:00 +0900 > > > Changes from v5: > > [1/6]: Avoid preprocessor directives in tracepoint macro args > > Patch #1 is not the only patch

Re: [ovs-dev] Pravin Shelar

2017-12-28 Thread Pravin Shelar
On Wed, Dec 27, 2017 at 10:33 AM, Joe Perches wrote: > On Wed, 2017-12-27 at 10:25 -0800, Ben Pfaff wrote: >> On Wed, Dec 27, 2017 at 04:22:55PM +0100, Julia Lawall wrote: >> > The email address pshe...@nicira.com listed for Pravin Shelar in >> > MAINTAINERS (OPENVSWITCH

Re: iproute2 net-next

2017-12-28 Thread Daniel Borkmann
On 12/26/2017 10:35 AM, Leon Romanovsky wrote: > On Mon, Dec 25, 2017 at 10:14:26PM -0800, Stephen Hemminger wrote: >> On Tue, 26 Dec 2017 06:47:43 +0200 >> Leon Romanovsky wrote: >> >>> On Mon, Dec 25, 2017 at 10:49:19AM -0800, Stephen Hemminger wrote: David Ahern has

[for-next V3 03/11] net/mlx5: E-Switch, Simplify representor load/unload callback API

2017-12-28 Thread Saeed Mahameed
From: Mark Bloch In the load() callback for loading representors we don't really need struct mlx5_eswitch but struct mlx5_core_dev, pass it directly. In the unload() callback for unloading representors we don't need the struct mlx5_eswitch argument, remove it.

[for-next V3 04/11] net/mlx5: E-Switch, Move mlx5e only logic outside E-Switch

2017-12-28 Thread Saeed Mahameed
From: Mark Bloch In our pursuit to cleanup e-switch sub-module from mlx5e specific code, we move the functions that insert/remove the flow steering rules that allow mlx5e representors to send packets directly to VFs into the EN driver code. Signed-off-by: Mark Bloch

[for-next V3 01/11] net/mlx5: E-Switch, Refactor vport representors initialization

2017-12-28 Thread Saeed Mahameed
From: Mark Bloch Refactor the init stage of vport representors registration. vport number and hw id can be assigned by the E-Switch driver and not by the netdevice driver. While here, make the error path of mlx5_eswitch_init() a reverse order of the good path, also use

[for-next V3 09/11] net/mlx5e: E-Switch, Use the name of static array instead of its address

2017-12-28 Thread Saeed Mahameed
From: Gal Pressman Using the address of a static array is the same as using its name (in this specific use-case), but it's confusing and makes the code less readable. Fixes: 1bd27b11c1df ("net/mlx5: Introduce E-switch QoS management") Fixes: bd77bf1cb595 ("net/mlx5: Add SRIOV

[for-next V3 05/11] net/mlx5: E-Switch, Create a dedicated send to vport rule deletion function

2017-12-28 Thread Saeed Mahameed
From: Mark Bloch In order for representors to send packets directly to VFs we use an E-Switch function which insert special rules into the HW. For symmetry create an E-Switch function that deletes these rules as well. Signed-off-by: Mark Bloch

[for-next V3 11/11] net/mlx5: Separate ingress/egress namespaces for each vport

2017-12-28 Thread Saeed Mahameed
From: Gal Pressman Each vport has its own root flow table for the ACL flow tables and root flow table is per namespace, therefore we should create a namespace for each vport. Fixes: efdc810ba39d ("net/mlx5: Flow steering, Add vport ACL support") Signed-off-by: Gal Pressman

[for-next V3 07/11] net/mlx5: E-Switch, Create generic header struct to be used by representors

2017-12-28 Thread Saeed Mahameed
From: Mark Bloch Now that we don't store type dependent data in struct mlx5_eswitch_rep we can create a generic interface, and representor type. struct mlx5_eswitch_rep will store an array of interfaces, each interface is used by a different representor type. Once we moved

[pull request][for-next V3 00/11] Mellanox, mlx5 E-Switch updates 2017-12-19

2017-12-28 Thread Saeed Mahameed
Hi Dave and Doug, == This series includes updates for mlx5 E-Switch infrastructures, to be merged into net-next and rdma-next trees. Mark's patches provide E-Switch refactoring that generalize the mlx5 E-Switch vf representors interfaces and data structures. The serious is mainly

[for-next V3 10/11] net/mlx5: Fix ingress/egress naming mistake

2017-12-28 Thread Saeed Mahameed
From: Gal Pressman The functions names do not represent their actions, switch the mistaken ingress/egress naming. Fixes: fba53f7b5719 ("net/mlx5: Introduce mlx5_flow_steering structure") Signed-off-by: Gal Pressman Signed-off-by: Saeed Mahameed

[for-next V3 06/11] net/mlx5e: Move ethernet representors data into separate struct

2017-12-28 Thread Saeed Mahameed
From: Mark Bloch Ethernet representors have a need to store data which is applicable only for them. Create a priv void pointer in struct mlx5_eswitch_rep and move mlx5e to store the relevant data there. As part of this change we also initialize rep_if in

[for-next V3 02/11] net/mlx5: E-Switch, Refactor load/unload of representors

2017-12-28 Thread Saeed Mahameed
From: Mark Bloch Refactor the load/unload stages for better code reuse. Signed-off-by: Mark Bloch Reviewed-by: Or Gerlitz Signed-off-by: Saeed Mahameed --- .../ethernet/mellanox/mlx5/core/eswitch_offloads.c

[for-next V3 08/11] net/mlx5e: E-Switch, Move send-to-vport rule struct to en_rep

2017-12-28 Thread Saeed Mahameed
From: Mark Bloch Move struct mlx5_esw_sq which keeps send-to-vport rule to from the eswitch code to mlx5e and rename it to better reflect where it belongs Signed-off-by: Mark Bloch Reviewed-by: Or Gerlitz Signed-off-by: Saeed

Re: [pull request][for-next V2 00/11] Mellanox, mlx5 E-Switch updates 2017-12-19

2017-12-28 Thread Saeed Mahameed
On Thu, Dec 28, 2017 at 12:03 AM, David Miller wrote: > From: David Miller > Date: Wed, 27 Dec 2017 17:01:22 -0500 (EST) > >> Pulled, thank you. > > Actually, I had to revert. Please fix this and resubmit: > >

[RFT net-next v3 2/5] net: stmmac: dwmac-meson8b: simplify generating the clock names

2017-12-28 Thread Martin Blumenstingl
Instead of using a custom buffer, snprintf() and devm_kstrdup() we can simplify this by using devm_kasprintf(). No functional changes - this just makes the code shorter. Signed-off-by: Martin Blumenstingl ---

[RFT net-next v3 4/5] net: stmmac: dwmac-meson8b: fix setting the RGMII clock on Meson8b

2017-12-28 Thread Martin Blumenstingl
Meson8b only supports MPLL2 as clock input. The rate of the MPLL2 clock set by Odroid-C1's u-boot is close to 500MHz. The exact rate is 52394Hz, which is calculated in drivers/clk/meson/clk-mpll.c using the following formula: DIV_ROUND_UP_ULL((u64)parent_rate * SDM_DEN, (SDM_DEN * n2) + sdm)

[RFT net-next v3 3/5] net: stmmac: dwmac-meson8b: fix internal RGMII clock configuration

2017-12-28 Thread Martin Blumenstingl
While testing the dwmac-meson8b with an RGMII PHY on Meson8b we discovered that the m25_div is not actually a divider but rather a gate. This matches with the datasheet which describes bit 10 as "Generate 25MHz clock for PHY". Back when the driver was written it was assumed that this was a divider

[RFT net-next v3 0/5] dwmac-meson8b: RGMII clock fixes for Meson8b

2017-12-28 Thread Martin Blumenstingl
Hi Dave, please do not apply this series until it got a Tested-by from Emiliano. Hi Emiliano, you reported [0] that you couldn't get dwmac-meson8b to work on your Odroid-C1. With your findings (register dumps, clk_summary output, etc.) I think I was able to find a fix: it consists of two

[RFT net-next v3 1/5] net: stmmac: dwmac-meson8b: only configure the clocks in RGMII mode

2017-12-28 Thread Martin Blumenstingl
Neither the m25_div_clk nor the m250_div_clk or m250_mux_clk are used in RMII mode. The m25_div_clk output is routed to the RGMII PHY's "RGMII clock". This means that we don't need to configure the clocks in RMII mode. The driver however did this - with no effect since the clocks are not routed to

[RFT net-next v3 5/5] net: stmmac: dwmac-meson8b: propagate rate changes to the parent clock

2017-12-28 Thread Martin Blumenstingl
On Meson8b the only valid input clock is MPLL2. The bootloader configures that to run at 52394Hz which cannot be divided evenly down to 25MHz using the m250_div and m25_div clocks. Currently the common clock framework chooses a m250_div of 2 - with the internal fixed "divide by 10" this

[PATCH net-next 1/2] update ENA driver to version 1.5.0

2017-12-28 Thread netanel
From: Netanel Belgazal This patchset contains two changes: * Add a robust mechanism for detection of stuck Rx/Tx rings due to missed or misrouted MSI-X * Increase the driver version to 1.5.0 Netanel Belgazal (2): net: ena: add detection and recovery mechanism for

[PATCH net-next 2/2] net: ena: increase ena driver version to 1.5.0

2017-12-28 Thread netanel
From: Netanel Belgazal Signed-off-by: Netanel Belgazal --- drivers/net/ethernet/amazon/ena/ena_netdev.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/amazon/ena/ena_netdev.h

[PATCH net-next 1/2] net: ena: add detection and recovery mechanism for handling missed/misrouted MSI-X

2017-12-28 Thread netanel
From: Netanel Belgazal A mechanism for detection of stuck Rx/Tx rings due to missed or misrouted interrupts. Check if there are unhandled completion descriptors before the first MSI-X interrupt arrived. The check is per queue and per interrupt vector. Once such condition is

[PATCH net 3/3] eet: ena: invoke netif_carrier_off() only after netdev registered

2017-12-28 Thread netanel
From: Netanel Belgazal netif_carrier_off() should be called only after register netdev. Move the function's call after the registration. Signed-off-by: Netanel Belgazal --- drivers/net/ethernet/amazon/ena/ena_netdev.c | 4 ++-- 1 file changed, 2

[PATCH net 2/3] net: ena: fix error handling in ena_down() sequence

2017-12-28 Thread netanel
From: Netanel Belgazal ENA admin command queue errors are not handled as part of ena_down(). As a result, in case of error admin queue transitions to non-running state and aborts all subsequent commands including those coming from ena_up(). Reset scheduled by the driver from

[PATCH net 1/3] net: ena: unmask MSI-X only after device initialization is completed

2017-12-28 Thread netanel
From: Netanel Belgazal Under certain conditions MSI-X interrupt might arrive right after it was unmasked in ena_up(). There is a chance it would be processed by the driver before device ENA_FLAG_DEV_UP flag is set. In such a case the interrupt is ignored. ENA device operates

[PATCH net 0/3] bug fixes for ENA Ethernet driver

2017-12-28 Thread netanel
From: Netanel Belgazal This patchset contains 3 bug fixes: * handle rare race condition during MSI-X initialization * fix error processing in ena_down() * call netif_carrier_off() only after netdev is registered Netanel Belgazal (3): net: ena: unmask MSI-X only after

Re: pull-request: bpf-next 2017-12-28

2017-12-28 Thread Daniel Borkmann
On 12/28/2017 02:41 AM, David Miller wrote: > From: Daniel Borkmann > Date: Thu, 28 Dec 2017 01:18:21 +0100 > >> The following pull-request contains BPF updates for your *net-next* >> tree. > > Pulled. Thanks! > Any progress on those tests failing on strict alignment

Re: [PATCH net-next 2/2] l2tp: add peer_offset parameter

2017-12-28 Thread Guillaume Nault
On Thu, Dec 28, 2017 at 07:23:48PM +0100, Lorenzo Bianconi wrote: > On Dec 28, Guillaume Nault wrote: > > After a quick review of L2TPv3 and pseudowires RFCs, I still don't see > > how adding some padding between the L2TPv3 header and the payload could > > constitute a valid frame. Of course, the

Re: [PATCH net] skbuff: in skb_copy_ubufs unclone before releasing zerocopy

2017-12-28 Thread David Miller
From: Willem de Bruijn Date: Thu, 28 Dec 2017 12:38:13 -0500 > From: Willem de Bruijn > > skb_copy_ubufs must unclone before it is safe to modify its > skb_shared_info with skb_zcopy_clear. > > Commit b90ddd568792 ("skbuff: skb_copy_ubufs

Re: [PATCH net 0/2] strparser: Fix lockdep issue

2017-12-28 Thread David Miller
From: Tom Herbert Date: Thu, 28 Dec 2017 11:00:42 -0800 > When sock_owned_by_user returns true in strparser. Fix is to add and > call sock_owned_by_user_nocheck since the check for owned by user is > not an error condition in this case. > > Fixes: 43a0c6751a322847

Re: [RFT net-next v2 0/3] dwmac-meson8b: RGMII clock fixes for Meson8b

2017-12-28 Thread Martin Blumenstingl
Hi Emiliano, On Thu, Dec 28, 2017 at 6:51 PM, Emiliano Ingrassia wrote: > Hi Martin, > > thank you for the quick response! > > On Thu, Dec 28, 2017 at 05:58:34PM +0100, Martin Blumenstingl wrote: >> Hi Emiliano, >> >> thank you for testing this! >> >> On Thu, Dec 28,

Re: [PATCH net-next] virtio_net: implement VIRTIO_CONFIG_S_NEEDS_RESET

2017-12-28 Thread Willem de Bruijn
On Mon, Oct 16, 2017 at 11:44 PM, Michael S. Tsirkin wrote: > On Tue, Oct 17, 2017 at 11:05:07AM +0800, Jason Wang wrote: >> >> >> On 2017年10月17日 06:34, Willem de Bruijn wrote: >> > On Mon, Oct 16, 2017 at 12:38 PM, Michael S. Tsirkin >> > wrote: >> > > On Mon,

[PATCH net 2/2] strparser: Call sock_owned_by_user_nocheck

2017-12-28 Thread Tom Herbert
strparser wants to check socket ownership without producing any warnings. As indicated by the comment in the code, it is permissible for owned_by_user to return true. Fixes: 43a0c6751a322847 ("strparser: Stream parser for messages") Reported-by: syzbot

[PATCH net 0/2] strparser: Fix lockdep issue

2017-12-28 Thread Tom Herbert
When sock_owned_by_user returns true in strparser. Fix is to add and call sock_owned_by_user_nocheck since the check for owned by user is not an error condition in this case. Fixes: 43a0c6751a322847 ("strparser: Stream parser for messages") Reported-by: syzbot

[PATCH net 1/2] sock: Add sock_owned_by_user_nocheck

2017-12-28 Thread Tom Herbert
This allows checking socket lock ownership with producing lockdep warnings. Signed-off-by: Tom Herbert --- include/net/sock.h | 5 + 1 file changed, 5 insertions(+) diff --git a/include/net/sock.h b/include/net/sock.h index 9155da422692..7a7b14e9628a 100644 ---

Re: [PATCH net-next 5/6] arm64: dts: marvell: mcbin: enable the fourth network interface

2017-12-28 Thread Russell King - ARM Linux
On Thu, Dec 28, 2017 at 11:04:16AM +0100, Antoine Tenart wrote: > Hi Russell, > > On Wed, Dec 27, 2017 at 11:20:00PM +, Russell King - ARM Linux wrote: > > On Wed, Dec 27, 2017 at 11:42:52PM +0100, Antoine Tenart wrote: > > > > > > What do you suggest to describe this in the dt, to enable a

Re: [PATCH net-next 5/6] arm64: dts: marvell: mcbin: enable the fourth network interface

2017-12-28 Thread Russell King - ARM Linux
On Thu, Dec 28, 2017 at 07:27:39PM +0100, Antoine Tenart wrote: > Hi Florian, > > On Thu, Dec 28, 2017 at 07:02:09AM -0800, Florian Fainelli wrote: > > On 12/28/2017 02:05 AM, Antoine Tenart wrote: > > > On Thu, Dec 28, 2017 at 08:46:23AM +0100, Andrew Lunn wrote: > > >> On Wed, Dec 27, 2017 at

Re: WARNING in strp_data_ready

2017-12-28 Thread Dmitry Vyukov
On Thu, Dec 28, 2017 at 7:21 PM, Ozgur wrote: > > > 28.12.2017, 19:33, "Dmitry Vyukov" : >> On Thu, Dec 28, 2017 at 5:14 PM, Tom Herbert wrote: >>> On Thu, Dec 28, 2017 at 12:59 AM, Ozgur wrote: 28.12.2017,

Re: [PATCH net-next 5/6] arm64: dts: marvell: mcbin: enable the fourth network interface

2017-12-28 Thread Antoine Tenart
Hi Florian, On Thu, Dec 28, 2017 at 07:02:09AM -0800, Florian Fainelli wrote: > On 12/28/2017 02:05 AM, Antoine Tenart wrote: > > On Thu, Dec 28, 2017 at 08:46:23AM +0100, Andrew Lunn wrote: > >> On Wed, Dec 27, 2017 at 10:24:01PM +, Russell King - ARM Linux wrote: > >>> On Wed, Dec 27, 2017

Re: [PATCH net-next 1/6] phy: add 2.5G SGMII mode to the phy_mode enum

2017-12-28 Thread Antoine Tenart
Hi Florian, On Thu, Dec 28, 2017 at 06:16:51AM -0800, Florian Fainelli wrote: > > And since you are respinning, please make sure you update phy_modes() in > the same header file as well as > Documentation/devicetree/bindings/net/ethernet.txt with the newly added > PHY interface mode. You're

Re: [PATCH net-next 2/2] l2tp: add peer_offset parameter

2017-12-28 Thread Lorenzo Bianconi
On Dec 28, Guillaume Nault wrote: > On Fri, Dec 22, 2017 at 03:10:18PM +0100, Lorenzo Bianconi wrote: > > Introduce peer_offset parameter in order to add the capability > > to specify two different values for payload offset on tx/rx side. > > If just offset is provided by userspace use it for rx

Re: [PATCH iproute2 2/3] utils: ll_map: Update name and type for existing entry

2017-12-28 Thread Serhey Popovych
Stephen Hemminger wrote: > On Wed, 20 Dec 2017 09:37:30 +0200 > Serhey Popovych wrote: > >> In case of we update existing entry we need not only rehash >> but also update name in existing entry. >> >> Need to update device type too since cached interface might >> be

Re: [PATCH iproute2 2/3] utils: ll_map: Update name and type for existing entry

2017-12-28 Thread Stephen Hemminger
On Wed, 20 Dec 2017 09:37:30 +0200 Serhey Popovych wrote: > In case of we update existing entry we need not only rehash > but also update name in existing entry. > > Need to update device type too since cached interface might > be deleted and new with same index, but

Re: [PATCH iproute2 3/3] utils: ll_map: Make network device name fixed size array of char

2017-12-28 Thread Stephen Hemminger
On Wed, 20 Dec 2017 09:37:31 +0200 Serhey Popovych wrote: > Network device names are fixed in size and never exceed > IFNAMSIZ (16 bytes). > > Make name fixed size array to always malloc() same size chunk > of memory and use memcpy()/memcmp() with constant IFNAMSIZ >

Re: [PATCH iproute2 3/3] utils: ll_map: Make network device name fixed size array of char

2017-12-28 Thread Serhey Popovych
Stephen Hemminger wrote: > On Wed, 20 Dec 2017 09:37:31 +0200 > Serhey Popovych wrote: > >> Network device names are fixed in size and never exceed >> IFNAMSIZ (16 bytes). >> >> Make name fixed size array to always malloc() same size chunk >> of memory and use

Re: [PATCH iproute2 3/3] ip/tunnel: Document "external" parameter

2017-12-28 Thread Stephen Hemminger
On Thu, 28 Dec 2017 13:11:42 +0200 Serhey Popovych wrote: > Add it to ip-link(8) "type gre" output help message > as well as to ip-link(8) page. > > Signed-off-by: Serhey Popovych Applied. Thanks

Re: [PATCH iproute2 1/3] vxcan,veth: Forbid "type" for peer device

2017-12-28 Thread Stephen Hemminger
On Thu, 28 Dec 2017 13:01:04 +0200 Serhey Popovych wrote: > It is already given for original device we configure this > peer for. > > Results from following command before/after change applied > are shown below: > > $ ip link add dev veth1a type veth peer name

Re: [PATCH v2 bpf-next 06/11] bpf: Add sock_ops RTO callback

2017-12-28 Thread Yuchung Cheng
On Thu, Dec 21, 2017 at 5:20 PM, Lawrence Brakmo wrote: > > Adds an optional call to sock_ops BPF program based on whether the > BPF_SOCK_OPS_RTO_CB_FLAG is set in bpf_sock_ops_flags. > The BPF program is passed 2 arguments: icsk_retransmits and whether the > RTO has expired. > >

Re: [RFT net-next v2 0/3] dwmac-meson8b: RGMII clock fixes for Meson8b

2017-12-28 Thread Emiliano Ingrassia
Hi Martin, thank you for the quick response! On Thu, Dec 28, 2017 at 05:58:34PM +0100, Martin Blumenstingl wrote: > Hi Emiliano, > > thank you for testing this! > > On Thu, Dec 28, 2017 at 5:16 PM, Emiliano Ingrassia > wrote: > > Hi Martin, Hi Dave, > > > > On Sun,

[PATCH net] skbuff: in skb_copy_ubufs unclone before releasing zerocopy

2017-12-28 Thread Willem de Bruijn
From: Willem de Bruijn skb_copy_ubufs must unclone before it is safe to modify its skb_shared_info with skb_zcopy_clear. Commit b90ddd568792 ("skbuff: skb_copy_ubufs must release uarg even without user frags") ensures that all skbs release their zerocopy state, even those

Re: [PATCH net-next 0/4] mlx4 misc for 4.16

2017-12-28 Thread David Miller
From: Tariq Toukan Date: Thu, 28 Dec 2017 16:26:07 +0200 > This patchset contains misc cleanups and improvements > to the mlx4 Core and Eth drivers. > > In patches 1 and 2 I reduce and reorder the branches in the RX csum flow. > In patch 3 I align the FMR unmapping flow

Re: [patch net-next] net: sched: don't set extack message in case the qdisc will be created

2017-12-28 Thread David Miller
From: Jiri Pirko Date: Thu, 28 Dec 2017 16:52:10 +0100 > From: Jiri Pirko > > If the qdisc is not found here, it is going to be created. Therefore, > this is not an error path. Remove the extack message set and don't > confuse user with error message in

Re: [PATCH 1/3] net: Fix possible race in peernet2id_alloc()

2017-12-28 Thread David Miller
From: Kirill Tkhai Date: Thu, 28 Dec 2017 15:55:15 +0300 > Could you please clarify the status or what I should do with the patchset > (because it's not clear for me)? Please resend.

Re: [PATCH net v1 1/1] tipc: fix hanging poll() for stream sockets

2017-12-28 Thread David Miller
From: Parthasarathy Bhuvaragan Date: Thu, 28 Dec 2017 12:03:06 +0100 > In commit 42b531de17d2f6 ("tipc: Fix missing connection request > handling"), we replaced unconditional wakeup() with condtional > wakeup for clients with flags POLLIN | POLLRDNORM |

Re: [PATCH net-next v9 0/2] add UniPhier AVE ethernet support

2017-12-28 Thread David Miller
From: Kunihiko Hayashi Date: Thu, 28 Dec 2017 15:58:10 +0900 > This series adds support for Socionext AVE ethernet controller implemented > on UniPhier SoCs. This driver supports RGMII/RMII modes. Series applied.

Re: [PATCH net-next] cxgb4/cxgb4vf: support for XLAUI Port Type

2017-12-28 Thread David Miller
From: Ganesh Goudar Date: Thu, 28 Dec 2017 12:07:15 +0530 > Add support for new Backplane XLAUI port type. > > Signed-off-by: Casey Leedom > Signed-off-by: Ganesh Goudar Applied.

Fw: [Bug 198297] New: Unable to add ethX to bridge if ethX. is already present in this bridge

2017-12-28 Thread Stephen Hemminger
I don't think this is ever going to work as expected. Begin forwarded message: Date: Thu, 28 Dec 2017 08:38:37 + From: bugzilla-dae...@bugzilla.kernel.org To: step...@networkplumber.org Subject: [Bug 198297] New: Unable to add ethX to bridge if ethX. is already present in this bridge

Re: [PATCH net-next v6 0/6] net: tcp: sctp: dccp: Replace jprobe usage with trace events

2017-12-28 Thread David Miller
From: Masami Hiramatsu Date: Thu, 28 Dec 2017 15:10:00 +0900 > Changes from v5: > [1/6]: Avoid preprocessor directives in tracepoint macro args Patch #1 is not the only patch which has this problem, at a minimum patch #5 has it too. Please audit the entire series for an

Re: [PATCH net-next] cxgb4: display VNI correctly

2017-12-28 Thread David Miller
From: Ganesh Goudar Date: Thu, 28 Dec 2017 11:29:52 +0530 > Fix incorrect VNI display in mps_tcam > > Signed-off-by: Santosh Rastapur > Signed-off-by: Ganesh Goudar Applied.

Re: [RFT net-next v2 0/3] dwmac-meson8b: RGMII clock fixes for Meson8b

2017-12-28 Thread Martin Blumenstingl
Hi Emiliano, thank you for testing this! On Thu, Dec 28, 2017 at 5:16 PM, Emiliano Ingrassia wrote: > Hi Martin, Hi Dave, > > On Sun, Dec 24, 2017 at 12:40:57AM +0100, Martin Blumenstingl wrote: >> Hi Dave, >> >> please do not apply this series until it got a Tested-by

Re: [patch net-next v2 00/10] Add support for resource abstraction

2017-12-28 Thread Jiri Pirko
Thu, Dec 28, 2017 at 05:33:58PM CET, d...@cumulusnetworks.com wrote: >On 12/28/17 10:23 AM, Jiri Pirko wrote: >>> So there are 4 tables exported to userspace: >>> >>> 1. mlxsw_erif table which is not in any of the kvd regions (no resource >>> path is given) and it has a size of 1000. Does

Re: [patch net-next v2 00/10] Add support for resource abstraction

2017-12-28 Thread David Ahern
On 12/28/17 10:23 AM, Jiri Pirko wrote: >> So there are 4 tables exported to userspace: >> >> 1. mlxsw_erif table which is not in any of the kvd regions (no resource >> path is given) and it has a size of 1000. Does mlxsw_erif mean a rif as >> in Router Interfaces? So the switch supports up to

Re: WARNING in strp_data_ready

2017-12-28 Thread Dmitry Vyukov
On Thu, Dec 28, 2017 at 5:14 PM, Tom Herbert wrote: > On Thu, Dec 28, 2017 at 12:59 AM, Ozgur wrote: >> >> >> 28.12.2017, 04:19, "Tom Herbert" : >>> On Wed, Dec 27, 2017 at 12:20 PM, Ozgur wrote: 27.12.2017,

Re: [patch net-next v2 00/10] Add support for resource abstraction

2017-12-28 Thread Jiri Pirko
Thu, Dec 28, 2017 at 05:09:09PM CET, d...@cumulusnetworks.com wrote: >On 12/28/17 2:25 AM, Yuval Mintz wrote: > Again, I have no objections to kvd, linear, hash, etc terms as they do > relate to Mellanox products. But kvd/linear, for example, does correlate > to industry standard

Re: [RFT net-next v2 0/3] dwmac-meson8b: RGMII clock fixes for Meson8b

2017-12-28 Thread Emiliano Ingrassia
Hi Martin, Hi Dave, On Sun, Dec 24, 2017 at 12:40:57AM +0100, Martin Blumenstingl wrote: > Hi Dave, > > please do not apply this series until it got a Tested-by from Emiliano. > > > Hi Emiliano, > > you reported [0] that you couldn't get dwmac-meson8b to work on your > Odroid-C1. With your

Re: WARNING in strp_data_ready

2017-12-28 Thread Tom Herbert
On Thu, Dec 28, 2017 at 12:59 AM, Ozgur wrote: > > > 28.12.2017, 04:19, "Tom Herbert" : >> On Wed, Dec 27, 2017 at 12:20 PM, Ozgur wrote: >>> 27.12.2017, 23:14, "Dmitry Vyukov" : On Wed, Dec 27, 2017 at 9:08 PM,

Re: [patch net-next v2 00/10] Add support for resource abstraction

2017-12-28 Thread David Ahern
On 12/28/17 2:25 AM, Yuval Mintz wrote: Again, I have no objections to kvd, linear, hash, etc terms as they do relate to Mellanox products. But kvd/linear, for example, does correlate to industry standard concepts in some way. My request is that the resource listing guide the

Re: [PATCH net-next v2 1/3] virtio_net: propagate linkspeed/duplex settings from the hypervisor

2017-12-28 Thread Jason Baron
On 12/27/2017 04:43 PM, David Miller wrote: > From: Jason Baron > Date: Fri, 22 Dec 2017 16:54:01 -0500 > >> The ability to set speed and duplex for virtio_net in useful in various >> scenarios as described here: >> >> 16032be virtio_net: add ethtool support for set and get

[patch net-next] net: sched: don't set extack message in case the qdisc will be created

2017-12-28 Thread Jiri Pirko
From: Jiri Pirko If the qdisc is not found here, it is going to be created. Therefore, this is not an error path. Remove the extack message set and don't confuse user with error message in case the qdisc was created successfully. Fixes: 09215598119e ("net: sched: sch_api:

Re: [PATCH iproute2] gre/tunnel: Print erspan_index using print_uint()

2017-12-28 Thread Serhey Popovych
> Hi Serhey, Hi William, Yes, iproute2-next/net-next branch contains fix already: we probably do not need proposed change. Sorry for noise. I'm currently focused on bug fixing in stable which affects my work for iproute2-next. All my future work will be based on iproute2-next as it contains

Re: [PATCH iproute2] gre/tunnel: Print erspan_index using print_uint()

2017-12-28 Thread William Tu
Hi Serhey, On Thu, Dec 28, 2017 at 3:12 AM, Serhey Popovych wrote: > One is missing in JSON output because fprintf() > is used instead of print_uint(). > > Signed-off-by: Serhey Popovych > --- > ip/link_gre.c |3 ++- > ip/link_gre6.c |

  1   2   >