Re: [PATCH] ethernet: mlx4: Delete an error message for a failed memory allocation in five functions

2018-01-02 Thread Tariq Toukan
On 01/01/2018 10:46 PM, SF Markus Elfring wrote: From: Markus Elfring Date: Mon, 1 Jan 2018 21:42:27 +0100 Omit an extra message for a memory allocation failure in these functions. This issue was detected by using the Coccinelle software. Signed-off-by:

Re: [RFC PATCH net-next 16/19] ipv6: Flush multipath routes when all siblings are dead

2018-01-02 Thread Ido Schimmel
On Tue, Jan 02, 2018 at 10:38:19AM -0700, David Ahern wrote: > On 12/31/17 9:15 AM, Ido Schimmel wrote: > > @@ -3550,13 +3581,21 @@ static int fib6_ifdown(struct rt6_info *rt, void > > *p_arg) > > } > > return -2; > > case NETDEV_DOWN: > > - if (rt->dst.dev

Re: [RFC PATCH net-next 13/19] ipv6: Flush all sibling routes upon NETDEV_UNREGISTER

2018-01-02 Thread Ido Schimmel
On Tue, Jan 02, 2018 at 10:42:51AM -0700, David Ahern wrote: > On 12/31/17 9:15 AM, Ido Schimmel wrote: > > IPv4 and IPv6 react differently to a netdev being unregistered. In IPv4, > > in case the netdev is used as a nexthop device in a multipath route, the > > entire route is flushed. > > > >

Re: [RFC PATCH net-next 04/19] ipv6: Prepare to handle multiple netdev events

2018-01-02 Thread Ido Schimmel
On Tue, Jan 02, 2018 at 09:29:42AM -0700, David Ahern wrote: > On 12/31/17 9:14 AM, Ido Schimmel wrote: > > To make IPv6 more in line with IPv4 we need to be able to respond > > differently to different netdev events. For example, when a netdev is > > unregistered all the routes using it as their

Re: [RFC PATCH net-next 03/19] ipv6: Clear nexthop flags upon netdev up

2018-01-02 Thread Ido Schimmel
Hi David, On Tue, Jan 02, 2018 at 09:20:47AM -0700, David Ahern wrote: > On 12/31/17 9:14 AM, Ido Schimmel wrote: > > Previous patch marked nexthops with the 'dead' and 'linkdown' flags. > > Clear these flags when the netdev comes back up. > > > > Signed-off-by: Ido Schimmel

Re: general protection fault in __netlink_ns_capable

2018-01-02 Thread Andrei Vagin
On Tue, Jan 02, 2018 at 04:35:11PM -0800, Andrei Vagin wrote: > On Tue, Jan 02, 2018 at 10:58:01AM -0800, syzbot wrote: > > Hello, > > > > syzkaller hit the following crash on > > 75aa5540627fdb3d8f86229776ea87f995275351 > > git://git.cmpxchg.org/linux-mmots.git/master > > compiler: gcc (GCC)

RE: [PATCH v4 net-next 0/4] qed*: Advance to FW 8.33.1.0

2018-01-02 Thread Elior, Ariel
> From: Tomer Tayar > Date: Wed, 27 Dec 2017 19:30:04 +0200 > > > This series advances all qed* drivers to use firmware 8.33.1.0 which brings > > new capabilities and initial support of new HW. The changes are mostly in > > qed, and include changes in the FW interface

Re: [PATCH net] sctp: fix handling of ICMP Frag Needed for too small MTUs

2018-01-02 Thread Xin Long
On Wed, Jan 3, 2018 at 5:44 AM, Marcelo Ricardo Leitner wrote: > syzbot reported a hang involving SCTP, on which it kept flooding dmesg > with the message: > [ 246.742374] sctp: sctp_transport_update_pmtu: Reported pmtu 508 too > low, using default minimum of 512 > >

[PATCHv4 1/2] capability: introduce sysctl for controlled user-ns capability whitelist

2018-01-02 Thread Mahesh Bandewar
From: Mahesh Bandewar Add a sysctl variable kernel.controlled_userns_caps_whitelist. Capability mask is stored in kernel as kernel_cap_t type (array of u32). This sysctl takes input as comma separated hex u32 words. For simplicity one could see this sysctl to operate on

[PATCHv4 0/2] capability controlled user-namespaces

2018-01-02 Thread Mahesh Bandewar
From: Mahesh Bandewar TL;DR version - Creating a sandbox environment with namespaces is challenging considering what these sandboxed processes can engage into. e.g. CVE-2017-6074, CVE-2017-7184, CVE-2017-7308 etc. just to name few. Current form of user-namespaces,

[PATCH] rtnetlink: give a user socket to get_target_net()

2018-01-02 Thread Andrei Vagin
This function is used from two places: rtnl_dump_ifinfo and rtnl_getlink. In rtnl_getlink(), we give a request skb into get_target_net(), but in rtnl_dump_ifinfo, we give a response skb into get_target_net(). The problem here is that NETLINK_CB() isn't initialized for the response skb. In both

[PATCHv4 2/2] userns: control capabilities of some user namespaces

2018-01-02 Thread Mahesh Bandewar
From: Mahesh Bandewar With this new notion of "controlled" user-namespaces, the controlled user-namespaces are marked at the time of their creation while the capabilities of processes that belong to them are controlled using the global mask. Init-user-ns is always

Re: [RFC crypto v3 0/9] Chelsio Inline TLS

2018-01-02 Thread Atul Gupta
Addressed the review comments in v2 and v3, please suggest if there is any other comment and step to proceed? Thanks Atul Gupta On Wednesday 20 December 2017 05:03 PM, Atul Gupta wrote: RFC series for Chelsio Inline TLS driver (chtls.ko) Driver use the ULP infrastructure to register chtls

Re: [PATCH] bonding: Delete an error message for a failed memory allocation in bond_update_slave_arr()

2018-01-02 Thread महेश बंडेवार
On Mon, Jan 1, 2018 at 8:07 AM, SF Markus Elfring wrote: > From: Markus Elfring > Date: Mon, 1 Jan 2018 17:00:04 +0100 > > Omit an extra message for a memory allocation failure in this function. > > This issue was detected by using

Re: [PATCH net] sctp: fix error path in sctp_stream_init

2018-01-02 Thread Xin Long
On Wed, Jan 3, 2018 at 5:44 AM, Marcelo Ricardo Leitner wrote: > syzbot noticed a NULL pointer dereference panic in sctp_stream_free() > which was caused by an incomplete error handling in sctp_stream_init(). > By not clearing stream->outcnt, it made a for() in

Re: [PATCH v3 00/27] kill devm_ioremap_nocache

2018-01-02 Thread Yisheng Xie
+ cris/ia64/mn10300/openrisc maintainers On 2017/12/25 9:09, Yisheng Xie wrote: > hi Christophe and Greg, > > On 2017/12/24 16:55, christophe leroy wrote: >> >> >> Le 23/12/2017 à 16:57, Guenter Roeck a écrit : >>> On 12/23/2017 05:48 AM, Greg KH wrote: On Sat, Dec 23, 2017 at 06:55:25PM

Re: WARNING in adjust_ptr_min_max_vals

2018-01-02 Thread Alexei Starovoitov
On Tue, Jan 02, 2018 at 08:58:01PM -0800, syzbot wrote: > Hello, > > syzkaller hit the following crash on > 0e08c463db387a2adcb0243b15ab868a73f87807 > git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/master > compiler: gcc (GCC) 7.1.1 20170620 > .config is attached > Raw console

Re: general protection fault in copy_verifier_state

2018-01-02 Thread Alexei Starovoitov
On Tue, Jan 02, 2018 at 02:58:01PM -0800, syzbot wrote: > Hello, > > syzkaller hit the following crash on > 6bb8824732f69de0f233ae6b1a8158e149627b38 > git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git/master > compiler: gcc (GCC) 7.1.1 20170620 > .config is attached > Raw console

Re: [PATCH v2] openvswitch: Trim off padding before L3+ netfilter processing

2018-01-02 Thread Pravin Shelar
On Fri, Dec 22, 2017 at 4:39 PM, Ed Swierk wrote: > On Fri, Dec 22, 2017 at 3:31 PM, Pravin Shelar wrote: >> On Thu, Dec 21, 2017 at 7:17 AM, Ed Swierk >> wrote: >>> IPv4 and IPv6 packets may arrive with lower-layer

Re: [ovs-dev] Pravin Shelar

2018-01-02 Thread Pravin Shelar
On Tue, Jan 2, 2018 at 11:36 AM, David Miller wrote: > From: Pravin Shelar > Date: Thu, 28 Dec 2017 15:47:39 -0800 > >> Thanks Joe for the patch. But it is corrupted. I will send updated patch >> soon. > > I'm still waiting for this, just FYI :) I sent the

[PATCH] MAINTAINERS: Update my email address.

2018-01-02 Thread Pravin B Shelar
Signed-off-by: Pravin Shelar --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 753799d..1704ed4 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -10152,7 +10152,7 @@ F: drivers/irqchip/irq-ompic.c F:

[PATCH net V2 2/2] net: ena: fix error handling in ena_down() sequence

2018-01-02 Thread netanel
From: Netanel Belgazal ENA admin command queue errors are not handled as part of ena_down(). As a result, in case of error admin queue transitions to non-running state and aborts all subsequent commands including those coming from ena_up(). Reset scheduled by the driver from

[PATCH net V2 1/2] net: ena: unmask MSI-X only after device initialization is completed

2018-01-02 Thread netanel
From: Netanel Belgazal Under certain conditions MSI-X interrupt might arrive right after it was unmasked in ena_up(). There is a chance it would be processed by the driver before device ENA_FLAG_DEV_UP flag is set. In such a case the interrupt is ignored. ENA device operates

[PATCH net V2 0/2] bug fixes for ENA Ethernet driver

2018-01-02 Thread netanel
From: Netanel Belgazal Changes from V1: Revome incorrect "ena: invoke netif_carrier_off() only after netdev registered" patch This patchset contains 2 bug fixes: * handle rare race condition during MSI-X initialization * fix error processing in ena_down() Netanel

[PATCH net v2] cxgb4: Fix FW flash errors

2018-01-02 Thread Ganesh Goudar
From: Arjun Vynipadath commit 96ac18f14a5a ("cxgb4: Add support for new flash parts") removed initialization of adapter->params.sf_fw_start causing issues while flashing firmware to card. We no longer need sf_fw_start in adapter->params as we already have macros defined for FW

Re: [PATCH iproute2-next 0/9] RDMA resource tracking

2018-01-02 Thread Leon Romanovsky
On Tue, Jan 02, 2018 at 11:37:16AM +0200, Leon Romanovsky wrote: > From: Leon Romanovsky > David, Thanks for the review, I'll fix everything you mentioned and will send new version a little bit later this week to give time to other reviewers to finish their reviews.

Re: [PATCH iproute2-next 6/9] rdma: Update kernel header file

2018-01-02 Thread Leon Romanovsky
On Tue, Jan 02, 2018 at 07:50:43PM -0700, David Ahern wrote: > On 1/2/18 2:37 AM, Leon Romanovsky wrote: > > From: Leon Romanovsky > > > > Synchronize iporute2 package with latest kernel > > RDMA netlink header file. > > > > Signed-off-by: Leon Romanovsky

[PATCH net-next] tg3: Add Macronix NVRAM support

2018-01-02 Thread Satish Baddipadige
From: Prashant Sreedharan This patch adds the support for Macronix NVRAM Signed-off-by: Prashant Sreedharan Signed-off-by: Satish Baddipadige Reviewed-by: Michael Chan

Re: [PATCH iproute2-next] ip: link: add support for netdevsim device type

2018-01-02 Thread David Ahern
On 1/2/18 3:54 PM, Jakub Kicinski wrote: > netdevsim is a new software device for testing kernel APIs > without any hardware attached. Allow users to create such > devices. > > Signed-off-by: Jakub Kicinski > Reviewed-by: Quentin Monnet

"lockless" qdisc breaks tx_queue_len change too?

2018-01-02 Thread Cong Wang
Hi, John While reviewing your ptr_ring fix again today, it looks like your "lockless" qdisc patchset breaks dev->tx_queue_len behavior. Before your patchset, dev->tx_queue_len is merely an integer to read, after your patchset, the skb array has to be resized when dev->tx_queue_len changes, but I

Re: [patch iproute2 v5 2/3] tc: Add -bs option to batch mode

2018-01-02 Thread David Ahern
You need a patch description here ... On 1/2/18 7:55 PM, Chris Mi wrote: > static int tc_action_modify(int cmd, unsigned int flags, > - int *argc_p, char ***argv_p) > + int *argc_p, char ***argv_p, > + int batch_size, int

Re: [patch iproute2 v5 1/3] lib/libnetlink: Add a function rtnl_talk_msg

2018-01-02 Thread David Ahern
On 1/2/18 7:55 PM, Chris Mi wrote: > diff --git a/lib/libnetlink.c b/lib/libnetlink.c > index 00e6ce0c..cc02a139 100644 > --- a/lib/libnetlink.c > +++ b/lib/libnetlink.c > @@ -581,32 +581,34 @@ static void rtnl_talk_error(struct nlmsghdr *h, struct > nlmsgerr *err, >

[bpf PATCH] bpf: sockmap missing NULL psock check

2018-01-02 Thread John Fastabend
Add psock NULL check to handle a racing sock event that can get the sk_callback_lock before this case but after xchg happens causing the refcnt to hit zero and sock user data (psock) to be null and queued for garbage collection. Also add a comment in the code because this is a bit subtle and not

[PATCH net-next 1/3] nfp: flower: obtain repr link state only from firmware

2018-01-02 Thread Jakub Kicinski
From: Dirk van der Merwe Instead of starting up reprs assuming that there is link, only respond to the link state reported by firmware. Furthermore, ensure link is down after repr netdevs are created. Signed-off-by: Dirk van der Merwe

[PATCH net-next 0/3] nfp: flower: repr link state

2018-01-02 Thread Jakub Kicinski
Dirk says: This series provides two updates towards the link state of reprs in the flower nfp app. Patch #1 improves the way link state is reported for reprs. Instead of starting with an assumed 'UP' state, always assume the link state is 'DOWN' and then modify this only on events received from

[PATCH net-next 2/3] nfp: add repr_preclean callback

2018-01-02 Thread Jakub Kicinski
From: Dirk van der Merwe Just before a repr is cleaned up, we give the app a chance to perform some preclean configuration while the reprs pointer is still configured for the app. Signed-off-by: Dirk van der Merwe Reviewed-by:

[PATCH net-next 3/3] nfp: flower: implement the PORT_REIFY message

2018-01-02 Thread Jakub Kicinski
From: Dirk van der Merwe The PORT_REIFY message indicates whether reprs have been created or when they are about to be destroyed. This is necessary so firmware can know which state the driver is in, e.g. the firmware will not send any control messages related to

Business Opportunity

2018-01-02 Thread Mr Yin Lianchen
Hello, How are you and your family? Thanks for accepting my connection. I am connecting you due to a Business Opportunity. Should you like to know more about it. Do get back to me so i give you further details. I hope to hear from you soon Regards, MR. YIN LIANCHEN CHIEF INVESTMENT OFFICER

Re: [PATCH iproute2-next 8/9] rdma: Add QP resource tracking information

2018-01-02 Thread David Ahern
On 1/2/18 2:37 AM, Leon Romanovsky wrote: > + mnl_attr_for_each_nested(nla_entry, nla_table) { > + struct nlattr *nla_line[RDMA_NLDEV_ATTR_MAX] = {}; > + uint32_t lqpn, rqpn = 0, rq_psn = 0, sq_psn; > + uint8_t type, state, path_mig_state = 0; > +

Re: [PATCH] liquidio: Use zeroing memory allocator than allocator/memset

2018-01-02 Thread David Miller
From: Himanshu Jha Date: Sun, 31 Dec 2017 17:57:29 +0530 > Use vzalloc for allocating zeroed memory and remove unnecessary > memset function. > > Done using Coccinelle. > Generated-by: scripts/coccinelle/api/alloc/kzalloc-simple.cocci > 0-day tested with no

[PATCH] nl80211: Check for the required netlink attribute presence

2018-01-02 Thread Hao Chen
nl80211_nan_add_func() does not check if the required attribute NL80211_NAN_FUNC_FOLLOW_UP_DEST is present when processing NL80211_CMD_ADD_NAN_FUNCTION request. This request can be issued by users with CAP_NET_ADMIN privilege and may result in NULL dereference and a system crash. Add a check for

Re: [patch iproute2 v5 0/3] tc: Add -bs option to batch mode

2018-01-02 Thread David Ahern
I have a day job outside of iproute2 patches; give a day or 2 for review by many people.

Re: [PATCH] ethernet/broadcom: Use zeroing memory allocator than allocator/memset

2018-01-02 Thread David Miller
From: Himanshu Jha Date: Sat, 30 Dec 2017 21:14:57 +0530 > Use dma_zalloc_coherent for allocating zeroed > memory and remove unnecessary memset function. > > Done using Coccinelle. > Generated-by: scripts/coccinelle/api/alloc/kzalloc-simple.cocci > 0-day tested with

Re: [PATCH net-next 0/2] net: stmmac: Couple of debug prints improvements

2018-01-02 Thread David Miller
From: Florian Fainelli Date: Fri, 29 Dec 2017 19:56:31 -0800 > While working on a particular problem, I had to turn on debug prints and found > them to be useful, but could deserve some improvements in order to help debug > situations. Series applied, thanks Florian.

Re: [PATCH] qed: Use zeroing memory allocator than allocator/memset

2018-01-02 Thread David Miller
From: Himanshu Jha Date: Sat, 30 Dec 2017 21:07:04 +0530 > Use dma_zalloc_coherent and vzalloc for allocating zeroed > memory and remove unnecessary memset function. > > Done using Coccinelle. > Generated-by: scripts/coccinelle/api/alloc/kzalloc-simple.cocci > 0-day

[patch iproute2 v5 3/3] man: Add -bs option to tc manpage

2018-01-02 Thread Chris Mi
Signed-off-by: Chris Mi --- man/man8/tc.8 | 9 + 1 file changed, 9 insertions(+) diff --git a/man/man8/tc.8 b/man/man8/tc.8 index ff071b33..7338ed3b 100644 --- a/man/man8/tc.8 +++ b/man/man8/tc.8 @@ -601,6 +601,15 @@ must exist already. read commands from provided

[patch iproute2 v5 1/3] lib/libnetlink: Add a function rtnl_talk_msg

2018-01-02 Thread Chris Mi
rtnl_talk can only send a single message to kernel. Add a new function rtnl_talk_msg that can send multiple messages to kernel. Signed-off-by: Chris Mi --- include/libnetlink.h | 3 +++ lib/libnetlink.c | 59 ++-- 2 files

[patch iproute2 v5 0/3] tc: Add -bs option to batch mode

2018-01-02 Thread Chris Mi
Currently in tc batch mode, only one command is read from the batch file and sent to kernel to process. With this patchset, we can accumulate several commands before sending to kernel. The batch size is specified using option -bs or -batchsize. To accumulate the commands in tc, client should

[patch iproute2 v5 2/3] tc: Add -bs option to batch mode

2018-01-02 Thread Chris Mi
Signed-off-by: Chris Mi --- tc/m_action.c | 90 -- tc/tc.c| 70 ++--- tc/tc_common.h | 8 +++- tc/tc_filter.c | 121 + 4 files changed,

Re: [PATCH net-next 2/2] tun: allow to attach ebpf socket filter

2018-01-02 Thread Jason Wang
On 2018年01月02日 17:19, Willem de Bruijn wrote: More importantly, should this program just return a boolean pass or drop. Taking a length and trimming may introduce bugs later on if the stack parses the packet unconditionally, expecting a minimum size to be present. This was the reason for

Re: [PATCH net-next] net: dsa: Fix dsa_legacy_register() return value

2018-01-02 Thread David Miller
From: Florian Fainelli Date: Fri, 29 Dec 2017 11:05:45 -0800 > We need to make the dsa_legacy_register() stub return 0 in order for > dsa_init_module() to successfully register and continue registering the > ETH_P_XDSA packet handler. > > Fixes: 2a93c1a3651f ("net: dsa:

Re: [net 1/1] tipc: fix problems with multipoint-to-point flow control

2018-01-02 Thread David Miller
From: Jon Maloy Date: Fri, 29 Dec 2017 19:48:02 +0100 > In commit 04d7b574b245 ("tipc: add multipoint-to-point flow control") we > introduced a protocol for preventing buffer overflow when many group > members try to simultaneously send messages to the same receiving

Re: [PATCH net] cxgb4: Fix FW flash errors

2018-01-02 Thread David Miller
From: Ganesh Goudar Date: Sat, 30 Dec 2017 00:06:09 +0530 > From: Arjun Vynipadath > > Initialize adapter->params.sf_fw_start to fix firmware flash > issues. Use existing macros defined for FW flash addresses. > > Fixes: 96ac18f14a5a ("cxgb4: Add

Re: [PATCH iproute2-next 6/9] rdma: Update kernel header file

2018-01-02 Thread David Ahern
On 1/2/18 2:37 AM, Leon Romanovsky wrote: > From: Leon Romanovsky > > Synchronize iporute2 package with latest kernel > RDMA netlink header file. > > Signed-off-by: Leon Romanovsky > --- > include/uapi/rdma/rdma_netlink.h | 58 >

Re: [PATCH net] ethtool: do not print warning for applications using legacy API

2018-01-02 Thread David Miller
From: Stephen Hemminger Date: Fri, 29 Dec 2017 10:02:52 -0800 > From: Stephen Hemminger > > In kernel log ths message appears on every boot: > "warning: `NetworkChangeNo' uses legacy ethtool link settings API, > link modes are only

Re: [patch iproute2 v4 3/3] man: Add -bs option to tc manpage

2018-01-02 Thread Chris Mi
2018/1/3 4:07, Marcelo Ricardo Leitner: On Tue, Jan 02, 2018 at 11:28:04PM +0900, Chris Mi wrote: Signed-off-by: Chris Mi --- man/man8/tc.8 | 5 + 1 file changed, 5 insertions(+) diff --git a/man/man8/tc.8 b/man/man8/tc.8 index ff071b33..de137e16 100644 ---

Re: [PATCH] 3c59x: fix missing dma_mapping_error check

2018-01-02 Thread David Miller
From: Neil Horman Date: Fri, 29 Dec 2017 11:40:10 -0500 > @@ -2067,6 +2072,9 @@ vortex_start_xmit(struct sk_buff *skb, struct > net_device *dev) > int len = (skb->len + 3) & ~3; > vp->tx_skb_dma = pci_map_single(VORTEX_PCI(vp), skb->data, len,

Re: [PATCH iproute2-next 3/9] rdma: Add filtering infrastructure

2018-01-02 Thread David Ahern
On 1/2/18 2:37 AM, Leon Romanovsky wrote: > +/* > + * Check if string entry is filtered: > + * * key doesn't exist -> user didn't request -> not filtered > + */ > +bool rd_check_is_string_filtered(struct rd *rd, const char *key, char *val) > +{ > + bool key_is_filtered = false; > + struct

Re: [PATCH iproute2-next 1/9] rdam: Add option to provide "-" sign for the port number

2018-01-02 Thread David Ahern
a couple of nits On 1/2/18 2:37 AM, Leon Romanovsky wrote: > diff --git a/rdma/utils.c b/rdma/utils.c > index 7b2001e2..7c920a5c 100644 > --- a/rdma/utils.c > +++ b/rdma/utils.c > @@ -10,6 +10,7 @@ > */ > > #include "rdma.h" > +#include > > static int rd_argc(struct rd *rd) > { > @@

Re: [PATCH net-next A 0/5] further sfp/phylink updates

2018-01-02 Thread David Miller
From: Russell King - ARM Linux Date: Fri, 29 Dec 2017 12:14:51 + > This series: > - cleans up printing of module information > - improves the transceiver capability decoding, getting rid of the > guessing by connector type, improves direct-attach cable support >

Re: [patch iproute2 v4 2/3] tc: Add -bs option to batch mode

2018-01-02 Thread Chris Mi
On Tue, Jan 02, 2018 at 11:28:03PM +0900, Chris Mi wrote: @@ -240,23 +244,49 @@ static int batch(const char *name) } cmdlineno = 0; - while (getcmdline(, , stdin) != -1) { + if (getcmdline(, , stdin) == -1) + goto Exit; + do { char

[PATCH v2 net,stable 2/2] net: fec: defer probe if regulator is not ready

2018-01-02 Thread Fugang Duan
Defer probe if regulator is not ready. E.g. some regulator is fixed regulator controlled by i2c expander gpio, the i2c device may be probed after the driver, then it should handle the case of defer probe error. Signed-off-by: Fugang Duan ---

[PATCH v2 net,stable 1/2] net: fec: restore dev_id in the cases of probe error

2018-01-02 Thread Fugang Duan
The static variable dev_id always plus one before netdev registerred. It should restore the dev_id value in the cases of probe error. Signed-off-by: Fugang Duan --- drivers/net/ethernet/freescale/fec_main.c | 1 + 1 file changed, 1 insertion(+) diff --git

[PATCH v2 net,stable 0/2] net: fec: clean up in the cases of probe error

2018-01-02 Thread Fugang Duan
The simple patches just clean up in the cases of probe error like restore dev_id and handle the defer probe when regulator is still not ready. v2: * Fabio Estevam's comment to suggest split v1 to separate patches. Fugang Duan (2): net: fec: restore dev_id in the cases of probe error net:

Re: [PATCH net-next 0/2] Enable virtio to act as a master for a passthru device

2018-01-02 Thread Jakub Kicinski
On Tue, 2 Jan 2018 16:35:36 -0800, Sridhar Samudrala wrote: > This patch series enables virtio to switch over to a VF datapath when a VF > netdev is present with the same MAC address. It allows live migration of a VM > with a direct attached VF without the need to setup a bond/team between a > VF

Re: ACPI issues on cold power on [bisected]

2018-01-02 Thread Joonsoo Kim
On Tue, Jan 02, 2018 at 11:25:01AM +0100, Rafael J. Wysocki wrote: > On Tue, Jan 2, 2018 at 3:54 AM, Joonsoo Kim wrote: > > On Fri, Dec 29, 2017 at 04:36:59PM +, Jonathan McDowell wrote: > >> On Fri, Dec 22, 2017 at 09:21:09AM +0900, Joonsoo Kim wrote: > >> > On Fri,

Re: [patch net-next v4 00/10] net: sched: allow qdiscs to share filter block instances

2018-01-02 Thread David Ahern
On 1/2/18 12:49 PM, Jiri Pirko wrote: > DaveA, please consider following example: > > $ tc qdisc add dev ens7 ingress > $ tc qdisc > qdisc ingress : dev ens7 parent :fff1 block 1 > > Now I have one device with one qdisc attached. > > I will add some filters, for example: > $ tc filter

Re: [PATCH v3 net-next 2/5] net: tracepoint: replace tcp_set_state tracepoint with inet_sock_set_state tracepoint

2018-01-02 Thread Yafang Shao
On Wed, Jan 3, 2018 at 3:46 AM, Brendan Gregg wrote: > On Sat, Dec 30, 2017 at 7:06 PM, Yafang Shao wrote: >> On Sun, Dec 31, 2017 at 6:33 AM, Brendan Gregg >> wrote: >>> On Tue, Dec 19, 2017 at 7:12 PM, Yafang Shao

Re: [PATCHv3 1/2] capability: introduce sysctl for controlled user-ns capability whitelist

2018-01-02 Thread महेश बंडेवार
On Sat, Dec 30, 2017 at 12:50 AM, Michael Kerrisk (man-pages) wrote: > Hello Mahesh, > > On 12/05/2017 11:31 PM, Mahesh Bandewar wrote: >> From: Mahesh Bandewar >> >> Add a sysctl variable kernel.controlled_userns_caps_whitelist. This >> takes input as

Re: [PATCHv3 0/2] capability controlled user-namespaces

2018-01-02 Thread महेश बंडेवार
Hello Michael, I really don't want to turn this into how-to-hack guide but I do see few points in your argument to make the case clearer. Please see the comments inline. On Sat, Dec 30, 2017 at 12:50 AM, Michael Kerrisk (man-pages) wrote: > Hello Mahesh, > > On

Re: [PATCHv3 0/2] capability controlled user-namespaces

2018-01-02 Thread महेश बंडेवार
On Sat, Dec 30, 2017 at 12:31 AM, James Morris wrote: > On Wed, 27 Dec 2017, Mahesh Bandewar (महेश बंडेवार) wrote: > >> Hello James, >> >> Seems like I missed your name to be added into the review of this >> patch series. Would you be willing be pull this into the

RE: [PATCH net,stable 1/1] net: fec: defer probe if regulator is not ready

2018-01-02 Thread Andy Duan
From: Fabio Estevam Sent: Tuesday, January 02, 2018 6:21 PM >Hi Andy, > >On Tue, Jan 2, 2018 at 7:57 AM, Fugang Duan wrote: > >> @@ -3576,6 +3580,7 @@ static int fec_enet_get_irq_cnt(struct >platform_device *pdev) >> of_node_put(phy_node); >>

[PATCH] rtlwifi: rtl8723de: Add firmware for new driver/device

2018-01-02 Thread Larry Finger
A driver for the RTL8723DE is nearing submission to staging. This commit supplies the firmware for it. Signed-off-by: Larry Finger Cc: Ping-Ke Shih --- WHENCE | 9 + rtlwifi/rtl8723defw.bin | Bin 0 -> 27726 bytes 2

Re: general protection fault in __netlink_ns_capable

2018-01-02 Thread Andrei Vagin
On Tue, Jan 02, 2018 at 10:58:01AM -0800, syzbot wrote: > Hello, > > syzkaller hit the following crash on > 75aa5540627fdb3d8f86229776ea87f995275351 > git://git.cmpxchg.org/linux-mmots.git/master > compiler: gcc (GCC) 7.1.1 20170620 > .config is attached > Raw console output is attached. > C

[PATCH net-next 0/2] Enable virtio to act as a master for a passthru device

2018-01-02 Thread Sridhar Samudrala
This patch series enables virtio to switch over to a VF datapath when a VF netdev is present with the same MAC address. It allows live migration of a VM with a direct attached VF without the need to setup a bond/team between a VF and virtio net device in the guest. The hypervisor needs to unplug

[PATCH net-next 1/2] virtio_net: Introduce VIRTIO_NET_F_MASTER feature bit

2018-01-02 Thread Sridhar Samudrala
This feature bit can be used by hypervisor to indicate virtio_net device to act as a master for a directly attached passthru device with the same MAC address. Signed-off-by: Sridhar Samudrala --- drivers/net/virtio_net.c| 3 ++-

[PATCH net-next 2/2] virtio_net: Extend virtio to use VF datapath when available

2018-01-02 Thread Sridhar Samudrala
This patch enables virtio to switch over to a VF datapath when a VF netdev is present with the same MAC address. It allows live migration of a VM with a direct attached VF without the need to setup a bond/team between a VF and virtio net device in the guest. The hypervisor needs to unplug the VF

Re: [net-next PATCH] net: ptr_ring: otherwise safe empty checks can overrun array bounds

2018-01-02 Thread John Fastabend
On 01/02/2018 03:12 PM, Michael S. Tsirkin wrote: > On Tue, Jan 02, 2018 at 01:27:23PM -0800, John Fastabend wrote: >> On 01/02/2018 09:17 AM, Michael S. Tsirkin wrote: >>> On Tue, Jan 02, 2018 at 07:01:33PM +0200, Michael S. Tsirkin wrote: On Tue, Jan 02, 2018 at 11:52:19AM -0500, David

Re: Linux ECN Handling

2018-01-02 Thread Steve Ibanez
Hi Neal, Sorry, my last email was incorrect. It turns out the default tcp congestion control alg that was being used on my client machines was cubic instead of dctcp. That is why tp->processing_cwr field was never set in the tcp_rcv_established function. I've changed the default back to dctcp on

Re: [net-next PATCH] net: ptr_ring: otherwise safe empty checks can overrun array bounds

2018-01-02 Thread Michael S. Tsirkin
On Tue, Jan 02, 2018 at 01:27:23PM -0800, John Fastabend wrote: > On 01/02/2018 09:17 AM, Michael S. Tsirkin wrote: > > On Tue, Jan 02, 2018 at 07:01:33PM +0200, Michael S. Tsirkin wrote: > >> On Tue, Jan 02, 2018 at 11:52:19AM -0500, David Miller wrote: > >>> From: John Fastabend

[PATCH iproute2-next] ip: link: add support for netdevsim device type

2018-01-02 Thread Jakub Kicinski
netdevsim is a new software device for testing kernel APIs without any hardware attached. Allow users to create such devices. Signed-off-by: Jakub Kicinski Reviewed-by: Quentin Monnet --- I think I forgot to send this out..

[PATCH bpf-next 3/3] tools: bpftool: remove new lines from errors

2018-01-02 Thread Jakub Kicinski
It's a little bit unusual for kernel style, but we add the new line character to error strings inside the p_err() function. We do this because new lines at the end of error strings will break JSON output. Fix a few p_err("..\n") which snuck in recently. Fixes: 5ccda64d38cc ("bpftool: implement

[PATCH bpf-next 1/3] tools: bpftool: rename cgroup list -> show in the code

2018-01-02 Thread Jakub Kicinski
So far we have used "show" as a keyword for listing programs and maps. Use the word "show" in the code for cgroups too, next commit will alias show and list. Signed-off-by: Jakub Kicinski Reviewed-by: Quentin Monnet ---

[PATCH bpf-next 0/3] tools: bpftool: alias "show" and "list" and fix errors in JSON

2018-01-02 Thread Jakub Kicinski
Hi! This series addresses small issues that snuck through the review of cgroup code. "list" and "show" are now made aliases to satisfy all users. Small fix to errors printed is needed, errors can't contain new line characters, otherwise JSON will break. Jakub Kicinski (3): tools: bpftool:

[PATCH bpf-next 2/3] tools: bpftool: alias show and list commands

2018-01-02 Thread Jakub Kicinski
iproute2 seems to accept show and list as aliases. Let's do the same thing, and by allowing both bring cgroup syntax back in line with maps and progs. Signed-off-by: Jakub Kicinski Reviewed-by: Quentin Monnet ---

Re: [PATCH] net: systemport: Delete an error message for a failed memory allocation in two functions

2018-01-02 Thread Florian Fainelli
On 01/01/2018 08:54 AM, SF Markus Elfring wrote: > From: Markus Elfring > Date: Mon, 1 Jan 2018 17:50:02 +0100 > > Omit an extra message for a memory allocation failure in these functions. > > This issue was detected by using the Coccinelle software. > >

Re: [PATCH v17 0/4] Replace PCI pool by DMA pool API

2018-01-02 Thread Bjorn Helgaas
On Tue, Jan 02, 2018 at 06:53:52PM +0100, Romain Perier wrote: > The current PCI pool API are simple macro functions direct expanded to > the appropriate dma pool functions. The prototypes are almost the same > and semantically, they are very similar. I propose to use the DMA pool > API directly

Re: [PATCH net] vxlan: trivial indenting fix.

2018-01-02 Thread Stephen Hemminger
On Tue, 2 Jan 2018 14:05:19 -0800 William Tu wrote: > Fix indentation of reserved_flags2 field in vxlanhdr_gpe. > > Signed-off-by: William Tu > --- > include/net/vxlan.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git

[PATCH net] vxlan: trivial indenting fix.

2018-01-02 Thread William Tu
Fix indentation of reserved_flags2 field in vxlanhdr_gpe. Signed-off-by: William Tu --- include/net/vxlan.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/net/vxlan.h b/include/net/vxlan.h index 13223396dc64..f96391e84a8a 100644 ---

[PATCH net] sctp: fix error path in sctp_stream_init

2018-01-02 Thread Marcelo Ricardo Leitner
syzbot noticed a NULL pointer dereference panic in sctp_stream_free() which was caused by an incomplete error handling in sctp_stream_init(). By not clearing stream->outcnt, it made a for() in sctp_stream_free() think that it had elements to free, but not, leading to the panic. As suggested by

[PATCH net] sctp: fix handling of ICMP Frag Needed for too small MTUs

2018-01-02 Thread Marcelo Ricardo Leitner
syzbot reported a hang involving SCTP, on which it kept flooding dmesg with the message: [ 246.742374] sctp: sctp_transport_update_pmtu: Reported pmtu 508 too low, using default minimum of 512 That happened because whenever SCTP hits an ICMP Frag Needed, it tries to adjust to the new MTU and

Re: [PATCH net-next v3] net: sched: fix skb leak in dev_requeue_skb()

2018-01-02 Thread John Fastabend
On 01/02/2018 10:49 AM, David Miller wrote: > From: Wei Yongjun > Date: Wed, 27 Dec 2017 17:05:52 +0800 > >> When dev_requeue_skb() is called with bluked skb list, only the > ^^ > > "bulked" > >> first skb of the list will be

Re: [PATCH iproute2 v2 2/3] link_iptnl: Print tunnel mode

2018-01-02 Thread Serhey Popovych
Stephen Hemminger wrote: > On Tue, 2 Jan 2018 23:02:45 +0200 > Serhey Popovych wrote: > >> Tunnel mode does not appear in parameters print for iptnl >> supported tunnels like ipip and sit, while printed for >> ip6tnl. >> >> Print tunnel mode as "proto" field name for

[PATCH] netcp_ethss: Delete error messages for a failed memory allocation in three functions

2018-01-02 Thread SF Markus Elfring
From: Markus Elfring Date: Tue, 2 Jan 2018 22:08:50 +0100 Omit extra messages for a memory allocation failure in these functions. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring ---

[PATCH iproute2 v2 1/3] link_iptnl: Kill code duplication

2018-01-02 Thread Serhey Popovych
Both sit and ipip "mode" parameter handling nearly the same. Except for sit we have "ip6ip" mode: check it only when configuring sit. Note that there is no need strcmp(lu->id, "ipip"): if it is not sit it is "ipip" because we have only these two link util defined in module. Signed-off-by: Serhey

[PATCH iproute2 v2 2/3] link_iptnl: Print tunnel mode

2018-01-02 Thread Serhey Popovych
Tunnel mode does not appear in parameters print for iptnl supported tunnels like ipip and sit, while printed for ip6tnl. Print tunnel mode as "proto" field name for JSON and without any name when printing to cli to follow ip6tnl behaviour. For non JSON output we have: $ ip -d link show dev

[PATCH iproute2 v2 3/3] link_iptnl: Open "encap" JSON object

2018-01-02 Thread Serhey Popovych
It seems missing pair of open_json_object()/close_json_object() in iptnl implementation. Note that we open "encap" JSON object in ip6tnl. Signed-off-by: Serhey Popovych --- ip/link_iptnl.c |1 + 1 file changed, 1 insertion(+) diff --git a/ip/link_iptnl.c

[PATCH iproute2 v2 0/3] iptnl/tunnel: Open JSON section, kill code duplication and print iptnl mode

2018-01-02 Thread Serhey Popovych
In this series I present following improvements and fixes: 1) Add missing open_json_context() to link_iptnl.c for "encap" options. 2) Get rid of code duplication when parsing tunnel mode parameters in link_iptnl.c. 3) Add code to link_iptnl.c to print tunnel mode to be

Re: [net-next PATCH] net: ptr_ring: otherwise safe empty checks can overrun array bounds

2018-01-02 Thread John Fastabend
On 01/02/2018 09:17 AM, Michael S. Tsirkin wrote: > On Tue, Jan 02, 2018 at 07:01:33PM +0200, Michael S. Tsirkin wrote: >> On Tue, Jan 02, 2018 at 11:52:19AM -0500, David Miller wrote: >>> From: John Fastabend >>> Date: Wed, 27 Dec 2017 19:50:25 -0800 >>> When

[net-next v2] ipv6: sr: export some functions of seg6local

2018-01-02 Thread Ahmed Abdelsalam
Some functions of seg6local are very useful to process SRv6 encapsulated packets This patch exports some functions of seg6local that are useful and can be re-used at different parts of the kernel. The set of exported functions are: (1) seg6_get_srh() (2) seg6_advance_nextseg() (3)

  1   2   3   4   >