Re: [PATCH net-next 1/3] ethtool: Ensure new ring parameters are within bounds during SRINGPARAM

On Tue, 9 Jan 2018 09:30:05 +0200 Tariq Toukan wrote: > >> diff --git a/net/core/ethtool.c b/net/core/ethtool.c > >> index 50a79203043b..9ea7cd52fde0 100644 > >> --- a/net/core/ethtool.c > >> +++ b/net/core/ethtool.c > >> @@ -1704,14 +1704,23 @@ static int

[patch iproute2 v7 2/2] tc: Add batchsize feature for filter and actions

Currently in tc batch mode, only one command is read from the batch file and sent to kernel to process. With this support, at most 128 commands can be accumulated before sending to kernel. Now it only works for the following successive commands: filter and actions add/delete/change/replace.

Re: [PATCH net-next 1/3] ethtool: Ensure new ring parameters are within bounds during SRINGPARAM

On 09/01/2018 4:23 AM, Jakub Kicinski wrote: On Mon, 8 Jan 2018 16:00:24 +0200, Tariq Toukan wrote: From: Eugenia Emantayev Add a sanity check to ensure that all requested ring parameters are within bounds, which should reduce errors in driver implementation. (y)

Re: [PATCH] ath9k: add a quirk to set use_msi automatically

AceLan Kao writes: > Some platform(BIOS) blocks legacy interrupts (INTx), and only allows MSI > for WLAN device. So adding a quirk to list those machines and set > use_msi automatically. > Adding the following platforms to the quirk. >Dell Inspiron 24-3460 >Dell

Re: [PATCH net-next v3 06/10] net/mlx5e: Change Mellanox references in DIM code

On 01/08/2018 11:06 PM, Saeed Mahameed wrote: On 01/08/2018 10:13 PM, Andy Gospodarek wrote: From: Andy Gospodarek Change all appropriate mlx5_am* and MLX5_AM* references to net_dim and NET_DIM, respectively, in code that handles dynamic interrupt moderation.  Also

Re: [PATCH net-next v3 09/10] bnxt_en: add support for software dynamic interrupt moderation

On Mon, Jan 8, 2018 at 10:13 PM, Andy Gospodarek wrote: > From: Andy Gospodarek > > This implements the changes needed for the bnxt_en driver to add support > for dynamic interrupt moderation per ring. > > This does add additional counters in the receive

Re: [PATCH net-next v3 06/10] net/mlx5e: Change Mellanox references in DIM code

On 01/08/2018 10:13 PM, Andy Gospodarek wrote: From: Andy Gospodarek Change all appropriate mlx5_am* and MLX5_AM* references to net_dim and NET_DIM, respectively, in code that handles dynamic interrupt moderation. Also change all references from 'am' to 'dim' when used

[patch iproute2 v7 1/2] lib/libnetlink: Add functions rtnl_talk_msg and rtnl_talk_iov

rtnl_talk can only send a single message to kernel. Add two functions rtnl_talk_msg and rtnl_talk_iov that can send multiple messages to kernel. rtnl_talk_msg takes struct msghdr * as argument. rtnl_talk_iov takes struct iovec * and iovlen as arguments. Signed-off-by: Chris Mi

[patch iproute2 v7 0/2] tc: Add batchsize feature to batch mode

Currently in tc batch mode, only one command is read from the batch file and sent to kernel to process. With this patchset, at most 128 commands can be accumulated before sending to kernel. We introduced two new functions in patch 1 to support for sending multiple messages. In patch 2, we add

Re: [PATCH net-next v3 00/10] net: create dynamic software irq moderation library

On 1/9/2018 8:13 AM, Andy Gospodarek wrote: From: Andy Gospodarek This converts the dynamic interrupt moderation library from the mlx5e driver into a library so it can be used by any driver. The penultimate patch in this set adds support for thiw new dynamic interrupt

[PATCH] ipvlan: fix ipvlan MTU limits

From: Keefe Liu The MTU of ipvlan interface should not bigger than the phy device, When we run following scripts, we will find there are some problems. Step1: ip link add link eth0 name ipv1 type ipvlan mode l2 ip netns add net1 ip link set dev ipv1

RE: [patch iproute2 v6 2/3] tc: Add -bs option to batch mode

> -Original Message- > From: Marcelo Ricardo Leitner [mailto:marcelo.leit...@gmail.com] > Sent: Saturday, January 6, 2018 3:15 AM > To: David Ahern > Cc: Chris Mi ; netdev@vger.kernel.org; > gerlitz...@gmail.com; step...@networkplumber.org >

[net-next 05/10] net/mlx5e: IPoIB, Use correct timestamp in child receive flow

From: Feras Daoud The current implementation takes the child timestamp object from the parent since the rq in mlx5i_complete_rx_cqe belongs to the parent. This change fixes the issue by taking the correct timestamp. Fixes: 7e7f4780c340 ("net/mlx5e: IPoIB, Use hash-table to

[net-next 02/10] net/mlx5: Hairpin pair core object setup

From: Or Gerlitz Low level code to setup hairpin pair core object, deals with: - create hairpin RQs/SQs - destroy hairpin RQs/SQs - modifying hairpin RQs/SQs - pairing (rst2rdy) and unpairing (rdy2rst) Unlike conventional RQs/SQs, the memory used for the packet and

[net-next 07/10] net/mlx5e: IPoIB, Add ethtool support to get child time stamping parameters

From: Feras Daoud Add support to get time stamping capabilities using ethtool for child interface. Usage example: ethtool -T CHILD-DEVNAME This change reuses the functionality of parent devices and does not introduce any new logic. Signed-off-by: Feras Daoud

[pull request][net-next 00/10] Mellanox, mlx5 updates 2018-01-08

Hi Dave, This series includes updates for mlx5 driver, for full information please see tag log message below. The series doesn't cause any conflict with Andy's "net: create dynamic software irq moderation library". Both merge together seamlessly. Please pull and let me know if there's any

[net-next 08/10] net/mlx5e: IPoIB, Fix spelling mistake "functionts" -> "functions"

From: Gal Pressman Fix trivial spelling mistake: "functionts" -> "functions". Signed-off-by: Gal Pressman Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core/ipoib/ipoib.h | 2 +- 1 file changed, 1 insertion(+),

[net-next 04/10] net/mlx5e: Support offloading TC NIC hairpin flows

From: Or Gerlitz We refer to TC NIC rule that involves forwarding as "hairpin". All hairpin rules from the current NIC device (called "func" in the code) to a given NIC device ("peer") are steered into the same hairpin RQ/SQ pair. The hairpin pair is set on demand and

[net-next 03/10] net/mlx5e: Basic setup of hairpin object

From: Or Gerlitz Add the code to do basic setup for hairpin object which will later serve offloading TC flows. This includes calling the mlx5 core to create/destroy the hairpin pair object and setting the HW transport objects that will be used for steering matched flows

[net-next 09/10] net/core: Add drop counters to VF statistics

From: Eugenia Emantayev Modern hardware can decide to drop packets going to/from a VF. Add receive and transmit drop counters to be displayed at hypervisor layer in iproute2 per VF statistics. Signed-off-by: Eugenia Emantayev Signed-off-by: Saeed

[net-next 10/10] net/mlx5e: E-switch, Add steering drop counters

From: Eugenia Emantayev Add flow counters to count packets dropped due to drop rules configured in eswitch egress and ingress ACLs. These counters will count VFs violations and incoming traffic drops. Will be presented on hypervisor via standard 'ip -s link show' command.

[net-next 06/10] net/mlx5e: IPoIB, Add PTP ioctl support for child interface

From: Feras Daoud Add support to control precision time protocol on child interfaces using ioctl. This commit changes the following: - Change parent ioctl function to be non static - Reuse the parent ioctl function in child devices Signed-off-by: Feras Daoud

[net-next 01/10] net/mlx5: Add hairpin definitions to the FW API

From: Or Gerlitz Add hairpin definitions to the IFC file. This includes the HCA ID, few HCA hairpin capabilities, new fields in RQ/SQ used later for the pairing and the WQ hairpin data size attribute. Signed-off-by: Or Gerlitz Signed-off-by: Saeed

RE: [patch iproute2 v6 1/3] lib/libnetlink: Add a function rtnl_talk_msg

> -Original Message- > From: David Ahern [mailto:dsah...@gmail.com] > Sent: Saturday, January 6, 2018 1:51 AM > To: Chris Mi ; netdev@vger.kernel.org > Cc: gerlitz...@gmail.com; step...@networkplumber.org; > marcelo.leit...@gmail.com > Subject: Re: [patch iproute2 v6

Re: iscsi target regression due to "tcp: remove prequeue support" patch

Hi MNC & Florian, (Adding net-dev + DaveM CC') Catching up on pre-holiday threads, thanks for the heads up. Comments below. On Wed, 2017-12-13 at 23:56 -0600, Mike Christie wrote: > Hey Nick and Florian, > > Starting in 4.14 iscsi logins will fail around 50% of the time. > > I git bisected

[PATCH net-next 2/2] net: hns3: report the function type the same line with hns3_nic_get_stats64

The function type should be on the same line with the function name, or it may cause display error if a patch edit the function. There is am example following: https://www.spinics.net/lists/netdev/msg476141.html Signed-off-by: Peng Li ---

[PATCH net-next 0/2] code improvements in HNS3 driver

This patchset fixes 2 comments for community review. [patch 1/2] reverts "net: hns3: Add packet statistics of netdev" reported by Jakub Kicinski and David Miller. [patch 2/2] reports the function type the same line with hns3_nic_get_stats64, reported by Andrew Lunn. Peng Li (2): Revert "net:

[PATCH net-next 1/2] Revert "net: hns3: Add packet statistics of netdev"

This reverts commit 8491000754796c838a0081c267f9dd54ad2ccba3. It is duplicate to add statistics of netdev for ethtool -S. Signed-off-by: Peng Li --- drivers/net/ethernet/hisilicon/hns3/hns3_ethtool.c | 80 +- 1 file changed, 1 insertion(+), 79

[PATCH net-next v3 06/10] net/mlx5e: Change Mellanox references in DIM code

From: Andy Gospodarek Change all appropriate mlx5_am* and MLX5_AM* references to net_dim and NET_DIM, respectively, in code that handles dynamic interrupt moderation. Also change all references from 'am' to 'dim' when used as local variables and add generic profile

[PATCH net-next v3 05/10] net/mlx5e: Move generic functions to new file

From: Andy Gospodarek These functions were identified as ones that could be made generic and used by multiple drivers. Most of the contents of en_rx_am.c are moved to net_dim.c. Signed-off-by: Andy Gospodarek Acked-by: Tal Gilboa

[PATCH net-next v3 03/10] net/mlx5e: Remove rq references in mlx5e_rx_am

From: Andy Gospodarek This makes mlx5e_am_sample more generic so that it can be called easily from a driver that does not use the same data structure to store these values in a single structure. Signed-off-by: Andy Gospodarek Acked-by: Tal Gilboa

[PATCH net-next v3 10/10] MAINTAINERS: add entry for Dynamic Interrupt Moderation

From: Andy Gospodarek Signed-off-by: Andy Gospodarek Signed-off-by: Tal Gilboa Acked-by: Saeed Mahameed --- MAINTAINERS | 5 + 1 file changed, 5 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index

[PATCH net-next v3 02/10] net/mlx5e: Move interrupt moderation forward declarations

From: Andy Gospodarek Move these to newly created file to prepare to move these functions to a library. Signed-off-by: Andy Gospodarek Acked-by: Tal Gilboa Acked-by: Saeed Mahameed ---

[PATCH net-next v3 07/10] net/mlx5e: Move dynamic interrupt coalescing code to include/linux

From: Andy Gospodarek This move allows drivers to add private structure elements to track the number of packets, bytes, and interrupts events per ring. A driver also defines a workqueue handler to act on this collected data once per poll and modify the coalescing parameters

[PATCH net-next v3 01/10] net/mlx5e: Move interrupt moderation structs to new file

From: Andy Gospodarek Create new header file to prepare to move code that handles irq moderation to a library that lives in a header file. Signed-off-by: Andy Gospodarek Acked-by: Tal Gilboa Acked-by: Saeed Mahameed

[PATCH net-next v3 08/10] net/dim: use struct net_dim_sample as arg to net_dim

From: Andy Gospodarek Simplify the arguments net_dim() by formatting them into a struct net_dim_sample before calling the function. Signed-off-by: Andy Gospodarek Suggested-by: Tal Gilboa Acked-by: Tal Gilboa

[PATCH net-next v3 09/10] bnxt_en: add support for software dynamic interrupt moderation

From: Andy Gospodarek This implements the changes needed for the bnxt_en driver to add support for dynamic interrupt moderation per ring. This does add additional counters in the receive path, but testing shows that any additional instructions are offset by throughput gain

[PATCH net-next v3 04/10] net/mlx5e: Move AM logic enums

From: Andy Gospodarek More movement to help make this code more generic. Signed-off-by: Andy Gospodarek Acked-by: Tal Gilboa Acked-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core/en_dim.h | 26

[PATCH net-next v3 00/10] net: create dynamic software irq moderation library

From: Andy Gospodarek This converts the dynamic interrupt moderation library from the mlx5e driver into a library so it can be used by any driver. The penultimate patch in this set adds support for thiw new dynamic interrupt moderation library in the bnxt_en driver and the

Re: WARNING: held lock freed!

On Mon, Jan 8, 2018 at 8:09 PM, Marcelo Ricardo Leitner wrote: > On Mon, Jan 08, 2018 at 06:01:14PM +0800, Xin Long wrote: >> On Mon, Jan 8, 2018 at 6:58 AM, syzbot >> wrote: >> > Hello, >> > >> > syzkaller hit the

[PATCH v2 bpf] bpf: introduce BPF_JIT_ALWAYS_ON config

The BPF interpreter has been used as part of the spectre 2 attack CVE-2017-5715. A quote from goolge project zero blog: "At this point, it would normally be necessary to locate gadgets in the host kernel code that can be used to actually leak data by reading from an attacker-controlled location,

Re: [PATCH 16/18] net: mpls: prevent bounds-check bypass via speculative execution

On Mon, Jan 8, 2018 at 8:13 PM, Linus Torvalds wrote: > > # carry will be clear if idx >= max > cmpq %idx,%max Bah. Other way around. cmpq %max,%idx I'm a moron. > # mask will be clear if carry was clear, ~0 otherwise > sbbq %mask,%mask >

Re: [PATCH 16/18] net: mpls: prevent bounds-check bypass via speculative execution

On Mon, Jan 8, 2018 at 7:42 PM, Dan Williams wrote: > > originally from Linus and tweaked by Alexei and I: Sadly, that tweak - while clever - is wrong. > unsigned long _mask = ~(long)(_m - 1 - _i) >> BITS_PER_LONG - 1;\ Why? Because "(long)(_m-1-_i)" is not

Re: [PATCH 16/18] net: mpls: prevent bounds-check bypass via speculative execution

On Mon, Jan 8, 2018 at 7:11 PM, Eric W. Biederman wrote: > Dan Williams writes: > >> Static analysis reports that 'index' may be a user controlled value that >> is used as a data dependency reading 'rt' from the 'platform_label' >> array. In

Re: [v2] net: gianfar_ptp: move set_fipers() to spinlock protecting area

On Tue, Jan 09, 2018 at 11:02:33AM +0800, Yangbo Lu wrote: > set_fipers() calling should be protected by spinlock in > case that any interrupt breaks related registers setting > and the function we expect. This patch is to move set_fipers() > to spinlock protecting area in ptp_gianfar_adjtime(). >

Re: [PATCH] net: gianfar_ptp: move set_fipers() to spinlock protecting area

On Mon, Jan 08, 2018 at 10:53:40AM -0200, Fabio Estevam wrote: > On Mon, Jan 8, 2018 at 8:13 AM, Yangbo Lu wrote: > > set_fipers() calling should be protected by spinlock. > > This patch is to move set_fipers() to spinlock protecting > > area in ptp_gianfar_adjtime() function.

Re: [PATCH net-next 12/20] net: hns3: Add packet statistics of netdev

On 2018/1/9 11:06, David Miller wrote: From: "lipeng (Y)" Date: Tue, 9 Jan 2018 10:48:04 +0800 So I think it is OK if you can revert [patch 12/20 ]("net: hns3: Add packet statistics of netdev"). I think it is OK if you send the revert patch, which is what I am asking

RE: [PATCH] net: gianfar_ptp: move set_fipers() to spinlock protecting area

> -Original Message- > From: Fabio Estevam [mailto:feste...@gmail.com] > Sent: 2018年1月8日 20:54 > To: Y.b. Lu > Cc: Claudiu Manoil ; Richard Cochran > ; netdev@vger.kernel.org; linux-kernel >

[v2] net: gianfar_ptp: move set_fipers() to spinlock protecting area

set_fipers() calling should be protected by spinlock in case that any interrupt breaks related registers setting and the function we expect. This patch is to move set_fipers() to spinlock protecting area in ptp_gianfar_adjtime(). Signed-off-by: Yangbo Lu --- Changes for v2:

[GIT] Networking

Highlights: 1) Frag and UDP handling fixes in i40e driver, from Amritha Nambiar and Alexander Duyck. 2) Undo unintentional UAPI change in netfilter conntrack, from Florian Westphal. 3) Revert a change to how error codes are returned from dev_get_valid_name(), it broke some apps. 4)

Re: [PATCH 16/18] net: mpls: prevent bounds-check bypass via speculative execution

Dan Williams writes: > Static analysis reports that 'index' may be a user controlled value that > is used as a data dependency reading 'rt' from the 'platform_label' > array. In order to avoid potential leaks of kernel memory values, block > speculative execution of

Re: [PATCH net-next 12/20] net: hns3: Add packet statistics of netdev

From: "lipeng (Y)" Date: Tue, 9 Jan 2018 10:48:04 +0800 > So I think it is OK if you can revert [patch 12/20 ]("net: hns3: Add > packet statistics of netdev"). I think it is OK if you send the revert patch, which is what I am asking for :-)

Re: [PATCH net-next v2 1/6] net: Fix netdev_WARN_ONCE macro

From: Joe Perches Date: Mon, 08 Jan 2018 18:42:01 -0800 > On Sun, 2018-01-07 at 12:08 +0200, Gal Pressman wrote: >> netdev_WARN_ONCE is broken (whoops..), this fix will remove the >> unnecessary "condition" parameter, add the missing comma and change >> "arg" to "args". >> >>

Re: [PATCH v2] openvswitch: Trim off padding before L3+ netfilter processing

On 1/6/18 10:57, Pravin Shelar wrote: > On Fri, Jan 5, 2018 at 10:59 PM, Ed Swierk wrote: >> >> >> On Jan 5, 2018 22:17, "Pravin Shelar" wrote: >> >> On Fri, Jan 5, 2018 at 3:20 PM, Ed Swierk >> wrote: >>> On Fri, Jan 5,

Re: [PATCH net-next 12/20] net: hns3: Add packet statistics of netdev

On 2018/1/9 9:54, David Miller wrote: From: Jakub Kicinski Date: Mon, 8 Jan 2018 17:50:21 -0800 Oh, I only noticed this extra misleading comment now. Unless each queue has a netdev, I don't see how these are per-queue. If it isn't per-queue I want this change reverted.

Re: [PATCH net-next v2 1/6] net: Fix netdev_WARN_ONCE macro

On Sun, 2018-01-07 at 12:08 +0200, Gal Pressman wrote: > netdev_WARN_ONCE is broken (whoops..), this fix will remove the > unnecessary "condition" parameter, add the missing comma and change > "arg" to "args". > > Fixes: 375ef2b1f0d0 ("net: Introduce netdev_*_once functions") > Signed-off-by: Gal

RE: [PATCH net-next v2 5/6] bnx2x: Replace WARN_ONCE with netdev_WARN_ONCE

-Original Message- From: netdev-ow...@vger.kernel.org [mailto:netdev-ow...@vger.kernel.org] On Behalf Of Gal Pressman Sent: 07 January 2018 15:39 To: David S. Miller Cc: netdev@vger.kernel.org; Tariq Toukan ; Saeed Mahameed

RE: [patch iproute2 v6 0/3] tc: Add -bs option to batch mode

> -Original Message- > From: n...@orbyte.nwl.cc [mailto:n...@orbyte.nwl.cc] On Behalf Of Phil > Sutter > Sent: Monday, January 8, 2018 9:32 PM > To: Chris Mi > Cc: dsah...@gmail.com; marcelo.leit...@gmail.com; > netdev@vger.kernel.org; gerlitz...@gmail.com; >

Re: [PATCH bpf-next] bpf: introduce BPF_JIT_ALWAYS_ON config

On 1/8/18 4:02 PM, Jakub Kicinski wrote: On Mon, 8 Jan 2018 22:59:04 +0100, Daniel Borkmann wrote: @@ -1453,6 +1457,11 @@ struct bpf_prog *bpf_prog_select_runtime(struct bpf_prog *fp, int *err) */ *err = bpf_check_tail_call(fp); +#ifdef CONFIG_BPF_JIT_ALWAYS_ON + if

Re: [PATCH net-next 1/3] ethtool: Ensure new ring parameters are within bounds during SRINGPARAM

On Mon, 8 Jan 2018 16:00:24 +0200, Tariq Toukan wrote: > From: Eugenia Emantayev > > Add a sanity check to ensure that all requested ring parameters > are within bounds, which should reduce errors in driver implementation. (y) > Signed-off-by: Eugenia Emantayev

Re: [PATCH 07/18] [media] uvcvideo: prevent bounds-check bypass via speculative execution

On Mon, Jan 8, 2018 at 3:23 AM, Laurent Pinchart wrote: > Hi Dan, > > Thank you for the patch. > > On Saturday, 6 January 2018 03:10:32 EET Dan Williams wrote: >> Static analysis reports that 'index' may be a user controlled value that >> is used as a data

Re: Subject: [RFC][PATCH 04/11] stmmac: fix breakage in stmmac_hw_setup()

From: Al Viro Date: Fri, 05 Jan 2018 19:31:58 + > Since "drivers: net: stmmac: reworking the PCS code" ->pcs_ctrl_ane() > had been taking iomem address to access as the first argument; its > predecessor (->ctrl_ane()) used to take struct mac_device_info instead. > >

Re: [RESEND PATCH 2/3] net: ovs: remove unused hardirq.h

From: "Yang Shi" Date: Tue, 09 Jan 2018 03:52:53 +0800 > Preempt counter APIs have been split out, currently, hardirq.h just > includes irq_enter/exit APIs which are not used by openvswitch at all. > > So, remove the unused hardirq.h. > > Signed-off-by: Yang Shi

Re: [RESEND PATCH 3/3] net: tipc: remove unused hardirq.h

From: "Yang Shi" Date: Tue, 09 Jan 2018 03:52:54 +0800 > Preempt counter APIs have been split out, currently, hardirq.h just > includes irq_enter/exit APIs which are not used by TIPC at all. > > So, remove the unused hardirq.h. > > Signed-off-by: Yang Shi

Re: [RESEND PATCH 1/3] net: caif: remove unused hardirq.h

From: "Yang Shi" Date: Tue, 09 Jan 2018 03:52:52 +0800 > Preempt counter APIs have been split out, currently, hardirq.h just > includes irq_enter/exit APIs which are not used by caif at all. > > So, remove the unused hardirq.h. > > Signed-off-by: Yang Shi

Re: [PATCH 00/52] Netfilter/IPVS updates for net-next

From: Pablo Neira Ayuso Date: Mon, 8 Jan 2018 21:19:08 +0100 > The following patchset contains Netfilter/IPVS updates for your > net-next tree: ... > 4) Add generic flow table offload infrastructure for nf_tables, this >includes the netlink control plane and support

Re: [PATCH net-next 12/20] net: hns3: Add packet statistics of netdev

From: Jakub Kicinski Date: Mon, 8 Jan 2018 17:50:21 -0800 > Oh, I only noticed this extra misleading comment now. Unless each queue > has a netdev, I don't see how these are per-queue. If it isn't per-queue I want this change reverted.

Re: [PATCH net-next v2 0/6] Replace WARN_ONCE usages with netdev_WARN_ONCE

From: Gal Pressman Date: Sun, 7 Jan 2018 12:08:34 +0200 > This series will fix an issue in netdev_WARN_ONCE, improve its formatting and > replace drivers' usage of WARN_ONCE to netdev_WARN_ONCE. > > Driver specific patches were compilation tested, in addition, functional >

Re: [PATCH net-next 12/20] net: hns3: Add packet statistics of netdev

On Mon, 8 Jan 2018 17:46:02 -0800, Jakub Kicinski wrote: > On Mon, 08 Jan 2018 20:39:13 -0500 (EST), David Miller wrote: > > From: Jakub Kicinski > > Date: Mon, 8 Jan 2018 12:04:31 -0800 > > > > > Ugh, I so didn't review this in time :( I think there is a consensus > > > that

RE: [patch iproute2 v6 0/3] tc: Add -bs option to batch mode

> -Original Message- > From: Stephen Hemminger [mailto:step...@networkplumber.org] > Sent: Monday, January 8, 2018 11:40 PM > To: Chris Mi > Cc: David Ahern ; Phil Sutter ; > marcelo.leit...@gmail.com; netdev@vger.kernel.org;

Re: [PATCH net-next 12/20] net: hns3: Add packet statistics of netdev

On Mon, 08 Jan 2018 20:39:13 -0500 (EST), David Miller wrote: > From: Jakub Kicinski > Date: Mon, 8 Jan 2018 12:04:31 -0800 > > > Ugh, I so didn't review this in time :( I think there is a consensus > > that we should avoid duplicating standard stats in ethtool. Especially > >

[PATCH] ath9k: add a quirk to set use_msi automatically

Some platform(BIOS) blocks legacy interrupts (INTx), and only allows MSI for WLAN device. So adding a quirk to list those machines and set use_msi automatically. Adding the following platforms to the quirk. Dell Inspiron 24-3460 Dell Inspiron 3472 Dell Inspiron 14-3473 Dell Vostro 3262

Re: [PATCH net-next 12/20] net: hns3: Add packet statistics of netdev

From: Jakub Kicinski Date: Mon, 8 Jan 2018 12:04:31 -0800 > Ugh, I so didn't review this in time :( I think there is a consensus > that we should avoid duplicating standard stats in ethtool. Especially > those old ones. Like "collisions", I assume this is a modern NIC, are >

Re: b43: Replace mdelay with msleep in b43_radio_2057_init_post

On 2018/1/9 0:31, Larry Finger wrote: On 01/08/2018 10:21 AM, Kalle Valo wrote: Jia-Ju Bai wrote: b43_radio_2057_init_post is not called in an interrupt handler nor holding a spinlock. The function mdelay in it can be replaced with msleep, to reduce busy wait.

[PATCH v2] b43: Replace mdelay with usleep_range in b43_radio_2057_init_post

b43_radio_2057_init_post is not called in an interrupt handler nor holding a spinlock. The function mdelay in it can be replaced with usleep_range, to reduce busy wait. Signed-off-by: Jia-Ju Bai --- v2: * Replace mdelay with usleep_range, instead of msleep in v1. Thank

Re: [PATCH net 0/3] Some sockopt optlen fixes

On Mon, Jan 08, 2018 at 07:02:26PM -0200, Marcelo Ricardo Leitner wrote: > Hangbin Liu reported that some SCTP sockopt are allowing the user to get > the kernel to allocate really large buffers by not having a ceiling on > optlen. > > This patchset address this issue (in patch 2), replace an

RE: [patch iproute2 v6 0/3] tc: Add -bs option to batch mode

> -Original Message- > From: n...@orbyte.nwl.cc [mailto:n...@orbyte.nwl.cc] On Behalf Of Phil > Sutter > Sent: Monday, January 8, 2018 9:32 PM > To: Chris Mi > Cc: dsah...@gmail.com; marcelo.leit...@gmail.com; > netdev@vger.kernel.org; gerlitz...@gmail.com; >

Re: [RFC PATCH bpf-next v2 0/4] Separate error injection table from kprobes

On Thu, 4 Jan 2018 11:07:16 -0500 Josef Bacik wrote: > On Tue, Dec 26, 2017 at 04:46:28PM +0900, Masami Hiramatsu wrote: > > Hi Josef and Alexei, > > > > Here are the 2nd version of patches to moving error injection > > table from kprobes. In this series I did a small

Re: linux-next: manual merge of the net-next tree with the bpf tree

On Tue, Jan 09, 2018 at 11:21:25AM +1100, Stephen Rothwell wrote: > Hi all, > > Today's linux-next merge of the net-next tree got a conflict in: > > tools/testing/selftests/bpf/test_align.c > > between commit: > > 2b36047e7889 ("selftests/bpf: fix test_align") > > from the bpf tree and

linux-next: manual merge of the net-next tree with the bpf tree

Hi all, Today's linux-next merge of the net-next tree got a conflict in: tools/testing/selftests/bpf/test_align.c between commit: 2b36047e7889 ("selftests/bpf: fix test_align") from the bpf tree and commit: 6a28b446b7d2 ("selftests/bpf: adjust test_align expected output") from the

Re: [PATCH 06/18] x86, barrier: stop speculation for failed access_ok

On Mon, Jan 8, 2018 at 3:53 PM, Dan Williams wrote: > > I've been thinking the "and" is only suitable for the array bounds > check, for get_user() we're trying to block speculation past > access_ok() at which point we can only do the lfence? Well, we *could* do the

Re: [PATCH v2] openvswitch: Trim off padding before L3+ netfilter processing

On Sat, Jan 6, 2018 at 10:57 AM, Pravin Shelar wrote: > On Fri, Jan 5, 2018 at 10:59 PM, Ed Swierk wrote: >> >> >> On Jan 5, 2018 22:17, "Pravin Shelar" wrote: >> >> On Fri, Jan 5, 2018 at 3:20 PM, Ed Swierk

Re: [PATCH net-next 2/2] openvswitch: add erspan version II support

On Fri, Jan 5, 2018 at 2:29 PM, William Tu wrote: > The patch adds support for configuring the erspan version II > fields for openvswitch. > The patch looks good, But it could change userspace API for OVS_TUNNEL_KEY_ATTR_ERSPAN_OPTS, how are we going to handle compatibility?

Re: [PATCH bpf-next] bpf: introduce BPF_JIT_ALWAYS_ON config

On Mon, 8 Jan 2018 22:59:04 +0100, Daniel Borkmann wrote: > > @@ -1453,6 +1457,11 @@ struct bpf_prog *bpf_prog_select_runtime(struct > > bpf_prog *fp, int *err) > > */ > > *err = bpf_check_tail_call(fp); > > > > +#ifdef CONFIG_BPF_JIT_ALWAYS_ON > > + if (!fp->jited) > > +

Re: [PATCH v3 bpf] bpf: prevent out-of-bounds speculation

On 01/08/2018 02:33 AM, Alexei Starovoitov wrote: > Under speculation, CPUs may mis-predict branches in bounds checks. Thus, > memory accesses under a bounds check may be speculated even if the > bounds check fails, providing a primitive for building a side channel. > > To avoid leaking kernel

Re: [PATCH 06/18] x86, barrier: stop speculation for failed access_ok

On Mon, Jan 8, 2018 at 3:44 PM, Linus Torvalds wrote: > On Mon, Jan 8, 2018 at 1:09 PM, Dan Williams wrote: >> On Sat, Jan 6, 2018 at 5:20 PM, Linus Torvalds >> wrote: >>> On Sat, Jan 6, 2018 at 3:31 PM, Dan

Re: [PATCH 06/18] x86, barrier: stop speculation for failed access_ok

On Mon, Jan 8, 2018 at 1:09 PM, Dan Williams wrote: > On Sat, Jan 6, 2018 at 5:20 PM, Linus Torvalds > wrote: >> On Sat, Jan 6, 2018 at 3:31 PM, Dan Williams >> wrote: >>> >>> I assume if we put this in

Re: [PATCH bpf] selftests/bpf: fix test_align

On 1/8/18 8:38 AM, Edward Cree wrote: On 05/01/18 23:02, Alexei Starovoitov wrote: since commit 82abbf8d2fc4 the verifier rejects the bit-wise arithmetic on pointers earlier. The test 'dubious pointer arithmetic' now has less output to match on. Adjust it. Fixes: 82abbf8d2fc4 ("bpf: do not

Re: [PATCH bpf] bpf: prevent out-of-bounds speculation

On 1/8/18 9:05 AM, Mark Rutland wrote: Hi Alexei, On Thu, Jan 04, 2018 at 08:28:11PM -0800, Alexei Starovoitov wrote: From: Alexei Starovoitov Under speculation, CPUs may mis-predict branches in bounds checks. Thus, memory accesses under a bounds check may be speculated even

[PATCH next-queue 2/2] ixgbe: add unlikely notes to tx fastpath expressions

Add unlikely() to a few error checking expressions in the Tx offload handling. Suggested-by: Yanjun Zhu Signed-off-by: Shannon Nelson --- drivers/net/ethernet/intel/ixgbe/ixgbe_ipsec.c | 8 1 file changed, 4 insertions(+), 4

[PATCH next-queue 1/2] ixgbe: fix clean hw loop count

Fix a cut-paste error so that we can clean all the table entries. Signed-off-by: Shannon Nelson --- drivers/net/ethernet/intel/ixgbe/ixgbe_ipsec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_ipsec.c

RE: [Intel-wired-lan] [PATCH 01/27] timecounter: Make cyclecounter struct part of timecounter struct

> From: Intel-wired-lan [mailto:intel-wired-lan-boun...@osuosl.org] On > Behalf Of Sagar Arun Kamble > Sent: Thursday, December 14, 2017 11:38 PM > To: linux-ker...@vger.kernel.org > Cc: alsa-de...@alsa-project.org; linux-r...@vger.kernel.org; > netdev@vger.kernel.org; Richard Cochran

Re: dvb usb issues since kernel 4.9

On Mon, 8 Jan 2018 22:44:27 +0100 Peter Zijlstra wrote: > On Mon, Jan 08, 2018 at 10:31:09PM +0100, Jesper Dangaard Brouer wrote: > > I did expected the issue to get worse, when you load the Pi with > > network traffic, as now the softirq time-budget have to be shared > >

Re: [PATCH bpf-next] bpf: introduce BPF_JIT_ALWAYS_ON config

On 01/08/2018 04:35 AM, Alexei Starovoitov wrote: > The BPF interpreter has been used as part of the spectre 2 attack > CVE-2017-5715. > > A quote from goolge project zero blog: > "At this point, it would normally be necessary to locate gadgets in > the host kernel code that can be used to

Re: dvb usb issues since kernel 4.9

On Mon, Jan 08, 2018 at 10:31:09PM +0100, Jesper Dangaard Brouer wrote: > I did expected the issue to get worse, when you load the Pi with > network traffic, as now the softirq time-budget have to be shared > between networking and USB/DVB. Thus, I guess you are running TCP and > USB/mpeg2ts on

Re: dvb usb issues since kernel 4.9

On Mon, 8 Jan 2018 17:26:10 +0100 "Josef Griebichler" wrote: > I tried your mentioned patch but unfortunately no real improvement for me. > dmesg http://ix.io/DOg > tvheadend service log http://ix.io/DOi > > Errors during recording are still there. Are you _also_

[PATCH] wireless: broadcom: radio_2056: delete duplicated macro definitions

Ctrl-V was hit twice when these macros were inserted: $ sed -n '9,527p' ./drivers/net/wireless/broadcom/b43/radio_2056.h | md5sum 4db53450c59d9939e903d4e4ba6bc9b1 - $ sed -n '528,1046p' ./drivers/net/wireless/broadcom/b43/radio_2056.h | md5sum 4db53450c59d9939e903d4e4ba6bc9b1 - Signed-off-by:

Re: [PATCH 02/18] Documentation: document nospec helpers

On Mon, 8 Jan 2018 17:09:59 + Mark Rutland wrote: > > I have just a couple of overall comments. > > > > - It would be nice if the document were done in RST and placed in the > >core-API manual, perhaps using kerneldoc comments for the macros > >themselves.

Re: [PATCH 06/18] x86, barrier: stop speculation for failed access_ok

On Sat, Jan 6, 2018 at 5:20 PM, Linus Torvalds wrote: > On Sat, Jan 6, 2018 at 3:31 PM, Dan Williams wrote: >> >> I assume if we put this in uaccess_begin() we also need audit for >> paths that use access_ok but don't do on to call

[PATCH net 2/3] sctp: add a ceiling to optlen in some sockopts

Hangbin Liu reported that some sockopt calls could cause the kernel to log a warning on memory allocation failure if the user supplied a large optlen value. That is because some of them called memdup_user() without a ceiling on optlen, allowing it to try to allocate really large buffers. This

  1   2   3   4   >