Re: [PATCH v6 22/36] nds32: Debugging support

2018-01-18 18:37 GMT+08:00 Arnd Bergmann : > On Mon, Jan 15, 2018 at 6:53 AM, Greentime Hu wrote: >> From: Greentime Hu >> >> This patch adds ptrace support. >> >> Signed-off-by: Vincent Chen >> Signed-off-by:

Re: [PATCH net-next] net: aquantia: Fix error return code in aq_pci_probe()

> Fix to return error code -ENOMEM from the aq_ndev_alloc() error > handling case instead of 0, as done elsewhere in this function. > > Fixes: 23ee07ad3c2f ("net: aquantia: Cleanup pci functions module") > Signed-off-by: Wei Yongjun Acked-by: Igor Russkikh

Re: [PATCH net-next] net: aquantia: make symbol hw_atl_boards static

Thanks, Wei! > Fixes the following sparse warning: > > drivers/net/ethernet/aquantia/atlantic/aq_pci_func.c:50:34: warning: > symbol 'hw_atl_boards' was not declared. Should it be static? > > Fixes: 4948293ff963 ("net: aquantia: Introduce new AQC devices and > capabilities") > Signed-off-by:

[PATCH net-next 1/1] forcedeth: remove duplicate structure member in rx

Since both first_rx_ctx and rx_skb are the head of rx ctx, it not necessary to use two structure members to statically indicate the head of rx ctx. So first_rx_ctx is removed. CC: Srinivas Eeda CC: Joe Jin CC: Junxiao Bi

[PATCH bpf-next] bpf: fix incorrect kmalloc usage in lpm_trie MAP_GET_NEXT_KEY rcu region

In commit b471f2f1de8b ("bpf: implement MAP_GET_NEXT_KEY command for LPM_TRIE map"), the implemented MAP_GET_NEXT_KEY callback function is guarded with rcu read lock. In the function body, "kmalloc(size, GFP_USER | __GFP_NOWARN)" is used which may sleep and violate rcu read lock region

Re: [net-next: PATCH v4 1/7] device property: Introduce fwnode_get_mac_address()

Hi Rafael, > > if (res) > > return res; > > > > - return device_get_mac_addr(dev, "address", addr, alen); > > + return fwnode_get_mac_addr(fwnode, "address", addr, alen); > > +} > > +EXPORT_SYMBOL(fwnode_get_mac_address); > > That should be EXPORT_SYMBOL_GPL().

[PATCH bpf-next] tools/bpf: fix a test failure in selftests prog test_verifier

Commit 111e6b45315c ("selftests/bpf: make test_verifier run most programs") enables tools/testing/selftests/bpf/test_verifier unit cases to run via bpf_prog_test_run command. With the latest code base, test_verifier had one test case failure: ... #473/p check deducing bounds from const, 2

Re: Re: [PATCH v4] net: qcom/emac: extend DMA mask to 46bits

Thanks. Cheers, -Dongsheng On 2018/1/23 12:48:27, "Timur Tabi" wrote: >On 1/22/18 10:25 PM, Wang Dongsheng wrote: >>Bit TPD3[31] is used as a timestamp bit if PTP is enabled, but >>it's used as an address bit if PTP is disabled. Since PTP isn't >>supported by the driver,

Re: [PATCH 0/3] Check gso_size of packets when forwarding

On Mon, Jan 22, 2018 at 12:14 PM, David Miller wrote: > From: Pravin Shelar > Date: Fri, 19 Jan 2018 13:54:15 -0800 > >> I agree it is not perfect. But the other proposed patch does not fix >> the connectivity issue. It only adds log msg in such cases at

Re: [PATCH v3 2/2] openvswitch: Remove padding from packet before L3+ conntrack processing

On Mon, Jan 22, 2018 at 6:42 PM, Ed Swierk wrote: > In the OVS conntrack receive path, ovs_ct_execute() pulls the skb to > the L3 header but does not trim it to the L3 length before calling > nf_conntrack_in(NF_INET_PRE_ROUTING). When nf_conntrack_proto_tcp >

Re: [PATCH v3 1/2] skbuff: Add skb_network_trim

On Mon, Jan 22, 2018 at 6:42 PM, Ed Swierk wrote: > IPv4 and IPv6 packets may arrive with lower-layer padding that is not > included in the L3 length. For example, a short IPv4 packet may have > up to 6 bytes of padding following the IP payload when received on an >

Re: [RFC v2 net-next 00/10] Time based packet transmission

On Mon, Jan 22, 2018 at 09:23:27PM -0800, Richard Cochran wrote: > On Wed, Jan 17, 2018 at 03:06:11PM -0800, Jesus Sanchez-Palencia wrote: > > First, a baseline test was ran for 10 minutes with the plain kernel only: > > > > | | plain kernel @ 1ms | > >

Re: [RFC v2 net-next 00/10] Time based packet transmission

On Wed, Jan 17, 2018 at 03:06:11PM -0800, Jesus Sanchez-Palencia wrote: > First, a baseline test was ran for 10 minutes with the plain kernel only: > > | | plain kernel @ 1ms | > |-++ > | min (ns): |+4.82e+02 | > | max (ns):

Re: [PATCH bpf] bpf: test_maps: cleanup sockmaps when test ends

On 01/22/2018 09:01 PM, Alexei Starovoitov wrote: > On Tue, Jan 23, 2018 at 01:55:30PM +0900, Prashant Bhole wrote: >> >> >> On 1/23/2018 1:38 PM, Alexei Starovoitov wrote: >>> On Tue, Jan 23, 2018 at 01:30:44PM +0900, Prashant Bhole wrote: Bug: BPF programs and maps related to sockmaps test

Re: [PATCH bpf] bpf: test_maps: cleanup sockmaps when test ends

On Tue, Jan 23, 2018 at 01:55:30PM +0900, Prashant Bhole wrote: > > > On 1/23/2018 1:38 PM, Alexei Starovoitov wrote: > > On Tue, Jan 23, 2018 at 01:30:44PM +0900, Prashant Bhole wrote: > > > Bug: BPF programs and maps related to sockmaps test exist in > > > memory even after test_maps ends > >

Re: [PATCH bpf] bpf: test_maps: cleanup sockmaps when test ends

On 1/23/2018 1:38 PM, Alexei Starovoitov wrote: On Tue, Jan 23, 2018 at 01:30:44PM +0900, Prashant Bhole wrote: Bug: BPF programs and maps related to sockmaps test exist in memory even after test_maps ends This patch fixes it by empyting sockmaps when test ends. Fixes: 6f6d33f3b3d0f ("bpf:

Re: [PATCH v4] net: qcom/emac: extend DMA mask to 46bits

On 1/22/18 10:25 PM, Wang Dongsheng wrote: Bit TPD3[31] is used as a timestamp bit if PTP is enabled, but it's used as an address bit if PTP is disabled. Since PTP isn't supported by the driver, we can extend the DMA address to 46 bits. Signed-off-by: Wang

[PATCH bpf-next] selftests/bpf: fix test_dev_cgroup

The test incorrectly doing mkdir /mnt/cgroup-test-work-dirtest-bpf-based-device-cgroup instead of mkdir /mnt/cgroup-test-work-dir/test-bpf-based-device-cgroup somehow such mkdir succeeds and new directory appears: /mnt/cgroup-test-work-dir/cgroup-test-work-dirtest-bpf-based-device-cgroup Later

Re: [PATCH bpf] bpf: test_maps: cleanup sockmaps when test ends

On Tue, Jan 23, 2018 at 01:30:44PM +0900, Prashant Bhole wrote: > Bug: BPF programs and maps related to sockmaps test exist in > memory even after test_maps ends > > This patch fixes it by empyting sockmaps when test ends. > > Fixes: 6f6d33f3b3d0f ("bpf: selftests add sockmap tests") >

[PATCH bpf] bpf: test_maps: cleanup sockmaps when test ends

Bug: BPF programs and maps related to sockmaps test exist in memory even after test_maps ends This patch fixes it by empyting sockmaps when test ends. Fixes: 6f6d33f3b3d0f ("bpf: selftests add sockmap tests") Signed-off-by: Prashant Bhole ---

[PATCH v4] net: qcom/emac: extend DMA mask to 46bits

Bit TPD3[31] is used as a timestamp bit if PTP is enabled, but it's used as an address bit if PTP is disabled. Since PTP isn't supported by the driver, we can extend the DMA address to 46 bits. Signed-off-by: Wang Dongsheng --- v4: - Changes: PATCH's

[PATCH] ip_tunnel: Use mark in skb by default

This allows marks set by connmark in iptables to be used for route lookups. Signed-off-by: Thomas Winter Cc: "David S. Miller" Cc: Alexey Kuznetsov Cc: Hideaki YOSHIFUJI ---

Re: [virtio-dev] [RFC PATCH net-next v2 1/2] virtio_net: Introduce VIRTIO_NET_F_BACKUP feature bit

On Mon, Jan 22, 2018 at 6:04 PM, Michael S. Tsirkin wrote: > On Mon, Jan 22, 2018 at 05:34:37PM -0800, Samudrala, Sridhar wrote: >> On 1/22/2018 4:05 PM, Michael S. Tsirkin wrote: >> > On Mon, Jan 22, 2018 at 03:27:40PM -0800, Samudrala, Sridhar wrote: >> > > > > You could

Re: [PATCH] net/mlx4_en: ensure rx_desc updating reaches HW before prod db updating

Hi Jason Thanks for your kindly response. On 01/22/2018 11:47 PM, Jason Gunthorpe wrote: >>> Yeah, mlx4 NICs in Google fleet receive trillions of packets per >>> second, and we never noticed an issue. >>> >>> Although we are using a slightly different driver, using order-0 pages >>> and fast

[PATCH net-next 4/4] net: core: Fix kernel-doc for netdev_upper_link()

Fixes the following warnings: ./net/core/dev.c:6438: warning: No description found for parameter 'extack' ./net/core/dev.c:6461: warning: No description found for parameter 'extack' Fixes: 42ab19ee9029 ("net: Add extack to upper device linking") Signed-off-by: Florian Fainelli

[PATCH net-next 2/4] net: phy: sfp: Fix kernel doc warning

We forgot to update the kernel doc header above sfp_register_upstream() Fixes: c19bb00070dd ("sfp: convert to fwnode") Signed-off-by: Florian Fainelli --- drivers/net/phy/sfp-bus.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH net-next 0/4] Kernel doc fixes for networking

Hi David, This patch series fixes kernel doc warnings found while running make htmldocs pertaining to the networking subsystem. There is a finaly set of warnings due to PHYLINK which I have not been able to resolve yet. The last patch could thereoteically be applied to 'net' since the commit

[PATCH net-next 3/4] net: core: Fix kernel-doc for call_netdevice_notifiers_info()

Remove the @dev comment, since we do not have a net_device argument, fixes the following kernel doc warning: /net/core/dev.c:1707: warning: Excess function parameter 'dev' description in 'call_netdevice_notifiers_info' Signed-off-by: Florian Fainelli --- net/core/dev.c | 1

[PATCH net-next 1/4] net: core: Fix kernel-doc for carrier_* attributes

Fix the documentation warning: include/linux/netdevice.h:1939: warning: Excess struct member 'carrier_changes' description in 'net_device' Reported-by: kbuild test robot Fixes: b2d3bcfa26a7 ("net: core: Expose number of link up/down transitions") Signed-off-by: Florian

[PATCH v3 2/2] openvswitch: Remove padding from packet before L3+ conntrack processing

In the OVS conntrack receive path, ovs_ct_execute() pulls the skb to the L3 header but does not trim it to the L3 length before calling nf_conntrack_in(NF_INET_PRE_ROUTING). When nf_conntrack_proto_tcp encounters a packet with lower-layer padding, nf_checksum() fails and logs "nf_ct_tcp: bad TCP

[PATCH v3 1/2] skbuff: Add skb_network_trim

IPv4 and IPv6 packets may arrive with lower-layer padding that is not included in the L3 length. For example, a short IPv4 packet may have up to 6 bytes of padding following the IP payload when received on an Ethernet device with a minimum packet length of 64 bytes. Higher-layer processing

Re: [PATCH net-next] nfp: fix error return code in nfp_pci_probe()

On Tue, 23 Jan 2018 02:10:27 +, Wei Yongjun wrote: > Fix to return error code -EINVAL instead of 0 when num_vfs above > limit_vfs, as done elsewhere in this function. > > Signed-off-by: Wei Yongjun Acked-by: Jakub Kicinski Thanks!

Re: [virtio-dev] [RFC PATCH net-next v2 1/2] virtio_net: Introduce VIRTIO_NET_F_BACKUP feature bit

On Mon, Jan 22, 2018 at 05:34:37PM -0800, Samudrala, Sridhar wrote: > On 1/22/2018 4:05 PM, Michael S. Tsirkin wrote: > > On Mon, Jan 22, 2018 at 03:27:40PM -0800, Samudrala, Sridhar wrote: > > > > > You could probably > > > > > even handle the Tx queue selection via a simple eBPF program and map

[PATCH net-next] nfp: fix error return code in nfp_pci_probe()

Fix to return error code -EINVAL instead of 0 when num_vfs above limit_vfs, as done elsewhere in this function. Signed-off-by: Wei Yongjun --- drivers/net/ethernet/netronome/nfp/nfp_main.c | 1 + 1 file changed, 1 insertion(+) diff --git

[PATCH net-next] net: aquantia: make symbol hw_atl_boards static

Fixes the following sparse warning: drivers/net/ethernet/aquantia/atlantic/aq_pci_func.c:50:34: warning: symbol 'hw_atl_boards' was not declared. Should it be static? Fixes: 4948293ff963 ("net: aquantia: Introduce new AQC devices and capabilities") Signed-off-by: Wei Yongjun

[PATCH net-next] net: aquantia: Fix error return code in aq_pci_probe()

Fix to return error code -ENOMEM from the aq_ndev_alloc() error handling case instead of 0, as done elsewhere in this function. Fixes: 23ee07ad3c2f ("net: aquantia: Cleanup pci functions module") Signed-off-by: Wei Yongjun ---

[PATCH bpf-next] selftests/bpf: speedup test_maps

test_hashmap_walk takes very long time on debug kernel with kasan on. Reduce the number of iterations in this test without sacrificing test coverage. Also add printfs as progress indicator. Signed-off-by: Alexei Starovoitov --- tools/testing/selftests/bpf/test_maps.c | 16

Re: [virtio-dev] [RFC PATCH net-next v2 1/2] virtio_net: Introduce VIRTIO_NET_F_BACKUP feature bit

On 1/22/2018 4:02 PM, Stephen Hemminger wrote: In the case of SwitchDev it should be possible for the port representors and the switch to provide data on which interfaces are bonded on the host side and which aren't. With that data it would be pretty easy to just put together a list of

Re: [PATCH net-next] tcp: avoid negotitating ECN for BBR

On Fri, Jan 19, 2018 at 11:31 AM, David Miller wrote: > > From: Yuchung Cheng > Date: Tue, 16 Jan 2018 17:57:26 -0800 > > > This patch keeps BBR from negotiating ECN if sysctl ECN is > > set. Prior to this patch, BBR negotiates ECN if enabled, sends > >

Re: [virtio-dev] [RFC PATCH net-next v2 1/2] virtio_net: Introduce VIRTIO_NET_F_BACKUP feature bit

On 1/22/2018 4:05 PM, Michael S. Tsirkin wrote: On Mon, Jan 22, 2018 at 03:27:40PM -0800, Samudrala, Sridhar wrote: You could probably even handle the Tx queue selection via a simple eBPF program and map since the input for whatever is used to select Tx should be pretty simple, destination MAC,

[PATCH net-next] nfp: fix fw dump handling of absolute rtsym size

From: Carl Heymann Fix bug that causes _absolute_ rtsym sizes of > 8 bytes (as per symbol table) to result in incorrect space used during a TLV-based debug dump. Detail: The size calculation stage calculates the correct size (size of the rtsym address field == 8),

Re: [virtio-dev] [RFC PATCH net-next v2 1/2] virtio_net: Introduce VIRTIO_NET_F_BACKUP feature bit

On Mon, Jan 22, 2018 at 05:13:01PM -0800, Jakub Kicinski wrote: > On Tue, 23 Jan 2018 02:47:57 +0200, Michael S. Tsirkin wrote: > > On Mon, Jan 22, 2018 at 04:16:23PM -0800, Jakub Kicinski wrote: > > > On Tue, 23 Jan 2018 02:05:48 +0200, Michael S. Tsirkin wrote: > > > > > As we are using

[net-next:master 376/384] htmldocs: include/linux/netdevice.h:1939: warning: Excess struct member 'carrier_changes' description in 'net_device'

tree: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git master head: c13da21cdb8085f1d9a53463c88a4d3967fe90fd commit: b2d3bcfa26a7a8de41f358a6cae8b848673b3c6e [376/384] net: core: Expose number of link up/down transitions reproduce: make htmldocs All warnings (new ones

Re: [virtio-dev] [RFC PATCH net-next v2 1/2] virtio_net: Introduce VIRTIO_NET_F_BACKUP feature bit

On Tue, 23 Jan 2018 02:47:57 +0200, Michael S. Tsirkin wrote: > On Mon, Jan 22, 2018 at 04:16:23PM -0800, Jakub Kicinski wrote: > > On Tue, 23 Jan 2018 02:05:48 +0200, Michael S. Tsirkin wrote: > > > > As we are using virtio_net to control and manage the VF data path, it > > > > is not > > > >

Re: [virtio-dev] [RFC PATCH net-next v2 1/2] virtio_net: Introduce VIRTIO_NET_F_BACKUP feature bit

On Mon, Jan 22, 2018 at 04:16:23PM -0800, Jakub Kicinski wrote: > On Tue, 23 Jan 2018 02:05:48 +0200, Michael S. Tsirkin wrote: > > > As we are using virtio_net to control and manage the VF data path, it is > > > not > > > clear to me > > > what is the advantage of creating a new device rather

Re: [PATCH v2] smc: return booleans instead of integers

On Mon, 2018-01-22 at 12:58 +0100, Ursula Braun wrote: > > On 01/19/2018 09:54 PM, Gustavo A. R. Silva wrote: > > Return statements in functions returning bool should use > > true/false instead of 1/0. > > > > This issue was detected with the help of Coccinelle. > > > > Signed-off-by: Gustavo

Re: [virtio-dev] [RFC PATCH net-next v2 1/2] virtio_net: Introduce VIRTIO_NET_F_BACKUP feature bit

On Tue, 23 Jan 2018 02:05:48 +0200, Michael S. Tsirkin wrote: > > As we are using virtio_net to control and manage the VF data path, it is not > > clear to me > > what is the advantage of creating a new device rather than extending > > virtio_net to manage > > the VF datapath via transparent bond

Re: [PATCH bpf-next 1/2] bpf: implement MAP_GET_NEXT_KEY command for LPM_TRIE map

On 1/22/18 11:28 AM, Eric Dumazet wrote: On Thu, 2018-01-18 at 15:08 -0800, Yonghong Song wrote: Current LPM_TRIE map type does not implement MAP_GET_NEXT_KEY command. This command is handy when users want to enumerate keys. Otherwise, a different map which supports key enumeration may be

Re: [net-next: PATCH v4 4/7] device property: Allow iterating over available child fwnodes

On Thu, Jan 18, 2018 at 1:31 PM, Marcin Wojtas wrote: > Implement a new helper function fwnode_get_next_available_child_node(), > which enables obtaining next enabled child fwnode, which > works on a similar basis to OF's of_get_next_available_child(). > > This commit also

Re: [virtio-dev] [RFC PATCH net-next v2 1/2] virtio_net: Introduce VIRTIO_NET_F_BACKUP feature bit

On Mon, Jan 22, 2018 at 03:27:40PM -0800, Samudrala, Sridhar wrote: > > > You could probably > > > even handle the Tx queue selection via a simple eBPF program and map > > > since the input for whatever is used to select Tx should be pretty > > > simple, destination MAC, source NUMA node, etc, and

Re: [net-next: PATCH v4 1/7] device property: Introduce fwnode_get_mac_address()

On Thu, Jan 18, 2018 at 1:31 PM, Marcin Wojtas wrote: > Until now there were two almost identical functions for > obtaining MAC address - of_get_mac_address() and, more generic, > device_get_mac_address(). However it is not uncommon, > that the network interface is represented

Re: [virtio-dev] [RFC PATCH net-next v2 1/2] virtio_net: Introduce VIRTIO_NET_F_BACKUP feature bit

On Mon, 22 Jan 2018 15:27:40 -0800 "Samudrala, Sridhar" wrote: > On 1/22/2018 1:31 PM, Michael S. Tsirkin wrote: > > On Wed, Jan 17, 2018 at 01:49:58PM -0800, Alexander Duyck wrote: > >> On Wed, Jan 17, 2018 at 11:57 AM, Michael S. Tsirkin > >>

Re: [net-next: PATCH v4 3/7] device property: Introduce fwnode_irq_get()

On Thu, Jan 18, 2018 at 1:31 PM, Marcin Wojtas wrote: > Until now there were two very similar functions allowing > to get Linux IRQ number from ACPI handle (acpi_irq_get()) > and OF node (of_irq_get()). The first one appeared to be used > only as a subroutine of

Re: [PATCH v2] smc: return booleans instead of integers

Quoting Ursula Braun : [...] Thanks, Gustavo. I have added the patch to our local repository. It will be part of one of my next patch sets to be sent to Dave Miller. Thanks, Ursula :) -- Gustavo

Re: Network interface "stops working"

(Please always Cc netdev for networking related bugs.) On Mon, Jan 22, 2018 at 2:02 AM, Turbo Fredriksson wrote: > I just got a new broadband delivered at home. It is "Hyperoptic 1Gbps fiber" > which comes as a ethernet connector at home. I wasn’t around > when they connected

Re: [virtio-dev] [RFC PATCH net-next v2 1/2] virtio_net: Introduce VIRTIO_NET_F_BACKUP feature bit

On 1/22/2018 1:31 PM, Michael S. Tsirkin wrote: On Wed, Jan 17, 2018 at 01:49:58PM -0800, Alexander Duyck wrote: On Wed, Jan 17, 2018 at 11:57 AM, Michael S. Tsirkin wrote: On Wed, Jan 17, 2018 at 11:25:41AM -0800, Samudrala, Sridhar wrote: On 1/17/2018 11:02 AM, Michael S.

Re: [PATCH net-next] nfp: flower: prioritize stats updates

On Sun, 21 Jan 2018 23:53:05 -0800, Jakub Kicinski wrote: > > Just a reminder that it really makes things more difficult that one > > can't just go: > > > > make drivers/net/ethernet/netronome/nfp/flower/cmsg.o > > > > to test a specific NFP object build like one can with pretty much the >

[PATCH] net: caif: fix boolean assignments

Assign true or false to boolean variables instead of an integer value. This issue was detected with the help of Coccinelle. Fixes: 0e4c7d85d5e5 ("caif: Add support for flow-control on device's tx-queue") Fixes: 7d3113042823 ("caif: Stash away hijacked skb destructor and call it later")

[PATCH] tipc: bcast: fix boolean assignment in tipc_nlist_purge

Assign true or false to boolean variables instead of an integer value. This issue was detected with the help of Coccinelle. Fixes: 2ae0b8af1fe3 ("tipc: add functionality to lookup multicast destination nodes") Signed-off-by: Gustavo A. R. Silva --- net/tipc/bcast.c |

Re: KASAN: slab-out-of-bounds Read in erspan_xmit

On Mon, Jan 22, 2018 at 2:45 PM, David Ahern wrote: > [ cc William Tu ] > > On 1/22/18 12:58 PM, syzbot wrote: >> Hello, >> >> syzbot hit the following crash on net-next commit >> 9d6474e458b13a94a0d5b141f2b8f38adf1991ae (Mon Jan 22 02:55:38 2018 +) >> tun: add missing rcu

Re: [Intel-wired-lan] [PATCH] igb: add VF trust infrastructure

Hi Corinna, I've looked over the patch and didn't see any issues. My understanding is that Jeff has pulled it into his tree and it should be going through testing shortly. Thanks. - Alex On Mon, Jan 22, 2018 at 12:54 AM, Corinna Vinschen wrote: > Hi, > > Could somebody

Re: Memory corruption with r8169 across several device revisions and kernels

Dear Francois, other r8169 experts, Am 22.01.2018 um 01:09 schrieb Francois Romieu: > Are you able to retrieve the layout ? That is, does it appear to match: > > - r8169 hardware stats DMA buffer ? > TxOk, RxOk, TxErr, RxErr, ... > > - rtnl_link_stats ? > rx_packets, tx_packets, rx_bytes,

[PATCH] net: ipv6: ndisc: fix bool assignment in ndisc_send_na

Assign true or false to boolean variables instead of an integer value. This issue was detected with the help of Coccinelle. Fixes: 1cb3fe513f62 ("ndisc: Break down ndisc_build_skb() and build message directly.") Signed-off-by: Gustavo A. R. Silva --- net/ipv6/ndisc.c

Re: KASAN: slab-out-of-bounds Read in erspan_xmit

[ cc William Tu ] On 1/22/18 12:58 PM, syzbot wrote: > Hello, > > syzbot hit the following crash on net-next commit > 9d6474e458b13a94a0d5b141f2b8f38adf1991ae (Mon Jan 22 02:55:38 2018 +) > tun: add missing rcu annotation > > So far this crash happened 5 times on net-next. > C reproducer is

Re: KASAN: use-after-free Read in erspan_xmit

[ cc William Tu ] On 1/22/18 12:58 PM, syzbot wrote: > Hello, > > syzbot hit the following crash on net-next commit > 9d6474e458b13a94a0d5b141f2b8f38adf1991ae (Mon Jan 22 02:55:38 2018 +) > tun: add missing rcu annotation > > So far this crash happened 9 times on net-next. > C reproducer is

Re: [Patch net-next 2/3] net_sched: plug in qdisc ops change_tx_queue_len

On Sun, Jan 21, 2018 at 2:12 PM, John Fastabend wrote: > On 01/19/2018 03:09 PM, Cong Wang wrote: > > hmm what happens if the resize fails in the next patch, > >> >> +static void pfifo_fast_change_tx_queue_len(struct Qdisc *sch, unsigned int >> new_len) >> +{ >> +

Re: [PATCH net] vxlan: update skb dst pmtu on tx path

On 12/18/2017 07:20 AM, Xin Long wrote: Unlike ip tunnels, now vxlan doesn't do any pmtu update for upper dst pmtu, even if it doesn't match the lower dst pmtu any more. The problem can be reproduced when reducing the vxlan lower dev's pmtu when running netperf. In jianlin's testing, the

Re: KASAN: use-after-free Read in erspan_build_header

[ cc William Tu] On 1/22/18 12:58 PM, syzbot wrote: > Hello, > > syzbot hit the following crash on upstream commit > 0d665e7b109d512b7cae3ccef6e8654714887844 (Fri Jan 19 12:49:24 2018 +) > mm, page_vma_mapped: Drop faulty pointer arithmetics in check_pte() > > So far this crash happened 11

Re: [PATCH v2 net 2/2] net: sched: fix TCF_LAYER_LINK case in tcf_get_base_ptr

On Mon, Jan 22, 2018 at 2:53 AM, Wolfgang Bumiller wrote: > TCF_LAYER_LINK and TCF_LAYER_NETWORK returned the same pointer as > skb->data points to the network header. > Use skb_mac_header instead. skb->data points to network header only on ingress side, IIRC.

Re: [PATCH v2 net 0/2] nbyte, cmp and text filter fixups

On Mon, Jan 22, 2018 at 2:53 AM, Wolfgang Bumiller wrote: > Changes: > * Fixed up commit message > * Removed not really related iproute2 patch from this thread. > > This fixes an oob read in em_nbyte and allows 'layer 0' in cmp and > nbyte and em_text to actually match

[PATCH] xfrm: fix boolean assignment in xfrm_get_type_offload

Assign true or false to boolean variables instead of an integer value. This issue was detected with the help of Coccinelle. Fixes: ffdb5211da1c ("xfrm: Auto-load xfrm offload modules") Signed-off-by: Gustavo A. R. Silva --- net/xfrm/xfrm_state.c | 2 +- 1 file changed,

Re: [PATCH net-next 1/1] rtnetlink: request RTM_GETLINK by pid or fd

On Mon, Jan 22, 2018 at 11:06:16PM +0100, Jiri Benc wrote: > On Mon, 22 Jan 2018 22:23:54 +0100, Christian Brauner wrote: > > That is certainly a good idea and I'm happy to send a follow-up patch > > for that! > > Note that I haven't looked into that and I don't know whether it is > easily

Re: [PATCH] RDS: Fix rds-ping inducing kernel panic

On 1/22/2018 2:17 PM, Kees Cook wrote: On Tue, Jan 23, 2018 at 4:01 AM, Santosh Shilimkar wrote: On 1/22/2018 3:24 AM, Kees Cook wrote: As described in: https://bugzilla.redhat.com/show_bug.cgi?id=822754 Attempting an RDS connection from the IP address of an

[PATCH] 9p/trans_virtio: discard zero-length reply

When a 9p request is successfully flushed, the server is expected to just mark it as used without sending a 9p reply (ie, without writing data into the buffer). In this case, virtqueue_get_buf() will return len == 0 and we must not report a REQ_STATUS_RCVD status to the client, otherwise the

[PATCH net] xfrm: Fix eth_hdr(skb)->h_proto to reflect inner IP version

From: Yossi Kuperman IPSec tunnel mode supports encapsulation of IPv4 over IPv6 and vice-versa. The outer IP header is stripped and the inner IP inherits the original Ethernet header. Tcpdump fails to properly decode the inner packet in case that h_proto is different than

Re: [PATCH] Carrier detect ok, don't turn off negotiation

The timer is supposed to be triggered by carrier detect interrupt. After remove the line noise, the carrier detect interrupt is never triggered again, because the carrier is always ok and it only trigger the timer once, Since the protocol was terminated and no new interrupts happen, the link

Re: [PATCH] RDS: Fix rds-ping inducing kernel panic

On Tue, Jan 23, 2018 at 4:01 AM, Santosh Shilimkar wrote: > On 1/22/2018 3:24 AM, Kees Cook wrote: >> >> As described in: https://bugzilla.redhat.com/show_bug.cgi?id=822754 >> >> Attempting an RDS connection from the IP address of an IPoIB interface >> to itself

lightweight netdevs Jan 2018 edition [Re: [PATCH net-next v2] net: core: Expose number of link up/down transitions]

On 1/22/18 1:46 PM, Florian Fainelli wrote: >> >> Like David Ahern I am strongly against the proliferation of sysfs files >> attached to network devices and the per-netdevice costs associated with >> that. >> >> However, dealing with that is a longer term issue that nobody has a clear >> plan for.

Re: [PATCH net-next 1/1] rtnetlink: request RTM_GETLINK by pid or fd

On Mon, 22 Jan 2018 22:23:54 +0100, Christian Brauner wrote: > That is certainly a good idea and I'm happy to send a follow-up patch > for that! Note that I haven't looked into that and I don't know whether it is easily possible. I'll appreciate if you could try that. > But there's still value

Re: [PATCHv4 1/5] net: dsa: Support internal phy on 'cpu' port

Hi, On Mon, Jan 22, 2018 at 12:56:44PM -0800, Florian Fainelli wrote: > On 01/22/2018 12:54 PM, Andrew Lunn wrote: > >> Note: there is still technically a misreprentation of how the PHY is > >> "attached" to the network device. In your DTSes, you have to have the > >> CPU port have a "phy-handle"

Re: [Patch net-next] tun: avoid calling xdp_rxq_info_unreg() twice

From: Cong Wang Date: Mon, 22 Jan 2018 13:49:27 -0800 > Similarly to tx ring, xdp_rxq_info is only registered > when !tfile->detached, so we need to avoid calling > xdp_rxq_info_unreg() twice too. The helper tun_cleanup_tx_ring() > already checks for this properly, so

[Patch net-next] tun: avoid calling xdp_rxq_info_unreg() twice

Similarly to tx ring, xdp_rxq_info is only registered when !tfile->detached, so we need to avoid calling xdp_rxq_info_unreg() twice too. The helper tun_cleanup_tx_ring() already checks for this properly, so it is correct to put xdp_rxq_info_unreg() just inside there. Reported-by:

Re: [RFC PATCH net-next v2 2/2] virtio_net: Extend virtio to use VF datapath when available

On Mon, Jan 22, 2018 at 12:27:14PM -0800, Siwei Liu wrote: > First off, as mentioned in another thread, the model of stacking up > virt-bond functionality over virtio seems a wrong direction to me. > Essentially the migration process would need to carry over all guest > side configurations

Re: [virtio-dev] [RFC PATCH net-next v2 1/2] virtio_net: Introduce VIRTIO_NET_F_BACKUP feature bit

On Wed, Jan 17, 2018 at 01:49:58PM -0800, Alexander Duyck wrote: > On Wed, Jan 17, 2018 at 11:57 AM, Michael S. Tsirkin wrote: > > On Wed, Jan 17, 2018 at 11:25:41AM -0800, Samudrala, Sridhar wrote: > >> > >> > >> On 1/17/2018 11:02 AM, Michael S. Tsirkin wrote: > >> > On Wed,

Re: [PATCH net-next v4 0/8] net: sched: add extack support for cls offloads

From: Jakub Kicinski Date: Fri, 19 Jan 2018 17:44:42 -0800 > Hi! > > I've dropped the tests from the series because test_offloads.py changes > will conflict with bpf-next patches. I will send four more patches with > tests once bpf-next is merged back, hopefully

Re: [PATCH 0/3] Check gso_size of packets when forwarding

On Mon, 22 Jan 2018 15:14:53 -0500 (EST) David Miller wrote: > From: Pravin Shelar > Date: Fri, 19 Jan 2018 13:54:15 -0800 > > > I agree it is not perfect. But the other proposed patch does not fix > > the connectivity issue. It only adds log msg in such

Re: [PATCH net] tls: Correct length of scatterlist in tls_sw_sendpage

From: Dave Watson Date: Fri, 19 Jan 2018 12:30:13 -0800 > The scatterlist is reused by both sendmsg and sendfile. > If a sendmsg of smaller number of pages is followed by a sendfile > of larger number of pages, the scatterlist may be too short, resulting > in a crash in

Re: [PATCH net-next 1/1] rtnetlink: request RTM_GETLINK by pid or fd

On Mon, Jan 22, 2018 at 10:00:46PM +0100, Jiri Benc wrote: > On Thu, 18 Jan 2018 21:55:53 +0100, Christian Brauner wrote: > > A more concrete scenario is creating a network namespace, moving a > > device into it via RTM_SETLINK which also supports IFLA_NET_NS_{FD,PID} > > and then wanting to query

Re: [PATCH net-next] hv_netvsc: Use the num_online_cpus() for channel limit

From: Haiyang Zhang Date: Fri, 19 Jan 2018 13:26:43 -0700 > From: Haiyang Zhang > > Since we no longer localize channel/CPU affiliation within one NUMA > node, num_online_cpus() is used as the number of channel cap, instead of > the

Re: [PATCH net] be2net: restore properly promisc mode after queues reconfiguration

From: Ivan Vecera Date: Fri, 19 Jan 2018 20:23:50 +0100 > The commit 622190669403 ("be2net: Request RSS capability of Rx interface > depending on number of Rx rings") modified be_update_queues() so the > IFACE (HW representation of the netdevice) is destroyed and then > re-created.

Re: [PATCH net-next] net: hns3: converting spaces into tabs to avoid checkpatch.pl warning

From: Salil Mehta Date: Fri, 19 Jan 2018 15:20:53 + > Spaces were mistakenly used instead of tabs in some of the code related > to reset functionality, which caused checkpatch.pl errors. These were > missed earlier so fixing them now. > > Signed-off-by: Salil Mehta

Re: [PATCH] net: igmp: fix source address check for IGMPv3 reports

From: Felix Fietkau Date: Fri, 19 Jan 2018 11:50:46 +0100 > Commit "net: igmp: Use correct source address on IGMPv3 reports" > introduced a check to validate the source address of locally generated > IGMPv3 packets. > Instead of checking the local interface address directly, it

Re: [PATCH net-next] cxgb3: assign port id to net_device->dev_port

From: Ganesh Goudar Date: Fri, 19 Jan 2018 15:11:48 +0530 > From: Arjun Vynipadath > > T3 devices have different ports on same PCI function, > so using dev_port to identify ports. > > Signed-off-by: Arjun Vynipadath > Signed-off-by:

Re: [PATCH] bridge: return boolean instead of integer in br_multicast_is_router

From: "Gustavo A. R. Silva" Date: Thu, 18 Jan 2018 17:37:45 -0600 > Return statements in functions returning bool should use > true/false instead of 1/0. > > This issue was detected with the help of Coccinelle. > > Signed-off-by: Gustavo A. R. Silva

Re: [PATCH net-next v2] net: stmmac: Fix reception of Broadcom switches tags

From: Florian Fainelli Date: Thu, 18 Jan 2018 15:12:21 -0800 > Broadcom tags inserted by Broadcom switches put a 4 byte header after > the MAC SA and before the EtherType, which may look like some sort of 0 > length LLC/SNAP packet (tcpdump and wireshark do think that way).

[PATCH] vmxnet3: repair memory leak

with the introduction of commit b0eb57cb97e7837ebb746404c2c58c6f536f23fa, it appears that rq->buf_info is improperly handled. While it is heap allocated when an rx queue is setup, and freed when torn down, an old line of code in vmxnet3_rq_destroy was not properly removed, leading to

Re: [PATCH V2 net-next 0/4] add some features to hns3 driver

From: Peng Li Date: Fri, 19 Jan 2018 14:41:08 +0800 > This patchset adds some features to hns3 driver, include the support > for ethtool command -d, -p and support for manager table. > > [Patch 1/4] adds support for ethtool command -d, its ops is get_regs. > driver will

Re: [RFC PATCH net-next v2 2/2] virtio_net: Extend virtio to use VF datapath when available

On 1/22/2018 12:27 PM, Siwei Liu wrote: First off, as mentioned in another thread, the model of stacking up virt-bond functionality over virtio seems a wrong direction to me. Essentially the migration process would need to carry over all guest side configurations previously done on the VF/PT and

Re: [PATCH net v3] gso: validate gso_type in GSO handlers

From: Willem de Bruijn Date: Fri, 19 Jan 2018 09:29:18 -0500 > From: Willem de Bruijn > > Validate gso_type during segmentation as SKB_GSO_DODGY sources > may pass packets where the gso_type does not match the contents. > > Syzkaller was

Re: [PATCH net-next 1/1] rtnetlink: request RTM_GETLINK by pid or fd

On Thu, 18 Jan 2018 21:55:53 +0100, Christian Brauner wrote: > A more concrete scenario is creating a network namespace, moving a > device into it via RTM_SETLINK which also supports IFLA_NET_NS_{FD,PID} > and then wanting to query the device. This would be very easy to do if > one could reuse the

  1   2   3   >