From: Niklas Cassel
Date: Mon, 22 Jan 2018 16:59:50 +0100
> Doing a bitwise AND between a bool and an int is generally not a good idea.
> The bool will be promoted to an int with value 0 or 1,
> the int is generally regarded as true with a non-zero value,
> thus ANDing them has the potential to y
From: Vadim Lomovtsev
Date: Mon, 22 Jan 2018 06:13:27 -0800
> From: Vadim Lomovtsev
>
> It was found that ethtool provides unexisting module name while
> it queries the specified network device for associated driver
> information. Then user tries to unload that module by provided
> module name
Wed, Jan 24, 2018 at 10:07:25PM CET, dsah...@gmail.com wrote:
>On 1/24/18 2:04 PM, Jiri Pirko wrote:
>> For the record, I still think it is odd to have 6 patches just to add
>> one arg to a function. I wonder where this unnecessary patch splits
>> would lead to in the future.
>
>I think it made the
On 1/24/18, 12:02 PM, "netdev-ow...@vger.kernel.org on behalf of Yuchung Cheng"
wrote:
On Tue, Jan 23, 2018 at 11:58 PM, Lawrence Brakmo wrote:
> Adds support for calling sock_ops BPF program when there is a
> retransmission. Two arguments are used; one for the sequence number and
From: Jeff Kirsher
Date: Wed, 24 Jan 2018 12:55:12 -0800
> This series contains updates to igb and e1000e only.
Pulled, however:
> Corinna Vinschen implements the ability to set the VF MAC to
> 00:00:00:00:00:00 via RTM_SETLINK on the PF, to prevent receiving
> "invlaid argument" when libvirt a
On 1/24/18 2:04 PM, Jiri Pirko wrote:
> For the record, I still think it is odd to have 6 patches just to add
> one arg to a function. I wonder where this unnecessary patch splits
> would lead to in the future.
I think it made the review much easier than 1 really long patch.
Wed, Jan 24, 2018 at 09:54:12PM CET, jakub.kicin...@netronome.com wrote:
>Hi!
>
>This series some of Jiri's comments and the fact that today drivers
>may produce extack even if there is no skip_sw flag (meaning the
>driver failure is not really a problem), and warning messages will
>only confuse th
From: Jakub Kicinski
Date: Wed, 24 Jan 2018 12:54:12 -0800
> This series some of Jiri's comments and the fact that today drivers
> may produce extack even if there is no skip_sw flag (meaning the
> driver failure is not really a problem), and warning messages will
> only confuse the users.
...
>
On Wed, 24 Jan 2018 13:54:16 +, Stachura, Mariusz wrote:
> >On Tue, 23 Jan 2018 10:55:33 +, Stachura, Mariusz wrote:
> >> As for review:
> >> 1) nit: reverse christmas tree
> >> I'm fixing it.
> >> 2) Are abilities guaranteed to be filled in by this function? Otherwise
> >> you will
From: Matt Turner
I personally spent a long time trying to decypher why my CPU would not
reach deeper C-states. Let's just tell the next user what's going on.
Signed-off-by: Matt Turner
Acked-by: Shannon Nelson
Tested-by: Aaron Brown
Signed-off-by: Jeff Kirsher
---
drivers/net/ethernet/inte
This series contains updates to igb and e1000e only.
Corinna Vinschen implements the ability to set the VF MAC to
00:00:00:00:00:00 via RTM_SETLINK on the PF, to prevent receiving
"invlaid argument" when libvirt attempts to restore the MAC address back
to its original state of 00:00:00:00:00:00.
From: Corinna Vinschen
Before libvirt modifies the MAC address and vlan tag for an SRIOV VF
for use by a virtual machine (either using vfio device assignment or
macvtap passthru mode), it saves the current MAC address and vlan tag
so that it can reset them to their original value when the guest i
From: Matt Turner
According to section 12.0.3.4.13 "Receive Descriptor Control - RXDCTL"
of the Intel® 82579 Gigabit Ethernet PHY Datasheet v2.1:
"HTHRESH should be given a non zero value when ever PTHRESH is
used."
In RXDCTL(0), PTHRESH lives at bits 5:0, and HTHREST lives at bits 13:
From: Daniel Hua
Problem description:
After ethernet cable connect and disconnect for several iterations on a
device with i210, tx timestamp will stop being put into the socket.
Steps to reproduce:
1. Setup a device with i210 and wire it to a 802.1AS capable switch (
Extreme Networks Summit x440
From: Lyude Paul
Recently I got a Caldigit TS3 Thunderbolt 3 dock, and noticed that upon
hotplugging my kernel would immediately crash due to igb:
[ 680.825801] kernel BUG at drivers/pci/msi.c:352!
[ 680.828388] invalid opcode: [#1] SMP
[ 680.829194] Modules linked in: igb(O) thunderbolt
cls_bpf now guarantees that only device-bound programs are
allowed with skip_sw. The drivers no longer pay attention to
flags on filter load, therefore the bpf_offload member can be
removed. If flags are needed again they should probably be
added to struct tc_cls_common_offload instead.
Signed-o
From: Markus Elfring
Omit an extra message for a memory allocation failure in this function.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring
Tested-by: Aaron Brown
Signed-off-by: Jeff Kirsher
---
drivers/net/ethernet/intel/igb/igb_main.c | 2 --
1 fil
Propagate extack to cls->destroy callbacks when called from
non-error paths. On error paths pass NULL to avoid overwriting
the failure message.
Signed-off-by: Jakub Kicinski
Reviewed-by: Simon Horman
---
include/net/sch_generic.h | 3 ++-
net/sched/cls_api.c | 15 ---
net/sc
Propagate extack on removal of offloaded filter. Don't pass
extack from error paths.
Signed-off-by: Jakub Kicinski
Reviewed-by: Simon Horman
---
net/sched/cls_flower.c | 18 ++
1 file changed, 10 insertions(+), 8 deletions(-)
diff --git a/net/sched/cls_flower.c b/net/sched/cls
Pass offload flags to the new implementation of
tc_cls_common_offload_init(). Extack will now only
be set if user requested skip_sw.
Signed-off-by: Jakub Kicinski
Reviewed-by: Simon Horman
---
net/sched/cls_matchall.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/net/
Propagate extack on removal of offloaded filter.
Signed-off-by: Jakub Kicinski
Reviewed-by: Simon Horman
---
net/sched/cls_bpf.c | 14 --
1 file changed, 8 insertions(+), 6 deletions(-)
diff --git a/net/sched/cls_bpf.c b/net/sched/cls_bpf.c
index 323b01f76a4c..8e5326bc6440 100644
-
Hi!
This series some of Jiri's comments and the fact that today drivers
may produce extack even if there is no skip_sw flag (meaning the
driver failure is not really a problem), and warning messages will
only confuse the users.
First patch propagates extack to destroy as requested by Jiri, extack
From: Tom Herbert
Date: Wed, 24 Jan 2018 12:35:39 -0800
> In this patch set:
>
> - Don't allow attaching non-TCP or listener sockets to a KCM mux.
> - In kcm_attach Check if sk_user_data is already set. This is
> under lock to avoid race conditions. More work is need to make
> all of the use
From: Jesus Sanchez-Palencia
By design, the idleslope increments are restricted to 16.384kbps steps.
Add a comment to igb_main.c making that explicit and add one example
that illustrates the impact of that.
Signed-off-by: Jesus Sanchez-Palencia
Tested-by: Aaron Brown
Signed-off-by: Jeff Kirshe
Propagate extack on removal of offloaded filter. Don't pass
extack from error paths.
Signed-off-by: Jakub Kicinski
Reviewed-by: Simon Horman
---
net/sched/cls_u32.c | 34 +++---
1 file changed, 19 insertions(+), 15 deletions(-)
diff --git a/net/sched/cls_u32.c b/ne
From: Zhang Shengju
This patch adds a new function igb_get_max_rss_queues() to get maximum
RSS queues, this will reduce duplicate code and facilitate future
maintenance.
Signed-off-by: Zhang Shengju
Tested-by: Aaron Brown
Signed-off-by: Jeff Kirsher
---
drivers/net/ethernet/intel/igb/igb.h
All users are now converted to tc_cls_common_offload_init().
Signed-off-by: Jakub Kicinski
Reviewed-by: Simon Horman
---
include/net/pkt_cls.h | 11 ---
1 file changed, 11 deletions(-)
diff --git a/include/net/pkt_cls.h b/include/net/pkt_cls.h
index 85cee929b9ce..1a41513cec7f 100644
--
Pass offload flags to the new implementation of
tc_cls_common_offload_init(). Extack will now only
be set if user requested skip_sw.
Signed-off-by: Jakub Kicinski
Reviewed-by: Simon Horman
---
net/sched/cls_flower.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/net/
Pass offload flags to the new implementation of
tc_cls_common_offload_init(). Extack will now only
be set if user requested skip_sw. hnodes need to
hold onto the flags now to be able to reuse them
on filter removal.
Signed-off-by: Jakub Kicinski
Reviewed-by: Simon Horman
---
net/sched/cls_u32
Propagate extack on removal of offloaded filter. Don't pass
extack from error paths.
Signed-off-by: Jakub Kicinski
Reviewed-by: Simon Horman
---
net/sched/cls_matchall.c | 9 +
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/net/sched/cls_matchall.c b/net/sched/cls_matcha
Pass offload flags to the new implementation of
tc_cls_common_offload_init(). Extack will now only
be set if user requested skip_sw.
Signed-off-by: Jakub Kicinski
Reviewed-by: Simon Horman
---
net/sched/cls_bpf.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/net/sche
Rename the tc_cls_common_offload_init() helper function to
tc_cls_common_offload_init_deprecated() and add a new implementation
which also takes flags argument. We will only set extack if flags
indicate that offload is forced (skip_sw) otherwise driver errors
should be ignored, as they don't influ
On Wed, 2018-01-24 at 12:35 -0800, Tom Herbert wrote:
> This is needed to prevent sk_user_data being overwritten.
> The check is done under the callback lock. This should prevent
> a socket from being attached twice to a KCM mux. It also prevents
> a socket from being attached for other use cases o
Al this series looks fine to me, want me to toss it into net-next?
On Wed, 2018-01-24 at 12:35 -0800, Tom Herbert wrote:
> TCP sockets for IPv4 and IPv6 that are not listeners or in closed
> stated are allowed to be attached to a KCM mux.
>
> Fixes: ab7ac4eb9832 ("kcm: Kernel Connection Multiplexor module")
> Reported-by: syzbot+8865eaff7f9acd593...@syzkaller.app
In this patch set:
- Don't allow attaching non-TCP or listener sockets to a KCM mux.
- In kcm_attach Check if sk_user_data is already set. This is
under lock to avoid race conditions. More work is need to make
all of the users of sk_user_data to use the same locking.
- v2
Remove unncessary
TCP sockets for IPv4 and IPv6 that are not listeners or in closed
stated are allowed to be attached to a KCM mux.
Fixes: ab7ac4eb9832 ("kcm: Kernel Connection Multiplexor module")
Reported-by: syzbot+8865eaff7f9acd593...@syzkaller.appspotmail.com
Signed-off-by: Tom Herbert
---
net/kcm/kcmsock.c
This is needed to prevent sk_user_data being overwritten.
The check is done under the callback lock. This should prevent
a socket from being attached twice to a KCM mux. It also prevents
a socket from being attached for other use cases of sk_user_data
as long as the other cases set sk_user_data und
On 1/24/18 11:58 AM, Yuchung Cheng wrote:
On Tue, Jan 23, 2018 at 11:57 PM, Lawrence Brakmo wrote:
Currently, a sock_ops BPF program can write the op field and all the
reply fields (reply and replylong). This is a bug. The op field should
not have been writeable and there is currently no way to
On Tue, Jan 23, 2018 at 11:57 PM, Lawrence Brakmo wrote:
> Add support for reading many more tcp_sock fields
>
> state,same as sk->sk_state
> rtt_min same as sk->rtt_min.s[0].v (current rtt_min)
> snd_ssthresh
> rcv_nxt
> snd_nxt
> snd_una
> mss_cache
> ecn_flags
>
From: Dmitry Safonov
Date: Thu, 18 Jan 2018 18:31:32 +
> v2:
> o fixed a nitpick from David Miller
>
> There are a bunch of fixes/cleanups/Documentations.
> Diffstat says for itself, regardless added docs and missed flag
> parameters.
Series applied to net-next, thank you.
On Tue, Jan 23, 2018 at 11:58 PM, Lawrence Brakmo wrote:
> Adds support for calling sock_ops BPF program when there is a
> retransmission. Two arguments are used; one for the sequence number and
> other for the number of segments retransmitted. Does not include syn-ack
> retransmissions.
>
> New o
On Tue, Jan 23, 2018 at 11:57 PM, Lawrence Brakmo wrote:
> Currently, a sock_ops BPF program can write the op field and all the
> reply fields (reply and replylong). This is a bug. The op field should
> not have been writeable and there is currently no way to use replylong
> field for indices >= 1
From: Wolfgang Bumiller
Date: Thu, 18 Jan 2018 11:32:35 +0100
> 'ptr' is shifted by the offset and then validated,
> the memcmp should not add it a second time.
>
> Signed-off-by: Wolfgang Bumiller
Applied.
Hello,
How are you and your family?
Thanks for accepting my connection.
I am connecting you due to a Business Opportunity.
Should you like to know more about it.
Do get back to me so i give you further details.
I hope to hear from you soon
Regards,
MR. YIN LIANCHEN
CHIEF INVESTMENT OFFICER
CHIN
From: Wolfgang Bumiller
Date: Thu, 18 Jan 2018 11:32:36 +0100
> TCF_LAYER_LINK and TCF_LAYER_NETWORK returned the same pointer as
> skb->data points to the network header.
> Use skb_mac_header instead.
>
> Signed-off-by: Wolfgang Bumiller
Applied with Subject changed to be more consistent "net
On Wed, 24 Jan 2018 10:37:59 -0500 (EST), David Miller wrote:
> From: Jakub Kicinski
> Date: Tue, 23 Jan 2018 18:45:58 -0800
>
> > Rename tc_cls_common_offload_init() to tc_cls_common_offload_init__()
> > and add a new implementation which also takes flags argument. We will
> > only set extack i
From: Jeff Kirsher
Date: Wed, 24 Jan 2018 08:59:23 -0800
> On Tue, Jan 23, 2018 at 10:20 AM, Jeff Kirsher
> wrote:
>> This series contains updates to ixgbe only.
>>
>> Shannon Nelson provides an implementation of the ipsec hardware offload
>> feature for the ixgbe driver for these devices: x540,
Christoph Hellwig writes:
> This is the io_getevents equivalent of ppoll/pselect and allows to
> properly mix signals and aio completions (especially with IOCB_CMD_POLL)
> and atomically executes the following sequence:
>
> sigset_t origmask;
>
> pthread_sigmask(SIG_SETMASK, &sigmask,
Christoph Hellwig writes:
> Simple one-shot poll through the io_submit() interface. To poll for
> a file descriptor the application should submit an iocb of type
> IOCB_CMD_POLL. It will poll the fd for the events specified in the
> the first 32 bits of the aio_buf field of the iocb.
>
> Unlike
Originally the erspan fields are defined as a group into a __be16 field,
and use mask and offset to access each field. This is more costly due to
calling ntohs/htons. The patch changes it to use bitfields.
Signed-off-by: William Tu
---
include/net/erspan.h | 127 +++
The first patch refactors the erspan header definitions.
Originally, the erspan fields are defined as a group into a __be16 field,
and use mask and offset to access each field. This is more costly due to
calling ntohs/htons and error-prone. The first patch changes it to use
bitfields. The secon
The patch adds support for openvswitch to configure erspan
v1 and v2. The OVS_TUNNEL_KEY_ATTR_ERSPAN_OPTS attr is added
to uapi as a binary blob to support all ERSPAN v1 and v2's
fields. Note that Previous commit "openvswitch: Add erspan tunnel
support." was reverted since it does not design prop
On 01/23/2018 10:16 AM, Daniel Borkmann wrote:
> On 01/23/2018 06:18 AM, John Fastabend wrote:
>> On 01/22/2018 09:01 PM, Alexei Starovoitov wrote:
>>> On Tue, Jan 23, 2018 at 01:55:30PM +0900, Prashant Bhole wrote:
On 1/23/2018 1:38 PM, Alexei Starovoitov wrote:
> On Tue, Jan 23, 2018 at
While there check return from get_prefix() for filter address.
Signed-off-by: Serhey Popovych
---
ip/ipneigh.c | 13 -
1 file changed, 4 insertions(+), 9 deletions(-)
diff --git a/ip/ipneigh.c b/ip/ipneigh.c
index 11f280d..0735424 100644
--- a/ip/ipneigh.c
+++ b/ip/ipneigh.c
@@ -2
Introduce and use tnl_print_endpoint() helper to print of tunnel
endpoint address.
Note that for AF_INET and AF_INET6 inet_ntop(3) is used that may return
NULL in case of failure and while unlikely format_host_rta() might
return NULL too. Handle this case when passing local/remote to
print_string(
While there check return from get_prefix() for filter address.
Signed-off-by: Serhey Popovych
---
ip/ipmroute.c | 26 ++
1 file changed, 10 insertions(+), 16 deletions(-)
diff --git a/ip/ipmroute.c b/ip/ipmroute.c
index 0450ea9..aa5029b 100644
--- a/ip/ipmroute.c
+++ b
While there check return from get_prefix() for filter address.
Signed-off-by: Serhey Popovych
---
ip/ipaddress.c | 29 +
1 file changed, 9 insertions(+), 20 deletions(-)
diff --git a/ip/ipaddress.c b/ip/ipaddress.c
index ba60125..44894e6 100644
--- a/ip/ipaddress.c
Signed-off-by: Serhey Popovych
---
ip/ipl2tp.c | 37 -
1 file changed, 16 insertions(+), 21 deletions(-)
diff --git a/ip/ipl2tp.c b/ip/ipl2tp.c
index 7c5ed31..8aaee74 100644
--- a/ip/ipl2tp.c
+++ b/ip/ipl2tp.c
@@ -296,7 +296,7 @@ static int get_response(stru
While there remove & from inet_prefix.data when since it is array.
Signed-off-by: Serhey Popovych
---
ip/tcp_metrics.c | 60 +++---
1 file changed, 30 insertions(+), 30 deletions(-)
diff --git a/ip/tcp_metrics.c b/ip/tcp_metrics.c
index 3f9790e.
First is used to get address from netlink attribute to
inet_prefix data structure. Use memcpy() with constant
value to let complier optimize by replacing a call by
inlining load/store instructions.
Second is used to match address in given netlink attribute
with one given as reference. It matches s
While there check return from get_prefix() for filter address.
Signed-off-by: Serhey Popovych
---
ip/iprule.c | 36 ++--
1 file changed, 18 insertions(+), 18 deletions(-)
diff --git a/ip/iprule.c b/ip/iprule.c
index 96695d8..a3abf2f 100644
--- a/ip/iprule.c
+++
Now we enhance get_addr() to return additional information about address
(e.g. if it unspecified or multicast) we want to have same functionality
for attributes in netlink message.
Introduce and use get_addr_rta() that parses given netlink attribute
into @inet_prefix data structure in the same way
On 2018-01-24 20:31, Ben Greear wrote:
On 01/24/2018 08:34 AM, Neftin, Sasha wrote:
On 1/24/2018 18:11, Alexander Duyck wrote:
On Tue, Jan 23, 2018 at 3:46 PM, Ben Greear
wrote:
Hello,
Anyone have any more suggestions for making e1000e work better?
This is
from a 4.9.65+ kernel,
with thes
On 01/24/2018 10:38 AM, Denys Fedoryshchenko wrote:
On 2018-01-24 20:31, Ben Greear wrote:
On 01/24/2018 08:34 AM, Neftin, Sasha wrote:
On 1/24/2018 18:11, Alexander Duyck wrote:
On Tue, Jan 23, 2018 at 3:46 PM, Ben Greear wrote:
Hello,
Anyone have any more suggestions for making e1000e wor
On 1/23/18 12:19 PM, Serhey Popovych wrote:
> Introduce and use tnl_print_endpoint() helper to print
> of tunnel endpoint address.
>
> Note that for AF_INET and AF_INET6 inet_ntop(3) is used
> that may return NULL in case of failure and while unlikely
> format_host_rta() might return NULL too. Han
On 01/24/2018 08:34 AM, Neftin, Sasha wrote:
On 1/24/2018 18:11, Alexander Duyck wrote:
On Tue, Jan 23, 2018 at 3:46 PM, Ben Greear wrote:
Hello,
Anyone have any more suggestions for making e1000e work better? This is
from a 4.9.65+ kernel,
with these additional e1000e patches applied:
e100
On 1/22/18 10:23 AM, Serhey Popovych wrote:
> With this series I want to unify collect metadata
> handling in tunnels:
>
> 1) Use "external" name for JSON and non-JSON output.
>
> Do not *print* any options when tunnel in
> collect metadata mode: gre6 already do
> this, so just a
Hi,
First, thanks for taking a look at this.
On 01/23/2018 01:53 AM, Antoine Tenart wrote:
Hi Jeremy,
On Mon, Jan 22, 2018 at 05:14:27PM -0600, Jeremy Linton wrote:
I'm running 4.15rc7 and hitting the following crash on the MACCHIATObin.
This is 100% reproducible once the adapter is given a
On 1/24/18 10:09 AM, Stephen Hemminger wrote:
> On Wed, 24 Jan 2018 08:29:24 -0800
> David Ahern wrote:
>
>> IPv6 allows routes to be installed when the device is not up (admin up).
>> Worse, it does not mark it as LINKDOWN. IPv4 does not allow it and really
>> there is no reason for IPv6 to allo
On 1/24/18 10:23 AM, Eric Dumazet wrote:
> On Wed, 2018-01-24 at 08:29 -0800, David Ahern wrote:
>> IPv6 allows routes to be installed when the device is not up (admin up).
>> Worse, it does not mark it as LINKDOWN. IPv4 does not allow it and really
>> there is no reason for IPv6 to allow it, so ch
On Wed, 2018-01-24 at 08:29 -0800, David Ahern wrote:
> IPv6 allows routes to be installed when the device is not up (admin up).
> Worse, it does not mark it as LINKDOWN. IPv4 does not allow it and really
> there is no reason for IPv6 to allow it, so check the flags and deny if
> device is admin do
Hello Marc,
thank you for Acking the patch, just wondering if this patch has any chance to
end up in v4.16?
Thanks,
Fab
> Subject: [PATCH 1/8] dt-bindings: can: rcar_can: document r8a774[35] can
> support
>
> Document "renesas,can-r8a7743" and "renesas,can-r8a7745" compatible
> strings. Since
On Wed, 24 Jan 2018 08:29:24 -0800
David Ahern wrote:
> IPv6 allows routes to be installed when the device is not up (admin up).
> Worse, it does not mark it as LINKDOWN. IPv4 does not allow it and really
> there is no reason for IPv6 to allow it, so check the flags and deny if
> device is admin
On Tue, Jan 23, 2018 at 10:20 AM, Jeff Kirsher
wrote:
> This series contains updates to ixgbe only.
>
> Shannon Nelson provides an implementation of the ipsec hardware offload
> feature for the ixgbe driver for these devices: x540, x550, 82599.
>
> The ixgbe NICs support ipsec offload for 1024 Rx
On Wed, 2018-01-24 at 08:48 -0800, Alexei Starovoitov wrote:
> On 1/24/18 7:48 AM, Eric Dumazet wrote:
> > On Wed, 2018-01-24 at 07:27 -0800, Alexei Starovoitov wrote:
> > >
> > > Most of the time, Yes, but it's the other way around this time.
> > > I specifically asked Larry to do it this way, si
On Mon, 22 Jan 2018 11:53:46 +0100
Wolfgang Bumiller wrote:
> The lexer will go with the longest match, so previously
> the starting double quotes of a string would be swallowed by
> the [^ \t\r\n()]+ pattern leaving the user no way to
> actually use strings with escape sequences.
> Fix this by n
On 1/24/18 7:48 AM, Eric Dumazet wrote:
On Wed, 2018-01-24 at 07:27 -0800, Alexei Starovoitov wrote:
Most of the time, Yes, but it's the other way around this time.
I specifically asked Larry to do it this way, since net tree is
practically closed (only critical fixes allowed).
When 4.15 is rel
Interestingly, we thought we had just been seeing this on the second
nic. However, we've went back through some older logs and realized that
it's been happening on the first nic as well, though it's presenting
itself slightly differently there (ping just says "Destination Host
Unreachable").
On Wed, 24 Jan 2018 16:24:34 +0100, Nicolas Dichtel wrote:
> I wonder if it would be possible to do something in the netlink framework,
> like
> NETLINK_LISTEN_ALL_NSID.
> Having some ancillary data at the netlink socket level and a function like
> nlsock_net() (instead of sock_net()) to get the c
On 1/24/2018 18:11, Alexander Duyck wrote:
On Tue, Jan 23, 2018 at 3:46 PM, Ben Greear wrote:
Hello,
Anyone have any more suggestions for making e1000e work better? This is
from a 4.9.65+ kernel,
with these additional e1000e patches applied:
e1000e: Fix error path in link detection
e1000e: F
IPv6 allows routes to be installed when the device is not up (admin up).
Worse, it does not mark it as LINKDOWN. IPv4 does not allow it and really
there is no reason for IPv6 to allow it, so check the flags and deny if
device is admin down.
Signed-off-by: David Ahern
---
v2
- missed setting err t
On Tue, Jan 23, 2018 at 3:46 PM, Ben Greear wrote:
> Hello,
>
> Anyone have any more suggestions for making e1000e work better? This is
> from a 4.9.65+ kernel,
> with these additional e1000e patches applied:
>
> e1000e: Fix error path in link detection
> e1000e: Fix wrong comment related to link
Wed, Jan 24, 2018 at 12:42:55PM CET, sathya.pe...@broadcom.com wrote:
>When a filter cannot be added in HW (i.e, fl_hw_replace_filter() returns
>error), the TCA_CLS_FLAGS_IN_HW flag is not set in the filter flags.
>
>This flag (via tc_in_hw()) must be checked before issuing the call
>to delete a fi
On Wed, Jan 24, 2018 at 12:35 AM, Benjamin Poirier
wrote:
> On 2018/01/22 10:01, Alexander Duyck wrote:
> [...]
>> >
>> > If the patch that I submitted for the current vmware issue is merged,
>> > the significant commits that are left are:
>> >
>> > 0a8047ac68e5 e1000e: Fix msi-x interrupt automas
From: Jiri Pirko
Date: Wed, 24 Jan 2018 10:02:09 +0100
> From: Yuval Mintz
>
> Driver periodically samples all neighbors configured in device
> in order to update the kernel regarding their state. When finding
> an entry configured in HW that doesn't show in neigh_lookup()
> driver logs an erro
From: Rahul Lakkireddy
Date: Wed, 24 Jan 2018 13:31:03 +0530
> Patch 1 fixes build error with compiling cudbg_zlib.c when
> CONFIG_ZLIB_DEFLATE macro is not defined.
>
> Patch 2 fixes following sparse warning:
> "Using plain integer as NULL pointer"
Series applied, thanks Rahul.
From: Ursula Braun
Date: Wed, 24 Jan 2018 10:28:11 +0100
> while the first 2 patches are just small cleanups, the remaing
> patches affect socket closing.
Series applied, thanks!
Forwarding this to netdev because group may have different opinions.
IMHO netlink is a multicast communication mechanism and therefore not it does
not have the close semantics of other connection oriented protocols.
Therefore this is not a bug.
Begin forwarded message:
Date: Wed, 24 Jan 2018 12:2
From: Ganesh Goudar
Date: Wed, 24 Jan 2018 20:44:07 +0530
> implement ndo_set_vf_vlan for mgmt netdevice to configure
> the PCIe VF.
>
> Original work by: Casey Leedom
> Signed-off-by: Ganesh Goudar
> ---
> V2: changing htonl() to cpu_to_be32() to maintain consistency
Applied, thanks.
On Wed, 2018-01-24 at 07:27 -0800, Alexei Starovoitov wrote:
>
> Most of the time, Yes, but it's the other way around this time.
> I specifically asked Larry to do it this way, since net tree is
> practically closed (only critical fixes allowed).
> When 4.15 is released on Sunday we'll send this p
Luis de Bethencourt wrote:
> The trailing semicolon is an empty statement that does no operation.
> Removing it since it doesn't do anything.
>
> Signed-off-by: Luis de Bethencourt
> Acked-by: Jes Sorensen
Patch applied to wireless-drivers-next.git, thanks.
8054a275de08 rtl8xxxu: Fix trailin
On Wed, 24 Jan 2018 10:19:24 +0100
Phil Sutter wrote:
> Hi Stephen,
>
> On Tue, Jan 23, 2018 at 02:44:42PM -0800, Stephen Hemminger wrote:
> > On Tue, 23 Jan 2018 17:40:47 +0100
> > Phil Sutter wrote:
> >
> > > The following command segfaults if enp0s31f6 does not exist:
> > >
> > > | # ip
On 01/24/2018 08:48 AM, Wang YanQing wrote:
> If we then OR this with 0x40, then the value of 6th bit (0th is first bit)
> become known, so the right mask is 0xbf instead of 0xcf.
>
> Signed-off-by: Wang YanQing
Applied to bpf-next, thanks Wang!
From: Jakub Kicinski
Date: Tue, 23 Jan 2018 18:45:58 -0800
> Rename tc_cls_common_offload_init() to tc_cls_common_offload_init__()
> and add a new implementation which also takes flags argument. We will
> only set extack if flags indicate that offload is forced (skip_sw)
> otherwise driver error
Le 24/01/2018 à 10:49, Roman Kapl a écrit :
> On 01/24/2018 10:16 AM, Xin Long wrote:
>> On Wed, Jan 24, 2018 at 6:42 AM, Roman Kapl wrote:
>>> Tunnel devices often use skb_dst(skb)->ops, but ops are not implemented
>>> for metadata tunnel destinations. Use skb_valid_dst to check if skb_dst
>>> is
From: Steffen Klassert
Date: Wed, 24 Jan 2018 10:47:09 +0100
> 1) Only offloads SAs after they are fully initialized.
>Otherwise a NIC may receive packets on a SA we can
>not yet handle in the stack.
>From Yossi Kuperman.
>
> 2) Fix negative refcount in case of a failing offload.
>
On Wed, Jan 24, 2018 at 09:57:06AM -0500, David Miller wrote:
> From: Steffen Klassert
> Date: Wed, 24 Jan 2018 10:13:25 +0100
>
> > commit 76a4201191814a0061cb5c861fafb9ecaa764846 upstream.
> >
> > We need to run xfrm_resolve_and_create_bundle() with
> > bottom halves off. Otherwise we may reus
On 1/24/18 6:14 AM, Eric Dumazet wrote:
On Tue, 2018-01-23 at 23:57 -0800, Lawrence Brakmo wrote:
This patchset adds support for:
- direct R or R/W access to many tcp_sock fields
- passing up to 4 arguments to sock_ops BPF functions
- tcp_sock field bpf_sock_ops_cb_flags for controlling callbac
Hi,
Le 24/01/2018 à 15:26, Christian Brauner a écrit :
> Hi,
>
> Based on the previous discussion this enables passing a IFLA_IF_NETNSID
> property along with RTM_SETLINK and RTM_DELLINK requests. The patch for
> RTM_NEWLINK will be sent out in a separate patch since there are more
> corner-cases
101 - 200 of 277 matches
Mail list logo
