Re: [PATCH v3] net: macb: Handle HRESP error

2018-01-26 Thread Harini Katakam
Hi David, On Sat, Jan 27, 2018 at 12:09 PM, wrote: > From: Harini Katakam > > Handle HRESP error by doing a SW reset of RX and TX and > re-initializing the descriptors, RX and TX queue pointers. > > Signed-off-by: Harini Katakam

[PATCH v3] net: macb: Handle HRESP error

2018-01-26 Thread harinikatakamlinux
From: Harini Katakam Handle HRESP error by doing a SW reset of RX and TX and re-initializing the descriptors, RX and TX queue pointers. Signed-off-by: Harini Katakam Signed-off-by: Michal Simek --- v3 and v2 changes:

[PATCH v2] net: macb: Handle HRESP error

2018-01-26 Thread harinikatakamlinux
From: Harini Katakam Handle HRESP error by doing a SW reset of RX and TX and re-initializing the descriptors, RX and TX queue pointers. Signed-off-by: Harini Katakam Signed-off-by: Michal Simek --- v2: Rebased on top of

[PATCH v2] net: macb: Handle HRESP error

2018-01-26 Thread harinikatakamlinux
From: Harini Katakam Handle HRESP error by doing a SW reset of RX and TX and re-initializing the descriptors, RX and TX queue pointers. Signed-off-by: Harini Katakam Signed-off-by: Michal Simek --- v2: Rebased on top of

[PATCH v2] net: macb: Handle HRESP error

2018-01-26 Thread harinikatakamlinux.com
From: Harini Katakam Handle HRESP error by doing a SW reset of RX and TX and re-initializing the descriptors, RX and TX queue pointers. Signed-off-by: Harini Katakam Signed-off-by: Michal Simek --- v2: Rebased on top of

Re: [virtio-dev] Re: [RFC PATCH net-next v2 2/2] virtio_net: Extend virtio to use VF datapath when available

2018-01-26 Thread Jakub Kicinski
On Fri, 26 Jan 2018 21:33:01 -0800, Samudrala, Sridhar wrote: > >> 3 netdev model breaks this configuration starting with the creation > >> and naming of the 2 devices to udev needing to be aware of master and > >> slave virtio-net devices. > > I don't understand this comment. There is one

Re: [virtio-dev] Re: [RFC PATCH net-next v2 2/2] virtio_net: Extend virtio to use VF datapath when available

2018-01-26 Thread Samudrala, Sridhar
On 1/26/2018 6:30 PM, Jakub Kicinski wrote: On Fri, 26 Jan 2018 15:30:35 -0800, Samudrala, Sridhar wrote: On 1/26/2018 2:47 PM, Jakub Kicinski wrote: On Sat, 27 Jan 2018 00:14:20 +0200, Michael S. Tsirkin wrote: On Fri, Jan 26, 2018 at 01:46:42PM -0800, Siwei Liu wrote: and the VM is not

Re: [PATCH v2] net: macb: Handle HRESP error

2018-01-26 Thread Harini Katakam
Hi David, On Fri, Jan 26, 2018 at 9:25 PM, David Miller wrote: > From: Harini Katakam > Date: Fri, 26 Jan 2018 16:12:11 +0530 > >> From: Harini Katakam >> >> Handle HRESP error by doing a SW reset of RX and TX and >>

Re: [PATCH] atm: firestream: Replace GFP_ATOMIC with GFP_KERNEL in fs_send

2018-01-26 Thread Jia-Ju Bai
On 2018/1/27 1:08, Al Viro wrote: On Fri, Jan 26, 2018 at 11:07:39AM -0500, David Miller wrote: This is found by a static analysis tool named DCNS written by myself. The trouble is, places like net/atm/raw.c:65: vcc->send = atm_send_aal0; net/atm/raw.c:74: vcc->send =

[PATCH bpf-next] netdevsim: fix overflow on the error path

2018-01-26 Thread Jakub Kicinski
Undo loop condition on the error path would cause the i counter to go below zero, if allocation failure happened with the first (i.e. 0th) element of the array. Fixes: 395cacb5f1a0 ("netdevsim: bpf: support fake map offload") Reported-by: Dan Carpenter Signed-off-by:

Re: [virtio-dev] Re: [RFC PATCH net-next v2 2/2] virtio_net: Extend virtio to use VF datapath when available

2018-01-26 Thread Jakub Kicinski
On Fri, 26 Jan 2018 15:30:35 -0800, Samudrala, Sridhar wrote: > On 1/26/2018 2:47 PM, Jakub Kicinski wrote: > > On Sat, 27 Jan 2018 00:14:20 +0200, Michael S. Tsirkin wrote: > >> On Fri, Jan 26, 2018 at 01:46:42PM -0800, Siwei Liu wrote: > and the VM is not expected to do any

pull-request: bpf-next 2018-01-26

2018-01-26 Thread Alexei Starovoitov
Hi David, The following pull-request contains BPF updates for your *net-next* tree. The main changes are: 1) A number of extensions to tcp-bpf, from Lawrence. - direct R or R/W access to many tcp_sock fields via bpf_sock_ops - passing up to 3 arguments to bpf_sock_ops functions -

Re: [PATCH bpf-next v7 3/5] libbpf: add error reporting in XDP

2018-01-26 Thread Daniel Borkmann
On 01/25/2018 01:05 AM, Eric Leblond wrote: > Parse netlink ext attribute to get the error message returned by > the card. Code is partially take from libnl. > > We add netlink.h to the uapi include of tools. And we need to > avoid include of userspace netlink header to have a successful > build

Re: [PATCH bpf-next v7 2/5] libbpf: add function to setup XDP

2018-01-26 Thread Daniel Borkmann
On 01/25/2018 01:05 AM, Eric Leblond wrote: > Most of the code is taken from set_link_xdp_fd() in bpf_load.c and > slightly modified to be library compliant. > > Signed-off-by: Eric Leblond > Acked-by: Alexei Starovoitov > --- > tools/lib/bpf/bpf.c| 127 >

Re: general protection fault in __lock_acquire (2)

2018-01-26 Thread Eric Biggers
On Thu, Nov 02, 2017 at 03:55:00AM -0700, syzbot wrote: > Hello, > > syzkaller hit the following crash on > fa8785e862ef644f742558f1a8c91eca6f3f0004 > git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/master > compiler: gcc (GCC) 7.1.1 20170620 > .config is attached > Raw console

Re: [PATCH bpf-next 0/2] bpf: fix kernel page fault in lpm map trie_get_next_key

2018-01-26 Thread Alexei Starovoitov
On Fri, Jan 26, 2018 at 03:06:06PM -0800, Yonghong Song wrote: > A kernel page fault which happens in lpm map trie_get_next_key is reported > by syzbot and Eric. The issue was introduced by commit b471f2f1de8b > ("bpf: implement MAP_GET_NEXT_KEY command for LPM_TRIE map"). > Patch #1 fixed the

Re: [PATCH bpf-next 00/13] BPF improvements and fixes

2018-01-26 Thread Alexei Starovoitov
On Fri, Jan 26, 2018 at 11:33:35PM +0100, Daniel Borkmann wrote: > This set contains a small cleanup in cBPF prologue generation and > otherwise fixes an outstanding issue related to BPF to BPF calls > and exception handling. For details please see related patches. > Last but not least, BPF

[bridge] IGMP/MLD snooping per port and per VLAN support

2018-01-26 Thread Joachim Nilsson
Hi, longtime lurker, first time poster. In the "new" VLAN aware bridge, is there anyone else except me (and possibly Cumulus) thinking about per port *and* per VLAN support for IGMP/MLD snooping in the bridge? By that I mean bridge support for per port and per VLAN querier, and group

[RFC 2/2] Revert "hv_netvsc: netvsc_teardown_gpadl() split"

2018-01-26 Thread Stephen Hemminger
This reverts commit 0cf737808ae7cb25e952be619db46b9147a92f46. The problem that the previous commit was trying to solve was that undoing the mapping of the receive buffer after revoke was problematic. This was because the shutdown logic was not ensuring that there were no receive and sends in

[RFC 1/2] hv_netvsc: make sure device is idle before changes

2018-01-26 Thread Stephen Hemminger
Make sure that device is in detached state before doing ring and mtu changes. When doing these changes, wait for all outstanding send completions and ring buffer events. Signed-off-by: Stephen Hemminger --- drivers/net/hyperv/hyperv_net.h | 1 -

[RFC 0/2] hv_netvsc shutdown redo

2018-01-26 Thread Stephen Hemminger
These patches change how teardown of Hyper-V network devices is done. These are tested on WS2012 and WS2016. It moves the tx/rx shutdown into the rndis close handling, and that makes earlier gpadl changes unnecsssary. Stephen Hemminger (2): hv_netvsc: make sure device is idle before changes

[PATCH net-next] net/mlx5e: IPoIB, Fix copy-paste bug in flow steering refactoring

2018-01-26 Thread Saeed Mahameed
From: Gal Pressman On TTC table creation, the indirection TIRs should be used instead of the inner indirection TIRs. Fixes: 1ae1df3a1193 ("net/mlx5e: Refactor RSS related objects and code") Signed-off-by: Gal Pressman Reviewed-by: Shalom Lagziel

[PATCH net] ipv6: addrconf: break critical section in addrconf_verify_rtnl()

2018-01-26 Thread Eric Dumazet
From: Eric Dumazet Heiner reported a lockdep splat [1] This is caused by attempting GFP_KERNEL allocation while RCU lock is held and BH blocked. We believe that addrconf_verify_rtnl() could run for a long period, so instead of using GFP_ATOMIC here as Ido suggested, we

Re: [RFC v2 net-next 00/10] Time based packet transmission

2018-01-26 Thread Jesus Sanchez-Palencia
Hi Levi, On 01/23/2018 05:43 PM, Levi Pearson wrote: > On Wed, Jan 17, 2018 at 4:06 PM, Jesus Sanchez-Palencia > wrote: >> This series is the v2 of the Time based packet transmission RFC, which was >> originally proposed by Richard Cochran:

Re: [virtio-dev] Re: [RFC PATCH net-next v2 2/2] virtio_net: Extend virtio to use VF datapath when available

2018-01-26 Thread Samudrala, Sridhar
On 1/26/2018 2:47 PM, Jakub Kicinski wrote: On Sat, 27 Jan 2018 00:14:20 +0200, Michael S. Tsirkin wrote: On Fri, Jan 26, 2018 at 01:46:42PM -0800, Siwei Liu wrote: and the VM is not expected to do any tuning/optimizations on the VF driver directly, i think the current patch that follows the

Re: [PATCH net-next v1] samples/bpf: Partially fixes the bpf.o build

2018-01-26 Thread Daniel Borkmann
On 01/26/2018 09:30 AM, Mickaël Salaün wrote: > On 26/01/2018 03:16, Alexei Starovoitov wrote: >> On Fri, Jan 26, 2018 at 01:39:30AM +0100, Mickaël Salaün wrote: >>> Do not build lib/bpf/bpf.o with this Makefile but use the one from the >>> library directory. This avoid making a buggy bpf.o file

[PATCH bpf-next 1/2] bpf: fix kernel page fault in lpm map trie_get_next_key

2018-01-26 Thread Yonghong Song
Commit b471f2f1de8b ("bpf: implement MAP_GET_NEXT_KEY command for LPM_TRIE map") introduces a bug likes below: if (!rcu_dereference(trie->root)) return -ENOENT; if (!key || key->prefixlen > trie->max_prefixlen) { root = >root; goto find_leftmost; } ..

[PATCH bpf-next 2/2] tools/bpf: add a multithreaded stress test in bpf selftests test_lpm_map

2018-01-26 Thread Yonghong Song
The new test will spawn four threads, doing map update, delete, lookup and get_next_key in parallel. It is able to reproduce the issue in the previous commit found by syzbot and Eric Dumazet. Signed-off-by: Yonghong Song --- tools/testing/selftests/bpf/Makefile | 2 +-

[PATCH bpf-next 0/2] bpf: fix kernel page fault in lpm map trie_get_next_key

2018-01-26 Thread Yonghong Song
A kernel page fault which happens in lpm map trie_get_next_key is reported by syzbot and Eric. The issue was introduced by commit b471f2f1de8b ("bpf: implement MAP_GET_NEXT_KEY command for LPM_TRIE map"). Patch #1 fixed the issue in the kernel and patch #2 adds a multithreaded test case in

Re: [virtio-dev] Re: [RFC PATCH net-next v2 2/2] virtio_net: Extend virtio to use VF datapath when available

2018-01-26 Thread Jakub Kicinski
On Sat, 27 Jan 2018 00:14:20 +0200, Michael S. Tsirkin wrote: > On Fri, Jan 26, 2018 at 01:46:42PM -0800, Siwei Liu wrote: > > > and the VM is not expected to do any tuning/optimizations on the VF driver > > > directly, > > > i think the current patch that follows the netvsc model of 2 > > >

Re: [PATCH bpf-next] bpf: clean up from test_tcpbpf_kern.c

2018-01-26 Thread Daniel Borkmann
On 01/26/2018 09:06 PM, Lawrence Brakmo wrote: > Removed commented lines from test_tcpbpf_kern.c > > Fixes: d6d4f60c3a09 bpf: add selftest for tcpbpf > Signed-off-by: Lawrence Brakmo Applied to bpf-next, thanks Lawrence!

Re: [PATCH bpf-next 10/13] bpf, mips64: remove obsolete exception handling from div/mod

2018-01-26 Thread David Daney
On 01/26/2018 02:33 PM, Daniel Borkmann wrote: Since we've changed div/mod exception handling for src_reg in eBPF verifier itself, remove the leftovers from mips64 JIT. Signed-off-by: Daniel Borkmann Cc: David Daney I didn't test it, but this

Re: [PATCH bpf-next 11/13] bpf, mips64: remove unneeded zero check from div/mod with k

2018-01-26 Thread David Daney
On 01/26/2018 02:33 PM, Daniel Borkmann wrote: The verifier in both cBPF and eBPF reject div/mod by 0 imm, so this can never load. Remove emitting such test and reject it from being JITed instead (the latter is actually also not needed, but given practice in sparc64, ppc64 today, so doesn't hurt

[PATCH bpf-next 00/13] BPF improvements and fixes

2018-01-26 Thread Daniel Borkmann
This set contains a small cleanup in cBPF prologue generation and otherwise fixes an outstanding issue related to BPF to BPF calls and exception handling. For details please see related patches. Last but not least, BPF selftests is extended with several new test cases. Thanks! Daniel Borkmann

[PATCH bpf-next 05/13] bpf, x86_64: remove obsolete exception handling from div/mod

2018-01-26 Thread Daniel Borkmann
Since we've changed div/mod exception handling for src_reg in eBPF verifier itself, remove the leftovers from x86_64 JIT. Signed-off-by: Daniel Borkmann Acked-by: Alexei Starovoitov --- arch/x86/net/bpf_jit_comp.c | 20 1 file

[PATCH bpf-next 13/13] bpf: add further test cases around div/mod and others

2018-01-26 Thread Daniel Borkmann
Update selftests to relfect recent changes and add various new test cases. Signed-off-by: Daniel Borkmann Acked-by: Alexei Starovoitov --- lib/test_bpf.c | 8 +- tools/testing/selftests/bpf/test_verifier.c | 343

[PATCH bpf-next 06/13] bpf, arm64: remove obsolete exception handling from div/mod

2018-01-26 Thread Daniel Borkmann
Since we've changed div/mod exception handling for src_reg in eBPF verifier itself, remove the leftovers from arm64 JIT. Signed-off-by: Daniel Borkmann Acked-by: Alexei Starovoitov --- arch/arm64/net/bpf_jit_comp.c | 13 - 1 file changed, 13

[PATCH bpf-next 04/13] bpf: fix subprog verifier bypass by div/mod by 0 exception

2018-01-26 Thread Daniel Borkmann
One of the ugly leftovers from the early eBPF days is that div/mod operations based on registers have a hard-coded src_reg == 0 test in the interpreter as well as in JIT code generators that would return from the BPF program with exit code 0. This was basically adopted from cBPF interpreter for

[PATCH bpf-next 01/13] bpf: xor of a/x in cbpf can be done in 32 bit alu

2018-01-26 Thread Daniel Borkmann
Very minor optimization; saves 1 byte per program in x86_64 JIT in cBPF prologue. Signed-off-by: Daniel Borkmann Acked-by: Alexei Starovoitov --- net/core/filter.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/core/filter.c

[PATCH bpf-next 03/13] bpf: make unknown opcode handling more robust

2018-01-26 Thread Daniel Borkmann
Recent findings by syzcaller fixed in 7891a87efc71 ("bpf: arsh is not supported in 32 bit alu thus reject it") triggered a warning in the interpreter due to unknown opcode not being rejected by the verifier. The 'return 0' for an unknown opcode is really not optimal, since with BPF to BPF calls,

[PATCH bpf-next 10/13] bpf, mips64: remove obsolete exception handling from div/mod

2018-01-26 Thread Daniel Borkmann
Since we've changed div/mod exception handling for src_reg in eBPF verifier itself, remove the leftovers from mips64 JIT. Signed-off-by: Daniel Borkmann Cc: David Daney --- arch/mips/net/ebpf_jit.c | 10 -- 1 file changed, 10 deletions(-)

[PATCH bpf-next 09/13] bpf, sparc64: remove obsolete exception handling from div/mod

2018-01-26 Thread Daniel Borkmann
Since we've changed div/mod exception handling for src_reg in eBPF verifier itself, remove the leftovers from sparc64 JIT. Signed-off-by: Daniel Borkmann Cc: David S. Miller --- arch/sparc/net/bpf_jit_comp_64.c | 18 -- 1 file changed,

[PATCH bpf-next 07/13] bpf, s390x: remove obsolete exception handling from div/mod

2018-01-26 Thread Daniel Borkmann
Since we've changed div/mod exception handling for src_reg in eBPF verifier itself, remove the leftovers from s390x JIT. Signed-off-by: Daniel Borkmann Cc: Michael Holzheu --- arch/s390/net/bpf_jit_comp.c | 10 -- 1 file changed, 10

[PATCH bpf-next 12/13] bpf, arm: remove obsolete exception handling from div/mod

2018-01-26 Thread Daniel Borkmann
Since we've changed div/mod exception handling for src_reg in eBPF verifier itself, remove the leftovers from arm32 JIT. Signed-off-by: Daniel Borkmann Cc: Shubham Bansal --- arch/arm/net/bpf_jit_32.c | 8 1 file changed, 8 deletions(-)

[PATCH bpf-next 08/13] bpf, ppc64: remove obsolete exception handling from div/mod

2018-01-26 Thread Daniel Borkmann
Since we've changed div/mod exception handling for src_reg in eBPF verifier itself, remove the leftovers from ppc64 JIT. Signed-off-by: Daniel Borkmann Cc: Naveen N. Rao --- arch/powerpc/net/bpf_jit_comp64.c | 8 1 file changed, 8

[PATCH bpf-next 11/13] bpf, mips64: remove unneeded zero check from div/mod with k

2018-01-26 Thread Daniel Borkmann
The verifier in both cBPF and eBPF reject div/mod by 0 imm, so this can never load. Remove emitting such test and reject it from being JITed instead (the latter is actually also not needed, but given practice in sparc64, ppc64 today, so doesn't hurt to add it here either). Signed-off-by: Daniel

[PATCH bpf-next 02/13] bpf: improve dead code sanitizing

2018-01-26 Thread Daniel Borkmann
Given we recently had c131187db2d3 ("bpf: fix branch pruning logic") and 95a762e2c8c9 ("bpf: fix incorrect sign extension in check_alu_op()") in particular where before verifier skipped verification of the wrongly assumed dead branch, we should not just replace the dead code parts with nops (mov

Re: ipv6_addrconf: WARNING about suspicious RCU usage

2018-01-26 Thread Heiner Kallweit
Am 23.01.2018 um 19:01 schrieb Ido Schimmel: > On Sun, Jan 21, 2018 at 10:22:16PM +0100, Heiner Kallweit wrote: >> So far everything looks good with Eric's patch. The warning didn't show up >> again. > > Eric, can you please submit your patch? > . > Soon the merge window starts, can the patch

Re: [virtio-dev] Re: [RFC PATCH net-next v2 2/2] virtio_net: Extend virtio to use VF datapath when available

2018-01-26 Thread Michael S. Tsirkin
On Fri, Jan 26, 2018 at 01:46:42PM -0800, Siwei Liu wrote: > > and the VM is not expected to do any tuning/optimizations on the VF driver > > directly, > > i think the current patch that follows the netvsc model of 2 netdevs(virtio > > and vf) should > > work fine. > > OK. For your use case

Re: [PATCH] vsock.7: document VSOCK socket address family

2018-01-26 Thread Michael Kerrisk (man-pages)
Stefan, I've just now noted that your page came with no license. What license do you want to use Please see https://www.kernel.org/doc/man-pages/licenses.html Thanks, Michael On 30 November 2017 at 12:21, Stefan Hajnoczi wrote: > The AF_VSOCK address family has been

Re: [virtio-dev] Re: [RFC PATCH net-next v2 2/2] virtio_net: Extend virtio to use VF datapath when available

2018-01-26 Thread Siwei Liu
On Fri, Jan 26, 2018 at 8:51 AM, Samudrala, Sridhar wrote: > > > On 1/26/2018 12:14 AM, Siwei Liu wrote: >> >> On Tue, Jan 23, 2018 at 2:58 PM, Michael S. Tsirkin >> wrote: >>> >>> On Tue, Jan 23, 2018 at 12:24:47PM -0800, Siwei Liu wrote:

[net-next 12/15] i40e: disallow programming multiple filters with same criteria

2018-01-26 Thread Jeff Kirsher
From: Jacob Keller Our hardware does not allow situations where two filters might conflict when matching. Essentially hardware only programs one filter for each set of matching criteria. We don't support filters with overlapping input sets, because each flow type can

[net-next 11/15] i40e: program fragmented IPv4 filter input set

2018-01-26 Thread Jeff Kirsher
From: Jacob Keller When implementing support for IP_USER_FLOW filters, we correctly programmed a filter for both the non fragmented IPv4/Other filter, as well as the fragmented IPv4 filters. However, we did not properly program the input set for fragmented IPv4 PCTYPE.

[net-next 06/15] i40e: change flags to use 64 bits

2018-01-26 Thread Jeff Kirsher
From: Alice Michael As we have added more flags, we need to now use more bits and have over flooded the 32 bit size. So make it 64. Also change all the existing bits to unsigned long long bits. Signed-off-by: Alice Michael Tested-by: Andrew

[net-next 08/15] i40e: fix FW_LLDP flag on init

2018-01-26 Thread Jeff Kirsher
From: Alan Brady Using ethtool --set-priv-flags disable-fw-lldp is persistent across reboots/reloads so we need some mechanism in the driver to detect if it's on or off on init so we can set the ethtool private flag appropriately. Without this, every time the driver is

[net-next 14/15] i40e/i40evf: Record ITR register location in the q_vector

2018-01-26 Thread Jeff Kirsher
From: Alexander Duyck The drivers for i40e and i40evf had a reg_idx value stored in the q_vector that was going completely unused. I can only assume this was copied over from ixgbe and nobody knew how to use it. I'm going to make use of the value to avoid having to

[net-next 15/15] i40e: Do not allow use more TC queue pairs than MSI-X vectors exist

2018-01-26 Thread Jeff Kirsher
From: Paweł Jabłoński This patch suppresses the message about invalid TC mapping and wrong selected TX queue. The root cause of this bug was setting too many TC queue pairs on huge multiprocessor machines. When quantity of the TC queue pairs is exceeding MSI-X vectors

[net-next 09/15] i40e: cleanup unnecessary parens

2018-01-26 Thread Jeff Kirsher
Clean up unnecessary parenthesis. Signed-off-by: Jeff Kirsher Tested-by: Andrew Bowers --- drivers/net/ethernet/intel/i40e/i40e_adminq.c | 2 +- drivers/net/ethernet/intel/i40evf/i40e_adminq.c | 2 +- 2 files changed, 2 insertions(+), 2

[net-next 01/15] i40e: Add returning AQ critical error to SW

2018-01-26 Thread Jeff Kirsher
From: Michal Kosiarz The FW has the ability to return a critical error on every AQ command. When this critical error occurs then we need to send the correct response to the caller. Signed-off-by: Michal Kosiarz Tested-by: Andrew Bowers

[net-next 10/15] i40e: Fix kdump failure

2018-01-26 Thread Jeff Kirsher
From: Avinash Dayanand kdump fails in the system when used in conjunction with Ethernet driver X722/X710. This is mainly because when we are resource constrained i.e. when we have just one online_cpus, we are enabling VMDq and iWARP. It doesn't make sense to enable

[net-next 03/15] i40evf: Allow turning off offloads when the VF has VLAN set

2018-01-26 Thread Jeff Kirsher
From: Paweł Jabłoński This patch adds back the capability to turn off offloads when VF has VLAN set. The commit 0a3b4f702fb1 ("i40evf: enable support for VF VLAN tag stripping control") adds the i40evf_set_features function and changes the 'turn off' flow for offloads.

[net-next 02/15] i40e: Fix for adding multiple ethtool filters on the same location

2018-01-26 Thread Jeff Kirsher
From: Patryk Małek This patch reorders i40e_add_del_fdir and i40e_update_ethtool_fdir_entry calls so that we first remove an already existing filter (inside i40e_update_ethtool_fdir_entry using i40e_add_del_fdir) and then we add a new one with i40e_add_del_fdir. After

[net-next 04/15] i40e/i40evf: Use ring pointers to clean up _set_itr_per_queue

2018-01-26 Thread Jeff Kirsher
From: Alexander Duyck This change cleans up the i40e/i40evf_set_itr_per_queue function by dropping all the unneeded pointer chases. Instead we can just pull out the pointers for the Tx and Rx rings and use them throughout the function. Signed-off-by: Alexander Duyck

[net-next 05/15] i40e: Display LLDP information on vSphere Web Client

2018-01-26 Thread Jeff Kirsher
From: Upasana Menon This patch enables driver to display LLDP information on the vSphere Web Client with Intel adapters (X710, XL710) and Distributed Virtual Switch. Signed-off-by: Upasana Menon Tested-by: Andrew Bowers

[net-next 07/15] i40e: Implement an ethtool private flag to stop LLDP in FW

2018-01-26 Thread Jeff Kirsher
From: Dave Ertman Implement the private flag disable-fw-lldp for ethtool to disable the processing of LLDP packets by the FW. This will stop the FW from consuming LLDPDU and cause them to be sent up the stack. The FW is also being configured to apply a default DCB

[net-next 13/15] i40e: fix reported mask for ntuple filters

2018-01-26 Thread Jeff Kirsher
From: Jacob Keller In commit 36777d9fa24c ("i40e: check current configured input set when adding ntuple filters") some code was added to report the input set mask for a given filter when reporting it to the user. This code is necessary so that the reported filter

[net-next 00/15][pull request] 40GbE Intel Wired LAN Driver Updates 2018-01-26

2018-01-26 Thread Jeff Kirsher
This series contains updates to i40e and i40evf. Michal updates the driver to pass critical errors from the firmware to the caller. Patryk fixes an issue of creating multiple identical filters with the same location, by simply moving the functions so that we remove the existing filter and then

Re: [PATCH v2 net-next 2/2] kcm: Check if sk_user_data already set in kcm_attach

2018-01-26 Thread Eric Dumazet
On Wed, 2018-01-24 at 12:35 -0800, Tom Herbert wrote: > This is needed to prevent sk_user_data being overwritten. > The check is done under the callback lock. This should prevent > a socket from being attached twice to a KCM mux. It also prevents > a socket from being attached for other use cases

Re: [bpf-next PATCH v2 2/3] bpf: sockmap, add sock close() hook to remove socks

2018-01-26 Thread John Fastabend
On 01/26/2018 10:14 AM, John Fastabend wrote: > The selftests test_maps program was leaving dangling BPF sockmap > programs around because not all psock elements were removed from > the map. The elements in turn hold a reference on the BPF program > they are attached to causing BPF programs to

Re: [PATCH 3/3] Revert "e1000e: Do not read ICR in Other interrupt"

2018-01-26 Thread Alexander Duyck
On Fri, Jan 26, 2018 at 1:12 AM, Benjamin Poirier wrote: > This reverts commit 16ecba59bc333d6282ee057fb02339f77a880beb. > > It was reported that emulated e1000e devices in vmware esxi 6.5 Build > 7526125 do not link up after commit 4aea7a5c5e94 ("e1000e: Avoid receiver >

Re: [PATCH iproute2-next 0/2] tc: qdisc: provide JSON output for RED and prio

2018-01-26 Thread David Ahern
On 1/26/18 12:27 PM, Jakub Kicinski wrote: > Hi! > > This small series adds support for JSON output for prio and RED qdiscs. > > Jakub Kicinski (2): > tc: red: JSON-ify RED output > tc: prio: JSON-ify prio output > > include/json_print.h | 1 + > lib/json_print.c | 1 + >

Re: [nf-next] netfilter: Add support for inner IPv6 packet match

2018-01-26 Thread Ahmed Abdelsalam
Hi Pablo, > Hi Ahmed, > > On Thu, Jan 18, 2018 at 04:13:25PM +0100, Ahmed Abdelsalam wrote: > [...] > > diff --git a/include/uapi/linux/netfilter_ipv6/ip6t_inner6.h > > b/include/uapi/linux/netfilter_ipv6/ip6t_inner6.h > Matching at inner headers is a very useful, no doubt. Problem is that >

Re: [PATCH net] ipv6: change route cache aging logic

2018-01-26 Thread Wei Wang
On Fri, Jan 26, 2018 at 12:05 PM, Martin KaFai Lau wrote: > On Fri, Jan 26, 2018 at 11:40:17AM -0800, Wei Wang wrote: >> From: Wei Wang >> >> In current route cache aging logic, if a route has both RTF_EXPIRE and >> RTF_GATEWAY set, the route will only be removed

[PATCH bpf-next] bpf: clean up from test_tcpbpf_kern.c

2018-01-26 Thread Lawrence Brakmo
Removed commented lines from test_tcpbpf_kern.c Fixes: d6d4f60c3a09 bpf: add selftest for tcpbpf Signed-off-by: Lawrence Brakmo --- tools/testing/selftests/bpf/test_tcpbpf_kern.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/tools/testing/selftests/bpf/test_tcpbpf_kern.c

Re: [PATCH net] ipv6: change route cache aging logic

2018-01-26 Thread Martin KaFai Lau
On Fri, Jan 26, 2018 at 11:40:17AM -0800, Wei Wang wrote: > From: Wei Wang > > In current route cache aging logic, if a route has both RTF_EXPIRE and > RTF_GATEWAY set, the route will only be removed if the neighbor cache > has no RTN_ROUTE flag. Otherwise, even if the route

Re: [PATCH net-next,v2 2/2] net: sched: add em_ipt ematch for calling xtables matches

2018-01-26 Thread Eyal Birger
On Fri, Jan 26, 2018 at 8:50 PM, Pablo Neira Ayuso wrote: > On Fri, Jan 26, 2018 at 06:48:53PM +0200, Eyal Birger wrote: >> diff --git a/net/sched/em_ipt.c b/net/sched/em_ipt.c >> new file mode 100644 >> index 000..2103b30 >> --- /dev/null >> +++ b/net/sched/em_ipt.c >

[PATCH net] ipv6: change route cache aging logic

2018-01-26 Thread Wei Wang
From: Wei Wang In current route cache aging logic, if a route has both RTF_EXPIRE and RTF_GATEWAY set, the route will only be removed if the neighbor cache has no RTN_ROUTE flag. Otherwise, even if the route has expired, it won't get deleted. Fix this logic to always check if

Re: dvb usb issues since kernel 4.9

2018-01-26 Thread Mauro Carvalho Chehab
Em Fri, 26 Jan 2018 12:17:37 -0200 Mauro Carvalho Chehab escreveu: > Hi Alan, > > Em Mon, 8 Jan 2018 14:15:35 -0500 (EST) > Alan Stern escreveu: > > > On Mon, 8 Jan 2018, Linus Torvalds wrote: > > > > > Can somebody tell which softirq it

[PATCH iproute2] ip: address: fix stats64 JSON object name

2018-01-26 Thread Jakub Kicinski
The JSON object name for statistics in ip link show is "stats644". Looks like a typo, commit d0e720111aad ("ip: ipaddress.c: add support for json output") contains an example with the expected "stats64" name. The fact that no one has noticed until now is probably an indication that no one is

[PATCH iproute2-next 0/2] tc: qdisc: provide JSON output for RED and prio

2018-01-26 Thread Jakub Kicinski
Hi! This small series adds support for JSON output for prio and RED qdiscs. Jakub Kicinski (2): tc: red: JSON-ify RED output tc: prio: JSON-ify prio output include/json_print.h | 1 + lib/json_print.c | 1 + lib/json_writer.c| 4 tc/q_prio.c | 12

[PATCH iproute2-next 1/2] tc: red: JSON-ify RED output

2018-01-26 Thread Jakub Kicinski
Make JSON output work with RED Qdiscs. Float/double printing helpers have to be added/uncommented to print the probability. Since TC stats in general are not split out to a separate object the xstats printed by this patch are not separated either. Signed-off-by: Jakub Kicinski

[PATCH iproute2-next 2/2] tc: prio: JSON-ify prio output

2018-01-26 Thread Jakub Kicinski
Make JSON output work with prio Qdiscs. This will also make other qdiscs which reuse the print_qopt work, like mqprio or pfifo_fast. Note that there is a double space between "priomap" and first prio number. Keep this original behaviour. Signed-off-by: Jakub Kicinski

Re: [regresssion 4.15] Userspace compilation broken by uapi/linux/if_ether.h update

2018-01-26 Thread David Miller
From: Guillaume Nault Date: Fri, 26 Jan 2018 18:17:23 +0100 > On Fri, Jan 26, 2018 at 11:51:38AM +0100, Guillaume Nault wrote: >> On Thu, Jan 25, 2018 at 11:21:34PM +0100, Hauke Mehrtens wrote: >> > On 01/25/2018 03:58 PM, Guillaume Nault wrote: >> > > Now that

Re: [PATCH net-next] bnxt_en: cleanup DIM work on device shutdown

2018-01-26 Thread Michael Chan
On Fri, Jan 26, 2018 at 7:27 AM, Andy Gospodarek wrote: > > From: Andy Gospodarek > > Make sure to cancel any pending work that might update driver coalesce > settings when taking down an interface. > > Fixes: 6a8788f25625 ("bnxt_en: add support for

Re: [PATCH net-next,v2 2/2] net: sched: add em_ipt ematch for calling xtables matches

2018-01-26 Thread Pablo Neira Ayuso
On Fri, Jan 26, 2018 at 06:48:53PM +0200, Eyal Birger wrote: > diff --git a/net/sched/em_ipt.c b/net/sched/em_ipt.c > new file mode 100644 > index 000..2103b30 > --- /dev/null > +++ b/net/sched/em_ipt.c [...] > +static int em_ipt_match(struct sk_buff *skb, struct tcf_ematch *em, > +

[net-next 00/15][pull request] 10GbE Intel Wired LAN Driver Updates 2018-01-26

2018-01-26 Thread Jeff Kirsher
This series contains updates to ixgbe and ixgbevf. Emil updates ixgbevf to match ixgbe functionality, starting with the consolidating of functions that represent logical steps in the receive process so we can later update them more easily. Updated ixgbevf to only synchronize the length of the

[net-next 02/15] ixgbevf: only DMA sync frame length

2018-01-26 Thread Jeff Kirsher
From: Emil Tantilov Based on commit 64f2525ca4e7 ("igb: Only DMA sync frame length") On some architectures synching a buffer for DMA may be expensive. Instead of the entire 2K receive buffer only synchronize the length of the frame, which will typically be the MTU or

[net-next 01/15] ixgbevf: add function for checking if we can reuse page

2018-01-26 Thread Jeff Kirsher
From: Emil Tantilov Introduce ixgbevf_can_reuse_page() similar to the change in ixgbe from commit af43da0dba0b ("ixgbe: Add function for checking to see if we can reuse page") Signed-off-by: Emil Tantilov Tested-by: Krishneil Singh

[net-next 03/15] ixgbevf: use length to determine if descriptor is done

2018-01-26 Thread Jeff Kirsher
From: Emil Tantilov Based on: commit 7ec0116c9131 ("igb: Use length to determine if descriptor is done") This change makes it so that we use the length of the packet instead of the DD status bit to determine if a new descriptor is ready to be processed. The obvious

[net-next 06/15] ixgbevf: add counters for Rx page allocations

2018-01-26 Thread Jeff Kirsher
From: Emil Tantilov We already had placehloders for failed page and buffer allocations. Added alloc_rx_page and made sure the stats are properly updated and exposed in ethtool. Signed-off-by: Emil Tantilov Tested-by: Krishneil Singh

[net-next 09/15] ixgbevf: don't bother clearing tx_buffer_info in ixgbevf_clean_tx_ring()

2018-01-26 Thread Jeff Kirsher
From: Emil Tantilov In the case of the Tx rings we need to only clear the Tx buffer_info when we are resetting the rings. Ideally we do this when we configure the ring to bring it back up instead of when we are taking it down in order to avoid dirtying pages we don't

[net-next 11/15] ixgbe: use ARRAY_SIZE for array sizing calculation on array buf

2018-01-26 Thread Jeff Kirsher
From: Colin Ian King Use the ARRAY_SIZE macro on array buf to determine size of the array. Improvement suggested by coccinelle. Signed-off-by: Colin Ian King Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher

[net-next 12/15] ixgbe: Don't report unsupported timestamping filters for X550

2018-01-26 Thread Jeff Kirsher
From: Miroslav Lichvar The current code enables on X550 timestamping of all packets for any filter, which means ethtool should not report any PTP-specific filters as unsupported. Signed-off-by: Miroslav Lichvar Acked-by: Richard Cochran

[net-next 04/15] ixgbevf: add support for DMA_ATTR_SKIP_CPU_SYNC/WEAK_ORDERING

2018-01-26 Thread Jeff Kirsher
From: Emil Tantilov Based on commit 5be5955425c2 ("igb: update driver to make use of DMA_ATTR_SKIP_CPU_SYNC") and commit 7bd175928280 ("igb: Add support for DMA_ATTR_WEAK_ORDERING") Convert the calls to dma_map/unmap_page() to the attributes version and add

[net-next 05/15] ixgbevf: update code to better handle incrementing page count

2018-01-26 Thread Jeff Kirsher
From: Emil Tantilov Based on commit bd4171a5d4c2 ("igb: update code to better handle incrementing page count") Update the driver code so that we do bulk updates of the page reference count instead of just incrementing it by one reference at a time. The advantage to

[net-next 08/15] ixgbevf: improve performance and reduce size of ixgbevf_tx_map()

2018-01-26 Thread Jeff Kirsher
From: Emil Tantilov Based on commit ec718254cbfe ("ixgbe: Improve performance and reduce size of ixgbe_tx_map") This change is meant to both improve the performance and reduce the size of ixgbevf_tx_map(). Expand the work done in the main loop by pushing first into

[net-next 13/15] ixgbe: add support for reporting 5G link speed

2018-01-26 Thread Jeff Kirsher
From: Paul Greenwalt Since 5G link speed is supported by some devices, add reporting of 5G link speed. Signed-off-by: Paul Greenwalt Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher

[net-next 07/15] ixgbevf: clear rx_buffer_info in configure instead of clean

2018-01-26 Thread Jeff Kirsher
From: Emil Tantilov Based on commit d2bead576e67 ("igb: Clear Rx buffer_info in configure instead of clean") This change makes it so that instead of going through the entire ring on Rx cleanup we only go through the region that was designated to be cleaned up and stop

[net-next 14/15] ixgbe: Fix && vs || typo

2018-01-26 Thread Jeff Kirsher
From: Dan Carpenter "offset" can't be both 0x0 and 0x so presumably || was intended instead of &&. That matches with how this check is done in other functions. Fixes: 73834aec7199 ("ixgbe: extend firmware version support") Signed-off-by: Dan Carpenter

[net-next 15/15] ixgbe: don't set RXDCTL.RLPML for 82599

2018-01-26 Thread Jeff Kirsher
From: Emil Tantilov commit 2de6aa3a666e ("ixgbe: Add support for padding packet") Uses RXDCTL.RLPML to limit the maximum frame size on Rx when using build_skb. Unfortunately that register does not work on 82599. Added an explicit check to avoid setting this register

  1   2   >