Re: [PATCH] esp4: remove redundant initialization of pointer esph

2018-02-01 Thread Steffen Klassert
On Tue, Jan 30, 2018 at 02:53:48PM +, Colin King wrote: > From: Colin Ian King > > Pointer esph is being assigned a value that is never read, esph is > re-assigned and only read inside an if statement, hence the > initialization is redundant and can be removed. > >

Re: KASAN: stack-out-of-bounds Read in xfrm_state_find (4)

2018-02-01 Thread Steffen Klassert
On Thu, Feb 01, 2018 at 11:30:00AM +0100, Dmitry Vyukov wrote: > On Thu, Feb 1, 2018 at 9:34 AM, Steffen Klassert > > Hi Steffen, > > Please see the email footer: > > > If you want to test a patch for this bug, please reply with: > > #syz test: git://repo/address.git branch > > and provide the

[PATCH bpf-next] bpf: add documentation to compare clang "-target bpf" and default target

2018-02-01 Thread Yonghong Song
The added documentation explains how generated codes may differ between clang bpf target and default target, and when to use each target. Signed-off-by: Yonghong Song --- Documentation/bpf/bpf_devel_QA.txt | 30 ++ 1 file changed, 30 insertions(+) diff

Re: iproute2 4.14.1 tc class add come to kernel-panic

2018-02-01 Thread Cong Wang
On Tue, Jan 30, 2018 at 11:46 PM, Roland Franke wrote: > Hello, > >> On Tue, Jan 30, 2018 at 9:46 AM, Roland Franke >> wrote: >>> >>> Hello, >>> Well, not min_qdisc things, but it should be resolved by: >>> >>> commit

Re: [PATCH] socket: Provide bounce buffer for constant sized put_cmsg()

2018-02-01 Thread kbuild test robot
Hi Kees, I love your patch! Perhaps something to improve: [auto build test WARNING on linus/master] [also build test WARNING on v4.15 next-20180201] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux

Re: Compare length of req sock queue with sk_max_ack_backlog

2018-02-01 Thread Tonghao Zhang
On Fri, Feb 2, 2018 at 12:19 PM, Eric Dumazet wrote: > On Fri, 2018-02-02 at 09:55 +0800, Tonghao Zhang wrote: >> On Thu, Feb 1, 2018 at 10:00 PM, Eric Dumazet wrote: >> > On Thu, 2018-02-01 at 20:34 +0800, Tonghao Zhang wrote: >> > > Hi Eric >> >

[PATCH] ss: introduce switch to print exact value of data rates

2018-02-01 Thread Tomasz Torcz
Introduce -X/--exact switch to disable human-friendly printing of datarates. With the switch, data is not presented as MBps/Kbps. Signed-off-by: Tomasz Torcz --- misc/ss.c | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/misc/ss.c

RE: [Intel-wired-lan] [RFC PATCH] e1000e: Remove Other from EIAC.

2018-02-01 Thread Brown, Aaron F
> From: Brown, Aaron F > Sent: Thursday, February 1, 2018 8:30 PM > To: 'Benjamin Poirier' ; Alexander Duyck > > Cc: Netdev ; intel-wired-lan l...@lists.osuosl.org>; linux-ker...@vger.kernel.org > Subject: RE:

Re: [PATCH] socket: Provide bounce buffer for constant sized put_cmsg()

2018-02-01 Thread kbuild test robot
Hi Kees, I love your patch! Yet something to improve: [auto build test ERROR on linus/master] [also build test ERROR on v4.15 next-20180201] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Kees

RE: [Intel-wired-lan] [RFC PATCH] e1000e: Remove Other from EIAC.

2018-02-01 Thread Brown, Aaron F
> From: Intel-wired-lan [mailto:intel-wired-lan-boun...@osuosl.org] On > Behalf Of Benjamin Poirier > Sent: Tuesday, January 30, 2018 11:31 PM > To: Alexander Duyck > Cc: Netdev ; intel-wired-lan l...@lists.osuosl.org>;

Re: Compare length of req sock queue with sk_max_ack_backlog

2018-02-01 Thread Eric Dumazet
On Fri, 2018-02-02 at 09:55 +0800, Tonghao Zhang wrote: > On Thu, Feb 1, 2018 at 10:00 PM, Eric Dumazet wrote: > > On Thu, 2018-02-01 at 20:34 +0800, Tonghao Zhang wrote: > > > Hi Eric > > > One question for you, In the patch ef547f2ac16 ("tcp: remove > > > max_qlen_log"),

[PATCH net] nfp: fix TLV offset calculation

2018-02-01 Thread Jakub Kicinski
From: Edwin Peer The data pointer in the config space TLV parser already includes NFP_NET_CFG_TLV_BASE, it should not be added again. Incorrect offset values were only used in printed user output, rendering the bug merely cosmetic. Fixes: 73a0329b057e ("nfp: add TLV

Re: [RFC iproute2-next 00/16] iproute printing enhancements

2018-02-01 Thread David Ahern
On 2/1/18 6:19 PM, Stephen Hemminger wrote: > The first group of patches refactor the printout to breakup > excessively long print_route function and the last few implement > JSON and color output format for routes. > > The one thing that maybe controversial is changing the default > json output

Re: [PATCH] tcp_lp: use 64-bit arithmetic instead of 32-bit

2018-02-01 Thread Gustavo A. R. Silva
Hi Andrew, Quoting Andrew Lunn : On Wed, Jan 31, 2018 at 07:07:49PM -0600, Gustavo A. R. Silva wrote: Hi Alan, Quoting Alan Cox : >On Wed, 31 Jan 2018 18:24:07 -0600 >"Gustavo A. R. Silva" wrote: > >>Cast to s64 some

Re: [RFC iproute2-next 00/16] iproute printing enhancements

2018-02-01 Thread David Ahern
On 2/1/18 6:19 PM, Stephen Hemminger wrote: > The first group of patches refactor the printout to breakup > excessively long print_route function and the last few implement > JSON and color output format for routes. If I knew you were going to refactor route printing, I would have pointed you to

Re: [PATCH] tcp_lp: use 64-bit arithmetic instead of 32-bit

2018-02-01 Thread Gustavo A. R. Silva
Hi David, Quoting David Miller : From: "Gustavo A. R. Silva" Date: Wed, 31 Jan 2018 18:24:07 -0600 Cast to s64 some variables and a macro in order to give the compiler complete information about the proper arithmetic to use. Notice that these

Re: [PATCH] tcp_lp: use 64-bit arithmetic instead of 32-bit

2018-02-01 Thread Gustavo A. R. Silva
Hi David, Quoting David Laight : > The question you need to ask is 'can it overflow 32bit maths', otherwise > you are potentially making the system do extra work for no reason. > Yeah, I get your point and it seems that in this particular case there is no risk of a

[fw_cfg] c8bf448ff3: kernel_BUG_at_arch/x86/mm/physaddr.c

2018-02-01 Thread kernel test robot
FYI, we noticed the following commit (built with gcc-7): commit: c8bf448ff3899860de51fbae61a43619c912ddf2 ("fw_cfg: do DMA read operation") https://git.kernel.org/cgit/linux/kernel/git/mst/vhost.git vhost in testcase: boot on test machine: qemu-system-x86_64 -enable-kvm -m 420M caused below

Re: r8169 take too long to complete driver initialization

2018-02-01 Thread Chris Chiu
On Tue, Jan 30, 2018 at 8:07 PM, Chris Chiu wrote: > On Mon, Jan 29, 2018 at 11:24 PM, Hau wrote: >> Hi Chris, >> >> Could you test following patch? >> >> DECLARE_RTL_COND(rtl_ocp_tx_cond) >> { >> void __iomem *ioaddr = tp->mmio_addr; >> >> -

Re: Compare length of req sock queue with sk_max_ack_backlog

2018-02-01 Thread Tonghao Zhang
On Thu, Feb 1, 2018 at 10:00 PM, Eric Dumazet wrote: > On Thu, 2018-02-01 at 20:34 +0800, Tonghao Zhang wrote: >> Hi Eric >> One question for you, In the patch ef547f2ac16 ("tcp: remove >> max_qlen_log"), why we compared the length of req sock queue with >>

[RFC iproute2-next 14/16] json: make pretty printing optional

2018-02-01 Thread Stephen Hemminger
Since JSON is intended for programmatic consumption, it makes sense for the default output format to be concise as possible. For programmer and other uses, it is helpful to keep the pretty whitespace format; therefore enable it with -p flag. Signed-off-by: Stephen Hemminger

[RFC iproute2-next 13/16] iproute: implement JSON and color output

2018-02-01 Thread Stephen Hemminger
Add JSON and color output formatting to ip route command. Similar to existing address and link output. Signed-off-by: Stephen Hemminger --- include/utils.h | 5 + ip/iproute.c| 367 +++- 2 files changed, 259

[RFC iproute2-next 12/16] iproute: make flush a separate function

2018-02-01 Thread Stephen Hemminger
Minor refactoring to make function size smaller and reduce depth of nesting. Signed-off-by: Stephen Hemminger --- ip/iproute.c | 121 +++ 1 file changed, 64 insertions(+), 57 deletions(-) diff --git

[RFC iproute2-next 15/16] man: add documentation for json and pretty flags

2018-02-01 Thread Stephen Hemminger
New options were added without documentation or usage. Signed-off-by: Stephen Hemminger --- ip/ip.c | 4 ++-- man/man8/ip.8 | 18 ++ man/man8/tc.8 | 3 ++- 3 files changed, 18 insertions(+), 7 deletions(-) diff --git a/ip/ip.c b/ip/ip.c index

[RFC iproute2-next 16/16] json: fix newline at end of array

2018-02-01 Thread Stephen Hemminger
The json print library was toggling pretty print at the end of an array to workaround a bug in underlying json_writer. Instead, just fix json_writer to pretty print array correctly. Signed-off-by: Stephen Hemminger --- lib/json_print.c | 2 -- lib/json_writer.c | 5

[RFC iproute2-next 11/16] iproute: don't do assignment in condition

2018-02-01 Thread Stephen Hemminger
Fix checkpatch complaints about assignment in conditions. Signed-off-by: Stephen Hemminger --- ip/iproute.c | 25 - 1 file changed, 16 insertions(+), 9 deletions(-) diff --git a/ip/iproute.c b/ip/iproute.c index b466f9eb8cad..55b2f51e3987

[RFC iproute2-next 09/16] iproute: refactor printing of interface

2018-02-01 Thread Stephen Hemminger
For JSON and colorization, make common code a function. Signed-off-by: Stephen Hemminger --- ip/iproute.c | 16 +++- 1 file changed, 11 insertions(+), 5 deletions(-) diff --git a/ip/iproute.c b/ip/iproute.c index b2eea4be9c37..a9842cfc8205 100644 ---

[RFC iproute2-next 08/16] iproute: refactor multipath print

2018-02-01 Thread Stephen Hemminger
Make printing of multipath attributes a function to improve readability. Signed-off-by: Stephen Hemminger --- ip/iproute.c | 116 --- 1 file changed, 63 insertions(+), 53 deletions(-) diff --git a/ip/iproute.c

[RFC iproute2-next 07/16] iproute2: refactor newdst, gateway and via printing

2018-02-01 Thread Stephen Hemminger
Since these fields are printed in both route and multipath case; avoid duplicating code. Signed-off-by: Stephen Hemminger --- ip/iproute.c | 73 +--- 1 file changed, 40 insertions(+), 33 deletions(-) diff --git

[RFC iproute2-next 10/16] iproute: whitespace fixes

2018-02-01 Thread Stephen Hemminger
Add whitespace arount operators for consistency. Signed-off-by: Stephen Hemminger --- ip/iproute.c | 23 +-- 1 file changed, 13 insertions(+), 10 deletions(-) diff --git a/ip/iproute.c b/ip/iproute.c index a9842cfc8205..b466f9eb8cad 100644 ---

[RFC iproute2-next 06/16] iproute: refactor printing flow info

2018-02-01 Thread Stephen Hemminger
Use common code for printing flow info. Signed-off-by: Stephen Hemminger --- ip/iproute.c | 46 -- 1 file changed, 20 insertions(+), 26 deletions(-) diff --git a/ip/iproute.c b/ip/iproute.c index 42d1678b9690..7482f04c1852

[RFC iproute2-next 04/16] iproute: refactor cacheinfo printing

2018-02-01 Thread Stephen Hemminger
Make common function for decoding cacheinfo. This code may print more info than old version in some cases. Signed-off-by: Stephen Hemminger --- ip/iproute.c | 78 +--- 1 file changed, 32 insertions(+), 46

[RFC iproute2-next 00/16] iproute printing enhancements

2018-02-01 Thread Stephen Hemminger
The first group of patches refactor the printout to breakup excessively long print_route function and the last few implement JSON and color output format for routes. The one thing that maybe controversial is changing the default json output format to be compact. The value of JSON is for

[RFC iproute2-next 01/16] iproute: refactor printing flags

2018-02-01 Thread Stephen Hemminger
Both next hop and route need to decode flags. Signed-off-by: Stephen Hemminger --- ip/iproute.c | 46 ++ 1 file changed, 22 insertions(+), 24 deletions(-) diff --git a/ip/iproute.c b/ip/iproute.c index

[RFC iproute2-next 03/16] iproute: make printing IPv4 cache flags a function

2018-02-01 Thread Stephen Hemminger
More refactoring prior to JSON support. Signed-off-by: Stephen Hemminger --- ip/iproute.c | 63 +++- 1 file changed, 37 insertions(+), 26 deletions(-) diff --git a/ip/iproute.c b/ip/iproute.c index

[RFC iproute2-next 02/16] iproute: make printing icmpv6 a function

2018-02-01 Thread Stephen Hemminger
Refactor to reduce size of print_route and improve readability. Signed-off-by: Stephen Hemminger --- ip/iproute.c | 38 +- 1 file changed, 21 insertions(+), 17 deletions(-) diff --git a/ip/iproute.c b/ip/iproute.c index

[RFC iproute2-next 05/16] iproute: refactor metrics print

2018-02-01 Thread Stephen Hemminger
Make a separate function to improve readability and enable easier JSON conversion. Signed-off-by: Stephen Hemminger --- ip/iproute.c | 117 +++ 1 file changed, 61 insertions(+), 56 deletions(-) diff --git

RE: [Intel-wired-lan] Possible read-modify-write bug in ixgbe x550 phy setup

2018-02-01 Thread Tantilov, Emil S
>-Original Message- >From: Shannon Nelson [mailto:shannon.nel...@oracle.com] >Sent: Thursday, February 01, 2018 4:44 PM >To: Tantilov, Emil S >Cc: netdev@vger.kernel.org; intel-wired-...@lists.osuosl.org >Subject: Re: [Intel-wired-lan] Possible read-modify-write

Re: [Intel-wired-lan] Possible read-modify-write bug in ixgbe x550 phy setup

2018-02-01 Thread Shannon Nelson
On 2/1/2018 4:34 PM, Tantilov, Emil S wrote: -Original Message- From: Intel-wired-lan [mailto:intel-wired-lan-boun...@osuosl.org] On Behalf Of Shannon Nelson Sent: Thursday, February 01, 2018 3:46 PM To: Tantilov, Emil S Cc: netdev@vger.kernel.org;

RE: [Intel-wired-lan] Possible read-modify-write bug in ixgbe x550 phy setup

2018-02-01 Thread Tantilov, Emil S
>-Original Message- >From: Intel-wired-lan [mailto:intel-wired-lan-boun...@osuosl.org] On >Behalf Of Shannon Nelson >Sent: Thursday, February 01, 2018 3:46 PM >To: Tantilov, Emil S >Cc: netdev@vger.kernel.org; intel-wired-...@lists.osuosl.org >Subject:

Re: sctp netns "unregister_netdevice: waiting for lo to become free. Usage count = 1"

2018-02-01 Thread Alexey Kodanev
On 01.02.2018 21:02, Tommi Rantala wrote: > 2018-01-31 19:51 GMT+02:00 Tommi Rantala : >> On 31.01.2018 14:31, Neil Horman wrote: >>> >>> On Wed, Jan 31, 2018 at 11:42:24AM +0200, Tommi Rantala wrote: I think there's a problem in the dst refcounting in

Possible read-modify-write bug in ixgbe x550 phy setup

2018-02-01 Thread Shannon Nelson
Hi Emil, I was looking through a set of ixgbe patches and came across this commit commit 410a494902777c11f95031d9ed757d7f8f09c5c6 ixgbe: add write flush when configuring CS4223/7 and am wondering about the setting of reg_phy_ext in the middle of ixgbe_setup_mac_link_sfp_x550a(). It

Re: suspicious RCU usage at net/ipv6/ip6_fib.c:LINE

2018-02-01 Thread Wei Wang
On Thu, Feb 1, 2018 at 2:56 PM, Eric Biggers wrote: > +wei...@google.com > > On Tue, Jan 02, 2018 at 03:58:02PM -0800, syzbot wrote: >> Hello, >> >> syzkaller hit the following crash on >> 6bb8824732f69de0f233ae6b1a8158e149627b38 >>

Re: [PATCH net] net: memcontrol: charge allocated memory after mem_cgroup_sk_alloc()

2018-02-01 Thread Roman Gushchin
On Thu, Feb 01, 2018 at 03:27:14PM -0800, Eric Dumazet wrote: > Well, this memcg stuff is so confusing. > > My recollection is that we had : > > > https://git.kernel.org/pub/scm/linux/kernel/git/davem/net.git/commit/?id=d979a39d7242e0601bf9b60e89628fb8ac577179 > >

Re: WARNING in reuseport_add_sock

2018-02-01 Thread Eric Dumazet
On Thu, 2018-02-01 at 15:30 -0800, Eric Biggers wrote: > On Fri, Jan 12, 2018 at 03:58:01PM -0800, syzbot wrote: > > Hello, > > > > syzkaller hit the following crash on > > 30a7acd573899fd8b8ac39236eff6468b195ac7d > > git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/master > >

Re: [RFC][PATCH iproute2-next 2/6] ip: Introduce get_rtnl_link_stats_rta() to get link statistics

2018-02-01 Thread Stephen Hemminger
On Thu, 1 Feb 2018 21:40:54 +0200 Serhey Popovych wrote: > +/* Based on copy_rtnl_link_stats() from kernel at net/core/rtnetlink.c */ > +static void copy_rtnl_link_stats64(struct rtnl_link_stats64 *a, > +const struct rtnl_link_stats *b)

Re: WARNING in reuseport_add_sock

2018-02-01 Thread Eric Biggers
On Fri, Jan 12, 2018 at 03:58:01PM -0800, syzbot wrote: > Hello, > > syzkaller hit the following crash on > 30a7acd573899fd8b8ac39236eff6468b195ac7d > git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/master > compiler: gcc (GCC) 7.1.1 20170620 > .config is attached > Raw console

Re: [PATCH net-next] r8169: add module param for control of ASPM disable

2018-02-01 Thread Francois Romieu
net-next is closed anyway. -- Ueimor

Re: [PATCH net-next] r8169: add module param for control of ASPM disable

2018-02-01 Thread Francois Romieu
Chunhao Lin : [...] > @@ -5878,6 +5881,20 @@ static void rtl_pcie_state_l2l3_enable(struct > rtl8169_private *tp, bool enable) > RTL_W8(Config3, data); > } > > +static void rtl_hw_internal_aspm_clkreq_enable(struct rtl8169_private *tp, > +

Re: [PATCH net] net: memcontrol: charge allocated memory after mem_cgroup_sk_alloc()

2018-02-01 Thread Eric Dumazet
Well, this memcg stuff is so confusing. My recollection is that we had : https://git.kernel.org/pub/scm/linux/kernel/git/davem/net.git/commit/?id=d979a39d7242e0601bf9b60e89628fb8ac577179

Re: suspicious RCU usage at net/ipv6/ip6_fib.c:LINE

2018-02-01 Thread Eric Biggers
+wei...@google.com On Tue, Jan 02, 2018 at 03:58:02PM -0800, syzbot wrote: > Hello, > > syzkaller hit the following crash on > 6bb8824732f69de0f233ae6b1a8158e149627b38 > git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git/master > compiler: gcc (GCC) 7.1.1 20170620 > .config is

Re: [PATCH net] net: memcontrol: charge allocated memory after mem_cgroup_sk_alloc()

2018-02-01 Thread Roman Gushchin
On Thu, Feb 01, 2018 at 01:17:56PM -0800, Eric Dumazet wrote: > On Thu, Feb 1, 2018 at 12:22 PM, Roman Gushchin wrote: > > On Thu, Feb 01, 2018 at 10:16:55AM -0500, David Miller wrote: > >> From: Roman Gushchin > >> Date: Wed, 31 Jan 2018 21:54:08 + > >> > >> > So I

Re: [Patch net] xt_RATEEST: acquire xt_rateest_mutex for hash insert

2018-02-01 Thread Florian Westphal
Cong Wang wrote: > On Wed, Jan 31, 2018 at 5:44 PM, Eric Dumazet wrote: > > On Wed, 2018-01-31 at 16:26 -0800, Cong Wang wrote: > >> rateest_hash is supposed to be protected by xt_rateest_mutex. > >> > >> Reported-by:

RE: [RFC PATCH 1/2] hv_netvsc: Split netvsc_revoke_buf() and netvsc_teardown_gpadl()

2018-02-01 Thread Stephen Hemminger
There are multiple issues with some of the parameter change paths. Still working on getting something stable. Both upstream, and net-next do have crash issues under concurrent changes. I don't want Linux doing different workaround than Windows if at all possible; because it means that it would

Re: [RFC PATCH 1/2] hv_netvsc: Split netvsc_revoke_buf() and netvsc_teardown_gpadl()

2018-02-01 Thread Mohammed Gamal
On Thu, 2018-02-01 at 09:37 +0100, Mohammed Gamal wrote: > On Wed, 2018-01-31 at 15:01 -0800, Stephen Hemminger wrote: > > On Wed, 31 Jan 2018 12:16:49 +0100 > > Mohammed Gamal wrote: > > > > > On Tue, 2018-01-30 at 11:29 -0800, Stephen Hemminger wrote: > > > > On Tue, 23 Jan

Re: suspicious RCU usage at net/tipc/bearer.c:LINE

2018-02-01 Thread Eric Biggers
On Sun, Dec 31, 2017 at 10:58:01AM -0800, syzbot wrote: > Hello, > > syzkaller hit the following crash on > 5aa90a84589282b87666f92b6c3c917c8080a9bf > git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/master > compiler: gcc (GCC) 7.1.1 20170620 > .config is attached > Raw console

Re: KASAN: use-after-free Read in tipc_group_size

2018-02-01 Thread Eric Biggers
On Mon, Jan 08, 2018 at 08:11:35PM +, Jon Maloy wrote: > > > > -Original Message- > > From: Cong Wang [mailto:xiyou.wangc...@gmail.com] > > Sent: Monday, January 08, 2018 13:44 > > To: syzbot > > Cc: David Miller

Re: [Patch net] xt_RATEEST: acquire xt_rateest_mutex for hash insert

2018-02-01 Thread Cong Wang
On Wed, Jan 31, 2018 at 5:44 PM, Eric Dumazet wrote: > On Wed, 2018-01-31 at 16:26 -0800, Cong Wang wrote: >> rateest_hash is supposed to be protected by xt_rateest_mutex. >> >> Reported-by: >> Fixes: 5859034d7eb8

Re: [PATCH] vsock.7: document VSOCK socket address family

2018-02-01 Thread Michael Kerrisk (man-pages)
On 1 February 2018 at 19:03, Stefan Hajnoczi wrote: > On Tue, Jan 30, 2018 at 10:31:54PM +0100, Michael Kerrisk (man-pages) wrote: >> Hi Stefan, >> >> Ping on the below please, since it either blocks the man-pages release >> I'd currently like to make, or I must remove the

Re: [PATCH net] net: memcontrol: charge allocated memory after mem_cgroup_sk_alloc()

2018-02-01 Thread Eric Dumazet
On Thu, Feb 1, 2018 at 12:22 PM, Roman Gushchin wrote: > On Thu, Feb 01, 2018 at 10:16:55AM -0500, David Miller wrote: >> From: Roman Gushchin >> Date: Wed, 31 Jan 2018 21:54:08 + >> >> > So I really start thinking that reverting 9f1c2674b328 >> > ("net: memcontrol:

Re: [PATCH, net] ibmvnic: fix firmware version when no firmware level has been provided by the VIOS server

2018-02-01 Thread Tyrel Datwyler
On 02/01/2018 10:04 AM, Desnes Augusto Nunes do Rosario wrote: > Older versions of VIOS servers do not send the firmware level in the VPD > buffer for the ibmvnic driver. Thus, not only the current message is mis- > leading but the firmware version in the ethtool will be NULL. Therefore, > this

Re: [Intel-wired-lan] [RFC v2 net-next 01/10] net: Add a new socket option for a future transmit time.

2018-02-01 Thread Jesus Sanchez-Palencia
Hi, On 02/01/2018 01:27 AM, Miroslav Lichvar wrote: > On Wed, Jan 31, 2018 at 04:49:36PM -0800, Jesus Sanchez-Palencia wrote: >> On 01/18/2018 09:13 AM, Richard Cochran wrote: >>> Right, the clockid_t should be passed in through the CMSG along with >>> the time. >> >> While implementing this

Re: sctp netns "unregister_netdevice: waiting for lo to become free. Usage count = 1"

2018-02-01 Thread Tommi Rantala
2018-02-01 21:23 GMT+02:00 Neil Horman : > No, I can't say I saw the patch on the list. Can you resend it? Here's the patch again, sending from gmail this time. The previous mail is now also at spinics, dunno what happened.

Urgent Attention!

2018-02-01 Thread Mr Gary Gibson
I am Mr Gary Gibson. I've a proposal for you but I don't know if it would be against your ethics but would appreciate your acceptance, which would definitely be of a life time opportunity for the both of us. I hope you will accept my mail in good faith. I will give you detailed information as

Good Morning !

2018-02-01 Thread Anny
Good Morning , I have a project i would like to bring to you and i want you to help me discuss it. please let me know if you will be available for this project. Thanks

Re: [Intel-wired-lan] [PATCH] ixgbevf: remove redundant initialization of variable 'dma'.

2018-02-01 Thread Alexander Duyck
On Thu, Feb 1, 2018 at 10:35 AM, Colin King wrote: > From: Colin Ian King > > Variable dma is initialized with a value that is never read, later > on it is re-assigned a new value, hence the initialization is redundant > and can be removed. > >

Re: [PATCH] DT: net: renesas,ravb: document R8A77980 bindings

2018-02-01 Thread Geert Uytterhoeven
On Thu, Feb 1, 2018 at 9:13 PM, Sergei Shtylyov wrote: > Renesas R-Car V3H (R8A77980) SoC has the R-Car gen3 compatible EtherAVB > device, so document the SoC specific bindings. > > Signed-off-by: Sergei Shtylyov

Re: [PATCH net] net: memcontrol: charge allocated memory after mem_cgroup_sk_alloc()

2018-02-01 Thread Roman Gushchin
On Thu, Feb 01, 2018 at 10:16:55AM -0500, David Miller wrote: > From: Roman Gushchin > Date: Wed, 31 Jan 2018 21:54:08 + > > > So I really start thinking that reverting 9f1c2674b328 > > ("net: memcontrol: defer call to mem_cgroup_sk_alloc()") > > and fixing the original issue

[PATCH] DT: net: renesas,ravb: document R8A77980 bindings

2018-02-01 Thread Sergei Shtylyov
Renesas R-Car V3H (R8A77980) SoC has the R-Car gen3 compatible EtherAVB device, so document the SoC specific bindings. Signed-off-by: Sergei Shtylyov --- The patch is against DaveM's 'net-next.git' repo but I wouldn't mind if it's applied to 'net.git'

RE: [PATCH iproute2-next 08/10] rdma: Add QP resource tracking information

2018-02-01 Thread Steve Wise
Hey Leon, > > From: Leon Romanovsky > > This patch adds ss-similar interface to view various resource > tracked objects. At this stage, only QP is presented. > > 1. Get all QPs for the specific device: > $ rdma res show qp link mlx5_4 > link mlx5_4/- lqpn 8 type UD state

Re: [PATCH net] net: igmp: add a missing rcu locking section

2018-02-01 Thread David Miller
From: Eric Dumazet Date: Thu, 01 Feb 2018 10:26:57 -0800 > From: Eric Dumazet > > Newly added igmpv3_get_srcaddr() needs to be called under rcu lock. > > Timer callbacks do not ensure this locking. ... > Fixes: a46182b00290 ("net: igmp: Use

Re: [PATCH v2] net: pxa168_eth: add netconsole support

2018-02-01 Thread David Miller
From: Alexander Monakov Date: Thu, 1 Feb 2018 22:45:17 +0300 (MSK) > This implements ndo_poll_controller callback which is necessary to > enable netconsole. > > Signed-off-by: Alexander Monakov Looks good, applied.

Re: [PATCH, net] ibmvnic: fix firmware version when no firmware level has been provided by the VIOS server

2018-02-01 Thread David Miller
From: Desnes Augusto Nunes do Rosario Date: Thu, 1 Feb 2018 16:04:30 -0200 > Older versions of VIOS servers do not send the firmware level in the VPD > buffer for the ibmvnic driver. Thus, not only the current message is mis- > leading but the firmware version in the

Re: [PATCH] lan78xx: remove redundant initialization of pointer 'phydev'

2018-02-01 Thread David Miller
From: Colin King Date: Thu, 1 Feb 2018 17:10:18 + > From: Colin Ian King > > Pointer phydev is initialized and this value is never read, phydev > is immediately updated to a new value, hence this initialization > is redundant and can be

Re: [PATCH] vmxnet3: remove redundant initialization of pointer 'rq'

2018-02-01 Thread David Miller
From: Colin King Date: Thu, 1 Feb 2018 17:29:21 + > From: Colin Ian King > > Pointer rq is being initialized but this value is never read, it > is being updated inside a for-loop. Remove the initialization and > move it into the scope of

Re: [PATCH] net: jme: remove unused initialization of 'rxdesc'

2018-02-01 Thread David Miller
From: Colin King Date: Thu, 1 Feb 2018 16:58:42 + > From: Colin Ian King > > Pointer rxdesc is assigned a value that is never read, it is overwritten > by a new assignment inside a while loop hence the initial assignment > is redundant

Re: [PATCH iproute2-next 0/4] ip: Introduce and use helper to read /proc/net/dev

2018-02-01 Thread Serhey Popovych
Stephen Hemminger wrote: > On Wed, 31 Jan 2018 21:49:45 +0200 > Serhey Popovych wrote: > >> Currently there is two places in ip(8) where /proc/net/dev is read line >> by line with nearly identical steps: iptunnel.c and ip6tunnel.c >> >> On the other hand we have

Re: [PATCH 0/6] Netfilter fixes for net

2018-02-01 Thread David Miller
From: Pablo Neira Ayuso Date: Thu, 1 Feb 2018 19:02:11 +0100 > The following patchset contains Netfilter fixes for your net tree, > they are: > > 1) Fix OOM that syskaller triggers with ipt_replace.size = -1 and >IPT_SO_SET_REPLACE socket option, from Dmitry Vyukov. >

[PATCH v2] net: pxa168_eth: add netconsole support

2018-02-01 Thread Alexander Monakov
This implements ndo_poll_controller callback which is necessary to enable netconsole. Signed-off-by: Alexander Monakov Cc: Russell King Cc: Sebastian Hesselbarth Cc: Florian Fainelli ---

[RFC][PATCH iproute2-next 4/6] iptunnel/ip6tunnel: Code cleanups

2018-02-01 Thread Serhey Popovych
Use switch () instead of if () to compare tunnel type to fit into 80 columns and make code more readable. Print "\n" using fputc(). In iptunnel.c abstract tunnel parameters matching code in iptunnel.c into ip_tunnel_parm_match() helper to conform with ip6tunnel.c. In ip6tunnel.c no need to call

[RFC][PATCH iproute2-next 5/6] iptunnel/ip6tunnel: Use netlink to walk through tunnels list

2018-02-01 Thread Serhey Popovych
Signed-off-by: Serhey Popovych --- ip/ip6tunnel.c | 115 --- ip/iptunnel.c | 108 ++- ip/tunnel.c| 117 +---

[RFC][PATCH iproute2-next 3/6] tunnel: Split statistic getting and printing

2018-02-01 Thread Serhey Popovych
This is first step to move tunnel code to use rtnl dump interface instead of /proc/net/dev read. Make tnl_print_stats() to accept @struct rtnl_link_stats64 parameter, introduce tnl_get_stats() that will parse line from /proc/net/dev into @struct rtnl_link_stats64. Signed-off-by: Serhey Popovych

[RFC][PATCH iproute2-next 6/6] tuntap: Use netlink to walk through tuntap list

2018-02-01 Thread Serhey Popovych
It seems bad idea to depend on sysfs being mounted and reflected to the current network namespace. Same applies to procfs. Instead netlink should be used to talk to the kernel and get list of specific network devices among with their parameters. Support for kernel netlink message filtering by

[RFC][PATCH iproute2-next 2/6] ip: Introduce get_rtnl_link_stats_rta() to get link statistics

2018-02-01 Thread Serhey Popovych
Assume all statistics in ip(8) represented either by IFLA_STATS64 or IFLA_STATS is 64 bit. It is clean that we can store __u32 counters of @struct rtnl_link_stats in __u64 counters in @struct rtnl_link_stats64. New get_rtnl_link_stats_rta() follows __print_link_stats() behaviour on handling of

[RFC][PATCH iproute2-next 1/6] ipaddress: Unify print_link_stats() and print_link_stats64()

2018-02-01 Thread Serhey Popovych
To show real differences between these two variants adjust whitespace intendation and use print_uint() instead of print_int() as all members in both @struct rtnl_link_stats and @struct rtnl_link_stats64 are unsigned. Signed-off-by: Serhey Popovych --- ip/ipaddress.c |

[RFC][PATCH iproute2-next 0/6] ip: Use netlink to walk through network device list

2018-02-01 Thread Serhey Popovych
In this seris I replace /proc/net/dev and /sys/class/net usage for walk through network device list in iptunnel/ip6tunnel and iptuntap by rtnl_dump_filter() functionality. This is an RFC, tested minimally tunnels, tuntap seems work as before. Note that some comments, especially for

Re: [PATCH] vmxnet3: remove redundant initialization of pointer 'rq'

2018-02-01 Thread Shrikrishna Khare
On Thu, 1 Feb 2018, Colin King wrote: > From: Colin Ian King > > Pointer rq is being initialized but this value is never read, it > is being updated inside a for-loop. Remove the initialization and > move it into the scope of the for-loop. > > Cleans up clang

Re: sctp netns "unregister_netdevice: waiting for lo to become free. Usage count = 1"

2018-02-01 Thread Neil Horman
On Thu, Feb 01, 2018 at 08:02:07PM +0200, Tommi Rantala wrote: > 2018-01-31 19:51 GMT+02:00 Tommi Rantala : > > On 31.01.2018 14:31, Neil Horman wrote: > >> > >> On Wed, Jan 31, 2018 at 11:42:24AM +0200, Tommi Rantala wrote: > >>> > >>> I think there's a problem in the

ethtool 4.15 released

2018-02-01 Thread John W. Linville
ethtool version 4.15 has been released. Home page: https://www.kernel.org/pub/software/network/ethtool/ Download link: https://www.kernel.org/pub/software/network/ethtool/ethtool-4.15.tar.xz Release notes: * Feature: Support for FEC encoding control * Fix: Fix coding style

[PATCH] ixgbevf: remove redundant initialization of variable 'dma'.

2018-02-01 Thread Colin King
From: Colin Ian King Variable dma is initialized with a value that is never read, later on it is re-assigned a new value, hence the initialization is redundant and can be removed. Cleans up clang warning: drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c:584:13:

[PATCH net] net: igmp: add a missing rcu locking section

2018-02-01 Thread Eric Dumazet
From: Eric Dumazet Newly added igmpv3_get_srcaddr() needs to be called under rcu lock. Timer callbacks do not ensure this locking. = WARNING: suspicious RCU usage 4.15.0+ #200 Not tainted -

Re: possible deadlock in do_ip_getsockopt

2018-02-01 Thread Florian Westphal
syzbot wrote: > Hello, > > syzbot hit the following crash on upstream commit > c4e0ca7fa24137e372d6135fe16e8df8e123f116 (Fri Jan 26 23:10:50 2018 +) > Merge tag 'riscv-for-linus-4.15-maintainers' of >

Re: sctp netns "unregister_netdevice: waiting for lo to become free. Usage count = 1"

2018-02-01 Thread Tommi Rantala
2018-01-31 19:51 GMT+02:00 Tommi Rantala : > On 31.01.2018 14:31, Neil Horman wrote: >> >> On Wed, Jan 31, 2018 at 11:42:24AM +0200, Tommi Rantala wrote: >>> >>> I think there's a problem in the dst refcounting in sctp_v4_get_dst() >>> >>> There's a dst_entry struct that

[PATCH, net] ibmvnic: fix firmware version when no firmware level has been provided by the VIOS server

2018-02-01 Thread Desnes Augusto Nunes do Rosario
Older versions of VIOS servers do not send the firmware level in the VPD buffer for the ibmvnic driver. Thus, not only the current message is mis- leading but the firmware version in the ethtool will be NULL. Therefore, this patch fixes the firmware string and its warning. Fixes: 4e6759be28e4

[PATCH 0/6] Netfilter fixes for net

2018-02-01 Thread Pablo Neira Ayuso
Hi David, The following patchset contains Netfilter fixes for your net tree, they are: 1) Fix OOM that syskaller triggers with ipt_replace.size = -1 and IPT_SO_SET_REPLACE socket option, from Dmitry Vyukov. 2) Check for too long extension name in xt_request_find_{match|target} that result

[PATCH 2/6] netfilter: x_tables: avoid out-of-bounds reads in xt_request_find_{match|target}

2018-02-01 Thread Pablo Neira Ayuso
From: Eric Dumazet It looks like syzbot found its way into netfilter territory. Issue here is that @name comes from user space and might not be null terminated. Out-of-bound reads happen, KASAN is not happy. v2 added similar fix for xt_request_find_target(), as Florian

[PATCH 3/6] netfilter: ipset: Fix wraparound in hash:*net* types

2018-02-01 Thread Pablo Neira Ayuso
From: Jozsef Kadlecsik Fix wraparound bug which could lead to memory exhaustion when adding an x.x.x.x-255.255.255.255 range to any hash:*net* types. Fixes Netfilter's bugzilla id #1212, reported by Thomas Schwark. Fixes: 48596a8ddc46 ("netfilter: ipset: Fix adding an

[PATCH 4/6] netfilter: x_tables: fix pointer leaks to userspace

2018-02-01 Thread Pablo Neira Ayuso
From: Dmitry Vyukov Several netfilter matches and targets put kernel pointers into info objects, but don't set usersize in descriptors. This leads to kernel pointer leaks if a match/target is set and then read back to userspace. Properly set usersize for these

[PATCH] ath5k: remove duplicated re-assignment to pointer 'tq'

2018-02-01 Thread Colin King
From: Colin Ian King Pointer tq is initialized with >ah_txq[queue] and then a few lines later is re-assigned the same value, hence this duplicate assignment is redundant and can be removed. Cleans up clang warning: drivers/net/wireless/ath/ath5k/qcu.c:326:25: warning:

Re: [PATCH] vsock.7: document VSOCK socket address family

2018-02-01 Thread Stefan Hajnoczi
On Tue, Jan 30, 2018 at 10:31:54PM +0100, Michael Kerrisk (man-pages) wrote: > Hi Stefan, > > Ping on the below please, since it either blocks the man-pages release > I'd currently like to make, or I must remove the vsock.7 page for this > release. Sorry for the delay. The verbatim license is

  1   2   >