Re: [PATCH RFC iproute-next 2/5] rdma: Add CM_ID resource tracking information

2018-02-20 Thread Leon Romanovsky
On Wed, Feb 14, 2018 at 01:07:01PM -0800, Steve Wise wrote: > Sample output: > > # rdma resource > 2: cxgb4_0: pd 5 cq 2 qp 2 cm_id 3 mr 7 > 3: mlx4_0: pd 7 cq 3 qp 3 cm_id 3 mr 7 > > # rdma resource show cm_id > [root@stevo1 iproute2]# /root/stevo/iproute2/rdma/rdma resource show cm_id > link cxg

[PATCH iproute2] rdma: Avoid memory leak for skipper resource

2018-02-20 Thread Leon Romanovsky
From: Leon Romanovsky The call to get_task_name() allocates memory which is not freed in case of skipping the object. Fixes: 8ecac46a60ff ("rdma: Add QP resource tracking information") Signed-off-by: Leon Romanovsky --- rdma/res.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff

[PATCH iproute2-next v2] ip link: add support to display extended tun attributes

2018-02-20 Thread Sabrina Dubroca
Signed-off-by: Sabrina Dubroca Reviewed-by: Stefano Brivio --- v2: define print_onoff to print flags, fix checkpatch warnings, drop header changes ip/iptuntap.c | 86 +++ 1 file changed, 86 insertions(+) diff --git a/ip/iptuntap.c b/ip/ip

[PATCH iproute2] ip: link_gre6.c: Support IP6_TNL_F_ALLOW_LOCAL_REMOTE flag

2018-02-20 Thread Petr Machata
For IP-in-IP tunnels, one can specify the [no]allow-localremote command when configuring a device. Under the hood, this flips the IP6_TNL_F_ALLOW_LOCAL_REMOTE flag on the netdevice. However, ip6gretap and ip6erspan devices, where the flag is also relevant, are not IP-in-IP tunnels, and thus there's

[4.4-stable 04/22] isdn: sc: work around type mismatch warning

2018-02-20 Thread Arnd Bergmann
This driver shows warnings on many architectures: drivers/isdn/sc/init.c: In function 'identify_board': drivers/isdn/sc/init.c:484:2: error: passing argument 1 of 'readl' makes pointer from integer without a cast [-Werror] In newer kernels, it was completely removed, but for the 4.4-stable serie

[4.4-stable 11/22] netlink: fix nla_put_{u8,u16,u32} for KASAN

2018-02-20 Thread Arnd Bergmann
commit b4391db42308c9940944b5d7be5ca4b78fb88dd0 upstream. When CONFIG_KASAN is enabled, the "--param asan-stack=1" causes rather large stack frames in some functions. This goes unnoticed normally because CONFIG_FRAME_WARN is disabled with CONFIG_KASAN by default as of commit 3f181b4d8652 ("lib/Kco

[4.4-stable 17/22] cw1200: fix bogus maybe-uninitialized warning

2018-02-20 Thread Arnd Bergmann
commit 7fc1503c906f0fac62d3506a6e993e49fb996248 upstream. On x86, the cw1200 driver produces a rather silly warning about the possible use of the 'ret' variable without an initialization presumably after being confused by the architecture specific definition of WARN_ON: drivers/net/wireless/st/cw

[4.4-stable 19/22] net: hp100: remove unnecessary #ifdefs

2018-02-20 Thread Arnd Bergmann
commit 747a11279a442b913a57bf38934879babab3b58b upstream. Building the hp100 ethernet driver causes warnings when both the PCI and EISA drivers are disabled: ethernet/hp/hp100.c: In function 'hp100_module_init': ethernet/hp/hp100.c:3047:2: warning: label 'out3' defined but not used [-Wunused-lab

Re: [RFC net PATCH] virtio_net: disable XDP_REDIRECT in receive_mergeable() case

2018-02-20 Thread Jesper Dangaard Brouer
On Fri, 16 Feb 2018 09:19:02 -0800 John Fastabend wrote: > On 02/16/2018 07:41 AM, Jesper Dangaard Brouer wrote: > > On Fri, 16 Feb 2018 13:31:37 +0800 > > Jason Wang wrote: > > > >> On 2018年02月16日 06:43, Jesper Dangaard Brouer wrote: > >>> The virtio_net code have three different RX code-p

Re: [PATCH RFC PoC 0/3] nftables meets bpf

2018-02-20 Thread Pablo Neira Ayuso
Hi Daniel, On Mon, Feb 19, 2018 at 08:57:39PM +0100, Daniel Borkmann wrote: > On 02/19/2018 05:37 PM, Pablo Neira Ayuso wrote: > [...] > > * Simplified infrastructure: We don't need the ebpf verifier complexity > > either given we trust the code we generate from the kernel. We don't > > need a

Appending firmware/hardware dump to vmcore during kernel panic

2018-02-20 Thread Rahul Lakkireddy
Hi all, We have a requirement to collect firmware/hardware state of the underlying NIC during kernel panic. We are doing this in cxgb4 driver, using panic notifier list [1]. cxgb4 registers a callback function to the panic notifier list, which gets invoked during kernel panic. In the callback fu

Re: [PATCH RFC 3/3] netfilter: nf_tables: add BPF-based jit infrastructure

2018-02-20 Thread Pablo Neira Ayuso
Hi David, On Mon, Feb 19, 2018 at 01:53:34PM -0500, David Miller wrote: > I'm very suprised that this is generating classical BPF filters. > > We have native eBPF and that is what anything generating new code > should be using, rather than the 20+ year old CBPF. I'm not the only one that likes 90

Re: [PATCH v2] sched: report if filter is too large to dump

2018-02-20 Thread Jiri Pirko
Mon, Feb 19, 2018 at 09:32:51PM CET, c...@rkapl.cz wrote: >So far, if the filter was too large to fit in the allocated skb, the >kernel did not return any error and stopped dumping. Modify the dumper >so that it returns -EMSGSIZE when a filter fails to dump and it is the >first filter in the skb. I

Re: [PATCH RFC 0/4] net: add bpfilter

2018-02-20 Thread Pablo Neira Ayuso
Hi David! On Mon, Feb 19, 2018 at 12:22:26PM -0500, David Miller wrote: [...] > Netfilter's chronic performance differential is why a lot of mindshare > was lost to userspace networking technologies. Claiming that Netfilter is the reason for the massive adoption of userspace networking isn't a fa

Re: [PATCH iproute2-next] ip link: add support to display extended tun attributes

2018-02-20 Thread Sabrina Dubroca
2018-02-20, 00:19:25 +0200, Serhey Popovych wrote: > I get following checkpatch.pl warnings: > > WARNING: Missing a blank line after declarations > #73: FILE: ip/iptuntap.c:497: > + __u8 mq = rta_getattr_u8(tb[IFLA_TUN_MULTI_QUEUE]); > + if (!mq) > > WARNING: Missing a

Re: [RFC PATCH v3 0/3] Enable virtio_net to act as a backup for a passthru device

2018-02-20 Thread Jiri Pirko
Fri, Feb 16, 2018 at 07:11:19PM CET, sridhar.samudr...@intel.com wrote: >Patch 1 introduces a new feature bit VIRTIO_NET_F_BACKUP that can be >used by hypervisor to indicate that virtio_net interface should act as >a backup for another device with the same MAC address. > >Ppatch 2 is in response to

Re: INFO: rcu detected stall in xfrm_confirm_neigh

2018-02-20 Thread Steffen Klassert
On Mon, Feb 19, 2018 at 11:05:38AM +0100, Dmitry Vyukov wrote: > On Mon, Feb 19, 2018 at 8:22 AM, Steffen Klassert > wrote: > >> > wrote: > >> >> Hello, > >> >> > >> >> syzbot hit the following crash on net-next commit > >> >> 9515a2e082f91457db0ecff4b65371d0fb5d9aad (Thu Jan 25 03:37:38 2018 >

Re: [PATCH RFC 0/4] net: add bpfilter

2018-02-20 Thread Michal Kubecek
On Mon, Feb 19, 2018 at 06:09:39PM +0100, Phil Sutter wrote: > What puzzles me about your argumentation is that you seem to propose for > the kernel to cover up flaws in userspace. Spinning this concept further > would mean that if there would be an old bug in iproute2 we should think > of adding a

Re: [PATCH net-next 0/6] tcp: remove non GSO code

2018-02-20 Thread Oleksandr Natalenko
Hi. 19.02.2018 20:56, Eric Dumazet wrote: Switching TCP to GSO mode, relying on core networking layers to perform eventual adaptation for dumb devices was overdue. 1) Most TCP developments are done with TSO in mind. 2) Less high-resolution timers needs to be armed for TCP-pacing 3) GSO can bene

Re: [RFC][PATCH bpf v2 1/2] bpf: allow 64-bit offsets for bpf function calls

2018-02-20 Thread Michael Ellerman
"Naveen N. Rao" writes: > Daniel Borkmann wrote: >> On 02/15/2018 05:25 PM, Daniel Borkmann wrote: >>> On 02/13/2018 05:05 AM, Sandipan Das wrote: The imm field of a bpf_insn is a signed 32-bit integer. For JIT-ed bpf-to-bpf function calls, it stores the offset from __bpf_call_base

Re: ppp/pppoe, still panic 4.15.3 in ppp_push

2018-02-20 Thread Denys Fedoryshchenko
On 2018-02-16 20:48, Guillaume Nault wrote: On Fri, Feb 16, 2018 at 01:13:18PM +0200, Denys Fedoryshchenko wrote: On 2018-02-15 21:42, Guillaume Nault wrote: > On Thu, Feb 15, 2018 at 09:34:42PM +0200, Denys Fedoryshchenko wrote: > > On 2018-02-15 21:31, Guillaume Nault wrote: > > > On Thu, Feb

Re: net: hang in unregister_netdevice: waiting for lo to become free

2018-02-20 Thread Dmitry Vyukov
On Tue, Feb 20, 2018 at 8:56 AM, Tommi Rantala wrote: > On 19.02.2018 20:59, Dmitry Vyukov wrote: >> >> On Sat, Feb 3, 2018 at 1:15 PM, Xin Long wrote: > > On 1/30/18 1:57 PM, David Ahern wrote: >> >> On 1/30/18 1:08 PM, Daniel Borkmann wrote: >>> >>> On 01/30/2018 07:32 P

<    1   2   3