RE: [EXT] [PATCH net-next v2 0/2] phylink: API changes

Hi Florian Please keep CC Yelena Krivosheev for changes withdrivers/net/ethernet/marvell/mvneta.c Thanks Yan Markman Tel. 05-44732819 -Original Message- From: Florian Fainelli [mailto:f.faine...@gmail.com] Sent: Thursday, March 29, 2018 1:44 AM To:

Re: [PATCH v3 1/2] of_net: Implement of_get_nvmem_mac_address helper

On 28-03-18 00:50, Florian Fainelli wrote: On 03/27/2018 02:52 AM, Mike Looijmans wrote: It's common practice to store MAC addresses for network interfaces into nvmem devices. However the code to actually do this in the kernel lacks, so this patch adds of_get_nvmem_mac_address() for drivers to

Re: [PATCH 2/2] rhashtable: improve rhashtable_walk stability when stop/start used.

On Thu, Mar 29, 2018 at 12:19:10PM +1100, NeilBrown wrote: > When a walk of an rhashtable is interrupted with rhastable_walk_stop() > and then rhashtable_walk_start(), the location to restart from is based > on a 'skip' count in the current hash chain, and this can be incorrect > if insertions or

Re: [PATCH 1/2] rhashtable: fix insertion of in rhltable when duplicate found.

On Thu, Mar 29, 2018 at 12:19:09PM +1100, NeilBrown wrote: > When rhltable_insert() finds an entry with the same key, > it splices the new entry at the start of a list of entries with the > same key. > It stores the address of the new object in *pprev, but in general this > is *not* the location

[PATCH v4 1/2] of_net: Implement of_get_nvmem_mac_address helper

It's common practice to store MAC addresses for network interfaces into nvmem devices. However the code to actually do this in the kernel lacks, so this patch adds of_get_nvmem_mac_address() for drivers to obtain the address from an nvmem cell provider. This is particulary useful on devices where

[PATCH v4 0/2] of_net: Implement of_get_nvmem_mac_address helper

Posted this as a small set now, with an (optional) second patch that shows how the changes work and what I've used to test the code on a Topic Miami board. I've taken the liberty to add appropriate "Acked" and "Review" tags. v4: Replaced "6" with ETH_ALEN v3: Add patch that implements mac in

[PATCH v4 2/2] net: macb: Try to retrieve MAC addess from nvmem provider

Call of_get_nvmem_mac_address() to fetch the MAC address from an nvmem cell, if one is provided in the device tree. This allows the address to be stored in an I2C EEPROM device for example. Signed-off-by: Mike Looijmans Acked-by: Nicolas Ferre

Re: [PATCH 5/6] rhashtable: support guaranteed successful insertion.

On Thu, Mar 29, 2018 at 08:26:21AM +1100, NeilBrown wrote: > > I say "astronomically unlikely", you say "probability .. is extremely > low". I think we are in agreement here. > > The point remains that if an error *can* be returned then I have to > write code to handle it and test that code.

Re: [PATCH][next] wil6210: fix potential null dereference of ndev before null check

me...@codeaurora.org writes: > On 2018-03-28 20:40, Colin King wrote: >> From: Colin Ian King >> >> The pointer ndev is being dereferenced before it is being null checked, >> hence there is a potential null pointer deference. Fix this by only >> dereferencing ndev after

how to disable DIFS and Backoff in 802.11 ath9k or ath5k driver

Dear All, I am a researcher on 802.11 network security. I am doing a project where the first two stations are communicating and the third station tries to inject an forged 802.11 ACK if the last data frame is lost. The ACK must be arrived to the data sender before the ACK timer expires. Therefore

Re: [Xen-devel] [PATCH v2 1/1] xen-netback: process malformed sk_buff correctly to avoid BUG_ON()

Hi Eric, On 03/29/2018 12:03 PM, Eric Dumazet wrote: > > > On 03/28/2018 08:51 PM, Dongli Zhang wrote: >> The "BUG_ON(!frag_iter)" in function xenvif_rx_next_chunk() is triggered if >> the received sk_buff is malformed, that is, when the sk_buff has pattern >> (skb->data_len &&

Re: [PATCH net V2] vhost: correctly remove wait queue during poll failure

On Tue, Mar 27, 2018 at 08:50:52PM +0800, Jason Wang wrote: > We tried to remove vq poll from wait queue, but do not check whether > or not it was in a list before. This will lead double free. Fixing > this by switching to use vhost_poll_stop() which zeros poll->wqh after > removing poll from

Re: [PATCH v2 1/1] xen-netback: process malformed sk_buff correctly to avoid BUG_ON()

On 03/28/2018 08:51 PM, Dongli Zhang wrote: > The "BUG_ON(!frag_iter)" in function xenvif_rx_next_chunk() is triggered if > the received sk_buff is malformed, that is, when the sk_buff has pattern > (skb->data_len && !skb_shinfo(skb)->nr_frags). Below is a sample call > stack: > >... > > The

[PATCH v2 1/1] xen-netback: process malformed sk_buff correctly to avoid BUG_ON()

The "BUG_ON(!frag_iter)" in function xenvif_rx_next_chunk() is triggered if the received sk_buff is malformed, that is, when the sk_buff has pattern (skb->data_len && !skb_shinfo(skb)->nr_frags). Below is a sample call stack: [ 438.652658] [ cut here ] [ 438.652660]

Re: [PATCH iproute2-next 0/2] more JSON support

On 3/27/18 7:07 PM, Stephen Hemminger wrote: > From: Stephen Hemminger > > Add JSON to ILA and L2TP display > > Stephen Hemminger (2): > ip/ila: support json and color > ip/l2tp: add JSON support > > ip/ipila.c | 76 +++--- > ip/ipl2tp.c |

Re: [iproute2 0/1] iproute2: add TIPC statistics support in ss

On 3/23/18 8:01 AM, GhantaKrishnamurthy MohanKrishna wrote: > The following patchset add user space TIPC socket diagnostics support > in ss tool of iproute2. It requires the sock_diag framework > for AF_TIPC support in the kernel, commit id: c30b70deb5f > (tipc: implement socket diagnostics for

Re: [PATCH bpf-next 00/14] nfp: bpf: add updates, deletes, atomic ops, prandom and packet cache

On Wed, Mar 28, 2018 at 05:48:24PM -0700, Jakub Kicinski wrote: > Hi! > > This set adds support for update and delete calls from the datapath, > as well as XADD instructions (32 and 64 bit) and pseudo random numbers. > The XADD support depends on verifier enforcing alignment which Daniel >

Re: [PATCH] vhost-net: add time limitation for tx polling(Internet mail)

On 2018年03月28日 23:31, Michael S. Tsirkin wrote: On Wed, Mar 28, 2018 at 02:37:04PM +0800, Jason Wang wrote: On 2018年03月28日 12:01, haibinzhang(张海斌) wrote: On 2018年03月27日 19:26, Jason wrote On 2018年03月27日 17:12, haibinzhang wrote: handle_tx() will delay rx for a long time when busy tx

[PATCH net-next 0/2] nfp: flower: handle MTU changes

Hi! This set improves MTU handling for flower offload. The max MTU is correctly capped and physical port MTU is communicated to the FW (and indirectly HW). John Hurley (2): nfp: app: modify app MTU setting callbacks nfp: flower: offload phys port MTU change

[PATCH net-next 1/2] nfp: modify app MTU setting callbacks

From: John Hurley Rename the 'change_mtu' app callback to 'check_mtu'. This is called whenever an MTU change is requested on a netdev. It can reject the change but is not responsible for implementing it. Introduce a new 'repr_change_mtu' app callback that is hit when

[PATCH net-next 2/2] nfp: flower: offload phys port MTU change

From: John Hurley Trigger a port mod message to request an MTU change on the NIC when any physical port representor is assigned a new MTU value. The driver waits 10 msec for an ack that the FW has set the MTU. If no ack is received the request is rejected and an

Re: [PATCH 1/2] af_key: Use DIV_ROUND_UP() instead of open-coded equivalent

On Wed, Mar 28, 2018 at 07:59:25AM +0200, Steffen Klassert wrote: > On Mon, Mar 26, 2018 at 07:39:16AM -0400, Kevin Easton wrote: > > Several places use (x + 7) / 8 to convert from a number of bits to a number > > of bytes. Replace those with DIV_ROUND_UP(x, 8) instead, for consistency > > with

[PATCH 0/2] rhashtable_walk fixes

These two patches apply on top of my previous "rhashtable: reset iter when rhashtable_walk_start sees new table" patch. The first fixes a bug that I found in rhltable_insert(). The second is an alternate to my "rhashtable: allow a walk of the hash table without missing object." This version

[PATCH 2/2] rhashtable: improve rhashtable_walk stability when stop/start used.

When a walk of an rhashtable is interrupted with rhastable_walk_stop() and then rhashtable_walk_start(), the location to restart from is based on a 'skip' count in the current hash chain, and this can be incorrect if insertions or deletions have happened. This does not happen when the walk is not

[PATCH 1/2] rhashtable: fix insertion of in rhltable when duplicate found.

When rhltable_insert() finds an entry with the same key, it splices the new entry at the start of a list of entries with the same key. It stores the address of the new object in *pprev, but in general this is *not* the location where the match was found (though in a common case where the hash

Re: [PATCH 4/6] rhashtable: allow a walk of the hash table without missing objects.

On Thu, Mar 29 2018, NeilBrown wrote: > > How about storing the hash chains in order by object address? > Then rhashtable_walk_start() can easily find it's place regardless of > whether the old object was still present or not, using <= on the > address. > "Insert" would need to record an insert

[PATCH bpf-next 07/14] nfp: bpf: add map updates from the datapath

Support calling map_update_elem() from the datapath programs by calling into FW-provided helper. Value pointer is passed in LM pointer #2. Keeping track of old state for arg3 is not necessary, since LM pointer #2 will be always loaded in this case, the trivial optimization for value at the

[PATCH bpf-next 08/14] nfp: bpf: add map deletes from the datapath

Support calling map_delete_elem() FW helper from the datapath programs. For JIT checks and code are basically equivalent to map lookups. Similarly to other map helper key must be on the stack. Different pointer types are left for future extension. Signed-off-by: Jakub Kicinski

[PATCH bpf-next 06/14] nfp: bpf: add helper for basic map call checks

Add a verifier helper for performing the basic state checks before a call to a map helper. Signed-off-by: Jakub Kicinski Reviewed-by: Quentin Monnet Reviewed-by: Jiong Wang ---

[PATCH bpf-next 01/14] nfp: bpf: read from packet data cache for PTR_TO_PACKET

From: Jiong Wang This patch assumes there is a packet data cache, and would try to read packet data from the cache instead of from memory. This patch only implements the optimisation "backend", it doesn't build the packet data cache, so this optimisation is not

[PATCH bpf-next 09/14] bpf: add parenthesis around argument of BPF_LDST_BYTES()

BPF_LDST_BYTES() does not put it's argument in parenthesis when referencing it. This makes it impossible to pass pointers obtained by address-of operator (e.g. BPF_LDST_BYTES()). Add the parenthesis. Signed-off-by: Jakub Kicinski Reviewed-by: Quentin Monnet

[PATCH bpf-next 03/14] nfp: bpf: detect packet reads could be cached, enable the optimisation

From: Jiong Wang This patch is the front end of this optimisation, it detects and marks those packet reads that could be cached. Then the optimisation "backend" will be activated automatically. Signed-off-by: Jiong Wang Reviewed-by: Jakub

[PATCH bpf-next 05/14] nfp: bpf: add helper for validating stack pointers

Our implementation has restriction on stack pointers for function calls. Move the common checks into a helper for reuse. The state has to be encapsulated into a structure to support parameters other than BPF_REG_2. Signed-off-by: Jakub Kicinski Reviewed-by:

[PATCH bpf-next 12/14] nfp: bpf: add support for atomic add of unknown values

Allow atomic add to be used even when the value is not guaranteed to fit into a 16 bit immediate. This requires the value to be pulled as data, and therefore use of a transfer register and a context swap. Track the information about possible lengths of the value, if it's guaranteed to be larger

[PATCH bpf-next 13/14] nfp: bpf: add support for bpf_get_prandom_u32()

NFP has a prng register, which we can read to obtain a u32 worth of pseudo random data. Generate code for it. Signed-off-by: Jakub Kicinski Reviewed-by: Quentin Monnet Reviewed-by: Jiong Wang ---

[PATCH bpf-next 04/14] nfp: bpf: rename map_lookup_stack() to map_call_stack_common()

We will reuse most of map call code gen for other map calls. Rename the lookup gen function and use meta->func_id instead of hard-coding lookup. Signed-off-by: Jakub Kicinski Reviewed-by: Quentin Monnet Reviewed-by: Jiong Wang

[PATCH bpf-next 02/14] nfp: bpf: support unaligned read offset

From: Jiong Wang This patch add the support for unaligned read offset, i.e. the read offset to the start of packet cache area is not aligned to REG_WIDTH. In this case, the read area might across maximum three transfer-in registers. Signed-off-by: Jiong Wang

[PATCH bpf-next 14/14] nfp: bpf: improve wrong FW response warnings

When FW responds with a message of wrong size or type make sure the type is checked first and included in the wrong size message. This makes it easier to figure out which FW command failed. Signed-off-by: Jakub Kicinski Reviewed-by: Quentin Monnet

[PATCH bpf-next 11/14] nfp: bpf: expose command delay slots

Allow callers to control the delay slots of commands, instead of giving them just a wait/nowait choice. Signed-off-by: Jakub Kicinski Reviewed-by: Quentin Monnet Reviewed-by: Jiong Wang ---

[PATCH bpf-next 10/14] nfp: bpf: add basic support for atomic adds

Implement atomic add operation for 32 and 64 bit values. Depend on the verifier to ensure alignment. Values have to be kept in big endian and swapped upon read/write. For now only support atomic add of a constant. Signed-off-by: Jakub Kicinski Reviewed-by:

[PATCH bpf-next 00/14] nfp: bpf: add updates, deletes, atomic ops, prandom and packet cache

Hi! This set adds support for update and delete calls from the datapath, as well as XADD instructions (32 and 64 bit) and pseudo random numbers. The XADD support depends on verifier enforcing alignment which Daniel recently added. XADD uses NFP's atomic engine which requires values to be in big

Re: [PATCH v8 bpf-next 0/9] bpf, tracing: introduce bpf raw tracepoints

On 03/28/2018 09:05 PM, Alexei Starovoitov wrote: > v7->v8: > - moved 'u32 num_args' from 'struct tracepoint' into 'struct > bpf_raw_event_map' > that increases memory overhead, but can be optimized/compressed later. > Now it's zero changes in tracepoint.[ch] [...] > The first approach simply

RE: [Resend Patch 1/3] Vmbus: Add function to report available ring buffer to write in total ring size percentage

Maybe best through greg's char-misc tree since it has generic hv code and sometime updates both network and scsi. Alternatively, put common code through one tree, and hold off the network device change till next release. -Original Message- From: Long Li Sent: Wednesday, March 28,

[PATCH] atm: iphase: fix spelling mistake: "Receiverd" -> "Received"

From: Colin Ian King Trivial fix to spelling mistake in message text Signed-off-by: Colin Ian King --- drivers/atm/iphase.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/atm/iphase.c b/drivers/atm/iphase.c index

Re: WARNING in refcount_dec

(Cc'ing netdev and Willem) On Wed, Mar 28, 2018 at 12:03 PM, Byoungyoung Lee wrote: > Another crash patterns observed: race between (setsockopt$packet_int) > and (bind$packet). > > -- > [ 357.731597] kernel BUG at >

Re: [PATCH] gfs2: Stop using rhashtable_walk_peek

On 28 March 2018 at 23:53, NeilBrown wrote: > Thank for this patch! > The above looks a bit fragile to me. > gfs2_glock_iter_next() (And hence gfs2_glock_seq_start()) will sometimes > exit with gl_held true, and sometimes with it false. > gfs2_glock_seq_stop() assumes that it is

[PATCH net-next v2 0/2] phylink: API changes

Hi all, This patch series contains two API changes to PHYLINK which will later be used by DSA to migrate to PHYLINK. Because these are API changes that impact other outstanding work (e.g: MVPP2) I would rather get them included sooner to minimize conflicts. Thank you! Changes in v2: - added

[PATCH net-next v2 2/2] sfp/phylink: move module EEPROM ethtool access into netdev core ethtool

From: Russell King Provide a pointer to the SFP bus in struct net_device, so that the ethtool module EEPROM methods can access the SFP directly, rather than needing every user to provide a hook for it. Reviewed-by: Andrew Lunn Signed-off-by: Russell

[PATCH net-next v2 1/2] net: phy: phylink: Provide PHY interface to mac_link_{up,down}

In preparation for having DSA transition entirely to PHYLINK, we need to pass a PHY interface type to the mac_link_{up,down} callbacks because we may have to make decisions on that (e.g: turn on/off RGMII interfaces etc.). We do not pass an entire phylink_link_state because not all parameters

RE: [Resend Patch 1/3] Vmbus: Add function to report available ring buffer to write in total ring size percentage

> Subject: Re: [Resend Patch 1/3] Vmbus: Add function to report available ring > buffer to write in total ring size percentage > > > Long, > > > Netvsc has a function to calculate how much ring buffer in percentage > > is available to write. This function is also useful for storvsc and > >

[PATCH net-next] MAINTAINERS: update vmxnet3 driver maintainer

Shrikrishna Khare would no longer maintain the vmxnet3 driver. Taking over the role of vmxnet3 maintainer. Signed-off-by: Ronak Doshi Signed-off-by: Shrikrishna Khare --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Stable backport needed for "net: don't call update_pmtu unconditionally"

Hi, f15ca723c1 ("net: don't call update_pmtu unconditionally") fixes NULL derefs caused by a93bf0ff4490 ("vxlan: update skb dst pmtu on tx path"), which was backported to 4.14.24. We've received reports of panics with Open vSwitch and Weave through 4.14.30

Re: [PATCH v3 net 4/5] tcp: prevent bogus undos when SACK is not enabled

On Tue, Mar 13, 2018 at 3:25 AM, Ilpo Järvinen wrote: > When a cumulative ACK lands to high_seq at the end of loss > recovery and SACK is not enabled, the sender needs to avoid > false fast retransmits (RFC6582). The avoidance mechanisms is > implemented by remaining in

Re: [PATCH v3 net 2/5] tcp: prevent bogus FRTO undos with non-SACK flows

On Tue, Mar 13, 2018 at 3:25 AM, Ilpo Järvinen wrote: > > If SACK is not enabled and the first cumulative ACK after the RTO > retransmission covers more than the retransmitted skb, a spurious > FRTO undo will trigger (assuming FRTO is enabled for that RTO). > The reason

[PATCH net-next v2 1/3] net: systemport: Remove adaptive TX coalescing

Adaptive TX coalescing is not currently giving us any advantages and ends up making the CPU spin more frequently until TX completion. Deny and disable adaptive TX coalescing for now and rely on static configuration, we can always add it back later. Reviewed-by: Tal Gilboa

[PATCH net-next v2 2/3] net: systemport: Fix coalescing settings handling

There were a number of issues with setting the RX coalescing parameters: - we would not be preserving values that would have been configured across close/open calls, instead we would always reset to no timeout and 1 interrupt per packet, this would also prevent DIM from setting its default

[PATCH net-next v2 3/3] net: bcmgenet: Fix coalescing settings handling

There were a number of issues with setting the RX coalescing parameters: - we would not be preserving values that would have been configured across close/open calls, instead we would always reset to no timeout and 1 interrupt per packet, this would also prevent DIM from setting its default

[PATCH net-next v2 0/3] net: Broadcom drivers coalescing fixes

Hi all, Following Tal's review of the adaptive RX/TX coalescing feature added to the SYSTEMPORT and GENET driver a number of things showed up: - adaptive TX coalescing is not actually a good idea with the current way the estimator will program the ring, this results in a higher CPU load, NAPI

Re: RFC on writel and writel_relaxed

On Thu, 29 Mar 2018 08:31:32 +1100 Benjamin Herrenschmidt wrote: > On Thu, 2018-03-29 at 02:23 +1000, Nicholas Piggin wrote: > > On Wed, 28 Mar 2018 11:55:09 -0400 (EDT) > > David Miller wrote: > > > > > From: Benjamin Herrenschmidt

Re: [PATCH] net: phy: marvell10g: add thermal hwmon device

Hi Russell Guenter Roeck, the HWMON maintainer should also be involved in reviewing this patch. Andrew On Wed, Mar 28, 2018 at 11:20:26AM +0100, Russell King wrote: > Add a thermal monitoring device for the Marvell 88x3310, which updates > once a second. We also need to hook into

[PATCH] ath10k: avoid possible string overflow

The way that 'strncat' is used here raised a warning in gcc-8: drivers/net/wireless/ath/ath10k/wmi.c: In function 'ath10k_wmi_tpc_stats_final_disp_tables': drivers/net/wireless/ath/ath10k/wmi.c:4649:4: error: 'strncat' output truncated before terminating nul copying as many bytes from a string

Re: [PATCH net-next 2/2] sfp/phylink: move module EEPROM ethtool access into netdev core ethtool

On Wed, Mar 28, 2018 at 12:03:39PM -0700, Florian Fainelli wrote: > From: Russell King > > Provide a pointer to the SFP bus in struct net_device, so that the > ethtool module EEPROM methods can access the SFP directly, rather > than needing every user to provide a

Re: [Resend Patch 1/3] Vmbus: Add function to report available ring buffer to write in total ring size percentage

Long, > Netvsc has a function to calculate how much ring buffer in percentage is > available to write. This function is also useful for storvsc and other > vmbus devices. What is the submission strategy for this series? Do you expect it to go through net or scsi? If the latter, I'll need an ack

Re: [RFC PATCH v2 00/14] Introducing AF_XDP support

Hello, On Tue, 2018-03-27 at 18:59 +0200, Björn Töpel wrote: > From: Björn Töpel > > optimized for high performance packet processing and, in upcoming > patch sets, zero-copy semantics. In this v2 version, we have removed > all zero-copy related code in order to make it

Re: [PATCH net-next 2/3] net: systemport: Fix coalescing settings handling

On 03/28/2018 02:23 PM, Tal Gilboa wrote: > On 3/27/2018 10:47 PM, Florian Fainelli wrote: >> There were a number of issues with setting the RX coalescing parameters: >> >> - we would not be preserving values that would have been configured >>    across close/open calls, instead we would always

Re: [PATCH] gfs2: Stop using rhashtable_walk_peek

On Wed, Mar 28 2018, Andreas Gruenbacher wrote: > Function rhashtable_walk_peek is problematic because there is no > guarantee that the glock previously returned still exists; when that key > is deleted, rhashtable_walk_peek can end up returning a different key, > which would cause an

[PATCH v2 net-next 0/2] Add ATU/VTU statistics

Previous patches have added basic support for Address Translation Unit and VLAN translation Unit violation interrupts. Add statistics counters for when these occur, which can be accessed using ethtool. Downgrade one of the particularly spammy warnings from VTU violations to debug only, now that we

[PATCH v2 net-next 1/2] net: dsa: mv88e6xxx: Keep ATU/VTU violation statistics

Count the numbers of various ATU and VTU violation statistics and return them as part of the ethtool -S statistics. Signed-off-by: Andrew Lunn --- v2: int -> unsigned int --- drivers/net/dsa/mv88e6xxx/chip.c| 50 -

[PATCH v2 net-next 2/2] net: dsa: mv88e6xxx: Make VTU miss violations less spammy

VTU miss violations can happen under normal conditions. Don't spam the kernel log, downgrade the output to debug level only. The statistics counter will indicate it is happening, if anybody not debugging is interested. Signed-off-by: Andrew Lunn --- v2: Rather than delete, use

Re: [PATCH 4/6] rhashtable: allow a walk of the hash table without missing objects.

On Wed, Mar 28 2018, Herbert Xu wrote: > On Wed, Mar 28, 2018 at 06:17:57PM +1100, NeilBrown wrote: >> >> Sounds like over-kill to me. >> It might be reasonable to have a CONFIG_DEBUG_RHASHTABLE which enables >> extra to code to catch misuse, but I don't see the justification for >> always

Re: [PATCH 07/30] aio: add delayed cancel support

On Wed, Mar 28, 2018 at 05:35:26PM +0100, Al Viro wrote: > On Wed, Mar 28, 2018 at 09:29:03AM +0200, Christoph Hellwig wrote: > > static void aio_fsync_work(struct work_struct *work) > > { > > struct fsync_iocb *req = container_of(work, struct fsync_iocb, work); > > + struct aio_kiocb

Re: RFC on writel and writel_relaxed

On Thu, 2018-03-29 at 02:23 +1000, Nicholas Piggin wrote: > On Wed, 28 Mar 2018 11:55:09 -0400 (EDT) > David Miller wrote: > > > From: Benjamin Herrenschmidt > > Date: Thu, 29 Mar 2018 02:13:16 +1100 > > > > > Let's fix all archs, it's way easier

Re: [pci PATCH v7 2/5] virtio_pci: Add support for unmanaged SR-IOV on virtio_pci devices

On Mar 15, 2018, at 11:42 AM, Alexander Duyck wrote: > From: Alexander Duyck > > Hardware-realized virtio_pci devices can implement SR-IOV, so this > patch enables its use. The device in question is an upcoming Intel > NIC that implements

Re: [virtio-dev] [pci PATCH v7 1/5] pci: Add pci_sriov_configure_simple for PFs that don't manage VF resources

On Mar 15, 2018, at 11:41 AM, Alexander Duyck wrote: > From: Alexander Duyck > > This patch adds a common configuration function called > pci_sriov_configure_simple that will allow for managing VFs on devices > where the PF is not capable

Re: [PATCH 5/6] rhashtable: support guaranteed successful insertion.

On Wed, Mar 28 2018, Herbert Xu wrote: > On Wed, Mar 28, 2018 at 06:04:40PM +1100, NeilBrown wrote: >> >> I disagree. My patch 6 only makes it common instead of exceedingly >> rare. If any table in the list other than the first has a chain with 16 >> elements, then trying to insert an element

Re: [PATCH net-next 2/3] net: systemport: Fix coalescing settings handling

On 3/27/2018 10:47 PM, Florian Fainelli wrote: There were a number of issues with setting the RX coalescing parameters: - we would not be preserving values that would have been configured across close/open calls, instead we would always reset to no timeout and 1 interrupt per packet, this

Re: [PATCH net-next 3/3] net: bcmgenet: Fix coalescing settings handling

On 3/27/2018 10:47 PM, Florian Fainelli wrote: There were a number of issues with setting the RX coalescing parameters: - we would not be preserving values that would have been configured across close/open calls, instead we would always reset to no timeout and 1 interrupt per packet, this

Re: [PATCH] sunrpc: remove incorrect HMAC request initialization

Applying, thanks!--b. On Wed, Mar 28, 2018 at 10:57:22AM -0700, Eric Biggers wrote: > make_checksum_hmac_md5() is allocating an HMAC transform and doing > crypto API calls in the following order: > > crypto_ahash_init() > crypto_ahash_setkey() > crypto_ahash_digest() > > This is

[PATCH iproute2-next 1/1] tc: enable json output for actions

Signed-off-by: Roman Mashak --- tc/m_action.c | 23 ++- 1 file changed, 18 insertions(+), 5 deletions(-) diff --git a/tc/m_action.c b/tc/m_action.c index 6c3049c7db88..8891659ae15a 100644 --- a/tc/m_action.c +++ b/tc/m_action.c @@ -364,6 +364,7 @@

Re: [PATCH net-next 1/3] net: systemport: Remove adaptive TX coalescing

On 3/27/2018 10:47 PM, Florian Fainelli wrote: Adaptive TX coalescing is not currently giving us any advantages and ends up making the CPU spin more frequently until TX completion. Deny and disable adaptive TX coalescing for now and rely on static configuration, we can always add it back later.

Re: [PATCH net-next 1/2] net: dsa: mv88e6xxx: Keep ATU/VTU violation statistics

On 03/28/2018 12:33 PM, Andrew Lunn wrote: > On Wed, Mar 28, 2018 at 11:17:19AM -0700, Florian Fainelli wrote: >> On 03/27/2018 02:59 PM, Andrew Lunn wrote: >>> Count the numbers of various ATU and VTU violation statistics and >>> return them as part of the ethtool -S statistics. >>> >>>

[bpf-next PATCH v3 4/4] bpf: sockmap, more BPF_SK_SKB_STREAM_VERDICT tests

Add BPF_SK_SKB_STREAM_VERDICT tests for ingress hook. While we do this also bring stream tests in-line with MSG based testing. A map for skb options is added for userland to push options at BPF programs. Signed-off-by: John Fastabend --- samples/sockmap/sockmap_kern.c

[bpf-next PATCH v3 3/4] bpf: sockmap, BPF_F_INGRESS flag for BPF_SK_SKB_STREAM_VERDICT:

Add support for the BPF_F_INGRESS flag in skb redirect helper. To do this convert skb into a scatterlist and push into ingress queue. This is the same logic that is used in the sk_msg redirect helper so it should feel familiar. Signed-off-by: John Fastabend ---

[bpf-next PATCH v3 2/4] bpf: sockmap, add BPF_F_INGRESS tests

Add a set of tests to verify ingress flag in redirect helpers works correctly with various msg sizes. Signed-off-by: John Fastabend --- samples/sockmap/sockmap_kern.c | 41 +-- samples/sockmap/sockmap_test.sh | 22

[bpf-next PATCH v3 0/4] bpf, sockmap BPF_F_INGRESS support

This series adds the BPF_F_INGRESS flag support to the redirect APIs. Bringing the sockmap API in-line with the cls_bpf redirect APIs. We add it to both variants of sockmap programs, the first patch adds support for tx ulp hooks and the third patch adds support for the recv skb hooks. Patches two

[bpf-next PATCH v3 1/4] bpf: sockmap redirect ingress support

Add support for the BPF_F_INGRESS flag in sk_msg redirect helper. To do this add a scatterlist ring for receiving socks to check before calling into regular recvmsg call path. Additionally, because the poll wakeup logic only checked the skb recv queue we need to add a hook in TCP stack (similar to

Re: [PATCH v8 bpf-next 6/9] bpf: introduce BPF_RAW_TRACEPOINT

- On Mar 28, 2018, at 3:40 PM, rostedt rost...@goodmis.org wrote: > On Wed, 28 Mar 2018 12:38:48 -0700 > Alexei Starovoitov wrote: > >> On 3/28/18 12:34 PM, Steven Rostedt wrote: >> > On Wed, 28 Mar 2018 12:05:37 -0700 >> > Alexei Starovoitov wrote: >> > >>

Re: [PATCH v7 bpf-next 06/10] tracepoint: compute num_args at build time

- On Mar 28, 2018, at 3:38 PM, rostedt rost...@goodmis.org wrote: > On Wed, 28 Mar 2018 15:32:20 -0400 > Steven Rostedt wrote: > >> -#define __DO_TRACE(tp, proto, args, cond, rcucheck) \ >> +#define __DO_TRACE(name, proto, args, cond, rcucheck)

Re: [PATCH v8 bpf-next 6/9] bpf: introduce BPF_RAW_TRACEPOINT

On Wed, 28 Mar 2018 12:38:48 -0700 Alexei Starovoitov wrote: > On 3/28/18 12:34 PM, Steven Rostedt wrote: > > On Wed, 28 Mar 2018 12:05:37 -0700 > > Alexei Starovoitov wrote: > > > >> +++ b/include/linux/tracepoint-defs.h > >> @@ -35,4 +35,10 @@ struct tracepoint

Re: [PATCH v8 bpf-next 6/9] bpf: introduce BPF_RAW_TRACEPOINT

On 3/28/18 12:34 PM, Steven Rostedt wrote: On Wed, 28 Mar 2018 12:05:37 -0700 Alexei Starovoitov wrote: +++ b/include/linux/tracepoint-defs.h @@ -35,4 +35,10 @@ struct tracepoint { struct tracepoint_func __rcu *funcs; }; +struct bpf_raw_event_map { + struct

Re: [PATCH v7 bpf-next 06/10] tracepoint: compute num_args at build time

On Wed, 28 Mar 2018 15:32:20 -0400 Steven Rostedt wrote: > -#define __DO_TRACE(tp, proto, args, cond, rcucheck) \ > +#define __DO_TRACE(name, proto, args, cond, rcucheck) > \ > do {

Re: [PATCH v8 bpf-next 6/9] bpf: introduce BPF_RAW_TRACEPOINT

On Wed, 28 Mar 2018 12:05:37 -0700 Alexei Starovoitov wrote: > +++ b/include/linux/tracepoint-defs.h > @@ -35,4 +35,10 @@ struct tracepoint { > struct tracepoint_func __rcu *funcs; > }; > > +struct bpf_raw_event_map { > + struct tracepoint *tp; > + void

Re: [PATCH net-next 2/2] net: dsa: mv88e6xxx: Make VTU miss violations less spammy

On Wed, Mar 28, 2018 at 11:11:07AM -0700, Florian Fainelli wrote: > On 03/27/2018 02:59 PM, Andrew Lunn wrote: > > VTU miss violations can happen under normal conditions. Don't spam the > > kernel log. The statistics counter will indicate it is happening, if > > anybody is interested. > > > >

Re: [PATCH net-next 1/2] net: dsa: mv88e6xxx: Keep ATU/VTU violation statistics

On Wed, Mar 28, 2018 at 11:17:19AM -0700, Florian Fainelli wrote: > On 03/27/2018 02:59 PM, Andrew Lunn wrote: > > Count the numbers of various ATU and VTU violation statistics and > > return them as part of the ethtool -S statistics. > > > > Signed-off-by: Andrew Lunn > > --- >

Re: [PATCH v7 bpf-next 06/10] tracepoint: compute num_args at build time

On Wed, 28 Mar 2018 15:22:24 -0400 (EDT) Mathieu Desnoyers wrote: > > > cache hot/cold argument clearly doesn't apply. > > In the current situation I'm fine with adding this extra field > to struct tracepoint. However, we should keep in mind to move > all

Re: [PATCH v7 bpf-next 06/10] tracepoint: compute num_args at build time

On 3/28/18 12:22 PM, Mathieu Desnoyers wrote: - On Mar 28, 2018, at 2:54 PM, rostedt rost...@goodmis.org wrote: On Wed, 28 Mar 2018 11:19:34 -0700 Alexei Starovoitov wrote: On 3/28/18 11:10 AM, Steven Rostedt wrote: On Wed, 28 Mar 2018 11:03:24 -0700 Alexei Starovoitov

Re: [PATCH v7 bpf-next 06/10] tracepoint: compute num_args at build time

- On Mar 28, 2018, at 2:54 PM, rostedt rost...@goodmis.org wrote: > On Wed, 28 Mar 2018 11:19:34 -0700 > Alexei Starovoitov wrote: > >> On 3/28/18 11:10 AM, Steven Rostedt wrote: >> > On Wed, 28 Mar 2018 11:03:24 -0700 >> > Alexei Starovoitov wrote: >> > >> >>

Re: [PATCH net-next 2/2] sfp/phylink: move module EEPROM ethtool access into netdev core ethtool

On 03/28/2018 12:11 PM, Russell King - ARM Linux wrote: > On Wed, Mar 28, 2018 at 12:03:39PM -0700, Florian Fainelli wrote: >> From: Russell King >> >> Provide a pointer to the SFP bus in struct net_device, so that the >> ethtool module EEPROM methods can access the

Re: [PATCH net-next 2/2] sfp/phylink: move module EEPROM ethtool access into netdev core ethtool

On Wed, Mar 28, 2018 at 12:03:39PM -0700, Florian Fainelli wrote: > From: Russell King > > Provide a pointer to the SFP bus in struct net_device, so that the > ethtool module EEPROM methods can access the SFP directly, rather > than needing every user to provide a

Re: [PATCH net-next 1/2] ipv6: do not set routes if disable_ipv6 has been enabled

On 3/27/18 11:11 AM, Lorenzo Bianconi wrote: > Do not allow to set ipv6 routes from userspace if disable_ipv6 has been > enabled. The issue can be triggered using the following reproducer: > > - sysctl net.ipv6.conf.all.disable_ipv6=1 > - ip -6 route add a:b:c:d::/64 dev em1 > - ip -6 route show

  1   2   3   4   >