[PATCH v15 net-next 02/12] ethtool: enable Inline TLS in HW

2018-03-31 Thread Atul Gupta
Ethtool option enables TLS record offload on HW, user configures the feature for netdev capable of Inline TLS. This allows user to define custom sk_prot for Inline TLS sock Signed-off-by: Atul Gupta --- include/linux/netdev_features.h | 2 ++ net/core/ethtool.c

[PATCH v15 net-next 06/12] crypto: chtls - structure and macro for Inline TLS

2018-03-31 Thread Atul Gupta
Define Inline TLS state, connection management info. Supporting macros definition. Signed-off-by: Atul Gupta Reviewed-by: Michael Werner --- drivers/crypto/chelsio/chtls/chtls.h| 482

[PATCH v15 net-next 04/12] cxgb4: LLD driver changes to support TLS

2018-03-31 Thread Atul Gupta
Read the Inline TLS capability from firmware. Determine the area reserved for storing the keys Dump the Inline TLS tx and rx records count. Signed-off-by: Atul Gupta Reviewed-by: Michael Werner Reviewed-by: Casey Leedom ---

[PATCH v15 net-next 03/12] cxgb4: Inline TLS FW Interface

2018-03-31 Thread Atul Gupta
Key area size in hw-config file. CPL struct for TLS request and response. Work request for Inline TLS. Signed-off-by: Atul Gupta Reviewed-by: Casey Leedom --- drivers/net/ethernet/chelsio/cxgb4/t4_msg.h | 122 ++-

[PATCH v15 net-next 01/12] tls: support for Inline tls record

2018-03-31 Thread Atul Gupta
Facility to register Inline TLS drivers to net/tls. Setup TLS_HW_RECORD prot to listen on offload device. Cases handled - Inline TLS device exists, setup prot for TLS_HW_RECORD - Atleast one Inline TLS exists, sets TLS_HW_RECORD. - If non-inline device establish connection, move to TLS_SW_TX

WARNING: refcount bug in sk_alloc

2018-03-31 Thread syzbot
Hello, syzbot hit the following crash on upstream commit c2a9838452a4d71f76103c18c926468a9ea05713 (Fri Mar 30 05:27:12 2018 +) Merge tag 'for-4.16/dm-fixes-4' of git://git.kernel.org/pub/scm/linux/kernel/git/device-mapper/linux-dm syzbot dashboard link:

Re: [PATCH net-next 0/9] devlink: Add support for region access

2018-03-31 Thread Andrew Lunn
> I want to be able to login to a customer and accessing this snapshot > without any previous configuration from the user and not asking for > enabling the feature and then waiting for a repro...this will help > debugging issues that are hard to reproduce, I don't see any reason > to disable this.

Re: [PATCH bpf-next 01/10] bpf: btf: Introduce BPF Type Format (BTF)

2018-03-31 Thread Martin KaFai Lau
On Sat, Mar 31, 2018 at 04:43:28PM +0800, kbuild test robot wrote: > Hi Martin, > > Thank you for the patch! Perhaps something to improve: > > [auto build test WARNING on bpf-next/master] > > url: > https://github.com/0day-ci/linux/commits/Martin-KaFai-Lau/BTF-

Re: [PATCH bpf-next 07/10] bpf: btf: Add pretty print support to the basic arraymap

2018-03-31 Thread Martin KaFai Lau
On Sat, Mar 31, 2018 at 05:12:36PM +0800, kbuild test robot wrote: > Hi Martin, > > Thank you for the patch! Perhaps something to improve: > > [auto build test WARNING on bpf-next/master] > > url: > https://github.com/0day-ci/linux/commits/Martin-KaFai-Lau/BTF-

Re: INFO: task hung in tunnel_key_exit_net

2018-03-31 Thread Dmitry Vyukov
#syz dup: INFO: task hung in netdev_run_todo On Sat, Mar 31, 2018 at 5:43 PM, syzbot wrote: > Hello, > > syzbot hit the following crash on net-next commit > 18845557fd6fc1998f2d0d8c30467f86db587529 (Thu Mar 29 20:24:06 2018 +) > Merge

INFO: task hung in tunnel_key_exit_net

2018-03-31 Thread syzbot
Hello, syzbot hit the following crash on net-next commit 18845557fd6fc1998f2d0d8c30467f86db587529 (Thu Mar 29 20:24:06 2018 +) Merge tag 'wireless-drivers-next-for-davem-2018-03-29' of git://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers-next syzbot dashboard link:

[PATCH] sky2: Increase D3 delay to sky2 stops working after suspend

2018-03-31 Thread Kai-Heng Feng
The sky2 ethernet stops working after system resume from suspend: [ 582.852065] sky2 :04:00.0: Refused to change power state, currently in D3 The current 150ms delay is not enough, change it to 200ms can solve the issue. BugLink: https://bugs.launchpad.net/bugs/1758507 Cc: Stable

Re: [PATCH 06/12] wireless: Convert simple uses of a static const Ethernet broadcast address

2018-03-31 Thread Joe Perches
On Sat, 2018-03-31 at 14:01 +, Pkshih wrote: > On Sat, 2018-03-31 at 00:05 -0700, Joe Perches wrote: > > Use the new ether_broadcast_addr global instead to save some object code. [] > > diff --git a/drivers/net/wireless/realtek/rtlwifi/core.c [] > > @@ -1649,7 +1648,7 @@ static int

Re: [PATCH] Patch to replace DEFINE_SEMAPHORE with DEFINE_BINARY_SEMAPHORE

2018-03-31 Thread Greg Kroah-Hartman
On Sat, Mar 31, 2018 at 07:16:21PM +0530, Wasim Nazir wrote: > This message contains confidential information and is intended only for the > individual(s) named. If you are not the intended recipient, you are > notified that disclosing, copying, distributing or taking any action in > reliance

Re: [PATCH 06/12] wireless: Convert simple uses of a static const Ethernet broadcast address

2018-03-31 Thread Pkshih
On Sat, 2018-03-31 at 00:05 -0700, Joe Perches wrote: > Use the new ether_broadcast_addr global instead to save some object code. > > Signed-off-by: Joe Perches > --- >  drivers/net/wireless/admtek/adm8211.c   | 3 +-- >  drivers/net/wireless/ath/carl9170/mac.c |

Re: [RFC PATCH] inet: frags: lowpan_rhash_params can be static

2018-03-31 Thread Eric Dumazet
On 03/31/2018 12:47 AM, kbuild test robot wrote: > > Fixes: b051dbce5e50 ("inet: frags: use rhashtables for reassembly units") > Signed-off-by: Fengguang Wu > --- > reassembly.c |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git

Re: [PATCH v2 2/2] net: usb: asix88179_178a: de-duplicate code

2018-03-31 Thread Marc Zyngier
Alexander, David, On 2018-03-08 11:19, Alexander Kurz wrote: Remove the duplicated code for asix88179_178a bind and reset methods. Signed-off-by: Alexander Kurz --- drivers/net/usb/ax88179_178a.c | 117 +++-- 1 file changed, 31

Re: [net-next V8 PATCH 14/16] mlx5: use page_pool for xdp_return_frame call

2018-03-31 Thread Jesper Dangaard Brouer
On Sat, 31 Mar 2018 14:06:57 +0200 Jesper Dangaard Brouer wrote: > This patch shows how it is possible to have both the driver local page > cache, which uses elevated refcnt for "catching"/avoiding SKB > put_page returns the page through the page allocator. And at the >

[net-next V8 PATCH 11/16] xdp: rhashtable with allocator ID to pointer mapping

2018-03-31 Thread Jesper Dangaard Brouer
Use the IDA infrastructure for getting a cyclic increasing ID number, that is used for keeping track of each registered allocator per RX-queue xdp_rxq_info. Instead of using the IDR infrastructure, which uses a radix tree, use a dynamic rhashtable, for creating ID to pointer lookup table, because

[net-next V8 PATCH 16/16] xdp: transition into using xdp_frame for ndo_xdp_xmit

2018-03-31 Thread Jesper Dangaard Brouer
Changing API ndo_xdp_xmit to take a struct xdp_frame instead of struct xdp_buff. This brings xdp_return_frame and ndp_xdp_xmit in sync. This builds towards changing the API further to become a bulk API, because xdp_buff is not a queue-able object while xdp_frame is. V4: Adjust for commit

[net-next V8 PATCH 12/16] page_pool: refurbish version of page_pool code

2018-03-31 Thread Jesper Dangaard Brouer
Need a fast page recycle mechanism for ndo_xdp_xmit API for returning pages on DMA-TX completion time, which have good cross CPU performance, given DMA-TX completion time can happen on a remote CPU. Refurbish my page_pool code, that was presented[1] at MM-summit 2016. Adapted page_pool code to

[net-next V8 PATCH 13/16] xdp: allow page_pool as an allocator type in xdp_return_frame

2018-03-31 Thread Jesper Dangaard Brouer
New allocator type MEM_TYPE_PAGE_POOL for page_pool usage. The registered allocator page_pool pointer is not available directly from xdp_rxq_info, but it could be (if needed). For now, the driver should keep separate track of the page_pool pointer, which it should use for RX-ring page

[net-next V8 PATCH 07/16] virtio_net: convert to use generic xdp_frame and xdp_return_frame API

2018-03-31 Thread Jesper Dangaard Brouer
The virtio_net driver assumes XDP frames are always released based on page refcnt (via put_page). Thus, is only queues the XDP data pointer address and uses virt_to_head_page() to retrieve struct page. Use the XDP return API to get away from such assumptions. Instead queue an xdp_frame, which

[net-next V8 PATCH 09/16] i40e: convert to use generic xdp_frame and xdp_return_frame API

2018-03-31 Thread Jesper Dangaard Brouer
Also convert driver i40e, which very recently got XDP_REDIRECT support in commit d9314c474d4f ("i40e: add support for XDP_REDIRECT"). V7: This patch got added in V7 of this patchset. Signed-off-by: Jesper Dangaard Brouer --- drivers/net/ethernet/intel/i40e/i40e_txrx.c | 20

[net-next V8 PATCH 06/16] tun: convert to use generic xdp_frame and xdp_return_frame API

2018-03-31 Thread Jesper Dangaard Brouer
From: Jesper Dangaard Brouer The tuntap driver invented it's own driver specific way of queuing XDP packets, by storing the xdp_buff information in the top of the XDP frame data. Convert it over to use the more generic xdp_frame structure. The main problem with the in-driver

[net-next V8 PATCH 10/16] mlx5: register a memory model when XDP is enabled

2018-03-31 Thread Jesper Dangaard Brouer
Now all the users of ndo_xdp_xmit have been converted to use xdp_return_frame. This enable a different memory model, thus activating another code path in the xdp_return_frame API. V2: Fixed issues pointed out by Tariq. Signed-off-by: Jesper Dangaard Brouer Reviewed-by: Tariq

[net-next V8 PATCH 15/16] xdp: transition into using xdp_frame for return API

2018-03-31 Thread Jesper Dangaard Brouer
Changing API xdp_return_frame() to take struct xdp_frame as argument, seems like a natural choice. But there are some subtle performance details here that needs extra care, which is a deliberate choice. When de-referencing xdp_frame on a remote CPU during DMA-TX completion, result in the

[net-next V8 PATCH 08/16] bpf: cpumap convert to use generic xdp_frame

2018-03-31 Thread Jesper Dangaard Brouer
The generic xdp_frame format, was inspired by the cpumap own internal xdp_pkt format. It is now time to convert it over to the generic xdp_frame format. The cpumap needs one extra field dev_rx. Signed-off-by: Jesper Dangaard Brouer --- include/net/xdp.h |1 +

[net-next V8 PATCH 14/16] mlx5: use page_pool for xdp_return_frame call

2018-03-31 Thread Jesper Dangaard Brouer
This patch shows how it is possible to have both the driver local page cache, which uses elevated refcnt for "catching"/avoiding SKB put_page returns the page through the page allocator. And at the same time, have pages getting returned to the page_pool from ndp_xdp_xmit DMA completion. The

[net-next V8 PATCH 01/16] mlx5: basic XDP_REDIRECT forward support

2018-03-31 Thread Jesper Dangaard Brouer
This implements basic XDP redirect support in mlx5 driver. Notice that the ndo_xdp_xmit() is NOT implemented, because that API need some changes that this patchset is working towards. The main purpose of this patch is have different drivers doing XDP_REDIRECT to show how different memory models

[net-next V8 PATCH 04/16] xdp: move struct xdp_buff from filter.h to xdp.h

2018-03-31 Thread Jesper Dangaard Brouer
This is done to prepare for the next patch, and it is also nice to move this XDP related struct out of filter.h. Signed-off-by: Jesper Dangaard Brouer --- include/linux/filter.h | 24 +--- include/net/xdp.h | 22 ++ 2 files

[net-next V8 PATCH 05/16] xdp: introduce a new xdp_frame type

2018-03-31 Thread Jesper Dangaard Brouer
This is needed to convert drivers tuntap and virtio_net. This is a generalization of what is done inside cpumap, which will be converted later. Signed-off-by: Jesper Dangaard Brouer --- include/net/xdp.h | 40 1 file changed, 40

[net-next V8 PATCH 02/16] xdp: introduce xdp_return_frame API and use in cpumap

2018-03-31 Thread Jesper Dangaard Brouer
Introduce an xdp_return_frame API, and convert over cpumap as the first user, given it have queued XDP frame structure to leverage. V3: Cleanup and remove C99 style comments, pointed out by Alex Duyck. V6: Remove comment that id will be added later (Req by Alex Duyck) V8: Rename enum mem_type to

[net-next V8 PATCH 03/16] ixgbe: use xdp_return_frame API

2018-03-31 Thread Jesper Dangaard Brouer
Extend struct ixgbe_tx_buffer to store the xdp_mem_info. Notice that this could be optimized further by putting this into a union in the struct ixgbe_tx_buffer, but this patchset works towards removing this again. Thus, this is not done. Signed-off-by: Jesper Dangaard Brouer

[net-next V8 PATCH 00/16] XDP redirect memory return API

2018-03-31 Thread Jesper Dangaard Brouer
This V8 is send against net-next, because i40e got XDP_REDIRECT support in-between V6, and it doesn't exist in bpf-next yet. Most significant change in this V8, is that page_pool only gets compiled into the kernel when a drivers Kconfig 'select' the feature. This patchset works towards

Re: [PATCH] net: bond: skip vlan header when do layer 3+4 hash policy

2018-03-31 Thread Nikolay Aleksandrov
On 31/03/18 12:14, liujia...@huawei.com wrote: From: liujian When the hash policy is BOND_XMIT_POLICY_LAYER34 mode and skb protocol is 802.1q VLAN, the policy will be degenerated to LAYER2 mode; Now, change it to get the next layer protocol to ensure that it worked in

[PATCH] net: bond: skip vlan header when do layer 3+4 hash policy

2018-03-31 Thread liujian56
From: liujian When the hash policy is BOND_XMIT_POLICY_LAYER34 mode and skb protocol is 802.1q VLAN, the policy will be degenerated to LAYER2 mode; Now, change it to get the next layer protocol to ensure that it worked in BOND_XMIT_POLICY_LAYER34 mode. Signed-off-by:

Re: [PATCH bpf-next 07/10] bpf: btf: Add pretty print support to the basic arraymap

2018-03-31 Thread kbuild test robot
Hi Martin, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on bpf-next/master] url: https://github.com/0day-ci/linux/commits/Martin-KaFai-Lau/BTF-BPF-Type-Format/20180331-144656 base: https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git master

[RFC PATCH] bpf: btf: map_seq_next() can be static

2018-03-31 Thread kbuild test robot
Fixes: a1fffb3d6155 ("bpf: btf: Add pretty print support to the basic arraymap") Signed-off-by: Fengguang Wu --- inode.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/kernel/bpf/inode.c b/kernel/bpf/inode.c index 11ea64b..e3eec943 100644 ---

Re: [net-next V7 PATCH 07/16] virtio_net: convert to use generic xdp_frame and xdp_return_frame API

2018-03-31 Thread Jesper Dangaard Brouer
On Sat, 31 Mar 2018 02:22:35 +0800 kbuild test robot wrote: > reproduce: > # apt-get install sparse > make ARCH=x86_64 allmodconfig > make C=1 CF=-D__CHECK_ENDIAN__ [...] >417 >418static bool __virtnet_xdp_xmit(struct virtnet_info

[PATCH net-next v3 0/3] kernel: add support to collect hardware logs in crash recovery kernel

2018-03-31 Thread Rahul Lakkireddy
On production servers running variety of workloads over time, kernel panic can happen sporadically after days or even months. It is important to collect as much debug logs as possible to root cause and fix the problem, that may not be easy to reproduce. Snapshot of underlying hardware/firmware

[PATCH net-next v3 2/3] vmcore: append device dumps to vmcore as elf notes

2018-03-31 Thread Rahul Lakkireddy
Update read and mmap logic to append device dumps as additional notes before the other elf notes. We add device dumps before other elf notes because the other elf notes may not fill the elf notes buffer completely and we will end up with zero-filled data between the elf notes and the device dumps.

[PATCH net-next v3 1/3] vmcore: add API to collect hardware dump in second kernel

2018-03-31 Thread Rahul Lakkireddy
The sequence of actions done by device drivers to append their device specific hardware/firmware logs to /proc/vmcore are as follows: 1. During probe (before hardware is initialized), device drivers register to the vmcore module (via vmcore_add_device_dump()), with callback function, along with

[PATCH net-next v3 3/3] cxgb4: collect hardware dump in second kernel

2018-03-31 Thread Rahul Lakkireddy
Register callback to collect hardware/firmware dumps in second kernel before hardware/firmware is initialized. The dumps for each device will be available as elf notes in /proc/vmcore in second kernel. Signed-off-by: Rahul Lakkireddy Signed-off-by: Ganesh Goudar

[RFC PATCH] bpf: btf: enum_ops can be static

2018-03-31 Thread kbuild test robot
Fixes: 790d8de6fdc0 ("bpf: btf: Introduce BPF Type Format (BTF)") Signed-off-by: Fengguang Wu --- btf.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/bpf/btf.c b/kernel/bpf/btf.c index 3454e72..7841ed6 100644 --- a/kernel/bpf/btf.c +++

Re: [PATCH bpf-next 01/10] bpf: btf: Introduce BPF Type Format (BTF)

2018-03-31 Thread kbuild test robot
Hi Martin, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on bpf-next/master] url: https://github.com/0day-ci/linux/commits/Martin-KaFai-Lau/BTF-BPF-Type-Format/20180331-144656 base: https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git master

Re: [PATCH] Bluetooth: Mark expected switch fall-throughs

2018-03-31 Thread Marcel Holtmann
Hi Gustavo, > In preparation to enabling -Wimplicit-fallthrough, mark switch cases > where we are expecting to fall through. > > Signed-off-by: Gustavo A. R. Silva > --- > net/bluetooth/mgmt.c| 1 + > net/bluetooth/rfcomm/sock.c | 1 + > 2 files changed, 2

Re: [PATCH v3 net-next 08/12] inet: frags: use rhashtables for reassembly units

2018-03-31 Thread kbuild test robot
Hi Eric, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/Eric-Dumazet/inet-frags-bring-rhashtables-to-IP-defrag/20180331-142351 reproduce: # apt-get install sparse make ARCH

[RFC PATCH] inet: frags: lowpan_rhash_params can be static

2018-03-31 Thread kbuild test robot
Fixes: b051dbce5e50 ("inet: frags: use rhashtables for reassembly units") Signed-off-by: Fengguang Wu --- reassembly.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/ieee802154/6lowpan/reassembly.c b/net/ieee802154/6lowpan/reassembly.c index

[PATCH v2 bpf-next 03/10] bpf: btf: Check members of struct/union

2018-03-31 Thread Martin KaFai Lau
This patch checks a few things of struct's members: 1) It has a valid size (e.g. a "const void" is invalid) 2) A member's size (+ its member's offset) does not exceed the containing struct's size. 3) The member's offset satisfies the alignment requirement The above can only be done after the

[PATCH v2 bpf-next 07/10] bpf: btf: Add pretty print support to the basic arraymap

2018-03-31 Thread Martin KaFai Lau
This patch adds pretty print support to the basic arraymap. Support for other bpf maps can be added later. This patch adds new attrs to the BPF_MAP_CREATE command to allow specifying the btf_fd, btf_key_id and btf_value_id. The BPF_MAP_CREATE can then associate the btf to the map if the creating

[PATCH v2 bpf-next 08/10] bpf: btf: Sync bpf.h and btf.h to tools/

2018-03-31 Thread Martin KaFai Lau
This patch sync up the bpf.h and btf.h to tools/ Signed-off-by: Martin KaFai Lau Acked-by: Alexei Starovoitov --- tools/include/uapi/linux/bpf.h | 13 tools/include/uapi/linux/btf.h | 132 + 2 files changed, 145

[PATCH v2 bpf-next 09/10] bpf: btf: Add BTF support to libbpf

2018-03-31 Thread Martin KaFai Lau
If the ".BTF" elf section exists, libbpf will try to create a btf_fd (through BPF_BTF_LOAD). If that fails, it will still continue loading the bpf prog/map without the BTF. If the bpf_object has a BTF loaded, it will create a map with the btf_fd. libbpf will try to figure out the btf_key_id and

[PATCH v2 bpf-next 04/10] bpf: btf: Add pretty print capability for data with BTF type info

2018-03-31 Thread Martin KaFai Lau
This patch adds pretty print capability for data with BTF type info. The current usage is to allow pretty print of a BPF map. The next few patches will allow a read() on a pinned map with BTF type info for its key and value. This patch uses the seq_printf() infra. Signed-off-by: Martin KaFai

[PATCH v2 bpf-next 10/10] bpf: btf: Add BTF tests

2018-03-31 Thread Martin KaFai Lau
This patch tests the BTF loading, map_create with BTF and the changes in libbpf. -r: Raw tests that test raw crafted BTF data -f: Test LLVM compiled bpf prog with BTF data -g: Test BPF_OBJ_GET_INFO_BY_FD for btf_fd -p: Test pretty print The tools/testing/selftests/bpf/Makefile will probe for BTF

[PATCH v2 bpf-next 00/10] BTF: BPF Type Format

2018-03-31 Thread Martin KaFai Lau
This patch introduces BPF Type Format (BTF). BTF (BPF Type Format) is the meta data format which describes the data types of BPF program/map. Hence, it basically focus on the C programming language which the modern BPF is primary using. The first use case is to provide a generic pretty print

[PATCH v2 bpf-next 02/10] bpf: btf: Validate type reference

2018-03-31 Thread Martin KaFai Lau
After collecting all btf_type in the first pass in an earlier patch, the second pass (in this patch) can validate the reference types (e.g. the referring type does exist and it does not refer to itself). While checking the reference type, it also gathers other information (e.g. the size of an

[PATCH v2 bpf-next 01/10] bpf: btf: Introduce BPF Type Format (BTF)

2018-03-31 Thread Martin KaFai Lau
This patch introduces BPF type Format (BTF). BTF (BPF Type Format) is the meta data format which describes the data types of BPF program/map. Hence, it basically focus on the C programming language which the modern BPF is primary using. The first use case is to provide a generic pretty print

[PATCH v2 bpf-next 05/10] bpf: btf: Add BPF_BTF_LOAD command

2018-03-31 Thread Martin KaFai Lau
This patch adds a BPF_BTF_LOAD command which 1) loads and verifies the BTF (implemented in earlier patches) 2) returns a BTF fd to userspace. In the next patch, the BTF fd can be specified during BPF_MAP_CREATE. It currently limits to CAP_SYS_ADMIN. Signed-off-by: Martin KaFai Lau

[PATCH v2 bpf-next 06/10] bpf: btf: Add BPF_OBJ_GET_INFO_BY_FD support to BTF fd

2018-03-31 Thread Martin KaFai Lau
This patch adds BPF_OBJ_GET_INFO_BY_FD support to BTF fd. The original BTF data, which was used to create the BTF fd during the earlier BPF_BTF_LOAD call, will be returned. The userspace is expected to allocate buffer to info.info and the buffer size is set to info.info_len before calling

[PATCH 01/12] ethernet: Add generic ether__addr addresses

2018-03-31 Thread Joe Perches
Treewide there are ~60 declarations of Ethernet broadcast or zero address use as a 6 byte array that are later used as either an output for vsprintf extension %pM or as a source array to copy or compare. Create const globals for these uses with EXPORT_SYMBOL for modules. Miscellanea: o Rename

[PATCH 02/12] treewide/net: Rename eth_stp_addr to ether_stp_addr

2018-03-31 Thread Joe Perches
eth_stp_addr is not in the same form as the other global ether__addr addresses like ether_broadcast_addr. Convert it treewide. Miscellanea: o Add comment to the ether_stp_addr define to show it's for spanning-tree Signed-off-by: Joe Perches ---

[PATCH 00/12] Ethernet: Add and use ether__addr globals

2018-03-31 Thread Joe Perches
There are many local static and non-static arrays that are used for Ethernet broadcast address output or comparison. Centralize the array into a single separate file and remove the local arrays. Joe Perches (12): ethernet: Add generic ether__addr addresses treewide/net: Rename eth_stp_addr

[PATCH 03/12] net: mac80211: Use global ether_broadcast_addr

2018-03-31 Thread Joe Perches
Remove statics and use the new global ether_broadcast_addr instead to save some overall object code size. Signed-off-by: Joe Perches --- net/mac80211/iface.c| 5 + net/mac80211/key.c | 6 ++ net/mac80211/mesh_hwmp.c| 19 ++-

[PATCH 04/12] bridge: netfilter: Use the new global ether__addr arrays

2018-03-31 Thread Joe Perches
Remove the local consts and use the new globals. Signed-off-by: Joe Perches --- net/bridge/netfilter/ebt_stp.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/net/bridge/netfilter/ebt_stp.c b/net/bridge/netfilter/ebt_stp.c index

[PATCH 05/12] net: atm: Use ether_broadcast_addr

2018-03-31 Thread Joe Perches
Use the new global instead of a local static to reduce object code size a tiny bit. Signed-off-by: Joe Perches --- net/atm/lec.c | 12 +--- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/net/atm/lec.c b/net/atm/lec.c index 01d5d20a6eb1..ec47b45bd836

[PATCH 07/12] brcmfmac: Convert ALLFFMAC to ether_broadcast_addr

2018-03-31 Thread Joe Perches
Remove the local ALLFFMAC extern array and use the new global instead. Miscellanea: o Convert char *mac to const char *mac as it can't be modified Signed-off-by: Joe Perches --- drivers/net/wireless/broadcom/brcm80211/brcmfmac/common.c | 2 --

[PATCH 06/12] wireless: Convert simple uses of a static const Ethernet broadcast address

2018-03-31 Thread Joe Perches
Use the new ether_broadcast_addr global instead to save some object code. Signed-off-by: Joe Perches --- drivers/net/wireless/admtek/adm8211.c | 3 +-- drivers/net/wireless/ath/carl9170/mac.c | 4 +--- drivers/net/wireless/broadcom/b43/main.c| 3 +--

[PATCH 08/12] iwlegacy: Remove EXPORT_SYMBOL(il_bcast_addr) and use ether_broadcast_addr

2018-03-31 Thread Joe Perches
Remove the local array and use the new global instead to save some small amount of object code. Signed-off-by: Joe Perches --- drivers/net/wireless/intel/iwlegacy/3945-mac.c | 2 +- drivers/net/wireless/intel/iwlegacy/4965-mac.c | 2 +-

[PATCH 10/12] mvpp2: Use ether_broadcast_addr instead of a local array

2018-03-31 Thread Joe Perches
Save a small bit of object code by using the new global instead. Signed-off-by: Joe Perches --- drivers/net/ethernet/marvell/mvpp2.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/net/ethernet/marvell/mvpp2.c

[PATCH 12/12] ethernet: Use ether_zero_addr instead of local statics

2018-03-31 Thread Joe Perches
This saves a small amount of object code. Miscellanea: o __b44_cam_write now use const u8 *data instead of unsigned char * to avoid compiler warnings as it doesn't modify data Signed-off-by: Joe Perches --- drivers/net/ethernet/broadcom/b44.c | 5 ++---

[PATCH 09/12] iwlwifi: Remove local iwl_bcast_addr and use ether_broadcast_addr

2018-03-31 Thread Joe Perches
Use the new global to save a little bit of object code. Signed-off-by: Joe Perches --- drivers/net/wireless/intel/iwlwifi/dvm/dev.h | 1 - drivers/net/wireless/intel/iwlwifi/dvm/scan.c | 2 +- drivers/net/wireless/intel/iwlwifi/dvm/sta.c | 4 +--- 3 files changed, 2

[PATCH 11/12] qlogic: Convert local bcast_addr to global ether_broadcast_addr

2018-03-31 Thread Joe Perches
Use the new global instead of local statics to save a bit of object code. Signed-off-by: Joe Perches --- drivers/net/ethernet/qlogic/netxen/netxen_nic_hw.c | 5 + drivers/net/ethernet/qlogic/qlcnic/qlcnic_hw.c | 6 ++

Re: [PATCH] mt7601u: phy: mark expected switch fall-through

2018-03-31 Thread Jakub Kicinski
On Fri, 30 Mar 2018 16:12:23 -0500, Gustavo A. R. Silva wrote: > In preparation to enabling -Wimplicit-fallthrough, mark switch cases > where we are expecting to fall through. > > Signed-off-by: Gustavo A. R. Silva Acked-by: Jakub Kicinski

Re: [PATCH net-next] netdevsim: Change nsim_devlink_setup to return error to caller

2018-03-31 Thread Jakub Kicinski
On Fri, 30 Mar 2018 09:28:51 -0700, David Ahern wrote: > Change nsim_devlink_setup to return any error back to the caller and > update nsim_init to handle it. > > Requested-by: Jakub Kicinski > Signed-off-by: David Ahern Acked-by: Jakub

Re: [PATCH net-next 0/9] devlink: Add support for region access

2018-03-31 Thread Alex Vesker
On 3/31/2018 1:26 AM, David Ahern wrote: On 3/30/18 1:39 PM, Alex Vesker wrote: On 3/30/2018 7:57 PM, David Ahern wrote: On 3/30/18 8:34 AM, Andrew Lunn wrote: And it seems to want contiguous pages. How well does that work after the system has been running for a while and memory is

[PATCH net-next] vlan: vlan_hw_filter_capable() can be static

2018-03-31 Thread Wei Yongjun
Fixes the following sparse warning: net/8021q/vlan_core.c:168:6: warning: symbol 'vlan_hw_filter_capable' was not declared. Should it be static? Signed-off-by: Wei Yongjun --- net/8021q/vlan_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

<    1   2