Re: [PATCH iproute2] iplink_geneve: correct size of message to avoid spurious errors

2018-04-20 Thread William Tu
On Wed, Apr 18, 2018 at 11:06 AM, Jakub Kicinski wrote: > Commit 6c4b672738ac ("iplink_geneve: Get rid of inet_get_addr()") > inadvertently changed the parameter to addattr_l() resulting in: > > addattr_l ERROR: message exceeded bound of 4 > > when remote is

[PATCH net-next 1/1] tc-testing: updated ife test cases

2018-04-20 Thread Roman Mashak
Signed-off-by: Roman Mashak --- .../selftests/tc-testing/tc-tests/actions/ife.json | 1036 +++- 1 file changed, 1024 insertions(+), 12 deletions(-) diff --git a/tools/testing/selftests/tc-testing/tc-tests/actions/ife.json

Re: general protection fault in smc_setsockopt

2018-04-20 Thread syzbot
syzbot has found reproducer for the following crash on upstream commit 83beed7b2b26f232d782127792dd0cd4362fdc41 (Fri Apr 20 17:56:32 2018 +) Merge branch 'fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/evalenti/linux-soc-thermal syzbot dashboard link:

Re: [PATCH RFC net-next 00/11] udp gso

2018-04-20 Thread Alexander Duyck
On Fri, Apr 20, 2018 at 2:58 PM, Willem de Bruijn wrote: Also any plans for HW offload support for this? I vaguely recall that the igb and ixgbe parts had support for something like this in hardware. I would have to double check to see what exactly

pull-request: bpf-next 2018-04-21

2018-04-20 Thread Daniel Borkmann
Hi David, The following pull-request contains BPF updates for your *net-next* tree. The main changes are: 1) Initial work on BPF Type Format (BTF) is added, which is a meta data format which describes the data types of BPF programs / maps. BTF has its roots from CTF (Compact C-Type

pull-request: bpf 2018-04-21

2018-04-20 Thread Daniel Borkmann
Hi David, The following pull-request contains BPF updates for your *net* tree. The main changes are: 1) Fix a deadlock between mm->mmap_sem and bpf_event_mutex when one task is detaching a BPF prog via perf_event_detach_bpf_prog() and another one dumping through

[PATCH net-next, v2] Per interface IPv4 stats (CONFIG_IP_IFSTATS_TABLE)

2018-04-20 Thread Stephen Suryaputra
This is enhanced from the proposed patch by Igor Maravic in 2011 to support per interface IPv4 stats. The enhancement is mainly adding a kernel configuration option CONFIG_IP_IFSTATS_TABLE. Changes from v1: - Count input statistics in the input device (per Julian Anastasov). - Changes so that the

Re: unregister_netdevice: waiting for DEV to become free

2018-04-20 Thread syzbot
syzbot has found reproducer for the following crash on https://github.com/google/kmsan.git/master commit 48c6a2b0ab1b752451cdc40b5392471ed1a2a329 (Mon Apr 16 08:42:26 2018 +) mm/kmsan: fix origin calculation in kmsan_internal_check_memory syzbot dashboard link:

Query: eBPF socket filter

2018-04-20 Thread Tushar Dave
Hi, I am dealing with Reliable Datagram Socket (RDS) protocol and exploring ways to filter RDS traffic using eBPF. FYI, RDS sits on top of transport layer and works with transport such as TCP and IB/RDMA. So RDS messages arrive in form of skb (over TCP)and scatterlist (over IB/RDMA). For RDS

Re: [PATCH RFC net-next] net: ipvs: Adjust gso_size for IPPROTO_TCP

2018-04-20 Thread Martin KaFai Lau
On Fri, Apr 20, 2018 at 11:43:59PM +0300, Julian Anastasov wrote: > > Hello, > > On Thu, 19 Apr 2018, Martin KaFai Lau wrote: > > > This patch is not a proper fix and mainly serves for discussion purpose. > > It is based on net-next which I have been using to debug the issue. > > > > The

Re: [PATCH] iptables: Per-net ns lock

2018-04-20 Thread Andrei Vagin
On Fri, Apr 20, 2018 at 04:42:47PM +0300, Kirill Tkhai wrote: > Containers want to restore their own net ns, > while they may have no their own mnt ns. > This case they share host's /run/xtables.lock > file, but they may not have permission to open > it. > > Patch makes /run/xtables.lock to be

Re: Representative Needed.

2018-04-20 Thread PPMC OFFSHORE
Good day, I am seeking your concept with great gratitude to present you as a representative to carry out business transactions with a reasonable share upon your interest and cooperation to work with us in trust. If interested please get back. Regards Kingsley --- This email has been

Re: Representative Needed.

2018-04-20 Thread PPMC OFFSHORE
Good day, I am seeking your concept with great gratitude to present you as a representative to carry out business transactions with a reasonable share upon your interest and cooperation to work with us in trust. If interested please get back. Regards Kingsley --- This email has been

[PATCH net-next 2/7] net/ipv6: Rename rt6_get_cookie_safe

2018-04-20 Thread David Ahern
rt6_get_cookie_safe takes a fib6_info and checks the sernum of the node. Update the name to reflect its purpose. Signed-off-by: David Ahern --- include/net/ip6_fib.h | 6 +++--- net/ipv6/route.c | 4 ++-- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git

[PATCH net-next 4/7] net/ipv6: Move rcu locking to callers of fib6_get_cookie_safe

2018-04-20 Thread David Ahern
A later patch protects 'from' in rt6_info and this simplifies the locking needed by it. Signed-off-by: David Ahern --- include/net/ip6_fib.h | 6 -- net/ipv6/route.c | 13 ++--- 2 files changed, 14 insertions(+), 5 deletions(-) diff --git

[PATCH net-next 6/7] net/ipv6: Make from in rt6_info rcu protected

2018-04-20 Thread David Ahern
When a dst entry is created from a fib entry, the 'from' in rt6_info is set to the fib entry. The 'from' reference is used most notably for cookie checking - making sure stale dst entries are updated if the fib entry is changed. When a fib entry is deleted, the pcpu routes on it are walked

[PATCH net-next 5/7] net/ipv6: Move release of fib6_info from pcpu routes to helper

2018-04-20 Thread David Ahern
Code move only; no functional change intended. Signed-off-by: David Ahern --- net/ipv6/ip6_fib.c | 41 +++-- 1 file changed, 23 insertions(+), 18 deletions(-) diff --git a/net/ipv6/ip6_fib.c b/net/ipv6/ip6_fib.c index

[PATCH net-next 7/7] net/ipv6: Remove unncessary check on f6i in fib6_check

2018-04-20 Thread David Ahern
Dan reported an imbalance in fib6_check on use of f6i and checking whether it is null. Since fib6_check is only called if f6i is non-null, remove the unnecessary check. Reported-by: Dan Carpenter Signed-off-by: David Ahern --- net/ipv6/route.c | 3

[PATCH net-next 1/7] net/ipv6: Clean up rt expires helpers

2018-04-20 Thread David Ahern
rt6_clean_expires and rt6_set_expires are no longer used. Removed them. rt6_update_expires has 1 caller in route.c, so move it from the header. Signed-off-by: David Ahern --- include/net/ip6_fib.h | 21 - net/ipv6/route.c | 9 + 2 files

[PATCH net-next 0/7] net/ipv6: Another followup to the fib6_info change

2018-04-20 Thread David Ahern
Last one - for this week. Patches 1, 2 and 7 are more cleanup patches - removing dead code, moving code from a header to near its single caller, and updating function name. Patches 3-5 do some refactoring leading up to patch 6 which fixes a NULL dereference. I have only managed to trigger a

[PATCH net-next 3/7] net/ipv6: Move rcu_read_lock to callers of ip6_rt_cache_alloc

2018-04-20 Thread David Ahern
A later patch protects 'from' in rt6_info and this simplifies the locking needed by it. With the move, the fib6_info_hold for the uncached_rt is no longer needed since the rcu_lock is still held. Signed-off-by: David Ahern --- net/ipv6/route.c | 13 ++--- 1 file

[PATCH bpf-next v3 4/9] bpf/verifier: improve register value range tracking with ARSH

2018-04-20 Thread Yonghong Song
When helpers like bpf_get_stack returns an int value and later on used for arithmetic computation, the LSH and ARSH operations are often required to get proper sign extension into 64-bit. For example, without this patch: 54: R0=inv(id=0,umax_value=800) 54: (bf) r8 = r0 55:

[PATCH bpf-next v3 0/9] bpf: add bpf_get_stack helper

2018-04-20 Thread Yonghong Song
Currently, stackmap and bpf_get_stackid helper are provided for bpf program to get the stack trace. This approach has a limitation though. If two stack traces have the same hash, only one will get stored in the stackmap table regardless of whether BPF_F_REUSE_STACKID is specified or not, so some

[PATCH bpf-next v3 2/9] bpf: add bpf_get_stack helper

2018-04-20 Thread Yonghong Song
Currently, stackmap and bpf_get_stackid helper are provided for bpf program to get the stack trace. This approach has a limitation though. If two stack traces have the same hash, only one will get stored in the stackmap table, so some stack traces are missing from user perspective. This patch

[PATCH bpf-next v3 6/9] samples/bpf: move common-purpose trace functions to selftests

2018-04-20 Thread Yonghong Song
There is no functionality change in this patch. The common-purpose trace functions, including perf_event polling and ksym lookup, are moved from trace_output_user.c and bpf_load.c to selftests/bpf/trace_helpers.c so that these function can be reused later in selftests. Signed-off-by: Yonghong

[PATCH bpf-next v3 9/9] tools/bpf: add a test for bpf_get_stack with tracepoint prog

2018-04-20 Thread Yonghong Song
The test_stacktrace_map and test_stacktrace_build_id are enhanced to call bpf_get_stack in the helper to get the stack trace as well. The stack traces from bpf_get_stack and bpf_get_stackid are compared to ensure that for the same stack as represented as the same hash, their ip addresses or build

[PATCH bpf-next v3 7/9] tools/bpf: add a verifier test case for bpf_get_stack helper and ARSH

2018-04-20 Thread Yonghong Song
The test_verifier already has a few ARSH test cases. This patch adds a new test case which takes advantage of newly improved verifier behavior for bpf_get_stack and ARSH. Signed-off-by: Yonghong Song --- tools/testing/selftests/bpf/test_verifier.c | 45 +

[PATCH bpf-next v3 3/9] bpf/verifier: refine retval R0 state for bpf_get_stack helper

2018-04-20 Thread Yonghong Song
The special property of return values for helpers bpf_get_stack and bpf_probe_read_str are captured in verifier. Both helpers return a negative error code or a length, which is equal to or smaller than the buffer size argument. This additional information in the verifier can avoid the condition

[PATCH bpf-next v3 5/9] tools/bpf: add bpf_get_stack helper to tools headers

2018-04-20 Thread Yonghong Song
Signed-off-by: Yonghong Song --- tools/include/uapi/linux/bpf.h| 19 +-- tools/testing/selftests/bpf/bpf_helpers.h | 3 ++- 2 files changed, 19 insertions(+), 3 deletions(-) diff --git a/tools/include/uapi/linux/bpf.h b/tools/include/uapi/linux/bpf.h

[PATCH bpf-next v3 8/9] tools/bpf: add a test for bpf_get_stack with raw tracepoint prog

2018-04-20 Thread Yonghong Song
The test attached a raw_tracepoint program to sched/sched_switch. It tested to get stack for user space, kernel space and user space with build_id request. It also tested to get user and kernel stack into the same buffer with back-to-back bpf_get_stack helper calls. Whenever the kernel stack is

[PATCH bpf-next v3 1/9] bpf: change prototype for stack_map_get_build_id_offset

2018-04-20 Thread Yonghong Song
This patch didn't incur functionality change. The function prototype got changed so that the same function can be reused later. Signed-off-by: Yonghong Song --- kernel/bpf/stackmap.c | 13 + 1 file changed, 5 insertions(+), 8 deletions(-) diff --git

Re: [pci PATCH v8 2/4] ena: Migrate over to unmanaged SR-IOV support

2018-04-20 Thread Gregory Rose
On 4/20/2018 9:30 AM, Alexander Duyck wrote: Instead of implementing our own version of a SR-IOV configuration stub in the ena driver we can just reuse the existing pci_sriov_configure_simple function. Signed-off-by: Alexander Duyck --- v5: Replaced call to

Re: [pci PATCH v8 4/4] pci-pf-stub: Add PF driver stub for PFs that function only to enable VFs

2018-04-20 Thread Gregory Rose
On 4/20/2018 9:31 AM, Alexander Duyck wrote: Add a new driver called "pci-pf-stub" to act as a "white-list" for PF devices that provide no other functionality other then acting as a means of allocating a set of VFs. For now I only have one example ID provided by Amazon in terms of devices that

Re: [pci PATCH v8 1/4] pci: Add pci_sriov_configure_simple for PFs that don't manage VF resources

2018-04-20 Thread Gregory Rose
On 4/20/2018 9:28 AM, Alexander Duyck wrote: This patch adds a common configuration function called pci_sriov_configure_simple that will allow for managing VFs on devices where the PF is not capable of managing VF resources. Signed-off-by: Alexander Duyck

Re: Q: force netif ON even when there is no real link ?

2018-04-20 Thread Andrew Lunn
> By saying "mac driver", I mean Ethernet driver with fixed phy. The fixed-phy implements the usual PHY API. So the MAC driver just sees a PHY which has a fixed speed, and is up. Andrew

Re: [PATCH net-next] net: phy: mdio-boardinfo: Allow recursive mdiobus_register()

2018-04-20 Thread Andrew Lunn
On Fri, Apr 20, 2018 at 10:34:30AM -0400, David Miller wrote: > From: Andrew Lunn > Date: Thu, 19 Apr 2018 02:00:47 +0200 > > > mdiobus_register will search for any mdiobus board info registered for > > the bus being registered. If found, it will probe devices on the bus. > >

Re: [PATCH RFC net-next 00/11] udp gso

2018-04-20 Thread Willem de Bruijn
>>> Also any plans for HW offload support for this? I vaguely recall that >>> the igb and ixgbe parts had support for something like this in >>> hardware. I would have to double check to see what exactly is >>> supported. >> >> I hadn't given that much thought until the request yesterday to >>

Re: [PATCH] kvmalloc: always use vmalloc if CONFIG_DEBUG_VM

2018-04-20 Thread Mikulas Patocka
On Fri, 20 Apr 2018, Matthew Wilcox wrote: > On Fri, Apr 20, 2018 at 04:54:53PM -0400, Mikulas Patocka wrote: > > On Fri, 20 Apr 2018, Michal Hocko wrote: > > > No way. This is just wrong! First of all, you will explode most likely > > > on many allocations of small sizes. Second,

Re: [PATCH RFC net-next] igb: adjust SYSTIM register using TIMADJ register

2018-04-20 Thread Richard Cochran
On Fri, Apr 20, 2018 at 02:56:36PM -0500, Kshitiz Gupta wrote: > Currently the driver adjusts time by reading the current time and then > modifying it before writing to SYSTIM register. This can introduce > inaccuracies in SYSTIM. With a PREEMPT_RT kernel, spinlocks may be > interrupted, which in

Re: [PATCH] kvmalloc: always use vmalloc if CONFIG_DEBUG_VM

2018-04-20 Thread Matthew Wilcox
On Fri, Apr 20, 2018 at 04:54:53PM -0400, Mikulas Patocka wrote: > On Fri, 20 Apr 2018, Michal Hocko wrote: > > No way. This is just wrong! First of all, you will explode most likely > > on many allocations of small sizes. Second, CONFIG_DEBUG_VM tends to be > > enabled quite often. > > You're an

Re: [PATCH] kvmalloc: always use vmalloc if CONFIG_DEBUG_VM

2018-04-20 Thread Mikulas Patocka
On Fri, 20 Apr 2018, Michal Hocko wrote: > On Fri 20-04-18 06:41:36, Matthew Wilcox wrote: > > On Fri, Apr 20, 2018 at 03:08:52PM +0200, Michal Hocko wrote: > > > > In order to detect these bugs reliably I submit this patch that changes > > > > kvmalloc to always use vmalloc if CONFIG_DEBUG_VM

Re: [PATCH] kvmalloc: always use vmalloc if CONFIG_DEBUG_VM

2018-04-20 Thread Mikulas Patocka
On Fri, 20 Apr 2018, Michal Hocko wrote: > On Thu 19-04-18 12:12:38, Mikulas Patocka wrote: > [...] > > From: Mikulas Patocka > > Subject: [PATCH] kvmalloc: always use vmalloc if CONFIG_DEBUG_VM > > > > The kvmalloc function tries to use kmalloc and falls back to vmalloc

Re: [RFC PATCH ghak32 V2 11/13] audit: add support for containerid to network namespaces

2018-04-20 Thread Richard Guy Briggs
On 2018-04-20 16:22, Paul Moore wrote: > On Fri, Apr 20, 2018 at 4:02 PM, Richard Guy Briggs wrote: > > On 2018-04-18 21:46, Paul Moore wrote: > >> On Fri, Mar 16, 2018 at 5:00 AM, Richard Guy Briggs > >> wrote: > >> > Audit events could happen in a network

Re: [pci PATCH v8 0/4] Add support for unmanaged SR-IOV

2018-04-20 Thread Randy Dunlap
On 04/20/18 13:01, Alexander Duyck wrote: > On Fri, Apr 20, 2018 at 10:23 AM, Randy Dunlap wrote: >> On 04/20/18 09:28, Alexander Duyck wrote: >>> This series is meant to add support for SR-IOV on devices when the VFs are >>> not managed by the kernel. Examples of recent

Re: [PATCH RFC net-next] net: ipvs: Adjust gso_size for IPPROTO_TCP

2018-04-20 Thread Julian Anastasov
Hello, On Thu, 19 Apr 2018, Martin KaFai Lau wrote: > This patch is not a proper fix and mainly serves for discussion purpose. > It is based on net-next which I have been using to debug the issue. > > The change that works around the issue is in ensure_mtu_is_adequate(). > Other

Re: [RFC PATCH ghak32 V2 11/13] audit: add support for containerid to network namespaces

2018-04-20 Thread Paul Moore
On Fri, Apr 20, 2018 at 4:02 PM, Richard Guy Briggs wrote: > On 2018-04-18 21:46, Paul Moore wrote: >> On Fri, Mar 16, 2018 at 5:00 AM, Richard Guy Briggs wrote: >> > Audit events could happen in a network namespace outside of a task >> > context due to packets

Re: [PATCH net] bpf: sockmap remove dead check

2018-04-20 Thread Daniel Borkmann
On 04/20/2018 06:16 PM, Jann Horn wrote: > Remove dead code that bails on `attr->value_size > KMALLOC_MAX_SIZE` - the > previous check already bails on `attr->value_size != 4`. > > Signed-off-by: Jann Horn Applied to bpf tree, thanks Jann!

Re: [PATCH RFC net-next 00/11] udp gso

2018-04-20 Thread Tushar Dave
On 04/20/2018 01:08 PM, Alexander Duyck wrote: On Fri, Apr 20, 2018 at 11:27 AM, Tushar Dave wrote: On 04/18/2018 11:12 AM, Alexander Duyck wrote: On Wed, Apr 18, 2018 at 10:28 AM, David Miller wrote: From: Sowmini Varadhan

Re: [RFC PATCH ghak32 V2 11/13] audit: add support for containerid to network namespaces

2018-04-20 Thread Richard Guy Briggs
On 2018-04-18 21:46, Paul Moore wrote: > On Fri, Mar 16, 2018 at 5:00 AM, Richard Guy Briggs wrote: > > Audit events could happen in a network namespace outside of a task > > context due to packets received from the net that trigger an auditing > > rule prior to being associated

Re: [PATCH RFC net-next 00/11] udp gso

2018-04-20 Thread Alexander Duyck
On Fri, Apr 20, 2018 at 11:27 AM, Tushar Dave wrote: > > > On 04/18/2018 11:12 AM, Alexander Duyck wrote: >> >> On Wed, Apr 18, 2018 at 10:28 AM, David Miller >> wrote: >>> >>> From: Sowmini Varadhan >>> Date: Wed, 18

Re: [pci PATCH v8 0/4] Add support for unmanaged SR-IOV

2018-04-20 Thread Alexander Duyck
On Fri, Apr 20, 2018 at 10:23 AM, Randy Dunlap wrote: > On 04/20/18 09:28, Alexander Duyck wrote: >> This series is meant to add support for SR-IOV on devices when the VFs are >> not managed by the kernel. Examples of recent patches attempting to do this >> include: >>

[PATCH RFC net-next] igb: adjust SYSTIM register using TIMADJ register

2018-04-20 Thread Kshitiz Gupta
Currently the driver adjusts time by reading the current time and then modifying it before writing to SYSTIM register. This can introduce inaccuracies in SYSTIM. With a PREEMPT_RT kernel, spinlocks may be interrupted, which in the existing implementation may lead to increased time between the read

[PATCH net] ibmvnic: Clean actual number of RX or TX pools

2018-04-20 Thread Thomas Falcon
Avoid using value stored in the login response buffer when cleaning TX and RX buffer pools since these could be inconsistent depending on the device state. Instead use the field in the driver's private data that tracks the number of active pools. Signed-off-by: Thomas Falcon

[PATCHv4 net 3/3] net: sched: ife: check on metadata length

2018-04-20 Thread Alexander Aring
This patch checks if sk buffer is available to dererence ife header. If not then NULL will returned to signal an malformed ife packet. This avoids to crashing the kernel from outside. Signed-off-by: Alexander Aring Reviewed-by: Yotam Gigi Acked-by: Jamal

[PATCHv4 net 1/3] net: sched: ife: signal not finding metaid

2018-04-20 Thread Alexander Aring
We need to record stats for received metadata that we dont know how to process. Have find_decode_metaid() return -ENOENT to capture this. Signed-off-by: Alexander Aring Reviewed-by: Yotam Gigi Acked-by: Jamal Hadi Salim ---

[PATCHv4 net 2/3] net: sched: ife: handle malformed tlv length

2018-04-20 Thread Alexander Aring
There is currently no handling to check on a invalid tlv length. This patch adds such handling to avoid killing the kernel with a malformed ife packet. Signed-off-by: Alexander Aring Reviewed-by: Yotam Gigi Acked-by: Jamal Hadi Salim

[PATCHv4 net 0/3] net: sched: ife: malformed ife packet fixes

2018-04-20 Thread Alexander Aring
As promised at netdev 2.2 tc workshop I am working on adding scapy support for tdc testing. It is still work in progress. I will submit the patches to tdc later (they are not in good shape yet). The good news is I have been able to find bugs which normal packet testing would not be able to find.

[PATCH net] strparser: Do not call mod_delayed_work with a timeout of LONG_MAX

2018-04-20 Thread Doron Roberts-Kedes
struct sock's sk_rcvtimeo is initialized to LONG_MAX/MAX_SCHEDULE_TIMEOUT in sock_init_data. Calling mod_delayed_work with a timeout of LONG_MAX causes spurious execution of the work function. timer->expires is set equal to jiffies + LONG_MAX. When timer_base->clk falls behind the current value of

Re: [PATCH bpf-next v3 4/8] bpf: add documentation for eBPF helpers (23-32)

2018-04-20 Thread Quentin Monnet
2018-04-19 13:16 UTC+0200 ~ Daniel Borkmann > On 04/17/2018 04:34 PM, Quentin Monnet wrote: >> Add documentation for eBPF helper functions to bpf.h user header file. >> This documentation can be parsed with the Python script provided in >> another commit of the patch series,

Re: [PATCH net-next 0/5] virtio-net: Add SCTP checksum offload support

2018-04-20 Thread Michael S. Tsirkin
On Fri, Apr 20, 2018 at 02:22:19PM -0300, Marcelo Ricardo Leitner wrote: > On Wed, Apr 18, 2018 at 05:06:46PM +0300, Michael S. Tsirkin wrote: > > On Tue, Apr 17, 2018 at 04:35:18PM -0400, Vlad Yasevich wrote: > > > On 04/02/2018 10:47 AM, Marcelo Ricardo Leitner wrote: > > > > On Mon, Apr 02,

Re: [PATCH RFC net-next 00/11] udp gso

2018-04-20 Thread Tushar Dave
On 04/18/2018 11:12 AM, Alexander Duyck wrote: On Wed, Apr 18, 2018 at 10:28 AM, David Miller wrote: From: Sowmini Varadhan Date: Wed, 18 Apr 2018 08:31:03 -0400 However, I share Sridhar's concerns about the very fundamental change to UDP

Re: [PATCH] PCI: Add PCIe to pcie_print_link_status() messages

2018-04-20 Thread Bjorn Helgaas
On Fri, Apr 13, 2018 at 11:16:38AM -0700, Jakub Kicinski wrote: > Currently the pcie_print_link_status() will print PCIe bandwidth > and link width information but does not mention it is pertaining > to the PCIe. Since this and related functions are used exclusively > by networking drivers today

Re: [PATCH RFC net-next 00/11] udp gso

2018-04-20 Thread Alexander Duyck
On Wed, Apr 18, 2018 at 11:22 AM, Willem de Bruijn wrote: > On Wed, Apr 18, 2018 at 2:12 PM, Alexander Duyck > wrote: >> On Wed, Apr 18, 2018 at 10:28 AM, David Miller wrote: >>> From: Sowmini Varadhan

Re: [pci PATCH v8 0/4] Add support for unmanaged SR-IOV

2018-04-20 Thread Randy Dunlap
On 04/20/18 09:28, Alexander Duyck wrote: > This series is meant to add support for SR-IOV on devices when the VFs are > not managed by the kernel. Examples of recent patches attempting to do this > include: > virto - https://patchwork.kernel.org/patch/10241225/ > pci-stub -

Re: [PATCH net-next 0/5] virtio-net: Add SCTP checksum offload support

2018-04-20 Thread Marcelo Ricardo Leitner
On Wed, Apr 18, 2018 at 05:06:46PM +0300, Michael S. Tsirkin wrote: > On Tue, Apr 17, 2018 at 04:35:18PM -0400, Vlad Yasevich wrote: > > On 04/02/2018 10:47 AM, Marcelo Ricardo Leitner wrote: > > > On Mon, Apr 02, 2018 at 09:40:01AM -0400, Vladislav Yasevich wrote: > > >> Now that we have SCTP

[RFC iproute 2/5] json: make json print_uint take unsigned int

2018-04-20 Thread Stephen Hemminger
It is a source of possible bugs that json print handler print_uint was doing implict conversion to 64 bit than printing with the format specifier which often had only a unsigned format value. Instead introduce wider range of print stubs for unsigned integer types. No color versions of these

[RFC iproute 4/5] tcp_metrics: use print_luint

2018-04-20 Thread Stephen Hemminger
Metrics are long unsigned, so use correct print function. Signed-off-by: Stephen Hemminger --- ip/tcp_metrics.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ip/tcp_metrics.c b/ip/tcp_metrics.c index 72dc980c92a6..3b82a4e1d2f2 100644 ---

[RFC iproute 0/5] print_uint issues

2018-04-20 Thread Stephen Hemminger
There are several issues with implicit conversions in json handling print_uint function which were first seen and patches proposed by Alin Nastac. This is my swipe at them. Final version will be some combination of his patches and some of this. Spotted some more changing print_uint into a

[RFC iproute 5/5] mroute: use print_uint64

2018-04-20 Thread Stephen Hemminger
The values from multicast stats are 64 bit always. Signed-off-by: Stephen Hemminger --- ip/ipmroute.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/ip/ipmroute.c b/ip/ipmroute.c index 59c5b7718e18..eb6b2816324f 100644 ---

[RFC iproute 3/5] flower: use 16 bit format where possible

2018-04-20 Thread Stephen Hemminger
Should use print_hu not print_uint for 16 bit value. Signed-off-by: Stephen Hemminger --- tc/f_flower.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tc/f_flower.c b/tc/f_flower.c index 9d4bfd2f808b..ba8eb66cdd11 100644 --- a/tc/f_flower.c +++

[RFC iproute 1/5] ipneigh: fix missing format specifier

2018-04-20 Thread Stephen Hemminger
Signed-off-by: Stephen Hemminger --- ip/ipneigh.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ip/ipneigh.c b/ip/ipneigh.c index 4748381701e4..bd6e5c5e18ca 100644 --- a/ip/ipneigh.c +++ b/ip/ipneigh.c @@ -204,7 +204,7 @@ static void

Re: [PATCH 0/8] arm: renesas: Change platform dependency to ARCH_RENESAS

2018-04-20 Thread Mark Brown
On Fri, Apr 20, 2018 at 03:28:26PM +0200, Geert Uytterhoeven wrote: > The first 6 patches can be applied independently by subsystem > maintainers. > The last two patches depend on the first 6 patches, and are thus marked > RFC. Would it not make sense to try to apply everything en masse rather

[pci PATCH v8 4/4] pci-pf-stub: Add PF driver stub for PFs that function only to enable VFs

2018-04-20 Thread Alexander Duyck
Add a new driver called "pci-pf-stub" to act as a "white-list" for PF devices that provide no other functionality other then acting as a means of allocating a set of VFs. For now I only have one example ID provided by Amazon in terms of devices that require this functionality. The general idea is

[pci PATCH v8 3/4] nvme: Migrate over to unmanaged SR-IOV support

2018-04-20 Thread Alexander Duyck
Instead of implementing our own version of a SR-IOV configuration stub in the nvme driver we can just reuse the existing pci_sriov_configure_simple function. Reviewed-by: Christoph Hellwig Signed-off-by: Alexander Duyck --- v5: Replaced call to

[pci PATCH v8 2/4] ena: Migrate over to unmanaged SR-IOV support

2018-04-20 Thread Alexander Duyck
Instead of implementing our own version of a SR-IOV configuration stub in the ena driver we can just reuse the existing pci_sriov_configure_simple function. Signed-off-by: Alexander Duyck --- v5: Replaced call to pci_sriov_configure_unmanaged with

[pci PATCH v8 1/4] pci: Add pci_sriov_configure_simple for PFs that don't manage VF resources

2018-04-20 Thread Alexander Duyck
This patch adds a common configuration function called pci_sriov_configure_simple that will allow for managing VFs on devices where the PF is not capable of managing VF resources. Signed-off-by: Alexander Duyck Tested-by: Mark Rustad ---

[pci PATCH v8 0/4] Add support for unmanaged SR-IOV

2018-04-20 Thread Alexander Duyck
This series is meant to add support for SR-IOV on devices when the VFs are not managed by the kernel. Examples of recent patches attempting to do this include: virto - https://patchwork.kernel.org/patch/10241225/ pci-stub - https://patchwork.kernel.org/patch/10109935/ vfio -

Re: [RFC PATCH ghak32 V2 06/13] audit: add support for non-syscall auxiliary records

2018-04-20 Thread Paul Moore
On Thu, Apr 19, 2018 at 9:23 PM, Richard Guy Briggs wrote: > On 2018-04-18 20:39, Paul Moore wrote: >> On Fri, Mar 16, 2018 at 5:00 AM, Richard Guy Briggs wrote: >> > Standalone audit records have the timestamp and serial number generated >> > on the fly and as

[PATCH net] bpf: sockmap remove dead check

2018-04-20 Thread Jann Horn
Remove dead code that bails on `attr->value_size > KMALLOC_MAX_SIZE` - the previous check already bails on `attr->value_size != 4`. Signed-off-by: Jann Horn --- kernel/bpf/sockmap.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/kernel/bpf/sockmap.c

Re: [PATCH net-next 2/2] netns: isolate seqnums to use per-netns locks

2018-04-20 Thread Christian Brauner
On Fri, Apr 20, 2018 at 03:56:28PM +0200, Christian Brauner wrote: > On Wed, Apr 18, 2018 at 11:52:47PM +0200, Christian Brauner wrote: > > On Wed, Apr 18, 2018 at 11:55:52AM -0500, Eric W. Biederman wrote: > > > Christian Brauner writes: > > > > > > > Now that it's

Re: [virtio-dev] [pci PATCH v7 2/5] virtio_pci: Add support for unmanaged SR-IOV on virtio_pci devices

2018-04-20 Thread Michael S. Tsirkin
On Fri, Apr 20, 2018 at 09:08:51AM -0700, Alexander Duyck wrote: > On Fri, Apr 20, 2018 at 8:28 AM, Michael S. Tsirkin wrote: > > On Fri, Apr 20, 2018 at 07:56:14AM -0700, Alexander Duyck wrote: > >> > I think for virtio it should include the feature bit, yes. > >> > Adding

Re: [RFC PATCH ghak32 V2 05/13] audit: add containerid support for ptrace and signals

2018-04-20 Thread Paul Moore
On Thu, Apr 19, 2018 at 9:03 PM, Richard Guy Briggs wrote: > On 2018-04-18 20:32, Paul Moore wrote: >> On Fri, Mar 16, 2018 at 5:00 AM, Richard Guy Briggs wrote: ... >> > /* >> > * audit_log_container_info - report container info >> > - * @tsk: task to be

Re: [RFC PATCH ghak32 V2 10/13] audit: add containerid support for seccomp and anom_abend records

2018-04-20 Thread Paul Moore
On Thu, Apr 19, 2018 at 8:42 PM, Richard Guy Briggs wrote: > On 2018-04-18 21:31, Paul Moore wrote: >> On Fri, Mar 16, 2018 at 5:00 AM, Richard Guy Briggs wrote: >> > Add container ID auxiliary records to secure computing and abnormal end >> > standalone

Re: [virtio-dev] [pci PATCH v7 2/5] virtio_pci: Add support for unmanaged SR-IOV on virtio_pci devices

2018-04-20 Thread Alexander Duyck
On Fri, Apr 20, 2018 at 8:28 AM, Michael S. Tsirkin wrote: > On Fri, Apr 20, 2018 at 07:56:14AM -0700, Alexander Duyck wrote: >> > I think for virtio it should include the feature bit, yes. >> > Adding feature bit is very easy - post a patch to the virtio TC mailing >> > list,

Re: [net-next 1/3] tipc: set default MTU for UDP media

2018-04-20 Thread kbuild test robot
Hi GhantaKrishnamurthy, Thank you for the patch! Yet something to improve: [auto build test ERROR on net-next/master] url: https://github.com/0day-ci/linux/commits/GhantaKrishnamurthy-MohanKrishna/tipc-Confgiuration-of-MTU-for-media-UDP/20180420-224412 config: i386-randconfig-a0-201815

Re: [virtio-dev] Re: [PATCH v7 net-next 2/4] net: Introduce generic failover module

2018-04-20 Thread Michael S. Tsirkin
On Fri, Apr 20, 2018 at 08:56:57AM -0700, Alexander Duyck wrote: > On Fri, Apr 20, 2018 at 8:34 AM, Michael S. Tsirkin wrote: > > On Fri, Apr 20, 2018 at 08:21:00AM -0700, Samudrala, Sridhar wrote: > >> > > + finfo = netdev_priv(failover_dev); > >> > > + > >> > > + primary_dev =

Re: [PATCH v7 net-next 4/4] netvsc: refactor notifier/event handling code to use the failover framework

2018-04-20 Thread Jiri Pirko
Fri, Apr 20, 2018 at 05:28:02PM CEST, step...@networkplumber.org wrote: >On Thu, 19 Apr 2018 18:42:04 -0700 >Sridhar Samudrala wrote: > >> Use the registration/notification framework supported by the generic >> failover infrastructure. >> >> Signed-off-by: Sridhar

Re: [PATCH bpf-next] libbpf: fixed build error for samples/bpf/

2018-04-20 Thread Martin KaFai Lau
On Fri, Apr 20, 2018 at 10:05:16AM +0200, Björn Töpel wrote: > From: Björn Töpel > > Commit 8a138aed4a80 ("bpf: btf: Add BTF support to libbpf") did not > include stdbool.h, so GCC complained when building samples/bpf/. > > In file included from

[PATCH net-next 0/4] mm,tcp: provide mmap_hook to solve lockdep issue

2018-04-20 Thread Eric Dumazet
This patch series provide a new mmap_hook to fs willing to grab a mutex before mm->mmap_sem is taken, to ensure lockdep sanity. This hook allows us to shorten tcp_mmap() execution time (while mmap_sem is held), and improve multi-threading scalability. Eric Dumazet (4): mm: provide a mmap_hook

Re: [virtio-dev] Re: [PATCH v7 net-next 2/4] net: Introduce generic failover module

2018-04-20 Thread Alexander Duyck
On Fri, Apr 20, 2018 at 8:34 AM, Michael S. Tsirkin wrote: > On Fri, Apr 20, 2018 at 08:21:00AM -0700, Samudrala, Sridhar wrote: >> > > + finfo = netdev_priv(failover_dev); >> > > + >> > > + primary_dev = rtnl_dereference(finfo->primary_dev); >> > > + standby_dev =

[PATCH net-next 1/4] mm: provide a mmap_hook infrastructure

2018-04-20 Thread Eric Dumazet
When adding tcp mmap() implementation, I forgot that socket lock had to be taken before current->mm->mmap_sem. syzbot eventually caught the bug. This patch provides a new mmap_hook() method in struct file_operations that might be provided by fs to implement a finer control of whats to be done

[PATCH net-next 2/4] net: implement sock_mmap_hook()

2018-04-20 Thread Eric Dumazet
sock_mmap_hook() is the mmap_hook handler provided for socket_file_ops Following patch will provide tcp_mmap_hook() for TCP protocol. Signed-off-by: Eric Dumazet --- include/linux/net.h | 1 + net/socket.c| 9 + 2 files changed, 10 insertions(+) diff --git

[PATCH net-next 4/4] tcp: mmap: move the skb cleanup to tcp_mmap_hook()

2018-04-20 Thread Eric Dumazet
Freeing all skbs and sending ACK is time consuming. This is currently done while both current->mm->mmap_sem and socket lock are held, in tcp_mmap() Thanks to mmap_hook infrastructure, we can perform the cleanup after current->mm->mmap_sem has been released, thus allowing other threads to perform

[PATCH net-next 3/4] tcp: provide tcp_mmap_hook()

2018-04-20 Thread Eric Dumazet
Many socket operations can copy data between user and kernel space while socket lock is held. This means mm->mmap_sem can be taken after socket lock. When implementing tcp mmap(), I forgot this and syzbot was kind enough to point this to my attention. This patch adds tcp_mmap_hook(), allowing us

Re: [PATCH net-next] tun: do not compute the rxhash, if not needed

2018-04-20 Thread David Miller
From: Paolo Abeni Date: Fri, 20 Apr 2018 13:18:16 +0200 > Currently, the tun driver, in absence of an eBPF steering program, > always compute the rxhash in its rx path, even when such value > is later unused due to additional checks ( > > This changeset moves the all the

Re: [PATCH v1 net-next] lan78xx: Add support to dump lan78xx registers

2018-04-20 Thread David Miller
From: Raghuram Chary J Date: Fri, 20 Apr 2018 11:43:50 +0530 > In order to dump lan78xx family registers using ethtool, add > support at lan78xx driver level. > > Signed-off-by: Raghuram Chary J > --- > v0->v1: >

[PATCH for-rc] uapi: Fix SPDX tags for files referring to the 'OpenIB.org' license

2018-04-20 Thread Jason Gunthorpe
Based on discussion with Kate Stewart this license is not a BSD-2-Clause, but is now formally identified as Linux-OpenIB by SPDX. The key difference between the licenses is in the 'warranty' paragraph. if_infiniband.h refers to the 'OpenIB.org' license, but does not include the text, instead it

[PATCH] hv_netvsc: select needed ucs2_string routine

2018-04-20 Thread Stephen Hemminger
The conversion of rndis friendly name to utf8 uses a standard kernel routine which is optional in config. Therefore build would fail for some configurations. Resolve by selecting needed library. Fixes: 0fe554a46a0f ("hv_netvsc: propogate Hyper-V friendly name into interface alias")

Re: [PATCH v7 net-next 4/4] netvsc: refactor notifier/event handling code to use the failover framework

2018-04-20 Thread David Miller
From: "Michael S. Tsirkin" Date: Fri, 20 Apr 2018 18:43:54 +0300 > On Fri, Apr 20, 2018 at 08:28:02AM -0700, Stephen Hemminger wrote: >> Plus, DPDK is now dependent on existing model. > > DPDK does the kernel bypass thing, doesn't it? Why does the kernel care? +1

Re: [PATCH v7 net-next 4/4] netvsc: refactor notifier/event handling code to use the failover framework

2018-04-20 Thread Samudrala, Sridhar
On 4/20/2018 8:28 AM, Stephen Hemminger wrote: On Thu, 19 Apr 2018 18:42:04 -0700 Sridhar Samudrala wrote: Use the registration/notification framework supported by the generic failover infrastructure. Signed-off-by: Sridhar Samudrala

  1   2   >