Re: [PATCH] net: phy: marvell: clear wol event before setting it

2018-04-25 Thread Bhadram Varka
Hi, On 4/19/2018 5:48 PM, Andrew Lunn wrote: On Thu, Apr 19, 2018 at 04:02:32PM +0800, Jisheng Zhang wrote: From: Jingju Hou If WOL event happened once, the LED[2] interrupt pin will not be cleared unless reading the CSISR register. So clear the WOL event before

Re: [PATCHv2 1/1] IB/rxe: avoid double kfree_skb

2018-04-25 Thread Yanjun Zhu
Add netdev@vger.kernel.org On 2018/4/26 12:41, Zhu Yanjun wrote: When skb is sent, it will pass the following functions in soft roce. rxe_send [rdma_rxe] ip_local_out __ip_local_out ip_output ip_finish_output ip_finish_output2

Re: [RFC bpf] bpf, x64: fix JIT emission for dead code

2018-04-25 Thread Gianluca Borello
On Wed, Apr 25, 2018 at 8:34 AM Daniel Borkmann wrote: > I've applied this fix to bpf tree, thanks Gianluca! Thank you all for the quick review, really appreciated!

Re: pull-request: bpf 2018-04-25

2018-04-25 Thread Daniel Borkmann
On 04/26/2018 05:05 AM, David Miller wrote: > From: Daniel Borkmann > Date: Thu, 26 Apr 2018 00:04:50 +0200 > >> The following pull-request contains BPF updates for your *net* tree. > ... >> Please consider pulling these changes from: >> >>

[PATCH v2] net/mlx4_en: fix potential use-after-free with dma_unmap_page

2018-04-25 Thread Sarah Newman
When swiotlb is in use, calling dma_unmap_page means that the original page mapped with dma_map_page must still be valid as swiotlb will copy data from its internal cache back to the originally requested DMA location. When GRO is enabled, all references to the original frag may be put before

Re: [PATCH bpf-next 13/15] xsk: support for Tx

2018-04-25 Thread Björn Töpel
2018-04-25 21:00 GMT+02:00 Willem de Bruijn : [...] >>> static inline struct xdp_desc *xskq_peek_desc(struct xsk_queue *q, >>> + struct xdp_desc *desc) >>> +{ >>> + struct xdp_rxtx_ring *ring; >>> + >>> + if

Re: [PATCH net-next v2 2/5] bpf: Add IPv6 Segment Routing helpers

2018-04-25 Thread kbuild test robot
Hi Mathieu, Thank you for the patch! Yet something to improve: [auto build test ERROR on net-next/master] url: https://github.com/0day-ci/linux/commits/Mathieu-Xhonneux/ipv6-sr-introduce-seg6local-End-BPF-action/20180426-082209 config: microblaze-mmu_defconfig (attached as .config)

Re: [PATCH net-next] neighbour: support for NTF_EXT_LEARNED flag

2018-04-25 Thread Roopa Prabhu
On Wed, Apr 25, 2018 at 10:20 AM, David Miller wrote: > From: Roopa Prabhu > Date: Tue, 24 Apr 2018 13:49:34 -0700 > >> From: Roopa Prabhu >> >> This patch extends NTF_EXT_LEARNED support to the neighbour system. >>

Re: [PATCH] fault-injection: reorder config entries

2018-04-25 Thread Randy Dunlap
On 04/25/2018 01:02 PM, Mikulas Patocka wrote: > This patch reorders Kconfig entries, so that menuconfig displays proper > indentation. > > Signed-off-by: Mikulas Patocka Acked-by: Randy Dunlap Tested-by: Randy Dunlap

[PATCH net-next] bridge: use hlist_entry_safe

2018-04-25 Thread YueHaibing
Use hlist_entry_safe() instead of open-coding it. Signed-off-by: YueHaibing --- net/bridge/br_forward.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/net/bridge/br_forward.c b/net/bridge/br_forward.c index b4eed11..7a7fd67 100644 ---

Re: pull-request: bpf 2018-04-25

2018-04-25 Thread David Miller
From: Daniel Borkmann Date: Thu, 26 Apr 2018 00:04:50 +0200 > The following pull-request contains BPF updates for your *net* tree. ... > Please consider pulling these changes from: > > git://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf.git Pulled, thanks Daniel. >

Re: [net-next 00/10][pull request] 1GbE Intel Wired LAN Driver Updates 2018-04-25

2018-04-25 Thread David Miller
From: Jeff Kirsher Date: Wed, 25 Apr 2018 11:22:22 -0700 > This series enables some ethtool and tc-flower filters to be offloaded > to igb-based network controllers. This is useful when the system > configuration wants to steer kinds of traffic to a specific hardware

Re: [PATCH v7 net-next 4/4] netvsc: refactor notifier/event handling code to use the failover framework

2018-04-25 Thread Michael S. Tsirkin
On Wed, Apr 25, 2018 at 05:18:31PM -0700, Stephen Hemminger wrote: > On Wed, 25 Apr 2018 15:57:57 -0700 > Siwei Liu wrote: > > > > > > > I think ideally the infrastructure should suppport flexible matching of > > > NICs - netvsc is already reported to be moving to some kind

Re: [PATCH net-next 07/14] bnxt_en: Do not allow VF to read EEPEOM.

2018-04-25 Thread Michael Chan
On Wed, Apr 25, 2018 at 6:38 PM, Andrew Lunn wrote: > On Wed, Apr 25, 2018 at 08:40:50PM -0400, Michael Chan wrote: > > Hi Michael > > You have a typO in the Subject. > Thanks. I will wait a day or so for any additional comments before sending v2 to fix the typo.

Re: [PATCH net-next v8 4/4] netvsc: refactor notifier/event handling code to use the failover framework

2018-04-25 Thread Michael S. Tsirkin
On Wed, Apr 25, 2018 at 05:08:37PM -0700, Stephen Hemminger wrote: > On Wed, 25 Apr 2018 16:59:28 -0700 > Sridhar Samudrala wrote: > > > Use the registration/notification framework supported by the generic > > failover infrastructure. > > > > Signed-off-by: Sridhar

Re: [PATCH v7 net-next 4/4] netvsc: refactor notifier/event handling code to use the failover framework

2018-04-25 Thread Michael S. Tsirkin
On Wed, Apr 25, 2018 at 03:57:57PM -0700, Siwei Liu wrote: > On Wed, Apr 25, 2018 at 3:22 PM, Michael S. Tsirkin wrote: > > On Wed, Apr 25, 2018 at 02:38:57PM -0700, Siwei Liu wrote: > >> On Mon, Apr 23, 2018 at 1:06 PM, Michael S. Tsirkin > >> wrote: > >> > On

Re: [PATCH bpf-next] bpf: Allow bpf_jit_enable = 2 with BPF_JIT_ALWAYS_ON config

2018-04-25 Thread Leo Yan
On Wed, Apr 25, 2018 at 05:37:39PM +0200, Daniel Borkmann wrote: > On 04/25/2018 04:14 PM, Alexei Starovoitov wrote: > > On Wed, Apr 25, 2018 at 05:25:47PM +0800, Leo Yan wrote: > >> > >> If we have concern for security issue, should we remove support for > >> 'bpf_jit_enable = 2' and modify the

[PATCH bpf-next] bpf, doc: Update bpf_jit_enable limitation for CONFIG_BPF_JIT_ALWAYS_ON

2018-04-25 Thread Leo Yan
When CONFIG_BPF_JIT_ALWAYS_ON is enabled, kernel has limitation for bpf_jit_enable, so it has fixed value 1 and we cannot set it to 2 for JIT opcode dumping; this patch is to update the doc for it. Signed-off-by: Leo Yan --- Documentation/networking/filter.txt | 6 ++ 1

Re: [PATCH 06/40] proc: introduce proc_create_single{,_data}

2018-04-25 Thread Finn Thain
On Wed, 25 Apr 2018, Christoph Hellwig wrote: > > -/* > - * /proc/nubus stuff > - */ > - I don't think that the introduction of proc_create_single{,_data} alters the value of that comment. That comment and similar comments in the same file do have a purpose, which is to keep separate the

Re: [PATCH v2] bpf, x86_32: add eBPF JIT compiler for ia32

2018-04-25 Thread Wang YanQing
On Wed, Apr 25, 2018 at 02:11:16AM +0200, Daniel Borkmann wrote: > On 04/19/2018 05:54 PM, Wang YanQing wrote: > > Testing results on i5-5200U: > > > > 1) test_bpf: Summary: 349 PASSED, 0 FAILED, [319/341 JIT'ed] > > 2) test_progs: Summary: 81 PASSED, 2 FAILED. > >test_progs report "libbpf:

Re: [PATCH net-next 07/14] bnxt_en: Do not allow VF to read EEPEOM.

2018-04-25 Thread Andrew Lunn
On Wed, Apr 25, 2018 at 08:40:50PM -0400, Michael Chan wrote: Hi Michael You have a typO in the Subject. Andrew

Re: [PATCH v2 net-next 0/2] tcp: mmap: rework zerocopy receive

2018-04-25 Thread Soheil Hassas Yeganeh
On Wed, Apr 25, 2018 at 5:43 PM, Eric Dumazet wrote: > syzbot reported a lockdep issue caused by tcp mmap() support. > > I implemented Andy Lutomirski nice suggestions to resolve the > issue and increase scalability as well. > > First patch is adding a new setsockopt()

linux-next: manual merge of the bpf-next tree with the bpf tree

2018-04-25 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the bpf-next tree got a conflict in: samples/sockmap/Makefile between commit: 4dfe1bb95235 ("bpf: sockmap sample use clang flag, -target bpf") from the bpf tree and commit: 2e04eb1dd1ca ("bpf: sockmap, remove samples program") from the bpf-next

linux-next: manual merge of the bpf-next tree with the net-next tree

2018-04-25 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the bpf-next tree got a conflict in: tools/testing/selftests/bpf/.gitignore between commit: 0abf854d7cbb ("selftests: bpf: update .gitignore with missing generated files") from the net-next tree and commit: b6fd9cf796e6 ("selftests: bpf: update

[PATCH net-next 06/14] bnxt_en: Display function level rx/tx_discard_pkts via ethtool

2018-04-25 Thread Michael Chan
From: Vasundhara Volam Add counters to display sum of rx/tx_discard_pkts of all rings as function level statistics via ethtool. Signed-off-by: Vasundhara Volam Signed-off-by: Michael Chan ---

[PATCH net-next 09/14] bnxt_en: reduce timeout on initial HWRM calls

2018-04-25 Thread Michael Chan
From: Andy Gospodarek Testing with DIM enabled on older kernels indicated that firmware calls were slower than expected. More detailed analysis indicated that the default 25us delay was higher than necessary. Reducing the time spend in usleep_range() for the first several

[PATCH net-next 07/14] bnxt_en: Do not allow VF to read EEPEOM.

2018-04-25 Thread Michael Chan
Firmware does not allow the operation and would return failure, causing a warning in dmesg. So check for VF and disallow it in the driver. Signed-off-by: Michael Chan --- drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c | 5 + 1 file changed, 5 insertions(+)

[PATCH net-next 11/14] bnxt_en: Reserve rings in bnxt_set_channels() if device is down.

2018-04-25 Thread Michael Chan
The current code does not reserve rings during ethtool -L when the device is down. The rings will be reserved when the device is later opened. Change it to reserve rings during ethtool -L when the device is down. This provides a better guarantee that the device open will be successful when the

[PATCH net-next 01/14] bnxt_en: Add TC to hardware QoS queue mapping logic.

2018-04-25 Thread Michael Chan
The current driver maps MQPRIO traffic classes directly 1:1 to the internal hardware queues (TC0 maps to hardware queue 0, etc). This direct mapping requires the internal hardware queues to be reconfigured from lossless to lossy and vice versa when necessary. This involves reconfiguring internal

[PATCH net-next 05/14] bnxt_en: Simplify ring alloc/free error messages.

2018-04-25 Thread Michael Chan
Replace switch statements printing different messages for every ring type with a common message. Signed-off-by: Michael Chan --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 43 +-- 1 file changed, 6 insertions(+), 37 deletions(-) diff

[PATCH net-next 14/14] bnxt_en: Reserve rings at driver open if none was reserved at probe time.

2018-04-25 Thread Michael Chan
Add logic to reserve default rings at driver open time if none was reserved during probe time. This will happen when the PF driver did not provision minimum rings to the VF, due to more limited resources. Driver open will only succeed if some minimum rings can be reserved. Signed-off-by:

[PATCH net-next 10/14] bnxt_en: add debugfs support for DIM

2018-04-25 Thread Michael Chan
From: Andy Gospodarek This adds debugfs support for bnxt_en with the purpose of allowing users to examine the current DIM profile in use for each receive queue. This was instrumental in debugging issues found with DIM and ensuring that the profiles we expect to use are the

[PATCH net-next 03/14] bnxt_en: Check the lengths of encapsulated firmware responses.

2018-04-25 Thread Michael Chan
Firmware messages that are forwarded from PF to VFs are encapsulated. The size of these encapsulated messages must not exceed the maximum defined message size. Add appropriate checks to avoid oversize messages. Firmware messages may be expanded in future specs and this will provide some

[PATCH net-next 08/14] bnxt_en: Increase RING_IDLE minimum threshold to 50

2018-04-25 Thread Michael Chan
From: Andy Gospodarek This keeps the RING_IDLE flag set in hardware for higher coalesce settings by default and improved latency. Signed-off-by: Andy Gospodarek Signed-off-by: Michael Chan ---

[PATCH net-next 00/14] bnxt_en: Net-next updates.

2018-04-25 Thread Michael Chan
This series has 3 main features. The first is to add mqprio TC to hardware queue mapping to avoid reprogramming hardware CoS queue watermarks during run-time. The second is DIM improvements from Andy Gospo. The third is some improvements to VF resource allocations when supporting large numbers

[PATCH net-next 13/14] bnxt_en: Reserve RSS and L2 contexts for VF.

2018-04-25 Thread Michael Chan
For completeness and correctness, the VF driver needs to reserve these RSS and L2 contexts. Signed-off-by: Michael Chan --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 4 drivers/net/ethernet/broadcom/bnxt/bnxt_sriov.c | 10 +-

[PATCH net-next 02/14] bnxt_en: Remap TC to hardware queues when configuring PFC.

2018-04-25 Thread Michael Chan
Initially, the MQPRIO TCs are mapped 1:1 directly to the hardware queues. Some of these hardware queues are configured to be lossless. When PFC is enabled on one of more TCs, we now need to remap the TCs that have PFC enabled to the lossless hardware queues. After remapping, we need to close and

[PATCH net-next 12/14] bnxt_en: Don't reserve rings on VF when min rings were not provisioned by PF.

2018-04-25 Thread Michael Chan
When rings are more limited and the PF has not provisioned minimum guaranteed rings to the VF, do not reserve rings during driver probe. Wait till device open before reserving rings when they will be used. Device open will succeed if some minimum rings can be successfully reserved and allocated.

[PATCH net-next 04/14] bnxt_en: Do not set firmware time from VF driver on older firmware.

2018-04-25 Thread Michael Chan
Older firmware will reject this call and cause an error message to be printed by the VF driver. Signed-off-by: Michael Chan --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

Re: [PATCH stable v4.4+] r8152: add Linksys USB3GIGV1 id

2018-04-25 Thread Grant Grundler
On Wed, Apr 25, 2018 at 2:54 AM, Krzysztof Kozlowski wrote: > commit 90841047a01b452cc8c3f9b990698b264143334a upstream > > This linksys dongle by default comes up in cdc_ether mode. > This patch allows r8152 to claim the device: >Bus 002 Device 002: ID 13b1:0041 Linksys > >

Re: [PATCH v7 net-next 4/4] netvsc: refactor notifier/event handling code to use the failover framework

2018-04-25 Thread Stephen Hemminger
On Wed, 25 Apr 2018 15:57:57 -0700 Siwei Liu wrote: > > > > I think ideally the infrastructure should suppport flexible matching of > > NICs - netvsc is already reported to be moving to some kind of serial > > address. > > > As Stephen said, Hyper-V supports the serial

Re: [PATCH net-next v8 4/4] netvsc: refactor notifier/event handling code to use the failover framework

2018-04-25 Thread Stephen Hemminger
On Wed, 25 Apr 2018 16:59:28 -0700 Sridhar Samudrala wrote: > Use the registration/notification framework supported by the generic > failover infrastructure. > > Signed-off-by: Sridhar Samudrala NAK unless you prove this works on

[PATCH net-next 2/2] liquidio: add support for ndo_get_stats64 instead of ndo_get_stats

2018-04-25 Thread Felix Manlunas
From: Pradeep Nalla Support ndo_get_stats64 instead of ndo_get_stats. Also add stats for multicast and broadcast packets. Signed-off-by: Pradeep Nalla Acked-by: Raghu Vatsavayi Signed-off-by: Felix Manlunas

[PATCH net-next 1/2] liquidio: move a couple of functions to lio_core.c

2018-04-25 Thread Felix Manlunas
From: Pradeep Nalla To support the next patch in this series which has code that calls octnet_get_link_stats from two different .c files, move that function (and its dependency octnet_nic_stats_callback) to lio_core.c. Remove octnet_get_link_stats's static declaration

[PATCH net-next 0/2] liquidio: add support for ndo_get_stats64

2018-04-25 Thread Felix Manlunas
From: Pradeep Nalla Support ndo_get_stats64 instead of ndo_get_stats. Also add stats for multicast and broadcast packets. Pradeep Nalla (2): liquidio: move a couple of functions to lio_core.c liquidio: add support for ndo_get_stats64 instead of ndo_get_stats

[PATCH net-next v8 2/4] net: Introduce generic failover module

2018-04-25 Thread Sridhar Samudrala
This provides a generic interface for paravirtual drivers to listen for netdev register/unregister/link change events from pci ethernet devices with the same MAC and takeover their datapath. The notifier and event handling code is based on the existing netvsc implementation. It exposes 2 sets of

[PATCH net-next v8 4/4] netvsc: refactor notifier/event handling code to use the failover framework

2018-04-25 Thread Sridhar Samudrala
Use the registration/notification framework supported by the generic failover infrastructure. Signed-off-by: Sridhar Samudrala --- drivers/net/hyperv/Kconfig | 1 + drivers/net/hyperv/hyperv_net.h | 2 + drivers/net/hyperv/netvsc_drv.c | 134

[PATCH net-next v8 1/4] virtio_net: Introduce VIRTIO_NET_F_STANDBY feature bit

2018-04-25 Thread Sridhar Samudrala
This feature bit can be used by hypervisor to indicate virtio_net device to act as a standby for another device with the same MAC address. VIRTIO_NET_F_STANDBY is defined as bit 62 as it is a device feature bit. Signed-off-by: Sridhar Samudrala ---

[PATCH net-next v8 0/4] Enable virtio_net to act as a standby for a passthru device

2018-04-25 Thread Sridhar Samudrala
This is another update based on feedback from MST and Stephen on the last patchset. Hopefully this series can be integrated and any further enhancements can be made on top of this patchset. v8: - Made the failover managment routines more robust by updating the feature bits/other fields in the

[PATCH net-next v8 3/4] virtio_net: Extend virtio to use VF datapath when available

2018-04-25 Thread Sridhar Samudrala
This patch enables virtio_net to switch over to a VF datapath when a VF netdev is present with the same MAC address. It allows live migration of a VM with a direct attached VF without the need to setup a bond/team between a VF and virtio net device in the guest. The hypervisor needs to enable

Re: [RFC bpf-next 8/9] bpf: Provide helper to do lookups in kernel FIB table

2018-04-25 Thread David Ahern
On 4/25/18 1:55 PM, Daniel Borkmann wrote: >> @@ -3861,6 +4090,8 @@ sk_filter_func_proto(enum bpf_func_id func_id, const >> struct bpf_prog *prog) >> return _get_socket_cookie_proto; >> case BPF_FUNC_get_socket_uid: >> return _get_socket_uid_proto; >> +case

[PATCH net] net: systemport: Correclty disambiguate driver instances

2018-04-25 Thread Florian Fainelli
While adding the DSA notifier, we will be sending DSA notifications with info->master that is going to point to a particular net_device instance. Our logic in bcm_sysport_map_queues() correctly disambiguates net_device instances that are not covered by our own driver, but it will not make sure

Re: [dm-devel] [PATCH v5] fault-injection: introduce kvmalloc fallback options

2018-04-25 Thread James Bottomley
On Wed, 2018-04-25 at 19:00 -0400, Mikulas Patocka wrote: > > On Wed, 25 Apr 2018, James Bottomley wrote: > > > > > Do we really need the new config option?  This could just be > > > > manually  tunable via fault injection IIUC. > > >  > > > We do, because we want to enable it in RHEL and Fedora

Re: [dm-devel] [PATCH v5] fault-injection: introduce kvmalloc fallback options

2018-04-25 Thread Mikulas Patocka
On Wed, 25 Apr 2018, James Bottomley wrote: > > > Do we really need the new config option?  This could just be > > > manually  tunable via fault injection IIUC. > > > > We do, because we want to enable it in RHEL and Fedora debugging > > kernels, so that it will be tested by the users. > > >

Re: [PATCH v7 net-next 4/4] netvsc: refactor notifier/event handling code to use the failover framework

2018-04-25 Thread Siwei Liu
On Wed, Apr 25, 2018 at 3:22 PM, Michael S. Tsirkin wrote: > On Wed, Apr 25, 2018 at 02:38:57PM -0700, Siwei Liu wrote: >> On Mon, Apr 23, 2018 at 1:06 PM, Michael S. Tsirkin wrote: >> > On Mon, Apr 23, 2018 at 12:44:39PM -0700, Siwei Liu wrote: >> >> On Mon,

Re: [dm-devel] [PATCH v5] fault-injection: introduce kvmalloc fallback options

2018-04-25 Thread Mikulas Patocka
On Wed, 25 Apr 2018, David Rientjes wrote: > On Wed, 25 Apr 2018, Mikulas Patocka wrote: > > > You need to enable it on boot. Enabling it when the kernel starts to > > execute userspace code is already too late (because you would miss > > kvmalloc calls in the kernel boot path). > > Is your

Re: [dm-devel] [PATCH v5] fault-injection: introduce kvmalloc fallback options

2018-04-25 Thread David Rientjes
On Wed, 25 Apr 2018, Mikulas Patocka wrote: > You need to enable it on boot. Enabling it when the kernel starts to > execute userspace code is already too late (because you would miss > kvmalloc calls in the kernel boot path). > Is your motivation that since kvmalloc() never falls back to

Re: [PATCH net-next 3/3] net: phy: Enable C45 PHYs with vendor specific address space

2018-04-25 Thread kbuild test robot
Hi Vicentiu, Thank you for the patch! Yet something to improve: [auto build test ERROR on net-next/master] url: https://github.com/0day-ci/linux/commits/Vicentiu-Galanopulo/net-phy-Enable-C45-vendor-specific-MDIO-register-addr-space/20180418-014927 config: x86_64-randconfig-b0-04260315

Re: [dm-devel] [PATCH v5] fault-injection: introduce kvmalloc fallback options

2018-04-25 Thread Mikulas Patocka
On Wed, 25 Apr 2018, James Bottomley wrote: > On Wed, 2018-04-25 at 17:22 -0400, Mikulas Patocka wrote: > > > > On Wed, 25 Apr 2018, David Rientjes wrote: > > > > > > Do we really need the new config option?  This could just be > > > manually  tunable via fault injection IIUC. > > > > We do,

Re: [PATCH v7 net-next 4/4] netvsc: refactor notifier/event handling code to use the failover framework

2018-04-25 Thread Michael S. Tsirkin
On Wed, Apr 25, 2018 at 02:38:57PM -0700, Siwei Liu wrote: > On Mon, Apr 23, 2018 at 1:06 PM, Michael S. Tsirkin wrote: > > On Mon, Apr 23, 2018 at 12:44:39PM -0700, Siwei Liu wrote: > >> On Mon, Apr 23, 2018 at 10:56 AM, Michael S. Tsirkin > >> wrote: > >> >

Re: [dm-devel] [PATCH v5] fault-injection: introduce kvmalloc fallback options

2018-04-25 Thread James Bottomley
On Wed, 2018-04-25 at 17:22 -0400, Mikulas Patocka wrote: > > On Wed, 25 Apr 2018, David Rientjes wrote: > > > On Wed, 25 Apr 2018, Mikulas Patocka wrote: > > > > > From: Mikulas Patocka > > > Subject: [PATCH] fault-injection: introduce kvmalloc fallback > > > options > >

[bpf PATCH] bpf: fix uninitialized variable in bpf tools

2018-04-25 Thread John Fastabend
Here the variable cont is used as the saved_pointer for a call to strtok_r(). It is safe to use the value uninitialized in this context however and the later reference is only ever used if the strtok_r is successful. But, 'gcc-5' at least doesn't have all this knowledge so initialize cont to NULL.

pull-request: bpf 2018-04-25

2018-04-25 Thread Daniel Borkmann
Hi David, The following pull-request contains BPF updates for your *net* tree. The main changes are: 1) Fix to clear the percpu metadata_dst that could otherwise carry stale ip_tunnel_info, from William. 2) Fix that reduces the number of passes in x64 JIT with regards to dead code

Loan Offer

2018-04-25 Thread Coleman Krosberg
Thank you for your time, We are looking for clients in your area of residents with good business or project that requires financing to execute, or who wants a loan to do business, we do give loans with low interest. Please get back to me if you are interested in this or you know anybody who

Re: [PATCH net-next v2 2/2] openvswitch: Support conntrack zone limit

2018-04-25 Thread Yi-Hung Wei
>> +#ifIS_ENABLED(CONFIG_NETFILTER_CONNCOUNT) >> +#define OVS_CT_LIMIT_UNLIMITED 0 >> +#define OVS_CT_LIMIT_DEFAULT OVS_CT_LIMIT_UNLIMITED >> +#define CT_LIMIT_HASH_BUCKETS 512 >> + > Can you use static key when the limit is not set. > This would avoid overhead in datapath when these limits

[PATCH v2 net-next 2/2] selftests: net: tcp_mmap must use TCP_ZEROCOPY_RECEIVE

2018-04-25 Thread Eric Dumazet
After prior kernel change, mmap() on TCP socket only reserves VMA. We have to use setsockopt(fd, IPPROTO_TCP, TCP_ZEROCOPY_RECEIVE, ...) to perform the transfert of pages from skbs in TCP receive queue into such VMA. struct tcp_zerocopy_receive { __u64 address; /* in: address of

[PATCH v2 net-next 1/2] tcp: add TCP_ZEROCOPY_RECEIVE support for zerocopy receive

2018-04-25 Thread Eric Dumazet
When adding tcp mmap() implementation, I forgot that socket lock had to be taken before current->mm->mmap_sem. syzbot eventually caught the bug. Since we can not lock the socket in tcp mmap() handler we have to split the operation in two phases. 1) mmap() on a tcp socket simply reserves VMA

[PATCH v2 net-next 0/2] tcp: mmap: rework zerocopy receive

2018-04-25 Thread Eric Dumazet
syzbot reported a lockdep issue caused by tcp mmap() support. I implemented Andy Lutomirski nice suggestions to resolve the issue and increase scalability as well. First patch is adding a new setsockopt() operation and changes mmap() behavior. Second patch changes tcp_mmap reference program.

Re: [bpf PATCH v2] bpf: fix for lex/yacc build error with gcc-5

2018-04-25 Thread Daniel Borkmann
On 04/25/2018 11:22 PM, John Fastabend wrote: > Fix build error found with Ubuntu shipped gcc-5 > > ~/git/bpf/tools/bpf$ make all > > Auto-detecting system features: > ...libbfd: [ OFF ] > ...disassembler-four-args: [ OFF ] > > CC bpf_jit_disasm.o >

Re: [PATCH][net-next] net: ip tos cgroup

2018-04-25 Thread kbuild test robot
Hi Li, Thank you for the patch! Yet something to improve: [auto build test ERROR on net/master] [also build test ERROR on v4.17-rc2 next-20180424] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Re: [PATCH v7 net-next 4/4] netvsc: refactor notifier/event handling code to use the failover framework

2018-04-25 Thread Siwei Liu
On Mon, Apr 23, 2018 at 1:06 PM, Michael S. Tsirkin wrote: > On Mon, Apr 23, 2018 at 12:44:39PM -0700, Siwei Liu wrote: >> On Mon, Apr 23, 2018 at 10:56 AM, Michael S. Tsirkin wrote: >> > On Mon, Apr 23, 2018 at 10:44:40AM -0700, Stephen Hemminger wrote: >> >>

[PATCH v2] selftests: net: add in_netns.sh TEST_GEN_PROGS_EXTENDED

2018-04-25 Thread Anders Roxell
Script in_netns.sh is a utility function and not its own test so it shouldn't be part of the TEST_PROGS. The in_netns.sh get used by run_afpackettests. To install in_netns.sh without being added to the main run_kselftest.sh script use the TEST_GEN_PROGS_EXTENDED variable. Fixes: 5ff9c1a3dd92

Re: simplify procfs code for seq_file instances

2018-04-25 Thread Alexey Dobriyan
On Tue, Apr 24, 2018 at 06:06:53PM +0200, Christoph Hellwig wrote: > On Tue, Apr 24, 2018 at 08:19:16AM -0700, Andrew Morton wrote: > > > > I want to ask if it is time to start using poorman function overloading > > > > with _b_c_e(). There are millions of allocation functions for example, > > > >

[bpf PATCH v2] bpf: fix for lex/yacc build error with gcc-5

2018-04-25 Thread John Fastabend
Fix build error found with Ubuntu shipped gcc-5 ~/git/bpf/tools/bpf$ make all Auto-detecting system features: ...libbfd: [ OFF ] ...disassembler-four-args: [ OFF ] CC bpf_jit_disasm.o LINK bpf_jit_disasm CC bpf_dbg.o

Re: [PATCH v5] fault-injection: introduce kvmalloc fallback options

2018-04-25 Thread Mikulas Patocka
On Wed, 25 Apr 2018, David Rientjes wrote: > On Wed, 25 Apr 2018, Mikulas Patocka wrote: > > > From: Mikulas Patocka > > Subject: [PATCH] fault-injection: introduce kvmalloc fallback options > > > > This patch introduces a fault-injection option "kvmalloc_fallback". This

Re: [PATCH v5] fault-injection: introduce kvmalloc fallback options

2018-04-25 Thread David Rientjes
On Wed, 25 Apr 2018, Mikulas Patocka wrote: > From: Mikulas Patocka > Subject: [PATCH] fault-injection: introduce kvmalloc fallback options > > This patch introduces a fault-injection option "kvmalloc_fallback". This > option makes kvmalloc randomly fall back to vmalloc. >

Re: [PATCH 3/3] tools bpftool: Display license GPL compatible in prog show/list

2018-04-25 Thread Daniel Borkmann
On 04/25/2018 11:03 PM, Jakub Kicinski wrote: > On Wed, 25 Apr 2018 19:41:08 +0200, Jiri Olsa wrote: >> @@ -295,6 +297,7 @@ static void print_prog_plain(struct bpf_prog_info *info, >> int fd) >> printf("tag "); >> fprint_hex(stdout, info->tag, BPF_TAG_SIZE, ""); >>

Re: [PATCH v5] fault-injection: introduce kvmalloc fallback options

2018-04-25 Thread Randy Dunlap
On 04/25/2018 01:57 PM, Mikulas Patocka wrote: > > > On Wed, 25 Apr 2018, Randy Dunlap wrote: > >> On 04/25/2018 01:02 PM, Mikulas Patocka wrote: >>> >>> >>> From: Mikulas Patocka >>> Subject: [PATCH v4] fault-injection: introduce kvmalloc fallback options >>> >>> This

Re: [PATCH 3/3] tools bpftool: Display license GPL compatible in prog show/list

2018-04-25 Thread Jakub Kicinski
On Wed, 25 Apr 2018 19:41:08 +0200, Jiri Olsa wrote: > @@ -295,6 +297,7 @@ static void print_prog_plain(struct bpf_prog_info *info, > int fd) > printf("tag "); > fprint_hex(stdout, info->tag, BPF_TAG_SIZE, ""); > print_dev_plain(info->ifindex, info->netns_dev, info->netns_ino);

Re: [PATCH net-next 02/10] udp: add gso

2018-04-25 Thread Alexander Duyck
On Wed, Apr 25, 2018 at 1:51 PM, Willem de Bruijn wrote: >> It might be nice if you could break this into two patches. One for >> actually doing the GSO in software, and another enabling the stack to >> request it. > > Okay. > >>> diff --git

Business Proposal,

2018-04-25 Thread Mrs Zeliha Faruk
Hello Dear Greetings to you, please I have a very important business proposal for our mutual benefit, please let me know if you are interested. Best Regards, Miss. Zeliha ömer Faruk Caddesi Kristal Kule Binasi No:215

[PATCH v5] fault-injection: introduce kvmalloc fallback options

2018-04-25 Thread Mikulas Patocka
On Wed, 25 Apr 2018, Randy Dunlap wrote: > On 04/25/2018 01:02 PM, Mikulas Patocka wrote: > > > > > > From: Mikulas Patocka > > Subject: [PATCH v4] fault-injection: introduce kvmalloc fallback options > > > > This patch introduces a fault-injection option

Re: [PATCH net-next 02/10] udp: add gso

2018-04-25 Thread David Miller
From: Willem de Bruijn Date: Wed, 25 Apr 2018 16:51:41 -0400 > I have been itching to rename the UFO flag, though I then find > SKB_GSO_UFO easier to differentiate from SKB_GSO_UDP > than SKB_GFO_UDP. > > But, the uapi headers will continue to have >

Re: [PATCH net-next 02/10] udp: add gso

2018-04-25 Thread Willem de Bruijn
> It might be nice if you could break this into two patches. One for > actually doing the GSO in software, and another enabling the stack to > request it. Okay. >> diff --git a/include/linux/skbuff.h b/include/linux/skbuff.h >> index d274059529eb..a4a5c0c5cba8 100644 >> ---

Re: [PATCH RFC 2/9] veth: Add driver XDP

2018-04-25 Thread Jesper Dangaard Brouer
On Tue, 24 Apr 2018 23:39:16 +0900 Toshiaki Makita wrote: > This is basic implementation of veth driver XDP. > > Incoming packets are sent from the peer veth device in the form of skb, > so this is generally doing the same thing as generic XDP. I'm unsure that

Re: [PATCH net-next 02/10] udp: add gso

2018-04-25 Thread Alexander Duyck
On Wed, Apr 25, 2018 at 11:55 AM, Willem de Bruijn wrote: > From: Willem de Bruijn > > Implement generic segmentation offload for udp datagrams. Callers can > concatenate and send at once the payload of multiple datagrams with > the same

Re: [PATCH RFC 6/9] veth: Add ndo_xdp_xmit

2018-04-25 Thread Jesper Dangaard Brouer
On Tue, 24 Apr 2018 23:39:20 +0900 Toshiaki Makita wrote: > +static int veth_xdp_xmit(struct net_device *dev, struct xdp_frame *frame) > +{ > + struct veth_priv *rcv_priv, *priv = netdev_priv(dev); > + int headroom = frame->data - (void *)frame; > + struct

Re: [PATCH v4] fault-injection: introduce kvmalloc fallback options

2018-04-25 Thread Randy Dunlap
On 04/25/2018 01:02 PM, Mikulas Patocka wrote: > > > From: Mikulas Patocka > Subject: [PATCH v4] fault-injection: introduce kvmalloc fallback options > > This patch introduces a fault-injection option "kvmalloc_fallback". This > option makes kvmalloc randomly fall back to

[PATCH v4] fault-injection: introduce kvmalloc fallback options

2018-04-25 Thread Mikulas Patocka
On Tue, 24 Apr 2018, Michal Hocko wrote: > > > Wouldn't it be equally trivial to simply enable the fault injection? You > > > would get additional failure paths testing as a bonus. > > > > The RHEL and Fedora debugging kernels are compiled with fault injection. > > But the fault-injection

Re: [PATCH bpf-next] bpf: clear the ip_tunnel_info.

2018-04-25 Thread William Tu
On Wed, Apr 25, 2018 at 12:54 AM, Daniel Borkmann wrote: > On 04/25/2018 08:46 AM, William Tu wrote: >> The percpu metadata_dst might carry the stale ip_tunnel_info >> and cause incorrect behavior. When mixing tests using ipv4/ipv6 >> bpf vxlan and geneve tunnel, the ipv6

[PATCH] fault-injection: reorder config entries

2018-04-25 Thread Mikulas Patocka
This patch reorders Kconfig entries, so that menuconfig displays proper indentation. Signed-off-by: Mikulas Patocka --- lib/Kconfig.debug | 36 ++-- 1 file changed, 18 insertions(+), 18 deletions(-) Index: linux-2.6/lib/Kconfig.debug

RE: e1000e I219 timestamping oops related to TSYNCRXCTL read

2018-04-25 Thread Keller, Jacob E
Hi Benjamin, > -Original Message- > From: netdev-ow...@vger.kernel.org [mailto:netdev-ow...@vger.kernel.org] > On Behalf Of Benjamin Poirier > Sent: Tuesday, April 24, 2018 11:53 PM > To: Allan, Bruce W ; Yanir Lubetkin > ; Keller, Jacob

Re: [RFC bpf-next 8/9] bpf: Provide helper to do lookups in kernel FIB table

2018-04-25 Thread Daniel Borkmann
On 04/25/2018 08:34 PM, David Ahern wrote: > Provide a helper for doing a FIB and neighbor lookup in the kernel > tables from an XDP program. The helper provides a fastpath for forwarding > packets. If the packet is a local delivery or for any reason is not a > simple lookup and forward, the

[PATCH bpf-next v7 08/10] tools/bpf: add a verifier test case for bpf_get_stack helper and ARSH

2018-04-25 Thread Yonghong Song
The test_verifier already has a few ARSH test cases. This patch adds a new test case which takes advantage of newly improved verifier behavior for bpf_get_stack and ARSH. Signed-off-by: Yonghong Song --- tools/testing/selftests/bpf/test_verifier.c | 45 +

[PATCH bpf-next v7 01/10] bpf: change prototype for stack_map_get_build_id_offset

2018-04-25 Thread Yonghong Song
This patch didn't incur functionality change. The function prototype got changed so that the same function can be reused later. Signed-off-by: Yonghong Song --- kernel/bpf/stackmap.c | 13 + 1 file changed, 5 insertions(+), 8 deletions(-) diff --git

[PATCH bpf-next v7 06/10] tools/bpf: add bpf_get_stack helper to tools headers

2018-04-25 Thread Yonghong Song
The tools header file bpf.h is synced with kernel uapi bpf.h. The new helper is also added to bpf_helpers.h. Signed-off-by: Yonghong Song --- tools/include/uapi/linux/bpf.h| 19 +-- tools/testing/selftests/bpf/bpf_helpers.h | 2 ++ 2 files changed, 19

[PATCH bpf-next v7 09/10] tools/bpf: add a test for bpf_get_stack with raw tracepoint prog

2018-04-25 Thread Yonghong Song
The test attached a raw_tracepoint program to sched/sched_switch. It tested to get stack for user space, kernel space and user space with build_id request. It also tested to get user and kernel stack into the same buffer with back-to-back bpf_get_stack helper calls. Whenever the kernel stack is

[PATCH bpf-next v7 07/10] samples/bpf: move common-purpose trace functions to selftests

2018-04-25 Thread Yonghong Song
There is no functionality change in this patch. The common-purpose trace functions, including perf_event polling and ksym lookup, are moved from trace_output_user.c and bpf_load.c to selftests/bpf/trace_helpers.c so that these function can be reused later in selftests. Acked-by: Alexei

[PATCH bpf-next v7 10/10] tools/bpf: add a test for bpf_get_stack with tracepoint prog

2018-04-25 Thread Yonghong Song
The test_stacktrace_map and test_stacktrace_build_id are enhanced to call bpf_get_stack in the helper to get the stack trace as well. The stack traces from bpf_get_stack and bpf_get_stackid are compared to ensure that for the same stack as represented as the same hash, their ip addresses or build

[PATCH bpf-next v7 00/10] bpf: add bpf_get_stack helper

2018-04-25 Thread Yonghong Song
Currently, stackmap and bpf_get_stackid helper are provided for bpf program to get the stack trace. This approach has a limitation though. If two stack traces have the same hash, only one will get stored in the stackmap table regardless of whether BPF_F_REUSE_STACKID is specified or not, so some

  1   2   3   4   5   >