Re: [PATCH net-next v2] net: core: rework basic flow dissection helper

2018-05-04 Thread kbuild test robot
Hi Paolo, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/Paolo-Abeni/net-core-rework-basic-flow-dissection-helper/20180505-090417 reproduce: # apt-get install sparse make

Re: [PATCH iproute2] rdma: fix header files

2018-05-04 Thread Stephen Hemminger
On Fri, 4 May 2018 16:13:07 -0600 David Ahern wrote: > On 5/4/18 3:56 PM, Stephen Hemminger wrote: > > All user api headers in iproute2 should be in include/uapi > > so that script can be used to put correct sanitized kernel headers > > there. And the header files for rdma

Re: [PATCH v2 net-next 1/4] umh: introduce fork_usermode_blob() helper

2018-05-04 Thread Jann Horn
On Thu, May 3, 2018 at 12:36 AM, Alexei Starovoitov wrote: > Introduce helper: > int fork_usermode_blob(void *data, size_t len, struct umh_info *info); > struct umh_info { >struct file *pipe_to_umh; >struct file *pipe_from_umh; >pid_t pid; > }; > > that

[PATCH] net/9p: correct the variable name in v9fs_get_trans_by_name() comment

2018-05-04 Thread Sun Lianwen
The v9fs_get_trans_by_name(char *s) variable name is not "name" but "s". Signed-off-by: Sun Lianwen --- net/9p/mod.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/9p/mod.c b/net/9p/mod.c index 6ab36aea7727..eb9777f05755 100644 ---

Re: [v2 PATCH 1/1] tg3: fix meaningless hw_stats reading after tg3_halt memset 0 hw_stats

2018-05-04 Thread Zumeng Chen
On 05/03/2018 01:04 PM, Michael Chan wrote: On Wed, May 2, 2018 at 5:30 PM, Zumeng Chen wrote: On 2018年05月03日 01:32, Michael Chan wrote: On Wed, May 2, 2018 at 3:27 AM, Zumeng Chen wrote: On 2018年05月02日 13:12, Michael Chan wrote: On Tue, May 1,

Re: [PATCH V3] net/netlink: make sure the headers line up actual value output

2018-05-04 Thread Bo YU
Hi, On Fri, May 04, 2018 at 01:02:23PM -0400, David Miller wrote: From: YU Bo Date: Thu, 3 May 2018 23:09:23 -0400 Making sure the headers line up properly with the actual value output of the command `cat /proc/net/netlink` Before the patch: sk Eth Pid Groups Rmem Wmem

Re: [PATCH v2 net-next 1/4] umh: introduce fork_usermode_blob() helper

2018-05-04 Thread Alexei Starovoitov
On Fri, May 04, 2018 at 07:56:43PM +, Luis R. Rodriguez wrote: > What a mighty short list of reviewers. Adding some more. My review below. > I'd appreciate a Cc on future versions of these patches. sure. > On Wed, May 02, 2018 at 09:36:01PM -0700, Alexei Starovoitov wrote: > > Introduce

Re: [PATCH v2 net-next] net: stmmac: Add support for U32 TC filter using Flexible RX Parser

2018-05-04 Thread Jakub Kicinski
On Fri, 4 May 2018 10:01:38 +0100, Jose Abreu wrote: > This adds support for U32 filter by using an HW only feature called > Flexible RX Parser. This allow us to match any given packet field with a > pattern and accept/reject or even route the packet to a specific DMA > channel. > > Right now we

[PATCH 24/24] selftests: net: return Kselftest Skip code for skipped tests

2018-05-04 Thread Shuah Khan (Samsung OSG)
When net test is skipped because of unmet dependencies and/or unsupported configuration, it returns 0 which is treated as a pass by the Kselftest framework. This leads to false positive result even when the test could not be run. Change it to return kselftest skip code when a test gets skipped to

[PATCH net-next] vlan: correct the file path in vlan_dev_change_flags() comment

2018-05-04 Thread Sun Lianwen
The vlan_flags enum is defined in include/uapi/linux/if_vlan.h file. not in include/linux/if_vlan.h file. Signed-off-by: Sun Lianwen --- net/8021q/vlan_dev.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/net/8021q/vlan_dev.c

Re: [PATCH v2 net-next 2/4] net: add skeleton of bpfilter kernel module

2018-05-04 Thread Alexei Starovoitov
On Thu, May 03, 2018 at 03:23:55PM +0100, Edward Cree wrote: > On 03/05/18 05:36, Alexei Starovoitov wrote: > > bpfilter.ko consists of bpfilter_kern.c (normal kernel module code) > > and user mode helper code that is embedded into bpfilter.ko > > > > The steps to build bpfilter.ko are the

Re: [PATCH iproute2-next] bpf: don't offload perf array maps

2018-05-04 Thread Daniel Borkmann
On 05/05/2018 02:37 AM, Jakub Kicinski wrote: > Perf arrays are handled specially by the kernel, don't request > offload even when used by an offloaded program. > > Signed-off-by: Jakub Kicinski > Reviewed-by: Quentin Monnet Acked-by:

[PATCH iproute2-next] bpf: don't offload perf array maps

2018-05-04 Thread Jakub Kicinski
Perf arrays are handled specially by the kernel, don't request offload even when used by an offloaded program. Signed-off-by: Jakub Kicinski Reviewed-by: Quentin Monnet --- lib/bpf.c | 11 --- 1 file changed, 8 insertions(+),

Re: [PATCH bpf-next v3 00/15] Introducing AF_XDP support

2018-05-04 Thread Alexei Starovoitov
On Fri, May 04, 2018 at 01:22:17PM +0200, Magnus Karlsson wrote: > On Fri, May 4, 2018 at 1:38 AM, Alexei Starovoitov > wrote: > > On Fri, May 04, 2018 at 12:49:09AM +0200, Daniel Borkmann wrote: > >> On 05/02/2018 01:01 PM, Björn Töpel wrote: > >> > From: Björn

pull-request: bpf-next 2018-05-05

2018-05-04 Thread Daniel Borkmann
Hi David, The following pull-request contains BPF updates for your *net-next* tree. The main changes are: 1) Add initial infrastructure for AF_XDP sockets, which is optimized for high performance packet processing. This early work only adds copy-mode, and zero-copy semantics with driver

Re: [PATCH net-next] net/ipv6: rename rt6_next to fib6_next

2018-05-04 Thread David Miller
From: David Ahern Date: Fri, 4 May 2018 13:54:24 -0700 > This slipped through the cracks in the followup set to the fib6_info flip. > Rename rt6_next to fib6_next. > > Signed-off-by: David Ahern Applied, thanks David.

Re: pull-request: bpf 2018-05-05

2018-05-04 Thread David Miller
From: Daniel Borkmann Date: Sat, 5 May 2018 00:21:47 +0200 > The following pull-request contains BPF updates for your *net* tree. > > The main changes are: > > 1) Sanitize attr->{prog,map}_type from bpf(2) since used as an array index >to retrieve prog/map specific

Re: [PATCH] net: disable UDP punt on sockets in RCV_SHUTDWON

2018-05-04 Thread Eric Dumazet
On 05/04/2018 02:08 PM, Chintan Shah wrote: > A UDP application which opens multiple sockets with same local > address/port combination (using SO_REUSEPORT/SO_REUSEADDR socket options); > and issues connect to a remote socket (using one of these local socket). > Now if the same socket, which

Re: [PATCH net] sctp: delay the authentication for the duplicated cookie-echo chunk

2018-05-04 Thread Marcelo Ricardo Leitner
On Fri, May 04, 2018 at 05:05:10PM +0800, Xin Long wrote: > Now sctp only delays the authentication for the normal cookie-echo > chunk by setting chunk->auth_chunk in sctp_endpoint_bh_rcv(). But > for the duplicated one with auth, in sctp_assoc_bh_rcv(), it does > authentication first based on the

Re: [PATCH bpf-next 09/10] tools: bpftool: add simple perf event output reader

2018-05-04 Thread Jakub Kicinski
CC perf folks On Fri, 4 May 2018 14:25:03 -0700, Alexei Starovoitov wrote: > > +static void > > +perf_event_read(struct event_ring_info *ring, void **buf, size_t *buf_len) > > +{ > > + volatile struct perf_event_mmap_page *header = ring->mem; > > + __u64 buffer_size = MMAP_PAGE_CNT *

Re: [net-next PATCH v2 4/8] udp: Do not pass checksum as a parameter to GSO segmentation

2018-05-04 Thread Alexander Duyck
On Fri, May 4, 2018 at 1:19 PM, Eric Dumazet wrote: > > > On 05/04/2018 11:30 AM, Alexander Duyck wrote: >> From: Alexander Duyck >> >> This patch is meant to allow us to avoid having to recompute the checksum >> from scratch and have it

pull-request: bpf 2018-05-05

2018-05-04 Thread Daniel Borkmann
Hi David, The following pull-request contains BPF updates for your *net* tree. The main changes are: 1) Sanitize attr->{prog,map}_type from bpf(2) since used as an array index to retrieve prog/map specific ops such that we prevent potential out of bounds value under speculation, from Mark

Re: [PATCH iproute2] rdma: fix header files

2018-05-04 Thread David Ahern
On 5/4/18 3:56 PM, Stephen Hemminger wrote: > All user api headers in iproute2 should be in include/uapi > so that script can be used to put correct sanitized kernel headers > there. And the header files for rdma must be a complete set; if one > header file includes another, all must be present. >

Re: [PATCH v2 4/4] smack: provide socketpair callback

2018-05-04 Thread Casey Schaufler
On 5/4/2018 7:28 AM, David Herrmann wrote: > From: Tom Gundersen > > Make sure to implement the new socketpair callback so the SO_PEERSEC > call on socketpair(2)s will return correct information. > > Signed-off-by: Tom Gundersen > Signed-off-by: David Herrmann

[PATCH iproute2] rdma: fix header files

2018-05-04 Thread Stephen Hemminger
All user api headers in iproute2 should be in include/uapi so that script can be used to put correct sanitized kernel headers there. And the header files for rdma must be a complete set; if one header file includes another, all must be present. This fixes build on older distributions, and Windows

Re: [PATCH bpf-next 09/10] tools: bpftool: add simple perf event output reader

2018-05-04 Thread Daniel Borkmann
On 05/04/2018 03:37 AM, Jakub Kicinski wrote: > Users of BPF sooner or later discover perf_event_output() helpers > and BPF_MAP_TYPE_PERF_EVENT_ARRAY. Dumping this array type is > not possible, however, we can add simple reading of perf events. > Create a new event_pipe subcommand for maps, this

[PATCH bpf-next 2/6] bpf: btf: Introduce BTF ID

2018-05-04 Thread Martin KaFai Lau
This patch gives an ID to each loaded BTF. The ID is allocated by the idr like the existing prog-id and map-id. The bpf_put(map->btf) is moved to __bpf_map_put() so that the userspace can stop seeing the BTF ID ASAP when the last BTF refcnt is gone. It also makes BTF accessible from userspace

[PATCH bpf-next 1/6] bpf: btf: Avoid WARN_ON when CONFIG_REFCOUNT_FULL=y

2018-05-04 Thread Martin KaFai Lau
If CONFIG_REFCOUNT_FULL=y, refcount_inc() WARN when refcount is 0. When creating a new btf, the initial btf->refcnt is 0 and triggered the following: [ 34.855452] refcount_t: increment on 0; use-after-free. [ 34.856252] WARNING: CPU: 6 PID: 1857 at lib/refcount.c:153 refcount_inc+0x26/0x30

[PATCH bpf-next 0/6] Introduce BTF ID

2018-05-04 Thread Martin KaFai Lau
This series introduces BTF ID which is exposed through the new BPF_BTF_GET_FD_BY_ID cmd, new "struct bpf_btf_info" and new members in the "struct bpf_map_info". Please see individual patch for details. Martin KaFai Lau (6): bpf: btf: Avoid WARN_ON when CONFIG_REFCOUNT_FULL=y bpf: btf:

[PATCH bpf-next 4/6] bpf: btf: Some test_btf clean up

2018-05-04 Thread Martin KaFai Lau
This patch adds a CHECK() macro for condition checking and error report purpose. Something similar to test_progs.c It also counts the number of tests passed/skipped/failed and print them at the end of the test run. Signed-off-by: Martin KaFai Lau Acked-by: Alexei Starovoitov

[PATCH bpf-next 5/6] bpf: btf: Update tools/include/uapi/linux/btf.h with BTF ID

2018-05-04 Thread Martin KaFai Lau
This patch sync the tools/include/uapi/linux/btf.h with the newly introduced BTF ID support. Signed-off-by: Martin KaFai Lau Acked-by: Alexei Starovoitov --- tools/include/uapi/linux/bpf.h | 11 +++ 1 file changed, 11 insertions(+) diff --git

[PATCH bpf-next 6/6] bpf: btf: Tests for BPF_OBJ_GET_INFO_BY_FD and BPF_BTF_GET_FD_BY_ID

2018-05-04 Thread Martin KaFai Lau
This patch adds test for BPF_BTF_GET_FD_BY_ID and the new btf_id/btf_key_id/btf_value_id in the "struct bpf_map_info". It also modifies the existing BPF_OBJ_GET_INFO_BY_FD test to reflect the new "struct bpf_btf_info". Signed-off-by: Martin KaFai Lau Acked-by: Alexei Starovoitov

[PATCH bpf-next 3/6] bpf: btf: Add struct bpf_btf_info

2018-05-04 Thread Martin KaFai Lau
During BPF_OBJ_GET_INFO_BY_FD on a btf_fd, the current bpf_attr's info.info is directly filled with the BTF binary data. It is not extensible. In this case, we want to add BTF ID. This patch adds "struct bpf_btf_info" which has the BTF ID as one of its member. The BTF binary data itself is

Re: [PATCH bpf-next 00/10] bpf: support offload of bpf_event_output()

2018-05-04 Thread Daniel Borkmann
On 05/04/2018 03:37 AM, Jakub Kicinski wrote: > Hi! > > This series centres on NFP offload of bpf_event_output(). The > first patch allows perf event arrays to be used by offloaded > programs. Next patch makes the nfp driver keep track of such > arrays to be able to filter FW events referring

Re: [PATCH] cxgb4vf: fix t4vf_eth_xmit()'s return type

2018-05-04 Thread Casey Leedom
| From: Luc Van Oostenryck | Sent: Tuesday, April 24, 2018 6:19:02 AM | | The method ndo_start_xmit() is defined as returning an 'netdev_tx_t', | which is a typedef for an enum type, but the implementation in this | driver returns an 'int'. | | Fix this by returning

Re: [PATCH net-next] net: core: rework skb_probe_transport_header()

2018-05-04 Thread kbuild test robot
Hi Paolo, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/Paolo-Abeni/net-core-rework-skb_probe_transport_header/20180504-041345 reproduce: # apt-get install sparse make ARCH

Re: [PATCH bpf-next 09/10] tools: bpftool: add simple perf event output reader

2018-05-04 Thread Alexei Starovoitov
On Thu, May 03, 2018 at 06:37:16PM -0700, Jakub Kicinski wrote: > Users of BPF sooner or later discover perf_event_output() helpers > and BPF_MAP_TYPE_PERF_EVENT_ARRAY. Dumping this array type is > not possible, however, we can add simple reading of perf events. > Create a new event_pipe

[PATCH] net: disable UDP punt on sockets in RCV_SHUTDWON

2018-05-04 Thread Chintan Shah
A UDP application which opens multiple sockets with same local address/port combination (using SO_REUSEPORT/SO_REUSEADDR socket options); and issues connect to a remote socket (using one of these local socket). Now if the same socket, which issued connect, issues shutdown (SHUT_RD); packets would

[PATCH ghak81 RFC V1 0/5] audit: group task params

2018-05-04 Thread Richard Guy Briggs
Group the audit parameters for each task into one structure. In particular, remove the loginuid and sessionid values and the audit context pointer from the task structure, replacing them with an audit task information structure to contain them. Use access functions to access audit values. Note:

[PATCH ghak81 RFC V1 1/5] audit: normalize loginuid read access

2018-05-04 Thread Richard Guy Briggs
Recognizing that the loginuid is an internal audit value, use an access function to retrieve the audit loginuid value for the task rather than reaching directly into the task struct to get it. Signed-off-by: Richard Guy Briggs --- kernel/auditsc.c | 16 1 file

[PATCH ghak81 RFC V1 2/5] audit: convert sessionid unset to a macro

2018-05-04 Thread Richard Guy Briggs
Use a macro, "AUDIT_SID_UNSET", to replace each instance of initialization and comparison to an audit session ID. Signed-off-by: Richard Guy Briggs --- include/linux/audit.h | 2 +- include/net/xfrm.h | 2 +- include/uapi/linux/audit.h | 1 + init/init_task.c

[PATCH ghak81 RFC V1 4/5] audit: use inline function to set audit context

2018-05-04 Thread Richard Guy Briggs
Recognizing that the audit context is an internal audit value, use an access function to set the audit context pointer for the task rather than reaching directly into the task struct to set it. Signed-off-by: Richard Guy Briggs --- include/linux/audit.h | 8

[PATCH ghak81 RFC V1 3/5] audit: use inline function to get audit context

2018-05-04 Thread Richard Guy Briggs
Recognizing that the audit context is an internal audit value, use an access function to retrieve the audit context pointer for the task rather than reaching directly into the task struct to get it. Signed-off-by: Richard Guy Briggs --- include/linux/audit.h| 16

[PATCH ghak81 RFC V1 5/5] audit: collect audit task parameters

2018-05-04 Thread Richard Guy Briggs
The audit-related parameters in struct task_struct should ideally be collected together and accessed through a standard audit API. Collect the existing loginuid, sessionid and audit_context together in a new struct audit_task_info pointer called "audit" in struct task_struct. Use kmem_cache to

[PATCH net-next] net/ipv6: rename rt6_next to fib6_next

2018-05-04 Thread David Ahern
This slipped through the cracks in the followup set to the fib6_info flip. Rename rt6_next to fib6_next. Signed-off-by: David Ahern --- include/net/ip6_fib.h | 6 +++--- net/ipv6/ip6_fib.c| 26 +- net/ipv6/route.c | 12 ++-- 3 files

Re: [net-next PATCH v2 4/8] udp: Do not pass checksum as a parameter to GSO segmentation

2018-05-04 Thread Eric Dumazet
On 05/04/2018 11:30 AM, Alexander Duyck wrote: > From: Alexander Duyck > > This patch is meant to allow us to avoid having to recompute the checksum > from scratch and have it passed as a parameter. > > Instead of taking that approach we can take advantage of the

Product Inquiry

2018-05-04 Thread Gerhard Kahmann
?Dear Sir, We recently visited your website, we were recommended by one of your customer and we are interested in your models, We will like to place an order from the list of your products. However, we would like to see your company's latest catalogs with the; minimum order quantity, delivery

Re: [net-next PATCH v2 3/8] udp: Do not pass MSS as parameter to GSO segmentation

2018-05-04 Thread Eric Dumazet
On 05/04/2018 11:29 AM, Alexander Duyck wrote: > From: Alexander Duyck > > There is no point in passing MSS as a parameter for for the GSO > segmentation call as it is already available via the shared info for the > skb itself. > > Signed-off-by: Alexander Duyck

Re: [RFC PATCH 2/2] net: mac808211: mac802154: use lockdep_assert_in_softirq() instead own warning

2018-05-04 Thread Peter Zijlstra
On Fri, May 04, 2018 at 09:07:35PM +0200, Sebastian Andrzej Siewior wrote: > On 2018-05-04 20:51:32 [+0200], Peter Zijlstra wrote: > > softirqs disabled, ack that is exactly what it checks. > > > > But afaict the assertion you introduced tests that we are _in_ softirq > > context, which is not

Re: [net-next PATCH v2 2/8] udp: Verify that pulling UDP header in GSO segmentation doesn't fail

2018-05-04 Thread Eric Dumazet
On 05/04/2018 11:29 AM, Alexander Duyck wrote: > From: Alexander Duyck > > We should verify that we can pull the UDP header before we attempt to do > so. Otherwise if this fails we have no way of knowing and GSO will not work > correctly. > > Signed-off-by:

Re: [PATCH v5 0/6] firmware_loader: cleanups for v4.18

2018-05-04 Thread Luis R. Rodriguez
On Fri, May 04, 2018 at 09:17:08PM +0200, Krzysztof Halasa wrote: > "Luis R. Rodriguez" writes: > > > * CONFIG_WANXL --> CONFIG_WANXL_BUILD_FIRMWARE > > * CONFIG_SCSI_AIC79XX --> CONFIG_AIC79XX_BUILD_FIRMWARE > > > > To this day both of these drivers are building driver

Re: [PATCH v2 net-next 1/4] umh: introduce fork_usermode_blob() helper

2018-05-04 Thread Luis R. Rodriguez
What a mighty short list of reviewers. Adding some more. My review below. I'd appreciate a Cc on future versions of these patches. On Wed, May 02, 2018 at 09:36:01PM -0700, Alexei Starovoitov wrote: > Introduce helper: > int fork_usermode_blob(void *data, size_t len, struct umh_info *info); >

Re: [PATCH v2 0/4] Introduce LSM-hook for socketpair(2)

2018-05-04 Thread James Morris
On Fri, 4 May 2018, David Herrmann wrote: > Hi > > This is v2 of the socketpair(2) LSM hook introduction. Thanks, all applied to git://git.kernel.org/pub/scm/linux/kernel/git/jmorris/linux-security.git next-general -- James Morris

Re: [PATCH 04/15] media: pxa_camera: remove the dmaengine compat need

2018-05-04 Thread Mauro Carvalho Chehab
Em Sun, 22 Apr 2018 13:06:12 +0200 Hans Verkuil escreveu: > On 04/02/2018 04:26 PM, Robert Jarzmik wrote: > > From: Robert Jarzmik > > > > As the pxa architecture switched towards the dmaengine slave map, the > > old compatibility mechanism to

Re: [PATCH v5 0/6] firmware_loader: cleanups for v4.18

2018-05-04 Thread Krzysztof Halasa
"Luis R. Rodriguez" writes: > * CONFIG_WANXL --> CONFIG_WANXL_BUILD_FIRMWARE > * CONFIG_SCSI_AIC79XX --> CONFIG_AIC79XX_BUILD_FIRMWARE > > To this day both of these drivers are building driver *firmwares* when > the option CONFIG_PREVENT_FIRMWARE_BUILD is disabled, and

Re: [PATCH v2 bpf-next 0/3] bpf: cleanups on managing subprog information

2018-05-04 Thread Daniel Borkmann
On 05/02/2018 10:17 PM, Jiong Wang wrote: > This patch set clean up some code logic related with managing subprog > information. > > Part of the set are inspried by Edwin's code in his RFC: > > "bpf/verifier: subprog/func_call simplifications" > > but with clearer separation so it could be

Re: [PATCH net-next v8 1/7] sched: Add Common Applications Kept Enhanced (cake) qdisc

2018-05-04 Thread Toke Høiland-Jørgensen
Thank you for the review! A few comments below, I'll fix the rest. > [...] > > So sch_cake doesn't accept normal tc filters? Is this intentional? > If so, why? For two reasons: - The two-level scheduling used in CAKE (tins / diffserv classes, and flow hashing) does not map in an obvious way

Re: [PATCH] net/mlx5: fix spelling mistake: "modfiy" -> "modify"

2018-05-04 Thread Saeed Mahameed
On Thu, 2018-05-03 at 14:44 -0400, David Miller wrote: > From: Colin King > Date: Thu, 3 May 2018 14:35:03 +0100 > > > From: Colin Ian King > > > > Trivial fix to spelling mistake in netdev_warn warning message > > > > Signed-off-by: Colin

Re: [RFC PATCH 2/2] net: mac808211: mac802154: use lockdep_assert_in_softirq() instead own warning

2018-05-04 Thread Sebastian Andrzej Siewior
On 2018-05-04 20:51:32 [+0200], Peter Zijlstra wrote: > On Fri, May 04, 2018 at 08:45:39PM +0200, Sebastian Andrzej Siewior wrote: > > On 2018-05-04 20:32:49 [+0200], Peter Zijlstra wrote: > > > On Fri, May 04, 2018 at 07:51:44PM +0200, Sebastian Andrzej Siewior wrote: > > > > From: Anna-Maria

Re: [RFC PATCH 2/2] net: mac808211: mac802154: use lockdep_assert_in_softirq() instead own warning

2018-05-04 Thread Peter Zijlstra
On Fri, May 04, 2018 at 08:45:39PM +0200, Sebastian Andrzej Siewior wrote: > On 2018-05-04 20:32:49 [+0200], Peter Zijlstra wrote: > > On Fri, May 04, 2018 at 07:51:44PM +0200, Sebastian Andrzej Siewior wrote: > > > From: Anna-Maria Gleixner > > > > > > The warning in

Re: [RFC PATCH 2/2] net: mac808211: mac802154: use lockdep_assert_in_softirq() instead own warning

2018-05-04 Thread Sebastian Andrzej Siewior
On 2018-05-04 20:32:49 [+0200], Peter Zijlstra wrote: > On Fri, May 04, 2018 at 07:51:44PM +0200, Sebastian Andrzej Siewior wrote: > > From: Anna-Maria Gleixner > > > > The warning in ieee802154_rx() and ieee80211_rx_napi() is there to ensure > > the softirq context for

Re: [RFC PATCH 2/2] net: mac808211: mac802154: use lockdep_assert_in_softirq() instead own warning

2018-05-04 Thread Peter Zijlstra
On Fri, May 04, 2018 at 07:51:44PM +0200, Sebastian Andrzej Siewior wrote: > From: Anna-Maria Gleixner > > The warning in ieee802154_rx() and ieee80211_rx_napi() is there to ensure > the softirq context for the subsequent netif_receive_skb() call. That's not in fact

[net-next PATCH v2 8/8] net: Add NETIF_F_GSO_UDP_L4 to list of GSO offloads with fallback

2018-05-04 Thread Alexander Duyck
From: Alexander Duyck Enable UDP offload as a generic software offload since we can now handle it for multiple cases including if the checksum isn't present and via gso_partial in the case of tunnels. Signed-off-by: Alexander Duyck ---

[net-next PATCH v2 7/8] udp: Do not copy destructor if one is not present

2018-05-04 Thread Alexander Duyck
From: Alexander Duyck This patch makes it so that if a destructor is not present we avoid trying to update the skb socket or any reference counting that would be associated with the NULL socket and/or descriptor. By doing this we can support traffic coming from

[net-next PATCH v2 6/8] udp: Add support for software checksum and GSO_PARTIAL with GSO offload

2018-05-04 Thread Alexander Duyck
From: Alexander Duyck This patch adds support for a software provided checksum and GSO_PARTIAL segmentation support. With this we can offload UDP segmentation on devices that only have partial support for tunnels. Since we are no longer needing the hardware checksum

[net-next PATCH v2 4/8] udp: Do not pass checksum as a parameter to GSO segmentation

2018-05-04 Thread Alexander Duyck
From: Alexander Duyck This patch is meant to allow us to avoid having to recompute the checksum from scratch and have it passed as a parameter. Instead of taking that approach we can take advantage of the fact that the length that was used to compute the existing

[net-next PATCH v2 5/8] udp: Partially unroll handling of first segment and last segment

2018-05-04 Thread Alexander Duyck
From: Alexander Duyck This patch allows us to take care of unrolling the first segment and the last segment of the loop for processing the segmented skb. Part of the motivation for this is that it makes it easier to process the fact that the first fame and all of the

[net-next PATCH v2 3/8] udp: Do not pass MSS as parameter to GSO segmentation

2018-05-04 Thread Alexander Duyck
From: Alexander Duyck There is no point in passing MSS as a parameter for for the GSO segmentation call as it is already available via the shared info for the skb itself. Signed-off-by: Alexander Duyck --- v2: New break-out patch based

[net-next PATCH v2 2/8] udp: Verify that pulling UDP header in GSO segmentation doesn't fail

2018-05-04 Thread Alexander Duyck
From: Alexander Duyck We should verify that we can pull the UDP header before we attempt to do so. Otherwise if this fails we have no way of knowing and GSO will not work correctly. Signed-off-by: Alexander Duyck --- v2: New break-out

[net-next PATCH v2 1/8] udp: Record gso_segs when supporting UDP segmentation offload

2018-05-04 Thread Alexander Duyck
From: Alexander Duyck We need to record the number of segments that will be generated when this frame is segmented. The expectation is that if gso_size is set then gso_segs is set as well. Without this some drivers such as ixgbe get confused if they attempt to

[net-next PATCH v2 0/8] UDP GSO Segmentation clean-ups

2018-05-04 Thread Alexander Duyck
This patch set addresses a number of issues I found while sorting out enabling UDP GSO Segmentation support for ixgbe/ixgbevf. Specifically there were a number of issues related to the checksum and such that seemed to cause either minor irregularities or kernel panics in the case of the offload

[PATCH net] Added support for 802.1ad Q in Q Ethernet tagged frames

2018-05-04 Thread Elad Nachman
stmmac reception handler calls stmmac_rx_vlan() to strip the vlan before calling napi_gro_receive(). The function assumes VLAN tagged frames are always tagged with 802.1Q protocol, and assigns ETH_P_8021Q to the skb by hard-coding the parameter on call to __vlan_hwaccel_put_tag() . This causes

Hello

2018-05-04 Thread Faruk Sakawo
I have a business to discuss with you, can we talk? Regards Faruk Sakawo

[PATCH V2 net-next] liquidio: support use of ethtool to set link speed of CN23XX-225 cards

2018-05-04 Thread Felix Manlunas
From: Weilin Chang Support setting the link speed of CN23XX-225 cards (which can do 25Gbps or 10Gbps) via ethtool_ops.set_link_ksettings. Also fix the function assigned to ethtool_ops.get_link_ksettings to use the new link_ksettings api completely (instead of partially

Re: [PATCH net-next v8 1/7] sched: Add Common Applications Kept Enhanced (cake) qdisc

2018-05-04 Thread Cong Wang
On Fri, May 4, 2018 at 7:02 AM, Toke Høiland-Jørgensen wrote: > +struct cake_sched_data { > + struct cake_tin_data *tins; > + > + struct cake_heap_entry overflow_heap[CAKE_QUEUES * CAKE_MAX_TINS]; > + u16 overflow_timeout; > + > + u16

Re: [PATCH] net: Work around crash in ipv6 fib-walk-continue

2018-05-04 Thread Ben Greear
On 05/04/2018 10:47 AM, David Ahern wrote: On 4/19/18 12:01 PM, gree...@candelatech.com wrote: From: Ben Greear This keeps us from crashing in certain test cases where we bring up many (1000, for instance) mac-vlans with IPv6 enabled in the kernel. This bug has been

[RFC PATCH 2/2] net: mac808211: mac802154: use lockdep_assert_in_softirq() instead own warning

2018-05-04 Thread Sebastian Andrzej Siewior
From: Anna-Maria Gleixner The warning in ieee802154_rx() and ieee80211_rx_napi() is there to ensure the softirq context for the subsequent netif_receive_skb() call. The check could be moved into the netif_receive_skb() function to prevent all calling functions implement

[RFC PATCH 0/2] Introduce assert_in_softirq()

2018-05-04 Thread Sebastian Andrzej Siewior
ieee80211_rx_napi() has a check to ensure that it is invoked in softirq context / with BH disabled. It is there because it invokes netif_receive_skb() which has this requirement. On -RT this check does not work as expected so there is always this warning. Tree wide there are two users of this

[RFC PATCH 1/2] lockdep: Add a assert_in_softirq()

2018-05-04 Thread Sebastian Andrzej Siewior
From: Anna-Maria Gleixner Instead of directly warn on wrong context, check if softirq context is set. This check could be a nop on RT. Signed-off-by: Anna-Maria Gleixner Signed-off-by: Sebastian Andrzej Siewior ---

Re: [PATCH] net: Work around crash in ipv6 fib-walk-continue

2018-05-04 Thread David Ahern
On 4/19/18 12:01 PM, gree...@candelatech.com wrote: > From: Ben Greear > > This keeps us from crashing in certain test cases where we > bring up many (1000, for instance) mac-vlans with IPv6 > enabled in the kernel. This bug has been around for a > very long time. > >

[PATCH v5 1/6] firmware: wrap FW_OPT_* into an enum

2018-05-04 Thread Luis R. Rodriguez
From: Andres Rodriguez This should let us associate enum kdoc to these values. While at it, kdocify the fw_opt. Signed-off-by: Andres Rodriguez Acked-by: Luis R. Rodriguez [mcgrof: coding style fixes, merge kdoc with enum move]

[PATCH v5 0/6] firmware_loader: cleanups for v4.18

2018-05-04 Thread Luis R. Rodriguez
folks. These patches are based on top of linux-next next-20180504, they are also available in a respective git branch, both for linux-next [1] and linux [2]. Question, and specially rants are greatly appreciated, and of course... may the 4th be with you. [0] https://github.com/teg/firmwared [1]

[PATCH v5 3/6] firmware: rename fw_sysfs_fallback to firmware_fallback_sysfs()

2018-05-04 Thread Luis R. Rodriguez
From: Andres Rodriguez This is done since this call is now exposed through kernel-doc, and since this also paves the way for different future types of fallback mechanims. Signed-off-by: Andres Rodriguez Acked-by: Luis R. Rodriguez

[PATCH v5 2/6] firmware: use () to terminate kernel-doc function names

2018-05-04 Thread Luis R. Rodriguez
From: Andres Rodriguez The kernel-doc spec dictates a function name ends in (). Signed-off-by: Andres Rodriguez Acked-by: Randy Dunlap Acked-by: Luis R. Rodriguez Signed-off-by: Luis R. Rodriguez

[PATCH v5 4/6] firmware_loader: document firmware_sysfs_fallback()

2018-05-04 Thread Luis R. Rodriguez
This also sets the expecations for future fallback interfaces, even if they are not exported. Signed-off-by: Luis R. Rodriguez --- drivers/base/firmware_loader/fallback.c | 20 1 file changed, 20 insertions(+) diff --git

[PATCH v5 6/6] firmware_loader: move kconfig FW_LOADER entries to its own file

2018-05-04 Thread Luis R. Rodriguez
This will make it easier to track and easier to understand what components and features are part of the FW_LOADER. There are some components related to firmware which have *nothing* to do with the FW_LOADER, souch as PREVENT_FIRMWARE_BUILD. Signed-off-by: Luis R. Rodriguez ---

[PATCH v5 5/6] firmware_loader: enhance Kconfig documentation over FW_LOADER

2018-05-04 Thread Luis R. Rodriguez
If you try to read FW_LOADER today it speaks of old riddles and unless you have been following development closely you will loose track of what is what. Even the documentation for PREVENT_FIRMWARE_BUILD is a bit fuzzy and how it fits into this big picture. Give the FW_LOADER kconfig documentation

Re: [PATCH v3 net-next] net: dsa: mv88e6xxx: 88E6141/6341 SERDES support

2018-05-04 Thread David Miller
From: Marek Behún Date: Fri, 4 May 2018 19:26:10 +0200 > The 88E6141/6341 switches (also known as Topaz) have 1 SGMII lane, > which can be configured the same way as the SERDES lane on 88E6390. > > Signed-off-by: Marek Behun Applied, thank you.

Re: [PATCH v2 2/4] net: hook socketpair() into LSM

2018-05-04 Thread David Miller
From: David Herrmann Date: Fri, 4 May 2018 16:28:20 +0200 > Use the newly created LSM-hook for socketpair(). The default hook > return-value is 0, so behavior stays the same unless LSMs start using > this hook. > > Acked-by: Serge Hallyn >

Charity Gift !!!

2018-05-04 Thread Mrs Mavis L. Wanczyk
-- This is the second time i am sending you this mail. I, Mavis Wanczyk donates $ 5 Million Dollars from part of my Powerball Jackpot Lottery of $ 758 Million Dollars, respond with your details for claims. I await your earliest response and God Bless you Good luck. Mavis Wanczyk

Re: [PATCH net] net: phy: sfp: fix the BR,min computation

2018-05-04 Thread David Miller
From: Antoine Tenart Date: Fri, 4 May 2018 17:10:54 +0200 > In an SFP EEPROM values can be read to get information about a given SFP > module. One of those is the bitrate, which can be determined using a > nominal bitrate in addition with min and max values (in %).

Re: [PATCH net-next v2] net: core: rework basic flow dissection helper

2018-05-04 Thread David Miller
From: Paolo Abeni Date: Fri, 4 May 2018 11:32:59 +0200 > When the core networking needs to detect the transport offset in a given > packet and parse it explicitly, a full-blown flow_keys struct is used for > storage. > This patch introduces a smaller keys store, rework the

[PATCH v3 net-next] net: dsa: mv88e6xxx: 88E6141/6341 SERDES support

2018-05-04 Thread Marek Behún
The 88E6141/6341 switches (also known as Topaz) have 1 SGMII lane, which can be configured the same way as the SERDES lane on 88E6390. Signed-off-by: Marek Behun --- drivers/net/dsa/mv88e6xxx/chip.c | 2 ++ drivers/net/dsa/mv88e6xxx/serdes.c | 20

[PATCH 1/2] net: nixge: Fix error path for obtaining mac address

2018-05-04 Thread Moritz Fischer
Fix issue where nixge_get_nvmem_address() returns a non-NULL return value on a failed nvmem_cell_get() that causes an invalid access when error value encoded in pointer is dereferenced. Furthermore ensure that buffer allocated by nvmem_cell_read() actually gets kfreed() if the function succeeds.

[PATCH 2/2] net: nixge: Address compiler warnings about signedness

2018-05-04 Thread Moritz Fischer
Fixes the following warnings: warning: pointer targets in passing argument 1 of ‘is_valid_ether_addr’ differ in signedness [-Wpointer-sign] if (mac_addr && is_valid_ether_addr(mac_addr)) { ^~~~ expected ‘const u8 * {aka const unsigned char *}’ but

Re: [PATCH net-next v2 02/13] net: phy: sfp: handle non-wired SFP connectors

2018-05-04 Thread Antoine Tenart
Hi Florian, On Fri, May 04, 2018 at 10:04:48AM -0700, Florian Fainelli wrote: > On 05/04/2018 06:56 AM, Antoine Tenart wrote: > > SFP connectors can be solder on a board without having any of their pins > > (LOS, i2c...) wired. In such cases the SFP link state cannot be guessed, > > and the

Re: [PATCH] net: ethernet: sun: niu set correct packet size in skb

2018-05-04 Thread David Miller
From: David Miller Date: Fri, 04 May 2018 13:09:50 -0400 (EDT) > From: Rob Taglang > Date: Fri, 04 May 2018 13:07:54 -0400 > >>> Still corrupted. Your email client is chopping up long lines. >>> Please, send a test patch to yourself and make sure you can

Re: [PATCH net-next v2 01/13] net: phy: sfp: make the i2c-bus property really optional

2018-05-04 Thread Antoine Tenart
Hi Florian, On Fri, May 04, 2018 at 10:03:16AM -0700, Florian Fainelli wrote: > On 05/04/2018 06:56 AM, Antoine Tenart wrote: > > > > static int sfp_read(struct sfp *sfp, bool a2, u8 addr, void *buf, size_t > > len) > > { > > + if (!sfp->read) > > + return -EOPNOTSUPP; > >

Re: [PATCH net-next v2 02/13] net: phy: sfp: handle non-wired SFP connectors

2018-05-04 Thread Andrew Lunn
On Fri, May 04, 2018 at 10:04:48AM -0700, Florian Fainelli wrote: > On 05/04/2018 06:56 AM, Antoine Tenart wrote: > > SFP connectors can be solder on a board without having any of their pins > > (LOS, i2c...) wired. In such cases the SFP link state cannot be guessed, > > and the overall link

Re: [PATCH net-next v2 03/13] net: phy: sfp: warn the user when no tx_disable pin is available

2018-05-04 Thread Andrew Lunn
On Fri, May 04, 2018 at 10:07:53AM -0700, Florian Fainelli wrote: > On 05/04/2018 06:56 AM, Antoine Tenart wrote: > > In case no Tx disable pin is available the SFP modules will always be > > emitting. This could be an issue when using modules using laser as their > > light source as we would have

  1   2   >