[PATCH net-next 04/14] nfp: abm: add helpers for configuring queue marking levels

2018-05-25 Thread Jakub Kicinski
Queue levels for simple ECN marking are stored in _abi_nfd_out_q_lvls_X symbol, where X is the PCIe PF id. Find out the location of that symbol and add helpers for modifying it. Signed-off-by: Jakub Kicinski --- drivers/net/ethernet/netronome/nfp/abm/ctrl.c | 80

[PATCH net-next 02/14] nfp: prefix vNIC phys_port_name with 'n'

2018-05-25 Thread Jakub Kicinski
Some drivers are using a bare number inside phys_port_name as VF id and OpenStack's regexps will pick it up. We can't use a bare number for your vNICs, prefix the names with 'n'. Signed-off-by: Jakub Kicinski --- drivers/net/ethernet/netronome/nfp/nfp_net_common.c

[PATCH net-next 10/14] nfp: abm: expose all PF queues

2018-05-25 Thread Jakub Kicinski
Allocate the PF representor as multi-queue to allow setting the configuration per-queue. Signed-off-by: Jakub Kicinski --- drivers/net/ethernet/netronome/nfp/abm/main.c | 10 +++--- drivers/net/ethernet/netronome/nfp/nfp_net_repr.c | 5 +++--

[PATCH net-next 06/14] net: sched: add qstats.qlen to qlen

2018-05-25 Thread Jakub Kicinski
AFAICT struct gnet_stats_queue.qlen is not used in Qdiscs. It may, however, be useful for offloads to report HW queue length there. Add that value to the result of qdisc_qlen_sum(). Signed-off-by: Jakub Kicinski --- include/net/sch_generic.h | 4 ++-- 1 file

[PATCH net-next 09/14] nfp: abm: expose the internal stats in ethtool

2018-05-25 Thread Jakub Kicinski
There is a handful of statistics exposing some internal details of the implementation. Expose those via ethtool. Signed-off-by: Jakub Kicinski --- drivers/net/ethernet/netronome/nfp/abm/ctrl.c | 22 drivers/net/ethernet/netronome/nfp/abm/main.c | 51

[PATCH net-next 07/14] nfp: abm: report statistics from RED offload

2018-05-25 Thread Jakub Kicinski
Report basic and extended RED statistics back to TC. Signed-off-by: Jakub Kicinski Reviewed-by: Dirk van der Merwe --- drivers/net/ethernet/netronome/nfp/abm/ctrl.c | 114 ++

[PATCH net-next 14/14] nfp: abm: report correct MQ stats

2018-05-25 Thread Jakub Kicinski
Report the stat diff to make sure MQ stats add up to child stats. Signed-off-by: Jakub Kicinski Reviewed-by: Dirk van der Merwe --- drivers/net/ethernet/netronome/nfp/abm/main.c | 24 +++ 1 file changed, 24

[PATCH net-next 08/14] nfp: allow apps to add extra stats to ports

2018-05-25 Thread Jakub Kicinski
Allow nfp apps to add extra ethtool stats. Signed-off-by: Jakub Kicinski --- drivers/net/ethernet/netronome/nfp/nfp_app.c | 22 +++ drivers/net/ethernet/netronome/nfp/nfp_app.h | 13 +++ .../ethernet/netronome/nfp/nfp_net_ethtool.c | 10

[PATCH net-next 12/14] nfp: abm: multi-queue RED offload

2018-05-25 Thread Jakub Kicinski
Add support for MQ offload and setting RED parameters on queue-by-queue basis. Signed-off-by: Jakub Kicinski Reviewed-by: Dirk van der Merwe --- drivers/net/ethernet/netronome/nfp/abm/ctrl.c | 50 -

[PATCH net-next 11/14] net: sched: mq: add simple offload notification

2018-05-25 Thread Jakub Kicinski
mq offload is trivial, we just need to let the device know that the root qdisc is mq. Alternative approach would be to export qdisc_lookup() and make drivers check the root type themselves, but notification via ndo_setup_tc is more in line with other qdiscs. Note that mq doesn't hold any stats

[PATCH net-next 00/14] nfp: abm: RED/MQ qdisc offload

2018-05-25 Thread Jakub Kicinski
Hi! This is second batch of advanced buffer management nfp driver changes. This series adds the qdisc offload. Support for a very simple subset of RED qdisc offload is added as needed for DCTCP ECN marking (min and max thresholds set to the same value). The first two patches fix glitches

[PATCH net-next 01/14] nfp: return -EOPNOTSUPP from .ndo_get_phys_port_name for VFs

2018-05-25 Thread Jakub Kicinski
After recent change we started returning 0 from ndo_get_phys_port_name for VFs. The name parameter for ndo_get_phys_port_name is not initialized by the stack so this can lead to a crash. We should have kept returning -EOPNOTSUPP in the first place. Signed-off-by: Jakub Kicinski

[PATCH net-next 13/14] net: sched: mq: request stats from offloads

2018-05-25 Thread Jakub Kicinski
MQ doesn't hold any statistics on its own, however, statistic from offloads are requested starting from the root, hence MQ will read the old values for its sums. Call into the drivers, because of the additive nature of the stats drivers are aware of how much "pending updates" they have to

[PATCH net-next 05/14] nfp: abm: add simple RED offload

2018-05-25 Thread Jakub Kicinski
Offload simple RED configurations. For now support only DCTCP like scenarios where min and max are the same. Signed-off-by: Jakub Kicinski --- drivers/net/ethernet/netronome/nfp/abm/main.c | 82 +++ drivers/net/ethernet/netronome/nfp/abm/main.h |

[PATCH net-next 03/14] nfp: abm: enable advanced queuing on demand

2018-05-25 Thread Jakub Kicinski
ABM NIC FW has a cut-through mode where the PCIe queuing is bypassed, thus working like our standard NIC FWs. Use this mode by default and only enable queuing in switchdev mode where users can configure it. Signed-off-by: Jakub Kicinski Reviewed-by: Dirk van der

Re: [PATCH] net: netsec: reduce DMA mask to 40 bits

2018-05-25 Thread Jassi Brar
On 26 May 2018 at 08:56, Jassi Brar wrote: > On 26 May 2018 at 01:07, Robin Murphy wrote: >> On Sat, 26 May 2018 00:33:05 +0530 >> Jassi Brar wrote: >> >>> On 25 May 2018 at 18:20, Ard Biesheuvel

Re: [PATCH] net: netsec: reduce DMA mask to 40 bits

2018-05-25 Thread Jassi Brar
On 26 May 2018 at 01:07, Robin Murphy wrote: > On Sat, 26 May 2018 00:33:05 +0530 > Jassi Brar wrote: > >> On 25 May 2018 at 18:20, Ard Biesheuvel >> wrote: >> > The netsec network controller IP can drive 64 address

[PATCH] PCI: reset driver SR-IOV state after remove

2018-05-25 Thread Jakub Kicinski
Bjorn points out that currently core and most of the drivers don't clean up dev->sriov->driver_max_VFs settings on .remove(). This means that if a different driver is bound afterwards it will inherit the old setting: - load PF driver 1 - driver calls pci_sriov_set_totalvfs() to reduce

Re: [PATCH net-next 0/8] nfp: offload LAG for tc flower egress

2018-05-25 Thread Jakub Kicinski
On Fri, 25 May 2018 08:48:09 +0200, Jiri Pirko wrote: > Thu, May 24, 2018 at 04:22:47AM CEST, jakub.kicin...@netronome.com wrote: > >Hi! > > > >This series from John adds bond offload to the nfp driver. Patch 5 > >exposes the hash type for NETDEV_LAG_TX_TYPE_HASH to make sure nfp > >hashing

Re: [PATCH net-next] bpfilter: fix a build err

2018-05-25 Thread YueHaibing
On 2018/5/26 0:19, Alexei Starovoitov wrote: > On Fri, May 25, 2018 at 06:17:57PM +0800, YueHaibing wrote: >> gcc-7.3.0 report following err: >> >> HOSTCC net/bpfilter/main.o >> In file included from net/bpfilter/main.c:9:0: >> ./include/uapi/linux/bpf.h:12:10: fatal error: linux/bpf_common.h:

Re: [PATCH] IB: Revert "remove redundant INFINIBAND kconfig dependencies"

2018-05-25 Thread Greg Thelen
On Fri, May 25, 2018 at 2:32 PM Arnd Bergmann wrote: > Several subsystems depend on INFINIBAND_ADDR_TRANS, which in turn depends > on INFINIBAND. However, when with CONFIG_INIFIBAND=m, this leads to a > link error when another driver using it is built-in. The >

[for-next 01/12] net/mlx5: E-Switch, Reorganize and rename fdb flow tables

2018-05-25 Thread Saeed Mahameed
From: Chris Mi We have several fdb flow tables for each of the legacy and switchdev modes. In the switchdev mode, there are fast path and slow path flow tables. Towards adding more flow tables in upcoming patches, reorganize and rename the various existing ones to reflect

[pull request][for-next 00/12] Mellanox, mlx5e updates 2018-05-25

2018-05-25 Thread Saeed Mahameed
Hi dave, This is a mlx5e only pull request, for more information please see tag log below. Please pull and let me know if there's any problem. Thanks, Saeed. The following changes since commit e52cde71709348c0d67bf0f213b438fa4d6cf9a9: net: dsa: dsa_loop: Make dynamic debugging helpful

[for-next 04/12] net/mlx5e: Parse mirroring action for offloaded TC eswitch flows

2018-05-25 Thread Saeed Mahameed
From: Chris Mi Currently, we only support the mirred redirect TC sub-action. In order to support flow based vport mirroring, add support to parse the mirred mirror sub-action. For mirroring, user-space will typically set the action order such that the mirror port (mirror

[for-next 05/12] net/mlx5e: Split offloaded eswitch TC rules for port mirroring

2018-05-25 Thread Saeed Mahameed
From: Chris Mi If a TC rule needs to be split for mirroring, create two HW rules, in the first level and the second level flow tables accordingly. In the first level flow table, forward the packet to the mirror port and forward the packet to the second level flow table for

[for-next 02/12] net/mlx5: Add cap bits for flow table destination in FDB table

2018-05-25 Thread Saeed Mahameed
From: Chris Mi If set, the FDB table supports the forward action with a destination list that includes a flow table. Signed-off-by: Chris Mi Reviewed-by: Paul Blakey Reviewed-by: Or Gerlitz Signed-off-by:

[for-next 11/12] net/mlx5e: Introducing new statistics rwlock

2018-05-25 Thread Saeed Mahameed
From: Shalom Lagziel Introduce a new read/write lock that will protect statistics gathering from netdev channels configuration changes. e.g. when channels are being replaced (increase/decrease number of rings) prevent statistic gathering (ndo_get_stats64) to read the

[for-next 07/12] net/mlx5e: TX, Use actual WQE size for SQ edge fill

2018-05-25 Thread Saeed Mahameed
From: Tariq Toukan We fill SQ edge with NOPs to avoid WQEs wrap. Here, instead of doing that in advance for the maximum possible WQE size, we do it on-demand using the actual WQE size. We re-order some parts in mlx5e_sq_xmit to finish the calculation of WQE size (ds_cnt)

[for-next 06/12] net/mlx5e: Use WQ API functions instead of direct fields access

2018-05-25 Thread Saeed Mahameed
From: Tariq Toukan Use the WQ API to get the WQ size, and to map a counter into a WQ entry index. Signed-off-by: Tariq Toukan Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core/en.h | 9 ++---

[for-next 03/12] net/mlx5: E-switch, Create a second level FDB flow table

2018-05-25 Thread Saeed Mahameed
From: Chris Mi If firmware supports the forward action with a destination list that includes a flow table, create a second level FDB flow table. This is going to be used for flow based mirroring under the switchdev offloads mode. Signed-off-by: Chris Mi

[for-next 08/12] net/mlx5i: Use compilation flag in IPOIB header

2018-05-25 Thread Saeed Mahameed
From: Tariq Toukan If CONFIG_MLX5_CORE_IPOIB is not set, compile-out the IPOIB related headers. Signed-off-by: Tariq Toukan Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core/ipoib/ipoib.h | 3 +++ 1 file

[for-next 10/12] net/mlx5e: Move phy link down events counter out of SW stats

2018-05-25 Thread Saeed Mahameed
PHY link down events counter belongs to phy_counters group. although it has special handling, it doesn't mean it can't be there. Move it to phy_counters_grp handler. Signed-off-by: Saeed Mahameed --- .../ethernet/mellanox/mlx5/core/en_stats.c| 37 +++

[for-next 12/12] net/mlx5e: Avoid reset netdev stats on configuration changes

2018-05-25 Thread Saeed Mahameed
From: Eran Ben Elisha Move all RQ, SQ and channel counters from the channel objects into the priv structure. With this change, counters will not be reset upon channel configuration changes. Channel's statistics for SQs which are associated with TCs higher than zero will be

[for-next 09/12] net/mlx5: Use order-0 allocations for all WQ types

2018-05-25 Thread Saeed Mahameed
From: Tariq Toukan Complete the transition of all WQ types to use fragmented order-0 coherent memory instead of high-order allocations. CQ-WQ already uses order-0. Here we do the same for cyclic and linked-list WQs. This allows the driver to load cleanly on systems with a

Re: [PATCH, net-next] qcom-emag: hide ACPI specific functions

2018-05-25 Thread Timur Tabi
On 5/25/18 4:37 PM, Arnd Bergmann wrote: +#ifdef CONFIG_ACPI static int emac_sgmii_irq_clear(struct emac_adapter *adpt, u8 irq_bits) { struct emac_sgmii *phy = >phy; @@ -288,6 +289,7 @@ static struct sgmii_ops qdf2400_ops = { .link_change = emac_sgmii_common_link_change,

Re: aio poll and a new in-kernel poll API V13

2018-05-25 Thread Al Viro
On Wed, May 23, 2018 at 09:19:49PM +0200, Christoph Hellwig wrote: > Hi all, > > this series adds support for the IOCB_CMD_POLL operation to poll for the > readyness of file descriptors using the aio subsystem. The API is based > on patches that existed in RHAS2.1 and RHEL3, which means it

Confusion about (new?) bridge behavior

2018-05-25 Thread Florian Fainelli
Hi, The DSA b53 driver currently (well, not quite currently, but at some point) was forcing the CPU port VLAN membership to be tagged. The reason for that is mostly because if we allow the CPU port to be untagged in multiple VLANs we can't quite properly separate traffic at the CPU port level, so

Re: [PATCH net-next v12 2/5] netvsc: refactor notifier/event handling code to use the failover framework

2018-05-25 Thread Stephen Hemminger
On Fri, 25 May 2018 16:11:47 -0700 "Samudrala, Sridhar" wrote: > On 5/25/2018 3:34 PM, Stephen Hemminger wrote: > > On Thu, 24 May 2018 09:55:14 -0700 > > Sridhar Samudrala wrote: > > > >> --- a/drivers/net/hyperv/Kconfig > >> +++

Re: [PATCH, net-next] net/mlx5e: fix TLS dependency

2018-05-25 Thread Saeed Mahameed
On Fri, 2018-05-25 at 23:36 +0200, Arnd Bergmann wrote: > With CONFIG_TLS=m and MLX5_CORE_EN=y, we get a link failure: > > drivers/net/ethernet/mellanox/mlx5/core/en_accel/tls_rxtx.o: In > function `mlx5e_tls_handle_ooo': > tls_rxtx.c:(.text+0x24c): undefined reference to `tls_get_record' >

Re: mmotm 2018-05-25-14-52 uploaded (drivers/net/ethernet/ti/davinci_mdio.c)

2018-05-25 Thread Randy Dunlap
[forgot to add netdev] On 05/25/2018 04:14 PM, Randy Dunlap wrote: > On 05/25/2018 02:52 PM, a...@linux-foundation.org wrote: >> The mm-of-the-moment snapshot 2018-05-25-14-52 has been uploaded to >> >>http://www.ozlabs.org/~akpm/mmotm/ >> >> mmotm-readme.txt says >> >> README for

Re: [PATCH net-next v12 2/5] netvsc: refactor notifier/event handling code to use the failover framework

2018-05-25 Thread Samudrala, Sridhar
On 5/25/2018 3:34 PM, Stephen Hemminger wrote: On Thu, 24 May 2018 09:55:14 -0700 Sridhar Samudrala wrote: --- a/drivers/net/hyperv/Kconfig +++ b/drivers/net/hyperv/Kconfig @@ -2,5 +2,6 @@ config HYPERV_NET tristate "Microsoft Hyper-V virtual network

Re: [PATCH net-next v12 1/5] net: Introduce generic failover module

2018-05-25 Thread Samudrala, Sridhar
On 5/25/2018 3:38 PM, Stephen Hemminger wrote: On Thu, 24 May 2018 09:55:13 -0700 Sridhar Samudrala wrote: diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h index 03ed492c4e14..0f4ba52b641d 100644 --- a/include/linux/netdevice.h +++

Re: [PATCH net-next v12 1/5] net: Introduce generic failover module

2018-05-25 Thread Stephen Hemminger
On Thu, 24 May 2018 09:55:13 -0700 Sridhar Samudrala wrote: > diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h > index 03ed492c4e14..0f4ba52b641d 100644 > --- a/include/linux/netdevice.h > +++ b/include/linux/netdevice.h > @@ -1421,6 +1421,8 @@

Re: [PATCH net-next v12 1/5] net: Introduce generic failover module

2018-05-25 Thread Stephen Hemminger
On Thu, 24 May 2018 09:55:13 -0700 Sridhar Samudrala wrote: > + spin_lock(_lock); Since register is not in fast path, this should be a mutex? > +int failover_slave_unregister(struct net_device *slave_dev) > +{ > + struct net_device *failover_dev; > +

Re: [PATCH net-next v12 2/5] netvsc: refactor notifier/event handling code to use the failover framework

2018-05-25 Thread Stephen Hemminger
On Thu, 24 May 2018 09:55:14 -0700 Sridhar Samudrala wrote: > --- a/drivers/net/hyperv/Kconfig > +++ b/drivers/net/hyperv/Kconfig > @@ -2,5 +2,6 @@ config HYPERV_NET > tristate "Microsoft Hyper-V virtual network driver" > depends on HYPERV > select

[PATCH] mwifiex: mark expected switch fall-throughs

2018-05-25 Thread Gustavo A. R. Silva
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. Signed-off-by: Gustavo A. R. Silva --- drivers/net/wireless/marvell/mwifiex/cfg80211.c | 4 drivers/net/wireless/marvell/mwifiex/scan.c | 1 + 2 files

Re: [PATCH v2 net-next] tcp: use data length instead of skb->len in tcp_probe

2018-05-25 Thread Song Liu
> On May 25, 2018, at 3:14 AM, Yafang Shao wrote: > > skb->len is meaningless to user. > data length could be more helpful, with which we can easily filter out > the packet without payload. > > Signed-off-by: Yafang Shao Acked-by: Song Liu

Re: [PATCH bpf-next] libbpf: Install btf.h with libbpf

2018-05-25 Thread Song Liu
On Fri, May 25, 2018 at 10:33 AM, Martin KaFai Lau wrote: > On Fri, May 25, 2018 at 10:23:13AM -0700, Andrey Ignatov wrote: >> install_headers target should contain all headers that are part of >> libbpf. Add missing btf.h >> >> Signed-off-by: Andrey Ignatov >

Re: [PATCH, net-next 2/2] bpf: avoid -Wmaybe-uninitialized warning

2018-05-25 Thread Song Liu
> On May 25, 2018, at 2:33 PM, Arnd Bergmann wrote: > > The stack_map_get_build_id_offset() function is too long for gcc to track > whether 'work' may or may not be initialized at the end of it, leading > to a false-positive warning: > > kernel/bpf/stackmap.c: In function

Re: [PATCH, net-next 1/2] bpf: btf: avoid -Wreturn-type warning

2018-05-25 Thread Song Liu
> On May 25, 2018, at 2:33 PM, Arnd Bergmann wrote: > > gcc warns about a noreturn function possibly returning in > some configurations: > > kernel/bpf/btf.c: In function 'env_type_is_resolve_sink': > kernel/bpf/btf.c:729:1: error: control reaches end of non-void function >

Re: [PATCH] PCI: allow drivers to limit the number of VFs to 0

2018-05-25 Thread Bjorn Helgaas
On Fri, May 25, 2018 at 02:05:21PM -0700, Jakub Kicinski wrote: > On Fri, 25 May 2018 09:02:23 -0500, Bjorn Helgaas wrote: > > On Thu, May 24, 2018 at 06:20:15PM -0700, Jakub Kicinski wrote: > > > On Thu, 24 May 2018 18:57:48 -0500, Bjorn Helgaas wrote: > > > > On Mon, Apr 02, 2018 at 03:46:52PM

[RFC PATCH 2/2] net: macb: Disable TX checksum offloading on all Zynq

2018-05-25 Thread Jennifer Dahm
The Zynq ethernet hardware has checksum offloading bugs that cause small UDP packets (<= 2 bytes) to be sent with an incorrect checksum (0x) and forwarded UDP packets to be re-checksummed, which is illegal behavior. The best solution we have right now is to disable hardware TX checksum

[RFC PATCH 1/2] net: macb: Add CAP to disable hardware TX checksum offloading

2018-05-25 Thread Jennifer Dahm
Certain PHYs have significant bugs in their TX checksum offloading that cannot be solved in software. In order to accommodate these PHYS, add a CAP to disable this hardware. Signed-off-by: Jennifer Dahm --- drivers/net/ethernet/cadence/macb.h | 1 +

[RFC PATCH 0/2] net: macb: Disable TX checksum offloading on all Zynq

2018-05-25 Thread Jennifer Dahm
During testing, I discovered that the Zynq GEM hardware overwrites all outgoing UDP packet checksums, which is illegal in packet forwarding cases. This happens both with and without the checksum-zeroing behavior introduced in 007e4ba3ee137f4700f39aa6dbaf01a71047c5f6 ("net: macb: initialize

[PATCH] ath9k: mark expected switch fall-throughs

2018-05-25 Thread Gustavo A. R. Silva
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. Signed-off-by: Gustavo A. R. Silva --- drivers/net/wireless/ath/ath9k/ar5008_phy.c | 2 ++ drivers/net/wireless/ath/ath9k/ar9002_phy.c | 1 +

Re: [PATCH 00/14] Modify action API for implementing lockless actions

2018-05-25 Thread Cong Wang
On Fri, May 25, 2018 at 1:39 PM, Vlad Buslov wrote: > > On Thu 24 May 2018 at 23:34, Cong Wang wrote: >> On Mon, May 14, 2018 at 7:27 AM, Vlad Buslov wrote: >>> Currently, all netlink protocol handlers for updating rules,

Re: [PATCH] IB: Revert "remove redundant INFINIBAND kconfig dependencies"

2018-05-25 Thread Leon Romanovsky
On Fri, May 25, 2018 at 11:29:59PM +0200, Arnd Bergmann wrote: > Several subsystems depend on INFINIBAND_ADDR_TRANS, which in turn depends > on INFINIBAND. However, when with CONFIG_INIFIBAND=m, this leads to a > link error when another driver using it is built-in. The > INFINIBAND_ADDR_TRANS

[PATCH, net-next] net/mlx5e: fix TLS dependency

2018-05-25 Thread Arnd Bergmann
With CONFIG_TLS=m and MLX5_CORE_EN=y, we get a link failure: drivers/net/ethernet/mellanox/mlx5/core/en_accel/tls_rxtx.o: In function `mlx5e_tls_handle_ooo': tls_rxtx.c:(.text+0x24c): undefined reference to `tls_get_record' drivers/net/ethernet/mellanox/mlx5/core/en_accel/tls_rxtx.o: In function

[PATCH, net-next] qcom-emag: hide ACPI specific functions

2018-05-25 Thread Arnd Bergmann
A couple of functions in this file are only used when building with ACPI enabled, leading to a build warning on most architectures: drivers/net/ethernet/qualcomm/emac/emac-sgmii.c:284:25: error: 'qdf2400_ops' defined but not used [-Werror=unused-variable] static struct sgmii_ops qdf2400_ops = {

[PATCH, net-next 1/2] bpf: btf: avoid -Wreturn-type warning

2018-05-25 Thread Arnd Bergmann
gcc warns about a noreturn function possibly returning in some configurations: kernel/bpf/btf.c: In function 'env_type_is_resolve_sink': kernel/bpf/btf.c:729:1: error: control reaches end of non-void function [-Werror=return-type] Using BUG() instead of BUG_ON() avoids that warning and

[PATCH, net-next 2/2] bpf: avoid -Wmaybe-uninitialized warning

2018-05-25 Thread Arnd Bergmann
The stack_map_get_build_id_offset() function is too long for gcc to track whether 'work' may or may not be initialized at the end of it, leading to a false-positive warning: kernel/bpf/stackmap.c: In function 'stack_map_get_build_id_offset': kernel/bpf/stackmap.c:334:13: error: 'work' may be used

[PATCH] IB: Revert "remove redundant INFINIBAND kconfig dependencies"

2018-05-25 Thread Arnd Bergmann
Several subsystems depend on INFINIBAND_ADDR_TRANS, which in turn depends on INFINIBAND. However, when with CONFIG_INIFIBAND=m, this leads to a link error when another driver using it is built-in. The INFINIBAND_ADDR_TRANS dependency is insufficient here as this is a 'bool' symbol that does not

Re: [PATCH] PCI: allow drivers to limit the number of VFs to 0

2018-05-25 Thread Jakub Kicinski
On Fri, 25 May 2018 09:02:23 -0500, Bjorn Helgaas wrote: > On Thu, May 24, 2018 at 06:20:15PM -0700, Jakub Kicinski wrote: > > On Thu, 24 May 2018 18:57:48 -0500, Bjorn Helgaas wrote: > > > On Mon, Apr 02, 2018 at 03:46:52PM -0700, Jakub Kicinski wrote: > > > > Some user space depends on

Inefficient call to ipv6_chk_acast_addr_src in icmp6_send

2018-05-25 Thread Salam Noureddine
Hi, The call to ipv6_chk_acast_addr_src in icmp6_send can be pretty costly on systems with a lot of net_devices since it can end up looping through all net_devices in a net namespace searching for an anycast address. A few thousand icmp6 error packets can end up consuming a whole CPU. I am

[GIT] Networking

2018-05-25 Thread David Miller
Let's begin the holiday weekend with some networking fixes: 1) Whoops need to restrict cfg80211 wiphy names even more to 64 bytes. From Eric Biggers. 2) Fix flags being ignored when using kernel_connect() with SCTP, from Xin Long. 3) Use after free in DCCP, from Alexey Kodanev. 4) Need

Re: [PATCH net-next] net: dsa: dsa_loop: Make dynamic debugging helpful

2018-05-25 Thread David Miller
From: Florian Fainelli Date: Thu, 24 May 2018 20:52:14 -0700 > Remove redundant debug prints from phy_read/write since we can trace those > calls through trace events. Enhance dynamic debug prints to print arguments > which helps figuring how what is going on at the driver

Re: [PATCH] PCI: allow drivers to limit the number of VFs to 0

2018-05-25 Thread Bjorn Helgaas
On Fri, May 25, 2018 at 03:27:52PM -0400, Don Dutile wrote: > On 05/25/2018 10:02 AM, Bjorn Helgaas wrote: > > On Thu, May 24, 2018 at 06:20:15PM -0700, Jakub Kicinski wrote: > > > Hi Bjorn! > > > > > > On Thu, 24 May 2018 18:57:48 -0500, Bjorn Helgaas wrote: > > > > On Mon, Apr 02, 2018 at

Re: [PATCH v4 2/3] media: rc: introduce BPF_PROG_LIRC_MODE2

2018-05-25 Thread Alexei Starovoitov
On Fri, May 18, 2018 at 03:07:29PM +0100, Sean Young wrote: > Add support for BPF_PROG_LIRC_MODE2. This type of BPF program can call > rc_keydown() to reported decoded IR scancodes, or rc_repeat() to report > that the last key should be repeated. > > The bpf program can be attached to using the

Re: [PATCH net-next v5 0/2] openvswitch: Support conntrack zone limit

2018-05-25 Thread David Miller
From: Yi-Hung Wei Date: Thu, 24 May 2018 17:56:41 -0700 > Currently, nf_conntrack_max is used to limit the maximum number of > conntrack entries in the conntrack table for every network namespace. > For the VMs and containers that reside in the same namespace, > they share

Re: [PATCH net-next] ifb: fix packets checksum

2018-05-25 Thread David Miller
From: Jon Maxwell Date: Fri, 25 May 2018 07:38:29 +1000 > Fixup the checksum for CHECKSUM_COMPLETE when pulling skbs on RX path. > Otherwise we get splats when tc mirred is used to redirect packets to ifb. > > Before fix: > > nic: hw csum failure > > Signed-off-by: Jon

Re: [pull request][net-next V2 0/6] Mellanox, mlx5e updates 2018-05-19

2018-05-25 Thread David Miller
From: Saeed Mahameed Date: Thu, 24 May 2018 14:38:14 -0700 > This is a mlx5e only pull request, for more information please see tag > log below. > > Please pull and let me know if there's any problem. > > v1->v2: > 1) patch #1 commit message: lldptool usage example and

Re: [PATCH 00/14] Modify action API for implementing lockless actions

2018-05-25 Thread Vlad Buslov
On Thu 24 May 2018 at 23:34, Cong Wang wrote: > On Mon, May 14, 2018 at 7:27 AM, Vlad Buslov wrote: >> Currently, all netlink protocol handlers for updating rules, actions and >> qdiscs are protected with single global rtnl lock which removes any

Re: [PATCH] 8139too: Remove unnecessary netif_napi_del()

2018-05-25 Thread David Miller
From: Bo Chen Date: Thu, 24 May 2018 12:48:35 -0700 > The call to free_netdev() in __rtl8139_cleanup_dev() clears the network device > napi list, and explicit calls to netif_napi_del() are unnecessary. > > Signed-off-by: Bo Chen Since this is just unnecessary

Re: [PATCH net] ibmvnic: Fix partial success login retries

2018-05-25 Thread David Miller
From: Thomas Falcon Date: Thu, 24 May 2018 14:37:53 -0500 > In its current state, the driver will handle backing device > login in a loop for a certain number of retries while the > device returns a partial success, indicating that the driver > may need to try again

Re: Poor TCP performance with XPS enabled after scrubbing skb

2018-05-25 Thread David Miller
From: Flavio Leitner Date: Thu, 24 May 2018 16:17:29 -0300 > veth originally called skb_orphan() on veth_xmit() most probably > because there was no TX completion. Then the code got generalized to > dev_forward_skb() and later on moved to skb_scrub_packet(). > > The issue is

Re: [PATCH net-next] tcp: use data length instead of skb->len in tcp_probe

2018-05-25 Thread David Miller
From: Song Liu Date: Thu, 24 May 2018 17:44:46 + > We should also rename __entry->length to __entry->data_len, so that whoever > using this field will notice the change. Agreed.

Re: [PATCH net-next 0/5] qed*: ethtool rx flow classification enhancements.

2018-05-25 Thread David Miller
From: Manish Chopra Date: Thu, 24 May 2018 09:54:48 -0700 > This series re-structures the driver's ethtool rx flow > classification flow, following that it adds other flow > profiles and rx flow classification enhancements > via "ethtool -N/-U" > > Please consider

Re: [PATCH net-next] vrf: add CRC32c offload to device features

2018-05-25 Thread David Ahern
On 5/24/18 9:49 AM, Davide Caratti wrote: > SCTP sockets originated in a VRF can improve their performance if CRC32c > computation is delegated to underlying devices: update device features, > setting NETIF_F_SCTP_CRC. Iterating the following command in the topology > proposed with [1], > > # ip

Re: pull-request: bpf 2018-05-24

2018-05-25 Thread Daniel Borkmann
On 05/25/2018 09:51 PM, David Miller wrote: > From: Daniel Borkmann > Date: Thu, 24 May 2018 18:38:02 +0200 > >> The following pull-request contains BPF updates for your *net* tree. >> >> The main changes are: >> >> 1) Fix a bug in the original fix to prevent out of bounds

Re: pull-request: bpf 2018-05-24

2018-05-25 Thread David Miller
From: Daniel Borkmann Date: Thu, 24 May 2018 18:38:02 +0200 > The following pull-request contains BPF updates for your *net* tree. > > The main changes are: > > 1) Fix a bug in the original fix to prevent out of bounds speculation when >multiple tail call maps from

[PATCH 2/2] batman-adv: Drop "experimental" from BATMAN_V Kconfig

2018-05-25 Thread Sven Eckelmann
The Kconfig option BATMAN_ADV_BATMAN_V is now enabled by default when the BATMAN_ADV is enabled. A feature which is enabled by default for a module should not be considered experimental. Reported-by: Joe Perches Signed-off-by: Sven Eckelmann ---

[PATCH 1/2] batman-adv: Remove "default n" in Kconfig

2018-05-25 Thread Sven Eckelmann
The "default n" is the default value for any bool or tristate Kconfig setting. It is therefore not necessary to add it to the an config entry. Reported-by: Sergei Shtylyov Signed-off-by: Sven Eckelmann --- net/batman-adv/Kconfig | 5 -

Re: [PATCH net] net: sched: check netif_xmit_frozen_or_stopped() in sch_direct_xmit()

2018-05-25 Thread Song Liu
On Fri, May 25, 2018 at 11:11 AM, Song Liu wrote: > Summary: > > At the end of sch_direct_xmit(), we are in the else path of > !dev_xmit_complete(ret), which means ret == NETDEV_TX_OK. The following > condition will always fail and netif_xmit_frozen_or_stopped() is not >

Re: [PATCH bpf-next v2 0/3] bpf: add boot parameters for sysctl knobs

2018-05-25 Thread Alexei Starovoitov
On Fri, May 25, 2018 at 06:50:09PM +0200, Eugene Syromiatnikov wrote: > On Thu, May 24, 2018 at 04:34:51PM -0700, Alexei Starovoitov wrote: > > On Thu, May 24, 2018 at 09:41:08AM +0200, Jesper Dangaard Brouer wrote: > > > On Wed, 23 May 2018 15:02:45 -0700 > > > Alexei Starovoitov

Re: [PATCH] net: netsec: reduce DMA mask to 40 bits

2018-05-25 Thread Robin Murphy
On Sat, 26 May 2018 00:33:05 +0530 Jassi Brar wrote: > On 25 May 2018 at 18:20, Ard Biesheuvel > wrote: > > The netsec network controller IP can drive 64 address bits for DMA, > > and the DMA mask is set accordingly in the driver. However,

Re: [PATCH net-next] vrf: add CRC32c offload to device features

2018-05-25 Thread David Miller
From: Davide Caratti Date: Thu, 24 May 2018 17:49:35 +0200 > SCTP sockets originated in a VRF can improve their performance if CRC32c > computation is delegated to underlying devices: update device features, > setting NETIF_F_SCTP_CRC. Iterating the following command in the

Re: [PATCH] PCI: allow drivers to limit the number of VFs to 0

2018-05-25 Thread Don Dutile
On 05/25/2018 10:02 AM, Bjorn Helgaas wrote: On Thu, May 24, 2018 at 06:20:15PM -0700, Jakub Kicinski wrote: Hi Bjorn! On Thu, 24 May 2018 18:57:48 -0500, Bjorn Helgaas wrote: On Mon, Apr 02, 2018 at 03:46:52PM -0700, Jakub Kicinski wrote: Some user space depends on enabling sriov_totalvfs

Re: [PATCH net] sctp: not allow to set rto_min with a value below 200 msecs

2018-05-25 Thread Neil Horman
On Sat, May 26, 2018 at 01:41:02AM +0800, Xin Long wrote: > syzbot reported a rcu_sched self-detected stall on CPU which is caused > by too small value set on rto_min with SCTP_RTOINFO sockopt. With this > value, hb_timer will get stuck there, as in its timer handler it starts > this timer again

Re: [PATCH net] selftests/net: Add missing config options for PMTU tests

2018-05-25 Thread David Miller
From: Stefano Brivio Date: Thu, 24 May 2018 16:10:12 +0200 > PMTU tests in pmtu.sh need support for VTI, VTI6 and dummy > interfaces: add them to config file. > > Reported-by: Naresh Kamboju > Fixes: d1f1b9cbf34c ("selftests: net: Introduce first

Re: [PATCH net-next] cxgb4/cxgb4vf: Notify link changes to OS-dependent code

2018-05-25 Thread David Miller
From: Ganesh Goudar Date: Thu, 24 May 2018 19:33:37 +0530 > From: Arjun Vynipadath > > We have a confusion of two different abstractions in the Common > Code: Physical Link (Port) and Logical Network Interface (Virtual > Interface), and we haven't been

Re: [PATCH] net: netsec: reduce DMA mask to 40 bits

2018-05-25 Thread Jassi Brar
On 25 May 2018 at 18:20, Ard Biesheuvel wrote: > The netsec network controller IP can drive 64 address bits for DMA, and > the DMA mask is set accordingly in the driver. However, the SynQuacer > SoC, which is the only silicon incorporating this IP at the moment, >

Re: [PATCH net-next] cxgb4: clean up init_one

2018-05-25 Thread David Miller
From: Ganesh Goudar Date: Thu, 24 May 2018 18:32:15 +0530 > clean up init_one and use chip_ver consistently throughout > init_one() for chip version. > > Signed-off-by: Casey Leedom > Signed-off-by: Ganesh Goudar Applied,

Re: [PATCH net-next v2] cxgb4/cxgb4vf: link management changes for new SFP

2018-05-25 Thread David Miller
From: Ganesh Goudar Date: Thu, 24 May 2018 17:49:30 +0530 > newer SFPs like SFP28 and QSFP28 Transceiver Modules present > several new possibilities which we haven't faced before. Fix the > assumptions in the code reflecting the more limited capabilities > of previous

Re: [PATCH 0/4] pull request for net: batman-adv 2018-05-24

2018-05-25 Thread David Miller
From: Simon Wunderlich Date: Thu, 24 May 2018 13:53:21 +0200 > here are a couple of bugfixes which we would like to have integrated into net. > > Please pull or let me know of any problem! Looks good, pulled, thanks Simon.

Re: [PATCH net-next] net: fec: remove stale comment

2018-05-25 Thread David Miller
From: YueHaibing Date: Thu, 24 May 2018 19:27:07 +0800 > This comment is outdated as fec_ptp_ioctl has been replaced by > fec_ptp_set/fec_ptp_get > since commit 1d5244d0e43b ("fec: Implement the SIOCGHWTSTAMP ioctl") > > Signed-off-by: YueHaibing

Re: [PATCH v2 net-next] sfc: stop the TX queue before pushing new buffers

2018-05-25 Thread David Miller
From: Martin Habets Date: Thu, 24 May 2018 10:14:00 +0100 > efx_enqueue_skb() can push new buffers for the xmit_more functionality. > We must stops the TX queue before this or else the TX queue does not get > restarted and we get a netdev watchdog. > > In the error

Re: [PATCH v2] ath6kl: mark expected switch fall-throughs

2018-05-25 Thread Gustavo A. R. Silva
On 05/25/2018 01:27 PM, Steve deRosier wrote: On Fri, May 25, 2018 at 11:23 AM Gustavo A. R. Silva wrote: In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. Signed-off-by: Gustavo A. R. Silva

[PATCH net-next 02/12] net: hns3: Add support for tx_accept_tag2 and tx_accept_untag2 config

2018-05-25 Thread Salil Mehta
From: Peng Li HNS3 Hardware can support up to two VLAN tags in transmit leg, the PPP module can handle the packets based on the tag1 and tag2 config. This patch adds support for tag2 config for vlan handling Signed-off-by: Peng Li Signed-off-by:

[PATCH net-next 03/12] net: hns3: Add STRP_TAGP field support for hardware revision 0x21

2018-05-25 Thread Salil Mehta
From: Peng Li Hardware Revision(0x21) Buffer Descriptor adds a field STRP_TAGP for vlan stripped processed indication. STRP_TAGP field has 2 bits, bit 0 is stripped indication of the vlan tag in outer vlan tag field, bit 1 is stripped indication of the vlan tag in inner

Re: [PATCH net-next] net:sched: add action inheritdsfield to skbmod

2018-05-25 Thread Cong Wang
On Thu, May 24, 2018 at 10:45 PM, Fu, Qiaobin wrote: > The new action inheritdsfield copies the field DS of > IPv4 and IPv6 packets into skb->priority. This enables > later classification of packets based on the DS field. Please move it to skbedit.

  1   2   3   >