[net-next:master 375/376] net/core/rtnetlink.c:3099:1: warning: the frame size of 1280 bytes is larger than 1024 bytes

2018-05-31 Thread kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git master head: 4b8e6ac41a594ea67ded6af6af5935f03221ea4c commit: ccf8dbcd062a930e64741c939ca784d15316aa0c [375/376] rtnetlink: Remove VLA usage config: um-x86_64_defconfig (attached as .config) compiler: gcc-7 (Debian

Re: [PATCH net-next] qed: Add srq core support for RoCE and iWARP

2018-05-31 Thread kbuild test robot
Hi Yuval, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/Yuval-Bason/qed-Add-srq-core-support-for-RoCE-and-iWARP/20180601-073407 reproduce: # apt-get install sparse make

[RFC PATCH] qed: qed_rdma_modify_srq() can be static

2018-05-31 Thread kbuild test robot
Fixes: 27c50d39911b ("qed: Add srq core support for RoCE and iWARP") Signed-off-by: kbuild test robot --- qed_rdma.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/net/ethernet/qlogic/qed/qed_rdma.c b/drivers/net/ethernet/qlogic/qed/qed_rdma.c

Re: [net PATCH] net-sysfs: Fix memory leak in XPS configuration

2018-05-31 Thread David Miller
From: Alexander Duyck Date: Thu, 31 May 2018 15:59:46 -0400 > This patch reorders the error cases in showing the XPS configuration so > that we hold off on memory allocation until after we have verified that we > can support XPS on a given ring. > > Fixes: 184c449f91fe ("net: Add support for

Re: [PATCH v2 net] ixgbe: fix parsing of TC actions for HW offload

2018-05-31 Thread David Miller
From: Jeff Kirsher Date: Thu, 31 May 2018 14:46:08 -0700 > On Thu, 2018-05-31 at 23:21 +0200, Ondřej Hlavatý wrote: >> The previous code was optimistic, accepting the offload of whole >> action >> chain when there was a single known action (drop/redirect). This >> results >> in offloading a rule

Re: [PATCH v2 net] mlx4_core: restore optimal ICM memory allocation

2018-05-31 Thread Qing Huang
On 5/31/2018 5:52 AM, Eric Dumazet wrote: Commit 1383cb8103bb ("mlx4_core: allocate ICM memory in page size chunks") brought two regressions caught in our regression suite. The big one is an additional cost of 256 bytes of overhead per 4096 bytes, or 6.25 % which is unacceptable since ICM

[PATCH net-next v2 2/2] qed: Fix use of incorrect shmem address.

2018-05-31 Thread Sudarsana Reddy Kalluru
Incorrect shared memory address is used while deriving the values for tc and pri_type. Use shmem address corresponding to 'oem_cfg_func' where the management firmare saves tc/pri_type values. Fixes: cac6f691 ("qed: Add support for Unified Fabric Port") Signed-off-by: Sudarsana Reddy Kalluru

[PATCH net-next v2 1/2] qed: Fix shared memory inconsistency between driver and the MFW.

2018-05-31 Thread Sudarsana Reddy Kalluru
The structure shared between driver and management firmware (MFW) differ in sizes. The additional field defined by the MFW is not relevant to the current driver. Add a dummy field to the structure. Fixes: cac6f691 ("qed: Add support for Unified Fabric Port") Signed-off-by: Sudarsana Reddy Kalluru

[PATCH net-next v2 0/2] qed: Fix issues in UFP feature commit 'cac6f691'.

2018-05-31 Thread Sudarsana Reddy Kalluru
From: Sudarsana Reddy Kalluru This patch series fixes couple of issues in the UFP feature commit, cac6f691: Add support for Unified Fabric Port. Changes from previous version: -- v2: Added "Fixes:" tag. Please consider applying it to "net-next". Sudarsana Reddy

Re: [PATCH net-next] net: phy: consider PHY_IGNORE_INTERRUPT in state machine PHY_NOLINK handling

2018-05-31 Thread David Miller
From: Heiner Kallweit Date: Wed, 30 May 2018 22:13:20 +0200 > We can bail out immediately also in case of PHY_IGNORE_INTERRUPT because > phy_mac_interupt() informs us once the link is up. > > Signed-off-by: Heiner Kallweit When state is PHY_NOLINK, the phy_mac_interrupt() code paths will

Re: [PATCH bpf-next] bpf: prevent non-IPv4 socket to be added into sock hash

2018-05-31 Thread Eric Dumazet
On Thu, May 31, 2018 at 7:32 PM John Fastabend wrote: > > > Hi Wei, > > Thanks for the report and fix. It would be better to fix the > root cause so that IPv6 works as intended. > > I'm testing the following now, > > Author: John Fastabend > Date: Thu May 31 14:38:59 2018 -0700 > >

Re: [PATCH bpf-next] xsk: temporarily disable AF_XDP

2018-05-31 Thread Björn Töpel
Den ons 30 maj 2018 kl 17:22 skrev Björn Töpel : > > From: Björn Töpel > > Temporarily disable AF_XDP sockets, and hide uapi. > [...] Alexei/Daniel, Ignore this patch, please. Thanks, Björn

Re: [PATCH net-next v2 0/2] net: phy: improve PHY suspend/resume

2018-05-31 Thread Andrew Lunn
> Configuring the different WoL options isn't handled by writing to > the PHY registers but by writing to chip / MAC registers. > Therefore phy_suspend() isn't able to figure out whether WoL is > enabled or not. Only the parent has the full picture. Hi Heiner I think you need to look at your

Re: suspicius csum initialization in vmxnet3_rx_csum

2018-05-31 Thread Neil Horman
On Thu, May 31, 2018 at 11:02:34AM -0700, Ronak Doshi wrote: > > On Wed, 30 May 2018, Paolo Abeni wrote: > > > Hi, > > > > On Thu, 2018-05-24 at 21:48 +, Guolin Yang wrote: > > > Yes, that code is not correct, we should fix that code > > > > Did you have any chance to address the issue

Re: [PATCH bpf-next] bpf: prevent non-IPv4 socket to be added into sock hash

2018-05-31 Thread John Fastabend
On 05/30/2018 02:29 PM, Wei Wang wrote: > From: Wei Wang > > Sock hash only supports IPv4 socket proto right now. > If a non-IPv4 socket gets stored in the BPF map, sk->sk_prot gets > overwritten with the v4 tcp prot. > > Syskaller reported the following related issue on an IPv6 socket: > BUG:

[PATCH net-next 2/2] selftests: forwarding: mirror_vlan: Change test description

2018-05-31 Thread Petr Machata
The test description is displayed with the PASS/FAIL resolution after the test is ran. There however already is one other test described exactly like this, which makes it unclear which of the tests passed or failed. Make the description unique. Signed-off-by: Petr Machata ---

[PATCH net-next 0/2] selftests: forwarding: mirror_vlan: Fixlets

2018-05-31 Thread Petr Machata
This patchset includes two small fixes for the tests that were introduced in commit 1bb58d2d3cbe ("Merge branch 'Mirroring-tests-involving-VLAN'"). In patch #1, a "tc action trap" is uninstalled after the suite runs, instead of being installed again. In patch #2, a test in suite is renamed to

[PATCH net-next 1/2] selftests: forwarding: mirror_vlan: Uninstall trap

2018-05-31 Thread Petr Machata
Instead of installing a trap before tests run and uninstalling it after they run, mirror_vlan.sh installs it twice due to a typo. Fix the typo. Signed-off-by: Petr Machata --- tools/testing/selftests/net/forwarding/mirror_vlan.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH v2 net] ixgbe: fix parsing of TC actions for HW offload

2018-05-31 Thread Jeff Kirsher
On Thu, 2018-05-31 at 23:21 +0200, Ondřej Hlavatý wrote: > The previous code was optimistic, accepting the offload of whole > action > chain when there was a single known action (drop/redirect). This > results > in offloading a rule which should not be offloaded, because its > behavior > cannot be

[PATCH v2 net] ixgbe: fix parsing of TC actions for HW offload

2018-05-31 Thread Ondřej Hlavatý
The previous code was optimistic, accepting the offload of whole action chain when there was a single known action (drop/redirect). This results in offloading a rule which should not be offloaded, because its behavior cannot be reproduced in the hardware. For example: $ tc filter add dev eno1

Re: [PATCH] rtnetlink: Add more well known protocol values

2018-05-31 Thread Stephen Hemminger
On Wed, 30 May 2018 08:27:32 -0400 Donald Sharp wrote: > FRRouting installs routes into the kernel associated with > the originating protocol. Add these values to the well > known values in rtnetlink.h. > > Signed-off-by: Donald Sharp > --- > v2: Fixed whitespace issues >

[PATCH] ixgbe: fix broken ipsec Rx with proper cast on spi

2018-05-31 Thread Shannon Nelson
Fix up a cast problem introduced by a sparse cleanup patch. This fixes a problem where the encrypted packets were not recognized on Rx and subsequently dropped. Fixes: 9cfbfa701b55 ("ixgbe: cleanup sparse warnings") Signed-off-by: Shannon Nelson ---

Re: [PATCH net-next v2 0/2] net: phy: improve PHY suspend/resume

2018-05-31 Thread Heiner Kallweit
On 31.05.2018 20:30, Andrew Lunn wrote: >> By the way: The problem is related to an experimental patch series for >> splitting r8169/r8168 drivers and switching r8168 to phylib. >> Therefore the change to r8168.c won't apply to existing kernel code. > > Hi Heiner > > I still think you are trying

[net PATCH] net-sysfs: Fix memory leak in XPS configuration

2018-05-31 Thread Alexander Duyck
This patch reorders the error cases in showing the XPS configuration so that we hold off on memory allocation until after we have verified that we can support XPS on a given ring. Fixes: 184c449f91fe ("net: Add support for XPS with QoS via traffic classes") Signed-off-by: Alexander Duyck ---

Re: [net] ixgbe: fix parsing of TC actions for HW offload

2018-05-31 Thread Ondřej Hlavatý
On 31.05., David Miller wrote: > From: Jeff Kirsher > Date: Wed, 30 May 2018 11:01:34 -0700 > > > From: Ondřej Hlavatý > > > > The previous code was optimistic, accepting the offload of whole action > > chain when there was a single known action (drop/redirect). This results > > in offloading

Re: [PATCH net-next] net: dsa: mv88e6xxx: Be explicit about DT or pdata

2018-05-31 Thread David Miller
From: Andrew Lunn Date: Thu, 31 May 2018 00:15:42 +0200 > Make it explicit that either device tree is used or platform data. If > neither is available, abort the probe. > > Reported-by: Dan Carpenter > Fixes: 877b7cb0b6f2 ("net: dsa: mv88e6xxx: Add minimal platform_data support") >

Re: [net] ixgbe: fix parsing of TC actions for HW offload

2018-05-31 Thread David Miller
From: Jeff Kirsher Date: Wed, 30 May 2018 11:01:34 -0700 > From: Ondřej Hlavatý > > The previous code was optimistic, accepting the offload of whole action > chain when there was a single known action (drop/redirect). This results > in offloading a rule which should not be offloaded, because

Re: [PATCH V2 mlx5-next 0/2] Mellanox, mlx5 new device events

2018-05-31 Thread David Miller
From: Saeed Mahameed Date: Wed, 30 May 2018 10:59:48 -0700 > The following series is for mlx5-next tree [1], it adds the support of two > new device events, from Ilan Tayari: > > 1. High temperature warnings. > 2. FPGA QP error event. > > In case of no objection this series will be applied to

[PATCH iproute2] configure: require libmnl

2018-05-31 Thread Stephen Hemminger
Several users of BPF and other features are trying to build without libmnl, then complaining that features don't work. The time has come to require libmnl to build iproute2. Signed-off-by: Stephen Hemminger --- configure| 20 +++- lib/libnetlink.c | 10 -- 2

Re: [PATCH] rtnetlink: Add more well known protocol values

2018-05-31 Thread David Miller
From: Donald Sharp Date: Wed, 30 May 2018 08:27:32 -0400 > FRRouting installs routes into the kernel associated with > the originating protocol. Add these values to the well > known values in rtnetlink.h. > > Signed-off-by: Donald Sharp Applied, thanks Donald.

Re: [PATCH net-next] cxgb4: Add FORCE_PAUSE bit to 32 bit port caps

2018-05-31 Thread David Miller
From: Ganesh Goudar Date: Wed, 30 May 2018 17:15:50 +0530 > Add FORCE_PAUSE bit to force local pause settings instead > of using auto negotiated values. > > Signed-off-by: Santosh Rastapur > Signed-off-by: Casey Leedom > Signed-off-by: Ganesh Goudar Applied, thank you.

Re: [PATCH net] cls_flower: Fix incorrect idr release when failing to modify rule

2018-05-31 Thread David Miller
From: Paul Blakey Date: Wed, 30 May 2018 11:29:15 +0300 > When we fail to modify a rule, we incorrectly release the idr handle > of the unmodified old rule. > > Fix that by checking if we need to release it. > > Fixes: fe2502e49b58 ("net_sched: remove cls_flower idr on failure") > Reported-by:

Re: [PATCH net-next 0/2] cls_flower: Various fixes

2018-05-31 Thread David Miller
From: Paul Blakey Date: Wed, 30 May 2018 11:17:36 +0300 > Two of the fixes are for my multiple mask patch This series doesn't apply cleanly to net-next. Please respin.

Re: [PATCH net-next v2 0/2] net: phy: improve PHY suspend/resume

2018-05-31 Thread Andrew Lunn
> By the way: The problem is related to an experimental patch series for > splitting r8169/r8168 drivers and switching r8168 to phylib. > Therefore the change to r8168.c won't apply to existing kernel code. Hi Heiner I still think you are trying to fix the wrong problem. Lets take a look at

Re: [PATCH net-next 0/5] net: aquantia: various ethtool ops implementation

2018-05-31 Thread David Miller
From: Igor Russkikh Date: Tue, 29 May 2018 15:56:57 +0300 > In this patchset Anton Mikaev and I added some useful ethtool operations: > - ring size changes > - link renegotioation > - flow control management > > The patch also improves init/deinit sequence. As noted the locking in patch #1

Re: [PATCH V2 mlx5-next 0/2] Mellanox, mlx5 new device events

2018-05-31 Thread Doug Ledford
On Wed, 2018-05-30 at 10:59 -0700, Saeed Mahameed wrote: > Hi, > > The following series is for mlx5-next tree [1], it adds the support of two > new device events, from Ilan Tayari: > > 1. High temperature warnings. > 2. FPGA QP error event. > > In case of no objection this series will be

Re: [PATCH net-next 1/1] qed*: Add link change count value to ethtool statistics display.

2018-05-31 Thread David Miller
From: Sudarsana Reddy Kalluru Date: Tue, 29 May 2018 02:31:24 -0700 > This patch adds driver changes for capturing the link change count in > ethtool statistics display. > > Please consider applying this to "net-next". > > Signed-off-by: Sudarsana Reddy Kalluru > Signed-off-by: Ariel Elior

Re: suspicius csum initialization in vmxnet3_rx_csum

2018-05-31 Thread Ronak Doshi
On Wed, 30 May 2018, Paolo Abeni wrote: > Hi, > > On Thu, 2018-05-24 at 21:48 +, Guolin Yang wrote: > > Yes, that code is not correct, we should fix that code > > Did you have any chance to address the issue and/or to give a more in- > deepth look to the change proposed in my initial

Re: [PATCH ethtool] ethtool: fix stack clash in do_get_phy_tunable and do_set_phy_tunable

2018-05-31 Thread John W. Linville
On Wed, May 09, 2018 at 02:01:46PM +0200, Michal Kubecek wrote: > Users reported stack clash detected when using --get-phy-tunable on > ppc64le. Problem is caused by local variable ds of type struct > ethtool_tunable which has last member "void *data[0]". Accessing data[0] > (as

[PATCH net-next 9/9] selftests: forwarding: mirror_gre_bridge_1d_vlan: Add STP test

2018-05-31 Thread Petr Machata
To test offloading of mirror-to-gretap in mlxsw for cases that a VLAN-unaware bridge is in underlay packet path, test that the STP status of bridge egress port is reflected. Signed-off-by: Petr Machata --- .../selftests/net/forwarding/mirror_gre_bridge_1d_vlan.sh| 12 1 file

[PATCH net-next 8/9] selftests: forwarding: mirror_gre_vlan_bridge_1q: Add more tests

2018-05-31 Thread Petr Machata
Offloading of mirror-to-gretap in mlxsw is tricky especially in cases when the gretap underlay involves bridges. Add more tests that exercise the bridge handling code: - forbidden_egress tests that check vlan removal on bridge port in the underlay packet path - untagged_egress tests that

Re: [pull request][net-next 0/7] Mellanox, mlx5e & FPGA updates 2018-05-29

2018-05-31 Thread David Miller
From: Saeed Mahameed Date: Tue, 29 May 2018 17:46:43 -0700 > The following series includes some minor FPGA and mlx5e netdev updates, > for more information please see tag log below. > > Please pull and let me know if there's any problem. > > Note: This series doesn't include nor require any

[PATCH net-next 7/9] selftests: forwarding: mirror_gre_vlan_bridge_1q: Rename two tests

2018-05-31 Thread Petr Machata
Rename test_gretap_forbidden() and test_ip6gretap_forbidden() to a more specific test_gretap_forbidden_cpu() and test_ip6gretap_forbidden_cpu(). This will make it clearer which is which when further down a patch is introduced that forbids a VLAN on regular bridge port. Signed-off-by: Petr Machata

[PATCH net-next 6/9] selftests: forwarding: mirror_gre_vlan_bridge_1q: Test final config

2018-05-31 Thread Petr Machata
After the final change reestablishes the original configuration, make sure the traffic flows again as it should. Signed-off-by: Petr Machata --- tools/testing/selftests/net/forwarding/mirror_gre_vlan_bridge_1q.sh | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git

[PATCH net-next 5/9] selftests: forwarding: mirror_gre_vlan_bridge_1q: Fix tunnel name

2018-05-31 Thread Petr Machata
The "ip6gretap" in the test name refers to the tunnel device type that the test is supposed to be testing. However test_ip6gretap_forbidden() tests, due to a typo, a gretap tunnel. Fix the typo. Signed-off-by: Petr Machata --- tools/testing/selftests/net/forwarding/mirror_gre_vlan_bridge_1q.sh

[PATCH net-next 0/9] Test mirror-to-gretap with bridge in UL

2018-05-31 Thread Petr Machata
This patchset adds more tests to the mirror-to-gretap suite where bridge is present in the underlay. Specifically it adds tests for bridge VLAN handling, FDB, and bridge port STP status. In patches #1-#3, the codebase is refactored to support the new tests. In patch #4, an STP test is added to

[PATCH net-next 4/9] selftests: forwarding: mirror_gre_lib: Add STP test

2018-05-31 Thread Petr Machata
Add a reusable full test that toggles STP state of a given bridge port and checks that the mirroring reacts appropriately. The test will be used by bridge tests in follow-up patches. Signed-off-by: Petr Machata --- .../selftests/net/forwarding/mirror_gre_lib.sh | 32 ++

[PATCH net-next 3/9] selftests: forwarding: mirror_lib: skip_hw the VLAN capture

2018-05-31 Thread Petr Machata
When the VLAN capture is installed on a front panel device and not a soft device, the packets are counted twice: once in fast path, and once after they are trapped to the kernel. Resolve the problem by passing skip_hw flag to vlan_capture_install(). Signed-off-by: Petr Machata ---

[PATCH net-next 2/9] selftests: forwarding: mirror_lib: Move here do_test_span_vlan_dir_ips()

2018-05-31 Thread Petr Machata
Move the function do_test_span_vlan_dir_ips() from mirror_vlan.sh test to a library file mirror_lib.sh to allow reuse. Fill in other entry points similar to other testing functions in mirror_lib.sh, they will be useful in following patches. Signed-off-by: Petr Machata ---

[PATCH net-next 1/9] selftests: forwarding: lib: Move here vlan_capture_{,un}install()

2018-05-31 Thread Petr Machata
Move vlan_capture_install() and vlan_capture_uninstall() from mirror_vlan.sh test to lib.sh so that it can be reused in other tests. Signed-off-by: Petr Machata --- tools/testing/selftests/net/forwarding/lib.sh | 23 ++ .../selftests/net/forwarding/mirror_vlan.sh

Re: [PATCH net-next] qed: Add srq core support for RoCE and iWARP

2018-05-31 Thread Leon Romanovsky
On Wed, May 30, 2018 at 04:11:37PM +0300, Yuval Bason wrote: > This patch adds support for configuring SRQ and provides the necessary > APIs for rdma upper layer driver (qedr) to enable the SRQ feature. > > Signed-off-by: Michal Kalderon > Signed-off-by: Ariel Elior > Signed-off-by: Yuval Bason

Re: [PATCH 1/2 net-next] net_failover: fix net_failover_compute_features()

2018-05-31 Thread Samudrala, Sridhar
On 5/31/2018 5:01 AM, Dan Carpenter wrote: This has an '&' vs '|' typo so it starts with vlan_features set to none. Also a u32 type isn't large enough to hold all the feature bits, it should be netdev_features_t. Fixes: cfc80d9a1163 ("net: Introduce net_failover driver") Signed-off-by: Dan

Re: [PATCH v2 net-next] net: remove bypassed check in sch_direct_xmit()

2018-05-31 Thread David Miller
From: Song Liu Date: Tue, 29 May 2018 10:03:21 -0700 > Checking netif_xmit_frozen_or_stopped() at the end of sch_direct_xmit() > is being bypassed. This is because "ret" from sch_direct_xmit() will be > either NETDEV_TX_OK or NETDEV_TX_BUSY, and only ret == NETDEV_TX_OK == 0 > will reach the

Re: [PATCH 2/2 net-next] net_failover: fix error code in net_failover_create()

2018-05-31 Thread Samudrala, Sridhar
On 5/31/2018 5:04 AM, Dan Carpenter wrote: We forgot to set the error code on this path. This function is supposed to return error pointers, so with this bug it accidentally returns NULL and the caller doesn't check for that. Fixes: cfc80d9a1163 ("net: Introduce net_failover driver")

Re: [PATCH rdma-next v3 10/14] IB/uverbs: Add support for flow counters

2018-05-31 Thread Leon Romanovsky
On Thu, May 31, 2018 at 02:49:44PM +, Ruhl, Michael J wrote: > >-Original Message- > >From: Leon Romanovsky [mailto:l...@kernel.org] > >Sent: Thursday, May 31, 2018 9:44 AM > >To: Doug Ledford ; Jason Gunthorpe > > > >Cc: Leon Romanovsky ; RDMA mailing list >r...@vger.kernel.org>;

[PATCH v3 net-next] net: stmmac: Add Flexible PPS support

2018-05-31 Thread Jose Abreu
This adds support for Flexible PPS output (which is equivalent to per_out output of PTP subsystem). Tested using an oscilloscope and the following commands: 1) Start PTP4L: # ptp4l -A -4 -H -m -i eth0 & 2) Set Flexible PPS frequency: # echo > /sys/class/ptp/ptpX/period

Re: [bpf-next V2 PATCH 7/8] bpf/xdp: non-map redirect can avoid calling ndo_xdp_flush

2018-05-31 Thread Song Liu
On Thu, May 31, 2018 at 2:00 AM, Jesper Dangaard Brouer wrote: > This is the first real user of the XDP_XMIT_FLUSH flag. > > As pointed out many times, XDP_REDIRECT without using BPF maps is > significant slower than the map variant. This is primary due to the > lack of bulking, as the

Re: [bpf-next V2 PATCH 6/8] xdp: done implementing ndo_xdp_xmit flush flag for all drivers

2018-05-31 Thread Song Liu
On Thu, May 31, 2018 at 2:00 AM, Jesper Dangaard Brouer wrote: > Removing XDP_XMIT_FLAGS_NONE as all driver now implement > a flush operation in their ndo_xdp_xmit call. The compiler > will catch if any users of XDP_XMIT_FLAGS_NONE remains. > > Signed-off-by: Jesper Dangaard Brouer Acked-by:

Re: [PATCH rdma-next v3 00/14] Verbs flow counters support

2018-05-31 Thread Yishai Hadas
On 5/31/2018 4:43 PM, Leon Romanovsky wrote: From: Leon Romanovsky Changelog: v2->v3: * Change function mlx5_fc_query signature to hide the details of internal core driver struct mlx5_fc * Add commen to data[] field at struct mlx5_ib_flow_counters_data (mlx5-abi.h) * Use array of

[PATCH net-next 3/3] selftests/net: add packet socket packet_snd test

2018-05-31 Thread Willem de Bruijn
From: Willem de Bruijn Add regression tests for PF_PACKET transmission using packet_snd. The TPACKET ring interface has tests for transmission and reception. This is an initial stab at the same for the send call based interface. Packets are sent over loopback, then read twice. The entire

Re: [bpf-next V2 PATCH 5/8] virtio_net: implement flush flag for ndo_xdp_xmit

2018-05-31 Thread Song Liu
On Thu, May 31, 2018 at 2:00 AM, Jesper Dangaard Brouer wrote: > When passed the XDP_XMIT_FLUSH flag virtnet_xdp_xmit now performs the > same virtqueue_kick as virtnet_xdp_flush. > > Signed-off-by: Jesper Dangaard Brouer Acked-by: Song Liu > --- > drivers/net/virtio_net.c |6 +- > 1

Re: [bpf-next V2 PATCH 4/8] tun: implement flush flag for ndo_xdp_xmit

2018-05-31 Thread Song Liu
On Thu, May 31, 2018 at 2:00 AM, Jesper Dangaard Brouer wrote: > When passed the XDP_XMIT_FLUSH flag tun_xdp_xmit now performs the same > kind of socket wake up as in tun_xdp_flush(). The wake up code from > tun_xdp_flush is generalized and shared with tun_xdp_xmit. > > Signed-off-by: Jesper

[PATCH net-next 1/3] selftests/net: enable msg_zerocopy test

2018-05-31 Thread Willem de Bruijn
From: Willem de Bruijn The existing msg_zerocopy test takes additional protocol arguments. Add a variant that takes no arguments and runs all supported variants. Call this from kselftest. Signed-off-by: Willem de Bruijn --- tools/testing/selftests/net/Makefile| 2 +-

[PATCH net-next 0/3] selftests/net: various

2018-05-31 Thread Willem de Bruijn
From: Willem de Bruijn A few odds and ends to network tests: - msg_zerocopy: run as part of kselftest - udp gso: add missing bounds test for minimal sizes - psocket_snd: initial basic conformance test Willem de Bruijn (3): selftests/net: enable msg_zerocopy test selftests/net:

[PATCH net-next 2/3] selftests/net: udpgso: test small gso_size boundary conditions

2018-05-31 Thread Willem de Bruijn
From: Willem de Bruijn Verify that udpgso can generate segments smaller than device mtu, down to the extreme case of 1B gso_size. Verify that irrespective of gso_size, udpgso restricts the number of segments it will generate per call (UDP_MAX_SEGMENTS). Signed-off-by: Willem de Bruijn ---

Re: [bpf-next V2 PATCH 3/8] ixgbe: implement flush flag for ndo_xdp_xmit

2018-05-31 Thread Song Liu
On Thu, May 31, 2018 at 1:59 AM, Jesper Dangaard Brouer wrote: > When passed the XDP_XMIT_FLUSH flag ixgbe_xdp_xmit now performs the > same kind of ring tail update as in ixgbe_xdp_flush. The update tail > code in ixgbe_xdp_flush is generalized and shared with ixgbe_xdp_xmit. > > Signed-off-by:

Re: [bpf-next V2 PATCH 8/8] bpf/xdp: devmap can avoid calling ndo_xdp_flush

2018-05-31 Thread Song Liu
On Thu, May 31, 2018 at 2:00 AM, Jesper Dangaard Brouer wrote: > The XDP_REDIRECT map devmap can avoid using ndo_xdp_flush, by instead > instructing ndo_xdp_xmit to flush via XDP_XMIT_FLUSH flag in > appropriate places. > > Notice after this patch it is possible to remove ndo_xdp_flush >

Re: [PATCH net-next v2 0/2] net: phy: improve PHY suspend/resume

2018-05-31 Thread Heiner Kallweit
On 30.05.2018 22:35, Andrew Lunn wrote: >> I think we need a better solution than spending the effort needed >> to make the MDIO ops runtime-pm-aware. In general there seems to be >> just one network driver using both phylib and runtime pm, so most >> drivers aren't affected (yet). >> >> I will

Re: [PATCH iproute2] ip: IFLA_NEW_NETNSID/IFLA_NEW_IFINDEX support

2018-05-31 Thread Nicolas Dichtel
Le 31/05/2018 à 17:46, Stephen Hemminger a écrit : > On Thu, 31 May 2018 16:28:48 +0200 [snip] > This makes sense. All of linkinfo that is present should be displayed. > > Both netns and ifindex are really unsigned values. Use __u32 and print_uint. Ok. > Also why not convert numeric values to

Re: [PATCH iproute2] ip: IFLA_NEW_NETNSID/IFLA_NEW_IFINDEX support

2018-05-31 Thread Stephen Hemminger
On Thu, 31 May 2018 16:28:48 +0200 Nicolas Dichtel wrote: > Parse and display those attributes. > Example: > ip l a type dummy > ip netns add foo > ip monitor link& > ip l s dummy1 netns foo > Deleted 6: dummy1: mtu 1500 qdisc noop state DOWN group > default > link/ether 66:af:3a:3f:a0:89

Re: [PATCH 0/4] RFC CPSW switchdev mode

2018-05-31 Thread Ilias Apalodimas
Sorry for the late response i had some time to take another look and do some extra testing > switchdev is about offloading what Linux can do to hardware to > accelerate it. The switch is a block of accelerator hardware, like a > GPU is for accelerating graphics. Linux can render OpenGL, but it is

Re: [PATCH rdma-next v3 08/14] IB/core: Support passing uhw for create_flow

2018-05-31 Thread Yishai Hadas
On 5/31/2018 5:42 PM, Ruhl, Michael J wrote: -Original Message- From: Leon Romanovsky [mailto:l...@kernel.org] Sent: Thursday, May 31, 2018 9:44 AM To: Doug Ledford ; Jason Gunthorpe Cc: Leon Romanovsky ; RDMA mailing list ; Boris Pismenny ; Matan Barak ; Ruhl, Michael J ; Or Gerlitz ;

[PATCH net-next 2/2] qed: Fix use of incorrect shmem address.

2018-05-31 Thread Sudarsana Reddy Kalluru
Incorrect shared memory address is used while deriving the values for tc and pri_type. Use shmem address corresponding to 'oem_cfg_func' where the management firmare saves tc/pri_type values. Signed-off-by: Sudarsana Reddy Kalluru Signed-off-by: Ariel Elior ---

[PATCH net-next 0/2] qed: Fix issues in UFP feature commit 'cac6f691'.

2018-05-31 Thread Sudarsana Reddy Kalluru
From: Sudarsana Reddy Kalluru This patch series fixes couple of issues in the UFP feature commit, cac6f691: Add support for Unified Fabric Port. Please consider applying it to "net-next". Sudarsana Reddy Kalluru (2): qed: Fix shared memory inconsistency between driver and the MFW. qed:

[PATCH net-next 1/2] qed: Fix shared memory inconsistency between driver and the MFW.

2018-05-31 Thread Sudarsana Reddy Kalluru
The structure shared between driver and management firmware (MFW) differ in sizes. The additional field defined by the MFW is not relevant to the current driver. Add a dummy field to the structure. Signed-off-by: Sudarsana Reddy Kalluru Signed-off-by: Ariel Elior ---

RE: [PATCH rdma-next v3 10/14] IB/uverbs: Add support for flow counters

2018-05-31 Thread Ruhl, Michael J
>-Original Message- >From: Leon Romanovsky [mailto:l...@kernel.org] >Sent: Thursday, May 31, 2018 9:44 AM >To: Doug Ledford ; Jason Gunthorpe > >Cc: Leon Romanovsky ; RDMA mailing list r...@vger.kernel.org>; Boris Pismenny ; Matan >Barak ; Ruhl, Michael J ; >Or Gerlitz ; Raed Salem ;

RE: [PATCH rdma-next v3 08/14] IB/core: Support passing uhw for create_flow

2018-05-31 Thread Ruhl, Michael J
>-Original Message- >From: Leon Romanovsky [mailto:l...@kernel.org] >Sent: Thursday, May 31, 2018 9:44 AM >To: Doug Ledford ; Jason Gunthorpe > >Cc: Leon Romanovsky ; RDMA mailing list r...@vger.kernel.org>; Boris Pismenny ; Matan >Barak ; Ruhl, Michael J ; >Or Gerlitz ; Raed Salem ;

Re: [PATCH iproute2] ip: IFLA_NEW_NETNSID/IFLA_NEW_IFINDEX support

2018-05-31 Thread Nicolas Dichtel
Oops, I use an old email for Stephen, sorry. Regards, Nicolas Le 31/05/2018 à 16:28, Nicolas Dichtel a écrit : > Parse and display those attributes. > Example: > ip l a type dummy > ip netns add foo > ip monitor link& > ip l s dummy1 netns foo > Deleted 6: dummy1: mtu 1500 qdisc noop state

[PATCH iproute2] ip: IFLA_NEW_NETNSID/IFLA_NEW_IFINDEX support

2018-05-31 Thread Nicolas Dichtel
Parse and display those attributes. Example: ip l a type dummy ip netns add foo ip monitor link& ip l s dummy1 netns foo Deleted 6: dummy1: mtu 1500 qdisc noop state DOWN group default link/ether 66:af:3a:3f:a0:89 brd ff:ff:ff:ff:ff:ff new-nsid 0 new-ifindex 6 Signed-off-by: Nicolas Dichtel

[PATCH] net: virtio: simplify the virtnet_find_vqs

2018-05-31 Thread Tonghao Zhang
Use the common free functions while return successfully. Signed-off-by: Tonghao Zhang --- drivers/net/virtio_net.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c index 8f08a3e..0eee6d6 100644 ---

Re: [PATCH v2] net: dsa: b53: Add BCM5389 support

2018-05-31 Thread Florian Fainelli
On 05/31/2018 12:04 AM, Damien Thébault wrote: > This patch adds support for the BCM5389 switch connected through MDIO. > > Signed-off-by: Damien Thébault Looks great, thanks Damien. Reviewed-by: Florian Fainelli -- Florian

Re: [PATCH net-next] net: dsa: mv88e6xxx: Be explicit about DT or pdata

2018-05-31 Thread Florian Fainelli
On 05/30/2018 03:15 PM, Andrew Lunn wrote: > Make it explicit that either device tree is used or platform data. If > neither is available, abort the probe. > > Reported-by: Dan Carpenter > Fixes: 877b7cb0b6f2 ("net: dsa: mv88e6xxx: Add minimal platform_data support") > Signed-off-by: Andrew

Re: [PATCH v4 net-next 00/19] inet: frags: bring rhashtables to IP defrag

2018-05-31 Thread Eric Dumazet
On Thu, May 31, 2018 at 8:18 AM Moshe Shemesh wrote: > > > > I do see big improvement after changing the 3 parameters as Eric suggested: > /proc/sys/net/ipv6/ip6frag_time set to 2 > /proc/sys/net/ipv6/ip6frag_low_thresh set to 104857600 > /proc/sys/net/ipv6/ip6frag_high_thresh set to 78643200 >

Re: [PATCH net-next] net: dsa: mv88e6xxx: Be explicit about DT or pdata

2018-05-31 Thread Vivien Didelot
Andrew Lunn writes: > Make it explicit that either device tree is used or platform data. If > neither is available, abort the probe. > > Reported-by: Dan Carpenter > Fixes: 877b7cb0b6f2 ("net: dsa: mv88e6xxx: Add minimal platform_data support") > Signed-off-by: Andrew Lunn Reviewed-by:

[PATCH rdma-next v3 07/14] IB/uverbs: Add read counters support

2018-05-31 Thread Leon Romanovsky
From: Raed Salem This patch exposes the read counters verb to user space applications. By that verb the user can read the hardware counters which are associated with the counters object. The application needs to provide a sufficient memory to hold the statistics. Reviewed-by: Yishai Hadas

[PATCH mlx5-next v3 02/14] net/mlx5: Use flow counter pointer as input to the query function

2018-05-31 Thread Leon Romanovsky
From: Or Gerlitz This allows to un-expose the details of struct mlx5_fc and keep it internal to the core driver as it used to be. Signed-off-by: Or Gerlitz Signed-off-by: Leon Romanovsky --- drivers/net/ethernet/mellanox/mlx5/core/eswitch.c | 15 ++-

[PATCH rdma-next v3 09/14] IB/core: Add support for flow counters

2018-05-31 Thread Leon Romanovsky
From: Raed Salem A counters object could be attached to flow on creation by providing the counter specification action. General counters description which count packets and bytes are introduced, downstream patches from this series will use them as part of flow counters binding. In addition,

[PATCH mlx5-next v3 03/14] net/mlx5: Export flow counter related API

2018-05-31 Thread Leon Romanovsky
From: Raed Salem Exports counters API to be used in both IB and EN. Reviewed-by: Yishai Hadas Signed-off-by: Raed Salem Signed-off-by: Leon Romanovsky --- drivers/net/ethernet/mellanox/mlx5/core/fs_core.h | 2 -- drivers/net/ethernet/mellanox/mlx5/core/fs_counters.c | 3 +++

[PATCH mlx5-next v3 12/14] IB/mlx5: Add flow counters binding support

2018-05-31 Thread Leon Romanovsky
From: Raed Salem Associates a counters with a flow when IB_FLOW_SPEC_ACTION_COUNT is part of the flow specifications. The counters user space placements of location and description (index, description) pairs are passed as private data of the counters flow specification. Reviewed-by: Yishai

[PATCH rdma-next v3 14/14] IB/mlx5: Add counters read support

2018-05-31 Thread Leon Romanovsky
From: Raed Salem This patch implements the uverbs counters read API, it will use the specific read counters function to the given type to accomplish its task. Reviewed-by: Yishai Hadas Signed-off-by: Raed Salem Signed-off-by: Leon Romanovsky --- drivers/infiniband/hw/mlx5/main.c | 43

[PATCH rdma-next v3 11/14] IB/mlx5: Add counters create and destroy support

2018-05-31 Thread Leon Romanovsky
From: Raed Salem This patch implements the device counters create and destroy APIs and introducing some internal management structures. Downstream patches in this series will add the functionality to support flow counters binding and reading. Reviewed-by: Yishai Hadas Signed-off-by: Raed

[PATCH rdma-next v3 13/14] IB/mlx5: Add flow counters read support

2018-05-31 Thread Leon Romanovsky
From: Raed Salem Implements the flow counters read wrapper. Reviewed-by: Yishai Hadas Signed-off-by: Raed Salem Signed-off-by: Leon Romanovsky --- drivers/infiniband/hw/mlx5/main.c| 15 +++ drivers/infiniband/hw/mlx5/mlx5_ib.h | 13 - 2 files changed, 27

[PATCH rdma-next v3 10/14] IB/uverbs: Add support for flow counters

2018-05-31 Thread Leon Romanovsky
From: Raed Salem The struct ib_uverbs_flow_spec_action_count associates a counters object with the flow. Post this association the flow counters can be read via the counters object. Reviewed-by: Yishai Hadas Signed-off-by: Raed Salem Signed-off-by: Leon Romanovsky ---

[PATCH rdma-next v3 08/14] IB/core: Support passing uhw for create_flow

2018-05-31 Thread Leon Romanovsky
From: Matan Barak This is required when user-space drivers need to pass extra information regarding how to handle this flow steering specification. Reviewed-by: Yishai Hadas Signed-off-by: Matan Barak Signed-off-by: Boris Pismenny Signed-off-by: Leon Romanovsky ---

[PATCH rdma-next v3 06/14] IB/core: Introduce counters read verb

2018-05-31 Thread Leon Romanovsky
From: Raed Salem The user supplies counters instance and a reference to an output array of uint64_t. The driver reads the hardware counters values and writes them to the output index location in the user supplied array. All counters values are represented as uint64_t types. To be able to

[PATCH rdma-next v3 05/14] IB/uverbs: Add create/destroy counters support

2018-05-31 Thread Leon Romanovsky
From: Raed Salem User space application which uses counters functionality, is expected to allocate/release the counters resources by calling create/destroy verbs and in turn get a unique handle that can be used to attach the counters to its counted type. Reviewed-by: Yishai Hadas

[PATCH rdma-next v3 04/14] IB/core: Introduce counters object and its create/destroy

2018-05-31 Thread Leon Romanovsky
From: Raed Salem A verbs application may need to get statistics and info on various aspects of a verb object (e.g. Flow, QP, ...), in general case the application will state which object's counters its interested in (we refer to this action as attach), bind this new counters object to the

[PATCH rdma-next v3 01/14] IB/uverbs: Add an ib_uobject getter to ioctl() infrastructure

2018-05-31 Thread Leon Romanovsky
From: Matan Barak Previously, the user had to dig inside the attribute to get the uobject. Add a helper function that correctly extract it (and do the required checks) for him/her. Signed-off-by: Matan Barak Reviewed-by: Michael J. Ruhl Signed-off-by: Leon Romanovsky ---

[PATCH rdma-next v3 00/14] Verbs flow counters support

2018-05-31 Thread Leon Romanovsky
From: Leon Romanovsky Changelog: v2->v3: * Change function mlx5_fc_query signature to hide the details of internal core driver struct mlx5_fc * Add commen to data[] field at struct mlx5_ib_flow_counters_data (mlx5-abi.h) * Use array of struct mlx5_ib_flow_counters_desc to clarify the

[PATCH v2 net] mlx4_core: restore optimal ICM memory allocation

2018-05-31 Thread Eric Dumazet
Commit 1383cb8103bb ("mlx4_core: allocate ICM memory in page size chunks") brought two regressions caught in our regression suite. The big one is an additional cost of 256 bytes of overhead per 4096 bytes, or 6.25 % which is unacceptable since ICM can be pretty large. This comes from having to

  1   2   >