From: Arjun Vynipadath
Date: Wed, 25 Jul 2018 19:39:52 +0530
> Break statements were missing for Geneve case in
> ndo_udp_tunnel_{add/del}, thereby raw mac matchall
> entries were not getting added.
>
> Fixes: c746fc0e8b2d("cxgb4: add geneve offload support for T6")
> Signed-off-by: Arjun
From: Jakub Kicinski
Date: Wed, 25 Jul 2018 15:39:27 -0700
> Devlink resources registered with devlink_resource_register() have
> to be unregistered.
>
> Fixes: 37923ed6b8ce ("netdevsim: Add simple FIB resource controller via
> devlink")
> Signed-off-by: Jakub Kicinski
> Reviewed-by: Quentin
From: Jakub Kicinski
Date: Wed, 25 Jul 2018 19:40:33 -0700
> This small set changes the handling of pci_sriov_set_totalvfs() errors.
> nfp is the only driver which fails probe on pci_sriov_set_totalvfs()
> errors. It turns out some BIOS configurations may break SR-IOV and
> users who don't use
On Wed, Jul 25, 2018 at 08:35:17AM -0600, Jason Gunthorpe wrote:
> On Wed, Jul 25, 2018 at 08:37:03AM +0300, Leon Romanovsky wrote:
>
> > > Also, I would like to keep the specs consistently formatted according
> > > to clang-format with 'BinPackParameters: true', so I reflowed them as
> > > well.
Port id 0x is reserved for control messages. Allow reception
of messages with this id on data queues. Hand off a raw buffer to
the higher layer code, without allocating SKB for max efficiency.
The RX handle can't modify or keep the buffer, after it returns
buffer is handed back over to
Representor packets are received on PF queues with special metadata tag
for demux. There is no reason to resolve the representor ID -> netdev
after the skb has been allocated. Move the code, this will allow us to
handle special FW messages without SKB allocation overhead.
Signed-off-by: Jakub
In preparation for SKB-less perf event handling make
nfp_bpf_event_output() take buffer address and length,
not SKB as parameters.
Signed-off-by: Jakub Kicinski
Reviewed-by: Dirk van der Merwe
Reviewed-by: Quentin Monnet
---
drivers/net/ethernet/netronome/nfp/bpf/cmsg.c | 5 -
Record perf maps by map ID, not raw kernel pointer. This helps
with debug messages, because printing pointers to logs is frowned
upon, and makes debug easier for the users, as map ID is something
they should be more familiar with. Note that perf maps are offload
neutral, therefore IDs won't be
Control queue is fairly low latency, and requires SKB allocations,
which means we can't even reach 0.5Msps with perf events. Allow
perf events to be delivered to data queues. This allows us to not
only use multiple queues, but also receive and deliver to user space
more than 5Msps per queue
Hi!
This set is focused on improving the performance of perf events
reported from BPF offload. Perf events can now be received on
packet data queues, which significantly improves the performance
(from total of 0.5 Msps to 5Msps per core). To get to this
performance we need a fast path for
FW can put constraints on map element size to maximize resource
use and efficiency. When user attempts offload of a map which
does not fit into those constraints an informational message is
printed to kernel logs to inform user about the reason offload
failed. Map offload does not have access to
Commit 7f1c684a8966 ("nfp: setup xdp_rxq_info") mixed the cache
cold and cache hot data in the nfp_net_rx_ring structure (ignoring
the feedback), to try to fit the structure into 2 cache lines
after struct xdp_rxq_info was added. Now that we are about to add
a new field the structure will grow
Hi!
This small set changes the handling of pci_sriov_set_totalvfs() errors.
nfp is the only driver which fails probe on pci_sriov_set_totalvfs()
errors. It turns out some BIOS configurations may break SR-IOV and
users who don't use that feature should not suffer.
Remaining patches makes sure we
Use kvcalloc() instead of tmp variable + kzalloc() when allocating
SW buffer information to allow falling back to vmalloc and to protect
from theoretical integer overflow.
Signed-off-by: Jakub Kicinski
Reviewed-by: Dirk van der Merwe
---
.../net/ethernet/netronome/nfp/nfp_net_common.c | 16
On machines with buggy ACPI tables or when SR-IOV is already enabled
we may not be able to set the SR-IOV VF limit in sysfs, it's not fatal
because the limit is imposed by the driver anyway. Only the sysfs
'sriov_totalvfs' attribute will be too high. Print an error to inform
user about the
Use array_size() and store the size as full size_t to protect from
theoretical size overflow when handling HW descriptor rings.
Signed-off-by: Jakub Kicinski
Reviewed-by: Dirk van der Merwe
---
drivers/net/ethernet/netronome/nfp/nfp_net.h| 4 ++--
On Thu, 26 Jul 2018 00:09:50 +0900, Taehee Yoo wrote:
> rhashtable_lookup() can return NULL. so that NULL pointer
> check routine should be added.
>
> Fixes: 02b55e5657c3 ("xdp: add MEM_TYPE_ZERO_COPY")
> Signed-off-by: Taehee Yoo
> ---
> V2 : add WARN_ON_ONCE when xa is NULL.
>
>
David,
To narrow down on the issue, I've been requested by our kernel team for the
following information:
"Can you clarify what kernel configuration was used for the clean 4.14.52
kernel (no changes)
The kernel configuration may be available in /proc/config.gz, or it might be
available as a
On Wed, 25 Jul 2018 08:23:26 -0700, Alexander Duyck wrote:
> On Wed, Jul 25, 2018 at 5:31 AM, Eran Ben Elisha wrote:
> > On 7/24/2018 10:51 PM, Jakub Kicinski wrote:
> The devlink params haven't been upstream even for a full cycle and
> already you guys are starting to use them to
On 07/26/2018 12:08 AM, Arthur Fabre wrote:
> When check_alu_op() handles a BPF_MOV between two registers,
> it calls check_reg_arg() on the dst register, marking it as unbounded.
> If the src and dst register are the same, this marks the src as
> unbounded, which can lead to unexpected errors for
David,
I tried out the commands on an Ubuntu 17.10.1 VM.
The pings on test-vrf are successful, but the pings on br0 are not successful.
# uname -rv
4.13.0-21-generic #24-Ubuntu SMP Mon Dec 18 17:29:16 UTC 2017
# lsb_release -a
No LSB modules are available.
Distributor ID: Ubuntu
The seg6local LWT provides the End.DT6 action, which allows to
decapsulate an outer IPv6 header containing a Segment Routing Header
(SRH), full specification is available here:
https://tools.ietf.org/html/draft-filsfils-spring-srv6-network-programming-05
This patch adds this action now to the
Are we ok with all the BBR patches for 816 (i.e. we did extensive testing?).
On Wed, Jul 25, 2018 at 3:58 PM kernel-commit-validator (Code Review) <
prodkernel-gerrit-comm...@google.com> wrote:
> GA release commit message is missing a Release-Commit: tag indicating the
> original SHA1.
>
>
>
From: Ido Schimmel
Date: Wed, 25 Jul 2018 09:23:49 +0300
> The Spectrum-2 ASIC uses an algorithmic TCAM (A-TCAM) where multiple
> exact matches lookups are performed instead of a single lookup as with
> standard circuit TCAM (C-TCAM) memory. This allows for higher scale and
> reduced power
2018-07-25 23:13 GMT+02:00 Martin KaFai Lau :
>> v2: - changed true/false -> 1/0
> hmmm...I thought I was asking to replace 1/0 with true/false. More
> below.
Silly me, I read your indication backwards. Agreed.
@Daniel: sorry for this one, sending a v3.
From: Wei Yongjun
Date: Wed, 25 Jul 2018 06:06:13 +
> Fixes the following sparse warnings:
>
> net/ipv4/igmp.c:1391:6: warning:
> symbol '__ip_mc_inc_group' was not declared. Should it be static?
>
> Signed-off-by: Wei Yongjun
Applied to 'net'.
From: Wei Yongjun
Date: Wed, 25 Jul 2018 06:11:16 +
> Fixes the following sparse warning:
>
> drivers/net/ethernet/microchip/lan743x_main.c:2944:25: warning:
> symbol 'lan743x_pm_ops' was not declared. Should it be static?
>
> Signed-off-by: Wei Yongjun
Applied.
From: Wei Yongjun
Date: Wed, 25 Jul 2018 06:06:07 +
> Fixes the following sparse warnings:
>
> net/ipv4/tcp_timer.c:25:5: warning:
> symbol 'tcp_retransmit_stamp' was not declared. Should it be static?
>
> Signed-off-by: Wei Yongjun
Applied, thank you.
From: Jianbo Liu
Date: Wed, 25 Jul 2018 02:31:25 +
> This fixes the following sparse warning:
>
> net/sched/cls_flower.c:1356:36: warning: incorrect type in argument 3
> (different base types)
> net/sched/cls_flower.c:1356:36: expected unsigned short [unsigned] [usertype]
> value
>
From: Tariq Toukan
Date: Tue, 24 Jul 2018 14:31:45 +0300
> Allow obtaining MTTs starting at any index,
> thus give a better cache utilization.
>
> For this, allow setting log_mtts_per_seg to 0, and use
> this in default.
>
> Signed-off-by: Tariq Toukan
> Signed-off-by: Eli Cohen
>
From: Or Gerlitz
Date: Tue, 24 Jul 2018 13:59:32 +0300
> This series enables mlx5 offloading of tc eswitch rules that set
> tos/ttl (encap) or match on them (decap) for tunnels.
Series applied, thanks.
From: Marc Kleine-Budde
Date: Tue, 24 Jul 2018 09:27:30 +0200
> Thanks David. Can you please merge net into next-next, as I've some
> patches for net-next that would result in a merge conflict between net
> and net-next later.
This has now been done.
From: Neal Cardwell
Date: Tue, 24 Jul 2018 21:57:27 -0400
> On Tue, Jul 24, 2018 at 1:42 PM Lawrence Brakmo wrote:
>>
>> Note that without this fix the 99% latencies when doing 10KB RPCs
>> in a congested network using DCTCP are 40ms vs. 190us with the patch.
>> Also note that these 40ms high
Devlink resources registered with devlink_resource_register() have
to be unregistered.
Fixes: 37923ed6b8ce ("netdevsim: Add simple FIB resource controller via
devlink")
Signed-off-by: Jakub Kicinski
Reviewed-by: Quentin Monnet
---
drivers/net/netdevsim/devlink.c | 1 +
1 file changed, 1
It's possible to insert an SA into the SADB that will
preclude the lookup of other SAs when using the MARK
attribute. The problem occurs based on a particular
sequencing with the marks where a new mark matches
requests for the SA mark of an existing SA but the
inverse is not true. For an example:
When check_alu_op() handles a BPF_MOV between two registers,
it calls check_reg_arg() on the dst register, marking it as unbounded.
If the src and dst register are the same, this marks the src as
unbounded, which can lead to unexpected errors for further checks that
rely on bounds info.
On Wed, 2018-07-25 at 14:52 -0500, Bjorn Helgaas wrote:
> From: Bjorn Helgaas
>
> The igb driver doesn't need anything provided by pci-aspm.h, so
> remove
> the unnecessary include of it.
>
> Signed-off-by: Bjorn Helgaas
Acked-by: Jeff Kirsher
I am fine with you picking up this change.
>
The zerocopy path ultimately calls iov_iter_get_pages, which defines the
step function for ITER_KVECs as simply, return -EFAULT. Taking the
non-zerocopy path for ITER_KVECs avoids the unnecessary fallback.
See https://lore.kernel.org/lkml/20150401023311.gl29...@zeniv.linux.org.uk/T/#u
for a
On 07/24/18 04:54 PM, Vakul Garg wrote:
> Removed checks against non-NULL before calling kfree_skb() and
> crypto_free_aead(). These functions are safe to be called with NULL
> as an argument.
>
> Signed-off-by: Vakul Garg
Acked-by: Dave Watson
On Wed, Jul 25, 2018 at 12:36:45PM +, Mathieu Xhonneux wrote:
> The seg6local LWT provides the End.DT6 action, which allows to
> decapsulate an outer IPv6 header containing a Segment Routing Header
> (SRH), full specification is available here:
>
>
On Wed, Jul 25, 2018 at 12:52 PM, Bjorn Helgaas wrote:
> From: Bjorn Helgaas
>
> The igb driver doesn't need anything provided by pci-aspm.h, so remove
> the unnecessary include of it.
>
> Signed-off-by: Bjorn Helgaas
Looks good to me.
Acked-by: Alexander Duyck
> ---
>
Define u_smp_rmb() and u_smp_wmb() to respective barrier instructions.
This ensures the processor will order accesses to queue indices against
accesses to queue ring entries.
Signed-off-by: Brian Brooks
---
samples/bpf/xdpsock_user.c | 5 +
1 file changed, 5 insertions(+)
diff --git
From: dann frazier
Date: Mon, 23 Jul 2018 16:55:40 -0600
> Otherwise interfaces get exposed under /sys/devices/virtual, which
> doesn't give udev the context it needs for PCI-based predictable
> interface names.
>
> Signed-off-by: dann frazier
Applied, thank you.
On 07/24/18 08:22 AM, Vakul Garg wrote:
> > I don't think this patch is safe as-is. sgin_arr is a stack array of size
> > MAX_SKB_FRAGS (+ overhead), while my read of skb_cow_data is that it
> > walks the whole chain of skbs from skb->next, and can return any number of
> > segments. Therefore we
On Wed, Jul 25, 2018 at 01:33:23PM -0700, Sinan Kaya wrote:
> On 7/25/2018 12:52 PM, Bjorn Helgaas wrote:
> > emove includes of from files that don't need
> > it. I'll apply all these via the PCI tree unless there's objection.
> >
> > ---
> >
> > Bjorn Helgaas (4):
> >igb: Remove
On Wed, 2018-07-25 at 14:52 -0500, Bjorn Helgaas wrote:
> From: Bjorn Helgaas
>
> This part of the iwlwifi driver doesn't need anything provided by
> pci-aspm.h, so remove the unnecessary include of it.
>
> Signed-off-by: Bjorn Helgaas
> ---
Acked-by: Luca Coelho
Thanks!
--
Cheers,
Luca.
From: Bjorn Helgaas
Date: Mon, 23 Jul 2018 15:59:46 -0500
> From: Bjorn Helgaas
>
> The vxge driver doesn't need anything provided by pci_hotplug.h, so remove
> the unnecessary include of it.
>
> Signed-off-by: Bjorn Helgaas
Applied to net-next, thanks.
On Thu, Jul 26, 2018 at 12:09:50AM +0900, Taehee Yoo wrote:
> rhashtable_lookup() can return NULL. so that NULL pointer
> check routine should be added.
>
> Fixes: 02b55e5657c3 ("xdp: add MEM_TYPE_ZERO_COPY")
> Signed-off-by: Taehee Yoo
Acked-by: Martin KaFai Lau
> ---
> V2 : add WARN_ON_ONCE
Currently all failure modes of xfrm interface creation return EEXIST.
This change improves the granularity of errnos provided by also
returning ENODEV or EINVAL if failures happen in looking up the
underlying interface, or a required parameter is not provided.
This change has been tested against
On Wed, Jul 25, 2018 at 01:38:44PM -0700, Martin KaFai Lau wrote:
> On Thu, Jul 26, 2018 at 01:30:39AM +0900, Taeung Song wrote:
> > To smoothly test BTF supported binary on samples/bpf,
> > let samples/bpf/Makefile probe llc, pahole and
> > llvm-objcopy for BPF support and use them
> > like
From: Krzysztof Kozlowski
Date: Mon, 23 Jul 2018 18:19:14 +0200
> Use generic kernel CRC32 implementation because it:
> 1. Should be faster (uses lookup tables),
> 2. Removes duplicated CRC generation code,
> 3. Uses well-proven algorithm instead of coding it one more time.
>
> Suggested-by:
From: Krzysztof Kozlowski
Date: Mon, 23 Jul 2018 18:20:20 +0200
> Use generic kernel CRC32 implementation because it:
> 1. Should be faster (uses lookup tables),
> 2. Removes duplicated CRC generation code,
> 3. Uses well-proven algorithm instead of coding it one more time.
>
> Suggested-by:
From: Heiner Kallweit
Date: Mon, 23 Jul 2018 21:40:07 +0200
> Add a helper for checking whether polling is used to detect PHY status
> changes.
>
> Signed-off-by: Heiner Kallweit
Applied.
On Thu, Jul 26, 2018 at 01:30:39AM +0900, Taeung Song wrote:
> To smoothly test BTF supported binary on samples/bpf,
> let samples/bpf/Makefile probe llc, pahole and
> llvm-objcopy for BPF support and use them
> like tools/testing/selftests/bpf/Makefile
> changed from the commit c0fa1b6c3efc
On 7/25/2018 12:52 PM, Bjorn Helgaas wrote:
emove includes of from files that don't need
it. I'll apply all these via the PCI tree unless there's objection.
---
Bjorn Helgaas (4):
igb: Remove unnecessary include of
ath9k: Remove unnecessary include of
iwlwifi: Remove
From: Vakul Garg
Date: Mon, 23 Jul 2018 21:00:06 +0530
> @@ -787,7 +787,7 @@ int tls_sw_recvmsg(struct sock *sk,
> target = sock_rcvlowat(sk, flags & MSG_WAITALL, len);
> timeo = sock_rcvtimeo(sk, flags & MSG_DONTWAIT);
> do {
> - bool zc = false;
> +
On Thu, Jul 26, 2018 at 04:21:31AM +0900, Taeung Song wrote:
>
>
> On 07/26/2018 03:27 AM, Taeung Song wrote:
> > Hi Arnaldo,
> >
> > On 07/26/2018 02:52 AM, Arnaldo Carvalho de Melo wrote:
> > > Em Thu, Jul 26, 2018 at 02:23:32AM +0900, Taeung Song escreveu:
> > > > Hi,
> > > >
> > > >
From: Camelia Groza
Date: Mon, 23 Jul 2018 18:06:15 +0300
> genphy_config_aneg() should be called only by PHYs that implement
> the Clause 22 register set. Prevent Clause 45 PHYs that don't implement
> the register set from calling the genphy function.
>
> Signed-off-by: Camelia Groza
From: xiangxia.m@gmail.com
Date: Sat, 21 Jul 2018 11:03:58 -0700
> From: Tonghao Zhang
>
> This patches improve the guest receive performance.
> On the handle_tx side, we poll the sock receive queue
> at the same time. handle_rx do that in the same way.
>
> For more performance report, see
From: "Michael S. Tsirkin"
Date: Wed, 25 Jul 2018 12:40:12 +0300
> On Mon, Jul 23, 2018 at 11:36:03PM +0900, Toshiaki Makita wrote:
>> From: Toshiaki Makita
>>
>> Add some ethtool stat items useful for performance analysis.
>>
>> Signed-off-by: Toshiaki Makita
>
> Series:
>
> Acked-by:
From: Bjorn Helgaas
The igb driver doesn't need anything provided by pci-aspm.h, so remove
the unnecessary include of it.
Signed-off-by: Bjorn Helgaas
---
drivers/net/ethernet/intel/igb/igb_main.c |1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/ethernet/intel/igb/igb_main.c
From: Bjorn Helgaas
Several PCI core files include pci-aspm.h even though they don't need
anything provided by that file. Remove the unnecessary includes of it.
Signed-off-by: Bjorn Helgaas
---
drivers/pci/pci-sysfs.c |1 -
drivers/pci/pci.c |1 -
drivers/pci/probe.c |1
From: Bjorn Helgaas
This part of the iwlwifi driver doesn't need anything provided by
pci-aspm.h, so remove the unnecessary include of it.
Signed-off-by: Bjorn Helgaas
---
drivers/net/wireless/intel/iwlwifi/pcie/drv.c |1 -
1 file changed, 1 deletion(-)
diff --git
From: Bjorn Helgaas
The ath9k driver doesn't need anything provided by pci-aspm.h, so remove
the unnecessary include of it.
Signed-off-by: Bjorn Helgaas
---
drivers/net/wireless/ath/ath9k/pci.c |1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/wireless/ath/ath9k/pci.c
Remove includes of from files that don't need
it. I'll apply all these via the PCI tree unless there's objection.
---
Bjorn Helgaas (4):
igb: Remove unnecessary include of
ath9k: Remove unnecessary include of
iwlwifi: Remove unnecessary include of
PCI: Remove
On 07/26/2018 03:27 AM, Taeung Song wrote:
Hi Arnaldo,
On 07/26/2018 02:52 AM, Arnaldo Carvalho de Melo wrote:
Em Thu, Jul 26, 2018 at 02:23:32AM +0900, Taeung Song escreveu:
Hi,
Building bpf programs with .BTF section,
I thought it'd be better to convert dwarf info to .BTF by
a new tool
On Tue, Jul 24, 2018 at 02:51:42PM +0530, Naresh Kamboju wrote:
> Deadlock warning on x86 machine while testing selftests: bpf:
> test_progs and running linux next 4.18.0-rc3-next-20180705 and still
> happening on 4.18.0-rc5-next-20180720.
>
> Any one noticed this kernel warning about deadlock ?
David Ahern writes:
> On 7/25/18 11:38 AM, Eric W. Biederman wrote:
>>
>> Absolutely NOT. Global thresholds are exactly correct given the fact
>> you are running on a single kernel.
>>
>> Memory is not free (Even though we are swimming in enough of it memory
>> rarely matters). One of the
Hello,
On Wed, 25 Jul 2018, Tan Hu wrote:
> We came across infinite loop in ipvs when using ipvs in docker
> env.
>
> When ipvs receives new packets and cannot find an ipvs connection,
> it will create a new connection, then if the dest is unavailable
> (i.e. IP_VS_DEST_F_AVAILABLE),
On 25.7.2018 19:04, David Ahern wrote:
> On 7/25/18 10:22 AM, Ivan Vecera wrote:
>> Kernel commit c5a9f6f0ab40 ("net/core: Add drop counters to VF
>> statistics") added support for Rx/Tx packet drops but these stats are
>> not reported by 'ip link'.
>>
>> Cc: Eugenia Emantayev
>> Cc: Saeed
On 07/25/2018 08:27 PM, Taeung Song wrote:
> On 07/26/2018 02:52 AM, Arnaldo Carvalho de Melo wrote:
[...]
>> BTW, Daniel, I just pushed to pahole's main repository at:
>>
>> git://git.kernel.org/pub/scm/devel/pahole/pahole.git
>>
>> with the Martin's BTF patch, so no need to pull from the
Remove unnecessary parentheses to fix the extraneous parentheses clang
warning.
Signed-off-by: Varsha Rao
---
drivers/net/wireless/st/cw1200/txrx.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/wireless/st/cw1200/txrx.c
Remove the unnecessary parentheses to fix the clang warning of
extraneous parentheses.
Signed-off-by: Varsha Rao
---
drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_n.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git
Remove extra parentheses to fix the clang warning of extraneous
parentheses.
Signed-off-by: Varsha Rao
---
drivers/net/wireless/ath/ath9k/debug_sta.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/ath/ath9k/debug_sta.c
Remove extra parentheses to fix the clang warning of extraneous
parentheses.
Signed-off-by: Varsha Rao
---
drivers/net/wireless/ath/ath6kl/main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/ath/ath6kl/main.c
b/drivers/net/wireless/ath/ath6kl/main.c
Hi Arnaldo,
On 07/26/2018 02:52 AM, Arnaldo Carvalho de Melo wrote:
Em Thu, Jul 26, 2018 at 02:23:32AM +0900, Taeung Song escreveu:
Hi,
Building bpf programs with .BTF section,
I thought it'd be better to convert dwarf info to .BTF by
a new tool such as 'tools/bpf/bpf_dwarf2btf' instead of
On Wed, Jul 25, 2018 at 07:59:48AM -0400, Jamal Hadi Salim wrote:
> On 24/07/18 04:06 PM, Paolo Abeni wrote:
> > Each lockless action currently does its own RCU locking in ->act().
> > This is allows using plain RCU accessor, even if the context
> > is really RCU BH.
> >
> > This change drops the
On 7/24/18 11:14 AM, David Miller wrote:
> From: David Ahern
> Date: Tue, 24 Jul 2018 09:14:01 -0600
>
>> I get the impression there is no longer a strong resistance against
>> moving the tables to per namespace, but deciding what is the right
>> approach to handle backwards compatibility.
On 7/25/18 11:38 AM, Eric W. Biederman wrote:
>
> Absolutely NOT. Global thresholds are exactly correct given the fact
> you are running on a single kernel.
>
> Memory is not free (Even though we are swimming in enough of it memory
> rarely matters). One of the few remaining challenges is for
On Wed, Jul 25, 2018 at 4:32 AM, Rafael J. Wysocki wrote:
> On Tue, Jul 24, 2018 at 6:49 PM, Kees Cook wrote:
>> In the quest to remove all stack VLA usage from the kernel[1], this
>> removes the discouraged use of AHASH_REQUEST_ON_STACK by switching to
>> shash directly and allocating the
David Ahern writes:
> On 7/25/18 6:33 AM, Eric W. Biederman wrote:
>> Cong Wang writes:
>>
>>> On Tue, Jul 24, 2018 at 8:14 AM David Ahern wrote:
On 7/19/18 11:12 AM, Cong Wang wrote:
> On Thu, Jul 19, 2018 at 9:16 AM David Ahern wrote:
>>
>> Chatting with Nikolay about
Hi,
Building bpf programs with .BTF section,
I thought it'd be better to convert dwarf info to .BTF by
a new tool such as 'tools/bpf/bpf_dwarf2btf' instead of pahole
in the future.
Currently for bpf binary that have .BTF section,
we need to use pahole from
On Wed, Jul 25, 2018 at 09:48:16AM -0700, Cong Wang wrote:
> On Wed, Jul 25, 2018 at 5:27 AM Jamal Hadi Salim wrote:
> >
> > Those changes were there from the beginning (above patch did
> > not introduce them).
> > IIRC, the reason was to distinguish between policy intended
> > drops and drops
On 7/25/18 10:22 AM, Ivan Vecera wrote:
> Kernel commit c5a9f6f0ab40 ("net/core: Add drop counters to VF
> statistics") added support for Rx/Tx packet drops but these stats are
> not reported by 'ip link'.
>
> Cc: Eugenia Emantayev
> Cc: Saeed Mahameed
>
> Signed-off-by: Ivan Vecera
> ---
>
On 7/23/18 1:24 AM, Jiri Pirko wrote:
> From: Jiri Pirko
>
> Signed-off-by: Jiri Pirko
> ---
> v3->v4:
> - reworked to chain object
> v1->v2:
> - moved the template handling
> from "tc filter template" to "tc chaintemplate"
> ---
> include/uapi/linux/rtnetlink.h | 7 +++
> man/man8/tc.8
On 7/22/18 4:31 AM, Eran Ben Elisha wrote:
> Extend VFs statistics by receive and transmit violation counters.
>
> Example: "ip -s link show dev enp5s0f0"
>
> 6: enp5s0f0: mtu 1500 qdisc mq state UP
> mode DEFAULT group default qlen 1000
> link/ether 24:8a:07:a5:28:f0 brd ff:ff:ff:ff:ff:ff
On 07/23/2018 11:43 AM, Björn Töpel wrote:
> From: Björn Töpel
>
> Polling for the ingress queues relies on reading the producer/consumer
> pointers of the Rx queue.
>
> Prior this commit, a cached consumer pointer could be used, instead of
> the actual consumer pointer and therefore report
On 07/25/2018 06:46 PM, Wang YanQing wrote:
> Commit 24dea04767e6 ("bpf, x32: remove ld_abs/ld_ind")
> removed the 4 /* Extra space for skb_copy_bits buffer */
> from _STACK_SIZE, but it didn't fix the concerned code
> in emit_prologue and emit_epilogue, and this error will
> bring very strange
On 7/25/2018 8:22 AM, Gustavo A. R. Silva wrote:
Currently, code at label *out* is unreachable. Fix this by updating
variable *ret* with -EINVAL, so the jump to *out* can be properly
executed instead of directly returning from function.
Addresses-Coverity-ID: 1472059 ("Structurally dead code")
>
> i extracted this struct/blob/voodoo from UGW3/4 7 years ago and was puzzled
> by it. for those of us that have worked with this table in the past, its
> semi understandable, yet its almost like a blackbox FW blob. can we try to
> make it a little more readable by adding a comment on each line
On Wed, Jul 25, 2018 at 5:27 AM Jamal Hadi Salim wrote:
>
> Those changes were there from the beginning (above patch did
> not introduce them).
> IIRC, the reason was to distinguish between policy intended
> drops and drops because of errors.
There must be a limit for "overlimit" to make sense.
Commit 24dea04767e6 ("bpf, x32: remove ld_abs/ld_ind")
removed the 4 /* Extra space for skb_copy_bits buffer */
from _STACK_SIZE, but it didn't fix the concerned code
in emit_prologue and emit_epilogue, and this error will
bring very strange kernel runtime errors.
This patch fix it.
Fixes:
> Subject: [PATCH net-next] lan743x: Make symbol lan743x_pm_ops static
>
> Fixes the following sparse warning:
>
> drivers/net/ethernet/microchip/lan743x_main.c:2944:25: warning:
> symbol 'lan743x_pm_ops' was not declared. Should it be static?
>
> Signed-off-by: Wei Yongjun
Acked-by: Bryan
On Tue, Jul 24, 2018 at 11:49 PM Jiri Pirko wrote:
>
> Wed, Jul 25, 2018 at 01:20:08AM CEST, xiyou.wangc...@gmail.com wrote:
> >So, you only send out notification when the last refcnt is gone.
> >
> >If the chain that is being deleted by a user is still used by an action,
> >you return 0 or
On 21/07/18 21:13, Hauke Mehrtens wrote:
+#define MC_ENTRY(val, msk, ns, out, len, type, flags, ipv4_len) \
+ { val, msk, (ns << 10 | out << 4 | len >> 1),\
+ (len & 1) << 15 | type << 13 | flags << 9 | ipv4_len << 8 }
+static const struct gswip_pce_microcode
To smoothly test BTF supported binary on samples/bpf,
let samples/bpf/Makefile probe llc, pahole and
llvm-objcopy for BPF support and use them
like tools/testing/selftests/bpf/Makefile
changed from the commit c0fa1b6c3efc ("bpf: btf:
Add BTF tests")
Cc: Martin KaFai Lau
Signed-off-by: Taeung
On 07/25/2018 05:48 PM, Paolo Abeni wrote:
> On Wed, 2018-07-25 at 15:03 +0200, Jiri Pirko wrote:
>> Wed, Jul 25, 2018 at 02:54:04PM CEST, pab...@redhat.com wrote:
>>> On Wed, 2018-07-25 at 13:56 +0200, Jiri Pirko wrote:
Tue, Jul 24, 2018 at 10:06:39PM CEST, pab...@redhat.com wrote:
>
On Wed, 2018-07-25 at 17:48 +0200, Paolo Abeni wrote:
> On Wed, 2018-07-25 at 15:03 +0200, Jiri Pirko wrote:
> > Well it was obviously wrong to expose TC_ACT_REDIRECT to uapi and it
> > really has no meaning for anyone to use it throughout its whole history.
> > I would vote for "fail", yet I
Kernel commit c5a9f6f0ab40 ("net/core: Add drop counters to VF
statistics") added support for Rx/Tx packet drops but these stats are
not reported by 'ip link'.
Cc: Eugenia Emantayev
Cc: Saeed Mahameed
Signed-off-by: Ivan Vecera
---
ip/ipaddress.c | 11 +--
1 file changed, 9
1 - 100 of 220 matches
Mail list logo
