On Mon, 27 Aug 2018 19:11:01 +0200
Andreas Schwab wrote:
> I'm getting this Oops when running iptables -F OUTPUT:
>
> [ 91.139409] Unable to handle kernel paging request for data at address
> 0xd001fff12f34
> [ 91.139414] Faulting instruction address: 0xd16a5718
> [
On Mon, Aug 27, 2018 at 06:31:22PM +0200, Olivier Brunel wrote:
>
> So the process is required, never ends and prevents umouting the
it's not required. It's not doing anything useful at the moment
and defaults to 'n' in kconfig. Please disable it your kernel.
> rootfs on shutdown. Unless I'm
On Mon, Aug 27, 2018 at 05:01:10PM +0200, Florian Weimer wrote:
> liquidio/lio_23xx_vsw.bin contains a compiled MIPS Linux kernel:
>
> $ tail --bytes=+1313 liquidio/lio_23xx_vsw.bin > elf
> $ readelf -aW elf
> […]
> [ 6] __ksymtab PROGBITS80e495f8 64a5f8 00d130
> 00 A
On Mon, Aug 27, 2018 at 12:56 PM, David Ahern wrote:
> On 8/27/18 10:24 AM, Stephen Hemminger wrote:
>>
>> Also, as Dave mentioned any implementation needs to handle multiple
>> namespaces
>> and routing tables.
>>
>> Could this alternative lookup be enabled via sysctl at runtime rather than
>>
On Mon, Aug 27, 2018 at 12:24 PM, Stephen Hemminger
wrote:
> On Sun, 26 Aug 2018 22:28:48 -0400
> "Md. Islam" wrote:
>
>> This patch implements Poptrie [1] based FIB lookup. It exhibits pretty
>> impressive lookup performance compared to LC-trie. This poptrie
>> implementation however somewhat
On Mon, 27 Aug 2018 14:46:52 -0700
Cong Wang wrote:
> UNIX_DIAG_VFS and UNIX_DIAG_ICONS are never used by ss,
> make them available in ss -e output.
>
> Cc: Stephen Hemminger
> Signed-off-by: Cong Wang
> ---
> misc/ss.c | 25 +
> 1 file changed, 25 insertions(+)
>
>
From: Zhu Yanjun
Date: Sat, 25 Aug 2018 15:19:05 +0800
> In IPv4, the newly introduced rdma_read_gids is used to read the SGID/DGID
> for the connection which returns GID correctly for RoCE transport as well.
>
> In IPv6, rdma_read_gids is also used. The following are why rdma_read_gids
> is
From: Azat Khuzhin
Date: Sun, 26 Aug 2018 17:03:09 +0300
> I have two Ethernet adapters:
> r8169 :03:01.0 eth0: RTL8169sb/8110sb, 00:14:d1:14:2d:49, XID 1000,
> IRQ 18
> r8169 :01:00.0 eth0: RTL8168e/8111e, 64:66:b3:11:14:5d, XID 2c20,
> IRQ 30
> And after upgrading from
From: Linus Walleij
Date: Mon, 27 Aug 2018 00:20:11 +0200
> Commit 52638f71fcff ("dsa: Move gpio reset into switch driver")
> moved the GPIO handling into the switch drivers but forgot
> to remove the GPIO header includes.
>
> Signed-off-by: Linus Walleij
Applied.
From: Cong Wang
Date: Mon, 27 Aug 2018 13:44:56 -0700
> On Mon, Aug 27, 2018 at 11:58 AM Jiri Pirko wrote:
>>
>> From: Jiri Pirko
>>
>> Jiri Pirko (2):
>> net: sched: fix extack error message when chain is failed to be
>> created
>> net: sched: return -ENOENT when trying to remove
From: Xin Long
Date: Mon, 27 Aug 2018 18:38:31 +0800
> As Marcelo noticed, in sctp_transport_get_next, it is iterating over
> transports but then also accessing the association directly, without
> checking any refcnts before that, which can cause an use-after-free
> Read.
>
> So fix it by
From: Xin Long
Date: Mon, 27 Aug 2018 18:41:32 +0800
> After erspan_ver is introudced, if erspan_ver is not set in iproute, its
> value will be left 0 by default. Since Commit 02f99df1875c ("erspan: fix
> invalid erspan version."), it has broken the traffic due to the version
> check in
From: Xin Long
Date: Mon, 27 Aug 2018 18:40:18 +0800
> After changing rhashtable_walk_start to return void, start_fail would
> never be set other value than 0, and the checking for start_fail is
> pointless, so remove it.
>
> Fixes: 97a6ec4ac021 ("rhashtable: Change rhashtable_walk_start to
UNIX_DIAG_VFS and UNIX_DIAG_ICONS are never used by ss,
make them available in ss -e output.
Cc: Stephen Hemminger
Signed-off-by: Cong Wang
---
misc/ss.c | 25 +
1 file changed, 25 insertions(+)
diff --git a/misc/ss.c b/misc/ss.c
index 41e7762b..d28bc1ec 100644
---
Do you received my previous email? about your late relative having the
same surname with you which i previously sent to you? please Let me
know.
in the (rare) case of failure in nla_nest_start(), missing NULL checks in
tcf_pedit_key_ex_dump() can make the following command
# tc action add action pedit ex munge ip ttl set 64
dereference a NULL pointer:
BUG: unable to handle kernel NULL pointer dereference at
PGD
On Mon, Aug 27, 2018 at 11:58 AM Jiri Pirko wrote:
>
> From: Jiri Pirko
>
> Jiri Pirko (2):
> net: sched: fix extack error message when chain is failed to be
> created
> net: sched: return -ENOENT when trying to remove filter from
> non-existent chain
Acked-by: Cong Wang
Quoting Hans de Goede (2018-08-27 11:53:19)
> On 27-08-18 20:47, Stephen Boyd wrote:
> > How would you know that a clk device driver hasn't probed yet and isn't
> > the driver that's actually providing the clk to this device on x86
> > systems? With DT systems we can figure that out by looking at
From: Jiri Pirko
Instead "Cannot find" say "Cannot create".
Fixes: c35a4acc2985 ("net: sched: cls_api: handle generic cls errors")
Signed-off-by: Jiri Pirko
---
net/sched/cls_api.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/sched/cls_api.c b/net/sched/cls_api.c
From: Jiri Pirko
When chain 0 was implicitly created, removal of non-existent filter from
chain 0 gave -ENOENT. Once chain 0 became non-implicit, the same call is
giving -EINVAL. Fix this by returning -ENOENT in that case.
Reported-by: Roman Mashak
Fixes: f71e0ca4db18 ("net: sched: Avoid
From: Jiri Pirko
Jiri Pirko (2):
net: sched: fix extack error message when chain is failed to be
created
net: sched: return -ENOENT when trying to remove filter from
non-existent chain
net/sched/cls_api.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
--
2.14.4
Hi,
On 27-08-18 20:47, Stephen Boyd wrote:
Quoting Hans de Goede (2018-08-27 07:31:58)
On some boards a platform clock is used as clock for the r8169 chip,
this commit adds support for getting and enabling this clock (assuming
it has an "ether_clk" alias set on it).
This is related to commit
When strncpy() is called with source and destination strings the same
length, gcc 8 warns that there may be an unterminated string. Using
strlcpy() rather than strncpy() forces a null at the end and quiets the
warning.
Signed-off-by: Larry Finger
---
v2 - No changes.
---
Quoting Hans de Goede (2018-08-27 07:31:58)
> On some boards a platform clock is used as clock for the r8169 chip,
> this commit adds support for getting and enabling this clock (assuming
> it has an "ether_clk" alias set on it).
>
> This is related to commit d31fd43c0f9a ("clk: x86: Do not gate
When the size argument in a call to strncpy() is the size of the
destimation, gcc8 issues a warning. These patches fix the potential
problem.
Signed-off-by: Larry Finger
v2 - The code is changed to implement the comments of David Laight.
Larry Finger (2):
staging: rtl8192e: Fix compiler
When strncpy() is called with source and destination strings the same
length, gcc 8 warns that there may be an unterminated string. This section
is completely reworked to use the known lengths of the strings.
Signed-off-by: Larry Finger
---
v2 - David Laight's comments are implemented.
---
On Mon, Aug 27, 2018 at 09:17:21PM +0300, Baruch Siach wrote:
> Hi Andrew,
>
> Thanks for reviewing.
>
> On Mon, Aug 27, 2018 at 03:47:23PM +0200, Andrew Lunn wrote:
> > On Mon, Aug 27, 2018 at 03:12:53PM +0300, Baruch Siach wrote:
> > > Without a valid of_node in struct device we can't find the
Quoting Hans de Goede (2018-08-27 07:31:57)
> Commit d31fd43c0f9a ("clk: x86: Do not gate clocks enabled by the
> firmware") causes all unclaimed PMC clocks on Cherry Trail devices to be on
> all the time, resulting on the device not being able to reach S0i2 or S0i3
> when suspended.
>
> The
On Sat, Aug 25, 2018 at 6:06 AM Jiri Pirko wrote:
>
> Fri, Aug 24, 2018 at 08:11:07PM CEST, xiyou.wangc...@gmail.com wrote:
> >On Fri, Aug 24, 2018 at 9:21 AM Roman Mashak wrote:
> >>
> >> So _before_ commit f71e0ca4db187af7c44987e9d21e9042c3046070 step 6 would
> >> return -ENOENT with "Error:
Hi Andrew,
Thanks for reviewing.
On Mon, Aug 27, 2018 at 03:47:23PM +0200, Andrew Lunn wrote:
> On Mon, Aug 27, 2018 at 03:12:53PM +0300, Baruch Siach wrote:
> > Without a valid of_node in struct device we can't find the mvpp2 port
> > device by its DT node. Specifically, this breaks
> >
On Mon, Aug 20, 2018 at 12:51:22PM -0500, Larry Finger wrote:
> When the size argument in a call to strncpy() is the size of the
> destimation, gcc8 issues a warning. These patches fix the potential
> problem by replacing the strncpy() with strlcpy().
>
> Signed-off-by: Larry Finger
>
>
>
Greetings,
We are rebuilding Iraq after years of conflicts and we are inviting you to
take up contracts. We are determined to purchase your products in large
quantities, for use in all over our 18 governorates(provinces) as the task
of re-building Iraq covers every single sectormand facet of
I'm getting this Oops when running iptables -F OUTPUT:
[ 91.139409] Unable to handle kernel paging request for data at address
0xd001fff12f34
[ 91.139414] Faulting instruction address: 0xd16a5718
[ 91.139419] Oops: Kernel access of bad area, sig: 11 [#1]
[ 91.139426] BE SMP
On Sun, Aug 26, 2018 at 6:14 AM wrote:
>
> > BTW, removing the FCS also means GRO is going to work, finally on this NIC
> > ;)
> >
> > GRO does not like packets with padding.
>
> As a follow-up, I am seeing hw csum failures on Sun V440 that has
> onboard Sun Cassini with sungem driver. First
On 8/27/18 10:24 AM, Stephen Hemminger wrote:
>
> Also, as Dave mentioned any implementation needs to handle multiple namespaces
> and routing tables.
>
> Could this alternative lookup be enabled via sysctl at runtime rather than
> kernel config?
>
I spent time a couple of years ago
On Mon, 2018-08-27 at 12:16 -0400, rpj...@crashcourse.ca wrote:
> Quoting David Miller :
>
> > From: "Robert P. J. Day"
> > Date: Mon, 27 Aug 2018 04:55:29 -0400 (EDT)
> >
> > > another pedantic oddity -- is there a reason for these two double
> > > negations in net/core/net-sysfs.c?
> >
> >
Quoting Eric Dumazet :
On 08/27/2018 09:16 AM, rpj...@crashcourse.ca wrote:
Quoting David Miller :
From: "Robert P. J. Day"
Date: Mon, 27 Aug 2018 04:55:29 -0400 (EDT)
another pedantic oddity -- is there a reason for these two double
negations in net/core/net-sysfs.c?
It turns an
On 08/27/2018 09:16 AM, rpj...@crashcourse.ca wrote:
>
> Quoting David Miller :
>
>> From: "Robert P. J. Day"
>> Date: Mon, 27 Aug 2018 04:55:29 -0400 (EDT)
>>
>>> another pedantic oddity -- is there a reason for these two double
>>> negations in net/core/net-sysfs.c?
>>
>> It turns an
On Mon, Aug 27, 2018 at 9:11 AM Stephen Hemminger
wrote:
>
> On Sun, 26 Aug 2018 19:42:28 -0700
> Yousuk Seung wrote:
>
> > +int get_time(unsigned int *time, const char *str)
> > +{
> > + double t;
> > + char *p;
> > +
> > + t = strtod(str, );
> > + if (p == str)
> > +
Small addentum: Of course I failed to realize this bpfilter helper is
also mentioned in the kernel log:
kern.info: [8.997711] bpfilter: Loaded bpfilter_umh pid 920
It also seems to be absolutely required when CONFIG_BPFILTER is
enabled, that is I tried blacklisting the module bpfilter,
On Sun, 26 Aug 2018 22:28:48 -0400
"Md. Islam" wrote:
> This patch implements Poptrie [1] based FIB lookup. It exhibits pretty
> impressive lookup performance compared to LC-trie. This poptrie
> implementation however somewhat deviates from the original
> implementation [2]. I tested this patch
Quoting David Miller :
From: "Robert P. J. Day"
Date: Mon, 27 Aug 2018 04:55:29 -0400 (EDT)
another pedantic oddity -- is there a reason for these two double
negations in net/core/net-sysfs.c?
It turns an arbitrary integer into a boolean, this is a common
construct across the kernel
On Sun, 26 Aug 2018 19:42:28 -0700
Yousuk Seung wrote:
> +int get_time(unsigned int *time, const char *str)
> +{
> + double t;
> + char *p;
> +
> + t = strtod(str, );
> + if (p == str)
> + return -1;
> +
> + if (*p) {
> + if (strcasecmp(p, "s") == 0 ||
From: "Robert P. J. Day"
Date: Mon, 27 Aug 2018 04:55:29 -0400 (EDT)
> another pedantic oddity -- is there a reason for these two double
> negations in net/core/net-sysfs.c?
It turns an arbitrary integer into a boolean, this is a common
construct across the kernel tree so I'm surprised you've
On Sun, 26 Aug 2018 22:13:53 -0400 "Md. Islam" wrote:
> This patch implements Poptrie [1] based FIB lookup. It exhibits pretty
> impressive lookup performance compared to LC-trie. This poptrie
> implementation however somewhat deviates from the original
> implementation [2]. I tested this
liquidio/lio_23xx_vsw.bin contains a compiled MIPS Linux kernel:
$ tail --bytes=+1313 liquidio/lio_23xx_vsw.bin > elf
$ readelf -aW elf
[…]
[ 6] __ksymtab PROGBITS80e495f8 64a5f8 00d130
00 A 0 0 8
[ 7] __ksymtab_gpl PROGBITS80e56728 657728
Disable the clk during suspend to save power. Note that tp->clk may be
NULL, the clk core functions handle this without problems.
Signed-off-by: Hans de Goede
---
drivers/net/ethernet/realtek/r8169.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/net/ethernet/realtek/r8169.c
Commit d31fd43c0f9a ("clk: x86: Do not gate clocks enabled by the
firmware"), which added the code to mark clocks as CLK_IS_CRITICAL, causes
all unclaimed PMC clocks on Cherry Trail devices to be on all the time,
resulting on the device not being able to reach S0i3 when suspended.
The reason for
On some boards a platform clock is used as clock for the r8169 chip,
this commit adds support for getting and enabling this clock (assuming
it has an "ether_clk" alias set on it).
This is related to commit d31fd43c0f9a ("clk: x86: Do not gate clocks
enabled by the firmware") which is a previous
Commit d31fd43c0f9a ("clk: x86: Do not gate clocks enabled by the
firmware") causes all unclaimed PMC clocks on Cherry Trail devices to be on
all the time, resulting on the device not being able to reach S0i2 or S0i3
when suspended.
The reason for this commit is that on some Bay Trail / Cherry
Hi All,
This series has as goal to revert commit d31fd43c0f9a ("clk: x86: Do not gate
clocks enabled by the firmware"), because that commit causes almost all
Cherry Trail devices to not use the S0i3 powerstate when suspending, leading
to them quickly draining their battery when suspended.
This
On Mon, Aug 27, 2018 at 03:12:53PM +0300, Baruch Siach wrote:
> Without a valid of_node in struct device we can't find the mvpp2 port
> device by its DT node. Specifically, this breaks
> of_find_net_device_by_node().
Hi Baruch
We need to be a little bit careful here. I've seen this done wrongly
On Mon, Aug 27, 2018 at 06:40:18PM +0800, Xin Long wrote:
> After changing rhashtable_walk_start to return void, start_fail would
> never be set other value than 0, and the checking for start_fail is
> pointless, so remove it.
>
> Fixes: 97a6ec4ac021 ("rhashtable: Change rhashtable_walk_start to
On Mon, Aug 27, 2018 at 06:38:31PM +0800, Xin Long wrote:
> As Marcelo noticed, in sctp_transport_get_next, it is iterating over
> transports but then also accessing the association directly, without
> checking any refcnts before that, which can cause an use-after-free
> Read.
>
> So fix it by
On Mon, Aug 27, 2018 at 06:40:18PM +0800, Xin Long wrote:
> After changing rhashtable_walk_start to return void, start_fail would
> never be set other value than 0, and the checking for start_fail is
> pointless, so remove it.
>
> Fixes: 97a6ec4ac021 ("rhashtable: Change rhashtable_walk_start to
On Mon, Aug 27, 2018 at 06:38:31PM +0800, Xin Long wrote:
> As Marcelo noticed, in sctp_transport_get_next, it is iterating over
> transports but then also accessing the association directly, without
> checking any refcnts before that, which can cause an use-after-free
> Read.
>
> So fix it by
Without a valid of_node in struct device we can't find the mvpp2 port
device by its DT node. Specifically, this breaks
of_find_net_device_by_node().
Signed-off-by: Baruch Siach
---
drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c | 1 +
1 file changed, 1 insertion(+)
diff --git
After erspan_ver is introudced, if erspan_ver is not set in iproute, its
value will be left 0 by default. Since Commit 02f99df1875c ("erspan: fix
invalid erspan version."), it has broken the traffic due to the version
check in erspan_xmit if users are not aware of 'erspan_ver' param, like
using an
After changing rhashtable_walk_start to return void, start_fail would
never be set other value than 0, and the checking for start_fail is
pointless, so remove it.
Fixes: 97a6ec4ac021 ("rhashtable: Change rhashtable_walk_start to return void")
Signed-off-by: Xin Long
---
net/sctp/proc.c | 4
As Marcelo noticed, in sctp_transport_get_next, it is iterating over
transports but then also accessing the association directly, without
checking any refcnts before that, which can cause an use-after-free
Read.
So fix it by holding transport before accessing the association. With
that,
another pedantic oddity -- is there a reason for these two double
negations in net/core/net-sysfs.c?
static ssize_t carrier_show(struct device *dev,
struct device_attribute *attr, char *buf)
{
struct net_device *netdev = to_net_dev(dev);
if
On Mon, 27 Aug 2018, Oliver Hartkopp wrote:
> "released upon production" means usually: Oh, we put that driver in
> a tar-ball on a CD that's shipped with the product and which will
> get no further visibility nor (security) maintenance.
>
> Robert, please tell your manager that creating a driver
On 08/27/2018 08:20 AM, Robert P. J. Day wrote:
On Sun, 26 Aug 2018, Stephen Hemminger wrote:
On Sun, 26 Aug 2018 15:20:24 -0400 (EDT)
"Robert P. J. Day" wrote:
On Sun, 26 Aug 2018, Andrew Lunn wrote:
i ask since, in my testing, when the interface should have been
up, the attribute
On Sun, 26 Aug 2018, Stephen Hemminger wrote:
> On Sun, 26 Aug 2018 11:14:33 -0400 (EDT)
> "Robert P. J. Day" wrote:
>
> > apologies for the constant pleas for assistance, but i think i'm
> > zeroing in on the problem that started all this. recap: custom
> > FPGA-based linux box with multiple
On Sun, 26 Aug 2018, Stephen Hemminger wrote:
> On Sun, 26 Aug 2018 15:20:24 -0400 (EDT)
> "Robert P. J. Day" wrote:
>
> > On Sun, 26 Aug 2018, Andrew Lunn wrote:
> >
> > > > i ask since, in my testing, when the interface should have been
> > > > up, the attribute file "operstate" for that
65 matches
Mail list logo
