From: Hauke Mehrtens
Date: Sat, 29 Sep 2018 13:26:30 +0200
> The MAINTAINERS file contained the wrong file name of the driver.
>
> Fixes: 14fceff4771e ("net: dsa: Add Lantiq / Intel DSA driver for vrx200")
> Reported-by: Joe Perches
> Signed-off-by: Hauke Mehrtens
Applied.
From: Stephen Hemminger
Date: Sat, 29 Sep 2018 14:52:56 +0200
> Similar to other patches from ERic.
>
> As diagnosed by Song Liu, ndo_poll_controller() can
> be very dangerous on loaded hosts, since the cpu
> calling ndo_poll_controller() might steal all NAPI
> contexts (for all RX/TX queues of
From: Andrew Lunn
Date: Sat, 29 Sep 2018 21:57:02 +0200
> Fix the patch for the mv88e6xxx.h header file in MAINTAINERS
>
> Reported-by: Joe Perches
> Signed-off-by: Andrew Lunn
Applied.
From: Johan Hedberg
Date: Sun, 30 Sep 2018 10:36:36 +0300
> Here's the first bluetooth-next pull request for the 4.20 kernel.
>
> - Fixes & cleanups to hci_qca driver
> - NULL dereference fix to debugfs
> - Improved L2CAP Connection-oriented Channel MTU & MPS handling
> - Added support for
From: Eric Dumazet
Date: Sun, 30 Sep 2018 11:33:39 -0700
> Caching ip_hdr(skb) before a call to pskb_may_pull() is buggy,
> do not do it.
>
> Fixes: 2efd4fca703a ("ip: in cmsg IP(V6)_ORIGDSTADDR call pskb_may_pull")
> Signed-off-by: Eric Dumazet
> Cc: Willem de Bruijn
> Reported-by: syzbot
Stephen Rothwell reports the following link failure with IPv6 as module:
x86_64-linux-gnu-ld: net/core/filter.o: in function `sk_lookup':
(.text+0x19219): undefined reference to `__udp6_lib_lookup'
Fix the build by only enabling the IPv6 socket lookup if IPv6 support is
compiled into the
From: Mike Manning
Date: Mon, 1 Oct 2018 09:41:27 +0100
> From: Patrick Ruddy
>
> The code to obtain the correct table for the incoming interface was
> missing for IPv6. This has been added along with the table creation
> notification to fib rules for the RTNL_FAMILY_IP6MR address family.
>
From: Mike Manning
Date: Mon, 1 Oct 2018 09:40:23 +0100
> From: Robert Shearman
>
> It is useful to be able to use the same socket for listening in a
> specific VRF, as for sending multicast packets out of a specific
> interface. However, the bound device on the socket currently takes
>
On Tue, Oct 02, 2018 at 12:50:19PM -0700, Cong Wang wrote:
> In commit ec3ed293e766 ("net_sched: change tcf_del_walker() to take
> idrinfo->lock")
> we move fl_hw_destroy_tmplt() to a workqueue to avoid blocking
> with the spinlock held. Unfortunately, this causes a lot of
> troubles here:
>
>
From: Ioana Radulescu
Date: Mon, 1 Oct 2018 13:44:54 +0300
> The Management Complex (MC) firmware initially allowed the
> configuration of a single key to be used both for Rx flow hashing
> and flow classification. This prevented us from supporting
> Rx flow classification independently of the
From: Saeed Mahameed
Date: Mon, 1 Oct 2018 10:37:47 -0700
> This pull request includes some fixes to mlx5 driver,
> Please pull and let me know if there's any problem.
Pulled.
> For -stable v4.11:
> "6e0a4a23c59a ('net/mlx5: E-Switch, Fix out of bound access when setting
> vport rate')"
>
>
From: Eric Dumazet
Date: Mon, 1 Oct 2018 23:24:26 -0700
> syzkaller was able to hit the WARN_ON(sock_owned_by_user(sk));
> in tcp_close()
>
> While a socket is being closed, it is very possible other
> threads find it in rtnetlink dump.
>
> tcp_get_info() will acquire the socket lock for a
From: Subash Abhinov Kasiviswanathan
Date: Tue, 2 Oct 2018 18:52:00 -0600
> This series is a set of small fixes for rmnet driver
>
> Patch 1 is a fix for a scenario reported by syzkaller
> Patch 2 & 3 are fixes for incorrect allocation flags
Series applied and queued up for -stable, thanks.
On 10/01/2018 10:49 PM, Eric Dumazet wrote:
> syszbot found an interesting use-after-free [1] happening
> while IPv4 fragment rhashtable was destroyed at netns dismantle.
>
David, please do not apply this patch.
I am working on another version, a bit more polished and allowing for more
On 10/02/2018 10:35 PM, Joe Stringer wrote:
> This series proposes a new helper for the BPF API which allows BPF programs to
> perform lookups for sockets in a network namespace. This would allow programs
> to determine early on in processing whether the stack is expecting to receive
> the packet,
The incoming skb needs to be reallocated in case the headroom
is not sufficient to adjust the ethernet header. This allocation
needs to be atomic otherwise it results in this splat
[<600601bb>] ___might_sleep+0x185/0x1a3
[<603f6314>] ? _raw_spin_unlock_irqrestore+0x0/0x27
[<60069bb0>] ?
From: Sean Tranchetti
RMNET RX handler was processing invalid packets that were
originally sent on the real device and were looped back via
dev_loopback_xmit(). This was detected using syzkaller.
Fixes: ceed73a2cf4a ("drivers: net: ethernet: qualcomm: rmnet: Initial
implementation")
The incoming skb needs to be reallocated in case the headroom
is not sufficient to add the MAP header. This allocation needs to
be atomic otherwise it results in the following splat
[32805.801456] BUG: sleeping function called from invalid context
[32805.841141] Internal error: Oops - BUG: 0 [#1]
This series is a set of small fixes for rmnet driver
Patch 1 is a fix for a scenario reported by syzkaller
Patch 2 & 3 are fixes for incorrect allocation flags
Sean Tranchetti (1):
net: qualcomm: rmnet: Skip processing loopback packets
Subash Abhinov Kasiviswanathan (2):
net: qualcomm:
From: Maciej Żenczykowski
Date: Tue, 2 Oct 2018 16:25:39 -0700
>> Please provide a proper "0/N" header posting in furture patch series
>> submissions.
>>
>> Thank you.
>
> Seeing as all but 2 of these patches were entirely independent should
> I have sent them as individual patches instead
> Please provide a proper "0/N" header posting in furture patch series
> submissions.
>
> Thank you.
Seeing as all but 2 of these patches were entirely independent should
I have sent them as individual patches instead (with one patch pair)?
Or are series preferred even if I ended up reuploading
All 9 patches applied, thanks.
Please provide a proper "0/N" header posting in furture patch series
submissions.
Thank you.
From: Eric Dumazet
Date: Tue, 2 Oct 2018 15:47:35 -0700
> We have an impressive number of syzkaller bugs that are linked
> to the fact that syzbot was able to create a networking device
> with millions of TX (or RX) queues.
>
> Let's limit the number of RX/TX queues to 4096, this really should
From: Mahesh Bandewar
Date: Tue, 2 Oct 2018 12:14:34 -0700
> From: Mahesh Bandewar
>
> RX queue config for bonding master could be different from its slave
> device(s). With the commit 6a9e461f6fe4 ("bonding: pass link-local
> packets to bonding master also."), the packet is reinjected into
From: Eric Dumazet
Date: Tue, 2 Oct 2018 12:35:05 -0700
> Timer handlers do not imply rcu_read_lock(), so my recent fix
> triggered a LOCKDEP warning when SYNACK is retransmit.
>
> Lets add rcu_read_lock()/rcu_read_unlock() pairs around ireq->ireq_opt
> usages instead of guessing what is done
We have an impressive number of syzkaller bugs that are linked
to the fact that syzbot was able to create a networking device
with millions of TX (or RX) queues.
Let's limit the number of RX/TX queues to 4096, this really should
cover all known cases.
A separate patch will add various
On 10/02/2018 03:05 PM, Eric Dumazet wrote:
> On Tue, Oct 2, 2018 at 2:54 PM Florian Fainelli wrote:
>>
>> On 10/02/2018 02:17 PM, Eric Dumazet wrote:
>>> On Tue, Oct 2, 2018 at 1:07 PM Florian Fainelli
>>> wrote:
Hi Eric, Neil,
Should not __dev_kfree_skb_any() call
On Tue, Oct 2, 2018 at 2:54 PM Florian Fainelli wrote:
>
> On 10/02/2018 02:17 PM, Eric Dumazet wrote:
> > On Tue, Oct 2, 2018 at 1:07 PM Florian Fainelli
> > wrote:
> >>
> >> Hi Eric, Neil,
> >>
> >> Should not __dev_kfree_skb_any() call kfree_skb() instead of
> >> dev_kfree_skb() which is
Hi,
I'm seeing occasional massive delays between packets being received in the
r8169 driver and them turning up in the rxrpc_data_ready() function called by
the UDP or UDP6 ->data_ready() handler. By massive, I mean I've seen anything
up to about 4s. I *think* that the effect gets rapidly worse
On 10/02/2018 02:17 PM, Eric Dumazet wrote:
> On Tue, Oct 2, 2018 at 1:07 PM Florian Fainelli wrote:
>>
>> Hi Eric, Neil,
>>
>> Should not __dev_kfree_skb_any() call kfree_skb() instead of
>> dev_kfree_skb() which is aliased to consumes_skb() and therefore does
>> not flag the skb with
On 10/2/18 1:27 AM, Eelco Chaudron wrote:
> Add support for showing hardware specific counters to easy
> troubleshooting hardware offload.
>
> $ tc -s filter show dev enp3s0np0 parent :
> filter protocol ip pref 1 flower chain 0
> filter protocol ip pref 1 flower chain 0 handle 0x1
>
On 9/28/18 8:03 AM, Simon Horman wrote:
> From: Pieter Jansen van Vuuren
>
> Allow matching on options in Geneve tunnel headers.
>
> The options can be described in the form
> CLASS:TYPE:DATA/CLASS_MASK:TYPE_MASK:DATA_MASK, where CLASS is
> represented as a 16bit hexadecimal value, TYPE as an
Hi Justin,
Please see comments below
-Vijay
> > > diff --git a/net/ncsi/ncsi-cmd.c b/net/ncsi/ncsi-cmd.c
> > > index 7567ca63aae2..2f98533eba46 100644
> > > --- a/net/ncsi/ncsi-cmd.c
> > > +++ b/net/ncsi/ncsi-cmd.c
> > > @@ -211,6 +211,26 @@ static int
On Thu, Sep 27, 2018 at 5:16 PM, wrote:
>
> On 2018-09-27 13:14, Yuchung Cheng wrote:
>>
>> On Wed, Sep 26, 2018 at 5:09 PM, Eric Dumazet wrote:
>>>
>>>
>>>
>>>
>>> On 09/26/2018 04:46 PM, stran...@codeaurora.org wrote:
>>> > Hi Eric,
>>> >
>>> > Someone recently reported a crash to us on the
On Tue, Oct 2, 2018 at 1:07 PM Florian Fainelli wrote:
>
> Hi Eric, Neil,
>
> Should not __dev_kfree_skb_any() call kfree_skb() instead of
> dev_kfree_skb() which is aliased to consumes_skb() and therefore does
> not flag the skb with SKB_REASON_DROPPED?
>
> If we take the in_irq() ||
Hi Vijay,
Please see the comments below.
Thanks,
Justin
> Hi Justin,
> Thanks for response. Please see my comments below.
>
> -Vijay
>
> > > diff --git a/net/ncsi/ncsi-cmd.c b/net/ncsi/ncsi-cmd.c
> > > index 7567ca63aae2..2f98533eba46 100644
> > > --- a/net/ncsi/ncsi-cmd.c
> > > +++
Don't hardcode the dummy program types to SOCKET_FILTER type, as this
prevents testing bpf_tail_call in conjunction with other program types.
Instead, use the program type specified in the test case.
Signed-off-by: Joe Stringer
---
v3: New patch.
v4: No change.
---
Allow the individual program load to be invoked. This will help with
testing, where a single ELF may contain several sections, some of which
denote subprograms that are expected to fail verification, along with
some which are expected to pass verification. By allowing programs to be
iterated and
This patch adds new BPF helper functions, bpf_sk_lookup_tcp() and
bpf_sk_lookup_udp() which allows BPF programs to find out if there is a
socket listening on this host, and returns a socket pointer which the
BPF program can then access to determine, for instance, whether to
forward or drop
reference tracking: leak potential reference
reference tracking: leak potential reference on stack
reference tracking: leak potential reference on stack 2
reference tracking: zero potential reference
reference tracking: copy and zero potential references
reference tracking: release reference
Teach the verifier a little bit about a new type of pointer, a
PTR_TO_SOCKET. This pointer type is accessed from BPF through the
'struct bpf_sock' structure.
Signed-off-by: Joe Stringer
Acked-by: Alexei Starovoitov
---
v2: Reuse reg_type_mismatch() in more places.
Reduce the number of
An upcoming commit will add another two pointer types that need very
similar behaviour, so generalise this function now.
Signed-off-by: Joe Stringer
Acked-by: Alexei Starovoitov
---
kernel/bpf/verifier.c | 22 ++---
Document the new pointer types in the verifier and how the pointer ID
tracking works to ensure that references which are taken are later
released.
Signed-off-by: Joe Stringer
Acked-by: Alexei Starovoitov
---
Documentation/networking/filter.txt | 64 +
1 file
Add some tests that demonstrate and test the balanced lookup/free
nature of socket lookup. Section names that start with "fail" represent
programs that are expected to fail verification; all others should
succeed.
Signed-off-by: Joe Stringer
Acked-by: Alexei Starovoitov
---
v3: Rebase against
Allow helper functions to acquire a reference and return it into a
register. Specific pointer types such as the PTR_TO_SOCKET will
implicitly represent such a reference. The verifier must ensure that
these references are released exactly once in each path through the
program.
To achieve this,
Add this iterator for spilled registers, it concentrates the details of
how to get the current frame's spilled registers into a single macro
while clarifying the intention of the code which is calling the macro.
Signed-off-by: Joe Stringer
Acked-by: Alexei Starovoitov
---
v2-v3: No change.
v4:
The array "reg_type_str" provides canonical formatting of register
types, however a couple of places would previously check whether a
register represented the context and write the name "context" directly.
An upcoming commit will add another pointer type to these statements, so
to provide more
An upcoming commit will need very similar copy/realloc boilerplate, so
refactor the existing stack copy/realloc functions into macros to
simplify it.
Signed-off-by: Joe Stringer
Acked-by: Alexei Starovoitov
---
kernel/bpf/verifier.c | 106 --
1 file
This check will be reused by an upcoming commit for conditional jump
checks for sockets. Refactor it a bit to simplify the later commit.
Signed-off-by: Joe Stringer
Acked-by: Alexei Starovoitov
---
kernel/bpf/verifier.c | 43 +--
1 file changed, 25
This series proposes a new helper for the BPF API which allows BPF programs to
perform lookups for sockets in a network namespace. This would allow programs
to determine early on in processing whether the stack is expecting to receive
the packet, and perform some action (eg drop, forward
On 10/1/18 2:43 AM, Mike Manning wrote:
> Services currently have to be VRF-aware if they are using an unbound
> socket. One cannot have multiple service instances running in the
> default and other VRFs for services that are not VRF-aware and listen
> on an unbound socket. This is because there
Hi Eric, Neil,
Should not __dev_kfree_skb_any() call kfree_skb() instead of
dev_kfree_skb() which is aliased to consumes_skb() and therefore does
not flag the skb with SKB_REASON_DROPPED?
If we take the in_irq() || irqs_disabled() branch, we will be calling
__dev_kfree_skb_irq() which takes care
On Mon, Oct 1, 2018 at 12:47 PM Lorenz Bauer wrote:
>
> Add a new flag BPF_F_ZERO_SEED, which forces a hash map
> to initialize the seed to zero.
> ---
> include/uapi/linux/bpf.h | 2 ++
> kernel/bpf/hashtab.c | 8 ++--
> 2 files changed, 8 insertions(+), 2 deletions(-)
>
> diff --git
On 10/1/18 2:43 AM, Mike Manning wrote:
> From: Duncan Eastoe
>
> If setsockopt(IP_MULTICAST_IF) or setsockopt(IPV6_MULTICAST_IF) is
> called on a socket which is not bound to a VRF then we should ensure
> that the output device chosen is also not bound to a VRF master.
Why does it matter? An
In commit ec3ed293e766 ("net_sched: change tcf_del_walker() to take
idrinfo->lock")
we move fl_hw_destroy_tmplt() to a workqueue to avoid blocking
with the spinlock held. Unfortunately, this causes a lot of
troubles here:
1. tcf_chain_destroy() could be called right after we queue the work
On Tue, 2018-10-02 at 11:41 -0700, David Miller wrote:
> From: Jeff Kirsher
> Date: Tue, 2 Oct 2018 08:24:38 -0700
>
> > This series contains updates to ice driver only.
>
> If there was a problem yo I'll solve it.
> Check out the hook while my DJ revolves it.
>
> Ice ice baby.
> Ice ice
On 10/1/18 2:43 AM, Mike Manning wrote:
> There is no easy way currently for applications that want to receive
> packets in the default VRF to be isolated from packets arriving in
> VRFs, which makes using VRF-unaware applications in a VRF-aware system
> a potential security risk.
please drop
On 10/1/18 2:43 AM, Mike Manning wrote:
> Add a sysctl raw_l3mdev_accept to control raw socket lookup in a manner
> similar to use of tcp_l3mdev_accept for stream and of udp_l3mdev_accept
> for datagram sockets. Have this default to off as this is what users
> expect, given that there is no
Timer handlers do not imply rcu_read_lock(), so my recent fix
triggered a LOCKDEP warning when SYNACK is retransmit.
Lets add rcu_read_lock()/rcu_read_unlock() pairs around ireq->ireq_opt
usages instead of guessing what is done by callers, since it is
not worth the pain.
Get rid of
On Fri, Sep 28, 2018 at 9:47 PM Cong Wang wrote:
>
> Just FYI, the crash is fixed, but another RCU warning pops up after
> my fix. So I am still debugging it, it is related to the kfree_rcu() in
> tcf_chain_destroy().
Update: I tried very hard to make it working, the end result is ugly,
as I
On 10/2/18 10:30 AM, Jiri Benc wrote:
> On Tue, 2 Oct 2018 08:57:24 -0600, David Ahern wrote:
>> You can when you introduce a new option or a new flag that is required
>> to get new behavior like kernel side filtering.
>
> Yes. That was what I tried with the patchset a few years back. It would
>
From: Mahesh Bandewar
RX queue config for bonding master could be different from its slave
device(s). With the commit 6a9e461f6fe4 ("bonding: pass link-local
packets to bonding master also."), the packet is reinjected into stack
with skb->dev as bonding master. This potentially triggers the
Hi Justin,
Thanks for response. Please see my comments below.
-Vijay
> > diff --git a/net/ncsi/ncsi-cmd.c b/net/ncsi/ncsi-cmd.c
> > index 7567ca63aae2..2f98533eba46 100644
> > --- a/net/ncsi/ncsi-cmd.c
> > +++ b/net/ncsi/ncsi-cmd.c
> > @@ -211,6 +211,26 @@ static int
On Tue, Oct 02, 2018 at 11:28:21AM -0700, Chenbo Feng wrote:
> On Tue, Oct 2, 2018 at 11:15 AM Pablo Neira Ayuso wrote:
> >
> > Hi Chenbo,
> >
> > On Tue, Oct 02, 2018 at 10:45:58AM -0700, Chenbo Feng wrote:
> > > On Tue, Oct 2, 2018 at 3:51 AM Pablo Neira Ayuso
> > > wrote:
> > [...]
> > > Do
On Tue, Oct 2, 2018 at 11:39 AM Björn Töpel wrote:
>
> On 2018-10-02 20:23, William Tu wrote:
> > On Tue, Oct 2, 2018 at 1:01 AM Björn Töpel wrote:
> >>
> >> From: Björn Töpel
> >>
> >> Jeff: Please remove the v1 patches from your dev-queue!
> >>
> >> This patch set introduces zero-copy AF_XDP
From: Jeff Kirsher
Date: Tue, 2 Oct 2018 08:24:38 -0700
> This series contains updates to ice driver only.
If there was a problem yo I'll solve it.
Check out the hook while my DJ revolves it.
Ice ice baby.
Ice ice baby.
Pulled, thanks Jeff.
On 2018-10-02 20:23, William Tu wrote:
On Tue, Oct 2, 2018 at 1:01 AM Björn Töpel wrote:
From: Björn Töpel
Jeff: Please remove the v1 patches from your dev-queue!
This patch set introduces zero-copy AF_XDP support for Intel's ixgbe
driver.
The ixgbe zero-copy code is located in its own
From: Sudarsana Reddy Kalluru
Date: Tue, 2 Oct 2018 06:16:10 -0700
> From: Sudarsana Reddy Kalluru
>
> The patch series adds driver support for configuring/reading the 20G link
> speed.
>
> Please consider applying this to "net-next".
Series applied.
On Tue, Oct 2, 2018 at 1:01 AM Björn Töpel wrote:
>
> From: Björn Töpel
>
> This patch prepares for the upcoming zero-copy Tx functionality by
> moving common functions used both by the regular path and zero-copy
> path.
>
> Signed-off-by: Björn Töpel
> ---
Thanks!
Tested-by: William Tu
On Tue, Oct 2, 2018 at 1:01 AM Björn Töpel wrote:
>
> From: Björn Töpel
>
> This patch prepares for the upcoming zero-copy Rx functionality, by
> moving/changing linkage of common functions, used both by the regular
> path and zero-copy path.
>
> Signed-off-by: Björn Töpel
> ---
Thanks!
From:
Date: Tue, 2 Oct 2018 14:49:32 +0200
> From: Rickard x Andersson
>
> During certain heavy network loads TX could time out
> with TX ring dump.
> TX is sometimes never restarted after reaching
> "tx_stop_threshold" because function "fec_enet_tx_queue"
> only tests the first queue.
>
> In
On Tue, Oct 2, 2018 at 1:01 AM Björn Töpel wrote:
>
> From: Björn Töpel
>
> This patch adds zero-copy Tx support for AF_XDP sockets. It implements
> the ndo_xsk_async_xmit netdev ndo and performs all the Tx logic from a
> NAPI context. This means pulling egress packets from the Tx ring,
>
On Tue, Oct 2, 2018 at 1:01 AM Björn Töpel wrote:
>
> From: Björn Töpel
>
> This patch adds zero-copy Rx support for AF_XDP sockets. Instead of
> allocating buffers of type MEM_TYPE_PAGE_SHARED, the Rx frames are
> allocated as MEM_TYPE_ZERO_COPY when AF_XDP is enabled for a certain
> queue.
>
>
On Tue, Oct 2, 2018 at 1:01 AM Björn Töpel wrote:
>
> From: Björn Töpel
>
> Add functions for Rx/Tx ring enable/disable. Instead of resetting the
> whole device, only the affected ring is disabled or enabled.
>
> This plumbing is used in later commits, when zero-copy AF_XDP support
> is
From: Mike Manning
Date: Tue, 2 Oct 2018 12:40:30 +0100
> This reverts commit 0ed4229b08c1 ("ipv6: defrag: drop non-last frags
> smaller than min mtu"). While one should not get fragments smaller than
> the IPv6 minimum MTU, not handling crafted packets in the TAHI IPv6
> conformance test suite
On 10/01/2018 03:43 PM, David Miller wrote:
> From: Eric Dumazet
> Date: Mon, 1 Oct 2018 15:02:26 -0700
>> This patch extends what I did in commit 449809a66c1d ("tcp/dccp:
>> block BH for SYN processing") by adding an extra rcu_read_{lock|unlock}
>> pair in the paths that might be taken when
On Tue, Oct 2, 2018 at 1:01 AM Björn Töpel wrote:
>
> From: Björn Töpel
>
> Jeff: Please remove the v1 patches from your dev-queue!
>
> This patch set introduces zero-copy AF_XDP support for Intel's ixgbe
> driver.
>
> The ixgbe zero-copy code is located in its own file ixgbe_xsk.[ch],
>
From: Paolo Abeni
Date: Tue, 2 Oct 2018 11:03:40 +0200
> This helper is unused since commit 988cf74deb45 ("inet:
> Stop generating UFO packets.")
>
> Signed-off-by: Paolo Abeni
Applied.
Hi Sam,
Sure, I will generate v3 after Vijay's patch is approved.
Thanks,
Justin
> On Fri, 2018-09-28 at 18:15 +, justin.l...@dell.com wrote:
> > The new command (NCSI_CMD_SEND_CMD) is added to allow user space
> > application
> > to send NC-SI command to the network card.
> > Also, add
When FW floods the driver with control messages try to exit the cmsg
processing loop every now and then to avoid soft lockups. Cmsg
processing is generally very lightweight so 512 seems like a reasonable
budget, which should not be exceeded under normal conditions.
Fixes: 77ece8d5f196 ("nfp: add
On Tue, 2 Oct 2018 14:35:18 +0900, Prashant Bhole wrote:
> Since map lookup error can be ENOENT or EOPNOTSUPP, let's print
> strerror() as error message in normal and JSON output.
>
> This patch adds helper function print_entry_error() to print
> entry from lookup error occurs
>
> Example:
On Tue, 2 Oct 2018 14:35:17 +0900, Prashant Bhole wrote:
> do_dump() function in bpftool/map.c has deep indentations. In order
> to reduce deep indent, let's move element printing code out of
> do_dump() into dump_map_elem() function.
>
> Signed-off-by: Prashant Bhole
Acked-by: Jakub Kicinski
On Tue, 2 Oct 2018 14:49:13 +0200, Magnus Karlsson wrote:
> On Mon, Oct 1, 2018 at 10:34 PM Jakub Kicinski wrote:
> > On Mon, 1 Oct 2018 14:51:32 +0200, Magnus Karlsson wrote:
> > > Jakub, please take a look at your patches. The last one I had to
> > > change slightly to make it fit with the
Hi Vijay,
Looks good. Please see my comment below.
Thanks,
Justin
> On Fri, 2018-09-28 at 18:06 -0700, Vijay Khemka wrote:
> > This patch adds OEM commands and response handling. It also defines OEM
> > command and response structure as per NCSI specification along with its
> > handlers.
> >
On Fri, 28 Sep 2018 at 06:38, Daniel Borkmann wrote:
>
> On 09/28/2018 01:26 AM, Joe Stringer wrote:
> > Teach the verifier a little bit about a new type of pointer, a
> > PTR_TO_SOCKET. This pointer type is accessed from BPF through the
> > 'struct bpf_sock' structure.
> >
> > Signed-off-by: Joe
On Tue, 2 Oct 2018 08:55:19 -0600, David Ahern wrote:
> You want take issue with a name suggest a different one.
I don't have a strong opinion on this. STRICT_HDR? HDR_CHECKED?
VERIFY_HDR? If you feel that your proposal is better, I don't mind.
Thanks,
Jiri
On Tue, 2 Oct 2018 08:57:24 -0600, David Ahern wrote:
> You can when you introduce a new option or a new flag that is required
> to get new behavior like kernel side filtering.
Yes. That was what I tried with the patchset a few years back. It would
be nice to revive the effort.
> I chose a
On Tue, 2 Oct 2018 09:11:17 -0600, David Ahern wrote:
> Generically speaking a filter modifies the output based on the input.
> Specifying a target namespace is an input to the dump that modifies the
> output.
That's conventionally called "algorithm" :-)
Let's just say we have a different
From: Dave Ertman
We are currently replaying the link state of a port after a reset, but
it is possible that the link state of a port can change during the reset
process. So check for the current link state of a port during the rebuild
process of a reset.
Signed-off-by: Dave Ertman
From: Brett Creeley
Currently there is no support for dynamic interrupt moderation. This
patch adds some initial code to support this. The following changes
were made:
1. Currently we are using multiple members to store the interrupt
granularity (itr_gran_25/50/100/200). This is not
From: Anirudh Venkataramanan
A VSI handle is just a number the driver maintains to uniquely identify
a VSI. A VSI handle is backed by a VSI number in the hardware. When
interacting when the hardware, VSI handles are converted into VSI numbers.
In commit 0f9d5027a749 ("ice: Refactor VSI
From: Preethi Banala
For the PF driver, when mapping interrupts to queues, we need to request
IRQs from the kernel and we also have to allocate interrupts from
the device.
Similarly, when the VF driver (iavf.ko) initializes, it requests the kernel
IRQs that it needs but it can't directly
From: Anirudh Venkataramanan
This patch is a continuation of the previous patch where VSI
handles are used instead of VSI numbers.
Signed-off-by: Anirudh Venkataramanan
Tested-by: Andrew Bowers
Signed-off-by: Jeff Kirsher
---
drivers/net/ethernet/intel/ice/ice_common.c | 71 +
From: Brett Creeley
Currently the ice_reset_req enum values have to be translated into
a different set of values that the hardware understands for the same
reset types. Avoid this translation by aligning ice_reset_req enum
values to the ones that the hardware understands.
Also add and else if
From: Dave Ertman
If the driver is unloaded when traffic is in progress, errors are
generated. Fix this by releasing qvectors and NAPI handler on remove.
Signed-off-by: Dave Ertman
Signed-off-by: Anirudh Venkataramanan
Tested-by: Andrew Bowers
Signed-off-by: Jeff Kirsher
---
From: Anirudh Venkataramanan
Currently, switch filters get replayed after reset. In addition to
filters, other VSI attributes (like RSS configuration, Tx scheduler
configuration, etc.) also need to be replayed after reset.
Thus, instead of replaying based on functional blocks (i.e. replay
all
From: Md Fahad Iqbal Polash
This patch implements ethtool hook for enabling/disabling
RSS. While disabling RSS, the LUT should be cleared. And
the LUT should be reconfigured while enabling RSS.
Signed-off-by: Md Fahad Iqbal Polash
Signed-off-by: Anirudh Venkataramanan
Tested-by: Andrew Bowers
This series contains updates to ice driver only.
Anirudh expands the use of VSI handles across the rest of the driver,
which includes refactoring the code to correctly use VSI handles. After
a reset, ensure that all configurations for a VSI get re-applied before
moving on to rebuilding the next
On 10/2/18 4:54 AM, Jiri Benc wrote:
> On Mon, 1 Oct 2018 17:28:28 -0700, David Ahern wrote:
>> Pull the inet6_fill_args arg up to in6_dump_addrs and move netnsid
>> into it. Since IFA_TARGET_NETNSID is a kernel side filter add the
>> NLM_F_DUMP_FILTERED flag so userspace knows the request was
On 10/2/18 5:27 AM, Jiri Benc wrote:
> On Tue, 2 Oct 2018 13:18:32 +0200, Christian Brauner wrote:
>> I didn't find this in the linked thread.
>
> Maybe it was suggested in another thread or in person on a conference,
> I can't remember, it's too long ago, sorry.
>
>> What I find interesting and
1 - 100 of 150 matches
Mail list logo
