Inquiry 09-10-2018

2018-10-09 Thread Daniel Murray
Hi,friend, This is Daniel Murray and i am from Sinara Group Co.Ltd Group Co.,LTD in Russia. We are glad to know about your company from the web and we are interested in your products. Could you kindly send us your Latest catalog and price list for our trial order. Best Regards, Daniel Murray

Re: [PATCH bpf-next] tools/bpf: use proper type and uapi perf_event.h header for libbpf

2018-10-09 Thread Alexei Starovoitov
On Tue, Oct 09, 2018 at 04:14:47PM -0700, Yonghong Song wrote: > Use __u32 instead u32 in libbpf.c and also use > uapi perf_event.h instead of tools/perf/perf-sys.h. > > Signed-off-by: Yonghong Song Applied, Thanks

Re: [bpf-next V2 PATCH 0/3] bpf/xdp: fix generic-XDP and demonstrate VLAN manipulation

2018-10-09 Thread Alexei Starovoitov
On Tue, Oct 09, 2018 at 12:04:37PM +0200, Jesper Dangaard Brouer wrote: > While implementing PoC building blocks for eBPF code XDP+TC that can > manipulate VLANs headers, I discovered a bug in generic-XDP. > > The fix should be backported to stable kernels. Even-though > generic-XDP was

Re: [PATCH bpf-next 0/6] Error handling when map lookup isn't supported

2018-10-09 Thread Alexei Starovoitov
On Tue, Oct 09, 2018 at 10:04:48AM +0900, Prashant Bhole wrote: > Currently when map a lookup fails, user space API can not make any > distinction whether given key was not found or lookup is not supported > by particular map. > > In this series we modify return value of maps which do not support

Re: [PATCH net-next v3] net/ncsi: Extend NC-SI Netlink interface to allow user space to send NC-SI command

2018-10-09 Thread Samuel Mendoza-Jonas
On Mon, 2018-10-08 at 23:13 +, justin.l...@dell.com wrote: > The new command (NCSI_CMD_SEND_CMD) is added to allow user space > application to send NC-SI command to the network card. > Also, add a new attribute (NCSI_ATTR_DATA) for transferring request and > response. > > The work flow is

Re: [PATCH stable 4.9 00/29] backport of IP fragmentation fixes

2018-10-09 Thread Florian Fainelli
On 10/09/18 17:46, Eric Dumazet wrote: > > > On 10/09/2018 03:48 PM, Florian Fainelli wrote: >> This is based on Stephen's v4.14 patches, with the necessary merge >> conflicts, and the lack of timer_setup() on the 4.9 baseline. >> >> Perf results on a gigabit capable system, before and after

Re: [PATCH net-next] net: enable RPS on vlan devices

2018-10-09 Thread Eric Dumazet
On 10/09/2018 07:11 PM, Shannon Nelson wrote: > > Hence the reason we sent this as an RFC a couple of weeks ago.  We got no > response, so followed up with this patch in order to get some input. Do you > have any suggestions for how we might accomplish this in a less ugly way? I dunno,

Re: [PATCH net-next] net: enable RPS on vlan devices

2018-10-09 Thread Shannon Nelson
On 10/9/2018 6:04 PM, Eric Dumazet wrote: On 10/09/2018 05:41 PM, Shannon Nelson wrote: From: Silviu Smarandache This patch modifies the RPS processing code so that it searches for a matching vlan interface on the packet and then uses the RPS settings of the vlan interface.  If no vlan

Inquiry 09-10-2018

2018-10-09 Thread Daniel Murray
Hi,friend, This is Daniel Murray and i am from Sinara Group Co.Ltd Group Co.,LTD in Russia. We are glad to know about your company from the web and we are interested in your products. Could you kindly send us your Latest catalog and price list for our trial order. Best Regards, Daniel Murray

[PATCH v3] rxrpc: use correct kvec num while send response packet in rxrpc_reject_packets

2018-10-09 Thread YueHaibing
Fixes gcc '-Wunused-but-set-variable' warning: net/rxrpc/output.c: In function 'rxrpc_reject_packets': net/rxrpc/output.c:527:11: warning: variable 'ioc' set but not used [-Wunused-but-set-variable] 'ioc' is the correct kvec num while send response packet. Fixes: ece64fec164f ("rxrpc: Emit

Re: [PATCH v2] rxrpc: use correct kvec num while send response packet in rxrpc_reject_packets

2018-10-09 Thread YueHaibing
On 2018/10/9 23:34, Sergei Shtylyov wrote: > On 10/09/2018 05:15 PM, YueHaibing wrote: > >> Fixes gcc '-Wunused-but-set-variable' warning: >> >> net/rxrpc/output.c: In function 'rxrpc_reject_packets': >> net/rxrpc/output.c:527:11: warning: >> variable 'ioc' set but not used

Re: [sky2 driver] 88E8056 PCI-E Gigabit Ethernet Controller not working after suspend

2018-10-09 Thread Laurent Bigonville
Le 9/10/18 à 22:09, Stephen Hemminger a écrit : On Tue, 9 Oct 2018 19:30:30 +0200 Laurent Bigonville wrote: Hello, On my desktop (Asus MB with dual Ethernet port), when waking up after suspend, the network card is not detecting the link. I have to rmmod the sky2 driver and then modprobing

Re: [PATCH net-next] net: enable RPS on vlan devices

2018-10-09 Thread Eric Dumazet
On 10/09/2018 05:41 PM, Shannon Nelson wrote: > From: Silviu Smarandache > > This patch modifies the RPS processing code so that it searches > for a matching vlan interface on the packet and then uses the > RPS settings of the vlan interface.  If no vlan interface > is found or the vlan

Re: [PATCH stable 4.9 00/29] backport of IP fragmentation fixes

2018-10-09 Thread Eric Dumazet
On 10/09/2018 03:48 PM, Florian Fainelli wrote: > This is based on Stephen's v4.14 patches, with the necessary merge > conflicts, and the lack of timer_setup() on the 4.9 baseline. > > Perf results on a gigabit capable system, before and after are below. > > Series can also be found here: >

[PATCH net-next] net: enable RPS on vlan devices

2018-10-09 Thread Shannon Nelson
From: Silviu Smarandache This patch modifies the RPS processing code so that it searches for a matching vlan interface on the packet and then uses the RPS settings of the vlan interface.  If no vlan interface is found or the vlan interface does not have RPS enabled, it will fall back to the RPS

[PATCH net 2/2] net: dsa: bcm_sf2: Call setup during switch resume

2018-10-09 Thread Florian Fainelli
There is no reason to open code what the switch setup function does, in fact, because we just issued a switch reset, we would make all the register get their default values, including for instance, having unused port be enabled again and wasting power and leading to an inappropriate switch core

[PATCH net 1/2] net: dsa: bcm_sf2: Fix unbind ordering

2018-10-09 Thread Florian Fainelli
The order in which we release resources is unfortunately leading to bus errors while dismantling the port. This is because we set priv->wol_ports_mask to 0 to tell bcm_sf2_sw_suspend() that it is now permissible to clock gate the switch. Later on, when dsa_slave_destroy() comes in from

[PATCH net 0/2] net: dsa: bcm_sf2: Couple of fixes

2018-10-09 Thread Florian Fainelli
Hi David, Here are two fixes for the bcm_sf2 driver that were found during testing unbind and analysing another issue during system suspend/resume. Thanks! Florian Fainelli (2): net: dsa: bcm_sf2: Fix unbind ordering net: dsa: bcm_sf2: Call setup during switch resume

Re: [PATCH bpf-next] tools/bpf: use proper type and uapi perf_event.h header for libbpf

2018-10-09 Thread Song Liu
> On Oct 9, 2018, at 4:14 PM, Yonghong Song wrote: > > Use __u32 instead u32 in libbpf.c and also use > uapi perf_event.h instead of tools/perf/perf-sys.h. > > Signed-off-by: Yonghong Song Acked-by: Song Liu > --- > tools/lib/bpf/Makefile | 2 +- > tools/lib/bpf/libbpf.c | 8 > 2

Re: [PATCH net-next] net/ipv6: Add knob to skip DELROUTE message on device down

2018-10-09 Thread David Ahern
On 10/9/18 3:27 PM, David Ahern wrote: > From: David Ahern > > Another difference between IPv4 and IPv6 is the generation of RTM_DELROUTE > notifications when a device is taken down (admin down) or deleted. IPv4 > does not generate a message for routes evicted by the down or delete; > IPv6 does.

[PATCH bpf-next] tools/bpf: use proper type and uapi perf_event.h header for libbpf

2018-10-09 Thread Yonghong Song
Use __u32 instead u32 in libbpf.c and also use uapi perf_event.h instead of tools/perf/perf-sys.h. Signed-off-by: Yonghong Song --- tools/lib/bpf/Makefile | 2 +- tools/lib/bpf/libbpf.c | 8 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/tools/lib/bpf/Makefile

[PATCH net-next v2 2/2] FDDI: defza: Support capturing outgoing SMT traffic

2018-10-09 Thread Maciej W. Rozycki
DEC FDDIcontroller 700 (DEFZA) uses a Tx/Rx queue pair to communicate SMT frames with adapter's firmware. Any SMT frame received from the RMC via the Rx queue is queued back by the driver to the SMT Rx queue for the firmware to process. Similarly the firmware uses the SMT Tx queue to supply

[PATCH net-next v2 1/2] FDDI: defza: Add support for DEC FDDIcontroller 700 TURBOchannel adapter

2018-10-09 Thread Maciej W. Rozycki
Add support for the DEC FDDIcontroller 700 (DEFZA), Digital Equipment Corporation's first-generation FDDI network interface adapter, made for TURBOchannel and based on a discrete version of what eventually became Motorola's widely used CAMEL chipset. The CAMEL chipset is present for example in

[PATCH net-next v2 0/2] FDDI: DEC FDDIcontroller 700 TURBOchannel adapter support

2018-10-09 Thread Maciej W. Rozycki
Hi, This is an update to . I believe I have addressed all the requests made in the previous review round. There is still one `checkpatch.pl' warning remaining: WARNING: quoted string split across lines #1652: FILE: drivers/net/fddi/defza.c:1442: +

[PATCH stable 4.9 27/29] ip: add helpers to process in-order fragments faster.

2018-10-09 Thread Florian Fainelli
From: Peter Oskolkov This patch introduces several helper functions/macros that will be used in the follow-up patch. No runtime changes yet. The new logic (fully implemented in the second patch) is as follows: * Nodes in the rb-tree will now contain not single fragments, but lists of

[PATCH stable 4.9 28/29] ip: process in-order fragments efficiently

2018-10-09 Thread Florian Fainelli
From: Peter Oskolkov This patch changes the runtime behavior of IP defrag queue: incoming in-order fragments are added to the end of the current list/"run" of in-order fragments at the tail. On some workloads, UDP stream performance is substantially improved: RX: ./udp_stream -F 10 -T 2 -l 60

[PATCH stable 4.9 13/29] inet: frags: do not clone skb in ip_expire()

2018-10-09 Thread Florian Fainelli
From: Eric Dumazet An skb_clone() was added in commit ec4fbd64751d ("inet: frag: release spinlock before calling icmp_send()") While fixing the bug at that time, it also added a very high cost for DDOS frags, as the ICMP rate limit is applied after this expensive operation (skb_clone() +

[PATCH stable 4.9 29/29] ip: frags: fix crash in ip_do_fragment()

2018-10-09 Thread Florian Fainelli
From: Taehee Yoo commit 5d407b071dc369c26a38398326ee2be53651cfe4 upstream A kernel crash occurrs when defragmented packet is fragmented in ip_do_fragment(). In defragment routine, skb_orphan() is called and skb->ip_defrag_offset is set. but skb->sk and skb->ip_defrag_offset are same union

[PATCH stable 4.9 25/29] net: sk_buff rbnode reorg

2018-10-09 Thread Florian Fainelli
From: Eric Dumazet commit bffa72cf7f9df842f0016ba03586039296b4caaf upstream skb->rbnode shares space with skb->next, skb->prev and skb->tstamp Current uses (TCP receive ofo queue and netem) need to save/restore tstamp, while skb->dev is either NULL (TCP) or a constant for a given queue

[PATCH stable 4.9 26/29] ipv4: frags: precedence bug in ip_expire()

2018-10-09 Thread Florian Fainelli
From: Dan Carpenter We accidentally removed the parentheses here, but they are required because '!' has higher precedence than '&'. Fixes: fa0f527358bd ("ip: use rb trees for IP frag queue.") Signed-off-by: Dan Carpenter Signed-off-by: David S. Miller (cherry picked from commit

[PATCH stable 4.9 11/29] inet: frags: remove inet_frag_maybe_warn_overflow()

2018-10-09 Thread Florian Fainelli
From: Eric Dumazet This function is obsolete, after rhashtable addition to inet defrag. Signed-off-by: Eric Dumazet Signed-off-by: David S. Miller (cherry picked from commit 2d44ed22e607f9a285b049de2263e3840673a260) --- include/net/inet_frag.h | 2 --

[PATCH stable 4.9 18/29] inet: frags: fix ip6frag_low_thresh boundary

2018-10-09 Thread Florian Fainelli
From: Eric Dumazet Giving an integer to proc_doulongvec_minmax() is dangerous on 64bit arches, since linker might place next to it a non zero value preventing a change to ip6frag_low_thresh. ip6frag_low_thresh is not used anymore in the kernel, but we do not want to prematuraly break user

[PATCH stable 4.9 04/29] inet: frags: refactor ipv6_frag_init()

2018-10-09 Thread Florian Fainelli
From: Eric Dumazet We want to call inet_frags_init() earlier. This is a prereq to "inet: frags: use rhashtables for reassembly units" Signed-off-by: Eric Dumazet Signed-off-by: David S. Miller (cherry picked from commit 5b975bab23615cd0fdf67af6c9298eb01c4b9f61) --- net/ipv6/reassembly.c |

[PATCH stable 4.9 16/29] inet: frags: reorganize struct netns_frags

2018-10-09 Thread Florian Fainelli
From: Eric Dumazet Put the read-mostly fields in a separate cache line at the beginning of struct netns_frags, to reduce false sharing noticed in inet_frag_kill() Signed-off-by: Eric Dumazet Signed-off-by: David S. Miller (cherry picked from commit c2615cf5a761b32bf74e85bddc223dfff3d9b9f0)

[PATCH stable 4.9 21/29] net: modify skb_rbtree_purge to return the truesize of all purged skbs.

2018-10-09 Thread Florian Fainelli
From: Peter Oskolkov Tested: see the next patch is the series. Suggested-by: Eric Dumazet Signed-off-by: Peter Oskolkov Signed-off-by: Eric Dumazet Cc: Florian Westphal Signed-off-by: David S. Miller (cherry picked from commit 385114dec8a49b5e5945e77ba7de6356106713f4) ---

[PATCH stable 4.9 19/29] ip: discard IPv4 datagrams with overlapping segments.

2018-10-09 Thread Florian Fainelli
From: Peter Oskolkov This behavior is required in IPv6, and there is little need to tolerate overlapping fragments in IPv4. This change simplifies the code and eliminates potential DDoS attack vectors. Tested: ran ip_defrag selftest (not yet available uptream). Suggested-by: David S. Miller

[PATCH stable 4.9 17/29] inet: frags: get rid of ipfrag_skb_cb/FRAG_CB

2018-10-09 Thread Florian Fainelli
From: Eric Dumazet ip_defrag uses skb->cb[] to store the fragment offset, and unfortunately this integer is currently in a different cache line than skb->next, meaning that we use two cache lines per skb when finding the insertion point. By aliasing skb->ip_defrag_offset and skb->dev, we pack

[PATCH stable 4.9 20/29] net: speed up skb_rbtree_purge()

2018-10-09 Thread Florian Fainelli
From: Eric Dumazet As measured in my prior patch ("sch_netem: faster rb tree removal"), rbtree_postorder_for_each_entry_safe() is nice looking but much slower than using rb_next() directly, except when tree is small enough to fit in CPU caches (then the cost is the same) Also note that there is

[PATCH stable 4.9 06/29] ipv6: export ip6 fragments sysctl to unprivileged users

2018-10-09 Thread Florian Fainelli
From: Eric Dumazet IPv4 was changed in commit 52a773d645e9 ("net: Export ip fragment sysctl to unprivileged users") The only sysctl that is not per-netns is not used : ip6frag_secret_interval Signed-off-by: Eric Dumazet Cc: Nikolay Borisov Signed-off-by: David S. Miller (cherry picked from

[PATCH stable 4.9 12/29] inet: frags: break the 2GB limit for frags storage

2018-10-09 Thread Florian Fainelli
From: Eric Dumazet Some users are willing to provision huge amounts of memory to be able to perform reassembly reasonnably well under pressure. Current memory tracking is using one atomic_t and integers. Switch to atomic_long_t so that 64bit arches can use more than 2GB, without any cost for

[PATCH stable 4.9 22/29] ipv6: defrag: drop non-last frags smaller than min mtu

2018-10-09 Thread Florian Fainelli
From: Florian Westphal don't bother with pathological cases, they only waste cycles. IPv6 requires a minimum MTU of 1280 so we should never see fragments smaller than this (except last frag). v3: don't use awkward "-offset + len" v2: drop IPv4 part, which added same check w. IPV4_MIN_MTU (68).

[PATCH stable 4.9 15/29] rhashtable: reorganize struct rhashtable layout

2018-10-09 Thread Florian Fainelli
From: Eric Dumazet While under frags DDOS I noticed unfortunate false sharing between @nelems and @params.automatic_shrinking Move @nelems at the end of struct rhashtable so that first cache line is shared between all cpus, because almost never dirtied. Signed-off-by: Eric Dumazet

[PATCH stable 4.9 08/29] inet: frags: use rhashtables for reassembly units

2018-10-09 Thread Florian Fainelli
From: Eric Dumazet Some applications still rely on IP fragmentation, and to be fair linux reassembly unit is not working under any serious load. It uses static hash tables of 1024 buckets, and up to 128 items per bucket (!!!) A work queue is supposed to garbage collect items when host is under

[PATCH stable 4.9 07/29] rhashtable: add schedule points

2018-10-09 Thread Florian Fainelli
From: Eric Dumazet Rehashing and destroying large hash table takes a lot of time, and happens in process context. It is safe to add cond_resched() in rhashtable_rehash_table() and rhashtable_free_and_destroy() Signed-off-by: Eric Dumazet Acked-by: Herbert Xu Signed-off-by: David S. Miller

[PATCH stable 4.9 09/29] inet: frags: remove some helpers

2018-10-09 Thread Florian Fainelli
From: Eric Dumazet Remove sum_frag_mem_limit(), ip_frag_mem() & ip6_frag_mem() Also since we use rhashtable we can bring back the number of fragments in "grep FRAG /proc/net/sockstat /proc/net/sockstat6" that was removed in commit 434d305405ab ("inet: frag: don't account number of fragment

[PATCH stable 4.9 14/29] ipv6: frags: rewrite ip6_expire_frag_queue()

2018-10-09 Thread Florian Fainelli
From: Eric Dumazet Make it similar to IPv4 ip_expire(), and release the lock before calling icmp functions. Signed-off-by: Eric Dumazet Signed-off-by: David S. Miller (cherry picked from commit 05c0b86b9696802fd0ce5676a92a63f1b455bdf3) --- net/ipv6/reassembly.c | 24

[PATCH stable 4.9 23/29] net: pskb_trim_rcsum() and CHECKSUM_COMPLETE are friends

2018-10-09 Thread Florian Fainelli
From: Eric Dumazet After working on IP defragmentation lately, I found that some large packets defeat CHECKSUM_COMPLETE optimization because of NIC adding zero paddings on the last (small) fragment. While removing the padding with pskb_trim_rcsum(), we set skb->ip_summed to CHECKSUM_NONE,

[PATCH stable 4.9 10/29] inet: frags: get rif of inet_frag_evicting()

2018-10-09 Thread Florian Fainelli
From: Eric Dumazet This refactors ip_expire() since one indentation level is removed. Note: in the future, we should try hard to avoid the skb_clone() since this is a serious performance cost. Under DDOS, the ICMP message wont be sent because of rate limits. Fact that ip6_expire_frag_queue()

[PATCH stable 4.9 24/29] net: add rb_to_skb() and other rb tree helpers

2018-10-09 Thread Florian Fainelli
From: Eric Dumazet Geeralize private netem_rb_to_skb() TCP rtx queue will soon be converted to rb-tree, so we will need skb_rbtree_walk() helpers. Signed-off-by: Eric Dumazet Signed-off-by: David S. Miller (cherry picked from commit 18a4c0eab2623cc95be98a1e6af1ad18e7695977) ---

[PATCH stable 4.9 01/29] inet: frags: change inet_frags_init_net() return value

2018-10-09 Thread Florian Fainelli
From: Eric Dumazet We will soon initialize one rhashtable per struct netns_frags in inet_frags_init_net(). This patch changes the return value to eventually propagate an error. Signed-off-by: Eric Dumazet Signed-off-by: David S. Miller (cherry picked from commit

[PATCH stable 4.9 02/29] inet: frags: add a pointer to struct netns_frags

2018-10-09 Thread Florian Fainelli
From: Eric Dumazet In order to simplify the API, add a pointer to struct inet_frags. This will allow us to make things less complex. These functions no longer have a struct inet_frags parameter : inet_frag_destroy(struct inet_frag_queue *q /*, struct inet_frags *f */) inet_frag_put(struct

[PATCH stable 4.9 00/29] backport of IP fragmentation fixes

2018-10-09 Thread Florian Fainelli
This is based on Stephen's v4.14 patches, with the necessary merge conflicts, and the lack of timer_setup() on the 4.9 baseline. Perf results on a gigabit capable system, before and after are below. Series can also be found here: https://github.com/ffainelli/linux/commits/fragment-stack-v4.9

[PATCH stable 4.9 03/29] inet: frags: refactor ipfrag_init()

2018-10-09 Thread Florian Fainelli
From: Eric Dumazet We need to call inet_frags_init() before register_pernet_subsys(), as a prereq for following patch ("inet: frags: use rhashtables for reassembly units") Signed-off-by: Eric Dumazet Signed-off-by: David S. Miller (cherry picked from commit

[PATCH stable 4.9 05/29] inet: frags: refactor lowpan_net_frag_init()

2018-10-09 Thread Florian Fainelli
From: Eric Dumazet We want to call lowpan_net_frag_init() earlier. Similar to commit "inet: frags: refactor ipv6_frag_init()" This is a prereq to "inet: frags: use rhashtables for reassembly units" Signed-off-by: Eric Dumazet Signed-off-by: David S. Miller (cherry picked from commit

[net-next:master 375/375] drivers/net//ethernet/chelsio/cxgb4/cxgb4_thermal.c:48:11: error: 'struct adapter' has no member named 'ch_thermal'

2018-10-09 Thread kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git master head: b187191577629b5358acf4e234809ee8d441ceb4 commit: b187191577629b5358acf4e234809ee8d441ceb4 [375/375] cxgb4: Add thermal zone support config: parisc-allmodconfig (attached as .config) compiler:

[PATCH net-next] net: sched: avoid writing on noop_qdisc

2018-10-09 Thread Eric Dumazet
While noop_qdisc.gso_skb and noop_qdisc.skb_bad_txq are not used in other places, it seems not correct to overwrite their fields in dev_init_scheduler_queue(). noop_qdisc is essentially a shared and read-only object, even if it is not marked as const because of some implementation detail.

Re: [PATCH bpf-next 0/6] Consistent prefixes for libbpf interfaces

2018-10-09 Thread Daniel Borkmann
On 10/09/2018 08:43 AM, Yonghong Song wrote: > On 10/4/18 7:22 AM, Daniel Borkmann wrote: >> [ +Yonghong ] >> >> On 10/04/2018 12:26 AM, Andrey Ignatov wrote: >>> This patch set renames a few interfaces in libbpf, mostly netlink related, >>> so that all symbols provided by the library have only

Re: [PATCH net v2] net/sched: cls_api: add missing validation of netlink attributes

2018-10-09 Thread Cong Wang
On Tue, Oct 9, 2018 at 2:26 PM Davide Caratti wrote: > --- a/net/sched/sch_api.c > +++ b/net/sched/sch_api.c > @@ -1322,6 +1322,7 @@ const struct nla_policy rtm_tca_policy[TCA_MAX + 1] = { > [TCA_INGRESS_BLOCK] = { .type = NLA_U32 }, > [TCA_EGRESS_BLOCK] = { .type =

[PATCH net-next] net/ipv6: Add knob to skip DELROUTE message on device down

2018-10-09 Thread David Ahern
From: David Ahern Another difference between IPv4 and IPv6 is the generation of RTM_DELROUTE notifications when a device is taken down (admin down) or deleted. IPv4 does not generate a message for routes evicted by the down or delete; IPv6 does. A NOS at scale really needs to avoid these

[PATCH net v2] net/sched: cls_api: add missing validation of netlink attributes

2018-10-09 Thread Davide Caratti
Similarly to what has been done in 8b4c3cdd9dd8 ("net: sched: Add policy validation for tc attributes"), fix classifier code to add validation of TCA_CHAIN and TCA_KIND netlink attributes. tested with: # ./tdc.py -c filter v2: let sch_api and cls_api share nla_policy they have in common, thanks

Re: [PATCH V1 net-next 00/12] Improving performance and reducing latencies, by using latest capabilities exposed in ENA device

2018-10-09 Thread Bshara, Saeed
Jesper, currently the driver allocate page per rx buffer, but we are considering to support mode where page split to 2 buffers in order to overcome memory fragmentation issue on low memory systems. but, this won't work with XDP, right? what's your advice? From: Bshara, Nafea Sent: Tuesday,

Re: [PATCH V1 net-next 00/12] Improving performance and reducing latencies, by using latest capabilities exposed in ENA device

2018-10-09 Thread Machulsky, Zorik
Acked-by: Zorik Machulsky On 10/9/18, 11:45 AM, "akiy...@amazon.com" wrote: From: Arthur Kiyanovski This patchset introduces the following: 1. A new placement policy of Tx headers and descriptors, which takes advantage of an option to place headers + descriptors in

Re: [PATCH net-next v2] net: core: change bool members of struct net_device to bitfield members

2018-10-09 Thread Eric Dumazet
On 10/09/2018 01:24 PM, Heiner Kallweit wrote: > Reordering the struct members to fill the holes could be a little tricky > and could have side effects because it may make a performance difference > whether certain members are in one cacheline or not. > And whether it's worth to spend this

Re: [PATCH net-next v2] net: core: change bool members of struct net_device to bitfield members

2018-10-09 Thread David Ahern
On 10/9/18 2:24 PM, Heiner Kallweit wrote: > Reordering the struct members to fill the holes could be a little tricky > and could have side effects because it may make a performance difference > whether certain members are in one cacheline or not. > And whether it's worth to spend this effort

Re: [PATCH net-next v2] net: core: change bool members of struct net_device to bitfield members

2018-10-09 Thread Heiner Kallweit
On 09.10.2018 17:20, David Ahern wrote: > On 10/8/18 2:17 PM, Heiner Kallweit wrote: >> bool is good as parameter type or function return type, but if used >> for struct members it consumes more memory than needed. >> Changing the bool members of struct net_device to bitfield members >> allows to

Re: [PATCH] qtnfmac: avoid uninitialized variable access

2018-10-09 Thread Sergey Matyukevich
Hello Arnd, > When qtnf_trans_send_cmd_with_resp() fails, we have not yet initialized > 'resp', as pointed out by a valid gcc warning: > > drivers/net/wireless/quantenna/qtnfmac/commands.c: In function > 'qtnf_cmd_send_with_reply': > drivers/net/wireless/quantenna/qtnfmac/commands.c:133:54:

Re: [sky2 driver] 88E8056 PCI-E Gigabit Ethernet Controller not working after suspend

2018-10-09 Thread Stephen Hemminger
On Tue, 9 Oct 2018 19:30:30 +0200 Laurent Bigonville wrote: > Hello, > > On my desktop (Asus MB with dual Ethernet port), when waking up after > suspend, the network card is not detecting the link. > > I have to rmmod the sky2 driver and then modprobing it again. > > lspci shows me: > >

Inquiry 09-10-2018

2018-10-09 Thread Daniel Murray
Hi,friend, This is Daniel Murray and i am from Sinara Group Co.Ltd Group Co.,LTD in Russia. We are glad to know about your company from the web and we are interested in your products. Could you kindly send us your Latest catalog and price list for our trial order. Best Regards, Daniel Murray

Re: [PATCH V1 net-next 00/12] Improving performance and reducing latencies, by using latest capabilities exposed in ENA device

2018-10-09 Thread Bshara, Nafea
It is high priority for us right after this major release get merged. On 10/9/18, 12:31 PM, "Jesper Dangaard Brouer" wrote: On Tue, 9 Oct 2018 21:44:57 +0300 wrote: > From: Arthur Kiyanovski > > This patchset introduces the following: > 1. A new placement

Re: [PATCH V1 net-next 00/12] Improving performance and reducing latencies, by using latest capabilities exposed in ENA device

2018-10-09 Thread Jesper Dangaard Brouer
On Tue, 9 Oct 2018 21:44:57 +0300 wrote: > From: Arthur Kiyanovski > > This patchset introduces the following: > 1. A new placement policy of Tx headers and descriptors, which takes > advantage of an option to place headers + descriptors in device memory > space. This is sometimes referred

Inquiry 09-10-2018

2018-10-09 Thread Daniel Murray
Hi,friend, This is Daniel Murray and i am from Sinara Group Co.Ltd Group Co.,LTD in Russia. We are glad to know about your company from the web and we are interested in your products. Could you kindly send us your Latest catalog and price list for our trial order. Best Regards, Daniel Murray

Re: [bpf-next V2 PATCH 0/3] bpf/xdp: fix generic-XDP and demonstrate VLAN manipulation

2018-10-09 Thread Song Liu
For the series: Acked-by: Song Liu On Tue, Oct 9, 2018 at 3:04 AM Jesper Dangaard Brouer wrote: > > While implementing PoC building blocks for eBPF code XDP+TC that can > manipulate VLANs headers, I discovered a bug in generic-XDP. > > The fix should be backported to stable kernels.

[PATCH V1 net-next 12/12] net: ena: fix indentations in ena_defs for better readability

2018-10-09 Thread akiyano
From: Arthur Kiyanovski Signed-off-by: Arthur Kiyanovski --- drivers/net/ethernet/amazon/ena/ena_admin_defs.h | 334 +- drivers/net/ethernet/amazon/ena/ena_eth_io_defs.h | 223 +++ drivers/net/ethernet/amazon/ena/ena_regs_defs.h | 206 +++-- 3 files

[PATCH V1 net-next 11/12] net: ena: update driver version to 2.0.1

2018-10-09 Thread akiyano
From: Arthur Kiyanovski Signed-off-by: Arthur Kiyanovski --- drivers/net/ethernet/amazon/ena/ena_netdev.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/ethernet/amazon/ena/ena_netdev.h b/drivers/net/ethernet/amazon/ena/ena_netdev.h index

[PATCH V1 net-next 08/12] net: ena: limit refill Rx threshold to 256 to avoid latency issues

2018-10-09 Thread akiyano
From: Arthur Kiyanovski Currently Rx refill is done when the number of required descriptors is above 1/8 queue size. With a default of 1024 entries per queue the threshold is 128 descriptors. There is intention to increase the queue size to 8196 entries. In this case threshold of 1024

[PATCH V1 net-next 10/12] net: ena: remove redundant parameter in ena_com_admin_init()

2018-10-09 Thread akiyano
From: Arthur Kiyanovski Remove redundant spinlock acquire parameter from ena_com_admin_init() Signed-off-by: Arthur Kiyanovski --- drivers/net/ethernet/amazon/ena/ena_com.c| 6 ++ drivers/net/ethernet/amazon/ena/ena_com.h| 5 + drivers/net/ethernet/amazon/ena/ena_netdev.c | 2

[PATCH V1 net-next 09/12] net: ena: change rx copybreak default to reduce kernel memory pressure

2018-10-09 Thread akiyano
From: Arthur Kiyanovski Improves socket memory utilization when receiving packets larger than 128 bytes (the previous rx copybreak) and smaller than 256 bytes. Signed-off-by: Arthur Kiyanovski --- drivers/net/ethernet/amazon/ena/ena_netdev.h | 2 +- 1 file changed, 1 insertion(+), 1

[PATCH V1 net-next 04/12] net: ena: add functions for handling Low Latency Queues in ena_com

2018-10-09 Thread akiyano
From: Arthur Kiyanovski This patch introduces APIs for detection, initialization, configuration and actual usage of low latency queues(LLQ). It extends transmit API with creation of LLQ descriptors in device memory (which include host buffers descriptors as well as packet header) Signed-off-by:

[PATCH V1 net-next 05/12] net: ena: add functions for handling Low Latency Queues in ena_netdev

2018-10-09 Thread akiyano
From: Arthur Kiyanovski This patch includes all code changes necessary in ena_netdev to enable packet sending via the LLQ placemnt mode. Signed-off-by: Arthur Kiyanovski --- drivers/net/ethernet/amazon/ena/ena_ethtool.c | 1 + drivers/net/ethernet/amazon/ena/ena_netdev.c | 387

[PATCH V1 net-next 06/12] net: ena: use CSUM_CHECKED device indication to report skb's checksum status

2018-10-09 Thread akiyano
From: Arthur Kiyanovski Set skb->ip_summed to the correct value as reported by the device. Add counter for the case where rx csum offload is enabled but device didn't check it. Signed-off-by: Arthur Kiyanovski --- drivers/net/ethernet/amazon/ena/ena_eth_com.c | 3 +++

[PATCH V1 net-next 07/12] net: ena: explicit casting and initialization, and clearer error handling

2018-10-09 Thread akiyano
From: Arthur Kiyanovski Signed-off-by: Arthur Kiyanovski --- drivers/net/ethernet/amazon/ena/ena_com.c| 39 drivers/net/ethernet/amazon/ena/ena_netdev.c | 5 ++-- drivers/net/ethernet/amazon/ena/ena_netdev.h | 22 3 files changed, 36

[PATCH V1 net-next 00/12] Improving performance and reducing latencies, by using latest capabilities exposed in ENA device

2018-10-09 Thread akiyano
From: Arthur Kiyanovski This patchset introduces the following: 1. A new placement policy of Tx headers and descriptors, which takes advantage of an option to place headers + descriptors in device memory space. This is sometimes referred to as LLQ - low latency queue. The patch set defines the

[PATCH V1 net-next 03/12] net: ena: introduce Low Latency Queues data structures according to ENA spec

2018-10-09 Thread akiyano
From: Arthur Kiyanovski Low Latency Queues(LLQ) allow usage of device's memory for descriptors and headers. Such queues decrease processing time since data is already located on the device when driver rings the doorbell. Signed-off-by: Arthur Kiyanovski ---

[PATCH V1 net-next 02/12] net: ena: complete host info to match latest ENA spec

2018-10-09 Thread akiyano
From: Arthur Kiyanovski Add new fields and definitions to host info and fill them according to the latest ENA spec version. Signed-off-by: Arthur Kiyanovski --- drivers/net/ethernet/amazon/ena/ena_admin_defs.h | 31 ++- drivers/net/ethernet/amazon/ena/ena_com.c |

[PATCH V1 net-next 01/12] net: ena: minor performance improvement

2018-10-09 Thread akiyano
From: Arthur Kiyanovski Reduce fastpath overhead by making ena_com_tx_comp_req_id_get() inline. Also move it to ena_eth_com.h file with its dependency function ena_com_cq_inc_head(). Signed-off-by: Arthur Kiyanovski --- drivers/net/ethernet/amazon/ena/ena_eth_com.c | 43

[PATCH net-next] tun: Consistently configure generic netdev params via rtnetlink

2018-10-09 Thread Serhey Popovych
Configuring generic network device parameters on tun will fail in presence of IFLA_INFO_KIND attribute in IFLA_LINKINFO nested attribute since tun_validate() always return failure. This can be visualized with following ip-link(8) command sequences: # ip link set dev tun0 group 100 # ip link

Re: [PATCH net-next] cxgb4: Add thermal zone support

2018-10-09 Thread David Miller
From: Ganesh Goudar Date: Tue, 9 Oct 2018 19:14:13 +0530 > Add thermal zone support to monitor ASIC's temperature. > > Signed-off-by: Ganesh Goudar Applied.

[PATCH net-next] net/mpls: Implement handler for strict data checking on dumps

2018-10-09 Thread David Ahern
From: David Ahern Without CONFIG_INET enabled compiles fail with: net/mpls/af_mpls.o: In function `mpls_dump_routes': af_mpls.c:(.text+0xed0): undefined reference to `ip_valid_fib_dump_req' The preference is for MPLS to use the same handler as ipv4 and ipv6 to allow consistency when doing a

Re: [PATCH bpf-next 4/6] bpf: add queue and stack maps

2018-10-09 Thread Song Liu
On Tue, Oct 9, 2018 at 6:05 AM Mauricio Vasquez wrote: > > > > On 10/08/2018 08:36 PM, Song Liu wrote: > > On Mon, Oct 8, 2018 at 12:12 PM Mauricio Vasquez B > > wrote: > >> Queue/stack maps implement a FIFO/LIFO data storage for ebpf programs. > >> These maps support peek, pop and push

Re: selftests/bpf: test_kmod.sh hangs on all devices

2018-10-09 Thread Naresh Kamboju
Hi Shuah, On Mon, 8 Oct 2018 at 20:46, Shuah Khan wrote: > > Hi Naresh, > > Please use sh...@kernel.org for faster responses. I updated MAINTAINERS > entry a while back removing shua...@osg.samsung.com address due to IT > infrastructure changes at Samsung. +1 Thank you. Best Regards Naresh

Re: selftests/bpf: test_kmod.sh hangs on all devices

2018-10-09 Thread Naresh Kamboju
> > > OTOH, > > > There is a kernel BUG, > > > > This is quite an old linux-next kernel, should be fixed by 100811936f89 > > ("bpf: test_bpf: > > add init_net to dev for flow_dissector"). Please make sure you have that > > commit included > > in your testing: This patch included in the linux

Re: [PATCH V2 net 0/4] minor bug fixes for ENA Ethernet driver

2018-10-09 Thread David Miller
From: Date: Tue, 9 Oct 2018 11:21:26 +0300 > From: Arthur Kiyanovski > > Arthur Kiyanovski (4): > net: ena: fix warning in rmmod caused by double iounmap > net: ena: fix rare bug when failed restart/resume is followed by > driver removal > net: ena: fix NULL dereference due to

Re: [PATCH net] net/sched: cls_api: add missing validation of netlink attributes

2018-10-09 Thread David Ahern
On 10/9/18 10:12 AM, Davide Caratti wrote: >>> --- a/net/sched/cls_api.c >>> +++ b/net/sched/cls_api.c >>> @@ -37,6 +37,11 @@ static LIST_HEAD(tcf_proto_base); >>> /* Protects list of registered TC modules. It is pure SMP lock. */ >>> static DEFINE_RWLOCK(cls_mod_lock); >>> >>> +const struct

[sky2 driver] 88E8056 PCI-E Gigabit Ethernet Controller not working after suspend

2018-10-09 Thread Laurent Bigonville
Hello, On my desktop (Asus MB with dual Ethernet port), when waking up after suspend, the network card is not detecting the link. I have to rmmod the sky2 driver and then modprobing it again. lspci shows me: 04:00.0 Ethernet controller: Marvell Technology Group Ltd. 88E8056 PCI-E Gigabit

Re: BBR and TCP internal pacing causing interrupt storm with pfifo_fast

2018-10-09 Thread Eric Dumazet
On Tue, Oct 9, 2018 at 10:22 AM Gasper Zejn wrote: > > On 09. 10. 2018 19:00, Eric Dumazet wrote: > > > > On 10/09/2018 09:38 AM, Gasper Zejn wrote: > >> Hello, > >> > >> I am seeing interrupt storms of over 100k-900k local timer interrupts > >> when changing between network devices or networks

Re: BBR and TCP internal pacing causing interrupt storm with pfifo_fast

2018-10-09 Thread Gasper Zejn
On 09. 10. 2018 19:00, Eric Dumazet wrote: > > On 10/09/2018 09:38 AM, Gasper Zejn wrote: >> Hello, >> >> I am seeing interrupt storms of over 100k-900k local timer interrupts >> when changing between network devices or networks with open TCP >> connections when not using sch_fq (I was using

Re: BBR and TCP internal pacing causing interrupt storm with pfifo_fast

2018-10-09 Thread Eric Dumazet
On 10/09/2018 09:38 AM, Gasper Zejn wrote: > Hello, > > I am seeing interrupt storms of over 100k-900k local timer interrupts > when changing between network devices or networks with open TCP > connections when not using sch_fq (I was using pfifo_fast). Using sch_fq > makes the bug with

[PATCH net] net/xfrm: fix out-of-bounds packet access

2018-10-09 Thread Alexei Starovoitov
BUG: KASAN: slab-out-of-bounds in _decode_session6+0x1331/0x14e0 net/ipv6/xfrm6_policy.c:161 Read of size 1 at addr 8801d882eec7 by task syz-executor1/6667 Call Trace: __dump_stack lib/dump_stack.c:77 [inline] dump_stack+0x1c9/0x2b4 lib/dump_stack.c:113

enquiry 09-10-2018

2018-10-09 Thread Daniel Murray
Hi,friend, This is Daniel Murray and i am from Sinara Group Co.Ltd Group Co.,LTD in Russia. We are glad to know about your company from the web and we are interested in your products. Could you kindly send us your Latest catalog and price list for our trial order. Best Regards, Daniel Murray

BBR and TCP internal pacing causing interrupt storm with pfifo_fast

2018-10-09 Thread Gasper Zejn
Hello, I am seeing interrupt storms of over 100k-900k local timer interrupts when changing between network devices or networks with open TCP connections when not using sch_fq (I was using pfifo_fast). Using sch_fq makes the bug with interrupt storm go away. The interrupts all called

  1   2   >