Re: [PATCH net-next 0/4] Adds support of RSS to HNS3 Driver for Rev 2(=0x21) H/W

2018-10-10 Thread David Miller
From: Salil Mehta Date: Wed, 10 Oct 2018 20:05:33 +0100 > This patch-set mainly adds new additions related to RSS for the new > hardware Revision 0x21. It also adds support to use RSS hash value > provided by the hardware along with descriptor. Series applied.

Re: [PATCH] qmi_wwan: Added support for Gemalto's Cinterion ALASxx WWAN interface

2018-10-10 Thread David Miller
From: Giacinto Cifelli Date: Wed, 10 Oct 2018 20:05:53 +0200 > Added support for Gemalto's Cinterion ALASxx WWAN interfaces > by adding QMI_FIXED_INTF with Cinterion's VID and PID. > > Signed-off-by: Giacinto Cifelli Applied and queued up for -stable.

Re: [net 1/1] tipc: queue socket protocol error messages into socket receive buffer

2018-10-10 Thread David Miller
From: Jon Maloy Date: Wed, 10 Oct 2018 17:50:23 +0200 > From: Parthasarathy Bhuvaragan > > In tipc_sk_filter_rcv(), when we detect protocol messages with error we > call tipc_sk_conn_proto_rcv() and let it reset the connection and notify > the socket by calling sk->sk_state_change(). > >

Re: [net 1/1] tipc: set link tolerance correctly in broadcast link

2018-10-10 Thread David Miller
From: Jon Maloy Date: Wed, 10 Oct 2018 17:34:01 +0200 > In the patch referred to below we added link tolerance as an additional > criteria for declaring broadcast transmission "stale" and resetting the > affected links. > > However, the 'tolerance' field of the broadcast link is never set, and

Re: [PATCH -next] phy: phy-ocelot-serdes: fix return value check in serdes_probe()

2018-10-10 Thread David Miller
From: Wei Yongjun Date: Wed, 10 Oct 2018 02:00:24 + > In case of error, the function syscon_node_to_regmap() returns ERR_PTR() > and never returns NULL. The NULL test in the return value check should > be replaced with IS_ERR(). > > Fixes: 51f6b410fc22 ("phy: add driver for Microsemi Ocelot

Re: [PATCH net 0/2] net: dsa: bcm_sf2: Couple of fixes

2018-10-10 Thread David Miller
From: Florian Fainelli Date: Tue, 9 Oct 2018 16:48:56 -0700 > Here are two fixes for the bcm_sf2 driver that were found during > testing unbind and analysing another issue during system > suspend/resume. Series applied and queued up for -stable, thanks.

KASAN: use-after-free Read in __llc_lookup_established

2018-10-10 Thread syzbot
Hello, syzbot found the following crash on: HEAD commit:3d647e62686f Merge tag 's390-4.19-4' of git://git.kernel.o.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=1707d80940 kernel config: https://syzkaller.appspot.com/x/.config?x=88e9a8a39dc0be2d

Re: [PATCH net-next] net: sched: avoid writing on noop_qdisc

2018-10-10 Thread David Miller
From: Eric Dumazet Date: Tue, 9 Oct 2018 15:20:50 -0700 > While noop_qdisc.gso_skb and noop_qdisc.skb_bad_txq are not used > in other places, it seems not correct to overwrite their fields > in dev_init_scheduler_queue(). > > noop_qdisc is essentially a shared and read-only object, even if >

Re: [PATCH net-next] net/ipv6: Add knob to skip DELROUTE message on device down

2018-10-10 Thread David Miller
From: David Ahern Date: Tue, 9 Oct 2018 14:27:51 -0700 > From: David Ahern > > Another difference between IPv4 and IPv6 is the generation of RTM_DELROUTE > notifications when a device is taken down (admin down) or deleted. IPv4 > does not generate a message for routes evicted by the down or

Re: [PATCH net-next] net/mpls: Implement handler for strict data checking on dumps

2018-10-10 Thread David Miller
From: David Ahern Date: Tue, 9 Oct 2018 11:10:43 -0700 > From: David Ahern > > Without CONFIG_INET enabled compiles fail with: > > net/mpls/af_mpls.o: In function `mpls_dump_routes': > af_mpls.c:(.text+0xed0): undefined reference to `ip_valid_fib_dump_req' > > The preference is for MPLS to

Re: [PATCH net v2 0/2] net: ipv4: fixes for PMTU when link MTU changes

2018-10-10 Thread David Miller
From: Sabrina Dubroca Date: Tue, 9 Oct 2018 17:48:13 +0200 > The first patch adapts the changes that commit e9fa1495d738 ("ipv6: > Reflect MTU changes on PMTU of exceptions for MTU-less routes") did in > IPv6 to IPv4: lower PMTU when the first hop's MTU drops below it, and > raise PMTU when the

Re: [PATCH net-next v7 28/28] net: WireGuard secure network tunnel

2018-10-10 Thread Jiri Pirko
Wed, Oct 10, 2018 at 10:27:46PM CEST, ja...@zx2c4.com wrote: >Hey Jiri, > >Actually, in the end I went with the suggestion from Andrew and Lukas, >which is to follow Dan's guideline: >https://lkml.org/lkml/2016/8/22/374 . It looks like this: >

Re: [PATCH V1 net-next 00/12] Improving performance and reducing latencies, by using latest capabilities exposed in ENA device

2018-10-10 Thread David Miller
From: Date: Tue, 9 Oct 2018 21:44:57 +0300 > This patchset introduces the following: > 1. A new placement policy of Tx headers and descriptors, which takes > advantage of an option to place headers + descriptors in device memory > space. This is sometimes referred to as LLQ - low latency queue.

Re: fore200e DMA cleanups and fixes

2018-10-10 Thread David Miller
From: Christoph Hellwig Date: Tue, 9 Oct 2018 16:57:13 +0200 > The fore200e driver came up during some dma-related audits, so > here is the fallout. Compile tested (x86 & sparc) only. Series applied to net-next.

RE: [PATCH net-next v5] net/ncsi: Extend NC-SI Netlink interface to allow user space to send NC-SI command

2018-10-10 Thread Justin.Lee1
> On Wed, 2018-10-10 at 18:11 +, justin.l...@dell.com wrote: > > > + > > + len = nla_len(info->attrs[NCSI_ATTR_DATA]); > > + if (len < sizeof(struct ncsi_pkt_hdr)) { > > + netdev_info(ndp->ndev.dev, "NCSI: no command to send %u\n", > > + package_id); > > +

Re: [PATCH net-next v2] net: tun: remove useless codes of tun_automq_select_queue

2018-10-10 Thread David Miller
From: Wang Li Date: Tue, 9 Oct 2018 10:32:04 +0800 > Because the function __skb_get_hash_symmetric always returns non-zero. > > Signed-off-by: Zhang Yu > Signed-off-by: Wang Li Applied.

Re: [PATCH net-next V3] virtio_net: ethtool tx napi configuration

2018-10-10 Thread David Miller
From: Jason Wang Date: Tue, 9 Oct 2018 10:06:26 +0800 > Implement ethtool .set_coalesce (-C) and .get_coalesce (-c) handlers. > Interrupt moderation is currently not supported, so these accept and > display the default settings of 0 usec and 1 frame. > > Toggle tx napi through setting

Re: netconsole warning in 4.19.0-rc7

2018-10-10 Thread Cong Wang
(Cc'ing Dave) On Wed, Oct 10, 2018 at 5:14 AM Meelis Roos wrote: > > Thies 4.19-rc7 on a bunch of test machines and got this warning from one. > It is reproducible and I have not noticed it before. > [...] > [9.914805] WARNING: CPU: 0 PID: 0 at kernel/softirq.c:168 >

Re: [PATCH net-next 0/3] nfp: flower: speed up stats update loop

2018-10-10 Thread David Miller
From: Jakub Kicinski Date: Mon, 8 Oct 2018 18:57:33 -0700 > This set from Pieter improves performance of processing FW stats > update notifications. The FW seems to send those at relatively > high rate (roughly ten per second per flow), therefore if we want > to approach the million flows mark

Re: [PATCH] isdn/hisax: amd7930_fn: Remove unnecessary parentheses

2018-10-10 Thread David Miller
From: Nathan Chancellor Date: Mon, 8 Oct 2018 15:59:05 -0700 > Clang warns when multiple sets of parentheses are used for a single > conditional statement. > > drivers/isdn/hisax/amd7930_fn.c:628:32: warning: equality comparison > with extraneous parentheses [-Wparentheses-equality] >

Re: [PATCH net 00/10] rxrpc: Fix packet reception code

2018-10-10 Thread David Miller
From: David Howells Date: Mon, 08 Oct 2018 23:47:18 +0100 > Here are a set of patches that prepares for and fix problems in rxrpc's > package reception code. There serious problems are: ... > The second patch fixes (A) - (C); the third patch renders (B) and (C) > non-issues by using the

Re: [PATCH net-next] net/ipv6: Make ipv6_route_table_template static

2018-10-10 Thread David Miller
From: David Ahern Date: Mon, 8 Oct 2018 14:06:34 -0700 > From: David Ahern > > ipv6_route_table_template is exported but there are no users outside > of route.c. Make it static. > > Signed-off-by: David Ahern Applied.

Re: [PATCH net-next] rtnetlink: Update comment in rtnl_stats_dump regarding strict data checking

2018-10-10 Thread David Miller
From: David Ahern Date: Mon, 8 Oct 2018 13:58:07 -0700 > From: David Ahern > > The NLM_F_DUMP_PROPER_HDR netlink flag was replaced by a setsockopt. > Update the comment in rtnl_stats_dump. > > Fixes: 841891ec0c65 ("rtnetlink: Update rtnl_stats_dump for strict data > checking") >

Re: [PATCH net-next] tcp: refactor DCTCP ECN ACK handling

2018-10-10 Thread David Miller
From: Yuchung Cheng Date: Mon, 8 Oct 2018 15:32:20 -0700 > DCTCP has two parts - a new ECN signalling mechanism and the response > function to it. The first part can be used by other congestion > control for DCTCP-ECN deployed networks. This patch moves that part > into a separate tcp_dctcp.h

Re: [PATCH net-next] rtnetlink: Move ifm in valid_fdb_dump_legacy to closer to use

2018-10-10 Thread David Miller
From: David Ahern Date: Mon, 8 Oct 2018 13:57:24 -0700 > From: David Ahern > > Move setting of local variable ifm to after the message parsing in > valid_fdb_dump_legacy. Avoid potential future use of unchecked variable. > > Fixes: 8dfbda19a21b ("rtnetlink: Move input checking for

Re: [PATCH net-next 0/3] mlxsw: selftests: Few small updates

2018-10-10 Thread David Miller
From: Ido Schimmel Date: Mon, 8 Oct 2018 18:50:38 + > First patch fixes a typo in mlxsw. > > Second patch fixes a race in a recent test. > > Third patch makes a recent test executable. Series applied, thanks Ido.

Re: [PATCH net] rds: RDS (tcp) hangs on sendto() to unresponding address

2018-10-10 Thread David Miller
From: Ka-Cheong Poon Date: Mon, 8 Oct 2018 09:17:11 -0700 > In rds_send_mprds_hash(), if the calculated hash value is non-zero and > the MPRDS connections are not yet up, it will wait. But it should not > wait if the send is non-blocking. In this case, it should just use the > base c_path for

Re: [PATCH] net: aquantia: remove some redundant variable initializations

2018-10-10 Thread David Miller
From: Colin King Date: Mon, 8 Oct 2018 14:35:58 +0100 > From: Colin Ian King > > There are several variables being initialized that are being set later > and hence the initialization is redundant and can be removed. Remove > then. > > Signed-off-by: Colin Ian King Applied to net-next.

Re: [RFC PATCH 2/2] net/ncsi: Configure multi-package, multi-channel modes with failover

2018-10-10 Thread Samuel Mendoza-Jonas
On Wed, 2018-10-10 at 22:36 +, justin.l...@dell.com wrote: > Hi Samuel, > > I am still testing your change and have some comments below. > > Thanks, > Justin > > > > This patch extends the ncsi-netlink interface with two new commands and > > three new attributes to configure multiple

Re: [PATCH net-next v5] net/ncsi: Extend NC-SI Netlink interface to allow user space to send NC-SI command

2018-10-10 Thread Samuel Mendoza-Jonas
On Wed, 2018-10-10 at 18:11 +, justin.l...@dell.com wrote: > + > + len = nla_len(info->attrs[NCSI_ATTR_DATA]); > + if (len < sizeof(struct ncsi_pkt_hdr)) { > + netdev_info(ndp->ndev.dev, "NCSI: no command to send %u\n", > + package_id); > +

A mail kvóta túllépte a korlátot

2018-10-10 Thread Escuela 398, Justo Daract
Tisztelt felhasználó, Postaládája túllépte a szokásos 100 MB tárolási korlátot, nem lesz képes fogadni vagy küldeni e-mailt, amíg meg nem növeli a postaláda kvótáját. A levél kvótájának növeléséhez kattintson az alábbi hivatkozásra, és töltse ki a szükséges adatokat a postaláda-kvóta

[net 1/3] net/mlx5: Fix memory leak when setting fpga ipsec caps

2018-10-10 Thread Saeed Mahameed
From: Talat Batheesh Allocated memory for context should be freed once finished working with it. Fixes: d6c4f0298cec ("net/mlx5: Refactor accel IPSec code") Signed-off-by: Talat Batheesh Reviewed-by: Or Gerlitz Reviewed-by: Tariq Toukan Signed-off-by: Saeed Mahameed ---

[net 2/3] net/mlx5: Take only bit 24-26 of wqe.pftype_wq for page fault type

2018-10-10 Thread Saeed Mahameed
From: Huy Nguyen The HW spec defines only bits 24-26 of pftype_wq as the page fault type, use the required mask to ensure that. Fixes: d9aaed838765 ("{net,IB}/mlx5: Refactor page fault handling") Signed-off-by: Huy Nguyen Signed-off-by: Eli Cohen Signed-off-by: Saeed Mahameed ---

[net-next 3/7] net/mlx5e: Gather common netdev init/cleanup functionality in one place

2018-10-10 Thread Saeed Mahameed
From: Feras Daoud Introduce a helper init/cleanup function that initializes mlx5e generic netdev private structure, and use them from all profiles init/cleanup callbacks. This patch will also be helpful to initialize/cleanup netdevs that are not created by mlx5 driver, e.g: accelerated ipoib

[net-next 4/7] net/mlx5e: Always initialize update stats delayed work

2018-10-10 Thread Saeed Mahameed
From: Feras Daoud mlx5e_detach_netdev cancels update_stats work which was not initialized in ipoib netdevice profile, as a result, the following assert occurs: ODEBUG: assert_init not available (active state 0) object type: timer_list hint:(null) This change moves the update stats work to be

[pull request][net-next 0/7] Mellanox, mlx5e and IPoIB netlink support fixes

2018-10-10 Thread Saeed Mahameed
This series was meant to go to -rc but due to this late submission and the size/complexity of this patchset, I am submitting to net-next. This series came to fix a very serious regression in RDMA IPoIB netlink child creation API, the patcheset contains fixes to two components and they must come

[net-next 2/7] RDMA/netdev: Fix netlink support in IPoIB

2018-10-10 Thread Saeed Mahameed
From: Denis Drozdov IPoIB netlink support was broken by the below commit since integrating the rdma_netdev support relies on an allocation flow for netdevs that was controlled by the ipoib driver while netdev's rtnl_newlink implementation assumes that the netdev will be allocated by netlink.

[net-next 1/7] RDMA/netdev: Hoist alloc_netdev_mqs out of the driver

2018-10-10 Thread Saeed Mahameed
From: Denis Drozdov netdev has several interfaces that expect to call alloc_netdev_mqs from the core code, with the driver only providing the arguments. This is incompatible with the rdma_netdev interface that returns the netdev directly. Thus re-organize the API used by ipoib so that the

[net-next 6/7] net/mlx5e: Use non-delayed work for update stats

2018-10-10 Thread Saeed Mahameed
Convert mlx5e update stats work to a normal work structure, since it is never used delayed. Add a helper function to queue update stats work on demand which checks for some conditions and reduce code duplication to have a better abstraction. Fixes: ed56c5193ad8 ("net/mlx5e: Update NIC HW stats

[net 3/3] net/mlx5: WQ, fixes for fragmented WQ buffers API

2018-10-10 Thread Saeed Mahameed
From: Tariq Toukan mlx5e netdevice used to calculate fragment edges by a call to mlx5_wq_cyc_get_frag_size(). This calculation did not give the correct indication for queues smaller than a PAGE_SIZE, (broken by default on PowerPC, where PAGE_SIZE == 64KB). Here it is replaced by the correct new

[pull request][net 0/3] Mellanox, mlx5 fixes 2018-10-10

2018-10-10 Thread Saeed Mahameed
Hi Dave, This pull request includes some fixes to mlx5 driver, Please pull and let me know if there's any problem. For -stable v4.11: ('net/mlx5: Take only bit 24-26 of wqe.pftype_wq for page fault type') For -stable v4.17: ('net/mlx5: Fix memory leak when setting fpga ipsec caps') For -stable

[net-next 5/7] net/mlx5e: Initialize all netdev common structures in one place

2018-10-10 Thread Saeed Mahameed
Move all mlx5e generic structures initializations to mlx5e_netdev_init. The common structure new initializer function will be used to initialize mlx5 context for netlink created netdevs such as IPoIB mlx5 accelerated child netdevs. Fixes: cd565b4b51e5 ("IB/IPoIB: Support acceleration options

[net-next 7/7] net/mlx5e: Do not ignore netdevice TX/RX queues number

2018-10-10 Thread Saeed Mahameed
From: Feras Daoud The current design of mlx5e driver ignores the netdevice TX/RX queues number for netdevices that RDMA IPoIB ULP creates. Instead, the queue number is initialized to the maximum number that mlx5 thinks best for performance. As a result, ULP drivers that choose to create a

[iproute2-next] tipc: support interface name when activating UDP bearer

2018-10-10 Thread Hoang Le
Support for indicating interface name has an ip address in parallel with specifying ip address when activating UDP bearer. This liberates the user from keeping track of the current ip address for each device. Old command syntax: $tipc bearer enable media udp name NAME localip IP New command

[PATCH bpf-next 2/8] tcp, ulp: remove ulp bits from sockmap

2018-10-10 Thread Daniel Borkmann
In order to prepare sockmap logic to be used in combination with kTLS we need to detangle it from ULP, and further split it in later commits into a generic API. Joint work with John. Signed-off-by: Daniel Borkmann Signed-off-by: John Fastabend --- include/net/tcp.h| 1 -

[PATCH bpf-next 7/8] bpf: add tls support for testing in test_sockmap

2018-10-10 Thread Daniel Borkmann
From: John Fastabend This adds a --ktls option to test_sockmap in order to enable the combination of ktls and sockmap to run, which makes for another batch of 648 test cases for both in combination. Signed-off-by: John Fastabend Signed-off-by: Daniel Borkmann ---

[PATCH bpf-next 6/8] tls: add bpf support to sk_msg handling

2018-10-10 Thread Daniel Borkmann
From: John Fastabend This work adds BPF sk_msg verdict program support to kTLS allowing BPF and kTLS to be combined together. Previously kTLS and sk_msg verdict programs were mutually exclusive in the ULP layer which created challenges for the orchestrator when trying to apply TCP based policy,

[PATCH bpf-next 5/8] tls: replace poll implementation with read hook

2018-10-10 Thread Daniel Borkmann
From: John Fastabend Instead of re-implementing poll routine use the poll callback to trigger read from kTLS, we reuse the stream_memory_read callback which is simpler and achieves the same. This helps to align sockmap and kTLS so we can more easily embed BPF in kTLS. Joint work with Daniel.

[PATCH bpf-next 8/8] bpf, doc: add maintainers entry to related files

2018-10-10 Thread Daniel Borkmann
Add a MAINTAINERS entry to the skmsg and related files such that patches, features, bug reports land with the right Cc. Signed-off-by: Daniel Borkmann Signed-off-by: John Fastabend --- MAINTAINERS | 10 ++ 1 file changed, 10 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index

[PATCH bpf-next 0/8] sockmap integration for ktls

2018-10-10 Thread Daniel Borkmann
This work adds a generic sk_msg layer and converts both sockmap and later ktls over to make use of it as a common data structure for application data (similarly as sk_buff for network packets). With that in place the sk_msg framework spans accross ULP layer in the kernel and allows for

[PATCH bpf-next 4/8] tls: convert to generic sk_msg interface

2018-10-10 Thread Daniel Borkmann
Convert kTLS over to make use of sk_msg interface for plaintext and encrypted scattergather data, so it reuses all the sk_msg helpers and data structure which later on in a second step enables to glue this to BPF. Joint work with John. Signed-off-by: Daniel Borkmann Signed-off-by: John

[PATCH bpf-next 1/8] tcp, ulp: enforce sock_owned_by_me upon ulp init and cleanup

2018-10-10 Thread Daniel Borkmann
Whenever the ULP data on the socket is mangled, enforce that the caller has the socket lock held as otherwise things may race with initialization and cleanup callbacks from ulp ops as both would mangle internal socket state. Joint work with John. Signed-off-by: Daniel Borkmann Signed-off-by:

Re: [PATCH stable 4.9 00/29] backport of IP fragmentation fixes

2018-10-10 Thread Florian Fainelli
On 10/10/2018 04:18 PM, Stephen Hemminger wrote: > On Tue, 9 Oct 2018 21:15:04 -0700 > Florian Fainelli wrote: > >>> >>> Strange, I do not see "ip: use rb trees for IP frag queue." in this list ? >> >> And it was not in Stephen's backport to 4.14 either, wait, looks like it >> was somehow

Re: [PATCH stable 4.9 00/29] backport of IP fragmentation fixes

2018-10-10 Thread Stephen Hemminger
On Tue, 9 Oct 2018 21:15:04 -0700 Florian Fainelli wrote: > > > > Strange, I do not see "ip: use rb trees for IP frag queue." in this list ? > > And it was not in Stephen's backport to 4.14 either, wait, looks like it > was somehow squashed into "net: sk_buff rbnode reorg". Stephen, was >

Re: [PATCH bpf-next v2 3/7] bpf: add MAP_LOOKUP_AND_DELETE_ELEM syscall

2018-10-10 Thread Mauricio Vasquez
On 10/10/2018 05:34 PM, Song Liu wrote: On Wed, Oct 10, 2018 at 10:48 AM Mauricio Vasquez wrote: On 10/10/2018 11:48 AM, Song Liu wrote: On Wed, Oct 10, 2018 at 7:06 AM Mauricio Vasquez B wrote: The following patch implements a bpf queue/stack maps that provides the peek/pop/push

Re: [PATCH bpf-next v2 3/7] bpf: add MAP_LOOKUP_AND_DELETE_ELEM syscall

2018-10-10 Thread Song Liu
On Wed, Oct 10, 2018 at 10:48 AM Mauricio Vasquez wrote: > > > > On 10/10/2018 11:48 AM, Song Liu wrote: > > On Wed, Oct 10, 2018 at 7:06 AM Mauricio Vasquez B > > wrote: > >> The following patch implements a bpf queue/stack maps that > >> provides the peek/pop/push functions. There is not a

Re: [PATCH net-next v5] net/ncsi: Extend NC-SI Netlink interface to allow user space to send NC-SI command

2018-10-10 Thread Vijay Khemka
On 10/10/18, 11:12 AM, "justin.l...@dell.com" wrote: The new command (NCSI_CMD_SEND_CMD) is added to allow user space application to send NC-SI command to the network card. Also, add a new attribute (NCSI_ATTR_DATA) for transferring request and response. The work flow is

[PATCH net v3] net/sched: cls_api: add missing validation of netlink attributes

2018-10-10 Thread Davide Caratti
Similarly to what has been done in 8b4c3cdd9dd8 ("net: sched: Add policy validation for tc attributes"), fix classifier code to add validation of TCA_CHAIN and TCA_KIND netlink attributes. tested with: # ./tdc.py -c filter v2: Let sch_api and cls_api share nla_policy they have in common, thanks

Re: [PATCH bpf-next] bpf: emit audit messages upon successful prog load and unload

2018-10-10 Thread Alexei Starovoitov
On Mon, Oct 08, 2018 at 01:57:40PM +0200, Jiri Olsa wrote: > > I check that discussion and it's related only to bpf program load/unload, > is there any plan to also notify about bpf program attachment? > > in the step 2 you described: > > step 2 (future work) > single event for bpf

[PATCH stable 4.9 v2 28/29] ip: frags: fix crash in ip_do_fragment()

2018-10-10 Thread Florian Fainelli
From: Taehee Yoo commit 5d407b071dc369c26a38398326ee2be53651cfe4 upstream A kernel crash occurrs when defragmented packet is fragmented in ip_do_fragment(). In defragment routine, skb_orphan() is called and skb->ip_defrag_offset is set. but skb->sk and skb->ip_defrag_offset are same union

[PATCH stable 4.9 v2 29/29] ipv4: frags: precedence bug in ip_expire()

2018-10-10 Thread Florian Fainelli
From: Dan Carpenter (commit 70837ffe3085c9a91488b52ca13ac84424da1042 upstream) We accidentally removed the parentheses here, but they are required because '!' has higher precedence than '&'. Fixes: fa0f527358bd ("ip: use rb trees for IP frag queue.") Signed-off-by: Dan Carpenter

[PATCH stable 4.9 v2 23/29] net: pskb_trim_rcsum() and CHECKSUM_COMPLETE are friends

2018-10-10 Thread Florian Fainelli
From: Eric Dumazet After working on IP defragmentation lately, I found that some large packets defeat CHECKSUM_COMPLETE optimization because of NIC adding zero paddings on the last (small) fragment. While removing the padding with pskb_trim_rcsum(), we set skb->ip_summed to CHECKSUM_NONE,

[PATCH stable 4.9 v2 22/29] ipv6: defrag: drop non-last frags smaller than min mtu

2018-10-10 Thread Florian Fainelli
From: Florian Westphal don't bother with pathological cases, they only waste cycles. IPv6 requires a minimum MTU of 1280 so we should never see fragments smaller than this (except last frag). v3: don't use awkward "-offset + len" v2: drop IPv4 part, which added same check w. IPV4_MIN_MTU (68).

[PATCH stable 4.9 v2 24/29] net: add rb_to_skb() and other rb tree helpers

2018-10-10 Thread Florian Fainelli
From: Eric Dumazet Geeralize private netem_rb_to_skb() TCP rtx queue will soon be converted to rb-tree, so we will need skb_rbtree_walk() helpers. Signed-off-by: Eric Dumazet Signed-off-by: David S. Miller (cherry picked from commit 18a4c0eab2623cc95be98a1e6af1ad18e7695977) ---

[PATCH stable 4.9 v2 25/29] ip: use rb trees for IP frag queue.

2018-10-10 Thread Florian Fainelli
From: Peter Oskolkov (commit fa0f527358bd900ef92f925878ed6bfbd51305cc upstream) Similar to TCP OOO RX queue, it makes sense to use rb trees to store IP fragments, so that OOO fragments are inserted faster. Tested: - a follow-up patch contains a rather comprehensive ip defrag self-test

[PATCH stable 4.9 v2 26/29] ip: add helpers to process in-order fragments faster.

2018-10-10 Thread Florian Fainelli
From: Peter Oskolkov This patch introduces several helper functions/macros that will be used in the follow-up patch. No runtime changes yet. The new logic (fully implemented in the second patch) is as follows: * Nodes in the rb-tree will now contain not single fragments, but lists of

[PATCH stable 4.9 v2 27/29] ip: process in-order fragments efficiently

2018-10-10 Thread Florian Fainelli
From: Peter Oskolkov This patch changes the runtime behavior of IP defrag queue: incoming in-order fragments are added to the end of the current list/"run" of in-order fragments at the tail. On some workloads, UDP stream performance is substantially improved: RX: ./udp_stream -F 10 -T 2 -l 60

[PATCH stable 4.9 v2 20/29] net: speed up skb_rbtree_purge()

2018-10-10 Thread Florian Fainelli
From: Eric Dumazet As measured in my prior patch ("sch_netem: faster rb tree removal"), rbtree_postorder_for_each_entry_safe() is nice looking but much slower than using rb_next() directly, except when tree is small enough to fit in CPU caches (then the cost is the same) Also note that there is

[PATCH stable 4.9 v2 19/29] ip: discard IPv4 datagrams with overlapping segments.

2018-10-10 Thread Florian Fainelli
From: Peter Oskolkov This behavior is required in IPv6, and there is little need to tolerate overlapping fragments in IPv4. This change simplifies the code and eliminates potential DDoS attack vectors. Tested: ran ip_defrag selftest (not yet available uptream). Suggested-by: David S. Miller

[PATCH stable 4.9 v2 21/29] net: modify skb_rbtree_purge to return the truesize of all purged skbs.

2018-10-10 Thread Florian Fainelli
From: Peter Oskolkov Tested: see the next patch is the series. Suggested-by: Eric Dumazet Signed-off-by: Peter Oskolkov Signed-off-by: Eric Dumazet Cc: Florian Westphal Signed-off-by: David S. Miller (cherry picked from commit 385114dec8a49b5e5945e77ba7de6356106713f4) ---

[PATCH stable 4.9 v2 11/29] inet: frags: remove inet_frag_maybe_warn_overflow()

2018-10-10 Thread Florian Fainelli
From: Eric Dumazet This function is obsolete, after rhashtable addition to inet defrag. Signed-off-by: Eric Dumazet Signed-off-by: David S. Miller (cherry picked from commit 2d44ed22e607f9a285b049de2263e3840673a260) --- include/net/inet_frag.h | 2 --

[PATCH stable 4.9 v2 14/29] ipv6: frags: rewrite ip6_expire_frag_queue()

2018-10-10 Thread Florian Fainelli
From: Eric Dumazet Make it similar to IPv4 ip_expire(), and release the lock before calling icmp functions. Signed-off-by: Eric Dumazet Signed-off-by: David S. Miller (cherry picked from commit 05c0b86b9696802fd0ce5676a92a63f1b455bdf3) --- net/ipv6/reassembly.c | 24

[PATCH stable 4.9 v2 10/29] inet: frags: get rif of inet_frag_evicting()

2018-10-10 Thread Florian Fainelli
From: Eric Dumazet This refactors ip_expire() since one indentation level is removed. Note: in the future, we should try hard to avoid the skb_clone() since this is a serious performance cost. Under DDOS, the ICMP message wont be sent because of rate limits. Fact that ip6_expire_frag_queue()

[PATCH stable 4.9 v2 18/29] inet: frags: fix ip6frag_low_thresh boundary

2018-10-10 Thread Florian Fainelli
From: Eric Dumazet Giving an integer to proc_doulongvec_minmax() is dangerous on 64bit arches, since linker might place next to it a non zero value preventing a change to ip6frag_low_thresh. ip6frag_low_thresh is not used anymore in the kernel, but we do not want to prematuraly break user

[PATCH stable 4.9 v2 13/29] inet: frags: do not clone skb in ip_expire()

2018-10-10 Thread Florian Fainelli
From: Eric Dumazet An skb_clone() was added in commit ec4fbd64751d ("inet: frag: release spinlock before calling icmp_send()") While fixing the bug at that time, it also added a very high cost for DDOS frags, as the ICMP rate limit is applied after this expensive operation (skb_clone() +

[PATCH stable 4.9 v2 07/29] rhashtable: add schedule points

2018-10-10 Thread Florian Fainelli
From: Eric Dumazet Rehashing and destroying large hash table takes a lot of time, and happens in process context. It is safe to add cond_resched() in rhashtable_rehash_table() and rhashtable_free_and_destroy() Signed-off-by: Eric Dumazet Acked-by: Herbert Xu Signed-off-by: David S. Miller

[PATCH stable 4.9 v2 15/29] rhashtable: reorganize struct rhashtable layout

2018-10-10 Thread Florian Fainelli
From: Eric Dumazet While under frags DDOS I noticed unfortunate false sharing between @nelems and @params.automatic_shrinking Move @nelems at the end of struct rhashtable so that first cache line is shared between all cpus, because almost never dirtied. Signed-off-by: Eric Dumazet

[PATCH stable 4.9 v2 16/29] inet: frags: reorganize struct netns_frags

2018-10-10 Thread Florian Fainelli
From: Eric Dumazet Put the read-mostly fields in a separate cache line at the beginning of struct netns_frags, to reduce false sharing noticed in inet_frag_kill() Signed-off-by: Eric Dumazet Signed-off-by: David S. Miller (cherry picked from commit c2615cf5a761b32bf74e85bddc223dfff3d9b9f0)

[PATCH stable 4.9 v2 04/29] inet: frags: refactor ipv6_frag_init()

2018-10-10 Thread Florian Fainelli
From: Eric Dumazet We want to call inet_frags_init() earlier. This is a prereq to "inet: frags: use rhashtables for reassembly units" Signed-off-by: Eric Dumazet Signed-off-by: David S. Miller (cherry picked from commit 5b975bab23615cd0fdf67af6c9298eb01c4b9f61) --- net/ipv6/reassembly.c |

[PATCH stable 4.9 v2 05/29] inet: frags: refactor lowpan_net_frag_init()

2018-10-10 Thread Florian Fainelli
From: Eric Dumazet We want to call lowpan_net_frag_init() earlier. Similar to commit "inet: frags: refactor ipv6_frag_init()" This is a prereq to "inet: frags: use rhashtables for reassembly units" Signed-off-by: Eric Dumazet Signed-off-by: David S. Miller (cherry picked from commit

[PATCH stable 4.9 v2 17/29] inet: frags: get rid of ipfrag_skb_cb/FRAG_CB

2018-10-10 Thread Florian Fainelli
From: Eric Dumazet ip_defrag uses skb->cb[] to store the fragment offset, and unfortunately this integer is currently in a different cache line than skb->next, meaning that we use two cache lines per skb when finding the insertion point. By aliasing skb->ip_defrag_offset and skb->dev, we pack

[PATCH stable 4.9 v2 09/29] inet: frags: remove some helpers

2018-10-10 Thread Florian Fainelli
From: Eric Dumazet Remove sum_frag_mem_limit(), ip_frag_mem() & ip6_frag_mem() Also since we use rhashtable we can bring back the number of fragments in "grep FRAG /proc/net/sockstat /proc/net/sockstat6" that was removed in commit 434d305405ab ("inet: frag: don't account number of fragment

[PATCH stable 4.9 v2 08/29] inet: frags: use rhashtables for reassembly units

2018-10-10 Thread Florian Fainelli
From: Eric Dumazet Some applications still rely on IP fragmentation, and to be fair linux reassembly unit is not working under any serious load. It uses static hash tables of 1024 buckets, and up to 128 items per bucket (!!!) A work queue is supposed to garbage collect items when host is under

[PATCH stable 4.9 v2 00/29] backport of IP fragmentation fixes

2018-10-10 Thread Florian Fainelli
This is based on Stephen's v4.14 patches, with the necessary merge conflicts, and the lack of timer_setup() on the 4.9 baseline. Perf results on a gigabit capable system, before and after are below. Series can also be found here: https://github.com/ffainelli/linux/commits/fragment-stack-v4.9-v2

[PATCH stable 4.9 v2 12/29] inet: frags: break the 2GB limit for frags storage

2018-10-10 Thread Florian Fainelli
From: Eric Dumazet Some users are willing to provision huge amounts of memory to be able to perform reassembly reasonnably well under pressure. Current memory tracking is using one atomic_t and integers. Switch to atomic_long_t so that 64bit arches can use more than 2GB, without any cost for

[PATCH stable 4.9 v2 06/29] ipv6: export ip6 fragments sysctl to unprivileged users

2018-10-10 Thread Florian Fainelli
From: Eric Dumazet IPv4 was changed in commit 52a773d645e9 ("net: Export ip fragment sysctl to unprivileged users") The only sysctl that is not per-netns is not used : ip6frag_secret_interval Signed-off-by: Eric Dumazet Cc: Nikolay Borisov Signed-off-by: David S. Miller (cherry picked from

[PATCH stable 4.9 v2 02/29] inet: frags: add a pointer to struct netns_frags

2018-10-10 Thread Florian Fainelli
From: Eric Dumazet In order to simplify the API, add a pointer to struct inet_frags. This will allow us to make things less complex. These functions no longer have a struct inet_frags parameter : inet_frag_destroy(struct inet_frag_queue *q /*, struct inet_frags *f */) inet_frag_put(struct

[PATCH stable 4.9 v2 01/29] inet: frags: change inet_frags_init_net() return value

2018-10-10 Thread Florian Fainelli
From: Eric Dumazet We will soon initialize one rhashtable per struct netns_frags in inet_frags_init_net(). This patch changes the return value to eventually propagate an error. Signed-off-by: Eric Dumazet Signed-off-by: David S. Miller (cherry picked from commit

[PATCH stable 4.9 v2 03/29] inet: frags: refactor ipfrag_init()

2018-10-10 Thread Florian Fainelli
From: Eric Dumazet We need to call inet_frags_init() before register_pernet_subsys(), as a prereq for following patch ("inet: frags: use rhashtables for reassembly units") Signed-off-by: Eric Dumazet Signed-off-by: David S. Miller (cherry picked from commit

Re: [PATCH] qmi_wwan: Added support for Gemalto's Cinterion ALASxx WWAN interface

2018-10-10 Thread Bjørn Mork
Giacinto Cifelli writes: > Added support for Gemalto's Cinterion ALASxx WWAN interfaces > by adding QMI_FIXED_INTF with Cinterion's VID and PID. > > Signed-off-by: Giacinto Cifelli Acked-by: Bjørn Mork

Re: [PATCH iproute 2/2] utils: fix get_rtnl_link_stats_rta stats parsing

2018-10-10 Thread Stephen Hemminger
On Wed, 10 Oct 2018 17:00:58 +0200 Lorenzo Bianconi wrote: > iproute2 walks through the list of available tunnels using netlink > protocol in order to get device info instead of reading > them from proc filesystem. However the kernel reports device statistics > using

Re: [sky2 driver] 88E8056 PCI-E Gigabit Ethernet Controller not working after suspend

2018-10-10 Thread Stephen Hemminger
On Wed, 10 Oct 2018 03:16:40 +0200 Laurent Bigonville wrote: > Le 9/10/18 à 22:09, Stephen Hemminger a écrit : > > On Tue, 9 Oct 2018 19:30:30 +0200 > > Laurent Bigonville wrote: > > > >> Hello, > >> > >> On my desktop (Asus MB with dual Ethernet port), when waking up after > >> suspend, the

Re: [PATCH net-next] net: enable RPS on vlan devices

2018-10-10 Thread Eric Dumazet
On 10/10/2018 11:23 AM, Shannon Nelson wrote: > For that matter, lots of features are "default off" until someone configures > them, and there are lots of features that are only used by a subset of users.  > In this case, we're trying to use something that already exists and arguably > is

Re: [PATCH net-next] net: enable RPS on vlan devices

2018-10-10 Thread Shannon Nelson
On 10/10/2018 10:37 AM, John Fastabend wrote: Latest tree has a sk_lookup() helper supported in 'tc' layer now to lookup the socket. And XDP has support for a "cpumap" object that allows redirect to remote CPUs. Neither was specifically designed for this but I suspect with some extra work these

Please Reply / Can i have a bit of your attention?

2018-10-10 Thread Bauer McDonalds
-- Hello dear! I sincerely hope i do not bother you with my message.I know this might look strange because we don't know each other but i believe anything is possible if we try. I have actually lost confidence on dating sites and due to the nature of my work its not easy to find someone

Re: [PATCH net-next] net: enable RPS on vlan devices

2018-10-10 Thread Shannon Nelson
On 10/10/2018 10:14 AM, Eric Dumazet wrote: On 10/10/2018 09:18 AM, Shannon Nelson wrote: On 10/9/2018 7:17 PM, Eric Dumazet wrote: On 10/09/2018 07:11 PM, Shannon Nelson wrote: Hence the reason we sent this as an RFC a couple of weeks ago.  We got no response, so followed up with this

[PATCH net-next v5] net/ncsi: Extend NC-SI Netlink interface to allow user space to send NC-SI command

2018-10-10 Thread Justin.Lee1
The new command (NCSI_CMD_SEND_CMD) is added to allow user space application to send NC-SI command to the network card. Also, add a new attribute (NCSI_ATTR_DATA) for transferring request and response. The work flow is as below. Request: User space application -> Netlink interface

[PATCH] qmi_wwan: Added support for Gemalto's Cinterion ALASxx WWAN interface

2018-10-10 Thread Giacinto Cifelli
Added support for Gemalto's Cinterion ALASxx WWAN interfaces by adding QMI_FIXED_INTF with Cinterion's VID and PID. Signed-off-by: Giacinto Cifelli --- drivers/net/usb/qmi_wwan.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/usb/qmi_wwan.c b/drivers/net/usb/qmi_wwan.c index

Re: [PATCH] bpf: bpftool, add support for attaching programs to maps

2018-10-10 Thread John Fastabend
On 10/10/2018 10:11 AM, Jakub Kicinski wrote: > On Wed, 10 Oct 2018 09:44:26 -0700, John Fastabend wrote: >> Sock map/hash introduce support for attaching programs to maps. To >> date I have been doing this with custom tooling but this is less than >> ideal as we shift to using bpftool as the

RE: [PATCH net-next v4] net/ncsi: Extend NC-SI Netlink interface to allow user space to send NC-SI command

2018-10-10 Thread Justin.Lee1
Hi Vijay, I will address the comment and send out the v5. Thanks, Justin > Hi Justin, > Please see minor comments below. > > Regards > -Vijay > > On 10/10/18, 9:01 AM, "justin.l...@dell.com" wrote: > > The new command (NCSI_CMD_SEND_CMD) is added to allow user space > application >

  1   2   >