On Thu, 1 Nov 2018 00:14:38 +
Jeff Barnhill <0xeff...@gmail.com> wrote:
> diff --git a/include/net/addrconf.h b/include/net/addrconf.h
> index 14b789a123e7..799af1a037d1 100644
> --- a/include/net/addrconf.h
> +++ b/include/net/addrconf.h
> @@ -317,6 +317,8 @@ bool ipv6_chk_acast_addr(struct
On 31/10/18 - 17:53:22, Eric Dumazet wrote:
> On 10/31/2018 04:26 PM, Christoph Paasch wrote:
> > Implementations of Quic might want to create a separate socket for each
> > Quic-connection by creating a connected UDP-socket.
> >
>
> Nice proposal, but I doubt a QUIC server can afford having one
On 10/31/2018 10:08 PM, Eric Dumazet wrote:
> Our plan is to use EDT model for UDP packets, so that we can
> still use one (not connected) UDP socket per cpu/thread.
>
> We added in linux-4.20 the EDT model for TCP, and I intend to add the
> remaining part for sch_fq for 4.21.
>
> UDP can
On 10/31/2018 08:50 PM, Christoph Paasch wrote:
> On 31/10/18 - 17:53:22, Eric Dumazet wrote:
>> On 10/31/2018 04:26 PM, Christoph Paasch wrote:
>>> Implementations of Quic might want to create a separate socket for each
>>> Quic-connection by creating a connected UDP-socket.
>>>
>>
>> Nice
> On Oct 31, 2018, at 10:04 PM, Eric Dumazet wrote:
>
>
>
>> On 10/31/2018 08:50 PM, Christoph Paasch wrote:
>>
>> What we had here is that we wanted to let a server initiate more than 64K
>> connections *while* binding also to a source-IP.
>> With TCP the bind() would then pick a
On 10/31/2018 08:50 PM, Christoph Paasch wrote:
> What we had here is that we wanted to let a server initiate more than 64K
> connections *while* binding also to a source-IP.
> With TCP the bind() would then pick a source-port and we ended up hitting the
> 64K limit. If we could do an atomic
On 10/31/18 3:57 PM, Paweł Staszewski wrote:
> Hi
>
> So maybee someone will be interested how linux kernel handles normal
> traffic (not pktgen :) )
>
>
> Server HW configuration:
>
> CPU : Intel(R) Xeon(R) Gold 6132 CPU @ 2.60GHz
>
> NIC's: 2x 100G Mellanox ConnectX-4 (connected to x16 pcie
On 10/31/18 6:02 PM, Jeff Barnhill wrote:
> I'll follow this email with a new patch using ifacaddr6 instead of
> creating a new struct. I ended up using fib6_nh.nh_dev to get the net,
> instead of adding a back pointer to idev. It seems that idev was
> recently removed in lieu of this, so if this
From: Tristram Ha
Initialize mutex before use. Avoid kernel complaint when
CONFIG_DEBUG_LOCK_ALLOC is enabled.
Fixes: b987e98e50ab90e5 ("dsa: add DSA switch driver for Microchip KSZ9477")
Signed-off-by: Tristram Ha
---
v1
- Remove comment
drivers/net/dsa/microchip/ksz_common.c | 10
[ sorry, too many distractions and I forgot to respond ]
On 10/30/18 11:34 AM, Stefano Brivio wrote:
> On Tue, 30 Oct 2018 10:34:45 -0600
> David Ahern wrote:
>
>> A more flexible approach is to use format strings to allow users to
>> customize the output order and whitespace as well. So for
--
Schönen Tag.
Wir hoffen, Sie gut zu treffen.
Benötigen Sie einen dringenden Kredit für ein Geschäft oder ein Projekt?
Wir bieten Kredite zu 1,5% und wir können Ihre Transaktion innerhalb von
3 bis 5 Arbeitstagen abschließen.
Wenn Sie ernsthaft an einem Kredit interessiert sind, empfehlen
From: Jaime Caamaño Ruiz
Date: Wed, 31 Oct 2018 18:52:03 +0100
> When there are both pop and push ethernet header actions among the
> actions to be applied to a packet, an unexpected EINVAL (Invalid
> argument) error is obtained. This is due to mac_proto not being reset
> correctly when those
From: Jeff Kirsher
Date: Wed, 31 Oct 2018 12:42:46 -0700
> This series contains a various collection of fixes.
...
> The following are changes since commit
> a6b3a3fa042343e29ffaf9169f5ba3c819d4f9a2:
> net: mvpp2: Fix affinity hint allocation
> and are available in the git repository at:
>
On Thu, Nov 01, 2018 at 12:05:53AM +0100, Daniel Borkmann wrote:
> In the verifier there is no such semantics where registers with
> PTR_TO_MAP_VALUE type have an id assigned to them. This is only
> used in PTR_TO_MAP_VALUE_OR_NULL and later on nullified once the
> test against NULL has been
On 10/31/2018 04:26 PM, Christoph Paasch wrote:
> Implementations of Quic might want to create a separate socket for each
> Quic-connection by creating a connected UDP-socket.
>
Nice proposal, but I doubt a QUIC server can afford having one UDP socket per
connection ?
It would add a huge
From: Daniel Borkmann
Date: Thu, 1 Nov 2018 01:28:41 +0100
> The following pull-request contains BPF updates for your *net* tree.
>
> The main changes are:
>
> 1) Fix tcp_bpf_recvmsg() to return -EAGAIN instead of 0 in non-blocking
>case when no data is available yet, from John.
>
> 2)
Hi David,
The following pull-request contains BPF updates for your *net* tree.
The main changes are:
1) Fix tcp_bpf_recvmsg() to return -EAGAIN instead of 0 in non-blocking
case when no data is available yet, from John.
2) Fix a compilation error in libbpf_attach_type_by_name() when
icmp6_send() function is expensive on systems with a large number of
interfaces. Every time it’s called, it has to verify that the source
address does not correspond to an existing anycast address by looping
through every device and every anycast address on the device. This can
result in
On Thu, Nov 01, 2018 at 12:05:51AM +0100, Daniel Borkmann wrote:
> The series contains two fixes in BPF core and test cases. For details
> please see individual patches. Thanks!
>
> Daniel Borkmann (4):
> bpf: fix partial copy of map_ptr when dst is scalar
> bpf: don't set id on after map
I'll follow this email with a new patch using ifacaddr6 instead of
creating a new struct. I ended up using fib6_nh.nh_dev to get the net,
instead of adding a back pointer to idev. It seems that idev was
recently removed in lieu of this, so if this is incorrect, please let
me know. Hopefully, I
The series contains two fixes in BPF core and test cases. For details
please see individual patches. Thanks!
Daniel Borkmann (4):
bpf: fix partial copy of map_ptr when dst is scalar
bpf: don't set id on after map lookup with ptr_to_map_val return
bpf: add various test cases to test_verifier
ALU operations on pointers such as scalar_reg += map_value_ptr are
handled in adjust_ptr_min_max_vals(). Problem is however that map_ptr
and range in the register state share a union, so transferring state
through dst_reg->range = ptr_reg->range is just buggy as any new
map_ptr in the dst_reg is
In the verifier there is no such semantics where registers with
PTR_TO_MAP_VALUE type have an id assigned to them. This is only
used in PTR_TO_MAP_VALUE_OR_NULL and later on nullified once the
test against NULL has been pattern matched and type transformed
into PTR_TO_MAP_VALUE.
Fixes:
Right now unprivileged tests are never executed as a BPF test run,
only loaded. Allow for running them as well so that we can check
the outcome and probe for regressions.
Signed-off-by: Daniel Borkmann
Acked-by: Alexei Starovoitov
---
tools/testing/selftests/bpf/test_verifier.c | 71
Add some more map related test cases to test_verifier kselftest
to improve test coverage. Summary: 1012 PASSED, 0 SKIPPED, 0 FAILED
Signed-off-by: Daniel Borkmann
Acked-by: Alexei Starovoitov
---
tools/testing/selftests/bpf/test_verifier.c | 250
1 file changed,
And store it as a flag in the sk_flags.
Signed-off-by: Christoph Paasch
---
arch/alpha/include/uapi/asm/socket.h | 2 ++
arch/ia64/include/uapi/asm/socket.h | 2 ++
arch/mips/include/uapi/asm/socket.h | 2 ++
arch/parisc/include/uapi/asm/socket.h | 2 ++
Implementations of Quic might want to create a separate socket for each
Quic-connection by creating a connected UDP-socket.
To achieve that on the server-side, a "master-socket" needs to wait for
incoming new connections and then creates a new socket that will be a
connected UDP-socket. To create
For UDP, there is only a single socket-hash table, the udptable.
We want to prevent incoming segments to match on this socket when
SO_DELAYED_BIND is set. Thus, when computing the score for unconnected
sockets, we simply prevent the match as long as the flag is set.
Signed-off-by: Christoph
W dniu 31.10.2018 o 23:20, Paweł Staszewski pisze:
W dniu 31.10.2018 o 23:09, Eric Dumazet pisze:
On 10/31/2018 02:57 PM, Paweł Staszewski wrote:
Hi
So maybee someone will be interested how linux kernel handles normal
traffic (not pktgen :) )
Server HW configuration:
CPU : Intel(R)
W dniu 31.10.2018 o 23:09, Eric Dumazet pisze:
On 10/31/2018 02:57 PM, Paweł Staszewski wrote:
Hi
So maybee someone will be interested how linux kernel handles normal traffic
(not pktgen :) )
Server HW configuration:
CPU : Intel(R) Xeon(R) Gold 6132 CPU @ 2.60GHz
NIC's: 2x 100G
On 10/31/2018 02:57 PM, Paweł Staszewski wrote:
> Hi
>
> So maybee someone will be interested how linux kernel handles normal traffic
> (not pktgen :) )
>
>
> Server HW configuration:
>
> CPU : Intel(R) Xeon(R) Gold 6132 CPU @ 2.60GHz
>
> NIC's: 2x 100G Mellanox ConnectX-4 (connected to
> -Original Message-
> From: Richard Cochran [mailto:richardcoch...@gmail.com]
> Sent: Wednesday, October 31, 2018 2:17 PM
> To: Miroslav Lichvar
> Cc: Keller, Jacob E ; netdev@vger.kernel.org;
> intel-wired-
> l...@lists.osuosl.org
> Subject: Re: [RFC PATCH 4/4] ixgbe: add support
On 10/31/2018 09:49 PM, Arnaldo Carvalho de Melo wrote:
> Em Wed, Oct 31, 2018 at 12:57:18PM -0700, Andrey Ignatov escreveu:
>> Arnaldo Carvalho de Melo reported build error in libbpf when clang
>> version 3.8.1-24 (tags/RELEASE_381/final) is used:
>>
>> libbpf.c:2201:36: error: comparison of
Hi Clement,
On 10/31/2018 10:36 AM, Clément Péron wrote:
> Hi Dinh,
>
> On Wed, 31 Oct 2018 at 15:42, Dinh Nguyen wrote:
>>
>> Hi Clement,
>>
>> On 10/31/2018 08:01 AM, Clément Péron wrote:
>>> Hi,
>>>
>>> The patch "net: stmmac: socfpga: add additional ocp reset line for
>>> Stratix10"
W dniu 30.10.2018 o 15:16, Eric Dumazet pisze:
On 10/30/2018 01:09 AM, Paweł Staszewski wrote:
W dniu 30.10.2018 o 08:29, Eric Dumazet pisze:
On 10/29/2018 11:09 PM, Dimitris Michailidis wrote:
Indeed this is a bug. I would expect it to produce frequent errors
though as many odd-length
W dniu 31.10.2018 o 22:05, Saeed Mahameed pisze:
On Tue, 2018-10-30 at 10:32 -0700, Cong Wang wrote:
On Tue, Oct 30, 2018 at 7:16 AM Eric Dumazet
wrote:
On 10/30/2018 01:09 AM, Paweł Staszewski wrote:
W dniu 30.10.2018 o 08:29, Eric Dumazet pisze:
On 10/29/2018 11:09 PM, Dimitris
On Wed, Oct 31, 2018 at 2:05 PM Saeed Mahameed wrote:
>
> Cong, How often does this happen ? can you some how verify if the
> problematic packet has extra end padding after the ip payload ?
For us, we need 10+ hours to get one warning. This is also
why we never capture the packet that causes
On Wed, Oct 31, 2018 at 03:49:35PM +0100, Miroslav Lichvar wrote:
>
> How about separating the PHC timestamp from the ptp_system_timestamp
> structure and use NULL to indicate we don't want to read the system
> clock? A gettimex64(ptp, ts, NULL) call would be equal to
> gettime64(ptp, ts).
On Tue, 2018-10-30 at 10:32 -0700, Cong Wang wrote:
> On Tue, Oct 30, 2018 at 7:16 AM Eric Dumazet
> wrote:
> >
> >
> >
> > On 10/30/2018 01:09 AM, Paweł Staszewski wrote:
> > >
> > >
> > > W dniu 30.10.2018 o 08:29, Eric Dumazet pisze:
> > > >
> > > > On 10/29/2018 11:09 PM, Dimitris
Em Wed, Oct 31, 2018 at 12:57:18PM -0700, Andrey Ignatov escreveu:
> Arnaldo Carvalho de Melo reported build error in libbpf when clang
> version 3.8.1-24 (tags/RELEASE_381/final) is used:
>
> libbpf.c:2201:36: error: comparison of constant -22 with expression of
> type 'const enum
On 10/31/2018 10:52 AM, Jaime Caamaño Ruiz wrote:
When there are both pop and push ethernet header actions among the
actions to be applied to a packet, an unexpected EINVAL (Invalid
argument) error is obtained. This is due to mac_proto not being reset
correctly when those actions are validated.
From: Ido Schimmel
Date: Wed, 31 Oct 2018 09:56:41 +
> Petr says:
>
> An MC-aware mode was introduced in commit 7b8195306694 ("mlxsw:
> spectrum: Configure MC-aware mode on mlxsw ports"). In MC-aware mode,
> BUM traffic gets a special treatment by being assigned to a separate set
> of
Arnaldo Carvalho de Melo reported build error in libbpf when clang
version 3.8.1-24 (tags/RELEASE_381/final) is used:
libbpf.c:2201:36: error: comparison of constant -22 with expression of
type 'const enum bpf_attach_type' is always false
[-Werror,-Wtautological-constant-out-of-range-compare]
From:
Date: Tue, 30 Oct 2018 16:45:49 -0700
> @@ -1206,6 +1201,12 @@ int ksz_switch_register(struct ksz_device *dev)
> if (dev->pdata)
> dev->chip_id = dev->pdata->chip_id;
>
> + /* mutex is used in next function call. */
> + mutex_init(>reg_mutex);
> +
From: Jacob Keller
The upstream and out-of-tree drivers are once again at comparable
functionality. It's been a while since we updated the upstream driver
version, so bump it now.
Signed-off-by: Jacob Keller
Tested-by: Andrew Bowers
Signed-off-by: Jeff Kirsher
---
Based on the original work from Arnd Bergmann.
When XFRM_ALGO is not enabled, the new ixgbe IPsec code produces a
link error:
drivers/net/ethernet/intel/ixgbe/ixgbe_ipsec.o: In function
`ixgbe_ipsec_vf_add_sa':
ixgbe_ipsec.c:(.text+0x1266): undefined reference to `xfrm_aead_get_byname'
Simply
From: Jacob Keller
The device IDs for the Ethernet SDI Adapter devices were never added to
the upstream driver. The IDs are already in the pci.ids database, and
are supported by the out-of-tree driver.
Add the device IDs now, so that the upstream driver can recognize and
load these devices.
From: Jacob Keller
VF drivers can trigger PCIe completer aborts any time they read a queue
that they don't own. Even in nominal circumstances, it is not possible
to prevent the VF driver from reading queues it doesn't own. VF drivers
may attempt to read queues it previously owned, but which it
This series contains a various collection of fixes.
Miroslav Lichvar from Red Hat or should I say IBM now? Updates the PHC
timecounter interval for igb so that it gets updated at least once
every 550 seconds.
Ngai-Mint provides a fix for fm10k to prevent a soft lockup or system
crash by adding
From: Radoslaw Tyl
This change resolves a driver bug where the driver is logging a
message that says "Spoofed packets detected". This can occur on the PF
(host) when a VF has VLAN+MACVLAN enabled and is re-started with a
different MAC address.
MAC and VLAN anti-spoofing filters are to be
From: Miroslav Lichvar
The timecounter needs to be updated at least once per ~550 seconds in
order to avoid a 40-bit SYSTIM timestamp to be misinterpreted as an old
timestamp.
Since commit 500462a9d ("timers: Switch to a non-cascading wheel"),
scheduling of delayed work seems to be less
From: Huazhong Tan
Date: Tue, 30 Oct 2018 21:50:42 +0800
> This patch series include bugfix for the HNS3 ethernet
> controller driver.
>
> Change log:
> V4->V5:
> Fixes comments from Joe Perches & Sergei Shtylyov
> V3->V4:
> Fixes comments from Sergei Shtylyov
> V2->V3:
>
From: Ngai-Mint Kwan
Current condition will always incorrectly report a full SM mailbox if an
IES API application is not running. Due to this, the
"fm10k_service_task" will be infinitely queued into the driver's
workqueue. This, in turn, will cause a "kworker" thread to report 100%
CPU
From: Mitch Williams
Add a few new status code which will be used by the ice driver, and
rename a few to make them more consistent. Error code are mapped to
similar values as in i40e_status.h, so as to be compatible with older
VF drivers not using this status enum.
Signed-off-by: Mitch Williams
From: Eric Dumazet
Date: Tue, 30 Oct 2018 00:57:25 -0700
> As shown by Dmitris, we need to use csum_block_add() instead of csum_add()
> when adding the FCS contribution to skb csum.
>
> Before 4.18 (more exactly commit 88078d98d1bb "net: pskb_trim_rcsum()
> and CHECKSUM_COMPLETE are friends"),
From: Bo YU
Date: Mon, 29 Oct 2018 23:42:10 -0400
> Fix a warning from checkpatch.pl:'please no space before tabs'
> in include/net/af_unix.h
>
> Signed-off-by: Bo YU
Applied.
From: Bo YU
Date: Mon, 29 Oct 2018 23:42:09 -0400
> Fix a warning from checkpatch:
> function definition argument 'struct sock *' should also have an
> identifier name in include/net/af_unix.h.
>
> Signed-off-by: Bo YU
Applied.
From: Cong Wang
Date: Mon, 29 Oct 2018 17:35:15 -0700
> Most callers of pskb_trim_rcsum() simply drops the skb when
> it fails, however, ip_check_defrag() still continues to pass
> the skb up to stack. In that case, we should restore its previous
> csum if __pskb_trim() fails.
>
> Found this
If libc does not provide strlcpy check for libbsd with pkg-config to
avoid relying on inline version.
Signed-off-by: Luca Boccassi
---
Changed from -include /usr/include/bsd/string.h hack to HAVE_LIBBSD
and proper includes in each file that uses strlcpy.
The hack causes a compiler warning as
On Wed, 2018-10-31 at 08:09 -0700, Stephen Hemminger wrote:
> On Mon, 29 Oct 2018 10:46:50 +
> Luca Boccassi wrote:
>
> > If libc does not provide strlcpy check for libbsd with pkg-config
> > to
> > avoid relying on inline version.
> >
> > Signed-off-by: Luca Boccassi
> > ---
> > This
When there are both pop and push ethernet header actions among the
actions to be applied to a packet, an unexpected EINVAL (Invalid
argument) error is obtained. This is due to mac_proto not being reset
correctly when those actions are validated.
Reported-at:
net-next is closed, please resubmit this when net-next opens back up.
Thank you.
Arnaldo Carvalho de Melo [Wed, 2018-10-31 07:12 -0700]:
> 1740.66 debian:9 : FAIL gcc (Debian
> 6.3.0-18+deb9u1) 6.3.0 20170516
>
> The failure was with clang tho:
>
> clang version 3.8.1-24 (tags/RELEASE_381/final)
>
> With:
>
> gcc version 6.3.0 20170516
On 10/31/18 10:55 AM, David Ahern wrote:
> I think the simplest fix for 4.20 is to break the loop if ret is non-0 -
> restore the previous behavior.
that is the only recourse. It has to bail if ret is non-0. Do you want
to send a patch with that fix?
> -Original Message-
> From: Miroslav Lichvar [mailto:mlich...@redhat.com]
> Sent: Wednesday, October 31, 2018 2:40 AM
> To: Richard Cochran
> Cc: netdev@vger.kernel.org; intel-wired-...@lists.osuosl.org; Keller, Jacob E
>
> Subject: Re: [RFC PATCH 3/4] igb: add support for extended PHC
> -Original Message-
> From: Richard Cochran [mailto:richardcoch...@gmail.com]
> Sent: Wednesday, October 31, 2018 7:40 AM
> To: Miroslav Lichvar
> Cc: Keller, Jacob E ; netdev@vger.kernel.org;
> intel-wired-
> l...@lists.osuosl.org
> Subject: Re: [RFC PATCH 4/4] ixgbe: add support
On 10/31/18 12:42 AM, Alexey Kodanev wrote:
> cb->args[2] can store the pointer to the struct fib6_walker,
> allocated in inet6_dump_fib(). On the next loop iteration in
> rtnl_dump_all(), 'memset(, 0, sizeof(cb->args))' can reset
> that pointer, leaking the memory [1].
>
> Fix it by calling
On Wed, 31 Oct 2018 21:49:30 +0530
Leslie Monis wrote:
> diff --git a/net/sched/sch_pie.c b/net/sched/sch_pie.c
> index c84e91e..b68b367 100644
> --- a/net/sched/sch_pie.c
> +++ b/net/sched/sch_pie.c
> @@ -57,6 +57,7 @@ struct pie_vars {
> psched_time_t dq_tstamp;/* drain rate */
>
On Wed, 31 Oct 2018 21:49:29 +0530
Leslie Monis wrote:
> From: "Mohit P. Tahiliani"
>
> The update in drop probability depends on the parameters
> alpha and beta, which in turn reflect the current congestion
> level. However, the previous if-else cases were recommended
> when the supported
On Wed, 31 Oct 2018 21:49:31 +0530
Leslie Monis wrote:
> diff --git a/net/sched/sch_pie.c b/net/sched/sch_pie.c
> index b68b367..88e605c 100644
> --- a/net/sched/sch_pie.c
> +++ b/net/sched/sch_pie.c
> @@ -58,6 +58,7 @@ struct pie_vars {
> u32 avg_dq_rate;/* bytes per pschedtime
On Wed, 31 Oct 2018 21:49:24 +0530
Leslie Monis wrote:
> The current implementation of PIE queueing discipline is according to an IETF
> draft [http://tools.ietf.org/html/draft-pan-aqm-pie-00] and the paper
> [PIE: A Lightweight Control Scheme to Address the Bufferbloat Problem].
> However, a
From: "Mohit P. Tahiliani"
RFC 8033 replaces the IETF draft for PIE
Signed-off-by: Mohit P. Tahiliani
Signed-off-by: Dhaval Khandla
Signed-off-by: Hrishikesh Hiraskar
Signed-off-by: Manish Kumar B
Signed-off-by: Sachin D. Patil
Signed-off-by: Leslie Monis
---
net/sched/sch_pie.c | 2 +-
From: "Mohit P. Tahiliani"
Random dropping of packets to achieve latency control may
introduce outlier situations where packets are dropped too
close to each other or too far from each other. This can
cause the real drop percentage to temporarily deviate from
the intended drop probability. In
From: "Mohit P. Tahiliani"
The update in drop probability depends on the parameters
alpha and beta, which in turn reflect the current congestion
level. However, the previous if-else cases were recommended
when the supported bandwidth was up to 12 Mbps but, current
data links support a much
From: "Mohit P. Tahiliani"
To overcome unnecessary packet drops due to a spurious
uptick in queuing latency caused by fluctuations in a
network, PIE can choose to be active only when the queue
occupancy is over a certain threshold. RFC 8033 suggests
the value of this threshold be 1/3 of the tail
From: "Mohit P. Tahiliani"
RFC 8033 suggests an initial value of 150 milliseconds for
the maximum time allowed for a burst of packets instead of
100 milliseconds.
Signed-off-by: Mohit P. Tahiliani
Signed-off-by: Dhaval Khandla
Signed-off-by: Hrishikesh Hiraskar
Signed-off-by: Manish Kumar B
From: "Mohit P. Tahiliani"
RFC 8033 suggests a default value of 15 milliseconds for
the update interval instead of 30 milliseconds.
Signed-off-by: Mohit P. Tahiliani
Signed-off-by: Dhaval Khandla
Signed-off-by: Hrishikesh Hiraskar
Signed-off-by: Manish Kumar B
Signed-off-by: Sachin D. Patil
From: "Mohit P. Tahiliani"
RFC 8033 suggests a default value of 15 milliseconds for
the target queue delay instead of 20 milliseconds.
Signed-off-by: Mohit P. Tahiliani
Signed-off-by: Dhaval Khandla
Signed-off-by: Hrishikesh Hiraskar
Signed-off-by: Manish Kumar B
Signed-off-by: Sachin D.
From: "Mohit P. Tahiliani"
RFC 8033 recommends a value of 16384 bytes for the queue
threshold instead of 1 bytes.
Signed-off-by: Mohit P. Tahiliani
Signed-off-by: Dhaval Khandla
Signed-off-by: Hrishikesh Hiraskar
Signed-off-by: Manish Kumar B
Signed-off-by: Sachin D. Patil
The current implementation of PIE queueing discipline is according to an IETF
draft [http://tools.ietf.org/html/draft-pan-aqm-pie-00] and the paper
[PIE: A Lightweight Control Scheme to Address the Bufferbloat Problem].
However, a lot of necessary modifications and enhancements have been proposed
Before calling dev_hard_start_xmit(), upper layers tried
to cook optimal skb list based on BQL budget.
Problem is that GSO packets can end up comsuming more than
the BQL budget.
Breaking the loop is not useful, since requeued packets
are ahead of any packets still in the qdisc.
It is also more
doorbell only depends on xmit_more and netif_tx_queue_stopped()
Using __netdev_tx_sent_queue() avoids messing with BQL stop flag,
and is more generic.
This patch increases performance on GSO workload by keeping
doorbells to the minimum required.
Signed-off-by: Eric Dumazet
Cc: Tariq Toukan
When qdisc_run() tries to use BQL budget to bulk-dequeue a batch
of packets, GSO can later transform this list in another list
of skbs, and each skb is sent to device ndo_start_xmit(),
one at a time, with skb->xmit_more being set to one but
for last skb.
Problem is that very often, BQL limit is
While BQL bulk dequeue works well for TSO packets, it is
not very efficient as soon as GSO is involved.
On a GSO only workload (UDP or TCP), this patch series
can save about 8 % of cpu cycles on a 40Gbit mlx4 NIC,
by keeping optimal batching, and avoiding expensive
doorbells, qdisc requeues and
Hi Dinh,
On Wed, 31 Oct 2018 at 15:42, Dinh Nguyen wrote:
>
> Hi Clement,
>
> On 10/31/2018 08:01 AM, Clément Péron wrote:
> > Hi,
> >
> > The patch "net: stmmac: socfpga: add additional ocp reset line for
> > Stratix10" introduce in 4.9.124 broke the ethernet on my CycloneV
> > board.
> >
> >
On Mon, 29 Oct 2018 15:32:03 -0700
Yonghong Song wrote:
> With llvm 7.0 or earlier, the map symbol type is STT_NOTYPE.
> -bash-4.4$ cat t.c
> __attribute__((section("maps"))) int g;
> -bash-4.4$ clang -target bpf -O2 -c t.c
> -bash-4.4$ readelf -s t.o
>
> Symbol table '.symtab'
On Mon, 29 Oct 2018 23:04:25 +0100
Stefano Brivio wrote:
> While rendering columns, we use a local variable to keep track of the
> field currently being printed, without touching current_field, which is
> used for buffering.
>
> Use the right pointer to access the left delimiter for the current
Hi Andrew,
On Wed, Oct 31, 2018 at 8:24 PM Andrew Lunn wrote:
>
> On Wed, Oct 31, 2018 at 09:10:22AM +0530, Harini Katakam wrote:
> > From: Harini Katakam
> >
> > Add runtime pm functions and move clock handling there.
> > If device is suspended and not a wake device, then return from
> > mdio
On Mon, 29 Oct 2018 10:46:50 +
Luca Boccassi wrote:
> If libc does not provide strlcpy check for libbsd with pkg-config to
> avoid relying on inline version.
>
> Signed-off-by: Luca Boccassi
> ---
> This allows distro maintainers to be able to choose to reduce
> duplication and let this
On Wed, Oct 31, 2018 at 07:40:03AM -0700, Richard Cochran wrote:
> On Mon, Oct 29, 2018 at 02:31:09PM +0100, Miroslav Lichvar wrote:
> > I think there could be a flag in ptp_system_timestamp, or a parameter
> > of gettimex64(), which would enable/disable reading of the system
> > clock.
>
> I'm
Hi Clement,
On 10/31/2018 08:01 AM, Clément Péron wrote:
> Hi,
>
> The patch "net: stmmac: socfpga: add additional ocp reset line for
> Stratix10" introduce in 4.9.124 broke the ethernet on my CycloneV
> board.
>
> When I boot i have this issue :
>
> socfpga-dwmac ff702000.ethernet: error
On Mon, Oct 29, 2018 at 02:31:09PM +0100, Miroslav Lichvar wrote:
> I think there could be a flag in ptp_system_timestamp, or a parameter
> of gettimex64(), which would enable/disable reading of the system
> clock.
I'm not a fan of functions that change their behavior based on flags
in their
1740.66 debian:9 : FAIL gcc (Debian 6.3.0-18+deb9u1)
6.3.0 20170516
The failure was with clang tho:
clang version 3.8.1-24 (tags/RELEASE_381/final)
With:
gcc version 6.3.0 20170516 (Debian 6.3.0-18+deb9u1)
it built without any warnings/errors.
CC
On Wed, Oct 31, 2018 at 4:37 AM Tariq Toukan wrote:
>
>
>
> On 30/10/2018 1:25 AM, Eric Dumazet wrote:
> > This patch has two changes :
> >
> > 1) Use netdev_tx_sent_queue_more() for skbs with xmit_more
> > This avoids mangling BQL status, since we only need to
> > take care of it for the
On Wed, Oct 31, 2018 at 4:30 AM Tariq Toukan wrote:
>
>
>
> On 30/10/2018 1:25 AM, Eric Dumazet wrote:
> > When qdisc_run() tries to use BQL budget to bulk-dequeue a batch
> > of packets, GSO can later transform this list in another list
> > of skbs, and each skb is sent to device
On Tue, 2018-10-30 at 00:18 -0700, Eric Dumazet wrote:
> Abdul Haleem reported a build error on ppc :
>
> drivers/net/ethernet/mellanox/mlx4/en_rx.c:582:18: warning: `struct
> iphdr` declared inside parameter list [enabled by default]
>struct iphdr *iph)
> ^
>
On Tue, Oct 30, 2018 at 12:12:51PM -0700, Eduardo Valentin wrote:
Greg,
On Thu, Oct 18, 2018 at 03:43:48PM -0700, David Miller wrote:
From: Christoph Paasch
Date: Thu, 18 Oct 2018 13:38:40 -0700
> Upstream commit bffa72cf7f9d ("net: sk_buff rbnode reorg") got
> backported as commit
Hi,
The patch "net: stmmac: socfpga: add additional ocp reset line for
Stratix10" introduce in 4.9.124 broke the ethernet on my CycloneV
board.
When I boot i have this issue :
socfpga-dwmac ff702000.ethernet: error getting reset control of ocp -2
socfpga-dwmac: probe of ff702000.ethernet failed
> Il 26 ottobre 2018 alle 20.19 Cong Wang ha scritto:
>
> On Fri, Oct 26, 2018 at 4:35 AM Marco Berizzi wrote:
>
> > Apologies for bothering you again.
> > I applied your patch to 4.19, but after issuing this
> > command:
> >
> > root@Calimero:~# tc qdisc add dev eth0 root handle 1:0 hfsc
On 30/10/2018 8:19 PM, David Miller wrote:
> From: Eric Dumazet
> Date: Tue, 30 Oct 2018 00:18:12 -0700
>
>> Abdul Haleem reported a build error on ppc :
>>
>> drivers/net/ethernet/mellanox/mlx4/en_rx.c:582:18: warning: `struct
>> iphdr` declared inside parameter list [enabled by default]
>>
1 - 100 of 120 matches
Mail list logo
