Re: [PATCH bpf-next v2 02/13] bpf: btf: Add BTF_KIND_FUNC and BTF_KIND_FUNC_PROTO

2018-11-05 Thread Alexei Starovoitov
On Thu, Nov 01, 2018 at 09:08:37PM +, Edward Cree wrote: > I've spent a bit more time thinking about / sleeping on this, and I >  still think there's a major disagreement here.  Basically it seems >  like I'm saying "the design of BTF is wrong" and you're saying "but >  it's the design" (with

[PATCH iproute2] tc: f_u32: allow skip_hw and skip_sw flags to be last

2018-11-05 Thread Jakub Kicinski
u32 uses NEXT_ARG() incorrectly when parsing skip_hw and skip_sw flags. NEXT_ARG() ensures there is another argument on the command line, and is used in handling syntax to move past and ensure there is a to read. Commit 5e5b3008d1fb ("tc: f_u32: Add support for skip_hw and skip_sw flags")

Re: [PATCH iproute2-next v3] rdma: Document IB device renaming option

2018-11-05 Thread David Ahern
On 11/4/18 12:11 PM, Leon Romanovsky wrote: > From: Leon Romanovsky > > [leonro@server /]$ lspci |grep -i Ether > 00:08.0 Ethernet controller: Red Hat, Inc. Virtio network device > 00:09.0 Ethernet controller: Mellanox Technologies MT27700 Family [ConnectX-4] > [leonro@server /]$ sudo rdma dev >

Re: [PATCH] net: phy: realtek: fix RTL8201F sysfs name

2018-11-05 Thread Florian Fainelli
On 11/4/2018 10:43 AM, Andrew Lunn wrote: > On Sun, Nov 04, 2018 at 07:02:42PM +0100, Holger Hoffstätte wrote: >> Since 4.19 the following error in sysfs has appeared when using the >> r8169 NIC driver: >> >> $cd /sys/module/realtek/drivers >> $ls -l >> ls: cannot access 'mdio_bus:RTL8201F

Re: [PATCH net] net: bpfilter: fix iptables failure if bpfilter_umh is disabled

2018-11-05 Thread David Miller
From: Taehee Yoo Date: Mon, 5 Nov 2018 22:31:41 +0900 > When iptables command is executed, ip_{set/get}sockopt() try to upload > bpfilter.ko if bpfilter is enabled. if it couldn't find bpfilter.ko, > command is failed. > bpfilter.ko is generated if CONFIG_BPFILTER_UMH is enabled. >

Re: [PATCH] sock_diag: fix autoloading of the raw_diag module

2018-11-05 Thread David Miller
From: Andrei Vagin Date: Sun, 4 Nov 2018 22:37:15 -0800 > IPPROTO_TCP isn't registred as an inet protocol, so > inet_protos[protocol] is always NULL for it. > > Cc: Cyrill Gorcunov > Cc: Xin Long > Fixes: bf2ae2e4bf93 ("sock_diag: request _diag module only when the family or > proto has

Re: [PATCH net v2 1/2] rtnetlink: restore handling of dumpit return value in rtnl_dump_all()

2018-11-05 Thread David Ahern
On 11/5/18 6:06 PM, David Miller wrote: > From: Alexey Kodanev > Date: Fri, 2 Nov 2018 19:11:04 +0300 > >> For non-zero return from dumpit() we should break the loop >> in rtnl_dump_all() and return the result. Otherwise, e.g., >> we could get the memory leak in inet6_dump_fib() [1]. The >>

Re: [PATCH net v2 1/2] rtnetlink: restore handling of dumpit return value in rtnl_dump_all()

2018-11-05 Thread David Miller
From: Alexey Kodanev Date: Fri, 2 Nov 2018 19:11:04 +0300 > For non-zero return from dumpit() we should break the loop > in rtnl_dump_all() and return the result. Otherwise, e.g., > we could get the memory leak in inet6_dump_fib() [1]. The > pointer to the allocated struct fib6_walker there

Re: [PATCH net v2 2/2] ipv6: properly check return value in inet6_dump_all()

2018-11-05 Thread David Miller
From: Alexey Kodanev Date: Fri, 2 Nov 2018 19:11:05 +0300 > Make sure we call fib6_dump_end() if it happens that skb->len > is zero. rtnl_dump_all() can reset cb->args on the next loop > iteration there. > > Fixes: 08e814c9e8eb ("net/ipv6: Bail early if user only wants cloned entries") >

Re: [PATCH net] net/ipv6: Move anycast init/cleanup functions out of CONFIG_PROC_FS

2018-11-05 Thread Jeff Barnhill
Thanks, David. Sorry for missing that in the original patch. Jeff On Mon, Nov 5, 2018 at 4:55 PM David Miller wrote: > > From: Jeff Barnhill <0xeff...@gmail.com> > Date: Mon, 5 Nov 2018 20:36:45 + > > > Move the anycast.c init and cleanup functions which were inadvertently > > added inside

Re: [PATCH net] net/ipv6: Move anycast init/cleanup functions out of CONFIG_PROC_FS

2018-11-05 Thread David Miller
From: Jeff Barnhill <0xeff...@gmail.com> Date: Mon, 5 Nov 2018 20:36:45 + > Move the anycast.c init and cleanup functions which were inadvertently > added inside the CONFIG_PROC_FS definition. > > Fixes: 2384d02520ff ("net/ipv6: Add anycast addresses to a global hashtable") > Signed-off-by:

[PATCH net] net/ipv6: Move anycast init/cleanup functions out of CONFIG_PROC_FS

2018-11-05 Thread Jeff Barnhill
Move the anycast.c init and cleanup functions which were inadvertently added inside the CONFIG_PROC_FS definition. Fixes: 2384d02520ff ("net/ipv6: Add anycast addresses to a global hashtable") Signed-off-by: Jeff Barnhill <0xeff...@gmail.com> --- net/ipv6/anycast.c | 2 +- 1 file changed, 1

Re: Kernel 4.19 network performance - forwarding/routing normal users traffic

2018-11-05 Thread Jesper Dangaard Brouer
On Sun, 4 Nov 2018 01:24:03 +0100 Paweł Staszewski wrote: > And today again after allpy patch for page allocator - reached again > 64/64 Gbit/s > > with only 50-60% cpu load Great. > today no slowpath hit for netwoking :) > > But again dropped pckt at 64GbitRX and 64TX > And as it

Can NFS work with VRF?

2018-11-05 Thread Ben Greear
Hello, I was trying to improve my old series of patches that binds NFS to a particular source IP address so that it could work with VRF in a 4.16 kernel. But, it seems a huge tangle to try to make NFS (and rpc, etc) able to bind to a local netdevice, which I think is what would be needed to

Re: [RFC PATCH] net/mlx5e: Temp software stats variable is not required

2018-11-05 Thread David Miller
From: Saeed Mahameed Date: Mon, 5 Nov 2018 19:13:59 + > On Sat, 2018-11-03 at 19:36 -0700, David Miller wrote: >> From: Saeed Mahameed >> Date: Fri, 2 Nov 2018 18:54:22 -0700 >> >> > +static void mlx5e_fold_sw_stats(struct mlx5e_priv *priv, struct >> > rtnl_link_stats64 *s) >> > +{ >> > +

Re: [RFC PATCH] net/mlx5e: Temp software stats variable is not required

2018-11-05 Thread Saeed Mahameed
On Sat, 2018-11-03 at 19:36 -0700, David Miller wrote: > From: Saeed Mahameed > Date: Fri, 2 Nov 2018 18:54:22 -0700 > > > +static void mlx5e_fold_sw_stats(struct mlx5e_priv *priv, struct > > rtnl_link_stats64 *s) > > +{ > > + int i; > > + > > + /* not required ? */ > > + memset(s, 0,

Rules for retransmitting sk_buffs?

2018-11-05 Thread John Ousterhout
I am creating a kernel module that implements the Homa transport protocol (see paper in SIGCOMM 2018) and as a Linux kernel newbie I'm struggling a bit to figure out how all of Linux's network plumbing works. I'm currently having problems retransmitting an sk_buff after packet loss and hoping

Re: [PATCH] sock_diag: fix autoloading of the raw_diag module

2018-11-05 Thread Cyrill Gorcunov
On Mon, Nov 05, 2018 at 10:12:34AM +0300, Cyrill Gorcunov wrote: > > Andrew, looking into kernel code I wonder, maybe we should simply > add this protocol into inet_protos during net/ipv4/af_inet.c:inet_init? > It will require to add netns_ok into raw_prot of course. After spending some time on

[lora-next RFC] Socket details for PF_LORA on sx1301

2018-11-05 Thread Ben Whitten
Hi, Using the test application to send data into a PF_LORA socket I have gotten the sx1301 driver to a point where I was able to produce a LoRa packet on the air. There a few options that this socket will need per transmission from the upper layers which I have compiled with some questions, I

Re: [PATCH iproute2-next] rdma: Refresh help section of resource information

2018-11-05 Thread Stephen Hemminger
On Thu, 1 Nov 2018 10:35:05 +0200 Leon Romanovsky wrote: > From: Leon Romanovsky > > After commit 4060e4c0d257 ("rdma: Add PD resource tracking > information"), the resource information shows PDs and MRs, > but help pages didn't fully reflect it. > > Signed-off-by: Leon Romanovsky Applied

Re: [PATCH iproute2] Include bsd/string.h only in include/utils.h

2018-11-05 Thread Stephen Hemminger
On Thu, 1 Nov 2018 22:25:27 + Luca Boccassi wrote: > This is simpler and cleaner, and avoids having to include the header > from every file where the functions are used. The prototypes of the > internal implementation are in this header, so utils.h will have to be > included anyway for

[PATCH net] net: bpfilter: fix iptables failure if bpfilter_umh is disabled

2018-11-05 Thread Taehee Yoo
When iptables command is executed, ip_{set/get}sockopt() try to upload bpfilter.ko if bpfilter is enabled. if it couldn't find bpfilter.ko, command is failed. bpfilter.ko is generated if CONFIG_BPFILTER_UMH is enabled. ip_{set/get}sockopt() only checks CONFIG_BPFILTER. So that if CONFIG_BPFILTER

Re: Help with the BPF verifier

2018-11-05 Thread Arnaldo Carvalho de Melo
Em Fri, Nov 02, 2018 at 09:27:52PM +, Yonghong Song escreveu: > > > On 11/2/18 8:42 AM, Edward Cree wrote: > > On 02/11/18 15:02, Arnaldo Carvalho de Melo wrote: > >> Yeah, didn't work as well: > > > >> And the -vv in 'perf trace' didn't seem to map to further details in the > >> output of

SCTP on RH 5.7

2018-11-05 Thread David Laight
Why do our customers insist on trying to use SCTP on RH 5.7 with its ancient 2.6.18 kernel. Not surprising they are getting issues! David - Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK Registration No: 1397386 (Wales)

Re: Kernel 4.19 network performance - forwarding/routing normal users traffic

2018-11-05 Thread Jesper Dangaard Brouer
On Mon, 5 Nov 2018 14:28:36 +0800 Aaron Lu wrote: > On Sat, Nov 03, 2018 at 01:53:25PM +0100, Jesper Dangaard Brouer wrote: > > > > On Fri, 2 Nov 2018 22:20:24 +0800 Aaron Lu wrote: > > > > > On Fri, Nov 02, 2018 at 12:40:37PM +0100, Jesper Dangaard Brouer wrote: > > > > On Fri, 2 Nov

Re: Kernel 4.19 network performance - forwarding/routing normal users traffic

2018-11-05 Thread Aaron Lu
On Mon, Nov 05, 2018 at 08:42:33AM +, Tariq Toukan wrote: > > On 03/11/2018 2:53 PM, Jesper Dangaard Brouer wrote: > > > > On Fri, 2 Nov 2018 22:20:24 +0800 Aaron Lu wrote: > >> > >> I think here is a problem - order 0 pages are freed directly to buddy, > >> bypassing per-cpu-pages. This

Re: Kernel 4.19 network performance - forwarding/routing normal users traffic

2018-11-05 Thread Tariq Toukan
On 03/11/2018 2:53 PM, Jesper Dangaard Brouer wrote: > > On Fri, 2 Nov 2018 22:20:24 +0800 Aaron Lu wrote: > >> On Fri, Nov 02, 2018 at 12:40:37PM +0100, Jesper Dangaard Brouer wrote: >>> On Fri, 2 Nov 2018 13:23:56 +0800 >>> Aaron Lu wrote: >>> On Thu, Nov 01, 2018 at 08:23:19PM

[PATCH] xfrm: Fix bucket count reported to userspace

2018-11-05 Thread Benjamin Poirier
sadhcnt is reported by `ip -s xfrm state count` as "buckets count", not the hash mask. Fixes: 28d8909bc790 ("[XFRM]: Export SAD info.") Signed-off-by: Benjamin Poirier --- net/xfrm/xfrm_state.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/xfrm/xfrm_state.c