Re: [RFC v1 2/3] vxlan: add support for underlay in non-default VRF

2018-11-15 Thread David Ahern
On 11/15/18 2:05 AM, Alexis Bauvin wrote: > Le 14 nov. 2018 à 20:58, David Ahern a écrit : >> >> you are making this more specific than it needs to be >> >> On 11/14/18 1:31 AM, Alexis Bauvin wrote: >>> diff --git a/drivers/net/vxlan.c b/drivers/net/vxlan.c >>> index

Re: [PATCH] [PATCH net-next] tun: fix multiqueue rx

2018-11-15 Thread Jason Wang
On 2018/11/16 下午3:00, Matthew Cover wrote: When writing packets to a descriptor associated with a combined queue, the packets should end up on that queue. Before this change all packets written to any descriptor associated with a tap interface end up on rx-0, even when the descriptor is

[PATCH] [PATCH net-next] tun: fix multiqueue rx

2018-11-15 Thread Matthew Cover
When writing packets to a descriptor associated with a combined queue, the packets should end up on that queue. Before this change all packets written to any descriptor associated with a tap interface end up on rx-0, even when the descriptor is associated with a different queue. The rx traffic

Re: [PATCH net] sctp: not allow to set asoc prsctp_enable by sockopt

2018-11-15 Thread Xin Long
On Fri, Nov 16, 2018 at 2:22 AM Marcelo Ricardo Leitner wrote: > > On Thu, Nov 15, 2018 at 07:14:28PM +0800, Xin Long wrote: > > As rfc7496#section4.5 says about SCTP_PR_SUPPORTED: > > > >This socket option allows the enabling or disabling of the > >negotiation of PR-SCTP support for

Re: [PATCH] [PATCH net-next] tun: fix multiqueue rx

2018-11-15 Thread Jason Wang
On 2018/11/16 下午12:10, Matthew Cover wrote: When writing packets to a descriptor associated with a combined queue, the packets should end up on that queue. Before this change all packets written to any descriptor associated with a tap interface end up on rx-0, even when the descriptor is

Re: [Patch net] net: invert the check of detecting hardware RX checksum fault

2018-11-15 Thread Herbert Xu
On Thu, Nov 15, 2018 at 08:52:23PM -0800, Eric Dumazet wrote: > > It is very possible NIC provides an incorrect CHECKSUM_COMPLETE, in the > case non zero trailer bytes were added by a buggy switch (or host) We should probably change netdev_rx_csum_fault to print out at least one complete packet

Re: [Patch net] net: invert the check of detecting hardware RX checksum fault

2018-11-15 Thread Eric Dumazet
On 11/15/2018 06:23 PM, Cong Wang wrote: > On Thu, Nov 15, 2018 at 5:52 PM Herbert Xu > wrote: >> >> On Thu, Nov 15, 2018 at 03:16:02PM -0800, Cong Wang wrote: >>> The following evidences indicate this check is likely wrong: >>> >>> 1. In the assignment "skb->csum_valid = !sum", sum==0

Re: [Patch net] net: invert the check of detecting hardware RX checksum fault

2018-11-15 Thread Herbert Xu
On Thu, Nov 15, 2018 at 06:23:38PM -0800, Cong Wang wrote: > > > Normally if the hardware's partial checksum is valid then we just > > trust it and send the packet along. However, if the partial > > checksum is invalid we don't trust it and we will compute the > > whole checksum manually which is

[PATCH] [PATCH net-next] tun: fix multiqueue rx

2018-11-15 Thread Matthew Cover
When writing packets to a descriptor associated with a combined queue, the packets should end up on that queue. Before this change all packets written to any descriptor associated with a tap interface end up on rx-0, even when the descriptor is associated with a different queue. The rx traffic

[PATCH net-next] cxgb4: Remove SGE_HOST_PAGE_SIZE dependency on page size

2018-11-15 Thread Arjun Vynipadath
The SGE Host Page Size has nothing to do with the actual Host Page Size. It's the SGE's BAR2 Doorbell/GTS Page Size for interpreting the SGE Ingress/Egress Queue per Page values. Firmware reads all of these things and makes all the subsequent changes necessary. The Host Driver uses the SGE Host

Re: [Patch net] net: invert the check of detecting hardware RX checksum fault

2018-11-15 Thread Cong Wang
On Thu, Nov 15, 2018 at 5:52 PM Herbert Xu wrote: > > On Thu, Nov 15, 2018 at 03:16:02PM -0800, Cong Wang wrote: > > The following evidences indicate this check is likely wrong: > > > > 1. In the assignment "skb->csum_valid = !sum", sum==0 indicates a valid > > checksum. > > > > 2.

Re: [PATCH net-next 6/8] net: eth: altera: tse: add support for ptp and timestamping

2018-11-15 Thread Richard Cochran
On Thu, Nov 15, 2018 at 06:55:29AM -0800, Dalon Westergreen wrote: > Sure, I would like to keep the debugfs entries for disabling freq > correction,and > reading the current scaled_ppm value. I intend to use these to tune > anexternal > vcxo. If there is a better way to do this, please let me

Re: [Patch net] net: invert the check of detecting hardware RX checksum fault

2018-11-15 Thread Herbert Xu
On Thu, Nov 15, 2018 at 03:16:02PM -0800, Cong Wang wrote: > The following evidences indicate this check is likely wrong: > > 1. In the assignment "skb->csum_valid = !sum", sum==0 indicates a valid > checksum. > > 2. __skb_checksum_complete() always returns sum, and TCP packets are dropped >

[PATCH 09/10] flow_dissector: add basic ethtool_rx_flow_spec to flow_rule structure translator

2018-11-15 Thread Pablo Neira Ayuso
This patch adds a function to translate the ethtool_rx_flow_spec structure to the flow_rule representation. This allows us to reuse code from the driver side given that both flower and ethtool_rx_flow interfaces use the same representation. Signed-off-by: Pablo Neira Ayuso ---

[PATCH 04/10] cls_api: add translator to flow_action representation

2018-11-15 Thread Pablo Neira Ayuso
This patch implements a new function to translate from native TC action to the new flow_action representation. Moreover, this patch also updates cls_flower to use this new function. Signed-off-by: Pablo Neira Ayuso --- include/net/pkt_cls.h | 3 ++ net/sched/cls_api.c| 113

[PATCH 02/10] net/mlx5e: support for two independent packet edit actions

2018-11-15 Thread Pablo Neira Ayuso
This patch adds pedit_headers_action structure to store the result of parsing tc pedit actions. Then, it calls alloc_tc_pedit_action() to populate the mlx5e hardware intermediate representation once all actions have been parsed. This patch comes in preparation for the new flow_action

[PATCH 01/10] flow_dissector: add flow_rule and flow_match structures and use them

2018-11-15 Thread Pablo Neira Ayuso
This patch wraps the dissector key and mask - that flower uses to represent the matching side - around the flow_match structure. To avoid a follow up patch that would edit the same LoCs in the drivers, this patch also wraps this new flow match structure around the flow rule object. This new

[PATCH 05/10] cls_flower: add statistics retrieval infrastructure and use it

2018-11-15 Thread Pablo Neira Ayuso
This patch provides a tc_cls_flower_stats structure that acts as container for tc_cls_flower_offload, then we can use to restore the statistics on the existing TC actions. Hence, tcf_exts_stats_update() is not used from drivers. Signed-off-by: Pablo Neira Ayuso ---

[PATCH 07/10] cls_flower: don't expose TC actions to drivers anymore

2018-11-15 Thread Pablo Neira Ayuso
Now that drivers have been converted to use the flow action infrastructure, remove this field from the tc_cls_flower_offload structure. Signed-off-by: Pablo Neira Ayuso --- include/net/pkt_cls.h | 1 - net/sched/cls_flower.c | 5 - 2 files changed, 6 deletions(-) diff --git

[PATCH 00/10] add flow_rule infrastructure

2018-11-15 Thread Pablo Neira Ayuso
This patchset introduces a kernel intermediate representation (IR) to express ACL hardware offloads, this is heavily based on the existing flow dissector infrastructure and the TC actions. This IR can be used by different frontend ACL interfaces such as ethtool_rxnfc and tc to represent ACL

[PATCH 08/10] flow_dissector: add wake-up-on-lan and queue to flow_action

2018-11-15 Thread Pablo Neira Ayuso
These actions need to be added to support bcm sf2 features available through the ethtool_rx_flow interface. Reviewed-by: Florian Fainelli Signed-off-by: Pablo Neira Ayuso --- include/net/flow_dissector.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/include/net/flow_dissector.h

[PATCH 06/10] drivers: net: use flow action infrastructure

2018-11-15 Thread Pablo Neira Ayuso
This patch updates drivers to use the new flow action infrastructure. Signed-off-by: Pablo Neira Ayuso --- drivers/net/ethernet/broadcom/bnxt/bnxt_tc.c | 74 +++--- .../net/ethernet/chelsio/cxgb4/cxgb4_tc_flower.c | 250 +--

[PATCH 03/10] flow_dissector: add flow action infrastructure

2018-11-15 Thread Pablo Neira Ayuso
This new infrastructure defines the nic actions that you can perform from existing network drivers. This infrastructure allows us to avoid a direct dependency with the native software TC action representation. Signed-off-by: Pablo Neira Ayuso --- include/net/flow_dissector.h | 70

[PATCH 10/10] dsa: bcm_sf2: use flow_rule infrastructure

2018-11-15 Thread Pablo Neira Ayuso
Update this driver to use the flow_rule infrastructure, hence we can use the same code to populate hardware IR from ethtool_rx_flow and the cls_flower interfaces. Signed-off-by: Pablo Neira Ayuso --- drivers/net/dsa/bcm_sf2_cfp.c | 103 -- 1 file changed,

[iproute2-next PATCH v3 2/2] man: tc-flower: Add explanation for range option

2018-11-15 Thread Amritha Nambiar
Add details explaining filtering based on port ranges. Signed-off-by: Amritha Nambiar --- man/man8/tc-flower.8 | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/man/man8/tc-flower.8 b/man/man8/tc-flower.8 index 8be8882..768bfa1 100644 --- a/man/man8/tc-flower.8

[iproute2-next PATCH v3 1/2] tc: flower: Classify packets based port ranges

2018-11-15 Thread Amritha Nambiar
Added support for filtering based on port ranges. UAPI changes have been accepted into net-next. Example: 1. Match on a port range: - $ tc filter add dev enp4s0 protocol ip parent :\ prio 1 flower ip_proto tcp dst_port range 20-30 skip_hw\ action drop $ tc -s

[PATCH net-next] tcp: add SRTT to SCM_TIMESTAMPING_OPT_STATS

2018-11-15 Thread Yousuk Seung
Add TCP_NLA_SRTT to SCM_TIMESTAMPING_OPT_STATS that reports the smoothed round trip time in microseconds (tcp_sock.srtt_us >> 3). Signed-off-by: Yousuk Seung Signed-off-by: Eric Dumazet Acked-by: Soheil Hassas Yeganeh Acked-by: Neal Cardwell Acked-by: Yuchung Cheng ---

Re: [PATCH bpf-next v2] bpftool: make libbfd optional

2018-11-15 Thread Stanislav Fomichev
On 11/13, Quentin Monnet wrote: > 2018-11-12 14:02 UTC-0800 ~ Jakub Kicinski > > On Mon, 12 Nov 2018 13:44:10 -0800, Stanislav Fomichev wrote: > >> Make it possible to build bpftool without libbfd. libbfd and libopcodes are > >> typically provided in dev/dbg packages (binutils-dev in debian)

Re: [patch 1/1] drivers/net/ethernet/qlogic/qed/qed_rdma.h: fix typo

2018-11-15 Thread David Miller
From: a...@linux-foundation.org Date: Thu, 15 Nov 2018 16:15:20 -0800 > From: Andrew Morton > Subject: drivers/net/ethernet/qlogic/qed/qed_rdma.h: fix typo > > Add missing semicolon. > > Fixes: 291d57f67d244973 ("qed: Fix rdma_info structure allocation") > Cc: Michal Kalderon > Cc: Denis

[patch 1/1] drivers/net/ethernet/qlogic/qed/qed_rdma.h: fix typo

2018-11-15 Thread akpm
From: Andrew Morton Subject: drivers/net/ethernet/qlogic/qed/qed_rdma.h: fix typo Add missing semicolon. Fixes: 291d57f67d244973 ("qed: Fix rdma_info structure allocation") Cc: Michal Kalderon Cc: Denis Bolotin Cc: David S. Miller Signed-off-by: Andrew Morton ---

Re: [PATCH net 0/3] mlx4 fixes for 4.20-rc

2018-11-15 Thread David Miller
From: Tariq Toukan Date: Thu, 15 Nov 2018 18:05:12 +0200 > This patchset includes small fixes for mlx4_core driver. Series applied.

Re: [PATCH net-next 8/8] net: eth: altera: tse: update devicetree bindings documentation

2018-11-15 Thread Thor Thayer
+ Rob Herring, Mark Rutland and the Device Tree mailing list. On 11/14/18 6:50 PM, Dalon Westergreen wrote: From: Dalon Westergreen Update devicetree bindings documentation to include msgdma prefetcher and ptp bindings. Signed-off-by: Dalon Westergreen ---

[PATCH net-next] uapi/ethtool: fix spelling errors

2018-11-15 Thread Stephen Hemminger
Trivial spelling errors found by codespell. Signed-off-by: Stephen Hemminger --- include/uapi/linux/ethtool.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/uapi/linux/ethtool.h b/include/uapi/linux/ethtool.h index c8f8e2455bf3..17be76aeb468 100644 ---

Re: [PATCH net] sctp: not allow to set asoc prsctp_enable by sockopt

2018-11-15 Thread Neil Horman
On Thu, Nov 15, 2018 at 08:25:36PM -0200, Marcelo Ricardo Leitner wrote: > On Thu, Nov 15, 2018 at 04:43:10PM -0500, Neil Horman wrote: > > On Thu, Nov 15, 2018 at 03:22:21PM -0200, Marcelo Ricardo Leitner wrote: > > > On Thu, Nov 15, 2018 at 07:14:28PM +0800, Xin Long wrote: > > > > As

[Patch net] net: invert the check of detecting hardware RX checksum fault

2018-11-15 Thread Cong Wang
The following evidences indicate this check is likely wrong: 1. In the assignment "skb->csum_valid = !sum", sum==0 indicates a valid checksum. 2. __skb_checksum_complete() always returns sum, and TCP packets are dropped only when it returns non-zero. So non-zero indicates a failure. 3. In

Re: [Patch net-next] net: remove unused skb_send_sock()

2018-11-15 Thread David Miller
From: Cong Wang Date: Mon, 12 Nov 2018 18:05:24 -0800 > Signed-off-by: Cong Wang John, any plans to use this? Looks like only skb_send_sock_lock() currently has a user.

Re: [PATCH net-next 5/8] net: eth: altera: tse: Move common functions to altera_utils

2018-11-15 Thread Thor Thayer
On 11/14/18 6:50 PM, Dalon Westergreen wrote: From: Dalon Westergreen Move request_and_map and other shared functions to altera_utils. This is the first step to moving common code out of tse specific code so that it can be shared with future altera ethernet ip. Signed-off-by: Dalon

Re: [PATCH][net-next] net: slightly optimize eth_type_trans

2018-11-15 Thread David Miller
From: Li RongQing Date: Tue, 13 Nov 2018 09:34:31 +0800 > netperf udp stream shows that eth_type_trans takes certain cpu, > so adjust the mac address check order, and firstly check if it > is device address, and only check if it is multicast address > only if not the device address. > > After

Re: [PATCH net-next 4/8] net: eth: altera: tse: add optional function to start tx dma

2018-11-15 Thread Thor Thayer
On 11/14/18 6:50 PM, Dalon Westergreen wrote: From: Dalon Westergreen Allow for optional start up of tx dma if the start_txdma function is defined in altera_dmaops. Signed-off-by: Dalon Westergreen --- drivers/net/ethernet/altera/altera_tse.h | 1 +

Re: [PATCH v3 net-next 0/4] net: batched receive in GRO path

2018-11-15 Thread Eric Dumazet
On 11/15/2018 02:45 PM, Edward Cree wrote: > On 15/11/18 22:01, Eric Dumazet wrote: >> On 11/15/2018 01:45 PM, Edward Cree wrote: >>> If napi->poll() is only handling one packet, surely GRO can't do anything >>>  useful either?  (AIUI at the end of the poll the GRO lists get flushed.) >> That

Re: [PATCH][net-next][v2] net: remove BUG_ON from __pskb_pull_tail

2018-11-15 Thread David Miller
From: Li RongQing Date: Tue, 13 Nov 2018 09:16:52 +0800 > if list is NULL pointer, and the following access of list > will trigger panic, which is same as BUG_ON > > Signed-off-by: Li RongQing Applied.

Re: [PATCH net-next 3/8] net: eth: altera: tse: fix altera_dmaops declaration

2018-11-15 Thread Thor Thayer
On 11/14/18 6:50 PM, Dalon Westergreen wrote: From: Dalon Westergreen The declaration of struct altera_dmaops does not have identifier names. Add identifier names to confrom with required coding styles. Signed-off-by: Dalon Westergreen --- drivers/net/ethernet/altera/altera_tse.h | 30

Re: [net-next 00/14][pull request] 40GbE Intel Wired LAN Driver Updates 2018-11-14

2018-11-15 Thread David Miller
From: Jeff Kirsher Date: Wed, 14 Nov 2018 15:10:18 -0800 > This series contains updates to i40e and virtchnl. Pulled, thanks Jeff.

Re: [PATCH net-next 2/8] net: eth: altera: set rx and tx ring size before init_dma call

2018-11-15 Thread Thor Thayer
On 11/14/18 6:50 PM, Dalon Westergreen wrote: From: Dalon Westergreen It is more appropriate to set the rx and tx ring size before calling the init function for the dma. Signed-off-by: Dalon Westergreen --- drivers/net/ethernet/altera/altera_tse_main.c | 6 -- 1 file changed, 4

Re: [PATCH net-next 1/8] net: eth: altera: tse_start_xmit ignores tx_buffer call response

2018-11-15 Thread Thor Thayer
On 11/14/18 6:50 PM, Dalon Westergreen wrote: From: Dalon Westergreen The return from tx_buffer call in tse_start_xmit is inapropriately ignored. tse_buffer calls should return 0 for success or NETDEV_TX_BUSY. tse_start_xmit should return not report a successful transmit when the tse_buffer

Re: [PATCH net-next 00/11] mlxsw: spectrum: acl: Introduce ERP sharing by multiple masks

2018-11-15 Thread David Miller
From: Ido Schimmel Date: Wed, 14 Nov 2018 08:22:25 + > Jiri says: > > The Spectrum-2 hardware has limitation number of ERPs per-region. In > order to accommodate more masks than number of ERPs, the hardware > supports to insert rules with delta bits. By that, the rules with masks > that

Re: [PATCH v3 net-next 0/4] net: batched receive in GRO path

2018-11-15 Thread Edward Cree
On 15/11/18 22:01, Eric Dumazet wrote: > On 11/15/2018 01:45 PM, Edward Cree wrote: >> If napi->poll() is only handling one packet, surely GRO can't do anything >>  useful either?  (AIUI at the end of the poll the GRO lists get flushed.) > That is my point. > > Adding yet another layer that will

[PATCH iproute2 10/22] ipxfrm: make local functions static

2018-11-15 Thread Stephen Hemminger
Make functions only used in ipxfrm.c static. Signed-off-by: Stephen Hemminger --- ip/ipxfrm.c | 11 ++- ip/xfrm.h | 9 - ip/xfrm_monitor.c | 2 +- 3 files changed, 7 insertions(+), 15 deletions(-) diff --git a/ip/ipxfrm.c b/ip/ipxfrm.c index

Re: [PATCH v3 net-next 0/4] net: batched receive in GRO path

2018-11-15 Thread Edward Cree
Some corrections as it looks like I didn't proofread this carefully enough  before sending it... On 14/11/18 18:07, Edward Cree wrote: > Payload_size in all tests was 8000 bytes. This was for TCP tests; the UDP test used 1-byte payloads. > UDP Stream (GRO off): > net-next: 7.808 Gb/s > after #4:

[PATCH iproute2 22/22] rdma: make local functions static

2018-11-15 Thread Stephen Hemminger
Several functions only used inside utils.c Signed-off-by: Stephen Hemminger --- rdma/rdma.h | 11 --- rdma/utils.c | 12 ++-- 2 files changed, 6 insertions(+), 17 deletions(-) diff --git a/rdma/rdma.h b/rdma/rdma.h index c3b7530b6cc7..05c3c69b07fd 100644 --- a/rdma/rdma.h +++

[PATCH iproute2 15/22] ss: make local variables static

2018-11-15 Thread Stephen Hemminger
Several variables only used in this code. Signed-off-by: Stephen Hemminger --- misc/ss.c | 28 ++-- 1 file changed, 14 insertions(+), 14 deletions(-) diff --git a/misc/ss.c b/misc/ss.c index 4d12fb5d19df..e4d6ae489e79 100644 --- a/misc/ss.c +++ b/misc/ss.c @@ -96,20

[PATCH iproute2 06/22] genl: remove dead code

2018-11-15 Thread Stephen Hemminger
The function genl_ctrl_resolve_family is defined but never used in current code. Signed-off-by: Stephen Hemminger --- genl/ctrl.c | 71 --- genl/genl_utils.h | 2 -- 2 files changed, 73 deletions(-) diff --git a/genl/ctrl.c b/genl/ctrl.c index

[PATCH iproute2 03/22] lib/color: make local functions static

2018-11-15 Thread Stephen Hemminger
color_enable etc, only used here. Signed-off-by: Stephen Hemminger --- include/color.h | 2 -- lib/color.c | 6 -- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/include/color.h b/include/color.h index e30f28c51c84..17ec56f3d7b4 100644 --- a/include/color.h +++

[PATCH iproute2 04/22] lib/ll_map: make local function static

2018-11-15 Thread Stephen Hemminger
ll_idx_a2n is only used in ll_map. Signed-off-by: Stephen Hemminger --- include/ll_map.h | 1 - lib/ll_map.c | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/include/ll_map.h b/include/ll_map.h index fb708191c22c..511fe00b8567 100644 --- a/include/ll_map.h +++

[PATCH iproute2 09/22] ipmonitor: make local variable static

2018-11-15 Thread Stephen Hemminger
prefix_banner only used in one file. Signed-off-by: Stephen Hemminger --- ip/ipmonitor.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ip/ipmonitor.c b/ip/ipmonitor.c index 9d5ac2b5e4d2..743632cc5569 100644 --- a/ip/ipmonitor.c +++ b/ip/ipmonitor.c @@ -24,7 +24,7 @@

[PATCH iproute2 11/22] tc: drop unused name_to_id function

2018-11-15 Thread Stephen Hemminger
Not used in current code. Signed-off-by: Stephen Hemminger --- include/names.h | 1 - lib/names.c | 28 2 files changed, 29 deletions(-) diff --git a/include/names.h b/include/names.h index 3e5d3b146a23..2fcaacc398d4 100644 --- a/include/names.h +++

[PATCH iproute2 12/22] tipc: make cmd_find static

2018-11-15 Thread Stephen Hemminger
Function only used in one file. Signed-off-by: Stephen Hemminger --- tipc/cmdl.c | 2 +- tipc/cmdl.h | 2 -- 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/tipc/cmdl.c b/tipc/cmdl.c index 4a2f4fd92f48..f2f259cc5320 100644 --- a/tipc/cmdl.c +++ b/tipc/cmdl.c @@ -17,7 +17,7 @@

[PATCH iproute2 13/22] tc/class: make filter variables static

2018-11-15 Thread Stephen Hemminger
Only used in this file. Signed-off-by: Stephen Hemminger --- tc/tc_class.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tc/tc_class.c b/tc/tc_class.c index 7e4e17fd7f39..7ac700d7ab31 100644 --- a/tc/tc_class.c +++ b/tc/tc_class.c @@ -153,9 +153,9 @@ static int

[PATCH iproute2 20/22] tc/action: make variables static

2018-11-15 Thread Stephen Hemminger
Signed-off-by: Stephen Hemminger --- tc/m_action.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tc/m_action.c b/tc/m_action.c index e90867fc6c25..d5fd5affe703 100644 --- a/tc/m_action.c +++ b/tc/m_action.c @@ -30,9 +30,9 @@ static struct action_util *action_list;

[PATCH iproute2 21/22] tc/pedit: use structure initialization

2018-11-15 Thread Stephen Hemminger
The pedit callback structure table should be iniatialized using structure initialization to avoid structure changes problems. Signed-off-by: Stephen Hemminger --- tc/p_eth.c | 5 ++--- tc/p_icmp.c | 5 ++--- tc/p_ip.c | 5 ++--- tc/p_ip6.c | 5 ++--- tc/p_tcp.c | 5 ++--- tc/p_udp.c | 5

[PATCH iproute2 14/22] tc/police: make print_police static

2018-11-15 Thread Stephen Hemminger
print_police function only used by m_police. Signed-off-by: Stephen Hemminger --- tc/m_police.c | 10 +++--- tc/tc_util.h | 3 --- 2 files changed, 7 insertions(+), 6 deletions(-) diff --git a/tc/m_police.c b/tc/m_police.c index f3b07f7b0439..d645999ba08b 100644 --- a/tc/m_police.c +++

[PATCH iproute2 16/22] tc/pedit: make functions static

2018-11-15 Thread Stephen Hemminger
The parse and pack functions are only used by the pedit routines. Signed-off-by: Stephen Hemminger --- tc/m_pedit.c | 33 ++--- tc/m_pedit.h | 15 --- 2 files changed, 14 insertions(+), 34 deletions(-) diff --git a/tc/m_pedit.c b/tc/m_pedit.c index

[PATCH iproute2 19/22] tc/meta: make meta_table static and const

2018-11-15 Thread Stephen Hemminger
The mapping table is only used by em_meta. Signed-off-by: Stephen Hemminger --- tc/em_meta.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/tc/em_meta.c b/tc/em_meta.c index d94fe88d9b2f..2ddc65ed6cb6 100644 --- a/tc/em_meta.c +++ b/tc/em_meta.c @@ -38,7 +38,7

[PATCH iproute2 07/22] bridge: make local variables static

2018-11-15 Thread Stephen Hemminger
enable_color and set_color_palette only used here. Signed-off-by: Stephen Hemminger --- bridge/bridge.c | 5 ++--- bridge/monitor.c | 2 +- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/bridge/bridge.c b/bridge/bridge.c index ac4d6a14f510..389f1bd5382b 100644 ---

[PATCH iproute2 18/22] tc/util: make local functions static

2018-11-15 Thread Stephen Hemminger
The tc util library parse/print has functions only used locally (and some dead code removed). Signed-off-by: Stephen Hemminger --- tc/tc_util.c | 17 +++-- tc/tc_util.h | 5 - 2 files changed, 3 insertions(+), 19 deletions(-) diff --git a/tc/tc_util.c b/tc/tc_util.c index

[PATCH iproute2 17/22] tc/ematch: make local functions static

2018-11-15 Thread Stephen Hemminger
The print handling is only used in tc/m_ematch.c Remove unused function to print_ematch_tree. Signed-off-by: Stephen Hemminger --- tc/m_ematch.c | 30 +++--- tc/m_ematch.h | 1 - 2 files changed, 3 insertions(+), 28 deletions(-) diff --git a/tc/m_ematch.c

[PATCH iproute2 08/22] ip: make flag names const/static

2018-11-15 Thread Stephen Hemminger
The table of filter flags is only used in ipaddress Signed-off-by: Stephen Hemminger --- ip/ipaddress.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ip/ipaddress.c b/ip/ipaddress.c index cd8cc76a3473..2671c4e162e3 100644 --- a/ip/ipaddress.c +++ b/ip/ipaddress.c @@

[PATCH iproute2 00/22] misc cleanups

2018-11-15 Thread Stephen Hemminger
Code cleanup including: * make local functions static * drop dead code * whitespace code style cleanup Stephen Hemminger (22): lib/ll_addr: whitespace and indent cleanup lib/utils: make local functions static lib/color: make local functions static lib/ll_map: make local function

[PATCH iproute2 02/22] lib/utils: make local functions static

2018-11-15 Thread Stephen Hemminger
Some of the print/parsing is only used internally. Drop unused get_s8/get_s16. Signed-off-by: Stephen Hemminger --- include/utils.h | 5 - lib/utils.c | 48 +++- 2 files changed, 7 insertions(+), 46 deletions(-) diff --git a/include/utils.h

[PATCH iproute2 01/22] lib/ll_addr: whitespace and indent cleanup

2018-11-15 Thread Stephen Hemminger
Run old ll_addr through kernel Lindent. Signed-off-by: Stephen Hemminger --- lib/ll_addr.c | 24 +--- 1 file changed, 13 insertions(+), 11 deletions(-) diff --git a/lib/ll_addr.c b/lib/ll_addr.c index 84de64e2e053..00b562aeda22 100644 --- a/lib/ll_addr.c +++ b/lib/ll_addr.c

[PATCH iproute2 05/22] libnetlnk: unused and local functions cleanup

2018-11-15 Thread Stephen Hemminger
rntl_talk_extack and parse_rtattr_index not used in current code. rtnl_dump_filter_l is only used in this file. Signed-off-by: Stephen Hemminger --- include/libnetlink.h | 7 --- lib/libnetlink.c | 28 ++-- 2 files changed, 2 insertions(+), 33 deletions(-) diff

Re: [PATCH net] sctp: not allow to set asoc prsctp_enable by sockopt

2018-11-15 Thread Marcelo Ricardo Leitner
On Thu, Nov 15, 2018 at 04:43:10PM -0500, Neil Horman wrote: > On Thu, Nov 15, 2018 at 03:22:21PM -0200, Marcelo Ricardo Leitner wrote: > > On Thu, Nov 15, 2018 at 07:14:28PM +0800, Xin Long wrote: > > > As rfc7496#section4.5 says about SCTP_PR_SUPPORTED: > > > > > >This socket option allows

Re: [PATCH v3 net-next 0/4] net: batched receive in GRO path

2018-11-15 Thread Eric Dumazet
On 11/15/2018 01:45 PM, Edward Cree wrote: > > If napi->poll() is only handling one packet, surely GRO can't do anything >  useful either?  (AIUI at the end of the poll the GRO lists get flushed.) That is my point. Adding yet another layer that will add no gain but add more waste of cpu

Re: [PATCH v3 net-next 0/4] net: batched receive in GRO path

2018-11-15 Thread Edward Cree
On 15/11/18 20:08, Eric Dumazet wrote: > On 11/15/2018 10:43 AM, Edward Cree wrote: > > Most of the packet isn't touched and thus won't be brought into cache. >> Only the headers of each packet (worst-case let's say 256 bytes) will >>  be touched during batch processing, that's 16kB. > You assume

Re: [PATCH net] sctp: not allow to set asoc prsctp_enable by sockopt

2018-11-15 Thread Neil Horman
On Thu, Nov 15, 2018 at 03:22:21PM -0200, Marcelo Ricardo Leitner wrote: > On Thu, Nov 15, 2018 at 07:14:28PM +0800, Xin Long wrote: > > As rfc7496#section4.5 says about SCTP_PR_SUPPORTED: > > > >This socket option allows the enabling or disabling of the > >negotiation of PR-SCTP support

Re: DSA support for Marvell 88e6065 switch

2018-11-15 Thread Andrew Lunn
On Thu, Nov 15, 2018 at 08:51:11PM +0100, Pavel Machek wrote: > Hi! > > I'm trying to create support for Marvell 88e6065 switch... and it > seems like drivers/net/dsa supports everything, but this model. > > Did someone work with this hardware before? Any idea if it would be > more suitable to

Re: [PATCH v3 net-next 0/4] net: batched receive in GRO path

2018-11-15 Thread Eric Dumazet
On 11/15/2018 10:43 AM, Edward Cree wrote: Most of the packet isn't touched and thus won't be brought into cache. > Only the headers of each packet (worst-case let's say 256 bytes) will >  be touched during batch processing, that's 16kB. You assume perfect use of the caches, but part of the

DSA support for Marvell 88e6065 switch

2018-11-15 Thread Pavel Machek
Hi! I'm trying to create support for Marvell 88e6065 switch... and it seems like drivers/net/dsa supports everything, but this model. Did someone work with this hardware before? Any idea if it would be more suitable to support by existing 88e6060 code, or if 88e6xxx code should serve as a base?

Re: [PATCH net] ipv6: fix a dst leak when removing its exception

2018-11-15 Thread David Ahern
On 11/13/18 8:48 AM, Xin Long wrote: > These is no need to hold dst before calling rt6_remove_exception_rt(). > The call to dst_hold_safe() in ip6_link_failure() was for ip6_del_rt(), > which has been removed in Commit 93531c674315 ("net/ipv6: separate > handling of FIB entries from dst based

Re: [PATCH net] net_sched: sch_fq: ensure maxrate fq parameter applies to EDT flows

2018-11-15 Thread David Miller
From: Eric Dumazet Date: Mon, 12 Nov 2018 16:17:16 -0800 > When EDT conversion happened, fq lost the ability to enfore a maxrate > for all flows. It kept it for non EDT flows. > > This commit restores the functionality. > > Tested: > > tc qd replace dev eth0 root fq maxrate 500Mbit > netperf

Re: [net-next PATCH v4] net: sched: cls_flower: Classify packets using port ranges

2018-11-15 Thread David Miller
From: Amritha Nambiar Date: Mon, 12 Nov 2018 16:15:55 -0800 > Added support in tc flower for filtering based on port ranges. > > Example: ... > v4: > 1. Added condition before setting port key. > 2. Organized setting and dumping port range keys into functions >and added validation of input

Re: [Patch net-next v2] net: dump more useful information in netdev_rx_csum_fault()

2018-11-15 Thread David Miller
From: Cong Wang Date: Mon, 12 Nov 2018 14:47:18 -0800 > Currently netdev_rx_csum_fault() only shows a device name, > we need more information about the skb for debugging csum > failures. > > Sample output: > > ens3: hw csum failure > dev features: 0x00014b89 > skb len=84 data_len=0

Re: [PATCHv2 net-net] net: dsa: mv88e6xxx: Work around mv886e6161 SERDES missing MII_PHYSID2

2018-11-15 Thread David Miller
From: Andrew Lunn Date: Mon, 12 Nov 2018 18:51:01 +0100 > We already have a workaround for a couple of switches whose internal > PHYs only have the Marvel OUI, but no model number. We detect such > PHYs and give them the 6390 ID as the model number. However the > mv88e6161 has two SERDES

[PATCH iproute2] testsuite: drop old kernel configs

2018-11-15 Thread Stephen Hemminger
The testsuite directory had a directory of ancient kernel configs. Signed-off-by: Stephen Hemminger --- testsuite/configs/all-2.4| 848 - testsuite/configs/all-no-act | 1499 - testsuite/configs/all-police-act | 1504

[PATCH iproute2-next] drop support for IPX

2018-11-15 Thread Stephen Hemminger
IPX has been depracted then removed from upstream kernels. Drop support from ip route as well. Signed-off-by: Stephen Hemminger --- Makefile | 3 -- include/utils.h| 10 - ip/ip.c| 4 +- ip/iproute.c | 2 +- lib/ipx_ntop.c | 71

Re: [net-next 00/11][pull request] 100GbE Intel Wired LAN Driver Updates 2018-11-13

2018-11-15 Thread David Miller
From: Jeff Kirsher Date: Tue, 13 Nov 2018 10:32:28 -0800 > This series contains updates to the ice driver only. Pulled, thanks Jeff.

Re: [PATCH net] ipv6: fix a dst leak when removing its exception

2018-11-15 Thread Mika Penttilä
On 15.11.2018 20.17, David Ahern wrote: > On 11/14/18 11:23 PM, Xin Long wrote: >> On Thu, Nov 15, 2018 at 3:33 PM David Ahern wrote: >>> On 11/14/18 11:03 AM, David Ahern wrote: On 11/13/18 8:48 AM, Xin Long wrote: > These is no need to hold dst before calling

Re: pending-fixes build: 1 failures 5 warnings (v4.20-rc2-261-g59a9ebee0952)

2018-11-15 Thread Mark Brown
On Thu, Nov 15, 2018 at 05:00:30PM +, Build bot for Mark Brown wrote: Today's pending-fixes branch fails to build an arm allmodconfig due to: > arm-allmodconfig > ../drivers/net/ethernet/qlogic/qed/qed_rdma.h:186:79: error: expected ';' > before '}' token >

Re: [PATCH v3 net-next 0/4] net: batched receive in GRO path

2018-11-15 Thread Edward Cree
On 15/11/18 07:22, Eric Dumazet wrote: > On 11/14/2018 10:07 AM, Edward Cree wrote: >> Conclusion: >> * TCP b/w is 16.5% faster for traffic which cannot be coalesced by GRO. > But only for traffic that actually was perfect GRO candidate, right ? > > Now what happens if all the packets you are

Re: [PATCH net] ipv6: fix a dst leak when removing its exception

2018-11-15 Thread David Ahern
On 11/14/18 11:23 PM, Xin Long wrote: > On Thu, Nov 15, 2018 at 3:33 PM David Ahern wrote: >> >> On 11/14/18 11:03 AM, David Ahern wrote: >>> On 11/13/18 8:48 AM, Xin Long wrote: These is no need to hold dst before calling rt6_remove_exception_rt(). The call to dst_hold_safe() in

Re: [PATCH net V2] cxgb4: fix thermal zone build error

2018-11-15 Thread Randy Dunlap
On 11/15/18 2:06 AM, Ganesh Goudar wrote: > with CONFIG_THERMAL=m and cxgb4 as built-in build fails, and > 'commit e70a57fa59bb ("cxgb4: fix thermal configuration dependencies")' > tries to fix it but when cxgb4i is made built-in build fails again, > use IS_REACHABLE instead of IS_ENABLED to fix

Re: [PATCH net V2 0/5] net/smc: fixes 2018-11-12

2018-11-15 Thread David Miller
From: Ursula Braun Date: Thu, 15 Nov 2018 13:11:15 +0100 > v1->v2: >do not define 8-byte alignment for union smcd_cdc_cursor in >patch 4/5 "net/smc: atomic SMCD cursor handling" This is even worse. The atomic64_t must be properly 8 byte aligned, else it will crash the kernel when an

Re: [PATCH net V2] cxgb4: fix thermal zone build error

2018-11-15 Thread David Miller
From: Ganesh Goudar Date: Thu, 15 Nov 2018 15:36:21 +0530 > with CONFIG_THERMAL=m and cxgb4 as built-in build fails, and > 'commit e70a57fa59bb ("cxgb4: fix thermal configuration dependencies")' > tries to fix it but when cxgb4i is made built-in build fails again, > use IS_REACHABLE instead of

Re: [PATCHv2] MAINTAINERS: Replace Vince Bridgers as Altera TSE maintainer

2018-11-15 Thread David Miller
From: thor.tha...@linux.intel.com Date: Mon, 12 Nov 2018 11:50:56 -0600 > From: Thor Thayer > > Vince has moved to a different role. Replace him as Altera > TSE maintainer. > > Signed-off-by: Thor Thayer > Acked-by: Vince Bridgers > Acked-by: Alan Tull > --- > v2 Include netdev and David

Re: [PATCH net 0/6] bnxt_en: Bug fixes.

2018-11-15 Thread David Miller
From: Michael Chan Date: Thu, 15 Nov 2018 03:25:36 -0500 > Most of the bug fixes are related to the new 57500 chips, including some > initialization and counter fixes, disabling RDMA support, and a > workaround for occasional missing interrupts. The last patch from > Vasundhara fixes the

Re: [PATCH net-next] net: phy: check for implementation of both callbacks in phy_drv_supports_irq

2018-11-15 Thread David Miller
From: Heiner Kallweit Date: Mon, 12 Nov 2018 21:16:06 +0100 > Now that the icplus driver has been fixed all PHY drivers supporting > interrupts have both callbacks (config_intr and ack_interrupt) > implemented - as it should be. Therefore phy_drv_supports_irq() > can be changed now to check for

[PATCH iproute2] genl: remove dead code

2018-11-15 Thread Stephen Hemminger
The function genl_ctrl_resolve_family is defined but never used in current code. Signed-off-by: Stephen Hemminger --- genl/ctrl.c | 71 --- genl/genl_utils.h | 2 -- 2 files changed, 73 deletions(-) diff --git a/genl/ctrl.c b/genl/ctrl.c index

Re: [PATCH net] sctp: not allow to set asoc prsctp_enable by sockopt

2018-11-15 Thread Marcelo Ricardo Leitner
On Thu, Nov 15, 2018 at 07:14:28PM +0800, Xin Long wrote: > As rfc7496#section4.5 says about SCTP_PR_SUPPORTED: > >This socket option allows the enabling or disabling of the >negotiation of PR-SCTP support for future associations. For existing >associations, it allows one to query

Re: Ethernet on my CycloneV broke since 4.9.124

2018-11-15 Thread Dinh Nguyen
On 11/15/18 9:50 AM, Clément Péron wrote: > Hi Dinh, > > Did you upstream the patch on linux-stable ? > Not yet... Dinh > On Fri, 2 Nov 2018 at 11:02, Clément Péron wrote: >> >> Hi Dinh, >> >> On Wed, 31 Oct 2018 at 23:02, Dinh Nguyen wrote: >>> >>> Hi Clement, >>> >>> On 10/31/2018 10:36

[PATCH net 0/3] mlx4 fixes for 4.20-rc

2018-11-15 Thread Tariq Toukan
Hi Dave, This patchset includes small fixes for mlx4_core driver. First patch by Jack zeros a field in a FW communication command, to match the FW spec. Please queue it to -stable >= v3.17. In the second patch I zero-initialize a variable to silence a compliation warning. Please queue it to

  1   2   >