The values represented by qede->flags is being used in mixed ways:
1. As 'value' at some places e.g., QEDE_FLAGS_IS_VF usage
2. As bit-mask(value) at some places e.g., QEDE_FLAGS_PTP_TX_IN_PRORGESS
usage.
This implementation pose problems in future when we want to add more flag
values
The patch adds driver support for MBI image update through MFW.
Signed-off-by: Sudarsana Reddy Kalluru
Signed-off-by: Ariel Elior
Signed-off-by: Michal Kalderon
---
drivers/net/ethernet/qlogic/qed/qed_hsi.h | 6
drivers/net/ethernet/qlogic/qed/qed_main.c | 13 +++--
In the case of internal reload (e.g., mtu change), there could be a race
between link-up notification from mfw and the driver unload processing. In
such case kernel assumes the link is up and starts using the queues which
leads to the server crash.
Send link notification to the kernel only when
MFW sends UFP notifications mostly during the device init phase and PFs
might not be assigned with a name by this time. Hence capturing port-id in
the debug messages would help in finding which PF the ufp notification was
sent to.
Also, fixed a minor scemantic issue in a debug print.
From: Sudarsana Reddy Kalluru
The patch series add few enhancements to qed/qede drivers.
Changes from previous versions:
---
v2: Use __set_bit()/__clear_bit() where data access doesn't need to be
atomic.
Please consider applying it to "net-next".
Sudarsana
From: David Ahern
Date: Thu, 22 Nov 2018 09:51:27 -0700
> I would like to see basic packets, bytes, and dropped counters tracked
> for Rx and Tx via the standard netdev counters for all devices. This is
> for ease in accounting as well as speed and simplicity for bumping
> counters for virtual
Kernel commit 48872c11b772 ("net_sched: sch_fq: add dctcp-like marking")
added support for TCA_FQ_CE_THRESHOLD attribute.
This patch adds iproute2 support for it.
It also makes sure fq_print_xstats() can deal with smaller tc_fq_qd_stats
structures given by older kernels.
Usage :
From: Linus Walleij
Date: Sat, 24 Nov 2018 00:16:34 +0100
> From: Andreas Fiedler
>
> The TX stats should be started with the tx_stats_syncp,
> there seems to be a copy/paste error in the driver.
>
> Signed-off-by: Andreas Fiedler
> Signed-off-by: Linus Walleij
Applied.
From: Fabio Estevam
Date: Fri, 23 Nov 2018 15:46:50 -0200
> The correct form is "can be probed", so fix the typo.
>
> Signed-off-by: Fabio Estevam
Applied.
From: Lorenzo Bianconi
Date: Fri, 23 Nov 2018 18:28:01 +0100
> Reset snd_queue tso_hdrs pointer to NULL in nicvf_free_snd_queue routine
> since it is used to check if tso dma descriptor queue has been previously
> allocated. The issue can be triggered with the following reproducer:
>
> $ip link
From: Sudarsana Reddy Kalluru
Date: Thu, 22 Nov 2018 22:44:49 -0800
> - edev->flags |= QEDE_FLAG_IS_VF;
> + set_bit(QEDE_FLAGS_IS_VF, >flags);
...
> - edev->flags |= QEDE_TX_TIMESTAMPING_EN;
> + set_bit(QEDE_FLAGS_TX_TIMESTAMPING_EN, >flags);
...
From: Petr Machata
Date: Thu, 22 Nov 2018 23:27:52 +
> An offloading driver may need to have access to switchdev events on
> ports that aren't directly under its control. An example is a VXLAN port
> attached to a bridge offloaded by a driver. The driver needs to know
> about VLANs
From: Heiner Kallweit
Date: Thu, 22 Nov 2018 21:54:36 +0100
> This series includes a few functional improvements.
Series applied.
From: Linu Cherian
Date: Thu, 22 Nov 2018 17:18:33 +0530
> From: Linu Cherian
>
> Patch 1: Code cleanup
> Patch 2: Adds support for an unhandled hardware configuration
> Patch 3: Preparatory patch for enabling cgx lmac links
> Patch 4: Support for enabling cgx lmac links
Series applied.
From: Ursula Braun
Date: Thu, 22 Nov 2018 10:26:33 +0100
> here are more patches for SMC:
> * patches 1-3 and 7 are cleanups without functional change
> * patches 4-6 and 8 are optimizations of existing code
> * patches 9 and 10 introduce and exploit LLC message DELETE RKEY
Series applied.
From: Hangbin Liu
Date: Thu, 22 Nov 2018 16:15:28 +0800
> team_notify_peers() will send ARP and NA to notify peers. team_mcast_rejoin()
> will send multicast join group message to notify peers. We should do this when
> enabling/changed to a new port. But it doesn't make sense to do it when a
Hi Cody,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on mac80211-next/master]
url:
https://github.com/0day-ci/linux/commits/Cody-Schuffelen/mac80211-next-rtnetlink-wifi-simulation-device/20181124-020949
base:
Document API and ABI for libbpf: naming convention, symbol visibility,
ABI versioning.
This is just a starting point. Documentation can be significantly
extended in the future to cover more topics.
ABI versioning section touches only a few basic points with a link to
more comprehensive
More and more projects use libbpf and one day it'll likely be packaged
and distributed as DSO and that requires ABI versioning so that both
compatible and incompatible changes to ABI can be introduced in a safe
way in the future without breaking executables dynamically linked with a
previous
Since ABI versioning info is kept separately from the code it's easy to
forget to update it while adding a new API.
Add simple verification that all global symbols exported with LIBBPF_API
are versioned in libbpf.map version script.
The idea is to check that number of global symbols in
This patch set adds ABI versioning and documentation to libbpf.
Patch 1 renames btf_get_from_id to btf__get_from_id to follow naming
convention.
Patch 2 adds version script and has more details on ABI versioning.
Patch 3 adds simple check that all global symbols are versioned.
Patch 4 documents a
From: Martin KaFai Lau
s/btf_get_from_id/btf__get_from_id/ to restore the API naming convention.
Signed-off-by: Martin KaFai Lau
Signed-off-by: Andrey Ignatov
---
tools/bpf/bpftool/map.c| 4 ++--
tools/bpf/bpftool/prog.c | 2 +-
tools/lib/bpf/btf.c
Daniel Borkmann [Thu, 2018-11-22 02:28 -0800]:
> On 11/21/2018 11:22 PM, Alexei Starovoitov wrote:
> > On 11/21/18 12:18 PM, Yonghong Song wrote:
> >> On 11/21/18 9:40 AM, Andrey Ignatov wrote:
> >>> More and more projects use libbpf and one day it'll likely be packaged
> >>> and distributed as
Make the formatting for map_type_name array consistent.
Signed-off-by: David Calavera
---
tools/bpf/bpftool/map.c | 46 -
1 file changed, 23 insertions(+), 23 deletions(-)
diff --git a/tools/bpf/bpftool/map.c b/tools/bpf/bpftool/map.c
index
Building tags produces warning:
ctags: Warning: kernel/bpf/local_storage.c:10: null expansion of name pattern
"\1"
Let's use the same fix as in commit <25528213fe9f75f4>, even though it
violates the usual code style.
Signed-off-by: Rustam Kovhaev
---
kernel/bpf/local_storage.c | 3 +--
1
From: Andreas Fiedler
The TX stats should be started with the tx_stats_syncp,
there seems to be a copy/paste error in the driver.
Signed-off-by: Andreas Fiedler
Signed-off-by: Linus Walleij
---
drivers/net/ethernet/cortina/gemini.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff
On Fri, Nov 23, 2018 at 2:09 PM David Miller wrote:
>
> From: Willem de Bruijn
> Date: Tue, 20 Nov 2018 13:00:18 -0500
>
> > From: Willem de Bruijn
> >
> > tpacket_snd sends packets with user pages linked into skb frags. It
> > notifies that pages can be reused when the skb is released by
On 11/22/2018 03:09 PM, Lorenz Bauer wrote:
> Add a new function, which encourages safe usage of the test interface.
> bpf_prog_test_run continues to work as before, but should be considered
> unsafe.
>
> Signed-off-by: Lorenz Bauer
Set looks good to me, thanks! Three small things below:
> ---
On 11/23/2018 09:58 PM, Nikita V. Shirokov wrote:
> currently by default libbpf's bpf_object__open requires
> bpf's program to specify version in a code because of two things:
> 1) default prog type is set to KPROBE
> 2) KPROBE requires (in kernel/bpf/syscall.c) version to be specified
>
> in
On 11/22/2018 11:14 PM, Daniel T. Lee wrote:
> Currently, kprobe_events failure won't be handled properly.
> Due to calling system() indirectly to write to kprobe_events,
> it can't be identified whether an error is derived from kprobe or system.
>
> // buf = "echo '%c:%s %s' >>
On 11/23/2018 06:48 PM, David Calavera wrote:
> Hi,
>
> Sorry for the mistake, I'll send a new patch. Before doing that, I've
> noticed that the array of map names in tools/bpf/bpftool/map.c is very
> inconsistent in formatting, some lines use tabs to align the names, others
> use spaces, and
currently by default libbpf's bpf_object__open requires
bpf's program to specify version in a code because of two things:
1) default prog type is set to KPROBE
2) KPROBE requires (in kernel/bpf/syscall.c) version to be specified
in this patch i'm changing default prog type to UNSPEC and also
On 11/23/2018 05:43 PM, Martynas Pumputis wrote:
> A format string consisting of "%p" or "%s" followed by an invalid
> specifier (e.g. "%p%\n" or "%s%") could pass the check which
> would make format_decode (lib/vsprintf.c) to warn.
>
> Reported-by:
Martin Lau [Fri, 2018-11-23 10:44 -0800]:
> On Wed, Nov 21, 2018 at 02:22:14PM -0800, Alexei Starovoitov wrote:
> > On 11/21/18 12:18 PM, Yonghong Song wrote:
> > >
> > >
> > > On 11/21/18 9:40 AM, Andrey Ignatov wrote:
> > >> More and more projects use libbpf and one day it'll likely be
From: Jeff Kirsher
Date: Wed, 21 Nov 2018 11:54:17 -0800
> This series contains updates to all of the Intel LAN drivers and
> documentation.
>
> Shannon Nelson updates the ixgbe kernel documentation to include IPsec
> hardware offload.
>
> Joe Perches cleans up whitespace issues in the igb
From: Eric Dumazet
Date: Wed, 21 Nov 2018 11:39:28 -0800
> We very often have few flows/chains to look at, and we
> might increase GRO_HASH_BUCKETS to 32 or 64 in the future.
>
> Signed-off-by: Eric Dumazet
Applied.
On Fri, Nov 23, 2018 at 11:25 AM David Miller wrote:
> My impression is that patch #2 needs some fixes in order to not
> lose dupacks. So there will be a respin of this.
>
> Thanks.
You are absolutely right, we will submit a v2 next week after TG holidays.
Thanks.
From: Eric Dumazet
Date: Wed, 21 Nov 2018 09:52:37 -0800
> While working on the SACK compression issue Jean-Louis Dupond
> reported, we found that his linux box was suffering very hard
> from tail drops on the socket backlog queue, because the opposite
> TCP stack was ont implementing latest RFC
From: Davide Caratti
Date: Wed, 21 Nov 2018 18:23:53 +0100
> commit f2cbd4852820 ("net/sched: act_police: fix race condition on state
> variables") introduces a new spinlock, but forgets its initialization.
> Ensure that tcf_police_init() initializes 'tcfp_lock' every time a 'police'
> action is
From: Paolo Abeni
Date: Wed, 21 Nov 2018 18:21:35 +0100
> Eric noted that with UDP GRO and NAPI timeout, we could keep a single
> UDP packet inside the GRO hash forever, if the related NAPI instance
> calls napi_gro_complete() at an higher frequency than the NAPI timeout.
> Willem noted that
From: Hangbin Liu
Date: Wed, 21 Nov 2018 21:52:33 +0800
> When we add a new IPv6 address, we should also join corresponding
> solicited-node
> multicast address, unless the interface has IFF_NOARP flag, as function
> addrconf_join_solict() did. But if we remove IFF_NOARP flag later, we do
> not
From: Willem de Bruijn
Date: Tue, 20 Nov 2018 13:00:18 -0500
> From: Willem de Bruijn
>
> tpacket_snd sends packets with user pages linked into skb frags. It
> notifies that pages can be reused when the skb is released by setting
> skb->destructor to tpacket_destruct_skb.
>
> This can cause
From: Felix Jia
Date: Tue, 20 Nov 2018 14:53:24 +1300
> +struct ip6_tnl_rule {
> + u8 version;
> + struct in6_addr ipv6_subnet;
> + u8 ipv6_prefixlen;
> + struct in_addr ipv4_subnet;
> + u8 ipv4_prefixlen;
> + u8 ea_length;
> + u8 psid_offset;
Please arrange the
On Wed, Nov 21, 2018 at 02:22:14PM -0800, Alexei Starovoitov wrote:
> On 11/21/18 12:18 PM, Yonghong Song wrote:
> >
> >
> > On 11/21/18 9:40 AM, Andrey Ignatov wrote:
> >> More and more projects use libbpf and one day it'll likely be packaged
> >> and distributed as DSO and that requires ABI
After switching the r8169 driver to use phylib some user reported that
their network is broken. This was caused by the genphy PHY driver being
used instead of the dedicated PHY driver for the RTL8211B. Users
reported that loading the Realtek PHY driver module upfront fixes the
issue. See also this
On Fri, Nov 23, 2018 at 03:46:50PM -0200, Fabio Estevam wrote:
> The correct form is "can be probed", so fix the typo.
>
> Signed-off-by: Fabio Estevam
Reviewed-by: Andrew Lunn
Andrew
The correct form is "can be probed", so fix the typo.
Signed-off-by: Fabio Estevam
---
Documentation/devicetree/bindings/net/dsa/dsa.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/net/dsa/dsa.txt
Reset snd_queue tso_hdrs pointer to NULL in nicvf_free_snd_queue routine
since it is used to check if tso dma descriptor queue has been previously
allocated. The issue can be triggered with the following reproducer:
$ip link set dev enP2p1s0v0 xdpdrv obj xdp_dummy.o
$ip link set dev enP2p1s0v0
Could be a bug, or just how it works?
Begin forwarded message:
Date: Thu, 22 Nov 2018 22:51:12 +
From: bugzilla-dae...@bugzilla.kernel.org
To: step...@networkplumber.org
Subject: [Bug 201773] New: IP_FREEBIND doesn’t counteract global
https://bugzilla.kernel.org/show_bug.cgi?id=201773
Send frames back on the same port for XDP_TX action.
Since the frame buffers have been allocated by us, we can recycle
them directly into the Rx buffer pool instead of requesting a
confirmation frame upon transmission complete.
Signed-off-by: Ioana Radulescu
---
Add support for XDP programs. Only XDP_PASS, XDP_DROP and XDP_TX
actions are supported for now. Frame header changes are also
allowed.
Ioana Radulescu (8):
dpaa2-eth: Add basic XDP support
dpaa2-eth: Allow XDP header adjustments
dpaa2-eth: Move function
dpaa2-eth: Release buffers back to
We keep one XDP program reference per channel. The only actions
supported for now are XDP_DROP and XDP_PASS.
Until now we didn't enforce a maximum size for Rx frames based
on MTU value. Change that, since for XDP mode we must ensure no
scatter-gather frames can be received.
Signed-off-by: Ioana
Remove one unused counter. Move the Tx portal busy counter to
the channel stats, since it logically belongs here.
Reorder fields in channel stats structure to match the ethtool
strings order and make it easier to print them with ethtool -S.
Signed-off-by: Ioana Radulescu
---
In order to support enqueueing Rx FDs back to hardware, we need to
DMA map Rx buffers as bidirectional.
Signed-off-by: Ioana Radulescu
---
drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git
Instead of freeing the RX buffers, release them back into the pool.
We wait for the maximum number of buffers supported by a single
release command to accumulate before issuing the command.
Also, don't unmap the Rx buffers at the beginning of the Rx routine
anymore, since that would require
Add counters for xdp processed frames to the channel statistics.
Signed-off-by: Ioana Radulescu
---
drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c | 7 ++-
drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.h | 4
drivers/net/ethernet/freescale/dpaa2/dpaa2-ethtool.c | 3 +++
3
We'll use function free_bufs() on the XDP path as well, so move
it higher in order to avoid a forward declaration.
Signed-off-by: Ioana Radulescu
---
drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c | 34
1 file changed, 17 insertions(+), 17 deletions(-)
diff --git
Reserve XDP_PACKET_HEADROOM bytes in Rx buffers to allow XDP
programs to increase frame header size.
Signed-off-by: Ioana Radulescu
---
drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c | 43 ++--
1 file changed, 40 insertions(+), 3 deletions(-)
diff --git
A format string consisting of "%p" or "%s" followed by an invalid
specifier (e.g. "%p%\n" or "%s%") could pass the check which
would make format_decode (lib/vsprintf.c) to warn.
Reported-by: syzbot+1ec5c5ec949c4adaa...@syzkaller.appspotmail.com
Signed-off-by: Martynas Pumputis
---
Hi all,
Running Kernel 4.19.x on Xen in machines using intel ixgbe driver the driver
crashes on startup with the kernel trace below.
It appears that the loop on line 2432 of net/core/dev.c iterates beyond the end
of the dev_maps->attr_map array, resulting in dereferencing garbage. A
On 10/12/18 6:25 AM, shubhrajyoti.da...@gmail.com wrote:
> From: Shubhrajyoti Datta
>
> Add support for can 2.0.
>
> Signed-off-by: Shubhrajyoti Datta
Added to linux-can-next.
Tnx,
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions|
On 22/11/18 20:59, David Calavera wrote:
> I noticed that these two new BPF Maps are not defined in bpftool.
> This patch defines those two maps and adds their names to the
> bpftool-map documentation.
>
> Signed-off-by: David Calavera
> ---
Subject line says 'QUEUE' twice, should one of those be
2018-11-21 09:28 UTC-0800 ~ Stanislav Fomichev
On 11/21, Quentin Monnet wrote:
2018-11-20 15:26 UTC-0800 ~ Stanislav Fomichev
On 11/20, Alexei Starovoitov wrote:
On Wed, Nov 21, 2018 at 12:18:57AM +0100, Daniel Borkmann wrote:
On 11/21/2018 12:04 AM, Alexei Starovoitov wrote:
On Tue, Nov
On 2018/11/23 5:52, Daniel Borkmann wrote:
> [ +Wang ]
>
> On 11/22/2018 07:03 AM, Nikita V. Shirokov wrote:
>> currently by default libbpf's bpf_object__open requires
>> bpf's program to specify version in a code because of two things:
>> 1) default prog type is set to KPROBE
>> 2) KPROBE
64 matches
Mail list logo
