[2.6 patch] forgotten bits of Sangoma drivers removal

Robert P. J. Day spotted that my removal of the Sangoma drivers missed a few bits. Signed-off-by: Adrian Bunk [EMAIL PROTECTED] --- Documentation/networking/00-INDEX |2 Documentation/networking/wan-router.txt | 621 include/linux/Kbuild

[2.6 patch] unexport ip6_find_1stfragopt

This patch removes the no longer used EXPORT_SYMBOL_GPL(ip6_find_1stfragopt). Signed-off-by: Adrian Bunk [EMAIL PROTECTED] --- This patch has been sent on: - 30 Jan 2008 961bcbf7370019e35920a75d2d34c91b71708dfe diff --git a/net/ipv6/ip6_output.c b/net/ipv6/ip6_output.c index 15c4f6c..ca707c0

[2.6.25 patch] fix broken error handling in ieee80211_sta_process_addba_request()

The Coverity checker spotted this buggy error handling added by commit 07db218396650933abff3c5c1ad1e2a6e0cfedeb. Signed-off-by: Adrian Bunk [EMAIL PROTECTED] --- 6003e3d899a8fd6425ff509363b776f8807df25d diff --git a/net/mac80211/ieee80211_sta.c b/net/mac80211/ieee80211_sta.c index 2019b4f

[RFC: 2.6.25 patch] ipv4/fib_hash.c: fix NULL dereference

Unless I miss a guaranteed relation between between f and new_fa-fa_info this patch is required for fixing a NULL dereference introduced by commit a6501e080c318f8d4467679d17807f42b3a33cd5 and spotted by the Coverity checker. Signed-off-by: Adrian Bunk [EMAIL PROTECTED] --- net/ipv4

[2.6 patch] net/phy/mdio_bus.c: fix a check-after-use

This patch fixes a check-after-use spotted by the Coverity checker. Signed-off-by: Adrian Bunk [EMAIL PROTECTED] --- 6beeb3ac577d74d72b2f91bd654eecb904c3c17e diff --git a/drivers/net/phy/mdio_bus.c b/drivers/net/phy/mdio_bus.c index 6e9f619..963630c 100644 --- a/drivers/net/phy/mdio_bus.c +++ b

[2.6 patch] remove include/linux/netfilter_ipv4/ipt_SAME.h

This patch removes the no longer used include/linux/netfilter_ipv4/ipt_SAME.h Signed-off-by: Adrian Bunk [EMAIL PROTECTED] --- include/linux/netfilter_ipv4/Kbuild |1 - include/linux/netfilter_ipv4/ipt_SAME.h | 19 --- 2 files changed, 20 deletions

[2.6 patch] unexport __inet_hash_connect

This patch removes the unused EXPORT_SYMBOL_GPL(__inet_hash_connect). Signed-off-by: Adrian Bunk [EMAIL PROTECTED] --- ffa30930d4ba630514fd93ded245456f05358140 diff --git a/net/ipv4/inet_hashtables.c b/net/ipv4/inet_hashtables.c index 9cac6c0..e6a0072 100644 --- a/net/ipv4/inet_hashtables.c

[2.6 patch] unexport inet_listen_wlock

This patch removes the no linger used EXPORT_SYMBOL(inet_listen_wlock). Signed-off-by: Adrian Bunk [EMAIL PROTECTED] --- 08c580a0a3219ce72f5c534c8868e75c4c224e01 diff --git a/net/ipv4/inet_hashtables.c b/net/ipv4/inet_hashtables.c index e6a0072..1aba606 100644 --- a/net/ipv4/inet_hashtables.c

[2.6 patch] make s2io.c:init_tti() static

This patch makes the needlessly global init_tti() static. Signed-off-by: Adrian Bunk [EMAIL PROTECTED] --- This patch has been sent on: - 30 Jan 2008 1e8c2b07be955b181814e4c24366517a66557908 diff --git a/drivers/net/s2io.c b/drivers/net/s2io.c index 5fab7d7..bc94e84 100644 --- a/drivers/net

[2.6 patch] net/phy/fixed.c: fix a use-after-free

This patch fixes a use-after-free introduced by commit a79d8e93d300adb8438ac396cfb118c238ad and spotted by the Coverity checker. Signed-off-by: Adrian Bunk [EMAIL PROTECTED] --- 20c51455b2faed63c3026fd4d7139e5a6a917d31 diff --git a/drivers/net/phy/fixed.c b/drivers/net/phy/fixed.c index

inet6_hash_connect() no longer uses secure_ipv6_port_ephemeral()

I do not claim to understand this code, but it doesn't seem to be intentional that after commit 5ee31fc1ecdcbc234c8c56dcacef87c8e09909d8 inet6_hash_connect() now uses secure_ipv4_port_ephemeral() instead of secure_ipv6_port_ephemeral() (inet6_sk_port_offset() is no longer used and

[2.6 patch] xfrm4_beet_input(): fix an if()

A bug every C programmer makes at some point in time... Signed-off-by: Adrian Bunk [EMAIL PROTECTED] --- 3125760a05c6e97097882a810dc1c5342296aae9 diff --git a/net/ipv4/xfrm4_mode_beet.c b/net/ipv4/xfrm4_mode_beet.c index e093a7b..b47030b 100644 --- a/net/ipv4/xfrm4_mode_beet.c +++ b/net/ipv4

[2.6 patch] rtnetlink.c: remove no longer used functions

On Wed, Jan 30, 2008 at 09:04:33PM +0100, Patrick McHardy wrote: Adrian Bunk wrote: This patch #if 0's the following no longer used functions: - rtattr_parse() - rtattr_strlcpy() - __rtattr_parse_nested_compat() Please remove them instead. Updated patch below. cu Adrian -- snip

[2.6 patch] remove obsolete tokenring maintainer information

- Peter's email address is bouncing - the project webpage no longer exists - neither Peter nor Mike had a single patch included in the kernel since 2.6.12-rc2 (when the git history begins) Signed-off-by: Adrian Bunk [EMAIL PROTECTED] --- MAINTAINERS | 23 --- 1 file

Strange commit 42a73808ed4f30b739eb52bcbb33a02fe62ceef5

Commit 42a73808ed4f30b739eb52bcbb33a02fe62ceef5 ([RAW]: Consolidate proc interface.) did not only change raw6_seq_ops (including adding 3 EXPORT_SYMBOL_GPL's to net/ipv4/raw.c for accessing functions from there), it also removed the only user of raw6_seq_ops... cu Adrian -- Is there

[2.6 patch] via-rhine.c:rhine_hw_init() must be __devinit

Thie patch fixes the following section mismatch: -- snip -- ... WARNING: drivers/net/built-in.o(.text+0xdd840): Section mismatch in reference from the function rhine_hw_init() to the function .devinit.text:rhine_reload_eeprom() ... -- snip -- Signed-off-by: Adrian Bunk [EMAIL PROTECTED

[2.6 patch] olympic_open() must be __devinit

This patch fixes the following section mismatch: -- snip -- ... WARNING: drivers/net/built-in.o(.text+0x155573): Section mismatch in reference from the function olympic_open() to the function .devinit.text:olympic_init() ... -- snip -- Signed-off-by: Adrian Bunk [EMAIL PROTECTED

[2.6 patch] ibmlana_adapter_names[] must be __devinitdata

This patch fixes the following section mismatch: -- snip -- ... WARNING: drivers/net/built-in.o(.devinit.text+0x1baa4): Section mismatch in reference from the function ibmlana_init_one() to the variable .init.data:ibmlana_adapter_names ... -- snip -- Signed-off-by: Adrian Bunk [EMAIL

[2.6 patch] ibmlana_init_one() must be __devinit

This patch fixes the following section mismatch: -- snip -- ... WARNING: drivers/net/built-in.o(.text+0x1148a5): Section mismatch in reference from the function ibmlana_init_one() to the variable .init.data:ibmlana_adapter_names ... -- snip -- Signed-off-by: Adrian Bunk [EMAIL PROTECTED

[2.6 patch] net/xfrm/: remove unused exports

This patch removes the following no longer used EXPORT_SYMBOL's: - xfrm_input.c: xfrm_parse_spi - xfrm_state.c: xfrm_replay_check - xfrm_state.c: xfrm_replay_advance Signed-off-by: Adrian Bunk [EMAIL PROTECTED] --- net/xfrm/xfrm_input.c |1 - net/xfrm/xfrm_state.c |2 -- 2 files

[2.6 patch] unexport sysctl_tcp_tso_win_divisor

This patch removes the no longer used EXPORT_SYMBOL(sysctl_tcp_tso_win_divisor). Signed-off-by: Adrian Bunk [EMAIL PROTECTED] --- 4884e7997ba5f63f2efeaeead21ed2768fb3f4de diff --git a/net/ipv4/tcp_output.c b/net/ipv4/tcp_output.c index 89f0188..ed750f9 100644 --- a/net/ipv4/tcp_output.c +++ b

[2.6 patch] unexport ip6_find_1stfragopt

This patch removes the no longer used EXPORT_SYMBOL_GPL(ip6_find_1stfragopt). Signed-off-by: Adrian Bunk [EMAIL PROTECTED] --- 961bcbf7370019e35920a75d2d34c91b71708dfe diff --git a/net/ipv6/ip6_output.c b/net/ipv6/ip6_output.c index 15c4f6c..ca707c0 100644 --- a/net/ipv6/ip6_output.c +++ b/net

[2.6 patch] IBMLANA no longer has to depend on MCA_LEGACY

This patch removes the no longer required dependency of IBMLANA on MCA_LEGACY. Signed-off-by: Adrian Bunk [EMAIL PROTECTED] --- d83989118e59f403200ea9c71d2293337b49df01 diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig index af40ff4..578ae2c 100644 --- a/drivers/net/Kconfig +++ b/drivers

[2.6 patch] e1000e/ethtool.c: make a function static

This patch makes the needlessly global reg_pattern_test_array() static. Signed-off-by: Adrian Bunk [EMAIL PROTECTED] --- ed72e457f06311390d9a9e51a00c904939466aff diff --git a/drivers/net/e1000e/ethtool.c b/drivers/net/e1000e/ethtool.c index 6d9c27f..a2034cf 100644 --- a/drivers/net/e1000e

[2.6 patch] make struct ipv4_devconf static

struct ipv4_devconf can now become static. Signed-off-by: Adrian Bunk [EMAIL PROTECTED] --- include/linux/inetdevice.h |2 -- net/ipv4/devinet.c |2 +- 2 files changed, 1 insertion(+), 3 deletions(-) 20262a3317069b1bdbf2b37f4002fa5322445914 diff --git a/include/linux

[2.6 patch] make nf_ct_path[] static

This patch makes the needlessly global nf_ct_path[] static. Signed-off-by: Adrian Bunk [EMAIL PROTECTED] --- 6396fbcebe3eb61f7e6eb1a671920a515912b005 diff --git a/net/netfilter/nf_conntrack_standalone.c b/net/netfilter/nf_conntrack_standalone.c index 696074a..5bd38a6 100644 --- a/net/netfilter

[2.6 patch] rtnetlink.c: #if 0 no longer used functions

This patch #if 0's the following no longer used functions: - rtattr_parse() - rtattr_strlcpy() - __rtattr_parse_nested_compat() Signed-off-by: Adrian Bunk [EMAIL PROTECTED] --- include/linux/rtnetlink.h | 12 net/core/rtnetlink.c |9 ++--- 2 files changed, 6

[2.6 patch] make net/802/tr.c:sysctl_tr_rif_timeout static

sysctl_tr_rif_timeout can now become static. Signed-off-by: Adrian Bunk [EMAIL PROTECTED] --- e5accd81b924224d40a3f38204c08cf6896ed79b diff --git a/net/802/tr.c b/net/802/tr.c index 3f16b17..18c6647 100644 --- a/net/802/tr.c +++ b/net/802/tr.c @@ -76,7 +76,7 @@ static DEFINE_SPINLOCK(rif_lock

[2.6 patch] make e1000_dump_eeprom() static

This patch makes the needlessly global e1000_dump_eeprom() static. Signed-off-by: Adrian Bunk [EMAIL PROTECTED] --- b5fd924a1388d4aaa94cf05e42e317c2b1fb5748 diff --git a/drivers/net/e1000/e1000_main.c b/drivers/net/e1000/e1000_main.c index 7f5b2ae..8a6645b 100644 --- a/drivers/net/e1000

[2.6 patch] net/sunqe.c section fix

This patch fixes the following section mismatch: -- snip -- ... WARNING: drivers/net/sunqe.o(.devinit.text+0x4): Section mismatch in reference from the function qec_sbus_probe() to the function .init.text:qec_ether_init() ... -- snip -- Signed-off-by: Adrian Bunk [EMAIL PROTECTED

[2.6 patch] net/sunbmac.c section fix

This patch fixes the following section mismatch: -- snip -- ... WARNING: drivers/net/sunbmac.o(.devinit.text+0x24): Section mismatch in reference from the function bigmac_sbus_probe() to the function .init.text:bigmac_ether_init() ... -- snip -- Signed-off-by: Adrian Bunk [EMAIL

[2.6 patch] drivers/net/sunvnet.c:print_version() must be __devinit

the function print_version() to the variable .devinit.data:version ... -- snip -- Signed-off-by: Adrian Bunk [EMAIL PROTECTED] --- f865222179806c4475cd79c2fb92ec622f88da3f diff --git a/drivers/net/sunvnet.c b/drivers/net/sunvnet.c index 4a0035f..6415ce1 100644 --- a/drivers/net/sunvnet.c

[2.6 patch] make s2io.c:init_tti() static

This patch makes the needlessly global init_tti() static. Signed-off-by: Adrian Bunk [EMAIL PROTECTED] --- 1e8c2b07be955b181814e4c24366517a66557908 diff --git a/drivers/net/s2io.c b/drivers/net/s2io.c index 5fab7d7..bc94e84 100644 --- a/drivers/net/s2io.c +++ b/drivers/net/s2io.c @@ -1088,7

Re: Mostly revert e1000/e1000e: Move PCI-Express device IDs over to e1000e

On Wed, Jan 30, 2008 at 04:51:04PM +1100, Linus Torvalds wrote: On Tue, 29 Jan 2008, Randy Dunlap wrote: Andrew was concerned about this when the driver was in -mm. He asked for a patch that would set E1000E to same value as E1000 and I supplied that. Auke acked it IIRC. Other

[2.6 patch] security/selinux/netlabel.c: fix double free

This patch fixes a double free (security_netlbl_sid_to_secattr() already calls netlbl_secattr_destroy() when it returns !0) introduced by commit 45c950e0f839fded922ebc0bfd59b1081cc71b70 and spotted by the Coverity checker. Signed-off-by: Adrian Bunk [EMAIL PROTECTED] --- --- linux-2.6/security

[2.6 patch] remove the obsolete xircom_tulip_cb driver

The xircom_tulip_cb driver has been replaced the xircom_cb driver, and since it depended on BROKEN_ON_SMP it e.g. was no longer present in many distribution kernels. This patch therefore removes it. Signed-off-by: Adrian Bunk [EMAIL PROTECTED] --- drivers/net/tulip/Kconfig | 15

Re: [2.6 patch] security/selinux/netlabel.c: fix double free

On Mon, Jan 28, 2008 at 05:23:46PM -0500, Paul Moore wrote: On Monday 28 January 2008 5:09:38 pm Adrian Bunk wrote: This patch fixes a double free (security_netlbl_sid_to_secattr() already calls netlbl_secattr_destroy() when it returns !0) introduced by commit

[2.6 patch] atm/idt77105.c: fix section mismatch

EXPORT_SYMBOL'ed code mustn't be __*init. Signed-off-by: Adrian Bunk [EMAIL PROTECTED] --- --- linux-2.6/drivers/atm/idt77105.c.old2008-01-19 11:19:53.0 +0200 +++ linux-2.6/drivers/atm/idt77105.c2008-01-19 11:20:10.0 +0200 @@ -354,13 +354,13 @@ static const struct

[2.6 patch] atm/suni.c: fix section mismatch

EXPORT_SYMBOL'ed code mustn't be __*init. Signed-off-by: Adrian Bunk [EMAIL PROTECTED] --- --- linux-2.6/drivers/atm/suni.c.old2008-01-19 12:16:41.0 +0200 +++ linux-2.6/drivers/atm/suni.c2008-01-19 12:17:23.0 +0200 @@ -275,35 +275,35 @@ static int suni_stop(struct

Re: [BUG] skge 0000:02:05: read data parity error

On Mon, Jan 14, 2008 at 12:52:00PM -0800, Stephen Hemminger wrote: On Mon, 14 Jan 2008 20:57:49 +0100 Oliver Pinter (Pintér Olivér) [EMAIL PROTECTED] wrote: Hi All! It is fully reproductable under 2.6.22.15, 2.6.23.13 (all tainted and not tainted [4 different kernel] ) and 2 different

Re: [BUG] skge 0000:02:05: read data parity error

On Mon, Jan 14, 2008 at 10:31:03PM +0100, Oliver Pinter (Pintér Olivér) wrote: I think, it is a potential security breakpoint, when applications with root permission its read, then a machine is freezed, or only i thin it's? When you are root there are infinite ways to kill your machine, so

Re: [BUG] skge 0000:02:05: read data parity error

On Mon, Jan 14, 2008 at 10:41:52PM +0100, Oliver Pinter (Pintér Olivér) wrote: On 1/14/08, Adrian Bunk [EMAIL PROTECTED] wrote: On Mon, Jan 14, 2008 at 10:31:03PM +0100, Oliver Pinter (Pintér Olivér) wrote: I think, it is a potential security breakpoint, when applications with root

[2.6.24 patch] fix netx-eth.c compilation

This was missed when commit e2ac455a18806b31c2d0da0a51d8740af5010b7a fixed the compile errors in drivers/net/netx-eth.c caused by commit 09f75cd7bf13720738e6a196cc0107ce9a5bd5a0. Signed-off-by: Adrian Bunk [EMAIL PROTECTED] --- 15e5efb728c61333ca10648334185efba86c4815 diff --git a/drivers/net

Re: forcedeth: MAC-address reversed on resume from suspend

[ original bug report: http://lkml.org/lkml/2008/1/2/253 ] On Wed, Jan 02, 2008 at 10:48:43PM +0100, Andreas Mohr wrote: Hi, On Wed, Jan 02, 2008 at 10:04:49PM +0100, Richard Jonsson wrote: Bugreport regarding forcedeth driver. When returning from suspend-to-RAM the MAC-address

[2.6 patch] the scheduled shaper removal

This patch contains the scheduled removal of the shaper driver. Signed-off-by: Adrian Bunk [EMAIL PROTECTED] --- Documentation/feature-removal-schedule.txt |9 Documentation/networking/00-INDEX |2 Documentation/networking/shaper.txt| 48 - drivers/net/Kconfig

Re: [PATCH] MAINTAINERS: remove Adam Fritzler, update his email address in other sources

On Mon, Dec 17, 2007 at 08:28:00PM -0800, Andrew Morton wrote: ... I'd suggest that you find out if Adrian is still running the trivial tree and if so, patchbomb him. I do. Simply Cc [EMAIL PROTECTED] for trivial patches and they might magically appear in Linus' tree during the next merge

Re: [patch 01/10] e1000e: make E1000E default to the same kconfig setting as E1000

On Fri, Dec 14, 2007 at 03:39:26PM -0500, Jeff Garzik wrote: [EMAIL PROTECTED] wrote: From: Randy Dunlap [EMAIL PROTECTED] ... So I think the breakage that occurs is mitigated by two factors: 1) kernel hackers that do their own configs are expected to be able to figure this stuff. 2) kernel

Re: [patch 01/10] e1000e: make E1000E default to the same kconfig setting as E1000

On Fri, Dec 14, 2007 at 06:17:55PM -0500, Jeff Garzik wrote: Adrian Bunk wrote: On Fri, Dec 14, 2007 at 03:39:26PM -0500, Jeff Garzik wrote: [EMAIL PROTECTED] wrote: From: Randy Dunlap [EMAIL PROTECTED] ... So I think the breakage that occurs is mitigated by two factors: 1) kernel hackers

Re: 2.6.24-rc5-mm1

On Thu, Dec 13, 2007 at 05:07:44PM +0100, Borislav Petkov wrote: On Thu, Dec 13, 2007 at 04:01:34PM +0100, Benjamin Thery wrote: The problem comes from the new macro UDPX_INC_STATS_BH introduced by Herbert, which was a nice addition to increment the correct UDP MIB depending on the socket

[2.6 patch] drivers/net/ipg.c: add __devexit annotation

ipg_remove() can become __devexit. Signed-off-by: Adrian Bunk [EMAIL PROTECTED] --- 97ace7a0e52ceac30caae20e1a3fe72c4644bce7 diff --git a/drivers/net/ipg.c b/drivers/net/ipg.c index dbd23bb..285ebbc 100644 --- a/drivers/net/ipg.c +++ b/drivers/net/ipg.c @@ -2214,7 +2214,7 @@ static struct

[2.6 patch] drivers/net/s2io.c section fixes

') ... -- snip -- Signed-off-by: Adrian Bunk [EMAIL PROTECTED] --- drivers/net/s2io.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) 50fb761b99d7ee0b234359d02144f84a87e2faff diff --git a/drivers/net/s2io.c b/drivers/net/s2io.c index 121cb10..9d80f1c 100644 --- a/drivers/net

[2.6 patch] drivers/net/sis190.c section fix

This patch fixes the following section mismatch with CONFIG_HOTPLUG=n: -- snip -- ... WARNING: vmlinux.o(.init.text.20+0x4cb25): Section mismatch: reference to .exit.text:sis190_mii_remove (between 'sis190_init_one' and 'read_eeprom') ... -- snip -- Signed-off-by: Adrian Bunk [EMAIL

Re: namespace support requires network modules to say GPL

On Sun, Dec 02, 2007 at 09:03:56PM +0100, Patrick McHardy wrote: Ben Greear wrote: Stephen Hemminger wrote: Naw, enterprise (or any other) distro vendors shouldn't have any issues here, since they can just patch their kernels around any issues. But it looks like Eric has this one thought

Re: namespace support requires network modules to say GPL

On Sun, Dec 02, 2007 at 10:59:46PM +0100, Patrick McHardy wrote: Adrian Bunk wrote: On Sun, Dec 02, 2007 at 09:03:56PM +0100, Patrick McHardy wrote: ... your statement has an interesting implication: Stuff like e.g. the EXPORT_SYMBOL(sk_alloc) predates the EXPORT_SYMBOL_GPL stuff. Who

Re: [PATCH RFC] [1/9] Core module symbol namespaces code and intro.

On Wed, Nov 28, 2007 at 12:06:45AM +0100, Andi Kleen wrote: On Tue, Nov 27, 2007 at 03:00:22PM -0800, Stephen Hemminger wrote: ... of a modular ipv6 is flawed. Modules that cannot be unloaded are still useful. Standard case: Distributions like to offer an option to not use ipv6 because

Re: [PATCH RFC] [1/9] Core module symbol namespaces code and intro.

On Mon, Nov 26, 2007 at 11:35:42PM -0600, Tom Tucker wrote: On Tue, 2007-11-27 at 15:49 +1100, Rusty Russell wrote: ... No. That's the wrong question. What's the real upside? Explicitly documenting what comprises the kernel API (external, supported) and what comprises the kernel

Re: [PATCH RFC] [1/9] Core module symbol namespaces code and intro.

On Tue, Nov 27, 2007 at 10:02:22AM +0100, Andi Kleen wrote: ... That is EXPORT_SYMBOL already. The trouble is just that it covers too much. My patchkit is trying to limit it again for a specific use case -- exporting an internal interface to another module. Or rather a set of modules.

Re: [PATCH RFC] [1/9] Core module symbol namespaces code and intro.

On Tue, Nov 27, 2007 at 11:45:37AM -0600, Tom Tucker wrote: On Tue, 2007-11-27 at 18:15 +0100, Adrian Bunk wrote: On Mon, Nov 26, 2007 at 11:35:42PM -0600, Tom Tucker wrote: On Tue, 2007-11-27 at 15:49 +1100, Rusty Russell wrote: ... No. That's the wrong question. What's the real

Re: [PATCH RFC] [1/9] Core module symbol namespaces code and intro.

On Tue, Nov 27, 2007 at 02:00:37PM -0500, Dave Jones wrote: On Mon, Nov 26, 2007 at 10:25:33AM -0800, Stephen Hemminger wrote: 1) Why is everyone so concerned that export symbol space is large? - does it cost cpu or running memory? - does it cause bugs? - or are you just

Re: [PATCH RFC] [1/9] Core module symbol namespaces code and intro.

On Tue, Nov 27, 2007 at 01:15:23PM -0800, Rick Jones wrote: The real problem is that these drivers are not in the upstream kernel. Are there common reasons why these drivers are not upstream? One might be that upstream has not accepted them. Anything doing or smelling of TOE comes to mind

Re: [2.6 patch] ipv4/arp.c:arp_process(): remove bogus #ifdef mess

On Mon, Nov 26, 2007 at 11:19:26PM +0800, Herbert Xu wrote: On Sun, Nov 25, 2007 at 04:30:03PM +, Adrian Bunk wrote: Please look at net/ipv4/arp.c:arp_process() Am I right that CONFIG_NET_ETHERNET=n and CONFIG_NETDEV_1000=y or CONFIG_NETDEV_1=y will not be handled

[2.6 patch] ipv4/arp.c:arp_process(): remove bogus #ifdef mess

On Mon, Nov 19, 2007 at 09:26:39PM -0800, David Miller wrote: From: Adrian Bunk [EMAIL PROTECTED] Date: Thu, 8 Nov 2007 04:30:10 +0100 @davem: Please look at net/ipv4/arp.c:arp_process() Am I right that CONFIG_NET_ETHERNET=n and CONFIG_NETDEV_1000=y or CONFIG_NETDEV_1=y

[2.6 patch] net/core/request_sock.c: remove unused exports

This patch removes the following unused EXPORT_SYMBOL's: - reqsk_queue_alloc - __reqsk_queue_destroy - reqsk_queue_destroy Signed-off-by: Adrian Bunk [EMAIL PROTECTED] --- net/core/request_sock.c |5 - 1 file changed, 5 deletions(-) 3761f092ccd5d87a1517b55e2001ac9ef189b901 diff --git

Re: [BUG] New Kernel Bugs

On Tue, Nov 13, 2007 at 07:57:54AM -0800, Ray Lee wrote: On Nov 13, 2007 7:24 AM, Giacomo A. Catenazzi [EMAIL PROTECTED] wrote: As a long time kernel tester, I see some problem with the newer new development model. In the short merge windows, after to much time, there are to many patches.

Re: [BUG] New Kernel Bugs

On Tue, Nov 13, 2007 at 12:13:56PM -0500, Theodore Tso wrote: On Tue, Nov 13, 2007 at 04:52:32PM +0100, Benoit Boissinot wrote: Btw, I used to test every -mm kernel. But since I've switched distros (gentoo-ubuntu) and I have less time, I feel it's harder to test -rc or -mm kernels (I know

Re: [BUG] New Kernel Bugs

On Tue, Nov 13, 2007 at 12:50:08PM -0500, Mark Lord wrote: Ingo Molnar wrote: for example git-bisect was godsent. I remember that years ago bisection of a bug was a very laborous task so that it was only used as a final, last-ditch approach for really nasty bugs. Today we can autonomouly

Re: [BUG] New Kernel Bugs

On Tue, Nov 13, 2007 at 01:18:43PM -0500, Mark Lord wrote: Adrian Bunk wrote: On Tue, Nov 13, 2007 at 12:50:08PM -0500, Mark Lord wrote: Ingo Molnar wrote: for example git-bisect was godsent. I remember that years ago bisection of a bug was a very laborous task so that it was only used

Re: [BUG] New Kernel Bugs

On Tue, Nov 13, 2007 at 01:47:10PM -0500, Mark Lord wrote: Adrian Bunk wrote: ... I did bisecting myself, and I know that it costs time and work. But the first point is the above one that it makes otherwise nearly undebuggable problems debuggable and fixable. .. Definitely useful

Re: [BUG] New Kernel Bugs

On Tue, Nov 13, 2007 at 02:26:05PM -0500, Mark Lord wrote: Adrian Bunk wrote: On Tue, Nov 13, 2007 at 01:47:10PM -0500, Mark Lord wrote: Adrian Bunk wrote: .. Another point is that it shifts the work from the few experienced developers to the many users. Users (and voluntary testers) we

Re: [BUG] New Kernel Bugs

On Tue, Nov 13, 2007 at 07:46:49PM +, Russell King wrote: On Tue, Nov 13, 2007 at 08:30:35PM +0100, Adrian Bunk wrote: There is this silly limit that noone can work more than 168 hours per week on the Linux kernel, and some kernel developers seem to take the liberty of spending even

Re: [BUG] New Kernel Bugs

On Tue, Nov 13, 2007 at 07:32:19PM +, Russell King wrote: ... There's another issue I want to raise concerning bugzilla. We have the classic case of not enough people reading bugzilla bugs - which is one of the biggest problems with bugzilla. Virtually no one in the ARM community looks

Re: [BUG] New Kernel Bugs

On Tue, Nov 13, 2007 at 03:13:46PM -0500, Mark Lord wrote: Adrian Bunk wrote: On Tue, Nov 13, 2007 at 02:26:05PM -0500, Mark Lord wrote: .. If you've been making significant updates to a driver/subsystem, and people are reporting that it is now broken for them, What are significant updates

Re: [BUG] New Kernel Bugs

On Tue, Nov 13, 2007 at 05:39:45PM -0700, Denys Vlasenko wrote: On Tuesday 13 November 2007 10:56, Adrian Bunk wrote: On Tue, Nov 13, 2007 at 12:13:56PM -0500, Theodore Tso wrote: On Tue, Nov 13, 2007 at 04:52:32PM +0100, Benoit Boissinot wrote: Btw, I used to test every -mm kernel

drivers/net/ax88796.c compile error on sh64

Commit 8687991a734a67f1638782c968f46fff0f94bb1f causes the following compile error on sh64: -- snip -- ... CC [M] drivers/net/ax88796.o /home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/net/ax88796.c: In function 'ax_get_8390_hdr':

Re: [2.6 patch] net/ipv4/ipvs/: remove unused exports

On Sun, Nov 11, 2007 at 04:09:40PM +0900, Simon Horman wrote: On Sun, Nov 11, 2007 at 07:48:40AM +0100, Adrian Bunk wrote: This patch removes the following unused EXPORT_SYMBOL's: - ip_vs_try_bind_dest - ip_vs_find_dest Signed-off-by: Adrian Bunk [EMAIL PROTECTED] Looks fine to me

[2.6 patch] unexport sysctl_{r,w}mem_max

sysctl_{r,w}mem_max can now be unexported. Signed-off-by: Adrian Bunk [EMAIL PROTECTED] --- d49d51e5f46615c30e0f96c5333733e0ab1c85e6 diff --git a/net/core/sock.c b/net/core/sock.c index 8fc2f84..c519b43 100644 --- a/net/core/sock.c +++ b/net/core/sock.c @@ -2097,7 +2097,3 @@ EXPORT_SYMBOL

[2.6 patch] net/ipv4/ipvs/: remove unused exports

This patch removes the following unused EXPORT_SYMBOL's: - ip_vs_try_bind_dest - ip_vs_find_dest Signed-off-by: Adrian Bunk [EMAIL PROTECTED] --- net/ipv4/ipvs/ip_vs_conn.c |1 - net/ipv4/ipvs/ip_vs_ctl.c |1 - 2 files changed, 2 deletions(-) ad9f400d4f66ea3423f97e609d6ef2572055c603

[2.6 patch] remove references to net-modules.txt

When I removed net-modules.txt because it only contained ancient information I missed that many Kconfig entries pointed to this ancient information. Signed-off-by: Adrian Bunk [EMAIL PROTECTED] --- Documentation/networking/3c505.txt |3 drivers/net/Kconfig| 199

Re: build #337 failed for 2.6.24-rc1-gb1d08ac In function `usbnet_set_settings':

On Wed, Nov 07, 2007 at 11:52:32PM +0100, Adrian Bunk wrote: On Wed, Nov 07, 2007 at 02:34:52PM -0800, David Brownell wrote: But on the other hand, it seems that only the ASIX code will work right; the DM9601 and MCS7830 Kconfig is different/wrong. I'm not seeing the problem

Re: build #337 failed for 2.6.24-rc1-gb1d08ac In function `usbnet_set_settings':

On Wed, Nov 07, 2007 at 06:53:48PM -0800, David Brownell wrote: On Wednesday 07 November 2007, Adrian Bunk wrote: On Wed, Nov 07, 2007 at 02:34:52PM -0800, David Brownell wrote: But on the other hand, it seems that only the ASIX code will work right; the DM9601 and MCS7830 Kconfig

Re: build #337 failed for 2.6.24-rc1-gb1d08ac In function `usbnet_set_settings':

On Wed, Nov 07, 2007 at 02:34:52PM -0800, David Brownell wrote: But on the other hand, it seems that only the ASIX code will work right; the DM9601 and MCS7830 Kconfig is different/wrong. I'm not seeing the problem. Which configuration will be handled wrongly? Notice how only

Re: [2.6 patch] remove Documentation/networking/net-modules.txt

On Mon, Oct 29, 2007 at 05:18:14PM +0200, Pekka Pietikainen wrote: On Wed, Oct 24, 2007 at 06:25:03PM +0200, Adrian Bunk wrote: According to git, the only one who touched this file during the last 5 years was me when removing drivers... That's not the only obsolete thing there: ncsa

[2.6 patch] remove comx driver docs

The drivers have already been removed 3.5 years ago. Signed-off-by: Adrian Bunk [EMAIL PROTECTED] --- Documentation/networking/00-INDEX |2 Documentation/networking/comx.txt | 248 - Documentation/networking/slicecom.hun | 371

[2.6 patch] remove Documentation/networking/Configurable

After more than 11 years this file does no longer contain much useful information. Signed-off-by: Adrian Bunk [EMAIL PROTECTED] --- Documentation/networking/00-INDEX |2 - Documentation/networking/Configurable | 34 -- 2 files changed, 36 deletions

[2.6 patch] remove Documentation/networking/ncsa-telnet

Newsflash: There once was a version of NCSA telnet that had some bug. Spotted by Pekka Pietikainen. Signed-off-by: Adrian Bunk [EMAIL PROTECTED] --- Documentation/networking/00-INDEX|2 -- Documentation/networking/ncsa-telnet | 16 2 files changed, 18 deletions

[2.6 patch] remove Documentation/networking/routing.txt

This file is so outdated that I can't see any value in keeping it. Signed-off-by: Adrian Bunk [EMAIL PROTECTED] --- Documentation/networking/00-INDEX|2 - Documentation/networking/routing.txt | 46 --- 2 files changed, 48 deletions

[2.6 patch] remove Documentation/networking/pt.txt

There's no no point in keeping documentation for a driver that was removed many years ago. Signed-off-by: Adrian Bunk [EMAIL PROTECTED] --- Documentation/networking/00-INDEX |2 - Documentation/networking/pt.txt | 58 -- 2 files changed, 60 deletions

[2.6 patch] drivers/net/netxen/: cleanups

This patch contains the following cleanups: - static functions in .c files shouldn't be marked inline - make needlessly global code static - #if 0 unused code Signed-off-by: Adrian Bunk [EMAIL PROTECTED] --- drivers/net/netxen/netxen_nic.h | 14 drivers/net/netxen

[2.6 patch] usbnet.c: check for the right MII variable

On Thu, Nov 01, 2007 at 04:52:39PM -0700, David Brownell wrote: On Thursday 01 November 2007, Adrian Bunk wrote: All this USB_USBNET_MII trickery is simply not worth it considering how few code it saves. Depends on what systems you're talking about. Forcing unused code into the kernel

[2.6 patch] drivers/net/chelsio/: #if 0 unused functions

This patch #if 0's the following unused functions: - espi.c:t1_espi_set_misc_ctrl() - sge.c:t1_sched_set_max_avail_bytes() - sge.c:t1_sched_set_drain_bits_per_us() Signed-off-by: Adrian Bunk [EMAIL PROTECTED] --- drivers/net/chelsio/espi.c |2 ++ drivers/net/chelsio/espi.h |1

Re: build #337 failed for 2.6.24-rc1-gb1d08ac In function `usbnet_set_settings':

On Fri, Nov 02, 2007 at 11:45:15AM -0700, David Brownell wrote: On Thursday 01 November 2007, Adrian Bunk wrote: The following combination of options is simply an unusual one: CONFIG_MII=m CONFIG_USB_USBNET=y CONFIG_USB_USBNET_MII=n I though that had been fixed for ages

Re: build #337 failed for 2.6.24-rc1-gb1d08ac In function `usbnet_set_settings':

On Fri, Nov 02, 2007 at 12:30:22PM -0700, David Brownell wrote: On Friday 02 November 2007, Adrian Bunk wrote: This approach has two disadvantages: - it's complicated No more so than the problem itself. - the MII stuff is an implementation detail, and we shouldn't bother   the user

Re: build #337 failed for 2.6.24-rc1-gb1d08ac In function `usbnet_set_settings':

On Fri, Nov 02, 2007 at 11:45:15AM -0700, David Brownell wrote: ... --- a.orig/drivers/net/usb/usbnet.c 2007-10-13 15:16:10.0 -0700 +++ a/drivers/net/usb/usbnet.c2007-11-02 11:39:59.0 -0700 @@ -682,10 +682,17 @@ done_nopm: /* ethtool methods; minidrivers may need to

[2.6 patch] let USB_USBNET always select MII

`usbnet_nway_reset': (.text+0xf18f6): undefined reference to `mii_nway_restart' make: *** [.tmp_vmlinux1] Error 1 -- snip -- Signed-off-by: Adrian Bunk [EMAIL PROTECTED] --- drivers/net/usb/Kconfig |9 + drivers/net/usb/usbnet.c |7 --- 2 files changed, 1 insertion(+), 15

Re: build #337 failed for 2.6.24-rc1-gb1d08ac In function `usbnet_set_settings':

On Thu, Nov 01, 2007 at 04:32:18PM -0700, David Brownell wrote: On Thursday 01 November 2007, Randy Dunlap wrote: The MII functions aren't available unless NET_ETHERNET=y. The setting of CONFIG_NET_ETHERNET doesn't matter for this bug. Howver, the MII functions aren't always needed...

[2.6 patch] fix drivers/net/wan/lmc/ compilation

expression before ‘else’ ... make[5]: *** [drivers/net/wan/lmc/lmc_main.o] Error 1 -- snip -- Signed-off-by: Adrian Bunk [EMAIL PROTECTED] --- d5e92a30491abf073e0a7f4d46b466c7c97f0f61 diff --git a/drivers/net/wan/lmc/lmc_main.c b/drivers/net/wan/lmc/lmc_main.c index 64eb578..37c52e1 100644

[2.6 patch] always export sysctl_{r,w}mem_max

-- Signed-off-by: Adrian Bunk [EMAIL PROTECTED] --- 22ea6cd56e4fa844b0b1bbab2542f09eb6c9a5ab diff --git a/net/core/sock.c b/net/core/sock.c index febbcbc..ee1cc4f 100644 --- a/net/core/sock.c +++ b/net/core/sock.c @@ -2004,7 +2004,5 @@ EXPORT_SYMBOL(sock_wmalloc); EXPORT_SYMBOL(sock_i_uid

[2.6 patch] net/ipv{4,6}/esp{4,6}.c must #include linux/scatterlist.h

.o] Error 1 -- snip -- Signed-off-by: Adrian Bunk [EMAIL PROTECTED] --- net/ipv4/esp4.c |2 +- net/ipv6/esp6.c |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) ecf93220d6af83516dbe04dcd09474a0423ce2ef diff --git a/net/ipv4/esp4.c b/net/ipv4/esp4.c index ba98401..23b647c

[2.6 patch] make bonding/bond_main.c:bond_deinit() static

bond_deinit() can now become static. Signed-off-by: Adrian Bunk [EMAIL PROTECTED] --- drivers/net/bonding/bond_main.c |3 ++- drivers/net/bonding/bonding.h |1 - 2 files changed, 2 insertions(+), 2 deletions(-) 5e5d2537b927f55a2199a0d9a073f41bb71290f6 diff --git a/drivers/net

[2.6 patch] drivers/net/ipg.c: cleanups

This patch contains the following cleanups: - make ipg_nic_get_stats() static - move DefaultPhyParam[] from ipg.h to ipg.c and make it static Signed-off-by: Adrian Bunk [EMAIL PROTECTED] --- drivers/net/ipg.c | 22 +- drivers/net/ipg.h | 20 2 files

  1   2   3   4   5   6   >