This patch #if 0's the following unused functions:
- espi.c:t1_espi_set_misc_ctrl()
- sge.c:t1_sched_set_max_avail_bytes()
- sge.c:t1_sched_set_drain_bits_per_us()
Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
---
drivers/net/chelsio/espi.c |2 ++
drivers/net/chelsio/es
On Thu, Nov 01, 2007 at 04:32:18PM -0700, David Brownell wrote:
> On Thursday 01 November 2007, Randy Dunlap wrote:
> > The MII functions aren't available unless NET_ETHERNET=y.
The setting of CONFIG_NET_ETHERNET doesn't matter for this bug.
> > Howver, the MII functions aren't always needed...
>
x27;
drivers/built-in.o: In function `usbnet_nway_reset':
(.text+0xf18f6): undefined reference to `mii_nway_restart'
make: *** [.tmp_vmlinux1] Error 1
<-- snip -->
Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
---
drivers/net/usb/Kconfig |9 +
drivers/net/usb/us
pected expression before ‘else’
...
make[5]: *** [drivers/net/wan/lmc/lmc_main.o] Error 1
<-- snip -->
Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
---
d5e92a30491abf073e0a7f4d46b466c7c97f0f61
diff --git a/drivers/net/wan/lmc/lmc_main.c b/drivers/net/wan/lmc/lmc_main.c
index 64eb5
x27;sg_init_table'
make[3]: *** [net/ipv6/esp6.o] Error 1
<-- snip -->
Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
---
net/ipv4/esp4.c |2 +-
net/ipv6/esp6.c |2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
ecf93220d6af83516dbe04dcd09474a0423ce2ef
di
ed!
make[2]: *** [__modpost] Error 1
<-- snip -->
Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
---
22ea6cd56e4fa844b0b1bbab2542f09eb6c9a5ab
diff --git a/net/core/sock.c b/net/core/sock.c
index febbcbc..ee1cc4f 100644
--- a/net/core/sock.c
+++ b/net/core/sock.c
@@ -2004,7 +2004,
On Wed, Oct 24, 2007 at 12:07:45PM -0700, David Stevens wrote:
> [EMAIL PROTECTED] wrote on 10/24/2007 09:24:10 AM:
>
> > This patch removes the unused EXPORT_SYMBOL(icmpmsg_statistics).
> >
> > Signed-off-by: Adria
This patch fixes a cut'n'paste error in
commit 1b76b31693d4a6088dec104ff6a6ead54081a3c2.
Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
---
4888742f8d7fe3b97fbc2911aa46375048173d01
diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c
index e5fab4b..6937
According to git, the only one who touched this file during the last
5 years was me when removing drivers...
modinfo offers less ancient information.
Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
Acked-by: Geert Uytterhoeven <[EMAIL PROTECTED]>
Acked-by: Paul Gortmaker <[
The EXPORT_PER_CPU_SYMBOL(softnet_data) is no longer used.
Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
---
6bf19ad197b0076e48be8720659d38413d438e26
diff --git a/net/core/dev.c b/net/core/dev.c
index 38b03da..113d216 100644
--- a/net/core/dev.c
+++ b/net/core/dev.c
@@ -4469,4 +
This patch makes three needlessly global functions static.
Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
---
include/net/sctp/auth.h |1 -
net/sctp/auth.c |6 +++---
2 files changed, 3 insertions(+), 4 deletions(-)
102a72ca5278d3c502bee6af4c4d11c9876d5a2d
diff -
This patch removes the unused EXPORT_SYMBOL(icmpmsg_statistics).
Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
---
4ce74657ac0b1bdcb4c7bc359d05643f8cc4a08b
diff --git a/net/ipv4/icmp.c b/net/ipv4/icmp.c
index 272c69e..233de06 100644
--- a/net/ipv4/icmp.c
+++ b/net/ipv4/icmp.c
@@ -
sctp_update_copy_cksum() is no longer used.
Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
---
include/net/sctp/sctp.h |1 -
net/sctp/crc32c.c |2 ++
2 files changed, 2 insertions(+), 1 deletion(-)
fc6646f84c07666228166c678ff2b5916db925ed
diff --git a/include/net/sctp/sc
sock_enable_timestamp() no longer has any modular users.
Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
---
c207a1b7709635c74b953324e60ab5a732ea279c
diff --git a/net/core/sock.c b/net/core/sock.c
index febbcbc..bba9949 100644
--- a/net/core/sock.c
+++ b/net/core/sock.c
@@ -1649,7 +
tcp_match_skb_to_sack() can become static.
Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
---
b734b439219a6251b7deb65dad2307f9c891f680
diff --git a/net/ipv4/tcp_input.c b/net/ipv4/tcp_input.c
index 9288220..603400d 100644
--- a/net/ipv4/tcp_input.c
+++ b/net/ipv4/tcp_input.c
@@ -1204,8 +
xs_setup_{udp,tcp}() can now become static.
Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
---
include/linux/sunrpc/xprtsock.h |6 --
net/sunrpc/xprtsock.c |4 ++--
2 files changed, 2 insertions(+), 8 deletions(-)
833a31c8caef70589f33be8e3a1fc9d8e01ce3c2
diff -
ircomm_tty can now become static.
Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
---
include/net/irda/ircomm_tty.h |1 -
net/irda/ircomm/ircomm_tty.c |2 +-
2 files changed, 1 insertion(+), 2 deletions(-)
487bdc857155e7346cbb80b07d2ec3df150fc9d2
diff --git a/include/ne
This patch contains the following cleanups:
- make ipg_nic_get_stats() static
- move DefaultPhyParam[] from ipg.h to ipg.c and make it static
Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
---
drivers/net/ipg.c | 22 +-
drivers/net/ipg.h | 20 -
bond_deinit() can now become static.
Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
---
drivers/net/bonding/bond_main.c |3 ++-
drivers/net/bonding/bonding.h |1 -
2 files changed, 2 insertions(+), 2 deletions(-)
5e5d2537b927f55a2199a0d9a073f41bb71290f6
diff --git a/drive
On Tue, Oct 23, 2007 at 08:55:29PM -0400, Jeff Garzik wrote:
> Actually, looking over the code I see obvious bugs in the logic:
>
> An invalid ethernet address should not cause device loading to fail,
> because the user is given the opportunity to supply a MAC address via
> userspace (ifconfig or
Since commit 1706d58763c36133d7fce6cc78b1444fd40db28c ip_frag_reasm()
can return the value of an uninitialized variable:
<-- snip -->
...
static int ip_frag_reasm(struct ipq *qp, struct sk_buff *prev,
struct net_device *dev)
{
struct iphdr *iph;
struct
The Coverity checker spotted that we have already oops'ed if "dst"
was NULL.
Since "dst" being NULL doesn't seem to be possible at this point this
patch removes the NULL check.
Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
---
eeb6009cf3ef5f6993ced359330
You want to check for the value, not for the address.
Spotted by the Coverity checker.
Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
---
--- a/drivers/net/e1000e/ethtool.c
+++ b/drivers/net/e1000e/ethtool.c
@@ -1451,11 +1451,11 @@ static int e1000_loopback_test(struct e1000_adapter
*a
The Coverity checker spotted the following in drivers/net/niu.c:
<-- snip -->
...
static int __devinit niu_pci_probe_sprom(struct niu *np)
{
...
val = nr64(ESPC_MOD_STR_LEN);
niudbg(PROBE, "SPROM: MOD_STR_LEN[%llu]\n",
(unsigned long long) val);
if (val >
On Wed, Sep 19, 2007 at 10:45:13AM -0700, David Miller wrote:
> From: Herbert Xu <[EMAIL PROTECTED]>
> Date: Wed, 19 Sep 2007 09:30:18 +0800
>
> > [PPP] pppoe: Fix double-free on skb after transmit failure
> >
> > When I got rid of the second packet in __pppoe_xmit I created
> > a double-free on
On Tue, Sep 11, 2007 at 10:29:47AM -0400, Bill Davidsen wrote:
> Adrian Bunk wrote:
>> On Tue, Sep 11, 2007 at 10:05:26AM +0200, Stephen Hemminger wrote:
>>
>>> There are several different problems in this thread:
>>> 1. The removal of old sk98lin driver
On Tue, Sep 11, 2007 at 10:05:26AM +0200, Stephen Hemminger wrote:
>
> There are several different problems in this thread:
> 1. The removal of old sk98lin driver caused some users to be forced to use
> skge. These users have uncovered issues with the dual port fiber based
> versions
> of
ocated
Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
---
3c211ad074038414ebc156b1abbc3df78dc60cb2
diff --git a/net/sctp/socket.c b/net/sctp/socket.c
index 37e7306..f53545a 100644
--- a/net/sctp/socket.c
+++ b/net/sctp/socket.c
@@ -112,9 +112,9 @@ extern int sysctl_sctp_mem[3];
ex
On Fri, Aug 31, 2007 at 09:58:22PM -0700, Andrew Morton wrote:
>...
> Changes since 2.6.23-rc3-mm1:
>...
> git-block.patch
>...
> git trees
>...
tcp_splice_data_recv() can become static.
Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
---
233aefd2a215430c16bd02eca06
sctp_addto_param() can become static.
Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
---
include/net/sctp/structs.h |1
net/sctp/sm_make_chunk.c | 39 ++---
2 files changed, 20 insertions(+), 20 deletions(-)
38f8064114b9e89a6a911b2e3625a41cdb
On Fri, Aug 31, 2007 at 09:58:22PM -0700, Andrew Morton wrote:
>...
> Changes since 2.6.23-rc3-mm1:
>...
> git-net.patch
>...
> git trees
>...
This hydra had more than one head...
Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
---
arch/i386/kernel/irq.c|
On Fri, Aug 31, 2007 at 09:58:22PM -0700, Andrew Morton wrote:
>...
> Changes since 2.6.23-rc3-mm1:
>...
> git-net.patch
>...
> git trees
>...
raise_softirq_irqoff no longer has any modular user.
Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
---
eff0407b63757cdd416
Already reported in an answer to the 2.6.23-rc4-mm1 announcement on
linux-kernel [1].
cu
Adrian
[1] http://lkml.org/lkml/2007/9/1/18
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise
On Sun, Sep 02, 2007 at 03:00:46PM +0200, Igor Sobrado wrote:
> On Sun, 2 Sep 2007, Alan Cox wrote:
>
>>> So, a multi-licensed file remains multi-licensed except when all authors
>>> agree about a change in the licensing terms. And it is clear on the BSD
>>
>> Not strictly true. They can either ag
On Sun, Sep 02, 2007 at 01:20:27PM +0200, Igor Sobrado wrote:
> On Sun, 2 Sep 2007, Alan Cox wrote:
>> You can shout this all you like but you would be wrong. You can remove
>> the licence if you have permission to do so. For the ath c files there
>> was permission to do so.
>
> There was permissio
6_csk_xmit':
(.text+0x72b0f): undefined reference to `flow_cache_genid'
net/built-in.o: In function `inet6_csk_xmit':
(.text+0x72be5): undefined reference to `flow_cache_genid'
make[1]: *** [.tmp_vmlinux1] Error 1
<-- snip -->
Signed-off-by: Adrian Bunk <[EMAIL PROTEC
defconfig fails with the following error on parisc:
<-- snip -->
...
CC net/core/gen_estimator.o
In file included from include2/asm/bitops.h:111,
from
/home/bunk/linux/kernel-2.6/linux-2.6.23-rc4-mm1/net/core/gen_estimator.c:18:
/home/bunk/linux/kernel-2.6/linux-2.6.23-
On Sat, Sep 01, 2007 at 08:36:24PM -0400, Jason Dixon wrote:
> On Sep 1, 2007, at 5:52 PM, Adrian Bunk wrote:
>
>> OK, I begin to understand this, there seem to be three different types
>> of files changed by Jiri's patch:
>> 1. dual licenced files planned to make G
On Sat, Sep 01, 2007 at 06:02:26PM -0600, Bob Beck wrote:
> >As a free software user and developer, the question I have is how come
> >the Linux community feels that they can take the BSD code that was
> >reverse-engineered at OpenBSD, and put a more restrictive licence onto
> >it, such that there
On Sat, Sep 01, 2007 at 06:36:36PM -0600, Theo de Raadt wrote:
> When companies have taken our wireless device drivers, many many of
> them have given changes and fixes back. Some maybe didn't, but that
> is OK.
>
> When Linux took our changes back, they immediately locked the door
> against chan
On Sat, Sep 01, 2007 at 07:29:39PM -0400, Constantine A. Murenin wrote:
> On 01/09/07, Adrian Bunk <[EMAIL PROTECTED]> wrote:
> > On Sat, Sep 01, 2007 at 05:27:03PM -0400, Constantine A. Murenin wrote:
> > > On 01/09/07, Adrian Bunk <[EMAIL PROTECTED]> wrote:
> &g
On Sat, Sep 01, 2007 at 04:41:12PM -0600, Bob Beck wrote:
> - Forwarded message from Bob Beck <[EMAIL PROTECTED]> -
>
> From: Bob Beck <[EMAIL PROTECTED]>
> To: [EMAIL PROTECTED]
> Subject: I respect the GPL immensely, really I do - but I believe this type
> of action weakens us all.
> X-
On Sun, Sep 02, 2007 at 03:36:08AM +0530, Satyam Sharma wrote:
>
>
> On Fri, 31 Aug 2007, Andrew Morton wrote:
> >
> > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.23-rc4/2.6.23-rc4-mm1/
>
> Got these on an i386 build with CONFIG_MODVERSIONS=y ...
>
> WARNING: "div64_64" [
On Sat, Sep 01, 2007 at 03:03:36PM -0700, Sam Leffler wrote:
> Adrian Bunk wrote:
>> On Sat, Sep 01, 2007 at 01:37:18PM -0400, Constantine A. Murenin wrote:
>>
>>> On 01/09/07, Jeff Garzik <[EMAIL PROTECTED]> wrote:
>>>
>>>> Consta
On Sat, Sep 01, 2007 at 05:51:49PM -0400, Constantine A. Murenin wrote:
> On 01/09/07, Adrian Bunk <[EMAIL PROTECTED]> wrote:
> > On Sat, Sep 01, 2007 at 10:54:57PM +0200, Adrian Bunk wrote:
> > > On Sat, Sep 01, 2007 at 01:37:18PM -0400, Constantine A. Murenin wrote:
&
On Sat, Sep 01, 2007 at 05:27:03PM -0400, Constantine A. Murenin wrote:
> On 01/09/07, Adrian Bunk <[EMAIL PROTECTED]> wrote:
> > On Sat, Sep 01, 2007 at 01:37:18PM -0400, Constantine A. Murenin wrote:
> > > On 01/09/07, Jeff Garzik <[EMAIL PROTECTED]> wrote:
> &
On Sat, Sep 01, 2007 at 10:54:57PM +0200, Adrian Bunk wrote:
> On Sat, Sep 01, 2007 at 01:37:18PM -0400, Constantine A. Murenin wrote:
> > On 01/09/07, Jeff Garzik <[EMAIL PROTECTED]> wrote:
> > > Constantine A. Murenin wrote:
> > > > This will hopefully help d
On Sat, Sep 01, 2007 at 01:37:18PM -0400, Constantine A. Murenin wrote:
> On 01/09/07, Jeff Garzik <[EMAIL PROTECTED]> wrote:
> > Constantine A. Murenin wrote:
> > > This will hopefully help diminish certain myths about the code licensing.
> >
> > What myth? The myth that Theo understands dual lic
On Tue, Aug 28, 2007 at 07:06:04PM +0200, Sam Ravnborg wrote:
> >
> > It fixes a bug exposed by a -mm only patch, not by the net tree
> > (and 2.6.23-rc3-mm1 doesn't contain the net tree at all).
> >
> > > But I'd like a better description, please. Which "non-gcc parser" are we
> > > talking abo
On Tue, Aug 28, 2007 at 12:37:04AM -0700, Andrew Morton wrote:
> On Mon, 27 Aug 2007 23:27:43 +0200 Adrian Bunk <[EMAIL PROTECTED]> wrote:
>
> > On Wed, Aug 22, 2007 at 03:33:27PM +0200, Gabriel C wrote:
> > >...
> > > WARNING: "div64_64&qu
On Mon, Aug 27, 2007 at 02:58:05PM -0700, Kok, Auke wrote:
> Adrian Bunk wrote:
>...
>> This patch has been sent on:
>> - 14 Aug 2007
>> - 29 Jul 2007
>
> currently we won't have e100 fixed up for ARM in 2.6.23, so removing this
> for 2.6.24 sounds
On Tue, Aug 21, 2007 at 06:51:16PM -0400, [EMAIL PROTECTED] wrote:
> On Tue, 21 Aug 2007 09:16:43 PDT, "Paul E. McKenney" said:
>
> > I agree that instant gratification is hard to come by when synching
> > up compiler and kernel versions. Nonetheless, it should be possible
> > to create APIs that
On Tue, Aug 14, 2007 at 06:04:01PM -0400, Jeff Garzik wrote:
> Adrian Bunk wrote:
>> According to git, the only one who touched this file during the last
>> 5 years was me when removing drivers...
>> modinfo offers less ancient information.
>> Signed-off-by: Ad
According to git, the only one who touched this file during the last
5 years was me when removing drivers...
modinfo offers less ancient information.
Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
---
This patch has been sent on:
- 23 Jul 2007
Documentation/networking/00-INDEX
The Coverity checker spotted that we'd have already oops'ed if "vlandev"
was NULL.
Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
---
--- linux-2.6.23-rc1-mm2/net/8021q/vlanproc.c.old 2007-08-08
06:22:40.0 +0200
+++ linux-2.6.23-rc1-mm2/net/8021q/vla
This patch removes the no longer used EXPORT_SYMBOL(dev_ethtool).
Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
---
37bcb29c1a1fefe6da0ea9e54a5cde09a82318f0
diff --git a/net/core/ethtool.c b/net/core/ethtool.c
index 2ab0a60..c5e0593 100644
--- a/net/core/ethtool.c
+++ b/net/core/eth
On Sun, Aug 12, 2007 at 02:00:26PM +0200, Michael Buesch wrote:
> Ok, I'll give it a try, with small modifications.
Thanks.
> On Sunday 12 August 2007, Adrian Bunk wrote:
> > Additional changes in this patch:
> > - small help text changes
> > - B44_PCI is no long
On Sat, Aug 11, 2007 at 04:42:39PM +0200, Michael Buesch wrote:
> On Saturday 11 August 2007 16:30:02 Adrian Bunk wrote:
> > And offering more options than required or manually sending users into
> > other menus are bad thing for your users.
>
> Breaking compilations are as
On Sat, Aug 11, 2007 at 11:36:46AM +0200, Michael Buesch wrote:
>
> That's all a silly discussion, guys.
> I personally do _not_ care which way we do this.
> BUT: My users do care. There is currently no way telling them to first enable
> SSB, when they want to select b44 (for example).
The curren
On Sat, Aug 11, 2007 at 02:57:36AM +0200, Johannes Berg wrote:
> On Sat, 2007-08-11 at 02:43 +0200, Adrian Bunk wrote:
>
> > -ENOMENUCONFIGPATCH
>
> Has anybody decided how it could possibly even look like anyhow? It
> should be fixed, but nobody has a plan.
The simplest
On Sat, Aug 11, 2007 at 02:08:21AM +0200, Michael Buesch wrote:
> This fixes the SSB dependency hell and introduces some
> fake-options that only give some advice on what to select.
>
> We live with these fake options only until menuconfig is able
> to tell more about needed dependencies and how t
On Thu, Aug 09, 2007 at 01:51:06AM -0700, Andrew Morton wrote:
>...
> - There is a new e1000 driver in git-netdev-all, called e1000e. I'm sure
> the developers would like it tested. Please cc netdev@vger.kernel.org on
> any reports.
>...
> Changes since 2.6.23-rc2-mm1:
>...
> git-netdev-all.
nf_ct_ipv6_skip_exthdr() can now become static.
Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
---
include/net/netfilter/ipv6/nf_conntrack_ipv6.h |3 ---
net/ipv6/netfilter/nf_conntrack_l3proto_ipv6.c |4 ++--
2 files changed, 2 insertions(+), 5 deletions(-)
--- linux-2.6.23-r
The following code can now become static:
- struct unix_socket_table
- unix_table_lock
Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
---
include/net/af_unix.h | 29 -
net/unix/af_unix.c| 30 --
2 files changed, 28 inse
Non-static inline code usually doesn't makes sense.
In this case making is static and non-inline is the correct solution.
Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
---
--- linux-2.6.23-rc1-mm1/net/core/pktgen.c.old 2007-07-26 20:12:01.0
+0200
+++ linux-2.6.23-rc1-m
e1000_{read,write}_pci_cfg() are no longer used.
Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
---
This patch has been sent on:
- 1 Jul 2007
- 5 Jun 2007
drivers/net/e1000/e1000_hw.h |2 --
drivers/net/e1000/e1000_main.c |4
2 files changed, 4 insertions(+), 2 del
This patch removes dead code ("tx_xcnt" can never be != 0 at this place)
spotted by the Coverity checker.
Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
---
drivers/net/cxgb3/xgmac.c |5 +
1 file changed, 1 insertion(+), 4 deletions(-)
--- linux-2.6.22-rc6-mm1/d
On Tue, Jul 24, 2007 at 12:48:13PM -0700, Linus Torvalds wrote:
>
>
> On Tue, 24 Jul 2007, Adrian Bunk wrote:
> >
> > > But do we
> > > care so much that it's worth inlining something like buffered_rmqueue()?
> > >...
> >
> >
On Wed, Jul 25, 2007 at 04:03:04AM -0700, Andrew Morton wrote:
>...
> Changes since 2.6.22-rc6-mm1:
>...
> +immunize-rcu_dereference-against-crazy-compiler-writers.patch
>...
> Misc new patches
>...
This patch causes the following compile error:
<-- snip -->
...
CC net/ipv4/fib_trie.o
On Wed, Jul 25, 2007 at 09:48:55AM -0400, Jeff Garzik wrote:
> Adrian Bunk wrote:
>> BTW:
>> Unless I'm misunderstanding anything, the new driver should support a
>> superset of what the old driver supported.
>> Therefore, it would be good if the final merge into L
7;:
(.text+0x8799): multiple definition of `e1000_phy_setup_autoneg'
drivers/net/e1000new/built-in.o:(.text+0xa9bd): first defined here
...
make[3]: *** [drivers/net/built-in.o] Error 1
<-- snip -->
Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
---
BTW:
Unless I'm misunderstan
On Tue, Jul 24, 2007 at 12:15:48PM -0700, Linus Torvalds wrote:
>
>
> On Tue, 24 Jul 2007, Andrew Morton wrote:
> >
> > fwiw, -fno-inline-functions-called-once (who knew?) takes i386 allnoconfig
> > vmlinux .text from 928360 up to 955362 bytes (27k larger).
> >
> > A surprisingly large increase
On Mon, Jul 23, 2007 at 02:28:11PM -0700, Linus Torvalds wrote:
>
>
> On Mon, 23 Jul 2007, Andrew Morton wrote:
> >
> > It'd be nice to get a clean trace. Are you able to obtain the full
> > trace with CONFIG_FRAME_POINTER=y?
>
> If you are talking about
>
> http://userweb.kernel.org/~a
kAccording to git, the only one who touched this file during the last
5 years was me when removing drivers...
modinfo offers a less ancient version of this information.
Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
---
Documentation/networking/00-INDEX|2
Documen
The Coverity checker noted that we've already dereferenced "dev" when we
check whether it's NULL.
Since it's impossible that "dev" is NULL at this place this patch
removes the NULL check.
Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
---
--- linu
Commit 8de0a15483b357d0f0b821330ec84d1660cadc4e added the following
use-after-free in net/bluetooth/rfcomm/tty.c:
<-- snip -->
...
static int rfcomm_dev_add(struct rfcomm_dev_req *req, struct rfcomm_dlc *dlc)
{
...
if (IS_ERR(dev->tty_dev)) {
list_del(&dev->list);
The Coverity checker spotted the following use-after-free
in net/9p/mux.c:
<-- snip -->
...
struct p9_conn *p9_conn_create(struct p9_transport *trans, int msize,
unsigned char *extended)
{
...
if (!m->tagpool) {
kfree(m);
The Coverity checker spotted the following bogus code
in drivers/net/xen-netfront.c:
<-- snip -->
...
static void xennet_alloc_rx_buffers(struct net_device *dev)
{
...
for (nr_flips = i = 0; ; i++) {
skb = __skb_dequeue(&np->rx_batch);
if (skb == NULL)
On Wed, Jul 18, 2007 at 05:18:20PM -0400, Robert P. J. Day wrote:
> On Wed, 18 Jul 2007, Adrian Bunk wrote:
>
> > On Wed, Jul 18, 2007 at 04:51:33PM -0400, Robert P. J. Day wrote:
> > > On Wed, 18 Jul 2007, Jeff Garzik wrote:
> > >
> > > > Randy Dunlap
On Wed, Jul 18, 2007 at 04:51:33PM -0400, Robert P. J. Day wrote:
> On Wed, 18 Jul 2007, Jeff Garzik wrote:
>
> > Randy Dunlap wrote:
> > > On Wed, 18 Jul 2007 16:23:09 -0400 (EDT) Robert P. J. Day wrote:
> > > > there's no point adding all that redundant content when it can all be
> > > > done au
On Mon, Jul 16, 2007 at 04:00:52PM +0300, Samuel Ortiz wrote:
> On Mon, Jul 16, 2007 at 02:17:15PM +0300, Samuel Ortiz wrote:
> > Hi Dave,
> >
> > When having built-in IrDA, we hit the following error:
> >
> > `irda_sysctl_unregister' referenced in section `.init.text' of
> > net/built-in.o: defi
On Mon, Jul 16, 2007 at 04:17:08PM +0400, Evgeniy Polyakov wrote:
> On Mon, Jul 16, 2007 at 02:07:44PM +0200, Adrian Bunk ([EMAIL PROTECTED])
> wrote:
> > > What about having all of them __devinit/__devexit?
> >
> > That would be completely wrong.
>
> Hi Adrian
On Mon, Jul 16, 2007 at 03:56:26PM +0400, Evgeniy Polyakov wrote:
> Hi Samuel.
>
> On Mon, Jul 16, 2007 at 02:17:15PM +0300, Samuel Ortiz ([EMAIL PROTECTED])
> wrote:
> > This is due to the irda_init fix recently added, where we call __exit
> > routines from an __init one. It is a build failure t
ipt_iprange.h must #include since it uses __be32.
This patch fixes kernel Bugzilla #7604.
Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
---
--- linux-2.6.22-rc6-mm1/include/linux/netfilter_ipv4/ipt_iprange.h.old
2007-07-15 13:07:40.0 +0200
+++ linux-2.6.22-rc6-mm1/include
On Fri, Jul 13, 2007 at 09:10:42AM +0200, Geert Uytterhoeven wrote:
> On Fri, 13 Jul 2007, Adrian Bunk wrote:
> > This patch removes some code that became dead code after the ATARI_ACSI
> > removal.
>
> When was it removed?
>...
Jens removed it in commit c2bcf3b8978c291e
On Fri, Jul 13, 2007 at 11:54:42PM -0700, David Miller wrote:
> From: Adrian Bunk <[EMAIL PROTECTED]>
> Date: Sat, 14 Jul 2007 06:09:54 +0200
>
> > This patch contains the following cleanups:
> > - note in the prompt if an option depends on EXPERIMENTAL
> > - rem
uld
know which ones you want
Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
---
net/ipv4/Kconfig | 27 ---
1 file changed, 8 insertions(+), 19 deletions(-)
--- linux-2.6.22-rc6-mm1/net/ipv4/Kconfig.old 2007-07-13 11:00:22.0
+0200
+++ linux-2.6.22-rc6-
From: John Donoghue <[EMAIL PROTECTED]>
CONFIG_EP93XX_ETH=y, CONFIG_MII=n results in an obvious link error.
Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
--- linux-2.6.20.2.orig/drivers/net/arm/Kconfig 2007-03-09 22:32:46.0
-0500
+++ linux-2.6.20.2/drivers/net/arm/Kconfig
This patch makes the needlessly global __inet_twsk_kill() static.
Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
---
include/net/inet_timewait_sock.h |3 ---
net/ipv4/inet_timewait_sock.c|5 ++---
2 files changed, 2 insertions(+), 6 deletions(-)
--- linux-2.6.22-rc6-mm1/i
This patch fixes the following section mismatch:
<-- snip -->
...
MODPOST vmlinux
WARNING: drivers/built-in.o(.text+0x272f8b): Section mismatch: reference to
.init.text:quattro_pci_find (between 'happy_meal_pci_probe' and
'happy_meal_pci_remove')
...
<-- sni
This patch fixes the following section mismatch:
<-- snip -->
...
MODPOST vmlinux
WARNING: drivers/built-in.o(.text+0x62e4f7): Section mismatch: reference to
.init.text:sram_test_word (between 'sram_test_pass' and 'sram_test_and_clear')
...
<-- snip --
This patch fixes the following section mismatch:
<-- snip -->
...
MODPOST vmlinux
WARNING: drivers/built-in.o(.text+0x26e3f2): Section mismatch: reference to
.init.text:rr_init (between 'rr_init_one' and 'rr_remove_one')
...
<-- snip -->
Signed-off-b
;-- snip -->
Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
---
--- linux-2.6.22-rc6-mm1/drivers/atm/fore200e.c.old 2007-07-10
04:11:43.0 +0200
+++ linux-2.6.22-rc6-mm1/drivers/atm/fore200e.c 2007-07-10 04:12:48.0
+0200
@@ -2435,7 +2435,7 @@
}
-sta
This patch fixes the following section mismatch:
<-- snip -->
...
MODPOST vmlinux
WARNING: drivers/built-in.o(.text+0x298170): Section mismatch: reference to
.init.text:sis900_mii_probe (between 'sis900_probe' and 'sis900_default_phy')
...
<-- snip -->
Si
This patch fixes the following section mismatch:
<-- snip -->
...
MODPOST vmlinux
WARNING: drivers/built-in.o(.text+0x361ef1): Section mismatch: reference to
.init.text:xl_init (between 'xl_probe' and 'xl_hw_reset')
...
<-- snip -->
Signed-off-b
$ filterdiff -z -i \*bnx2_fw\* patch-2.6.22.gz | diffstat -p1 -w72
drivers/net/bnx2_fw.h | 1697 +---
drivers/net/bnx2_fw2.h | 7868 -
2 files changed, 4982 insertions(+), 4583 deletions(-)
$
Please switch this driver to use request_firmware().
TIA
A
On Mon, Jul 09, 2007 at 01:27:55PM -0400, Bill Davidsen wrote:
> Adrian Bunk wrote:
>> On Thu, Jul 05, 2007 at 12:01:56PM -0400, Bill Davidsen wrote:
>>
>>> Please do not make unnecessary kernel changes which require changes in
>>> our systems.
>>>
With one exception, all DONGLE_OLD drivers have newer counterparts.
The DONGLE_OLD drivers depend on BROKEN_ON_SMP which e.g. implies that
the many distributions shipping only SMP-kernels will never offer them.
The one exception is a driver for the Cirrus Logic EDB-7211 evaluation
board that it
On Thu, Jul 05, 2007 at 12:01:56PM -0400, Bill Davidsen wrote:
> Please do not make unnecessary kernel changes which require changes in our
> systems.
Welcome to the kernel 2.6 development model.
> Kok, Auke wrote:
>> Bill Davidsen wrote:
>>> Adrian Bunk wrote:
>
Every file should include the headers containing the prototypes for
its global functions.
Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
---
--- linux-2.6.22-rc6-mm1/net/core/netevent.c.old2007-07-03
04:59:08.0 +0200
+++ linux-2.6.22-rc6-mm1/net/core/netevent.c2007-07
101 - 200 of 603 matches
Mail list logo
