RE: [PATCH] tehuti: possible leak in bdx_probe

2007-10-14 Thread Alexander Indenbaum
-Original Message- From: Florin Malita [mailto:[EMAIL PROTECTED] If pci_enable_device fails, bdx_probe returns without freeing the allocated pci_nic structure. Coverity CID 1908. Signed-off-by: Florin Malita [EMAIL PROTECTED] Looks fine to me. Acked-by: Alexander Indenbaum

RE: [PATCH] tehuti: driver for Tehuti 10GbE network adapters

2007-09-19 Thread Alexander Indenbaum
, Alexander Indenbaum - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

RE: [PATCH] tehuti: driver for Tehuti 10GbE network adapters

2007-09-19 Thread Alexander Indenbaum
to netdev after unregister_netdev() finishes and we can free_netdev() without any worry :) What do you think, does it still look fishy? Alexander Indenbaum - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http

RE: [PATCH] tehuti: driver for Tehuti 10GbE network adapters

2007-09-19 Thread Alexander Indenbaum
Ok, so you do irq acquire/release in open/close so that bit is fine. The code might actually work as is, sorry for the noise. It is no noise at all. Thank you for your feedback. - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED]