Re: [bug, bisected] pfifo_fast causes packet reordering

2018-03-19 Thread Alexander Stein
On Friday, March 16, 2018, 11:26:47 AM CET Jakob Unterwurzacher wrote: > On 15.03.18 23:30, John Fastabend wrote: > >> I have reproduced it using two USB network cards connected to each other. > >> The test tool sends UDP packets containing a counter and listens on the > >> other interface, it

[PATCH 1/1] phy/micrel: Change phy_id_mask for KSZ8721

2016-07-29 Thread Alexander Stein
There are KSZ8721 PHYs with phy_id 0x00221619. In order to detect them as PHY_ID_KSZ8001 compatible while staying different to PHY_ID_KSZ9021 ignore the last two bits when matching PHY_ID Signed-off-by: Alexander Stein <alexander...@web.de> --- drivers/net/phy/micrel.c | 4 ++-- 1 file c

Re: [PATCH 1/2] NET: PHY: Add PHY LED control binding.

2016-06-09 Thread Alexander Stein
On Wednesday 08 June 2016 14:30:08, Rob Herring wrote: > > diff --git a/Documentation/devicetree/bindings/phy/phy-leds.txt > > b/Documentation/devicetree/bindings/phy/phy-leds.txt new file mode 100644 > > index 000..1a35e3d > > --- /dev/null > > +++

Re: [PATCH 1/1 RFC] net/phy: Add Lantiq PHY driver

2016-05-23 Thread Alexander Stein
Hi Hauke, On Monday 23 May 2016 09:12:54, Mehrtens, Hauke wrote: > > On Thursday 19 May 2016 12:03:10, Mathias Kresin wrote: > > > 2016-05-19 9:03 GMT+02:00 John Crispin <j...@phrozen.org>: > > > > On 19/05/2016 08:57, Alexander Stein wrote: > > &

Re: [PATCH 1/1 RFC] net/phy: Add Lantiq PHY driver

2016-05-19 Thread Alexander Stein
On Thursday 19 May 2016 12:03:10, Mathias Kresin wrote: > 2016-05-19 9:03 GMT+02:00 John Crispin <j...@phrozen.org>: > > On 19/05/2016 08:57, Alexander Stein wrote: > >> Thanks for the link, I wasn't aware of that patch. I like it in general, > >> but ther

Re: [PATCH 1/1 RFC] net/phy: Add Lantiq PHY driver

2016-05-19 Thread Alexander Stein
On Thursday 19 May 2016 09:03:26, John Crispin wrote: > [ changing haukes mail addr to the intel one ] > > On 19/05/2016 08:57, Alexander Stein wrote: > > Hi John, > > > > On Thursday 19 May 2016 06:50:56, John Crispin wrote: > >> On 18/05/2016 18:24, Florian

Re: [PATCH 1/1 RFC] net/phy: Add Lantiq PHY driver

2016-05-19 Thread Alexander Stein
On Wednesday 18 May 2016 19:01:09, Andrew Lunn wrote: > > For LEDs, we had a patch series floating around adding LED triggers [1], > > and it seems to me like the LEDs class subsystem would be a good fit for > > controlling PHY LEDs, possibly with the help of PHYLIB when it comes to > > doing the

Re: [PATCH 1/1 RFC] net/phy: Add Lantiq PHY driver

2016-05-19 Thread Alexander Stein
Hi John, On Thursday 19 May 2016 06:50:56, John Crispin wrote: > On 18/05/2016 18:24, Florian Fainelli wrote: > > CC'ing Andrew, John, > > also CC'ing Matthias and Hauke. we have had a driver in OpenWrt/LEDE for > several years that seems a little more complete than this one. > >

[PATCH 1/1 RFC] net/phy: Add Lantiq PHY driver

2016-05-18 Thread Alexander Stein
This currently only supports PEF7071 and allows to specify max-speed and is able to read the LED configuration from device-tree. Signed-off-by: Alexander Stein <alexander.st...@systec-electronic.com> --- The main purpose for now is to set a LED configuration from device tree and to

Re: [PATCH 0/3] net: macb: Fix coding style issues

2016-03-07 Thread Alexander Stein
Hi, On Monday 07 March 2016 08:17:36, Moritz Fischer wrote: > this series deals with most of the checkpatch warnings > generated for macb. There are two BUG_ON()'s that I didn't touch, yet, > that were suggested by checkpatch, that I can address in a follow up > commit if needed. I think

Re: [PATCH] rtlwifi: pass struct rtl_stats by reference as it is more efficient

2016-02-22 Thread Alexander Stein
On Monday 22 February 2016 10:16:20, Colin Ian King wrote: > On 22/02/16 06:51, Alexander Stein wrote: > > On Saturday 20 February 2016 22:10:27, Colin King wrote: > >> From: Colin Ian King <colin.k...@canonical.com> > >> > >> passing rtl_stats by value

Re: [PATCH] rtlwifi: pass struct rtl_stats by reference as it is more efficient

2016-02-21 Thread Alexander Stein
On Saturday 20 February 2016 22:10:27, Colin King wrote: > From: Colin Ian King > > passing rtl_stats by value is inefficient; the structure is over 300 > bytes in size and generally just one field (packet_report_type) > is being accessed, so the pass by value is a

[PATCH 1/1] net sysfs: Print link speed as signed integer

2015-09-28 Thread Alexander Stein
Otherwise 4294967295 (MBit/s) (-1) will be printed when there is no link. Documentation/ABI/testing/sysfs-class-net does not state if this shall be signed or unsigned. Signed-off-by: Alexander Stein <alexander.st...@systec-electronic.com> --- net/core/net-sysfs.c | 2 +- 1 file chan

[PATCH v2 1/1] net sysfs: Print link speed as signed integer

2015-09-28 Thread Alexander Stein
Otherwise 4294967295 (MBit/s) (-1) will be printed when there is no link. Documentation/ABI/testing/sysfs-class-net does not state if this shall be signed or unsigned. Also remove the now unused variable fmt_udec. Signed-off-by: Alexander Stein <alexander.st...@systec-electronic.com> --- C