Fw: [Bugme-new] [Bug 6401] New: tg3 hardware address issue

2006-04-17 Thread Andrew Morton
Begin forwarded message: Date: Mon, 17 Apr 2006 13:39:47 -0700 From: [EMAIL PROTECTED] To: [EMAIL PROTECTED] Subject: [Bugme-new] [Bug 6401] New: tg3 hardware address issue http://bugzilla.kernel.org/show_bug.cgi?id=6401 Summary: tg3 hardware address issue Kernel Version:

Fw: [Bugme-new] [Bug 6402] New: KERNEL 2.6.16-rX (Gentoo) PPPD SNAT

2006-04-17 Thread Andrew Morton
Begin forwarded message: Date: Mon, 17 Apr 2006 14:57:03 -0700 From: [EMAIL PROTECTED] To: [EMAIL PROTECTED] Subject: [Bugme-new] [Bug 6402] New: KERNEL 2.6.16-rX (Gentoo) PPPD SNAT http://bugzilla.kernel.org/show_bug.cgi?id=6402 Summary: KERNEL 2.6.16-rX (Gentoo) PPPD SNAT

Fw: Openswan, iptables (fiaif) and 2.6.16 kernel

2006-04-14 Thread Andrew Morton
Begin forwarded message: Date: Fri, 14 Apr 2006 14:32:39 +0200 From: Laurent CARON [EMAIL PROTECTED] To: linux-kernel@vger.kernel.org Subject: Openswan, iptables (fiaif) and 2.6.16 kernel Hi, I'm running an openswan gateway for quite a long time now. I have used 2.4.X and 2.6.X kernels

Fw: [Bugme-new] [Bug 6378] New: bonding mode=1 does not always pick right primary interface

2006-04-12 Thread Andrew Morton
Begin forwarded message: Date: Wed, 12 Apr 2006 05:57:27 -0700 From: [EMAIL PROTECTED] To: [EMAIL PROTECTED] Subject: [Bugme-new] [Bug 6378] New: bonding mode=1 does not always pick right primary interface http://bugzilla.kernel.org/show_bug.cgi?id=6378 Summary: bonding mode=1

Re: [patch] ipv4: initialize arp_tbl rw lock

2006-04-08 Thread Andrew Morton
Heiko Carstens [EMAIL PROTECTED] wrote: Ok, so the problem seems to be that inet_init gets called after qeth_init. Looking at the top level Makefile this seems to be true for all network drivers in drivers/net/ and drivers/s390/net/ since we have vmlinux-main := $(core-y) $(libs-y)

Fw: [Bugme-new] [Bug 6354] New: NULL Pointer lapbether

2006-04-08 Thread Andrew Morton
Begin forwarded message: Date: Sat, 8 Apr 2006 08:11:18 -0700 From: [EMAIL PROTECTED] To: [EMAIL PROTECTED] Subject: [Bugme-new] [Bug 6354] New: NULL Pointer lapbether http://bugzilla.kernel.org/show_bug.cgi?id=6354 Summary: NULL Pointer lapbether Kernel Version: 2.6.14

Fw: [Bugme-new] [Bug 6349] New: iptables DNAT returns unknown error 4294967295

2006-04-07 Thread Andrew Morton
Begin forwarded message: Date: Fri, 7 Apr 2006 06:12:07 -0700 From: [EMAIL PROTECTED] To: [EMAIL PROTECTED] Subject: [Bugme-new] [Bug 6349] New: iptables DNAT returns unknown error 4294967295 http://bugzilla.kernel.org/show_bug.cgi?id=6349 Summary: iptables DNAT returns unknown

Re: updated [Patch 1/1] AF_UNIX Datagram getpeersec

2006-04-07 Thread Andrew Morton
Catherine Zhang [EMAIL PROTECTED] wrote: Enclosed please find the updated AF_UNIX patch. ... --- linux-2.6.17-rc1/include/asm-alpha/socket.h~lsm-secpeer-unix 2006-04-03 18:19:47.0 -0400 +++ linux-2.6.17-rc1-cxzhang/include/asm-alpha/socket.h 2006-04-03

Fw: bridge+netfilter broken for IP fragments in 2.6.16?

2006-04-01 Thread Andrew Morton
Begin forwarded message: Date: Sat, 1 Apr 2006 16:30:11 +0200 From: Thomas Zeitlhofer [EMAIL PROTECTED] To: linux-kernel@vger.kernel.org Subject: bridge+netfilter broken for IP fragments in 2.6.16? Hello, I have set up a bridge with two ports: # brctl show br0 bridge name bridge id

Fw: [Bugme-new] [Bug 6308] New: Bug in ip_route_input_slow()

2006-03-30 Thread Andrew Morton
Begin forwarded message: Date: Thu, 30 Mar 2006 09:06:52 -0800 From: [EMAIL PROTECTED] To: [EMAIL PROTECTED] Subject: [Bugme-new] [Bug 6308] New: Bug in ip_route_input_slow() http://bugzilla.kernel.org/show_bug.cgi?id=6308 Summary: Bug in ip_route_input_slow() Kernel Version:

Re: dcache leak in 2.6.16-git8 II

2006-03-29 Thread Andrew Morton
Andi Kleen [EMAIL PROTECTED] wrote: On Tuesday 28 March 2006 05:00, Andrew Morton wrote: Andi Kleen [EMAIL PROTECTED] wrote: On Monday 27 March 2006 13:48, Bharata B Rao wrote: On Mon, Mar 27, 2006 at 07:50:20AM +0200, Andi Kleen wrote: A 2GB x86-64 desktop system here

Re: [Patch 5/8] generic netlink interface for delay accounting

2006-03-29 Thread Andrew Morton
Shailabh Nagar [EMAIL PROTECTED] wrote: delayacct-genetlink.patch Create a generic netlink interface (NETLINK_GENERIC family), called taskstats, for getting delay and cpu statistics of tasks and thread groups during their lifetime and when they exit. It's be best to have a netlink

Re: [Patch 5/8] generic netlink interface for delay accounting

2006-03-29 Thread Andrew Morton
Balbir Singh [EMAIL PROTECTED] wrote: The kmem_cache_free() can happen outside the lock. kmem_cache_free() and setting to NULL outside the lock is prone to race conditions. Consider the following scenario A thread group T1 has exiting processes P1 and P2 P1 is exiting, finishes the

Re: [PATCH] deinline some larger functions from netdevice.h

2006-03-29 Thread Andrew Morton
Denis Vlasenko [EMAIL PROTECTED] wrote: Network folks did non comment on these two patches, let me try submitting them to you instead. They're both merged (one is in -linus, the other's in -davem). - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to

nf_conntrack_l3proto_ipv6.c Kconfig confusion

2006-03-24 Thread Andrew Morton
x86 allmodconfig: bix:/usr/src/25 make net/ipv6/netfilter/nf_conntrack_l3proto_ipv6.o CC net/ipv6/netfilter/nf_conntrack_l3proto_ipv6.o net/ipv6/netfilter/nf_conntrack_l3proto_ipv6.c: In function `ipv6_conntrack_in': net/ipv6/netfilter/nf_conntrack_l3proto_ipv6.c:254: error: structure has

Fw: [Bugme-new] [Bug 6277] New: System hangs up when using HTB on a Marvell Technology Group Ltd. Yukon Gigabit Ethernet 10/100/1000Base-T Adapter

2006-03-23 Thread Andrew Morton
Begin forwarded message: Date: Thu, 23 Mar 2006 11:52:03 -0800 From: [EMAIL PROTECTED] To: [EMAIL PROTECTED] Subject: [Bugme-new] [Bug 6277] New: System hangs up when using HTB on a Marvell Technology Group Ltd. Yukon Gigabit Ethernet 10/100/1000Base-T Adapter

ebt_ulog: not logging via ulog since somebody else already registered for PF_BRIDGE

2006-03-23 Thread Andrew Morton
How come? Calling initcall 0xc0517656: flow_cache_init+0x0/0x11b() Calling initcall 0xc0517771: llc_init+0x0/0x60() Calling initcall 0xc05177d1: snap_init+0x0/0x37() Calling initcall 0xc05186e7: inet_init+0x0/0x1ae() NET: Registered protocol family 2 input: AT Translated Set 2 keyboard as

Re: ebt_ulog: not logging via ulog since somebody else already registered for PF_BRIDGE

2006-03-23 Thread Andrew Morton
Andrew Morton [EMAIL PROTECTED] wrote: Calling initcall 0xc0519498: init+0x0/0x24() Calling initcall 0xc05194bc: init+0x0/0x74() Calling initcall 0xc0519530: init+0x0/0x74() Calling initcall 0xc05195a4: init+0x0/0x16() Calling initcall 0xc05195ba: init+0x0/0x16() Calling initcall

Re: ebt_ulog: not logging via ulog since somebody else already registered for PF_BRIDGE

2006-03-23 Thread Andrew Morton
David S. Miller [EMAIL PROTECTED] wrote: From: Andrew Morton [EMAIL PROTECTED] Date: Thu, 23 Mar 2006 22:36:43 -0800 Would it be possible to do s/init/ebt_ulog_init/etc? I agree, that would be most welcome. whee, 120 files. Gimme fifteen.. - To unsubscribe from this list: send the line

Fw: [Bugme-new] [Bug 6268] New: b44 driver - system hangs while changing MAC address

2006-03-22 Thread Andrew Morton
Begin forwarded message: Date: Wed, 22 Mar 2006 02:32:49 -0800 From: [EMAIL PROTECTED] To: [EMAIL PROTECTED] Subject: [Bugme-new] [Bug 6268] New: b44 driver - system hangs while changing MAC address http://bugzilla.kernel.org/show_bug.cgi?id=6268 Summary: b44 driver - system

Re: [2.6.16-gitX] heavy performance regression in ipw2200 wireless driver

2006-03-22 Thread Andrew Morton
Alessandro Suardi [EMAIL PROTECTED] wrote: Plze try to cc the right people. Driver - or firmware ? Don't know - since the new git snapshots run 1.1.1 which requires newer firmware from http://ipw2200.sourceforge.net. Symptom - my new FC5 partition with 2.6.16-git kernels connects via

Re: [PATCH] scm: fold __scm_send() into scm_send()

2006-03-20 Thread Andrew Morton
Chris Wright [EMAIL PROTECTED] wrote: * Chris Wright ([EMAIL PROTECTED]) wrote: * Ingo Oeser ([EMAIL PROTECTED]) wrote: Hi Chris, Andrew Morton wrote: Ingo Oeser [EMAIL PROTECTED] wrote: -int scm_send(struct socket *sock, struct msghdr *msg, struct scm_cookie

Re: [patch 1/4] natsemi: Add support for using MII port with no PHY

2006-03-16 Thread Andrew Morton
Mark Brown [EMAIL PROTECTED] wrote: +if (np-ignore_phy (ecmd-autoneg == AUTONEG_ENABLE || + ecmd-port == PORT_INTERNAL)) { What's PORT_INTERNAL? ethtool doesn't appear to define that. drivers/net/natsemi.c: In function `netdev_set_ecmd':

Fw: [Bugme-new] [Bug 6233] New: race condition in tcp_sendmsg when connection became established

2006-03-16 Thread Andrew Morton
Begin forwarded message: Date: Thu, 16 Mar 2006 07:22:54 -0800 From: [EMAIL PROTECTED] To: [EMAIL PROTECTED] Subject: [Bugme-new] [Bug 6233] New: race condition in tcp_sendmsg when connection became established http://bugzilla.kernel.org/show_bug.cgi?id=6233 Summary: race

Re: [PATCH] scm: fold __scm_send() into scm_send()

2006-03-13 Thread Andrew Morton
Ingo Oeser [EMAIL PROTECTED] wrote: -int scm_send(struct socket *sock, struct msghdr *msg, struct scm_cookie *scm) -{ -struct task_struct *p = current; -scm-creds = (struct ucred) { -.uid = p-uid, -.gid = p-gid, -.pid = p-tgid -};

Re: [patch 1/2] git-net: ebtables fix

2006-03-12 Thread Andrew Morton
[EMAIL PROTECTED] wrote: +.set_optmax = EBT_SO_SET_MAX + 1 +.set= do_ebt_set_ctl, It's unclear why that compiled. Let me try again. - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at

Re: [PATCH 2/8] [I/OAT] Driver for the Intel(R) I/OAT DMA engine

2006-03-12 Thread Andrew Morton
Evgeniy Polyakov [EMAIL PROTECTED] wrote: On Fri, Mar 10, 2006 at 06:29:46PM -0800, Leech, Christopher ([EMAIL PROTECTED]) wrote: From: Chris Leech [mailto:[EMAIL PROTECTED] Sent: Friday, March 10, 2006 6:29 PM To: Subject: [PATCH 2/8] [I/OAT] Driver for the Intel(R) I/OAT DMA

Re: [patch 1/1] git-net: export security_sid_to_context()

2006-03-12 Thread Andrew Morton
James Morris [EMAIL PROTECTED] wrote: On Sun, 12 Mar 2006, [EMAIL PROTECTED] wrote: Cc: Stephen Smalley [EMAIL PROTECTED] Cc: James Morris [EMAIL PROTECTED] Signed-off-by: Andrew Morton [EMAIL PROTECTED] These SELinux symbols should not be directly exported (if you need

Re: [PATCH 1/8] [I/OAT] DMA memcpy subsystem

2006-03-11 Thread Andrew Morton
Chris Leech [EMAIL PROTECTED] wrote: +void dma_async_device_cleanup(struct kref *kref); Declarations go in header files, please. Or give it static scope. - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at

Re: [PATCH 3/8] [I/OAT] Setup the networking subsystem as a DMA client

2006-03-11 Thread Andrew Morton
Chris Leech [EMAIL PROTECTED] wrote: There seems to be a small race here. +static void net_dma_rebalance(void) +{ +unsigned int cpu, i, n; +struct dma_chan *chan; + +lock_cpu_hotplug(); + +if (net_dma_count == 0) { +for_each_online_cpu(cpu) +

Re: [PATCH 3/8] [I/OAT] Setup the networking subsystem as a DMA client

2006-03-11 Thread Andrew Morton
Chris Leech [EMAIL PROTECTED] wrote: +#ifdef CONFIG_NET_DMA +#include linux/dmaengine.h +#endif There are still a number of instances of this in the patch series. Did you decide to keep the ifdefs in there for some reason? - To unsubscribe from this list: send the line unsubscribe netdev

Re: [PATCH 8/8] [I/OAT] TCP recv offload to I/OAT

2006-03-11 Thread Andrew Morton
Chris Leech [EMAIL PROTECTED] wrote: Locks down user pages and sets up for DMA in tcp_recvmsg, then calls dma_async_try_early_copy in tcp_v4_do_rcv All those ifdefs are still there. They really do put a maintenance burden on, of all places, net/ipv4/tcp.c. Please find a way of abstracting

Re: [PATCH] fix spidernet build issue

2006-03-10 Thread Andrew Morton
Jens Osterkamp [EMAIL PROTECTED] wrote: This patch fixes a spidernet build issue found in 2.6.16-rc5-mm2. What build issue? The duplicate symbols? I forget what they were, actually. It really helps if you can include the compiler/linker error messages when fixing build problems please.

Re: [PATCH] tcp: bigger congestion window for loopback

2006-03-09 Thread Andrew Morton
David S. Miller [EMAIL PROTECTED] wrote: Like Sun is going to give me the source?... And if Sun doesn't support their userland products well that is somehow the Linux kernel's problem? Presumably they tested this on Solaris and it ran OK. Maybe Solaris (and Windows?) have special-case

Re: [patch 1/4] net: percpufy frequently used vars -- add percpu_counter_mod_bh

2006-03-08 Thread Andrew Morton
Ravikiran G Thirumalai [EMAIL PROTECTED] wrote: On Wed, Mar 08, 2006 at 04:17:33PM -0500, Benjamin LaHaise wrote: On Wed, Mar 08, 2006 at 01:07:26PM -0800, Ravikiran G Thirumalai wrote: Last time I checked, all the major architectures had efficient local_t implementations. Most of the

Re: [patch 1/4] net: percpufy frequently used vars -- add percpu_counter_mod_bh

2006-03-08 Thread Andrew Morton
Andrew Morton [EMAIL PROTECTED] wrote: Once decrapify-asm-generic-localh.patch is merged I think all architectures can and should use asm-generic/local.h. err, no. Because that's just atomic_long_t, and that's a locked instruction. We need to review and fix up those architectures which have

Re: [patch 1/4] net: percpufy frequently used vars -- add percpu_counter_mod_bh

2006-03-08 Thread Andrew Morton
Benjamin LaHaise [EMAIL PROTECTED] wrote: On Wed, Mar 08, 2006 at 02:25:28PM -0800, Ravikiran G Thirumalai wrote: Then, for the batched percpu_counters, we could gain by using local_t only for the UP case. But we will have to have a new local_long_t implementation for that. Do you

Re: [patch 1/4] net: percpufy frequently used vars -- add percpu_counter_mod_bh

2006-03-08 Thread Andrew Morton
Ravikiran G Thirumalai [EMAIL PROTECTED] wrote: On Wed, Mar 08, 2006 at 03:43:21PM -0800, Andrew Morton wrote: Benjamin LaHaise [EMAIL PROTECTED] wrote: I think it may make more sense to simply convert local_t into a long, given that most of the users will be things like stats

Re: [patch 1/4] net: percpufy frequently used vars -- add percpu_counter_mod_bh

2006-03-08 Thread Andrew Morton
Andi Kleen [EMAIL PROTECTED] wrote: Andrew Morton [EMAIL PROTECTED] writes: x86_64 is signed 32-bit! I'll change it. You want signed 64bit? Well it's all random at present. Since the API is defined as unsigned I guess it's be best to make it unsigned for now. Later, when someone

Re: [Bugme-new] [Bug 6177] New: Java remote debugging is slow due to apparent networking bug

2006-03-07 Thread Andrew Morton
uploaded it to http://www.zip.com.au/~akpm/linux/patches/stuff/debug.dump.gz On 3/6/06, Andrew Morton [EMAIL PROTECTED] wrote: [EMAIL PROTECTED] wrote: http://bugzilla.kernel.org/show_bug.cgi?id=6177 Summary: Java remote debugging is slow due to apparent networking

Re: [Bugme-new] [Bug 6186] New: net/ipv4/route.c: use after free in rt_fill_info

2006-03-07 Thread Andrew Morton
[EMAIL PROTECTED] wrote: http://bugzilla.kernel.org/show_bug.cgi?id=6186 Summary: net/ipv4/route.c: use after free in rt_fill_info Kernel Version: 2.6.16-git Status: NEW Severity: normal Owner: [EMAIL PROTECTED] Submitter: [EMAIL

Re: [Bugme-new] [Bug 6187] New: netlink: possible use after free in netlink_recvmsg

2006-03-07 Thread Andrew Morton
[EMAIL PROTECTED] wrote: http://bugzilla.kernel.org/show_bug.cgi?id=6187 Summary: netlink: possible use after free in netlink_recvmsg Kernel Version: 2.6.16-git Status: NEW Severity: normal Owner: [EMAIL PROTECTED] Submitter:

Re: [patch 1/4] net: percpufy frequently used vars -- add percpu_counter_mod_bh

2006-03-07 Thread Andrew Morton
Ravikiran G Thirumalai [EMAIL PROTECTED] wrote: +static inline void percpu_counter_mod_bh(struct percpu_counter *fbc, long amount) +{ +local_bh_disable(); +percpu_counter_mod(fbc, amount); +local_bh_enable(); +} + percpu_counter_mod() does preempt_disable(), which is

Re: [patch 2/4] net: percpufy frequently used vars -- struct proto.memory_allocated

2006-03-07 Thread Andrew Morton
Ravikiran G Thirumalai [EMAIL PROTECTED] wrote: - if (atomic_read(sk-sk_prot-memory_allocated) sk-sk_prot-sysctl_mem[0]) { +if (percpu_counter_read(sk-sk_prot-memory_allocated) +sk-sk_prot-sysctl_mem[0]) { Bear in mind that percpu_counter_read[_positive] can

Re: [patch 3/4] net: percpufy frequently used vars -- proto.sockets_allocated

2006-03-07 Thread Andrew Morton
Ravikiran G Thirumalai [EMAIL PROTECTED] wrote: --- linux-2.6.16-rc5mm3.orig/include/net/sock.h 2006-03-07 15:09:22.0 -0800 +++ linux-2.6.16-rc5mm3/include/net/sock.h 2006-03-07 15:09:52.0 -0800 @@ -543,7 +543,7 @@ struct proto { /* Memory pressure */

Re: [patch 2/4] net: percpufy frequently used vars -- struct proto.memory_allocated

2006-03-07 Thread Andrew Morton
Ravikiran G Thirumalai [EMAIL PROTECTED] wrote: On Tue, Mar 07, 2006 at 06:14:22PM -0800, Andrew Morton wrote: Ravikiran G Thirumalai [EMAIL PROTECTED] wrote: - if (atomic_read(sk-sk_prot-memory_allocated) sk-sk_prot-sysctl_mem[0]) { +if (percpu_counter_read(sk-sk_prot

spider_net versus sungem_phy

2006-03-06 Thread Andrew Morton
drivers/net/spider_net.c:421: multiple definition of `mii_phy_probe' drivers/net/sungem_phy.o(.opd+0x160):drivers/net/sungem_phy.c:95: first defined here - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at

Re: [PATCH] avoid atomic op on page free

2006-03-06 Thread Andrew Morton
Benjamin LaHaise [EMAIL PROTECTED] wrote: Hello Andrew et al, The patch below adds a fast path that avoids the atomic dec and test operation and spinlock acquire/release on page free. This is especially important to the network stack which uses put_page() to free user buffers.

Re: [PATCH] avoid atomic op on page free

2006-03-06 Thread Andrew Morton
Benjamin LaHaise [EMAIL PROTECTED] wrote: On Mon, Mar 06, 2006 at 04:50:39PM -0800, Andrew Morton wrote: Am a bit surprised at those numbers. Because userspace has to do peculiar things to get its pages taken off the LRU. What exactly was that application doing? It's just a simple

Re: [Bugme-new] [Bug 6177] New: Java remote debugging is slow due to apparent networking bug

2006-03-06 Thread Andrew Morton
[EMAIL PROTECTED] wrote: http://bugzilla.kernel.org/show_bug.cgi?id=6177 Summary: Java remote debugging is slow due to apparent networking bug Kernel Version: 2.6.15 Status: NEW Severity: normal Owner: [EMAIL

Re: [PATCH] net: Move destructor from neigh-ops to neigh_params

2006-03-06 Thread Andrew Morton
Roland Dreier [EMAIL PROTECTED] wrote: struct neigh_ops currently has a destructor field, which no in-kernel drivers outside of infiniband use. net/atm/clip.c begs to disagree. I'm also wondering why a combination of the net and infiniband trees does this:

Re: [PATCH 0/8] Intel I/O Acceleration Technology (I/OAT)

2006-03-05 Thread Andrew Morton
Chris Leech [EMAIL PROTECTED] wrote: Patch #2 didn't make it. Too big for the list? Could be, it's the largest of the series. I've attached the gziped patch. I can try and split this up for the future. .. [I/OAT] Driver for the Intel(R) I/OAT DMA engine Adds a new ioatdma driver

Re: [PATCH 8/8] [I/OAT] TCP recv offload to I/OAT

2006-03-05 Thread Andrew Morton
Chris Leech [EMAIL PROTECTED] wrote: +#ifdef CONFIG_NET_DMA +tp-ucopy.dma_chan = NULL; +if ((len sysctl_tcp_dma_copybreak) !(flags MSG_PEEK) !sysctl_tcp_low_latency __get_cpu_var(softnet_data.net_dma)) +dma_lock_iovec_pages(msg-msg_iov, len,

Fw: [Bugme-new] [Bug 6167] New: tg3 oops from tg3_rx

2006-03-05 Thread Andrew Morton
Begin forwarded message: Date: Sun, 5 Mar 2006 08:11:23 -0800 From: [EMAIL PROTECTED] To: [EMAIL PROTECTED] Subject: [Bugme-new] [Bug 6167] New: tg3 oops from tg3_rx http://bugzilla.kernel.org/show_bug.cgi?id=6167 Summary: tg3 oops from tg3_rx Kernel Version: 2.6.15

Re: [PATCH 4/8] [I/OAT] Utility functions for offloading sk_buff to iovec copies

2006-03-04 Thread Andrew Morton
Chris Leech [EMAIL PROTECTED] wrote: + +#define NUM_PAGES_SPANNED(start, length) \ + ((PAGE_ALIGN((unsigned long)start + length) - \ + ((unsigned long)start PAGE_MASK)) PAGE_SHIFT) static inline all-lower-case functions are much nicer. +/* + * Lock down all the iovec pages

Re: [PATCH 5/8] [I/OAT] Structure changes for TCP recv offload to I/OAT

2006-03-04 Thread Andrew Morton
Chris Leech [EMAIL PROTECTED] wrote: +#ifdef CONFIG_NET_DMA +#include linux/dmaengine.h +#endif Please move the ifdefs into the header and include it unconditionally (entire patchset). - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL

Re: [PATCH 7/8] [I/OAT] Add a sysctl for tuning the I/OAT offloaded I/O threshold

2006-03-04 Thread Andrew Morton
Chris Leech [EMAIL PROTECTED] wrote: Any socket recv of less than this ammount will not be offloaded ... +int sysctl_tcp_dma_copybreak = NET_DMA_DEFAULT_COPYBREAK; Is it appropriate that this tunable be kernel-wide, rather than more finely-grained? - To unsubscribe from this list: send

Re: [PATCH 8/8] [I/OAT] TCP recv offload to I/OAT

2006-03-04 Thread Andrew Morton
Chris Leech [EMAIL PROTECTED] wrote: Locks down user pages and sets up for DMA in tcp_recvmsg, then calls dma_async_try_early_copy in tcp_v4_do_rcv +#ifdef CONFIG_NET_DMA +#ifdef CONFIG_NET_DMA +#ifdef CONFIG_NET_DMA +#ifdef CONFIG_NET_DMA +#ifdef CONFIG_NET_DMA +#ifdef CONFIG_NET_DMA

verify_sec_ctx_len() warning

2006-03-03 Thread Andrew Morton
net/xfrm/xfrm_user.c: In function `verify_sec_ctx_len': net/xfrm/xfrm_user.c:104: warning: comparison is always false due to limited range of data type if (sec_ctx-sadb_x_ctx_len PAGE_SIZE) PAGE_SIZE is 64k on powerpc, and that's a 16-bit variable. - To unsubscribe from this list: send

Re: [PATCH netdev-2.6 00/19] e1000: driver update (upstream)

2006-03-03 Thread Andrew Morton
Jeff Garzik [EMAIL PROTECTED] wrote: git://198.78.49.142/linux-2.6.git e1000-upstream Pulled into netdev#upstream, thanks! Did we fix wake-on-lan? - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at

Fw: [Bugme-new] [Bug 6121] New: TCP_DEFER_ACCEPT is reset on listen() call

2006-02-23 Thread Andrew Morton
Begin forwarded message: Date: Thu, 23 Feb 2006 07:26:28 -0800 From: [EMAIL PROTECTED] To: [EMAIL PROTECTED] Subject: [Bugme-new] [Bug 6121] New: TCP_DEFER_ACCEPT is reset on listen() call http://bugzilla.kernel.org/show_bug.cgi?id=6121 Summary: TCP_DEFER_ACCEPT is reset on

Re: [PATCH] keep track of network interface renaming

2006-02-18 Thread Andrew Morton
Olaf Hering [EMAIL PROTECTED] wrote: honeydew:~ # dmesg| grep -Ew '(eth[0-9]|rename|renamed)' e1000: eth0: e1000_probe: Intel(R) PRO/1000 Network Connection e1000: eth1: e1000_probe: Intel(R) PRO/1000 Network Connection e1000: eth2: e1000_probe: Intel(R) PRO/1000 Network Connection

Re: [RFT/PATCH] 3c509: use proper suspend/resume API

2006-02-15 Thread Andrew Morton
Pekka Enberg [EMAIL PROTECTED] wrote: I am looking for someone with 3c509 netword card that can do suspend/resume to test this patch. I have a 3c509, and I'm not afraid to use it! Problem is, it doesn't resume correctly either with or without the patch: it needs rmmod+modprobe to get it

Re: [RFT/PATCH] 3c509: use proper suspend/resume API

2006-02-15 Thread Andrew Morton
Pekka J Enberg [EMAIL PROTECTED] wrote: On Wed, 15 Feb 2006, Andrew Morton wrote: I have a 3c509, and I'm not afraid to use it! Problem is, it doesn't resume correctly either with or without the patch: it needs rmmod+modprobe to get it going again. (Which is better than the aic7xxx

Re: [RFT/PATCH] 3c509: use proper suspend/resume API

2006-02-15 Thread Andrew Morton
Pekka J Enberg [EMAIL PROTECTED] wrote: Hi Andrew, On Wed, 15 Feb 2006, Andrew Morton wrote: Problem is, it doesn't resume correctly either with or without the patch: it needs rmmod+modprobe to get it going again. (Which is better than the aic7xxx driver, which has a coronary

Fw: [Bugme-new] [Bug 6068] New: UDP packet loss and slow communication

2006-02-13 Thread Andrew Morton
Begin forwarded message: Date: Mon, 13 Feb 2006 14:21:57 -0800 From: [EMAIL PROTECTED] To: [EMAIL PROTECTED] Subject: [Bugme-new] [Bug 6068] New: UDP packet loss and slow communication http://bugzilla.kernel.org/show_bug.cgi?id=6068 Summary: UDP packet loss and slow communication

Fw: [Bugme-new] [Bug 6062] New: poor thoughput on broadcom 5704 using tg3

2006-02-12 Thread Andrew Morton
Begin forwarded message: Date: Sun, 12 Feb 2006 15:34:50 -0800 From: [EMAIL PROTECTED] To: [EMAIL PROTECTED] Subject: [Bugme-new] [Bug 6062] New: poor thoughput on broadcom 5704 using tg3 http://bugzilla.kernel.org/show_bug.cgi?id=6062 Summary: poor thoughput on broadcom 5704

Fw: [Bugme-new] [Bug 6036] New: mmap'ed write to socket hangs when connection remote end is broken

2006-02-09 Thread Andrew Morton
Begin forwarded message: Date: Thu, 9 Feb 2006 06:46:33 -0800 From: [EMAIL PROTECTED] To: [EMAIL PROTECTED] Subject: [Bugme-new] [Bug 6036] New: mmap'ed write to socket hangs when connection remote end is broken http://bugzilla.kernel.org/show_bug.cgi?id=6036 Summary: mmap'ed

Fw: Assert: CPU #..., mangle/filter comefrom(....) = ...

2006-02-08 Thread Andrew Morton
Begin forwarded message: Date: Thu, 09 Feb 2006 06:10:49 +0100 From: Knut Petersen [EMAIL PROTECTED] To: linux-kernel@vger.kernel.org Subject: Assert: CPU #..., mangle/filter comefrom() = ... As there probably is a reason to printk assertions: [ 28.616455] ADDRCONF(NETDEV_CHANGE):

Re: Linux 2.6.15.2

2006-02-03 Thread Andrew Morton
Holger Eitzenberger [EMAIL PROTECTED] wrote: On Mon, Jan 30, 2006 at 11:34:27PM -0800, Andrew Morton wrote: - A skbuff_head_cache leak causes oom-killings. All of these only seem to affect a small minority of machines. Hi, I have searched for a description for the above mentioned

Re: [patch 3/4] net: Percpufy frequently used variables -- proto.sockets_allocated

2006-02-03 Thread Andrew Morton
Ravikiran G Thirumalai [EMAIL PROTECTED] wrote: On Thu, Feb 02, 2006 at 07:16:00PM -0800, Andrew Morton wrote: Ravikiran G Thirumalai [EMAIL PROTECTED] wrote: On Fri, Jan 27, 2006 at 03:01:06PM -0800, Andrew Morton wrote: Here's an implementation which delegates tuning of batching

open bugzilla reports

2006-02-03 Thread Andrew Morton
This is a listing of the 263 bugzilla records which I felt worth keeping an eye on. It would be appreciated if the various maintenance teams could take a look, close off any which are fixed and see if we can fix any which aren't. There's probably not a lot of point in replying to this email for

Fw: [Bugme-new] [Bug 5999] New: Iptables modules fail to load on Alpha arch

2006-02-02 Thread Andrew Morton
Odd. Not sure what the Could not allocate 60 bytes percpu data is due to, either. Begin forwarded message: Date: Thu, 2 Feb 2006 15:13:29 -0800 From: [EMAIL PROTECTED] To: [EMAIL PROTECTED] Subject: [Bugme-new] [Bug 5999] New: Iptables modules fail to load on Alpha arch

Re: [patch 3/4] net: Percpufy frequently used variables -- proto.sockets_allocated

2006-02-02 Thread Andrew Morton
Ravikiran G Thirumalai [EMAIL PROTECTED] wrote: On Fri, Jan 27, 2006 at 03:01:06PM -0800, Andrew Morton wrote: Ravikiran G Thirumalai [EMAIL PROTECTED] wrote: If the benchmarks say that we need to. If we cannot observe any problems in testing of existing code and if we

Re: net-2.6.17.git crashes

2006-02-01 Thread Andrew Morton
David S. Miller [EMAIL PROTECTED] wrote: From: Andrew Morton [EMAIL PROTECTED] Date: Tue, 31 Jan 2006 23:40:33 -0800 It's still oopsing, with slab poisoning enabled. Does this patch help? yup. - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message

Re: net-2.6.17.git crashes

2006-01-31 Thread Andrew Morton
David S. Miller [EMAIL PROTECTED] wrote: From: Andrew Morton [EMAIL PROTECTED] Date: Sat, 28 Jan 2006 17:22:40 -0800 David, your tree git+ssh://master.kernel.org/pub/scm/linux/kernel/git/davem/net-2.6.17.git is oopsing all over the place. Reverting [NET]: Do not lose accepted

Re: [patch 3/4] net: Percpufy frequently used variables -- proto.sockets_allocated

2006-01-28 Thread Andrew Morton
Benjamin LaHaise [EMAIL PROTECTED] wrote: On Sat, Jan 28, 2006 at 01:28:20AM +0100, Eric Dumazet wrote: We might use atomic_long_t only (and no spinlocks) Something like this ? Erk, complex and slow... Try using local_t instead, which is substantially cheaper on the P4 as it doesn't

net-2.6.17.git crashes

2006-01-28 Thread Andrew Morton
David, your tree git+ssh://master.kernel.org/pub/scm/linux/kernel/git/davem/net-2.6.17.git is oopsing all over the place. Reverting [NET]: Do not lose accepted socket when -ENFILE/-EMFILE. makes it stop: diff -puN net/socket.c~0001-NET-Do-not-lose-accepted-socket-when-ENFILE-EMFILE

Re: [patch 3/4] net: Percpufy frequently used variables -- proto.sockets_allocated

2006-01-28 Thread Andrew Morton
Benjamin LaHaise [EMAIL PROTECTED] wrote: On Sat, Jan 28, 2006 at 04:55:49PM -0800, Andrew Morton wrote: local_t isn't much use until we get rid of asm-generic/local.h. Bloaty, racy with nested interrupts. The overuse of atomics is horrific in what is being proposed. Well yeah

Re: [patch 3/4] net: Percpufy frequently used variables -- proto.sockets_allocated

2006-01-27 Thread Andrew Morton
Andrew Morton [EMAIL PROTECTED] wrote: Oh, and because vm_acct_memory() is counting a singleton object, it can use DEFINE_PER_CPU rather than alloc_percpu(), so it saves on a bit of kmalloc overhead. Actually, I don't think that's true. we're allocating a sizeof(long) with kmalloc_node() so

Re: [patch 3/4] net: Percpufy frequently used variables -- proto.sockets_allocated

2006-01-27 Thread Andrew Morton
Ravikiran G Thirumalai [EMAIL PROTECTED] wrote: On Fri, Jan 27, 2006 at 12:16:02PM -0800, Andrew Morton wrote: Ravikiran G Thirumalai [EMAIL PROTECTED] wrote: which can be assumed as not frequent. At sk_stream_mem_schedule(), read_sockets_allocated() is invoked only certain

Re: [patch 3/4] net: Percpufy frequently used variables -- proto.sockets_allocated

2006-01-27 Thread Andrew Morton
Ravikiran G Thirumalai [EMAIL PROTECTED] wrote: On Fri, Jan 27, 2006 at 03:08:47PM -0800, Andrew Morton wrote: Andrew Morton [EMAIL PROTECTED] wrote: Oh, and because vm_acct_memory() is counting a singleton object, it can use DEFINE_PER_CPU rather than alloc_percpu(), so it saves

Re: [patch 3/4] net: Percpufy frequently used variables -- proto.sockets_allocated

2006-01-27 Thread Andrew Morton
Eric Dumazet [EMAIL PROTECTED] wrote: [PATCH] Add atomic_long_xchg() and atomic_long_cmpxchg() wrappers ... +static inline long atomic_long_xchg(atomic_long_t *l, long val) +{ + atomic64_t *v = (atomic64_t *)l; + return atomic64_xchg(v, val); All we need now is some

Fw: [Bugme-new] [Bug 5946] New: KERNEL: assertion (!sk-sk_forward_alloc) failed at net/core/stream.c (279)

2006-01-24 Thread Andrew Morton
Begin forwarded message: Date: Tue, 24 Jan 2006 00:11:51 -0800 From: [EMAIL PROTECTED] To: [EMAIL PROTECTED] Subject: [Bugme-new] [Bug 5946] New: KERNEL: assertion (!sk-sk_forward_alloc) failed at net/core/stream.c (279) http://bugzilla.kernel.org/show_bug.cgi?id=5946 Summary:

Re: [PATCH] tulip: Make ALi (ULi) integrated 100BaseTX Ethernet work

2006-01-23 Thread Andrew Morton
Olaf Hering [EMAIL PROTECTED] wrote: We carry this patch since 2005-03-13. Jiri, can you check if 2.6.16 still doesnt work for you on this sort of hardware? I did not find a bugzilla nor a better description. Doesn't compile. + if (tp-chip_id == ULI526X) { ULI526X isn't defined and

Re: the dreaded oom-killer (reproducable in 2.6.11 - 2.6.16-rc1) :(

2006-01-23 Thread Andrew Morton
(cc'ing netdev with permission) [EMAIL PROTECTED] wrote: We have a set of machines that have been usually hanging seconds after reporting an oom-killer: gfp_mask=0xd1, order=0. We've tried variations of kernels from 2.6.11 through 2.6.16-rc1, with and without PAE enabled, all seem to

Fw: [Bugme-new] [Bug 5936] New: Openswan tunnels + netfilter problem

2006-01-22 Thread Andrew Morton
Begin forwarded message: Date: Sun, 22 Jan 2006 12:02:22 -0800 From: [EMAIL PROTECTED] To: [EMAIL PROTECTED] Subject: [Bugme-new] [Bug 5936] New: Openswan tunnels + netfilter problem http://bugzilla.kernel.org/show_bug.cgi?id=5936 Summary: Openswan tunnels + netfilter problem

Fw: oops in 2.6.15.1 x86_64/ipv6

2006-01-21 Thread Andrew Morton
Begin forwarded message: Date: Thu, 19 Jan 2006 11:53:08 -0500 (EST) From: Gerhard Mack [EMAIL PROTECTED] To: linux-kernel@vger.kernel.org Subject: oops in 2.6.15.1 x86_64/ipv6 The system is a dual 3ghz Xeon blade running an amd64 install of debian with the kernel upgraded to 2.6.15.1. The

Fw: [Bugme-new] [Bug 5803] New: Bridge code Oops with 2.6.14.2

2006-01-20 Thread Andrew Morton
Looks like br_netfilter went splat. Begin forwarded message: Date: Sat, 31 Dec 2005 09:23:40 -0800 From: [EMAIL PROTECTED] To: [EMAIL PROTECTED] Subject: [Bugme-new] [Bug 5803] New: Bridge code Oops with 2.6.14.2 http://bugzilla.kernel.org/show_bug.cgi?id=5803 Summary: Bridge

Fw: [Bugme-new] [Bug 5627] New: Network boot - IP-Config reports wrong DHCP server address

2006-01-19 Thread Andrew Morton
Begin forwarded message: Date: Fri, 18 Nov 2005 10:42:33 -0800 From: [EMAIL PROTECTED] To: [EMAIL PROTECTED] Subject: [Bugme-new] [Bug 5627] New: Network boot - IP-Config reports wrong DHCP server address http://bugzilla.kernel.org/show_bug.cgi?id=5627 Summary: Network boot -

Fw: [Bugme-new] [Bug 5695] New: pppd hangs after disconnect on tty_set_ldisc when sch_htb used

2006-01-19 Thread Andrew Morton
Begin forwarded message: Date: Fri, 2 Dec 2005 13:53:04 -0800 From: [EMAIL PROTECTED] To: [EMAIL PROTECTED] Subject: [Bugme-new] [Bug 5695] New: pppd hangs after disconnect on tty_set_ldisc when sch_htb used http://bugzilla.kernel.org/show_bug.cgi?id=5695 Summary: pppd hangs

Re: [Bugme-new] [Bug 5927] New: TG3 driver unable to get memory resource

2006-01-19 Thread Andrew Morton
[EMAIL PROTECTED] wrote: http://bugzilla.kernel.org/show_bug.cgi?id=5927 Summary: TG3 driver unable to get memory resource Kernel Version: 2.6.15.1 Status: NEW Severity: normal Owner: [EMAIL PROTECTED] Submitter: [EMAIL

Re: e1000 breakage in Jeff's tree

2006-01-18 Thread Andrew Morton
Jeff Garzik [EMAIL PROTECTED] wrote: Andrew Morton wrote: It'd be easier for me to just pull the bare patches out of git. But I haven't yet worked out how to persuade git to do that in a sane fashion (help) I use 'git-diff-tree -p $hash' I seemed to screw that up and got a bunch

Re: [git patches] e1000 fixes

2006-01-18 Thread Andrew Morton
Jeff Garzik [EMAIL PROTECTED] wrote: Let's see how this goes... if there are further problems, I'll just revert the entire thing, and push these changes (and the previous set) into upstream-2.6.17 branch. I don't mind them updating the defconfig files, even though most people are too

Re: e1000 breakage in Jeff's tree

2006-01-18 Thread Andrew Morton
Jesse Brandeburg [EMAIL PROTECTED] wrote: On Wed, 18 Jan 2006, Andrew Morton wrote: git-bisect of mainline claims that the regression was introduced by commit 0fadb0597d240d4ed279042cab632d567510a1a3, e1000: Fix collision distance. Jeff(K), I can test patches... it appears git bisect

Re: [patch] 3c59x: improve usage of netif_carrier_{on,off}

2006-01-17 Thread Andrew Morton
Steffen Klassert [EMAIL PROTECTED] wrote: The patch _should_ do the following: 1. Set the polling intervall for media changes to 5 seconds if link is down and 60 seconds if link is up. 2. Handle netif_carrier_{on,of} and check for media changes in proper way by using

Re: e1000 breakage in Jeff's tree

2006-01-17 Thread Andrew Morton
Jeff Garzik [EMAIL PROTECTED] wrote: Andrew Morton wrote: The e1000 changes which popped up in Jeff's netdev tree today break the driver on my emt64 box. There's no real sign of damage apart from the fact that it simply won't send stuff. e1000: :01:02.0: e1000_probe: (PCI:33MHz

Re: [2.6.15] running tcpdump on 3c905b causes freeze (reproducable)

2006-01-14 Thread Andrew Morton
Folkert van Heusden [EMAIL PROTECTED] wrote: Have you tried enabling the NMI watchdog? Enable CONFIG_X86_LOCAL_APIC and boot with `nmi_watchdog=1' on the command line, make sure that the NMI line of /proc/interrupts is incrementing. I'll give it a try. I've added

Re: 2.6.15-mm3

2006-01-12 Thread Andrew Morton
Rafael J. Wysocki [EMAIL PROTECTED] wrote: Hi, On Wednesday, 11 January 2006 13:21, Andrew Morton wrote: ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.15/2.6.15-mm3/ I got that on system shutdown (x86-64, 1 CPU): Thanks. ipv6 died. I think shemminger had

Re: [git patches] 2.6.x net driver updates

2006-01-12 Thread Andrew Morton
Linus Torvalds [EMAIL PROTECTED] wrote: On Thu, 12 Jan 2006, Jeff Garzik wrote: dann frazier: CONFIG_AIRO needs CONFIG_CRYPTO I think this is done wrong. It should select CRYPTO rather than depends on CRYPTO. Otherwise people won't see it just because they don't have

<    4   5   6   7   8   9   10   >