Re: [PATCH 1/5] device property: helper macros for property entry creation

2015-08-05 Thread Andy Shevchenko
property_set - Collection of built-in device properties. * @fwnode: Handle to be pointed to by the fwnode field of struct device. -- Andy Shevchenko andriy.shevche...@linux.intel.com Intel Finland Oy -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message

Re: [PATCH 2/5] net: rfkill: add rfkill_find_type function

2015-08-05 Thread Andy Shevchenko
-type]); if (error) return error; spin_lock_irqsave(rfkill-lock, flags); -- Andy Shevchenko andriy.shevche...@linux.intel.com Intel Finland Oy -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to majord...@vger.kernel.org More

Re: [PATCH 5/5] net: rfkill: gpio: remove rfkill_gpio_platform_data

2015-08-05 Thread Andy Shevchenko
= pdata-name; - rfkill-type = pdata-type; - } else { - return -ENODEV; Shouldn't we leave the error path and modify to check if we have device property set set? } rfkill-clk = devm_clk_get(pdev-dev, NULL); -- Andy Shevchenko andriy.shevche

Re: [PATCH 1/2] iwlwifi: convert hex_dump_to_buffer() to %*ph

2015-08-04 Thread Andy Shevchenko
On Thu, 2015-07-16 at 15:42 +0300, Andy Shevchenko wrote: There is no need to use hex_dump_to_buffer() in the cases like this: hexdump_to_buffer(buf, len, 16, 1, outbuf, outlen, false); /* len = 16 */ sprintf(%s\n, outbuf); since it maybe easily converted to simple

Null pointer dereference in UDP4 core on AVR32 ATNGW100

2015-07-31 Thread Andy Shevchenko
is not supporting anymore avr32 I use the version just before this removal. (Nicolas, does Atmel care about that?) -- With Best Regards, Andy Shevchenko -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to majord...@vger.kernel.org More majordomo info at http

Re: Null pointer dereference in UDP4 core on AVR32 ATNGW100

2015-07-31 Thread Andy Shevchenko
On Fri, Jul 31, 2015 at 4:25 PM, Andy Shevchenko andy.shevche...@gmail.com wrote: Hi! Got few weeks ago an old AVR32 board (ATNGW100). It has ethernet cards supported by macb driver. Bring it mostly back to work with recent kernel from linux-next. Now, when I start networking on it, I got

Re: Null pointer dereference in UDP4 core on AVR32 ATNGW100

2015-07-31 Thread Andy Shevchenko
: 256 (order: 0, 4096 bytes) UDP-Lite hash table entries: 256 (order: 0, 4096 bytes) futex hash table entries: 16 (order: -5, 192 bytes) On Fri, Jul 31, 2015 at 3:45 PM, Andy Shevchenko andy.shevche...@gmail.com wrote: On Fri, Jul 31, 2015 at 4:25 PM, Andy Shevchenko andy.shevche...@gmail.com

Re: [net:master 41/49] drivers/net/ethernet/cadence/macb.c:164:1: error: macro writel passed 3 arguments, but takes just 2

2015-07-27 Thread Andy Shevchenko
2012-10-31 105 } 55054a16a drivers/net/ethernet/cadence/macb.c Havard Skinnemoen 2012-10-31 106 f2ce8a9e4 drivers/net/ethernet/cadence/macb.c Andy Shevchenko 2015-07-24 107 /* I/O accessors */ f2ce8a9e4 drivers/net/ethernet/cadence/macb.c

[PATCH v1 1/6] net/macb: improve big endian CPU support

2015-07-24 Thread Andy Shevchenko
. Fixes: a50dad355a53 (net: macb: Add big endian CPU support) Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com --- drivers/net/ethernet/cadence/macb.c | 103 ++-- drivers/net/ethernet/cadence/macb.h | 28 -- 2 files changed, 87 insertions

[PATCH v1 6/6] net/macb: convert to kernel doc

2015-07-24 Thread Andy Shevchenko
This patch coverts struct description to the kernel doc format. There is no functional change. Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com --- include/linux/platform_data/macb.h | 14 +++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/include/linux

[PATCH v1 4/6] net/macb: suppress compiler warnings

2015-07-24 Thread Andy Shevchenko
‘gem_get_ethtool_strings’: drivers/net/ethernet/cadence/macb.c:1988: warning: comparison between signed and unsigned Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com --- drivers/net/ethernet/cadence/macb.c | 5 ++--- drivers/net/ethernet/cadence/macb.h | 6 +++--- 2 files changed, 5

[PATCH v1 0/6] net/macb: fix for AVR32 and clean up

2015-07-24 Thread Andy Shevchenko
It seems no one had tested recently the driver on AVR32 platforms such as ATNGW100. This series bring it back to work. Andy Shevchenko (6): net/macb: improve big endian CPU support net/macb: check if macb_config present net/macb: use dev_*() when netdev is not yet registered net/macb

[PATCH v1 5/6] net/macb: replace macb_count_tx_descriptors() by DIV_ROUND_UP()

2015-07-24 Thread Andy Shevchenko
macb_count_tx_descriptors() repeats the generic macro DIV_ROUND_UP(). The patch does a replacement. There is no functional change. Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com --- drivers/net/ethernet/cadence/macb.c | 10 ++ 1 file changed, 2 insertions(+), 8

[PATCH v1 2/6] net/macb: check if macb_config present

2015-07-24 Thread Andy Shevchenko
for jumbo frames) Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com --- drivers/net/ethernet/cadence/macb.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/ethernet/cadence/macb.c b/drivers/net/ethernet/cadence/macb.c index 6980115..7986778 100644

[PATCH v1 3/6] net/macb: use dev_*() when netdev is not yet registered

2015-07-24 Thread Andy Shevchenko
To avoid messages like macb macb.0 (unnamed net_device) (uninitialized): Cadence caps 0x macb macb.0 (unnamed net_device) (uninitialized): invalid hw address, using random let's use dev_*() macros. Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com --- drivers/net

[PATCH 1/2] iwlwifi: convert hex_dump_to_buffer() to %*ph

2015-07-16 Thread Andy Shevchenko
the output is groupped by 2 bytes and looks like a typo. Thus, patch changes that to plain byte stream. Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com --- drivers/net/wireless/iwlwifi/dvm/debugfs.c | 8 ++-- drivers/net/wireless/iwlwifi/mvm/debugfs.c | 7 +-- 2 files

[PATCH 2/2] iwlegacy: convert hex_dump_to_buffer() to %*ph

2015-07-16 Thread Andy Shevchenko
the output is groupped by 2 bytes and looks like a typo. Thus, patch changes that to plain byte stream. Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com --- drivers/net/wireless/iwlegacy/3945-mac.c | 2 +- drivers/net/wireless/iwlegacy/debug.c| 8 ++-- 2 files changed, 3

<    1   2   3