Re: [PATCH net-next] net: ena: Fix Kconfig dependencies X86

Sure. Removing them and resubmit. On 10/17/18, 11:37 AM, "Sergei Shtylyov" wrote: Hello! On 17.10.2018 11:16, neta...@amazon.com wrote: > From: Netanel Belgazal > > The Kconfig limitation of X86 is to too wide. > The ENA driver only requires a little endian

Re: [PATCH v4 17/17] net: ena: Eliminate duplicate barriers on weakly-ordered archs

I think you should either add a parameter to ena_com_write_sq_doorbell() or add ena_com_write_sq_doorbell_rel(). Right now, you have unused function. On 3/20/18, 4:43 AM, "Sinan Kaya" wrote: Code includes barrier() followed by writel(). writel() already has a

Re: [PATCH net 3/3] eet: ena: invoke netif_carrier_off() only after netdev registered

Right. I’ll remove this patch. On 1/2/18, 9:08 PM, "David Miller" wrote: From: Date: Thu, 28 Dec 2017 21:30:20 + > From: Netanel Belgazal > > netif_carrier_off() should be called only after register

Re: [PATCH net 3/3] eet: ena: invoke netif_carrier_off() only after netdev registered

Yes, I mean in my driver. netif_carrier_off() have no effect when netdev is uninitialized. So I must call it after register_netdev(). On 12/29/17, 9:46 AM, "Jakub Kicinski" wrote: By "should" you mean in your driver, right? I think calling netif_carrier_off() on an

Re: [PATCH net-next 12/13] net: ena: change validate_tx_req_id() to be inline function

without the explicit hint. Regards, Netanel From: Leon Romanovsky <l...@kernel.org> Sent: Monday, June 19, 2017 7:56 AM To: Belgazal, Netanel Cc: da...@davemloft.net; netdev@vger.kernel.org; Woodhouse, David; Machulsky, Zorik; Matushevsky, Ale

Re: [PATCH net-next 09/13] net: ena: adding missing cast in ena_com_mem_addr_set()

Ack, Will use the proposed functions. From: Leon Romanovsky <l...@kernel.org> Sent: Monday, June 19, 2017 8:00 AM To: Belgazal, Netanel Cc: da...@davemloft.net; netdev@vger.kernel.org; Woodhouse, David; Machulsky, Zorik; Matushevsky, Alexander;

Re: [PATCH net-next 10/13] net: ena: add mtu limitation in ena_change_mtu()

I'll discard this patch. From: David Miller <da...@davemloft.net> Sent: Sunday, June 18, 2017 7:21 PM To: Belgazal, Netanel Cc: netdev@vger.kernel.org; Woodhouse, David; Machulsky, Zorik; Matushevsky, Alexander; BSHARA, Said; Wilson, Matt; Liguori, A

Re: [PATCH net 0/9] Bugs fixes in ena ethernet driver

:38 PM To: Belgazal, Netanel Cc: netdev@vger.kernel.org; Woodhouse, David; Machulsky, Zorik; Matushevsky, Alexander; BSHARA, Said; Wilson, Matt; Liguori, Anthony; Bshara, Nafea; Schmeilin, Evgeny Subject: Re: [PATCH net 0/9] Bugs fixes in ena ethernet driver From: <neta...@amazon.com> Date:

Re: [PATCH net-next 0/8] Bug fixes in ena ethernet driver

Ack. resubmitting to net branch and adding "Fixes" mark. From: David Miller <da...@davemloft.net> Sent: Saturday, June 10, 2017 11:11 PM To: f.faine...@gmail.com Cc: Belgazal, Netanel; netdev@vger.kernel.org; Woodhouse, David; Machulsky, Zo

Re: [PATCH net-next 0/8] Bug fixes in ena ethernet driver

I the last minute I fixed patchset #6 commit subject from stuck to hang and I forget to remove it. Sorry for that. resubmitted. From: David Miller <da...@davemloft.net> Sent: Friday, June 9, 2017 10:33 PM To: Belgazal, Netanel Cc: netdev@vger.kern

Re: [PATCH net-next 0/8] Bug fixes in ena ethernet driver

My apologies, I was not aware. Will make sure this won't happen again. Regards, Netanel From: David Miller <da...@davemloft.net> Sent: Friday, June 9, 2017 2:17 AM To: Belgazal, Netanel Cc: netdev@vger.kernel.org; Woodhouse, David; Machulsky,