> Again, I want to see this implemented in a way which causes things to be
> treated consistently across all tunneling types.
>
> Which means fixing the exact problem, IPCB(skb)->opt needing initilization.
>
> Thanks.
Thanks for the reply. I have revised my patch to apply to the range of tunnel
field is cleared
unconditionally in ip_tunnel_xmit. The change in ip_tunnel_xmit applies to
SIT, GRE, and IPIP tunnels.
The relevant vti, l2tp, and pptp functions already contain similar code for
clearing the IPCB.
Signed-off-by: Bernie Harris <bernie.har...@alliedtelesis.co.nz>
---
net/ipv4
field is cleared
unconditionally in ip_tunnel_xmit. The change in ip_tunnel_xmit applies to
SIT, GRE, and IPIP tunnels.
The relevant vti, l2tp, and pptp functions already contain similar code for
clearing the IPCB.
Signed-off-by: Bernie Harris <bernie.har...@alliedtelesis.co.nz>
---
net/ipv4
Thank you for the reply. I have revised the patch to apply to the range of
tunnel types, and so only the opt field is cleared.
tation
of ip_fast_csum.
This patch clears IPCB before dst_link_failure is called from the functions
ip_tunnel_xmit and ip6gre_xmit2, similar to what commit 11c21a30 does for
an ipv4 case.
Signed-off-by: Bernie Harris <bernie.har...@alliedtelesis.co.nz>
---
net/ipv4/ip_tunnel.c | 1 +
net/ipv6/ip6_gre.c
tation
of ip_fast_csum.
This patch clears IPCB before dst_link_failure is called, similar to what
commit 11c21a30 does for the ipv4 case.
Signed-off-by: Bernie Harris <bernie.har...@alliedtelesis.co.nz>
---
net/ipv6/ip6_gre.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/net/ipv6/ip6_gre.
There are cases where qdisc_dequeue_peeked can return NULL, and the result
is dereferenced later on in the function.
Similarly to the other qdisc dequeue functions, check whether the skb
pointer is NULL and if it is, goto out.
Signed-off-by: Bernie Harris <bernie.har...@alliedtelesis.co
Thank you. I will add unlikely() and re-submit the patch.
From: Cong Wang <xiyou.wangc...@gmail.com>
Sent: 27 January 2016 07:03
To: Bernie Harris
Cc: Linux Kernel Network Developers; David Miller; Jamal Hadi Salim;
sta...@vger.kernel.org
Subje
There are cases where qdisc_dequeue_peeked can return NULL, and the result
is dereferenced later on in the function.
Similarly to the other qdisc dequeue functions, check whether the skb
pointer is NULL and if it is, goto out.
Signed-off-by: Bernie Harris <bernie.har...@alliedtelesis.co
