[PATCH v3] net: qrtr: Expose tunneling endpoint to user space

2018-04-26 Thread Bjorn Andersson
r USB link. Signed-off-by: Bjorn Andersson <bjorn.anders...@linaro.org> --- Changes since v2: - Add support for read poll Changes since v1: - Dropped queue lock net/qrtr/Kconfig | 7 +++ net/qrtr/Makefile | 2 + net/qrtr/tun.c| 161 +++

[PATCH v2] net: qrtr: Expose tunneling endpoint to user space

2018-04-23 Thread Bjorn Andersson
r USB link. Signed-off-by: Bjorn Andersson <bjorn.anders...@linaro.org> --- Changes since v1: - Dropped queue lock net/qrtr/Kconfig | 7 +++ net/qrtr/Makefile | 2 + net/qrtr/tun.c| 146 ++ 3 files changed, 155 insertions(+) create

[PATCH] net: qrtr: Expose tunneling endpoint to user space

2018-04-18 Thread Bjorn Andersson
r USB link. Signed-off-by: Bjorn Andersson <bjorn.anders...@linaro.org> --- net/qrtr/Kconfig | 7 +++ net/qrtr/Makefile | 2 + net/qrtr/tun.c| 162 ++ 3 files changed, 171 insertions(+) create mode 100644 net/qrtr/tun.c diff

Re: [PATCH] brcmfmac: Make sure CLM downloading is optional

2018-01-15 Thread Bjorn Andersson
On Mon 15 Jan 11:40 PST 2018, Arend van Spriel wrote: > On 1/15/2018 6:10 PM, Bjorn Andersson wrote: > > The presence of a CLM file is described as optional, but missing the clm > > blob causes the preinit to return unsuccessfully. Fix this by ignoring >

[PATCH] brcmfmac: Make sure CLM downloading is optional

2018-01-15 Thread Bjorn Andersson
message before returning. Fixes: fdd0bd88ceae ("brcmfmac: add CLM download support") Cc: sta...@vger.kernel.org Signed-off-by: Bjorn Andersson <bjorn.anders...@linaro.org> --- This regression was introduced in v4.15-rc1, but I unfortunately didn't test WiFi until now. Included a Cc to

Re: [PATCH][V2] wcn36xx: fix incorrect assignment to msg_body.min_ch_time

2018-01-04 Thread Bjorn Andersson
On Fri 29 Dec 01:07 PST 2017, Colin King wrote: > From: Colin Ian King <colin.k...@canonical.com> > > The second assignment to msg_body.min_ch_time is incorrect, it > should actually be to msg_body.max_ch_time. > > Thanks to Bjorn Andersson for identifying the correct

Re: [PATCH][next] wcn36xx: remove redundant assignment to msg_body.min_ch_time

2017-12-26 Thread Bjorn Andersson
On Tue 19 Dec 09:04 PST 2017, Colin King wrote: > From: Colin Ian King > > msg_body.min_ch_time is being assigned twice; remove the redundant > first assignment. > > Detected by CoverityScan, CID#1463042 ("Unused Value") > Happy to see Coverity working for us :)

[PATCH] wcn36xx: Reduce spinlock in indication handler

2017-12-08 Thread Bjorn Andersson
throughout the indication worker, allowing the individual handlers to sleep. Signed-off-by: Bjorn Andersson <bjorn.anders...@linaro.org> --- drivers/net/wireless/ath/wcn36xx/smd.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/wireless/ath/wcn36xx/sm

Re: [PATCH v4] wcn36xx: Set default BTLE coexistence config

2017-11-16 Thread Bjorn Andersson
coexistence > performance. > > Signed-off-by: Eyal Ilsar <eil...@codeaurora.org> > Signed-off-by: Ramon Fried <rfr...@codeaurora.org> Looks good, Acked-by: Bjorn Andersson <bjorn.anders...@linaro.org> Regards, Bjorn > --- > drivers/net/wireless/ath/wcn36xx/smd.c |

Re: [PATCH v3] wcn36xx: Set default BTLE coexistence config

2017-11-15 Thread Bjorn Andersson
On Mon 13 Nov 23:23 PST 2017, Ramon Fried wrote: > From: Eyal Ilsar > > If the value for the firmware configuration parameters > BTC_STATIC_LEN_LE_BT and BTC_STATIC_LEN_LE_WLAN are not set the duty > cycle between BT and WLAN is such that if BT (including BLE) is active >

Re: [PATCH] wcn36xx: Set BTLE coexistence related configuration values to defaults

2017-11-13 Thread Bjorn Andersson
On Sun 12 Nov 06:21 PST 2017, Ramon Fried wrote: > From: Eyal Ilsar > > If the value for the firmware configuration parameters BTC_STATIC_LEN_LE_BT > and BTC_STATIC_LEN_LE_WLAN are not set the duty cycle between BT and WLAN > is such that if BT (including BLE) is active

[PATCH] qrtr: Move to postcore_initcall

2017-11-06 Thread Bjorn Andersson
Registering qrtr with module_init makes the ability of typical platform code to create AF_QIPCRTR socket during probe a matter of link order luck. Moving qrtr to postcore_initcall() avoids this. Signed-off-by: Bjorn Andersson <bjorn.anders...@linaro.org> --- net/qrtr/qrtr.c | 2 +-

Re: [PATCH] wcn36xx: Remove unnecessary rcu_read_unlock in wcn36xx_bss_info_changed

2017-10-11 Thread Bjorn Andersson
fc7cc7ccf ("wcn36xx: Introduce mutual exclusion of fw configuration") > Signed-off-by: Jia-Ju Bai <baijiaju1...@163.com> Acked-by: Bjorn Andersson <bjorn.anders...@linaro.org> Regards, Bjorn > --- > drivers/net/wireless/ath/wcn36xx/main.c |1 - > 1 file changed,

[PATCH v2 1/7] net: qrtr: Invoke sk_error_report() after setting sk_err

2017-10-11 Thread Bjorn Andersson
Rather than manually waking up any context sleeping on the sock to signal an error we should call sk_error_report(). This has the added benefit that in-kernel consumers can override this notification with its own callback. Signed-off-by: Bjorn Andersson <bjorn.anders...@linaro.org> --- C

[PATCH v2 4/7] net: qrtr: Pass source and destination to enqueue functions

2017-10-11 Thread Bjorn Andersson
just to decode it immediately in qrtr_local_enqueue(). In the future this change also makes it possible to prepend message headers based on the version of each link. Signed-off-by: Bjorn Andersson <bjorn.anders...@linaro.org> --- Changes since v1: - None net/qrtr/qrtr.c

[PATCH v2 2/7] net: qrtr: Move constants to header file

2017-10-11 Thread Bjorn Andersson
The constants are used by both the name server and clients, so clarify their value and move them to the uapi header. Signed-off-by: Bjorn Andersson <bjorn.anders...@linaro.org> --- Changes since v1: - None include/uapi/linux/qrtr.h | 3 +++ net/qrtr/qrtr.c | 2 -- 2 files chan

[PATCH v2 0/7] net: qrtr: Fixes and support receiving version 2 packets

2017-10-11 Thread Bjorn Andersson
packets continues to be send as version 1, but some groundwork has been done to make this a per-link property. Bjorn Andersson (7): net: qrtr: Invoke sk_error_report() after setting sk_err net: qrtr: Move constants to header file net: qrtr: Add control packet definition to uapi net: qrtr

[PATCH v2 3/7] net: qrtr: Add control packet definition to uapi

2017-10-11 Thread Bjorn Andersson
-off-by: Bjorn Andersson <bjorn.anders...@linaro.org> --- Changes since v1: - None include/uapi/linux/qrtr.h | 32 net/qrtr/qrtr.c | 12 2 files changed, 32 insertions(+), 12 deletions(-) diff --git a/include/uapi/linux/qrtr.h b/includ

[PATCH v2 5/7] net: qrtr: Clean up control packet handling

2017-10-11 Thread Bjorn Andersson
that these functions can be folded back into the callers. Signed-off-by: Bjorn Andersson <bjorn.anders...@linaro.org> --- Changes since v1: - None net/qrtr/qrtr.c | 93 ++--- 1 file changed, 29 insertions(+), 64 deletions(-) diff --git

[PATCH v2 7/7] net: qrtr: Support decoding incoming v2 packets

2017-10-11 Thread Bjorn Andersson
Add the necessary logic for decoding incoming messages of version 2 as well. Also make sure there's room for the bigger of version 1 and 2 headers in the code allocating skbs for outgoing messages. Signed-off-by: Bjorn Andersson <bjorn.anders...@linaro.org> --- Changes since v1: - D

[PATCH v2 6/7] net: qrtr: Use sk_buff->cb in receive path

2017-10-11 Thread Bjorn Andersson
Signed-off-by: Bjorn Andersson <bjorn.anders...@linaro.org> --- Changes since v1: - None net/qrtr/qrtr.c | 70 - 1 file changed, 40 insertions(+), 30 deletions(-) diff --git a/net/qrtr/qrtr.c b/net/qrtr/qrtr.c index a84edba7b1ef..7bc

[RESEND PATCH 4/7] net: qrtr: Pass source and destination to enqueue functions

2017-10-04 Thread Bjorn Andersson
just to decode it immediately in qrtr_local_enqueue(). In the future this change also makes it possible to prepend message headers based on the version of each link. Signed-off-by: Bjorn Andersson <bjorn.anders...@linaro.org> --- net/qrtr/qrtr.c

[RESEND PATCH 0/7] net: qrtr: Fixes and support receiving version 2 packets

2017-10-04 Thread Bjorn Andersson
packets continues to be send as version 1, but some groundwork has been done to make this a per-link property. Bjorn Andersson (7): net: qrtr: Invoke sk_error_report() after setting sk_err net: qrtr: Move constants to header file net: qrtr: Add control packet definition to uapi net: qrtr

[RESEND PATCH 1/7] net: qrtr: Invoke sk_error_report() after setting sk_err

2017-10-04 Thread Bjorn Andersson
Rather than manually waking up any context sleeping on the sock to signal an error we should call sk_error_report(). This has the added benefit that in-kernel consumers can override this notification with its own callback. Signed-off-by: Bjorn Andersson <bjorn.anders...@linaro.org> --- ne

[RESEND PATCH 2/7] net: qrtr: Move constants to header file

2017-10-04 Thread Bjorn Andersson
The constants are used by both the name server and clients, so clarify their value and move them to the uapi header. Signed-off-by: Bjorn Andersson <bjorn.anders...@linaro.org> --- include/uapi/linux/qrtr.h | 3 +++ net/qrtr/qrtr.c | 2 -- 2 files changed, 3 insertions(+), 2 del

[RESEND PATCH 3/7] net: qrtr: Add control packet definition to uapi

2017-10-04 Thread Bjorn Andersson
-off-by: Bjorn Andersson <bjorn.anders...@linaro.org> --- include/uapi/linux/qrtr.h | 32 net/qrtr/qrtr.c | 12 2 files changed, 32 insertions(+), 12 deletions(-) diff --git a/include/uapi/linux/qrtr.h b/include/uapi/linux/qrtr.h

[RESEND PATCH 5/7] net: qrtr: Clean up control packet handling

2017-10-04 Thread Bjorn Andersson
that these functions can be folded back into the callers. Signed-off-by: Bjorn Andersson <bjorn.anders...@linaro.org> --- net/qrtr/qrtr.c | 93 ++--- 1 file changed, 29 insertions(+), 64 deletions(-) diff --git a/net/qrtr/qrtr.c b/ne

[RESEND PATCH 6/7] net: qrtr: Use sk_buff->cb in receive path

2017-10-04 Thread Bjorn Andersson
Signed-off-by: Bjorn Andersson <bjorn.anders...@linaro.org> --- net/qrtr/qrtr.c | 70 - 1 file changed, 40 insertions(+), 30 deletions(-) diff --git a/net/qrtr/qrtr.c b/net/qrtr/qrtr.c index a84edba7b1ef..7bca6ec892a5 100644 --- a/net/qrtr/

[RESEND PATCH 7/7] net: qrtr: Support decoding incoming v2 packets

2017-10-04 Thread Bjorn Andersson
Add the necessary logic for decoding incoming messages of version 2 as well. Also make sure there's room for the bigger of version 1 and 2 headers in the code allocating skbs for outgoing messages. Signed-off-by: Bjorn Andersson <bjorn.anders...@linaro.org> --- net/qrtr/qrtr.c

[PATCH 0/7] net: qrtr: Fixes and support receiving version 2 packets

2017-09-07 Thread Bjorn Andersson
packets continues to be send as version 1, but some groundwork has been done to make this a per-link property. Bjorn Andersson (7): net: qrtr: Invoke sk_error_report() after setting sk_err net: qrtr: Move constants to header file net: qrtr: Add control packet definition to uapi net: qrtr

[PATCH 1/7] net: qrtr: Invoke sk_error_report() after setting sk_err

2017-09-07 Thread Bjorn Andersson
Rather than manually waking up any context sleeping on the sock to signal an error we should call sk_error_report(). This has the added benefit that in-kernel consumers can override this notificatino with its own callback. Signed-off-by: Bjorn Andersson <bjorn.anders...@linaro.org> --- ne

[PATCH 4/7] net: qrtr: Pass source and destination to enqueue functions

2017-09-07 Thread Bjorn Andersson
just to decode it immediately in qrtr_local_enqueue(). In the future this change also makes it possible to prepend message headers based on the version of each link. Signed-off-by: Bjorn Andersson <bjorn.anders...@linaro.org> --- net/qrtr/qrtr.c

[PATCH 3/7] net: qrtr: Add control packet definition to uapi

2017-09-07 Thread Bjorn Andersson
-off-by: Bjorn Andersson <bjorn.anders...@linaro.org> --- include/uapi/linux/qrtr.h | 32 net/qrtr/qrtr.c | 12 2 files changed, 32 insertions(+), 12 deletions(-) diff --git a/include/uapi/linux/qrtr.h b/include/uapi/linux/qrtr.h

[PATCH 7/7] net: qrtr: Support decoding incoming v2 packets

2017-09-07 Thread Bjorn Andersson
Add the necessary logic for decoding incoming messages of version 2 as well. Also make sure there's room for the bigger of version 1 and 2 headers in the code allocating skbs for outgoing messages. Signed-off-by: Bjorn Andersson <bjorn.anders...@linaro.org> --- net/qrtr/qrtr.c

[PATCH 2/7] net: qrtr: Move constants to header file

2017-09-07 Thread Bjorn Andersson
The constants are used by both the name server and clients, so clarify their value and move them to the uapi header. Signed-off-by: Bjorn Andersson <bjorn.anders...@linaro.org> --- include/uapi/linux/qrtr.h | 3 +++ net/qrtr/qrtr.c | 2 -- 2 files changed, 3 insertions(+), 2 del

[PATCH 6/7] net: qrtr: Use sk_buff->cb in receive path

2017-09-07 Thread Bjorn Andersson
Signed-off-by: Bjorn Andersson <bjorn.anders...@linaro.org> --- net/qrtr/qrtr.c | 70 - 1 file changed, 40 insertions(+), 30 deletions(-) diff --git a/net/qrtr/qrtr.c b/net/qrtr/qrtr.c index f28ecd7d735b..5042999756ce 100644 --- a/net/qrtr/

[PATCH 5/7] net: qrtr: Clean up control packet handling

2017-09-07 Thread Bjorn Andersson
that these functions can be folded back into the callers. Signed-off-by: Bjorn Andersson <bjorn.anders...@linaro.org> --- net/qrtr/qrtr.c | 93 ++--- 1 file changed, 29 insertions(+), 64 deletions(-) diff --git a/net/qrtr/qrtr.c b/ne

Re: [PATCH 2/2] Bluetooth: btqcomsmd: BD address setup

2017-09-03 Thread Bjorn Andersson
e BD address during > >>> hci device setup. > >>> > >>> Signed-off-by: Loic Poulain <loic.poul...@linaro.org> > >>> Signed-off-by: Bjorn Andersson <bjorn.anders...@linaro.org> > >>> --- > >>> drivers/bluetooth/btqcomsmd.c | 28 +++

Re: [PATCH 2/2] Bluetooth: btqcomsmd: BD address setup

2017-09-01 Thread Bjorn Andersson
ice setup. > > > > Signed-off-by: Loic Poulain <loic.poul...@linaro.org> > > Signed-off-by: Bjorn Andersson <bjorn.anders...@linaro.org> > > --- > > drivers/bluetooth/btqcomsmd.c | 28 > > 1 file changed, 28 insertions(+) >

[PATCH 1/2] Bluetooth: make baswap src const

2017-09-01 Thread Bjorn Andersson
From: Loic Poulain <loic.poul...@linaro.org> Signed-off-by: Loic Poulain <loic.poul...@linaro.org> Signed-off-by: Bjorn Andersson <bjorn.anders...@linaro.org> --- include/net/bluetooth/bluetooth.h | 2 +- net/bluetooth/lib.c | 4 ++-- 2 files changed, 3 insertio

[PATCH 0/2] btqcomsmd: Allow specifying board mac address

2017-09-01 Thread Bjorn Andersson
The btqcomsmd hardware lacks persistent storage of its mac address, so this needs to be configured during initialization. The second patch in this series reads the mac address from DT and does this, allowing the boot loader to populate this board specific information. Loic Poulain (2):

[PATCH 2/2] Bluetooth: btqcomsmd: BD address setup

2017-09-01 Thread Bjorn Andersson
g> Signed-off-by: Bjorn Andersson <bjorn.anders...@linaro.org> --- drivers/bluetooth/btqcomsmd.c | 28 1 file changed, 28 insertions(+) diff --git a/drivers/bluetooth/btqcomsmd.c b/drivers/bluetooth/btqcomsmd.c index d00c4fdae924..443bb2099329 100644 --- a

Re: [PATCH 0/6] In-kernel QMI handling

2017-08-08 Thread Bjorn Andersson
On Tue 08 Aug 04:02 PDT 2017, Bj?rn Mork wrote: > Bjorn Andersson <bjorn.anders...@linaro.org> writes: > > > This series starts by moving the common definitions of the QMUX protocol to > > the > > uapi header, as they are shared with clients - both in kernel and

Re: [PATCH 0/6] In-kernel QMI handling

2017-08-07 Thread Bjorn Andersson
On Mon 07 Aug 12:19 PDT 2017, Marcel Holtmann wrote: > Hi Bjorn, > > >>> This series starts by moving the common definitions of the QMUX > >>> protocol to the > >>> uapi header, as they are shared with clients - both in kernel and > >>> userspace. > >>> > >>> This series then introduces

Re: [PATCH 0/6] In-kernel QMI handling

2017-08-07 Thread Bjorn Andersson
On Fri 04 Aug 08:36 PDT 2017, Dan Williams wrote: > On Fri, 2017-08-04 at 07:59 -0700, Bjorn Andersson wrote: > > This series starts by moving the common definitions of the QMUX > > protocol to the > > uapi header, as they are shared with clients - both in ker

[PATCH 0/6] In-kernel QMI handling

2017-08-04 Thread Bjorn Andersson
implementation for showing QRTR and the QMI helpers in action. The sample device instantiates in response to finding the "test service" and implements the "test protocol". Bjorn Andersson (6): net: qrtr: Invoke sk_error_report() after setting sk_err net: qrtr: Move constants

[PATCH 1/6] net: qrtr: Invoke sk_error_report() after setting sk_err

2017-08-04 Thread Bjorn Andersson
Rather than manually waking up any context sleeping on the sock to signal an error we should call sk_error_report(). This has the added benefit that in-kernel consumers can override this notificatino with its own callback. Signed-off-by: Bjorn Andersson <bjorn.anders...@linaro.org> --- ne

[PATCH 4/6] soc: qcom: Introduce QMI encoder/decoder

2017-08-04 Thread Bjorn Andersson
-off-by: Bjorn Andersson <bjorn.anders...@linaro.org> --- drivers/soc/qcom/Kconfig | 8 + drivers/soc/qcom/Makefile | 2 + drivers/soc/qcom/qmi_encdec.c | 812 ++ include/linux/soc/qcom/qmi.h | 116 ++ 4 files changed, 938 insertions(+)

[PATCH 2/6] net: qrtr: Move constants to header file

2017-08-04 Thread Bjorn Andersson
The constants are used by both the name server and clients, so make their value explicit and move them to the uapi header. Signed-off-by: Bjorn Andersson <bjorn.anders...@linaro.org> --- include/uapi/linux/qrtr.h | 3 +++ net/qrtr/qrtr.c | 2 -- 2 files changed, 3 insertions

[PATCH 3/6] net: qrtr: Add control packet definition to uapi

2017-08-04 Thread Bjorn Andersson
-off-by: Bjorn Andersson <bjorn.anders...@linaro.org> --- include/uapi/linux/qrtr.h | 32 net/qrtr/qrtr.c | 12 2 files changed, 32 insertions(+), 12 deletions(-) diff --git a/include/uapi/linux/qrtr.h b/include/uapi/linux/qrtr.h

[PATCH 5/6] soc: qcom: Introduce QMI helpers

2017-08-04 Thread Bjorn Andersson
-off-by: Bjorn Andersson <bjorn.anders...@linaro.org> --- drivers/soc/qcom/Makefile| 1 + drivers/soc/qcom/qmi_interface.c | 540 +++ include/linux/soc/qcom/qmi.h | 133 ++ 3 files changed, 674 insertions(+) create mode 100644 drive

[PATCH 6/6] samples: Introduce Qualcomm QRTR sample client

2017-08-04 Thread Bjorn Andersson
Introduce a sample driver that register for server notifications and spawn clients for each available test service (service 15). The spawned clients implements the interface for encoding "ping" and "data" requests and decode the responses from the remote. Signed-off

[PATCH] wcn36xx: Introduce mutual exclusion of fw configuration

2017-08-02 Thread Bjorn Andersson
lock. Cc: sta...@vger.kernel.org Signed-off-by: Bjorn Andersson <bjorn.anders...@linaro.org> --- drivers/net/wireless/ath/wcn36xx/main.c| 52 -- drivers/net/wireless/ath/wcn36xx/wcn36xx.h | 3 ++ 2 files changed, 53 insertions(+), 2 deletions(-) diff --gi

[RESEND PATCH 0/4] Missing QRTR features

2017-06-07 Thread Bjorn Andersson
service register, allowing them to register services as well as querying for remote registered services. Bjorn Andersson (4): net: qrtr: Refactor packet allocation net: qrtr: Inject BYE on remote termination net: qrtr: Broadcast DEL_CLIENT message when endpoint is closed net: qrtr: Inform

[RESEND PATCH 3/4] net: qrtr: Broadcast DEL_CLIENT message when endpoint is closed

2017-06-07 Thread Bjorn Andersson
, but implementation of this suggestion is left for the future. Cc: Courtney Cavin <cca...@gmail.com> Signed-off-by: Bjorn Andersson <bjorn.anders...@linaro.org> --- net/qrtr/qrtr.c | 28 1 file changed, 28 insertions(+) diff --git a/net/qrtr/qrtr.c b/net/qrtr/

[RESEND PATCH 2/4] net: qrtr: Inject BYE on remote termination

2017-06-07 Thread Bjorn Andersson
to the local clients. Cc: Courtney Cavin <cca...@gmail.com> Signed-off-by: Bjorn Andersson <bjorn.anders...@linaro.org> --- net/qrtr/qrtr.c | 27 +++ 1 file changed, 27 insertions(+) diff --git a/net/qrtr/qrtr.c b/net/qrtr/qrtr.c index 86d35ed50da9..e8cbab23d667 1006

[RESEND PATCH 4/4] net: qrtr: Inform open sockets about new controller

2017-06-07 Thread Bjorn Andersson
ather than introducing support for broadcasting such a message in-band to all open local sockets we flag each socket with ENETRESET, as there are no other expected operations that would benefit from having support from locally broadcasting messages. Cc: Courtney Cavin <cca...@gmail.com> Sign

[RESEND PATCH 1/4] net: qrtr: Refactor packet allocation

2017-06-07 Thread Bjorn Andersson
Extract the allocation and filling in the control message header fields to a separate function in order to reuse this in subsequent patches. Cc: Courtney Cavin <cca...@gmail.com> Signed-off-by: Bjorn Andersson <bjorn.anders...@linaro.org> --- net/qrtr/qrtr.c | 25

[PATCH 3/4] net: qrtr: Broadcast DEL_CLIENT message when endpoint is closed

2017-06-07 Thread Bjorn Andersson
, but implementation of this suggestion is left for the future. Cc: Courtney Cavin <cca...@gmail.com> Signed-off-by: Bjorn Andersson <bjorn.anders...@linaro.org> --- net/qrtr/qrtr.c | 28 1 file changed, 28 insertions(+) diff --git a/net/qrtr/qrtr.c b/net/qrtr/

[PATCH 1/4] net: qrtr: Refactor packet allocation

2017-06-07 Thread Bjorn Andersson
Extract the allocation and filling in the control message header fields to a separate function in order to reuse this in subsequent patches. Cc: Courtney Cavin <cca...@gmail.com> Signed-off-by: Bjorn Andersson <bjorn.anders...@linaro.org> --- net/qrtr/qrtr.c | 25

[PATCH 2/4] net: qrtr: Inject BYE on remote termination

2017-06-07 Thread Bjorn Andersson
to the local clients. Cc: Courtney Cavin <cca...@gmail.com> Signed-off-by: Bjorn Andersson <bjorn.anders...@linaro.org> --- net/qrtr/qrtr.c | 27 +++ 1 file changed, 27 insertions(+) diff --git a/net/qrtr/qrtr.c b/net/qrtr/qrtr.c index 86d35ed50da9..e8cbab23d667 1006

[PATCH 4/4] net: qrtr: Inform open sockets about new controller

2017-06-07 Thread Bjorn Andersson
ather than introducing support for broadcasting such a message in-band to all open local sockets we flag each socket with ENETRESET, as there are no other expected operations that would benefit from having support from locally broadcasting messages. Cc: Courtney Cavin <cca...@gmail.com> Sign

[PATCH v2] mac80211: Invoke TX LED in more code paths

2017-05-27 Thread Bjorn Andersson
() into ieee80211_report_used_skb(), which is shared between the various code paths. Signed-off-by: Bjorn Andersson <bjorn.anders...@linaro.org> --- net/mac80211/status.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/mac80211/status.c b/net/mac80211/status.c index be47ac

Re: [PATCH 1/2] wcn36xx: Pass used skb to ieee80211_tx_status()

2017-05-17 Thread Bjorn Andersson
On Wed 17 May 06:14 PDT 2017, Johannes Berg wrote: > On Thu, 2017-05-04 at 13:13 +, Kalle Valo wrote: > > > > > > This code intentionally checked if TX status was requested, and > > > > if not then it doesn't go to the effort of building it. > > > > > > > > > > What I'm finding puzzling is

Re: [PATCH 2/6] wl1251: Use request_firmware_prefer_user() for loading NVS calibration data

2017-05-17 Thread Bjorn Andersson
On Wed 17 May 05:53 PDT 2017, Pali Roh?r wrote: > On Wednesday 17 May 2017 14:06:06 Johannes Berg wrote: > > On Tue, 2017-05-16 at 01:13 +0200, Luis R. Rodriguez wrote: > > > > > Now for N900 case there is a similar scenario > > > > > alhtough it has additional requirement to go to user-space due

Re: [PATCH] wcn36xx: Close SMD channel on device removal

2017-05-10 Thread Bjorn Andersson
On Wed 10 May 00:27 PDT 2017, Arend van Spriel wrote: > On 5/10/2017 1:03 AM, Bjorn Andersson wrote: > > On Mon 08 May 23:17 PDT 2017, Kalle Valo wrote: > > > > > Bjorn Andersson <bjorn.anders...@linaro.org> writes: > > > > > > > The SM

Re: [PATCH] wcn36xx: Close SMD channel on device removal

2017-05-09 Thread Bjorn Andersson
On Mon 08 May 23:17 PDT 2017, Kalle Valo wrote: > Bjorn Andersson <bjorn.anders...@linaro.org> writes: > > > The SMD channel is not the primary WCNSS channel and must explicitly be > > closed as the device is removed, or the channel will already by open on > >

[PATCH] wcn36xx: Close SMD channel on device removal

2017-05-08 Thread Bjorn Andersson
d-by: Eyal Ilsar <c_eil...@qti.qualcomm.com> Signed-off-by: Bjorn Andersson <bjorn.anders...@linaro.org> --- drivers/net/wireless/ath/wcn36xx/main.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/wireless/ath/wcn36xx/main.c b/drivers/net/wireless/ath/wcn36xx/mai

Re: [PATCH 1/2] wcn36xx: Pass used skb to ieee80211_tx_status()

2017-04-28 Thread Bjorn Andersson
On Thu 27 Apr 01:22 PDT 2017, Johannes Berg wrote: > > > @@ -371,7 +371,7 @@ static void reap_tx_dxes(struct wcn36xx *wcn, > > struct wcn36xx_dxe_ch *ch) > >   info = IEEE80211_SKB_CB(ctl->skb); > >   if (!(info->flags & > > IEEE80211_TX_CTL_REQ_TX_STATUS)) {

[PATCH 2/2] arm64: dts: apq8016-sbc: Correct WLAN LED default-trigger

2017-04-26 Thread Bjorn Andersson
The TX status trigger of the wlan interface is named phy0tx, so this updates the default-trigger for the WLAN LED to use that instead. Signed-off-by: Bjorn Andersson <bjorn.anders...@linaro.org> --- Note that without patch 1/2 this trigger does not fire - but there's also no harm in p

[PATCH 1/2] wcn36xx: Pass used skb to ieee80211_tx_status()

2017-04-26 Thread Bjorn Andersson
As the tx skbs are collected they should be passed to ieee80211_tx_status() rather than ieee80211_free_txskb(), as the prior will take care of monitoring and LED triggers while the latter will consider the skb dropped. Signed-off-by: Bjorn Andersson <bjorn.anders...@linaro.org> --- drive

Re: [PATCH 1/6] virtio: wrap find_vqs

2017-04-01 Thread Bjorn Andersson
On Wed 29 Mar 13:48 PDT 2017, Michael S. Tsirkin wrote: > We are going to add more parameters to find_vqs, let's wrap the call so > we don't need to tweak all drivers every time. > > Signed-off-by: Michael S. Tsirkin <m...@redhat.com> Acked-by: Bjorn Andersson <bjorn

Re: [PATCH 1/3] soc: qcom: smd: Transition client drivers from smd to rpmsg

2017-03-27 Thread Bjorn Andersson
On Mon 27 Mar 16:04 PDT 2017, David Miller wrote: > From: Bjorn Andersson <bjorn.anders...@linaro.org> > Date: Mon, 27 Mar 2017 15:58:37 -0700 > > > I'm sorry, but I can't figure out how to reproduce this. > > All of my builds are "make allmodconfig" so it

[PATCH v2 1/3] soc: qcom: smd: Transition client drivers from smd to rpmsg

2017-03-27 Thread Bjorn Andersson
drivers in one commit, to make sure we have a working system before and after this transition. Acked-by: Andy Gross <andy.gr...@linaro.org> Acked-by: Kalle Valo <kv...@codeaurora.org> Acked-by: Marcel Holtmann <mar...@holtmann.org> Signed-off-by: Bjorn Andersson <bjorn

[PATCH v2 3/3] soc: qcom: smd-rpm: Add msm8996 compatibility

2017-03-27 Thread Bjorn Andersson
With the RPM driver transitioned to RPMSG we can reuse the SMD-RPM driver ontop of GLINK for 8996, without any modifications. Acked-by: Andy Gross <andy.gr...@linaro.org> Signed-off-by: Bjorn Andersson <bjorn.anders...@linaro.org> --- drivers/soc/qcom/smd-rpm.c | 1 + 1 file changed,

[PATCH v2 2/3] soc: qcom: smd: Remove standalone driver

2017-03-27 Thread Bjorn Andersson
Signed-off-by: Bjorn Andersson <bjorn.anders...@linaro.org> --- drivers/remoteproc/Kconfig |6 +- drivers/rpmsg/Kconfig |1 - drivers/soc/qcom/Kconfig |8 - drivers/soc/qcom/Makefile |1 - drivers/soc/qcom/smd.c

Re: [PATCH 1/3] soc: qcom: smd: Transition client drivers from smd to rpmsg

2017-03-27 Thread Bjorn Andersson
On Thu 23 Mar 16:56 PDT 2017, David Miller wrote: > From: Bjorn Andersson <bjorn.anders...@linaro.org> > Date: Wed, 22 Mar 2017 14:57:33 -0700 > > > On Wed 22 Mar 11:44 PDT 2017, David Miller wrote: > > > >> From: Bjorn Andersson <bjorn.anders...@linaro.or

Re: [PATCH 1/3] soc: qcom: smd: Transition client drivers from smd to rpmsg

2017-03-22 Thread Bjorn Andersson
On Wed 22 Mar 11:44 PDT 2017, David Miller wrote: > From: Bjorn Andersson <bjorn.anders...@linaro.org> > Date: Mon, 20 Mar 2017 16:35:42 -0700 > > > By moving these client drivers to use RPMSG instead of the direct SMD > > API we can reuse them ontop of the newl

[PATCH 3/3] soc: qcom: smd-rpm: Add msm8996 compatibility

2017-03-20 Thread Bjorn Andersson
With the RPM driver transitioned to RPMSG we can reuse the SMD-RPM driver ontop of GLINK for 8996, without any modifications. Signed-off-by: Bjorn Andersson <bjorn.anders...@linaro.org> --- drivers/soc/qcom/smd-rpm.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/soc/qcom/smd

[PATCH 1/3] soc: qcom: smd: Transition client drivers from smd to rpmsg

2017-03-20 Thread Bjorn Andersson
drivers in one commit, to make sure we have a working system before and after this transition. Signed-off-by: Bjorn Andersson <bjorn.anders...@linaro.org> --- Based on v4.11-rc3 with Arnd's Kconfig dependency fixes for BT_QCOMSMD (https://lkml.org/lkml/2017/3/20/1038). drivers/bluetooth/K

[PATCH 2/3] soc: qcom: smd: Remove standalone driver

2017-03-20 Thread Bjorn Andersson
Remove the standalone SMD implementation as we have transitioned the client drivers to use the RPMSG based one. Also remove all dependencies on QCOM_SMD from Kconfig files, in order to keep them selectable in the absence of the removed symbol. Signed-off-by: Bjorn Andersson <bjorn.and

[PATCH] wcn36xx: Implement cancel_hw_scan

2017-02-01 Thread Bjorn Andersson
In the even that the wcn36xx interface is brought down while a hw_scan is active we must abort and wait for the ongoing scan to signal completion to mac80211. Reported-by: Mart Raudsepp <l...@gentoo.org> Fixes: 886039036c20 ("wcn36xx: Implement firmware assisted scan") Sign

Re: [PATCH] net: qrtr: Mark 'buf' as little endian

2017-01-09 Thread Bjorn Andersson
:16:got restricted __le32 [usertype] > net/qrtr/qrtr.c:276:16: warning: incorrect type in assignment (different base > types) > net/qrtr/qrtr.c:276:16:expected unsigned int [unsigned] [usertype] > > net/qrtr/qrtr.c:276:16:got restricted __le32 [usertype] > > Sile

Re: [v5,1/5] soc: qcom: smem_state: Fix include for ERR_PTR()

2016-11-18 Thread Bjorn Andersson
On Wed 16 Nov 10:49 PST 2016, Kalle Valo wrote: > Bjorn Andersson <bjorn.anders...@linaro.org> wrote: > > The correct include file for getting errno constants and ERR_PTR() is > > linux/err.h, rather than linux/errno.h, so fix the include. > > > > Fixes: e8b123e6

[PATCH v5 5/5] wcn36xx: Don't use the destroyed hal_mutex

2016-11-14 Thread Bjorn Andersson
ieee80211_unregister_hw() might invoke operations to stop the interface, that uses the hal_mutex. So don't destroy it until after we're done using it. Signed-off-by: Bjorn Andersson <bjorn.anders...@linaro.org> --- With this patch I can successfully (although with a SMD send t

[PATCH v5 1/5] soc: qcom: smem_state: Fix include for ERR_PTR()

2016-11-14 Thread Bjorn Andersson
The correct include file for getting errno constants and ERR_PTR() is linux/err.h, rather than linux/errno.h, so fix the include. Fixes: e8b123e60084 ("soc: qcom: smem_state: Add stubs for disabled smem_state") Acked-by: Andy Gross <andy.gr...@linaro.org> Signed-off-by:

[PATCH v5 4/5] wcn36xx: Implement print_reg indication

2016-11-14 Thread Bjorn Andersson
Some firmware versions sends a "print register indication", handle this by printing out the content. Cc: Nicolas Dechesne <n...@linaro.org> Signed-off-by: Bjorn Andersson <bjorn.anders...@linaro.org> --- Changes since v4: - None drivers/net/wireless/

[PATCH v5 3/5] wcn36xx: Implement firmware assisted scan

2016-11-14 Thread Bjorn Andersson
Using the software based channel scan mechanism from mac80211 keeps us offline for 10-15 second, we should instead issue a start_scan/end_scan on each channel reducing this time. Signed-off-by: Bjorn Andersson <bjorn.anders...@linaro.org> --- Changes since v4: - None drivers/net/wirele

[PATCH v5 2/5] wcn36xx: Transition driver to SMD client

2016-11-14 Thread Bjorn Andersson
The wcn36xx wifi driver follows the life cycle of the WLAN_CTRL SMD channel, as such it should be a SMD client. This patch makes this transition, now that we have the necessary frameworks available. Signed-off-by: Bjorn Andersson <bjorn.anders...@linaro.org> --- Changes since v4: - Added K

Re: [PATCH 1/2] wcn36xx: Correct Kconfig dependency

2016-11-09 Thread Bjorn Andersson
case either of > > those are =n, for compile testing reasons. > > > > Signed-off-by: Bjorn Andersson <bjorn.anders...@linaro.org> > > --- > > drivers/net/wireless/ath/wcn36xx/Kconfig | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --

[PATCH 2/2] soc: qcom: smem_state: Fix include for ERR_PTR()

2016-11-09 Thread Bjorn Andersson
The correct include file for getting errno constants and ERR_PTR() is linux/err.h, rather than linux/errno.h, so fix the include. Fixes: e8b123e60084 ("soc: qcom: smem_state: Add stubs for disabled smem_state") Signed-off-by: Bjorn Andersson <bjorn.anders...@linaro.org> --- A

[PATCH 1/2] wcn36xx: Correct Kconfig dependency

2016-11-09 Thread Bjorn Andersson
In the case SMD or WCNSS_CTRL are compiled as modules, wcn36xx must be compiled as module as well, so we need to mention this dependency. But we still want allow the driver to be compiled in case either of those are =n, for compile testing reasons. Signed-off-by: Bjorn Andersson <bjorn.and

Re: [PATCH v4 2/4] wcn36xx: Transition driver to SMD client

2016-09-08 Thread Bjorn Andersson
On Thu 08 Sep 10:35 PDT 2016, Kalle Valo wrote: > Bjorn Andersson <bjorn.anders...@linaro.org> writes: > > > On Thu, Sep 8, 2016 at 5:16 AM, Kalle Valo <kv...@codeaurora.org> wrote: > >> Bjorn Andersson <bjorn.anders...@linaro.org> writes: > >>

[PATCH v4 2/4] wcn36xx: Transition driver to SMD client

2016-09-06 Thread Bjorn Andersson
The wcn36xx wifi driver follows the life cycle of the WLAN_CTRL SMD channel, as such it should be a SMD client. This patch makes this transition, now that we have the necessary frameworks available. Signed-off-by: Bjorn Andersson <bjorn.anders...@linaro.org> --- Changes since v3:

[PATCH v4 3/4] wcn36xx: Implement firmware assisted scan

2016-09-06 Thread Bjorn Andersson
Using the software based channel scan mechanism from mac80211 keeps us offline for 10-15 second, we should instead issue a start_scan/end_scan on each channel reducing this time. Signed-off-by: Bjorn Andersson <bjorn.anders...@linaro.org> --- Changes since v3: - None Changes since v2: -

[PATCH v4 1/4] soc: qcom: wcnss_ctrl: Stub wcnss_ctrl API

2016-09-06 Thread Bjorn Andersson
Stub the wcnss_ctrl API to allow compile testing wcnss function drivers. Cc: Marcel Holtmann <mar...@holtmann.org> Signed-off-by: Bjorn Andersson <bjorn.anders...@linaro.org> --- There are no other pending changes colliding with this, so if Andy is okay with this it could be me

[PATCH v4 4/4] wcn36xx: Implement print_reg indication

2016-09-06 Thread Bjorn Andersson
Some firmware versions sends a "print register indication", handle this by printing out the content. Cc: Nicolas Dechesne <n...@linaro.org> Signed-off-by: Bjorn Andersson <bjorn.anders...@linaro.org> --- Changes since v3: - Rebased separate patch onto this series dr

Re: [PATCH v3 1/2] wcn36xx: Transition driver to SMD client

2016-09-02 Thread Bjorn Andersson
On Fri 02 Sep 09:24 PDT 2016, Kalle Valo wrote: > Bjorn Andersson <bjorn.anders...@linaro.org> writes: > > > The wcn36xx wifi driver follows the life cycle of the WLAN_CTRL SMD > > channel, as such it should be a SMD client. This patch makes this > > transition,

[PATCH v3 1/2] wcn36xx: Transition driver to SMD client

2016-09-01 Thread Bjorn Andersson
The wcn36xx wifi driver follows the life cycle of the WLAN_CTRL SMD channel, as such it should be a SMD client. This patch makes this transition, now that we have the necessary frameworks available. Signed-off-by: Bjorn Andersson <bjorn.anders...@linaro.org> --- Changes since v2: - C

[PATCH v3 2/2] wcn36xx: Implement firmware assisted scan

2016-09-01 Thread Bjorn Andersson
Using the software based channel scan mechanism from mac80211 keeps us offline for 10-15 second, we should instead issue a start_scan/end_scan on each channel reducing this time. Signed-off-by: Bjorn Andersson <bjorn.anders...@linaro.org> --- Changes since v2: - None drivers/net/wirele

  1   2   >