Re: [PATCH net-next 7/8] net: eth: altera: tse: add msgdma prefetcher

2018-11-27 Thread Dalon Westergreen
On Fri, 2018-11-16 at 09:20 -0600, Thor Thayer wrote: > Hi Dalon, > > Just a few comments/questions. > > On 11/14/18 6:50 PM, Dalon Westergreen wrote: > > From: Dalon Westergreen > > > > Add support for the mSGDMA prefetcher. The prefetcher adds support >

Re: [PATCH net-next 6/8] net: eth: altera: tse: add support for ptp and timestamping

2018-11-16 Thread Dalon Westergreen
On Thu, 2018-11-15 at 18:14 -0800, Richard Cochran wrote: > On Thu, Nov 15, 2018 at 06:55:29AM -0800, Dalon Westergreen wrote: > > I would prefer to keep altera just to be consistent with the altera_tse > > stuff, > > and i intend to reusethis code for a 10GbE driver,

Re: [PATCH net-next 6/8] net: eth: altera: tse: add support for ptp and timestamping

2018-11-16 Thread Dalon Westergreen
On Thu, 2018-11-15 at 18:14 -0800, Richard Cochran wrote: > On Thu, Nov 15, 2018 at 06:55:29AM -0800, Dalon Westergreen wrote: > > Sure, I would like to keep the debugfs entries for disabling freq > > correction,and > > reading the current scaled_ppm value. I intend

[PATCH net-next 5/8] net: eth: altera: tse: Move common functions to altera_utils

2018-11-14 Thread Dalon Westergreen
From: Dalon Westergreen Move request_and_map and other shared functions to altera_utils. This is the first step to moving common code out of tse specific code so that it can be shared with future altera ethernet ip. Signed-off-by: Dalon Westergreen --- drivers/net/ethernet/altera/altera_tse.h

[PATCH net-next 8/8] net: eth: altera: tse: update devicetree bindings documentation

2018-11-14 Thread Dalon Westergreen
From: Dalon Westergreen Update devicetree bindings documentation to include msgdma prefetcher and ptp bindings. Signed-off-by: Dalon Westergreen --- .../devicetree/bindings/net/altera_tse.txt| 98 +++ 1 file changed, 79 insertions(+), 19 deletions(-) diff --git

[PATCH net-next 7/8] net: eth: altera: tse: add msgdma prefetcher

2018-11-14 Thread Dalon Westergreen
From: Dalon Westergreen Add support for the mSGDMA prefetcher. The prefetcher adds support for a linked list of descriptors in system memory. The prefetcher feeds these to the mSGDMA dispatcher. The prefetcher is configured to poll for the next descriptor in the list to be owned by hardware

[PATCH net-next 4/8] net: eth: altera: tse: add optional function to start tx dma

2018-11-14 Thread Dalon Westergreen
From: Dalon Westergreen Allow for optional start up of tx dma if the start_txdma function is defined in altera_dmaops. Signed-off-by: Dalon Westergreen --- drivers/net/ethernet/altera/altera_tse.h | 1 + drivers/net/ethernet/altera/altera_tse_main.c | 5 + 2 files changed, 6

[PATCH net-next 6/8] net: eth: altera: tse: add support for ptp and timestamping

2018-11-14 Thread Dalon Westergreen
From: Dalon Westergreen Add support for the ptp clock used with the tse, and update the driver to support timestamping when enabled. We also enable debugfs entries for the ptp clock to allow some user control and interaction with the ptp clock. Signed-off-by: Dalon Westergreen --- drivers

[PATCH net-next 0/8] net: eth: altera: tse: Add PTP and mSGDMA prefetcher

2018-11-14 Thread Dalon Westergreen
From: Dalon Westergreen This patch series cleans up the Altera TSE driver and adds support for the newer msgdma prefetcher as well as ptp support when using the msgdma prefetcher. Dalon Westergreen (8): net: eth: altera: tse_start_xmit ignores tx_buffer call response net: eth: altera: set

[PATCH net-next 3/8] net: eth: altera: tse: fix altera_dmaops declaration

2018-11-14 Thread Dalon Westergreen
From: Dalon Westergreen The declaration of struct altera_dmaops does not have identifier names. Add identifier names to confrom with required coding styles. Signed-off-by: Dalon Westergreen --- drivers/net/ethernet/altera/altera_tse.h | 30 +--- 1 file changed, 16

[PATCH net-next 2/8] net: eth: altera: set rx and tx ring size before init_dma call

2018-11-14 Thread Dalon Westergreen
From: Dalon Westergreen It is more appropriate to set the rx and tx ring size before calling the init function for the dma. Signed-off-by: Dalon Westergreen --- drivers/net/ethernet/altera/altera_tse_main.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/net

[PATCH net-next 1/8] net: eth: altera: tse_start_xmit ignores tx_buffer call response

2018-11-14 Thread Dalon Westergreen
From: Dalon Westergreen The return from tx_buffer call in tse_start_xmit is inapropriately ignored. tse_buffer calls should return 0 for success or NETDEV_TX_BUSY. tse_start_xmit should return not report a successful transmit when the tse_buffer call returns an error condition. In addition