Re: [PATCH net V2] vhost: correctly remove wait queue during poll failure

2018-03-27 Thread Darren Kenny
eue to make sure it won't be freed twice. Cc: Darren Kenny <darren.ke...@oracle.com> Reported-by: syzbot+c0272972b01b872e6...@syzkaller.appspotmail.com Fixes: 2b8b328b61c79 ("vhost_net: handle polling errors when setting backend") Signed-off-by: Jason Wang <jasow...@redhat.com&

Re: [PATCH net] vhost: correctly remove wait queue during poll failure

2018-03-27 Thread Darren Kenny
Hi Jason, On Tue, Mar 27, 2018 at 11:47:22AM +0800, Jason Wang wrote: We tried to remove vq poll from wait queue, but do not check whether or not it was in a list before. This will lead double free. Fixing this by checking poll->wqh to make sure it was in a list. This text seems at odds with

Re: [PATCH] vhost: fix vhost ioctl signature to build with clang

2018-03-15 Thread Darren Kenny
(). Signed-off-by: Sonny Rao <sonny...@chromium.org> Reviewed-by: Darren Kenny <darren.ke...@oracle.com> All the other callers of this function already appear to assume that it is an unsigned int. Thanks, Darren. --- drivers/vhost/vhost.c | 2 +- drivers/vhost/vhost.h | 4 ++-- 2 f