Re: [PATCH 06/28] aio: implement IOCB_CMD_POLL

eff Moyer <jmo...@redhat.com> Looks ok, Reviewed-by: Darrick J. Wong <darrick.w...@oracle.com> After this point in the series my familiarity with network code and sockets drops way off, so please don't be too surprised if I don't get any further

Re: [PATCH 03/28] fs: update documentation to mention __poll_t

led patch that updated the docs but dropped the actual code update)... ...so with that fixed, Reviewed-by: Darrick J. Wong <darrick.w...@oracle.com> --D > --- > Documentation/filesystems/Locking | 2 +- > Documentation/filesystems/vfs.txt | 2 +- > 2 files changed, 2 insertions(+

Re: [PATCH 05/28] fs: introduce new ->get_poll_head and ->poll_mask methods

h Hellwig <h...@lst.de> Looks ok, Reviewed-by: Darrick J. Wong <darrick.w...@oracle.com> --D > --- > Documentation/filesystems/Locking | 7 ++- > Documentation/filesystems/vfs.txt | 13 + > fs/select.c | 28 +++

Re: [PATCH 13/36] fs: introduce new ->get_poll_head and ->poll_mask methods

On Mon, Mar 05, 2018 at 01:27:20PM -0800, Christoph Hellwig wrote: > ->get_poll_head returns the waitqueue that the poll operation is going > to sleep on. Note that this means we can only use a single waitqueue > for the poll, unlike some current drivers that use two waitqueues for > different

Re: [PATCH 07/36] aio: add delayed cancel support

On Mon, Mar 05, 2018 at 01:27:14PM -0800, Christoph Hellwig wrote: > The upcoming aio poll support would like to be able to complete the > iocb inline from the cancellation context, but that would cause > a lock order reversal. Add support for optionally moving the cancelation > outside the

Re: [PATCH 12/36] fs: add new vfs_poll and file_can_poll helpers

| 12 > mm/memcontrol.c | 2 +- For the fs/include/mm changes, Reviewed-by: Darrick J. Wong <darrick.w...@oracle.com> The other conversions look fine to me too but I've never looked at them before. :) --D > net/9p/trans_fd.c

Re: [PATCH 11/36] fs: update documentation for __poll_t

On Mon, Mar 05, 2018 at 01:27:18PM -0800, Christoph Hellwig wrote: No commit message... "Update documentation to match the headers"? --D > Signed-off-by: Christoph Hellwig > --- > Documentation/filesystems/Locking | 2 +- > Documentation/filesystems/vfs.txt | 2 +- > 2 files

Re: [PATCH 10/36] fs: cleanup do_pollfd

On Mon, Mar 05, 2018 at 01:27:17PM -0800, Christoph Hellwig wrote: > Use straigline code with failure handling gotos instead of a lot > of nested conditionals. > > Signed-off-by: Christoph Hellwig <h...@lst.de> Looks ok, Reviewed-by: Darrick J. Wong <darrick.w...@oracle.c

Re: [PATCH 09/36] fs: unexport poll_schedule_timeout

On Mon, Mar 05, 2018 at 01:27:16PM -0800, Christoph Hellwig wrote: > No users outside of select.c. > > Signed-off-by: Christoph Hellwig <h...@lst.de> Looks ok, Reviewed-by: Darrick J. Wong <darrick.w...@oracle.com> --D > --- > fs/select.c | 3 +-- > in

Re: [PATCH 08/36] aio: implement io_pgetevents

On Mon, Mar 05, 2018 at 01:27:15PM -0800, Christoph Hellwig wrote: > This is the io_getevents equivalent of ppoll/pselect and allows to > properly mix signals and aio completions (especially with IOCB_CMD_POLL) > and atomically executes the following sequence: > > sigset_t origmask; > >

Re: [PATCH 06/36] aio: delete iocbs from the active_reqs list in kiocb_cancel

d-by: Jeff Moyer <jmo...@redhat.com> Reviewed-by: Darrick J. Wong <darrick.w...@oracle.com> --D > --- > fs/aio.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/fs/aio.c b/fs/aio.c > index 2d40cf5dd4ec..0b6394b4e528 100644 > --- a/fs/a

Re: [PATCH 05/36] aio: simplify cancellation

*cancel) > } > EXPORT_SYMBOL(kiocb_set_cancel_fn); > > +/* > + * Only cancel if there ws a ki_cancel function to start with, and we > + * are the one how managed to clear it (to protect against simulatinious "...are the one who managed to clear it (to protect against simultaneous cancel

Re: [PATCH 04/36] aio: sanitize ki_list handling

of ignoring it. > > Signed-off-by: Christoph Hellwig <h...@lst.de> > Acked-by: Jeff Moyer <jmo...@redhat.com> Reviewed-by: Darrick J. Wong <darrick.w...@oracle.com> --D > --- > fs/aio.c | 13 ++--- > 1 file changed, 6 insertions(+), 7 deletions(

Re: [PATCH 03/36] aio: refactor read/write iocb setup

> fields. > > Signed-off-by: Christoph Hellwig <h...@lst.de> > Acked-by: Jeff Moyer <jmo...@redhat.com> Looks straightforward enough to me, Reviewed-by: Darrick J. Wong <darrick.w...@oracle.com> --D > --- > fs/aio.c | 171 > +

Re: [PATCH 02/36] aio: remove an outdated comment in aio_complete

toph Hellwig <h...@lst.de> > Acked-by: Jeff Moyer <jmo...@redhat.com> Looks ok, Reviewed-by: Darrick J. Wong <darrick.w...@oracle.com> --D > --- > fs/aio.c | 11 ++- > 1 file changed, 2 insertions(+), 9 deletions(-) > > diff --git a/fs/aio.c b

Re: [PATCH 01/36] aio: don't print the page size at boot time

..@redhat.com> Looks ok, Reviewed-by: Darrick J. Wong <darrick.w...@oracle.com> --D > --- > fs/aio.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/fs/aio.c b/fs/aio.c > index a062d75109cb..03d59593912d 100644 > --- a/fs/aio.c > +++ b/fs/aio

Re: [trivial PATCH] treewide: Align function definition open/close braces

*bp) > - { > +{ > struct xfs_agf *agf = XFS_BUF_TO_AGF(bp); > > if (xfs_sb_version_hascrc(>m_sb)) { > @@ -2449,8 +2449,7 @@ xfs_agf_verify( >be32_to_cpu(agf->agf_refcount_level) > XFS_BTREE_MAXLEVELS)) > return false; > >

Re: [PATCH v9 0/5] Add the ability to do BPF directed error injection

On Wed, Dec 13, 2017 at 01:03:57PM -0500, Josef Bacik wrote: > On Tue, Dec 12, 2017 at 03:11:50PM -0800, Darrick J. Wong wrote: > > On Mon, Dec 11, 2017 at 11:36:45AM -0500, Josef Bacik wrote: > > > This is the same as v8, just rebased onto the bpf tree. > > > > &g

Re: [PATCH v9 0/5] Add the ability to do BPF directed error injection

On Mon, Dec 11, 2017 at 11:36:45AM -0500, Josef Bacik wrote: > This is the same as v8, just rebased onto the bpf tree. > > v8->v9: > - rebased onto the bpf tree. > > v7->v8: > - removed the _ASM_KPROBE_ERROR_INJECT since it was not needed. > > v6->v7: > - moved the opt-in macro to bpf.h out of