Re: [PATCH net 0/3] mlx4 fixes for 4.20-rc

2018-11-15 Thread David Miller
From: Tariq Toukan Date: Thu, 15 Nov 2018 18:05:12 +0200 > This patchset includes small fixes for mlx4_core driver. Series applied.

Re: [Patch net-next] net: remove unused skb_send_sock()

2018-11-15 Thread David Miller
From: Cong Wang Date: Mon, 12 Nov 2018 18:05:24 -0800 > Signed-off-by: Cong Wang John, any plans to use this? Looks like only skb_send_sock_lock() currently has a user.

Re: [PATCH][net-next] net: slightly optimize eth_type_trans

2018-11-15 Thread David Miller
From: Li RongQing Date: Tue, 13 Nov 2018 09:34:31 +0800 > netperf udp stream shows that eth_type_trans takes certain cpu, > so adjust the mac address check order, and firstly check if it > is device address, and only check if it is multicast address > only if not the device address. > > After

Re: [PATCH][net-next][v2] net: remove BUG_ON from __pskb_pull_tail

2018-11-15 Thread David Miller
From: Li RongQing Date: Tue, 13 Nov 2018 09:16:52 +0800 > if list is NULL pointer, and the following access of list > will trigger panic, which is same as BUG_ON > > Signed-off-by: Li RongQing Applied.

Re: [net-next 00/14][pull request] 40GbE Intel Wired LAN Driver Updates 2018-11-14

2018-11-15 Thread David Miller
From: Jeff Kirsher Date: Wed, 14 Nov 2018 15:10:18 -0800 > This series contains updates to i40e and virtchnl. Pulled, thanks Jeff.

Re: [PATCH net-next 00/11] mlxsw: spectrum: acl: Introduce ERP sharing by multiple masks

2018-11-15 Thread David Miller
From: Ido Schimmel Date: Wed, 14 Nov 2018 08:22:25 + > Jiri says: > > The Spectrum-2 hardware has limitation number of ERPs per-region. In > order to accommodate more masks than number of ERPs, the hardware > supports to insert rules with delta bits. By that, the rules with masks > that

Re: [PATCH net] net_sched: sch_fq: ensure maxrate fq parameter applies to EDT flows

2018-11-15 Thread David Miller
From: Eric Dumazet Date: Mon, 12 Nov 2018 16:17:16 -0800 > When EDT conversion happened, fq lost the ability to enfore a maxrate > for all flows. It kept it for non EDT flows. > > This commit restores the functionality. > > Tested: > > tc qd replace dev eth0 root fq maxrate 500Mbit > netperf

Re: [net-next PATCH v4] net: sched: cls_flower: Classify packets using port ranges

2018-11-15 Thread David Miller
From: Amritha Nambiar Date: Mon, 12 Nov 2018 16:15:55 -0800 > Added support in tc flower for filtering based on port ranges. > > Example: ... > v4: > 1. Added condition before setting port key. > 2. Organized setting and dumping port range keys into functions >and added validation of input

Re: [Patch net-next v2] net: dump more useful information in netdev_rx_csum_fault()

2018-11-15 Thread David Miller
From: Cong Wang Date: Mon, 12 Nov 2018 14:47:18 -0800 > Currently netdev_rx_csum_fault() only shows a device name, > we need more information about the skb for debugging csum > failures. > > Sample output: > > ens3: hw csum failure > dev features: 0x00014b89 > skb len=84 data_len=0

Re: [PATCHv2 net-net] net: dsa: mv88e6xxx: Work around mv886e6161 SERDES missing MII_PHYSID2

2018-11-15 Thread David Miller
From: Andrew Lunn Date: Mon, 12 Nov 2018 18:51:01 +0100 > We already have a workaround for a couple of switches whose internal > PHYs only have the Marvel OUI, but no model number. We detect such > PHYs and give them the 6390 ID as the model number. However the > mv88e6161 has two SERDES

Re: [net-next 00/11][pull request] 100GbE Intel Wired LAN Driver Updates 2018-11-13

2018-11-15 Thread David Miller
From: Jeff Kirsher Date: Tue, 13 Nov 2018 10:32:28 -0800 > This series contains updates to the ice driver only. Pulled, thanks Jeff.

Re: [PATCH net V2 0/5] net/smc: fixes 2018-11-12

2018-11-15 Thread David Miller
From: Ursula Braun Date: Thu, 15 Nov 2018 13:11:15 +0100 > v1->v2: >do not define 8-byte alignment for union smcd_cdc_cursor in >patch 4/5 "net/smc: atomic SMCD cursor handling" This is even worse. The atomic64_t must be properly 8 byte aligned, else it will crash the kernel when an

Re: [PATCH net V2] cxgb4: fix thermal zone build error

2018-11-15 Thread David Miller
From: Ganesh Goudar Date: Thu, 15 Nov 2018 15:36:21 +0530 > with CONFIG_THERMAL=m and cxgb4 as built-in build fails, and > 'commit e70a57fa59bb ("cxgb4: fix thermal configuration dependencies")' > tries to fix it but when cxgb4i is made built-in build fails again, > use IS_REACHABLE instead of

Re: [PATCHv2] MAINTAINERS: Replace Vince Bridgers as Altera TSE maintainer

2018-11-15 Thread David Miller
From: thor.tha...@linux.intel.com Date: Mon, 12 Nov 2018 11:50:56 -0600 > From: Thor Thayer > > Vince has moved to a different role. Replace him as Altera > TSE maintainer. > > Signed-off-by: Thor Thayer > Acked-by: Vince Bridgers > Acked-by: Alan Tull > --- >

Re: [PATCH net 0/6] bnxt_en: Bug fixes.

2018-11-15 Thread David Miller
From: Michael Chan Date: Thu, 15 Nov 2018 03:25:36 -0500 > Most of the bug fixes are related to the new 57500 chips, including some > initialization and counter fixes, disabling RDMA support, and a > workaround for occasional missing interrupts. The last patch from > Vasundhara fixes the

Re: [PATCH net-next] net: phy: check for implementation of both callbacks in phy_drv_supports_irq

2018-11-15 Thread David Miller
From: Heiner Kallweit Date: Mon, 12 Nov 2018 21:16:06 +0100 > Now that the icplus driver has been fixed all PHY drivers supporting > interrupts have both callbacks (config_intr and ack_interrupt) > implemented - as it should be. Therefore phy_drv_supports_irq() > can be changed now to check for

Re: [PATCH net] l2tp: fix a sock refcnt leak in l2tp_tunnel_register

2018-11-14 Thread David Miller
From: Xin Long Date: Tue, 13 Nov 2018 01:08:25 +0800 > This issue happens when trying to add an existent tunnel. It > doesn't call sock_put() before returning -EEXIST to release > the sock refcnt that was held by calling sock_hold() before > the existence check. > > This patch is to fix it by

Re: [PATCH net-next 00/13] nfp: abm: track all Qdiscs

2018-11-14 Thread David Miller
From: Jakub Kicinski Date: Mon, 12 Nov 2018 14:58:06 -0800 > Our Qdisc offload so far has been very simplistic. We held > and array of marking thresholds and statistics sized to the > number of PF queues. This was sufficient since the only > configuration we supported was single layer of RED

Re: [PATCH net-next v2 0/6] net: aquantia: add rx-flow filter support

2018-11-14 Thread David Miller
From: Igor Russkikh Date: Mon, 12 Nov 2018 15:45:56 + > In this patchset the rx-flow filters functionality and vlan filter offloads > are implemented. > > The rules in NIC hardware have fixed order and priorities. > To support this, the locations of filters from ethtool perspective are also

Re: [PATCH net 4/5] net/smc: atomic SMCD cursor handling

2018-11-13 Thread David Miller
From: Ursula Braun Date: Mon, 12 Nov 2018 17:01:32 +0100 > +/* SMC-D cursor format */ > +union smcd_cdc_cursor { ... > +} __aligned(8); > struct smcd_cdc_msg { ... > + union smcd_cdc_cursor prod; > + union smcd_cdc_cursor cons; > u8 res3[8]; > } __packed; You're asking

Re: [PATCH net v2 0/4] qed: Miscellaneous bug fixes

2018-11-13 Thread David Miller
From: Denis Bolotin Date: Mon, 12 Nov 2018 12:50:19 +0200 > This patch series fixes several unrelated bugs across the driver. > Please consider applying to net. > > V1->V2: > --- > Use dma_rmb() instead of rmb(). Series applied, thank you.

Re: pull-request: can 2018-11-09

2018-11-13 Thread David Miller
From: Marc Kleine-Budde Date: Mon, 12 Nov 2018 12:57:08 +0100 > this is a pull request of 20 patches for net/master. Pulled, thanks Marc.

Re: [PATCH net-next 01/17] net: sched: refactor mini_qdisc_pair_swap() to use workqueue

2018-11-13 Thread David Miller
From: Vlad Buslov Date: Tue, 13 Nov 2018 13:13:19 + > > On Mon 12 Nov 2018 at 17:28, David Miller wrote: >> From: Vlad Buslov >> Date: Mon, 12 Nov 2018 09:55:30 +0200 >> >>> +void mini_qdisc_pair_swap(struct mini_Qdisc_pair *miniqp, >>> +

Re: [PATCH net-next 17/17] net: sched: unlock rules update API

2018-11-12 Thread David Miller
From: Vlad Buslov Date: Mon, 12 Nov 2018 09:55:46 +0200 > Register netlink protocol handlers for message types RTM_NEWTFILTER, > RTM_DELTFILTER, RTM_GETTFILTER as unlocked. Set rtnl_held variable that > tracks rtnl mutex state to be false by default. This whole conditional locking mechanism is

Re: [PATCH net-next 02/17] net: sched: protect block state with spinlock

2018-11-12 Thread David Miller
From: Vlad Buslov Date: Mon, 12 Nov 2018 09:55:31 +0200 > +#define ASSERT_BLOCK_LOCKED(block) \ > + WARN_ONCE(!spin_is_locked(&(block)->lock), \ > + "BLOCK: assertion failed at %s (%d)\n", __FILE__, __LINE__) spin_is_locked() is

Re: [PATCH net-next 01/17] net: sched: refactor mini_qdisc_pair_swap() to use workqueue

2018-11-12 Thread David Miller
From: Vlad Buslov Date: Mon, 12 Nov 2018 09:55:30 +0200 > +void mini_qdisc_pair_swap(struct mini_Qdisc_pair *miniqp, > + struct tcf_proto *tp_head) > +{ > + xchg(>tp_head, tp_head); If you are not checking the return value of xchg(), then this is simply a store with

Re: [PATCHv2 net-next 0/3] sctp: add support for sk_reuseport

2018-11-12 Thread David Miller
From: Xin Long Date: Mon, 12 Nov 2018 18:27:14 +0800 > sctp sk_reuseport allows multiple socks to listen on the same port and > addresses, as long as these socks have the same uid. This works pretty > much as TCP/UDP does, the only difference is that sctp is multi-homing > and all the bind_addrs

Re: [PATCH][net-next] net: remove BUG_ON from __pskb_pull_tail

2018-11-12 Thread David Miller
From: Li RongQing Date: Mon, 12 Nov 2018 17:26:13 +0800 > do { > - BUG_ON(!list); > Please get rid of the empty line afterwards as well. Thank you.

Re: [PATCH net v2 1/1] bnx2x: Assign unique DMAE channel number for FW DMAE transactions.

2018-11-12 Thread David Miller
From: Sudarsana Reddy Kalluru Date: Sun, 11 Nov 2018 18:27:34 -0800 > Driver assigns DMAE channel 0 for FW as part of START_RAMROD command. FW > uses this channel for DMAE operations (e.g., TIME_SYNC implementation). > Driver also uses the same channel 0 for DMAE operations for some of the PFs >

Re: [PATCH net-next v3] PCI: add USR vendor id and use it in r8169 and w6692 driver

2018-11-11 Thread David Miller
From: Heiner Kallweit Date: Sun, 11 Nov 2018 20:31:21 +0100 > The PCI vendor id of U.S. Robotics isn't defined in pci_ids.h so far, > only ISDN driver w6692 has a private definition. Move the definition > to pci_ids.h and use it in the r8169 driver too. > > Signed-off-by: Heiner Kallweit > ---

Re: [PATCH net-next] net_sched: sch_fq: add dctcp-like marking

2018-11-11 Thread David Miller
From: Eric Dumazet Date: Sun, 11 Nov 2018 09:11:31 -0800 > Similar to 80ba92fa1a92 ("codel: add ce_threshold attribute") > > After EDT adoption, it became easier to implement DCTCP-like CE marking. > > In many cases, queues are not building in the network fabric but on > the hosts themselves.

Re: [PATCH net-next] tcp: tsq: no longer use limit_output_bytes for paced flows

2018-11-11 Thread David Miller
From: Eric Dumazet Date: Sun, 11 Nov 2018 07:34:28 -0800 > FQ pacing guarantees that paced packets queued by one flow do not > add head-of-line blocking for other flows. > > After TCP GSO conversion, increasing limit_output_bytes to 1 MB is safe, > since this maps to 16 skbs at most in qdisc or

Re: [PATCH net-next 0/3] tcp: tso defer improvements

2018-11-11 Thread David Miller
From: Eric Dumazet Date: Sun, 11 Nov 2018 06:41:28 -0800 > This series makes tcp_tso_should_defer() a bit smarter : > > 1) MSG_EOR gives a hint to TCP to not defer some skbs > > 2) Second patch takes into account that head tstamp >can be in the future. > > 3) Third patch uses existing

Re: [PATCH net-next v2] PCI: add USR vendor id and use it in r8169 and w6692 driver

2018-11-11 Thread David Miller
From: Heiner Kallweit Date: Sun, 11 Nov 2018 11:50:08 +0100 > diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h > index 69f0abe1b..1fac231fe 100644 > --- a/include/linux/pci_ids.h > +++ b/include/linux/pci_ids.h > @@ -2359,6 +2359,10 @@ > > #define PCI_VENDOR_ID_SYNOPSYS

Re: [PATCH net 4/4] qed: Fix reading wrong value in loop condition

2018-11-11 Thread David Miller
From: Denis Bolotin Date: Sun, 11 Nov 2018 17:05:00 +0200 > diff --git a/drivers/net/ethernet/qlogic/qed/qed_int.c > b/drivers/net/ethernet/qlogic/qed/qed_int.c > index 0f0aba7..aa7504a 100644 > --- a/drivers/net/ethernet/qlogic/qed/qed_int.c > +++ b/drivers/net/ethernet/qlogic/qed/qed_int.c >

Re: [PATCH net] act_mirred: clear skb->tstamp on redirect

2018-11-11 Thread David Miller
From: Eric Dumazet Date: Sat, 10 Nov 2018 16:22:29 -0800 > If sch_fq is used at ingress, skbs that might have been > timestamped by net_timestamp_set() if a packet capture > is requesting timestamps could be delayed by arbitrary > amount of time, since sch_fq time base is MONOTONIC. > > Fix

Re: [PATCH net-next] net: dsa: mv88e6xxx: Work around mv886e6161 SERDES missing MII_PHYSID2

2018-11-11 Thread David Miller
From: Andrew Lunn Date: Sun, 11 Nov 2018 00:50:39 +0100 > We already have a workaround for a couple of switches whose internal > PHYs only have the Marvel OUI, but no model number. We detect such > PHYs and give them the 6390 ID as the model number. However the > mv88e6161 has two SERDES

Re: [patch net] net: dsa: mv88e6xxx: Fix clearing of stats counters

2018-11-11 Thread David Miller
From: Andrew Lunn Date: Sun, 11 Nov 2018 00:41:10 +0100 > The mv88e6161 would sometime fail to probe with a timeout waiting for > the switch to complete an operation. This operation is supposed to > clear the statistics counters. However, due to a read/modify/write, > without the needed mask,

Re: [PATCH net-next 0/4] net: dsa: mv88e6xxx: Support more SERDES interfacxes

2018-11-11 Thread David Miller
From: Andrew Lunn Date: Sun, 11 Nov 2018 00:32:13 +0100 > Currently the SERDES interfaces for ports 9 and 10 on the mv88e6390x > are supported, allowing upto 10G. However, when unused, these SERDES > interfaces can be used by some of the lower ports for 1000Base-X. > > The tricky bit here is

Re: [PATCH net-next 0/5] net: phy: convert advertise and supported to linkmode

2018-11-11 Thread David Miller
From: Andrew Lunn Date: Sat, 10 Nov 2018 23:43:32 +0100 > This is the last part in converting phylib to make use of a linux > bitmap, not a u32, to represent links modes. This will allow support > for PHYs > 1Gbps, which need to use link modes represented by a bit > > 32. > > A number of MAC

Re: [PATCH net-next] net: phy: remove states PHY_STARTING and PHY_PENDING

2018-11-11 Thread David Miller
From: Heiner Kallweit Date: Sat, 10 Nov 2018 23:40:50 +0100 > Both states aren't used. Most likely they result from an idea that > never materialized. So remove them. > > Signed-off-by: Heiner Kallweit Applied.

Re: [PATCH net-next v2] documentation of some IP/ICMP snmp counters

2018-11-11 Thread David Miller
From: yupeng Date: Sat, 10 Nov 2018 13:38:12 -0800 > The snmp_counter.rst explains the meanings of snmp counters. It also > provides a set of experiments (only 1 for this initial patch), > combines the experiments' resutls and the snmp counters' > meanings. This is an initial path, only explains

Re: [PATCH net-next 0/6] net: sched: indirect tc block cb registration

2018-11-11 Thread David Miller
From: Jakub Kicinski Date: Fri, 9 Nov 2018 21:21:25 -0800 > John says: > > This patchset introduces an alternative to egdev offload by allowing a > driver to register for block updates when an external device (e.g. tunnel > netdev) is bound to a TC block. Drivers can track new netdevs or

Re: [PATCH net-next 0/2] net: phy: add macros for PHYID matching in PHY driver config

2018-11-11 Thread David Miller
From: Heiner Kallweit Date: Sat, 10 Nov 2018 00:37:46 +0100 > Add macros for PHYID matching to be used in PHY driver configs. > By using these macros some boilerplate code can be avoided. > > Use them initially in the Realtek PHY drivers. Series applied.

Re: [PATCH net-next 0/3] net: phy: further phylib simplifications after recent changes to the state machine

2018-11-11 Thread David Miller
From: Heiner Kallweit Date: Fri, 9 Nov 2018 18:54:49 +0100 > After the recent changes to the state machine phylib can be further > simplified (w/o having to make any assumptions). Nothing exemplifies understanding of a piece of code like a patch series like this, nice work. Series applied.

[PATCH net-next] sctp: Fix SKB list traversal in sctp_intl_store_ordered().

2018-11-10 Thread David Miller
Same change as made to sctp_intl_store_reasm(). To be fully correct, an iterator has an undefined value when something like skb_queue_walk() naturally terminates. This will actually matter when SKB queues are converted over to list_head. Formalize what this code ends up doing with the current

[PATCH net-next] sctp: Fix SKB list traversal in sctp_intl_store_reasm().

2018-11-10 Thread David Miller
To be fully correct, an iterator has an undefined value when something like skb_queue_walk() naturally terminates. This will actually matter when SKB queues are converted over to list_head. Formalize what this code ends up doing with the current implementation. Signed-off-by: David S. Miller

[PATCH] iucv: Remove SKB list assumptions.

2018-11-10 Thread David Miller
Eliminate the assumption that SKBs and SKB list heads can be cast to eachother in SKB list handling code. This change also appears to fix a bug since the list->next pointer is sampled outside of holding the SKB queue lock. Signed-off-by: David S. Miller --- net/iucv/af_iucv.c | 41

Re: [PATCH net-next] OVS: remove VLAN_TAG_PRESENT - fixup

2018-11-10 Thread David Miller
From: Michał Mirosław Date: Sat, 10 Nov 2018 19:55:34 +0100 > It turns out I missed one VLAN_TAG_PRESENT in OVS code while rebasing. > This fixes it. > > Fixes: 9df46aefafa6 ("OVS: remove use of VLAN_TAG_PRESENT") > Signed-off-by: Michał Mirosław Applied, thanks.

Re: [PATCH net v2] net: sched: cls_flower: validate nested enc_opts_policy to avoid warning

2018-11-10 Thread David Miller
From: Jakub Kicinski Date: Fri, 9 Nov 2018 21:06:26 -0800 > TCA_FLOWER_KEY_ENC_OPTS and TCA_FLOWER_KEY_ENC_OPTS_MASK can only > currently contain further nested attributes, which are parsed by > hand, so the policy is never actually used resulting in a W=1 > build warning: > >

Re: [PATCH net-next] udp6: cleanup stats accounting in recvmsg()

2018-11-09 Thread David Miller
From: Paolo Abeni Date: Fri, 9 Nov 2018 15:52:45 +0100 > In the udp6 code path, we needed multiple tests to select the correct > mib to be updated. Since we touch at least a counter at each iteration, > it's convenient to use the recently introduced __UDPX_MIB() helper once > and remove some

Re: [PATCH net-next v2 0/2] dpaa2-eth: defer probe on object allocate

2018-11-09 Thread David Miller
From: Ioana Ciornei Date: Fri, 9 Nov 2018 15:26:45 + > Allocatable objects on the fsl-mc bus may be probed by the fsl_mc_allocator > after the first attempts of other drivers to use them. Defer the probe when > this situation happens. > > Changes in v2: > - proper handling of

Re: [PATCH net] flow_dissector: do not dissect l4 ports for fragments

2018-11-09 Thread David Miller
From: Eric Dumazet Date: Fri, 9 Nov 2018 16:53:06 -0800 > From: 배석진 > > Only first fragment has the sport/dport information, > not the following ones. > > If we want consistent hash for all fragments, we need to > ignore ports even for first fragment. > > This bug is visible for IPv6

Re: [PATCH net] net: sched: cls_flower: validate nested enc_opts_policy to avoid build warning

2018-11-09 Thread David Miller
From: Jakub Kicinski Date: Fri, 9 Nov 2018 14:41:22 -0800 > TCA_FLOWER_KEY_ENC_OPTS and TCA_FLOWER_KEY_ENC_OPTS_MASK can only > currently contain further nested attributes, which are parsed by > hand, so the policy is never actually used. Add the validation > anyway to avoid potential bugs

[PATCH] infiniband: nes: Fix more direct skb list accesses.

2018-11-09 Thread David Miller
The following: skb = skb->next; ... if (skb == (struct sk_buff *)queue) is transformed into: skb = skb_peek_next(skb, queue); ... if (!skb) Signed-off-by: David S. Miller --- drivers/infiniband/hw/nes/nes_mgt.c | 4 ++-- 1 file changed, 2

Re: [Patch net-next] net: dump more useful information in netdev_rx_csum_fault()

2018-11-09 Thread David Miller
From: Cong Wang Date: Fri, 9 Nov 2018 11:43:33 -0800 > diff --git a/net/core/datagram.c b/net/core/datagram.c > index 57f3a6fcfc1e..d8f4d55cd6c5 100644 > --- a/net/core/datagram.c > +++ b/net/core/datagram.c > @@ -736,7 +736,7 @@ __sum16 __skb_checksum_complete_head(struct sk_buff *skb, > int

Re: [PATCH v2 net-next] net: phy: improve struct phy_device member interrupts handling

2018-11-09 Thread David Miller
From: Heiner Kallweit Date: Fri, 9 Nov 2018 18:35:52 +0100 > As a heritage from the very early days of phylib member interrupts is > defined as u32 even though it's just a flag whether interrupts are > enabled. So we can change it to a bitfield member. In addition change > the code dealing with

Re: [PATCH net-next] nfp: use the new __netdev_tx_sent_queue() BQL optimisation

2018-11-09 Thread David Miller
From: Jakub Kicinski Date: Fri, 9 Nov 2018 18:50:00 -0800 > __netdev_tx_sent_queue() was added in commit e59020abf0f > ("net: bql: add __netdev_tx_sent_queue()") and allows for > better GSO performance. > > Signed-off-by: Jakub Kicinski > Reviewed-by: Dirk van der Merwe > Reviewed-by: Simon

Re: [PATCH net] net: qualcomm: rmnet: Fix incorrect assignment of real_dev

2018-11-09 Thread David Miller
From: Subash Abhinov Kasiviswanathan Date: Fri, 9 Nov 2018 18:56:27 -0700 > A null dereference was observed when a sysctl was being set > from userspace and rmnet was stuck trying to complete some actions > in the NETDEV_REGISTER callback. This is because the real_dev is set > only after the

Re: [PATCH net-next 0/8] More accurate PHC<->system clock synchronization

2018-11-09 Thread David Miller
From: Richard Cochran Date: Fri, 9 Nov 2018 17:44:31 -0800 > On Fri, Nov 09, 2018 at 03:28:46PM -0800, David Miller wrote: >> This series looks good to me but I want to give Richard an opportunity to >> review it first. > > The series is good to go. > > Acked-

Re: [PATCH net-next 0/8] More accurate PHC<->system clock synchronization

2018-11-09 Thread David Miller
From: Jeff Kirsher Date: Fri, 09 Nov 2018 15:33:10 -0800 > On Fri, 2018-11-09 at 15:28 -0800, David Miller wrote: >> From: Miroslav Lichvar >> Date: Fri, 9 Nov 2018 11:14:41 +0100 >> >> > RFC->v1: >> > - added new patches >> > - separated P

Re: [PATCH net 0/5] net: aquantia: 2018-11 bugfixes

2018-11-09 Thread David Miller
From: Igor Russkikh Date: Fri, 9 Nov 2018 11:53:54 + > The patchset fixes a number of bugs found in various areas after > driver validation. Series applied, thank you. Please, when you provide a Fixes: tag, do not separate it with the other Signed-off-by: and Acked-by: etc. tags with an

Re: [PATCH net-next 0/8] More accurate PHC<->system clock synchronization

2018-11-09 Thread David Miller
From: Miroslav Lichvar Date: Fri, 9 Nov 2018 11:14:41 +0100 > RFC->v1: > - added new patches > - separated PHC timestamp from ptp_system_timestamp > - fixed memory leak in PTP_SYS_OFFSET_EXTENDED > - changed PTP_SYS_OFFSET_EXTENDED to work with array of arrays > - fixed PTP_SYS_OFFSET_EXTENDED

Re: [PATCH net 1/1] bnx2x: Assign unique DMAE channel number for FW DMAE transactions.

2018-11-09 Thread David Miller
From: Sudarsana Reddy Kalluru Date: Fri, 9 Nov 2018 02:10:43 -0800 > +/* Following is the DMAE channel number allocation for the clients. > + * MFW: OCBB/OCSD implementations use DMAE channels 14/15 respectively. > + * Driver: 0-3 and 8-11 (for PF dmae operations) > + * 4 and 12

Re: [PATCH net-next] cxgb4vf: free mac_hlist properly

2018-11-09 Thread David Miller
From: Arjun Vynipadath Date: Fri, 9 Nov 2018 14:52:53 +0530 > The locally maintained list for tracking hash mac table was > not freed during driver remove. > > Signed-off-by: Arjun Vynipadath > Signed-off-by: Ganesh Goudar Applied.

Re: [PATCH net-next] cxgb4vf: fix memleak in mac_hlist initialization

2018-11-09 Thread David Miller
From: Arjun Vynipadath Date: Fri, 9 Nov 2018 14:52:01 +0530 > mac_hlist was initialized during adapter_up, which will be called > every time a vf device is first brought up, or every time when device > is brought up again after bringing all devices down. This means our > state of previous list

Re: [PATCH net-next] cxgb4: free mac_hlist properly

2018-11-09 Thread David Miller
From: Arjun Vynipadath Date: Fri, 9 Nov 2018 14:50:25 +0530 > The locally maintained list for tracking hash mac table was > not freed during driver remove. > > Signed-off-by: Arjun Vynipadath > Signed-off-by: Ganesh Goudar Applied.

Re: [PATCH][net-next] net: tcp: remove BUG_ON from tcp_v4_err

2018-11-09 Thread David Miller
From: Li RongQing Date: Fri, 9 Nov 2018 17:04:51 +0800 > if skb is NULL pointer, and the following access of skb's > skb_mstamp_ns will trigger panic, which is same as BUG_ON > > Signed-off-by: Li RongQing Applied.

Re: [PATCH net-next 0/7] nfp: abm: move code and improve parameter validation

2018-11-08 Thread David Miller
From: Jakub Kicinski Date: Thu, 8 Nov 2018 19:50:32 -0800 > This set starts by separating Qdisc handling code into a new file. > Next two patches allow early access to TLV-based capabilities during > probe, previously the capabilities were parsed just before netdevs > were registered, but its

Re: [PATCH net-next] tcp_bbr: update comments to reflect pacing_margin_percent

2018-11-08 Thread David Miller
From: Neal Cardwell Date: Thu, 8 Nov 2018 21:54:00 -0500 > Recently, in commit ab408b6dc744 ("tcp: switch tcp and sch_fq to new > earliest departure time model"), the TCP BBR code switched to a new > approach of using an explicit bbr_pacing_margin_percent for shaving a > pacing rate "haircut",

Re: [Patch net-next v2] net: move __skb_checksum_complete*() to skbuff.c

2018-11-08 Thread David Miller
From: Cong Wang Date: Thu, 8 Nov 2018 14:05:42 -0800 > __skb_checksum_complete_head() and __skb_checksum_complete() > are both declared in skbuff.h, they fit better in skbuff.c > than datagram.c. > > Cc: Stefano Brivio > Signed-off-by: Cong Wang Applied.

Re: [PATCH net-next] sfc: use the new __netdev_tx_sent_queue BQL optimisation

2018-11-08 Thread David Miller
From: Edward Cree Date: Thu, 8 Nov 2018 19:47:19 + > As added in 3e59020abf0f ("net: bql: add __netdev_tx_sent_queue()"), which > see for performance rationale. > > Signed-off-by: Edward Cree Applied.

Re: [PATCH net-next 0/4] Remove VLAN_TAG_PRESENT from drivers

2018-11-08 Thread David Miller
From: Michał Mirosław Date: Thu, 08 Nov 2018 18:44:46 +0100 > This series removes VLAN_TAG_PRESENT use from network drivers in > preparation to removing its special meaning. Series applied, thank you.

Re: [net-next, PATCH 1/2] net: socionext: different approach on DMA

2018-11-08 Thread David Miller
From: Ilias Apalodimas Date: Thu, 8 Nov 2018 17:19:54 +0200 > Current driver dynamically allocates an skb and maps it as DMA Rx > buffer. In order to prepare for upcoming XDP changes, let's introduce a > different allocation scheme. > Buffers are allocated dynamically and mapped into hardware.

Re: [net-next, PATCH 2/2] net: socionext: refactor netsec_alloc_dring()

2018-11-08 Thread David Miller
From: Ilias Apalodimas Date: Thu, 8 Nov 2018 17:19:55 +0200 > return -ENOMEM directly instead of assigning it in a variable > > Signed-off-by: Ilias Apalodimas Applied.

Re: [PATCH net-next] net: qca_spi: Add available buffer space verification

2018-11-08 Thread David Miller
From: Stefan Wahren Date: Thu, 8 Nov 2018 14:38:21 +0100 > Interferences on the SPI line could distort the response of > available buffer space. So at least we should check that the > response doesn't exceed the maximum available buffer space. > In error case increase a new error counter and

Re: [PATCH net 0/4] Slowpath Queue bug fixes

2018-11-08 Thread David Miller
From: Denis Bolotin Date: Thu, 8 Nov 2018 16:46:07 +0200 > This patch series fixes several bugs in the SPQ mechanism. > It deals with SPQ entries management, preventing resource leaks, memory > corruptions and handles error cases throughout the driver. > Please consider applying to net. Series

Re: [PATCH v3 net-next] sock: Reset dst when changing sk_mark via setsockopt

2018-11-08 Thread David Miller
From: David Barmann Date: Thu, 8 Nov 2018 08:13:35 -0600 > When setting the SO_MARK socket option, if the mark changes, the dst > needs to be reset so that a new route lookup is performed. > > This fixes the case where an application wants to change routing by > setting a new sk_mark. If this

Re: [PATCH net-next 0/2] dpaa2-eth: defer probe on object allocate

2018-11-08 Thread David Miller
From: David Miller Date: Thu, 08 Nov 2018 19:28:57 -0800 (PST) > From: Ioana Ciornei > Date: Thu, 8 Nov 2018 13:17:46 + > >> Allocatable objects on the fsl-mc bus may be probed by the fsl_mc_allocator >> after the first attempts of other drivers to use them.

Re: [PATCH net-next 0/2] dpaa2-eth: defer probe on object allocate

2018-11-08 Thread David Miller
From: Ioana Ciornei Date: Thu, 8 Nov 2018 13:17:46 + > Allocatable objects on the fsl-mc bus may be probed by the fsl_mc_allocator > after the first attempts of other drivers to use them. Defer the probe when > this situation happens. Series applied, thanks.

Re: [PATCH net-next] dpaa2-eth: Introduce TX congestion management

2018-11-08 Thread David Miller
From: Ioana Ciocoi Radulescu Date: Thu, 8 Nov 2018 20:21:15 + > Today I tried to further coalesce the confirmation frames such that I call > netdev_tx_completed_queue() only at the end of the NAPI poll, once for each > confirmation queue that was serviced during that NAPI. That sounds like

Re: [PATCH ipsec-next 00/11] xfrm: policy: add inexact policy search tree

2018-11-08 Thread David Miller
From: Florian Westphal Date: Wed, 7 Nov 2018 23:00:30 +0100 > This series attempts to improve xfrm policy lookup performance when > a lot of (several hundred or even thousands) inexact policies exist > on a system. > > On insert, a policy is either placed in hash table (all direct (/32 for >

Re: [PATCH v2 net] inet: frags: better deal with smp races

2018-11-08 Thread David Miller
From: Eric Dumazet Date: Thu, 8 Nov 2018 17:34:27 -0800 > Multiple cpus might attempt to insert a new fragment in rhashtable, > if for example RPS is buggy, as reported by 배석진 in > https://patchwork.ozlabs.org/patch/994601/ > > We use rhashtable_lookup_get_insert_key() instead of >

Re: [PATCH net-next 0/8] s390/qeth: updates 2018-11-08

2018-11-08 Thread David Miller
From: Julian Wiedmann Date: Thu, 8 Nov 2018 15:06:14 +0100 > please apply the following qeth patches to net-next. > > The first patch allows one more device type to query the FW for a MAC address, > the others are all basically just removal of duplicated or unused code. Series applied,

Re: [PATCH][net-next] openvswitch: remove BUG_ON from get_dpdev

2018-11-08 Thread David Miller
From: Li RongQing Date: Thu, 8 Nov 2018 20:40:20 +0800 > if local is NULL pointer, and the following access of local's > dev will trigger panic, which is same as BUG_ON > > Signed-off-by: Li RongQing Applied.

Re: [PATCH net-next v2 00/11] ICMP error handling for UDP tunnels

2018-11-08 Thread David Miller
From: Stefano Brivio Date: Thu, 8 Nov 2018 12:19:13 +0100 > This series introduces ICMP error handling for UDP tunnels and > encapsulations and related selftests. We need to handle ICMP errors to > support PMTU discovery and route redirection -- this support is entirely > missing right now: >

Re: [PATCH net-next] cxgb4: Add new T6 PCI device ids 0x608a

2018-11-08 Thread David Miller
From: Ganesh Goudar Date: Thu, 8 Nov 2018 14:21:07 +0530 > Signed-off-by: Ganesh Goudar Applied.

Re: [PATCH][net-next][v2] net/ipv6: compute anycast address hash only if dev is null

2018-11-08 Thread David Miller
From: Li RongQing Date: Thu, 8 Nov 2018 14:58:07 +0800 > avoid to compute the hash value if dev is not null, since > hash value is not used > > Signed-off-by: Li RongQing Applied.

Re: [PATCH net] inet: frags: better deal with smp races

2018-11-08 Thread David Miller
From: Eric Dumazet Date: Wed, 7 Nov 2018 22:10:53 -0800 > @@ -204,22 +205,22 @@ static struct inet_frag_queue *inet_frag_create(struct > netns_frags *nf, > /* TODO : call from rcu_read_lock() and no longer use > refcount_inc_not_zero() */ > struct inet_frag_queue *inet_frag_find(struct

Re: [PATCH net-next] net: bcmgenet: return correct value 'ret' from bcmgenet_power_down

2018-11-08 Thread David Miller
From: YueHaibing Date: Thu, 8 Nov 2018 02:08:43 + > Fixes gcc '-Wunused-but-set-variable' warning: > > drivers/net/ethernet/broadcom/genet/bcmgenet.c: In function > 'bcmgenet_power_down': > drivers/net/ethernet/broadcom/genet/bcmgenet.c:1136:6: warning: > variable 'ret' set but not used

Re: [PATCH net-next 0/7] net: sched: prepare for more Qdisc offloads

2018-11-08 Thread David Miller
From: Jakub Kicinski Date: Wed, 7 Nov 2018 17:33:33 -0800 > This series refactors the "switchdev" Qdisc offloads a little. We have > a few Qdiscs which can be fully offloaded today to the forwarding plane > of switching devices. > > First patch adds a helper for handing statistic dumps, the

Re: [net-next PATCH v2] net: sched: cls_flower: Classify packets using port ranges

2018-11-08 Thread David Miller
From: Amritha Nambiar Date: Wed, 07 Nov 2018 13:22:42 -0800 > diff --git a/include/uapi/linux/pkt_cls.h b/include/uapi/linux/pkt_cls.h > index 401d0c1..b63c3cf 100644 > --- a/include/uapi/linux/pkt_cls.h > +++ b/include/uapi/linux/pkt_cls.h > @@ -405,6 +405,11 @@ enum { >

Re: [PATCH net-next 0/2] net: phy: use phy_id_mask value zero for exact match

2018-11-08 Thread David Miller
From: Heiner Kallweit Date: Wed, 7 Nov 2018 21:52:31 +0100 > A phy_id_mask value zero means every PHYID matches, therefore > value zero isn't used. So we can safely redefine the semantics > of value zero to mean "exact match". This allows to avoid some > boilerplate code in PHY driver configs. >

Re: [PATCH net-next 0/5] net: phy: improve and simplify phylib state machine

2018-11-08 Thread David Miller
From: Florian Fainelli Date: Thu, 8 Nov 2018 15:00:01 -0800 > On 11/8/18 2:58 PM, David Miller wrote: >> From: Heiner Kallweit >> Date: Wed, 7 Nov 2018 20:41:52 +0100 >> >>> This patch series is based on two axioms: >>> >>> - During

Re: [PATCH net-next 0/5] net: phy: improve and simplify phylib state machine

2018-11-08 Thread David Miller
From: Heiner Kallweit Date: Wed, 7 Nov 2018 20:41:52 +0100 > This patch series is based on two axioms: > > - During autoneg a PHY always reports the link being down > > - Info in clause 22/45 registers doesn't allow to differentiate between > these two states: > 1. Link is physically down

Re: [PATCH 04/20] octeontx2-af: NPC MCAM entry alloc/free support

2018-11-08 Thread David Miller
From: sunil.kovv...@gmail.com Date: Fri, 9 Nov 2018 00:05:45 +0530 > +int rvu_mbox_handler_NPC_MCAM_ALLOC_ENTRY(struct rvu *rvu, > + struct npc_mcam_alloc_entry_req *req, > + struct npc_mcam_alloc_entry_rsp *rsp); > +int

Re: [PATCH net] ipv6/mcast: update mc_qrv when join new group

2018-11-08 Thread David Miller
From: Hangbin Liu Date: Thu, 8 Nov 2018 15:44:10 +0800 > On Fri, Oct 26, 2018 at 10:30:54AM +0800, Hangbin Liu wrote: >> Currently we only set mc_qrv to sysctl_mld_qrv when interface up. If we >> change sysctl_mld_qrv after interface up, it will has no effect. >> >> Fix it by assigning latest

Re: [net-next 00/12][pull request] Intel Wired LAN Driver Updates 2018-11-07

2018-11-07 Thread David Miller
From: Jeff Kirsher Date: Wed, 7 Nov 2018 14:48:18 -0800 > This series contains updates to almost all of the Intel wired LAN > drivers. ... > The following are changes since commit > 7c588c7468ea3f9b2fc8fa6840bed6262b5d1b00: > Merge branch

Re: [PATCH net-next 0/3] nfp: add and use tunnel netdev helpers

2018-11-07 Thread David Miller
From: John Hurley Date: Wed, 7 Nov 2018 18:32:47 + > A recent patch introduced the function netif_is_vxlan() to verify the > tunnel type of a given netdev as vxlan. > > Add a similar function to detect geneve netdevs and make use of this > function in the NFP driver. Also make use of the

Re: [PATCH net-next] sfc: add missing NVRAM partition types for EF10

2018-11-07 Thread David Miller
From: Edward Cree Date: Wed, 7 Nov 2018 18:12:42 + > Expose the MUM/SUC Firmware, UEFI Expansion ROM and MC Status partitions > of the NIC's NVRAM as MTDs if found on the NIC. The first two are needed > in order to properly update them when performing firmware updates; the MC > Status

<    1   2   3   4   5   6   7   8   9   10   >