Re: [PATCH net] ipv6: mcast: fix a use-after-free in inet6_mc_check

2018-10-15 Thread David Miller
From: Eric Dumazet Date: Fri, 12 Oct 2018 18:58:53 -0700 > syzbot found a use-after-free in inet6_mc_check [1] > > The problem here is that inet6_mc_check() uses rcu > and read_lock(>sflock) > > So the fact that ip6_mc_leave_src() is called under RTNL > and the socket lock does not help us, we

Re: [PATCH net-next 0/2] selftests: pmtu: Add test choice and captures

2018-10-15 Thread David Miller
From: Stefano Brivio Date: Fri, 12 Oct 2018 23:54:12 +0200 > This series adds a couple of features useful for debugging: 1/2 > allows selecting single tests and 2/2 adds optional traffic > captures. > > Semantics for current invocation of test script are preserved. M0AR SELF TESTS! I love it.

Re: [PATCH net-next] r8169: simplify rtl8169_set_magic_reg

2018-10-15 Thread David Miller
From: Heiner Kallweit Date: Fri, 12 Oct 2018 23:23:57 +0200 > Simplify this function, no functional change intended. > > Signed-off-by: Heiner Kallweit Applied.

Re: [PATCH net-next] r8169: remove unneeded call to netif_stop_queue in rtl8169_net_suspend

2018-10-15 Thread David Miller
From: Heiner Kallweit Date: Fri, 12 Oct 2018 23:30:52 +0200 > netif_device_detach() stops all tx queues already, so we don't need > this call. > > Signed-off-by: Heiner Kallweit Applied.

Re: [PATCH net-next] nfp: devlink port split support for 1x100G CXP NIC

2018-10-15 Thread David Miller
From: Jakub Kicinski Date: Fri, 12 Oct 2018 11:09:01 -0700 > From: Ryan C Goodfellow > > This commit makes it possible to use devlink to split the 100G CXP > Netronome into two 40G interfaces. Currently when you ask for 2 > interfaces, the math in src/nfp_devlink.c:nfp_devlink_port_split >

Re: [PATCH net-next 0/6] dpaa2-eth: code cleanup

2018-10-15 Thread David Miller
From: Ioana Ciornei Date: Fri, 12 Oct 2018 16:27:16 + > There are no functional changes in this patch set, only some cleanup > changes such as: unused parameters, uninitialized variables and > unnecessary Kconfig dependencies. Series applied.

Re: [PATCH net] ipv6: rate-limit probes for neighbourless routes

2018-10-15 Thread David Miller
From: Sabrina Dubroca Date: Fri, 12 Oct 2018 16:22:47 +0200 > When commit 270972554c91 ("[IPV6]: ROUTE: Add Router Reachability > Probing (RFC4191).") introduced router probing, the rt6_probe() function > required that a neighbour entry existed. This neighbour entry is used to > record the

Re: [PATCH net-next 0/2] net: phy: improve and simplify state machine

2018-10-15 Thread David Miller
From: Heiner Kallweit Date: Thu, 11 Oct 2018 22:35:35 +0200 > Improve / simplify handling of states PHY_RUNNING and PHY_RESUMING in > phylib state machine. Series applied.

Re: [PATCH net-next v2] vxlan: support NTF_USE refresh of fdb entries

2018-10-15 Thread David Miller
From: Roopa Prabhu Date: Thu, 11 Oct 2018 12:35:13 -0700 > From: Roopa Prabhu > > This makes use of NTF_USE in vxlan driver consistent > with bridge driver. > > Signed-off-by: Roopa Prabhu Applied.

Re: [Patch net] llc: set SOCK_RCU_FREE in llc_sap_add_socket()

2018-10-15 Thread David Miller
From: Cong Wang Date: Thu, 11 Oct 2018 11:15:13 -0700 > WHen an llc sock is added into the sk_laddr_hash of an llc_sap, > it is not marked with SOCK_RCU_FREE. > > This causes that the sock could be freed while it is still being > read by __llc_lookup_established() with RCU read lock. sock is >

Re: [PATCH net-next v7] net/ncsi: Extend NC-SI Netlink interface to allow user space to send NC-SI command

2018-10-15 Thread David Miller
From: Date: Thu, 11 Oct 2018 18:07:37 + > The new command (NCSI_CMD_SEND_CMD) is added to allow user space application > to send NC-SI command to the network card. > Also, add a new attribute (NCSI_ATTR_DATA) for transferring request and > response. > > The work flow is as below. > >

Re: [PATCH net-next] net: phy: trigger state machine immediately in phy_start_machine

2018-10-15 Thread David Miller
From: Heiner Kallweit Date: Thu, 11 Oct 2018 19:31:47 +0200 > When starting the state machine there may be work to be done > immediately, e.g. if the initial state is PHY_UP then the state > machine may trigger an autonegotiation. Having said that I see no need > to wait a second until the state

Re: [PATCH net-next 0/3] veth: XDP stats improvement

2018-10-15 Thread David Miller
From: Toshiaki Makita Date: Thu, 11 Oct 2018 18:36:47 +0900 > ndo_xdp_xmit in veth did not update packet counters as described in [1]. > Also, current implementation only updates counters on tx side so rx side > events like XDP_DROP were not collected. > This series implements the missing

Re: [pull request][net 0/3] Mellanox, mlx5 fixes 2018-10-10

2018-10-15 Thread David Miller
From: Saeed Mahameed Date: Wed, 10 Oct 2018 18:32:41 -0700 > This pull request includes some fixes to mlx5 driver, > Please pull and let me know if there's any problem. Pulled. > For -stable v4.11: > ('net/mlx5: Take only bit 24-26 of wqe.pftype_wq for page fault type') > For -stable v4.17: >

Re: [pull request][net-next 0/7] Mellanox, mlx5e and IPoIB netlink support fixes

2018-10-15 Thread David Miller
From: Saeed Mahameed Date: Wed, 10 Oct 2018 18:24:37 -0700 > This series was meant to go to -rc but due to this late submission and the > size/complexity of this patchset, I am submitting to net-next. > > This series came to fix a very serious regression in RDMA > IPoIB netlink child creation

Re: [PATCH net v3] net/sched: cls_api: add missing validation of netlink attributes

2018-10-15 Thread David Miller
From: Davide Caratti Date: Wed, 10 Oct 2018 22:00:58 +0200 > Similarly to what has been done in 8b4c3cdd9dd8 ("net: sched: Add policy > validation for tc attributes"), fix classifier code to add validation of > TCA_CHAIN and TCA_KIND netlink attributes. > > tested with: > # ./tdc.py -c filter

Re: [PATCH net-next v2 0/2] FDDI: DEC FDDIcontroller 700 TURBOchannel adapter support

2018-10-15 Thread David Miller
From: "Maciej W. Rozycki" Date: Tue, 9 Oct 2018 23:57:36 +0100 (BST) > Questions, comments? Otherwise, please apply. Series applied, thank you.

Re: [PATCH net-next] tun: Consistently configure generic netdev params via rtnetlink

2018-10-15 Thread David Miller
From: Serhey Popovych Date: Tue, 9 Oct 2018 21:21:01 +0300 > Configuring generic network device parameters on tun will fail in > presence of IFLA_INFO_KIND attribute in IFLA_LINKINFO nested attribute > since tun_validate() always return failure. > > This can be visualized with following

Re: [PATCH net-next 0/4] s390/qeth: updates 2018-10-12

2018-10-12 Thread David Miller
From: Julian Wiedmann Date: Fri, 12 Oct 2018 17:27:11 +0200 > please apply one more patchset for net-next. This extends the TSO support > in qeth. Series applied.

Re: [PATCH net] rxrpc: Fix incorrect conditional on IPV6

2018-10-12 Thread David Miller
From: Eric Dumazet Date: Fri, 12 Oct 2018 08:19:20 -0700 > > > On 10/12/2018 07:52 AM, David Howells wrote: >> The udpv6_encap_enable() function is part of the ipv6 code, and if that is >> configured as a loadable module and rxrpc is built in then a build failure >> will occur because the

Re: [PATCH] fore200e: fix sbus compile

2018-10-12 Thread David Miller
From: Christoph Hellwig Date: Fri, 12 Oct 2018 10:17:51 +0200 > Fix a stupid typo introduced in the refactoring. > > Fixes: 0efe5523 ("fore200e: simplify fore200e_bus usage") > Signed-off-by: Christoph Hellwig Applied.

Re: [PATCH net-next] net: Evict neighbor entries on carrier down

2018-10-12 Thread David Miller
From: David Ahern Date: Thu, 11 Oct 2018 20:33:49 -0700 > From: David Ahern > > When a link's carrier goes down it could be a sign of the port changing > networks. If the new network has overlapping addresses with the old one, > then the kernel will continue trying to use neighbor entries

Re: [PATCH v2 net-next] net/ipv6: Add knob to skip DELROUTE message on device down

2018-10-12 Thread David Miller
From: David Ahern Date: Thu, 11 Oct 2018 20:17:21 -0700 > From: David Ahern > > Another difference between IPv4 and IPv6 is the generation of RTM_DELROUTE > notifications when a device is taken down (admin down) or deleted. IPv4 > does not generate a message for routes evicted by the down or

Re: [PATCH net-next] net: cdc_ncm: remove set but not used variable 'ctx'

2018-10-12 Thread David Miller
From: YueHaibing Date: Fri, 12 Oct 2018 01:49:13 + > Fixes gcc '-Wunused-but-set-variable' warning: > > drivers/net/usb/cdc_ncm.c: In function 'cdc_ncm_status': > drivers/net/usb/cdc_ncm.c:1603:22: warning: > variable 'ctx' set but not used [-Wunused-but-set-variable] > struct

Re: [PATCH net-next] net: fddi: skfp: Remove unused macros 'PNMI_GET_ID' and 'PNMI_SET_ID'

2018-10-12 Thread David Miller
From: YueHaibing Date: Fri, 12 Oct 2018 10:37:41 +0800 > The two PNMI macros are never used > > Signed-off-by: YueHaibing Applied.

Re: [PATCH net 0/2] net: dsa: bcm_sf2: Couple of fixes

2018-10-11 Thread David Miller
From: Florian Fainelli Date: Thu, 11 Oct 2018 15:02:54 -0700 > On 10/10/2018 10:53 PM, David Miller wrote: >> From: Florian Fainelli >> Date: Tue, 9 Oct 2018 16:48:56 -0700 >> >>> Here are two fixes for the bcm_sf2 driver that were found during >>> tes

Re: [PATCH net-next 0/9] net: Kernel side filtering for route dumps

2018-10-11 Thread David Miller
From: Sowmini Varadhan Date: Thu, 11 Oct 2018 15:32:48 -0400 > Without getting into Ahern's patchset, which he obviously feels > quite passionately about.. > > On (10/11/18 12:28), David Miller wrote: >> >> Once you've composed the message, the whole point of filterin

Re: [PATCH net-next 0/9] net: Kernel side filtering for route dumps

2018-10-11 Thread David Miller
From: David Ahern Date: Thu, 11 Oct 2018 12:44:49 -0600 > I disagree with your overall premise of bpf the end-all hammer. It is a > tool but not the only tool. For starters, you are proposing building the > message, run the filter on it, and potentially back the message up to > drop the recently

Re: [PATCH net-next] nfp: replace long license headers with SPDX

2018-10-11 Thread David Miller
From: Jakub Kicinski Date: Thu, 11 Oct 2018 08:57:42 -0700 > Replace the repeated license text with SDPX identifiers. > While at it bump the Copyright dates for files we touched > this year. > > Signed-off-by: Edwin Peer > Signed-off-by: Jakub Kicinski > Signed-off-by: Nic Viljoen >

Re: [PATCH] net: phy: sfp: remove sfp_mutex's definition

2018-10-11 Thread David Miller
From: Sebastian Andrzej Siewior Date: Thu, 11 Oct 2018 17:06:21 +0200 > The sfp_mutex variable is defined but never used in this file. Not even > in the commit that introduced that variable. > > Remove sfp_mutex, it has no purpose. > > Cc: Andrew Lunn > Cc: Florian Fainelli > Cc: "David S.

Re: [PATCH 1/1] net: socionext: clear rx irq correctly

2018-10-11 Thread David Miller
From: Ilias Apalodimas Date: Thu, 11 Oct 2018 15:28:26 +0300 > commit 63ae7949e94a ("net: socionext: Use descriptor info instead of MMIO > reads on Rx") > removed constant mmio reads from the driver and started using a descriptor > field to check if packet should be processed. > This lead the

Re: [PATCH net] net/mlx4_core: Fix warnings during boot on driverinit param set failures

2018-10-11 Thread David Miller
From: Tariq Toukan Date: Thu, 11 Oct 2018 15:01:19 +0300 > From: Moshe Shemesh > > During boot, mlx4_core sets the driverinit configuration parameters and > updates the devlink module on the initial values calling > devlink_param_driverinit_value_set(). > If

Re: [PATCH net-next] selftests: use posix-style redirection in ip_defrag.sh

2018-10-11 Thread David Miller
From: Paolo Abeni Date: Thu, 11 Oct 2018 11:17:37 +0200 > The ip_defrag.sh script requires bash-style output redirection but > use the default shell. This may cause random failures if the default > shell is not bash. > Address the above using posix compliant output redirection. > > Fixes:

Re: [PATCH net 0/2] net: explicitly requires bash when needed.

2018-10-11 Thread David Miller
From: Paolo Abeni Date: Thu, 11 Oct 2018 10:54:51 +0200 > Some test scripts require bash-only features but use the default shell. > This may cause random failures if the default shell is not bash. > Instead of doing a potentially complex rewrite of such scripts, these patches > require the bash

Re: [PATCH V2 net-next 00/12] Improving performance and reducing latencies, by using latest capabilities exposed in ENA device

2018-10-11 Thread David Miller
From: Date: Thu, 11 Oct 2018 11:26:15 +0300 > From: Arthur Kiyanovski > > This patchset introduces the following: > 1. A new placement policy of Tx headers and descriptors, which takes > advantage of an option to place headers + descriptors in device memory > space. This is sometimes referred

Re: [PATCH net-next 00/19] mlxsw: Preparations for VxLAN support

2018-10-11 Thread David Miller
From: Ido Schimmel Date: Thu, 11 Oct 2018 07:47:48 + > This patchset prepares mlxsw for VxLAN support. It contains small and > mostly non-functional changes. Series applied, thanks.

Re: [PATCH net-next] octeontx2-af: Remove set but not used variable 'dev'

2018-10-11 Thread David Miller
From: YueHaibing Date: Thu, 11 Oct 2018 07:37:07 + > Fixes gcc '-Wunused-but-set-variable' warning: > > drivers/net/ethernet/marvell/octeontx2/af/cgx.c: In function > 'cgx_fwi_event_handler': > drivers/net/ethernet/marvell/octeontx2/af/cgx.c:257:17: warning: > variable 'dev' set but not

Re: [PATCH net-next v6] net/ncsi: Extend NC-SI Netlink interface to allow user space to send NC-SI command

2018-10-11 Thread David Miller
From: Date: Thu, 11 Oct 2018 06:21:10 + > @@ -366,6 +368,203 @@ static int ncsi_clear_interface_nl(struct sk_buff *msg, > struct genl_info *info) > return 0; > } > > +static int ncsi_send_cmd_nl(struct sk_buff *msg, struct genl_info *info) > +{ > + struct ncsi_dev_priv *ndp; >

Re: [PATCH net-next 0/4] Adds support of RSS to HNS3 Driver for Rev 2(=0x21) H/W

2018-10-10 Thread David Miller
From: Salil Mehta Date: Wed, 10 Oct 2018 20:05:33 +0100 > This patch-set mainly adds new additions related to RSS for the new > hardware Revision 0x21. It also adds support to use RSS hash value > provided by the hardware along with descriptor. Series applied.

Re: [PATCH] qmi_wwan: Added support for Gemalto's Cinterion ALASxx WWAN interface

2018-10-10 Thread David Miller
From: Giacinto Cifelli Date: Wed, 10 Oct 2018 20:05:53 +0200 > Added support for Gemalto's Cinterion ALASxx WWAN interfaces > by adding QMI_FIXED_INTF with Cinterion's VID and PID. > > Signed-off-by: Giacinto Cifelli Applied and queued up for -stable.

Re: [net 1/1] tipc: queue socket protocol error messages into socket receive buffer

2018-10-10 Thread David Miller
From: Jon Maloy Date: Wed, 10 Oct 2018 17:50:23 +0200 > From: Parthasarathy Bhuvaragan > > In tipc_sk_filter_rcv(), when we detect protocol messages with error we > call tipc_sk_conn_proto_rcv() and let it reset the connection and notify > the socket by calling sk->sk_state_change(). > >

Re: [net 1/1] tipc: set link tolerance correctly in broadcast link

2018-10-10 Thread David Miller
From: Jon Maloy Date: Wed, 10 Oct 2018 17:34:01 +0200 > In the patch referred to below we added link tolerance as an additional > criteria for declaring broadcast transmission "stale" and resetting the > affected links. > > However, the 'tolerance' field of the broadcast link is never set, and

Re: [PATCH -next] phy: phy-ocelot-serdes: fix return value check in serdes_probe()

2018-10-10 Thread David Miller
From: Wei Yongjun Date: Wed, 10 Oct 2018 02:00:24 + > In case of error, the function syscon_node_to_regmap() returns ERR_PTR() > and never returns NULL. The NULL test in the return value check should > be replaced with IS_ERR(). > > Fixes: 51f6b410fc22 ("phy: add driver for Microsemi Ocelot

Re: [PATCH net 0/2] net: dsa: bcm_sf2: Couple of fixes

2018-10-10 Thread David Miller
From: Florian Fainelli Date: Tue, 9 Oct 2018 16:48:56 -0700 > Here are two fixes for the bcm_sf2 driver that were found during > testing unbind and analysing another issue during system > suspend/resume. Series applied and queued up for -stable, thanks.

Re: [PATCH net-next] net: sched: avoid writing on noop_qdisc

2018-10-10 Thread David Miller
From: Eric Dumazet Date: Tue, 9 Oct 2018 15:20:50 -0700 > While noop_qdisc.gso_skb and noop_qdisc.skb_bad_txq are not used > in other places, it seems not correct to overwrite their fields > in dev_init_scheduler_queue(). > > noop_qdisc is essentially a shared and read-only object, even if >

Re: [PATCH net-next] net/ipv6: Add knob to skip DELROUTE message on device down

2018-10-10 Thread David Miller
From: David Ahern Date: Tue, 9 Oct 2018 14:27:51 -0700 > From: David Ahern > > Another difference between IPv4 and IPv6 is the generation of RTM_DELROUTE > notifications when a device is taken down (admin down) or deleted. IPv4 > does not generate a message for routes evicted by the down or

Re: [PATCH net-next] net/mpls: Implement handler for strict data checking on dumps

2018-10-10 Thread David Miller
From: David Ahern Date: Tue, 9 Oct 2018 11:10:43 -0700 > From: David Ahern > > Without CONFIG_INET enabled compiles fail with: > > net/mpls/af_mpls.o: In function `mpls_dump_routes': > af_mpls.c:(.text+0xed0): undefined reference to `ip_valid_fib_dump_req' > > The preference is for MPLS to

Re: [PATCH net v2 0/2] net: ipv4: fixes for PMTU when link MTU changes

2018-10-10 Thread David Miller
From: Sabrina Dubroca Date: Tue, 9 Oct 2018 17:48:13 +0200 > The first patch adapts the changes that commit e9fa1495d738 ("ipv6: > Reflect MTU changes on PMTU of exceptions for MTU-less routes") did in > IPv6 to IPv4: lower PMTU when the first hop's MTU drops below it, and > raise PMTU when the

Re: [PATCH V1 net-next 00/12] Improving performance and reducing latencies, by using latest capabilities exposed in ENA device

2018-10-10 Thread David Miller
From: Date: Tue, 9 Oct 2018 21:44:57 +0300 > This patchset introduces the following: > 1. A new placement policy of Tx headers and descriptors, which takes > advantage of an option to place headers + descriptors in device memory > space. This is sometimes referred to as LLQ - low latency queue.

Re: fore200e DMA cleanups and fixes

2018-10-10 Thread David Miller
From: Christoph Hellwig Date: Tue, 9 Oct 2018 16:57:13 +0200 > The fore200e driver came up during some dma-related audits, so > here is the fallout. Compile tested (x86 & sparc) only. Series applied to net-next.

Re: [PATCH net-next v2] net: tun: remove useless codes of tun_automq_select_queue

2018-10-10 Thread David Miller
From: Wang Li Date: Tue, 9 Oct 2018 10:32:04 +0800 > Because the function __skb_get_hash_symmetric always returns non-zero. > > Signed-off-by: Zhang Yu > Signed-off-by: Wang Li Applied.

Re: [PATCH net-next V3] virtio_net: ethtool tx napi configuration

2018-10-10 Thread David Miller
From: Jason Wang Date: Tue, 9 Oct 2018 10:06:26 +0800 > Implement ethtool .set_coalesce (-C) and .get_coalesce (-c) handlers. > Interrupt moderation is currently not supported, so these accept and > display the default settings of 0 usec and 1 frame. > > Toggle tx napi through setting

Re: [PATCH net-next 0/3] nfp: flower: speed up stats update loop

2018-10-10 Thread David Miller
From: Jakub Kicinski Date: Mon, 8 Oct 2018 18:57:33 -0700 > This set from Pieter improves performance of processing FW stats > update notifications. The FW seems to send those at relatively > high rate (roughly ten per second per flow), therefore if we want > to approach the million flows mark

Re: [PATCH] isdn/hisax: amd7930_fn: Remove unnecessary parentheses

2018-10-10 Thread David Miller
From: Nathan Chancellor Date: Mon, 8 Oct 2018 15:59:05 -0700 > Clang warns when multiple sets of parentheses are used for a single > conditional statement. > > drivers/isdn/hisax/amd7930_fn.c:628:32: warning: equality comparison > with extraneous parentheses [-Wparentheses-equality] >

Re: [PATCH net 00/10] rxrpc: Fix packet reception code

2018-10-10 Thread David Miller
From: David Howells Date: Mon, 08 Oct 2018 23:47:18 +0100 > Here are a set of patches that prepares for and fix problems in rxrpc's > package reception code. There serious problems are: ... > The second patch fixes (A) - (C); the third patch renders (B) and (C) > non-issues by using the

Re: [PATCH net-next] net/ipv6: Make ipv6_route_table_template static

2018-10-10 Thread David Miller
From: David Ahern Date: Mon, 8 Oct 2018 14:06:34 -0700 > From: David Ahern > > ipv6_route_table_template is exported but there are no users outside > of route.c. Make it static. > > Signed-off-by: David Ahern Applied.

Re: [PATCH net-next] rtnetlink: Update comment in rtnl_stats_dump regarding strict data checking

2018-10-10 Thread David Miller
From: David Ahern Date: Mon, 8 Oct 2018 13:58:07 -0700 > From: David Ahern > > The NLM_F_DUMP_PROPER_HDR netlink flag was replaced by a setsockopt. > Update the comment in rtnl_stats_dump. > > Fixes: 841891ec0c65 ("rtnetlink: Update rtnl_stats_dump for strict data > checking") >

Re: [PATCH net-next] tcp: refactor DCTCP ECN ACK handling

2018-10-10 Thread David Miller
From: Yuchung Cheng Date: Mon, 8 Oct 2018 15:32:20 -0700 > DCTCP has two parts - a new ECN signalling mechanism and the response > function to it. The first part can be used by other congestion > control for DCTCP-ECN deployed networks. This patch moves that part > into a separate tcp_dctcp.h

Re: [PATCH net-next] rtnetlink: Move ifm in valid_fdb_dump_legacy to closer to use

2018-10-10 Thread David Miller
From: David Ahern Date: Mon, 8 Oct 2018 13:57:24 -0700 > From: David Ahern > > Move setting of local variable ifm to after the message parsing in > valid_fdb_dump_legacy. Avoid potential future use of unchecked variable. > > Fixes: 8dfbda19a21b ("rtnetlink: Move input checking for

Re: [PATCH net-next 0/3] mlxsw: selftests: Few small updates

2018-10-10 Thread David Miller
From: Ido Schimmel Date: Mon, 8 Oct 2018 18:50:38 + > First patch fixes a typo in mlxsw. > > Second patch fixes a race in a recent test. > > Third patch makes a recent test executable. Series applied, thanks Ido.

Re: [PATCH net] rds: RDS (tcp) hangs on sendto() to unresponding address

2018-10-10 Thread David Miller
From: Ka-Cheong Poon Date: Mon, 8 Oct 2018 09:17:11 -0700 > In rds_send_mprds_hash(), if the calculated hash value is non-zero and > the MPRDS connections are not yet up, it will wait. But it should not > wait if the send is non-blocking. In this case, it should just use the > base c_path for

Re: [PATCH] net: aquantia: remove some redundant variable initializations

2018-10-10 Thread David Miller
From: Colin King Date: Mon, 8 Oct 2018 14:35:58 +0100 > From: Colin Ian King > > There are several variables being initialized that are being set later > and hence the initialization is redundant and can be removed. Remove > then. > > Signed-off-by: Colin Ian King Applied to net-next.

Re: [PATCH] r8152: limit MAC pass-through to one device

2018-10-10 Thread David Miller
From: Oliver Neukum Date: Wed, 10 Oct 2018 19:17:05 +0200 > On Mi, 2018-10-10 at 17:18 +, mario.limoncie...@dell.com wrote: >> > >> > MAC address having to be unique, a MAC coming from the host >> > must be used at most once at a time. Hence the users must >> > be recorded and additional

Re: [PATCH net] net: make skb_partial_csum_set() more robust against overflows

2018-10-10 Thread David Miller
From: Eric Dumazet Date: Wed, 10 Oct 2018 06:59:35 -0700 > syzbot managed to crash in skb_checksum_help() [1] : > > BUG_ON(offset + sizeof(__sum16) > skb_headlen(skb)); > > Root cause is the following check in skb_partial_csum_set() > > if (unlikely(start > skb_headlen(skb)) ||

Re: sparc64 mystery with Cheetah+ D-cache parity error (n_tty_set_termios, bpf_check, cheetah_copy_page_insn)

2018-10-10 Thread David Miller
From: Meelis Roos Date: Wed, 10 Oct 2018 16:24:59 +0300 > I have seen multiple strange messages like this, on multiple sparc64 > machines: > > [ 55.523882] CPU[1]: Cheetah+ D-cache parity error at > TPC[00707e8c] > [ 55.626033] TPC > > This specfic one ise from n_tty_set_termios and

Re: [PATCH v9 00/15] octeontx2-af: Add RVU Admin Function driver

2018-10-10 Thread David Miller
From: sunil.kovv...@gmail.com Date: Wed, 10 Oct 2018 18:14:20 +0530 > Resource virtualization unit (RVU) on Marvell's OcteonTX2 SOC maps HW > resources from the network, crypto and other functional blocks into > PCI-compatible physical and virtual functions. Each functional block > again has

Re: [PATCH net-next 1/1] qed: Add support for virtual link.

2018-10-10 Thread David Miller
From: Sudarsana Reddy Kalluru Date: Wed, 10 Oct 2018 05:00:12 -0700 > Currently driver registers to physical link notifications (of the device) > from Management firmware (MFW). Driver doesn't get notified if there's a > change in the virtual link e.g., link-flap on the peer PF interface. >

Re: [PATCH net-next] cxgb4: Add thermal zone support

2018-10-09 Thread David Miller
From: Ganesh Goudar Date: Tue, 9 Oct 2018 19:14:13 +0530 > Add thermal zone support to monitor ASIC's temperature. > > Signed-off-by: Ganesh Goudar Applied.

Re: [PATCH V2 net 0/4] minor bug fixes for ENA Ethernet driver

2018-10-09 Thread David Miller
From: Date: Tue, 9 Oct 2018 11:21:26 +0300 > From: Arthur Kiyanovski > > Arthur Kiyanovski (4): > net: ena: fix warning in rmmod caused by double iounmap > net: ena: fix rare bug when failed restart/resume is followed by > driver removal > net: ena: fix NULL dereference due to

Re: pull-request: bpf-next 2018-10-08

2018-10-09 Thread David Miller
From: Alexei Starovoitov Date: Mon, 8 Oct 2018 22:53:47 -0700 > The following pull-request contains BPF updates for your *net-next* > tree. Pulled, thanks Alexei.

Re: [PATCH bpf-next 0/6] Error handling when map lookup isn't supported

2018-10-08 Thread David Miller
From: Prashant Bhole Date: Tue, 9 Oct 2018 09:02:15 +0900 > Thanks. Is there any reason this series did not get posted on > netdev-list and can not be seen in the patchwork? Bad timing. I did something stupid on vger.kernel.org, it ran out of disk space while the postings were being processed,

Re: [PATCH net-next] dpaa2-eth: Don't account Tx confirmation frames on NAPI poll

2018-10-08 Thread David Miller
From: Ioana Ciocoi Radulescu Date: Mon, 8 Oct 2018 14:16:31 + > Until now, both Rx and Tx confirmation frames handled during > NAPI poll were counted toward the NAPI budget. However, Tx > confirmations are lighter to process than Rx frames, which can > skew the amount of work actually done

Re: [PATCH net-next] net: mscc: ocelot: remove set but not used variable 'phy_mode'

2018-10-08 Thread David Miller
From: YueHaibing Date: Mon, 8 Oct 2018 14:07:50 + > Fixes gcc '-Wunused-but-set-variable' warning: > > drivers/net/ethernet/mscc/ocelot_board.c: In function 'mscc_ocelot_probe': > drivers/net/ethernet/mscc/ocelot_board.c:262:17: warning: > variable 'phy_mode' set but not used

Re: [PATCH v2 net-next 11/23] rtnetlink: Update rtnl_stats_dump for strict data checking

2018-10-08 Thread David Miller
From: David Ahern Date: Mon, 8 Oct 2018 07:25:34 -0600 > On 10/8/18 4:17 AM, Christian Brauner wrote: >>> @@ -4696,13 +4697,32 @@ static int rtnl_stats_dump(struct sk_buff *skb, >>> struct netlink_callback *cb) >>> >>> cb->seq = net->dev_base_seq; >>> >>> - if (nlmsg_len(cb->nlh) <

Re: [PATCH V1 net 0/5] minor bug fixes for ENA Ethernet driver

2018-10-08 Thread David Miller
From: "Bshara, Nafea" Date: Mon, 8 Oct 2018 12:47:50 + > Ship it Anything but... see my feedback.

Re: [PATCH net-next 0/3] selftests: add more PMTU tests

2018-10-08 Thread David Miller
From: Sabrina Dubroca Date: Mon, 8 Oct 2018 14:37:02 +0200 > The current selftests for PMTU cover VTI tunnels, but there's nothing > about the generation and handling of PMTU exceptions by intermediate > routers. This series adds and improves existing helpers, then adds > IPv4 and IPv6

Re: [PATCH net 1/2] net: ipv4: update fnhe_pmtu when first hop's MTU changes

2018-10-08 Thread David Miller
From: Sabrina Dubroca Date: Mon, 8 Oct 2018 14:36:38 +0200 > Since commit 5aad1de5ea2c ("ipv4: use separate genid for next hop > exceptions"), exceptions get deprecated separately from cached > routes. In particular, administrative changes don't clear PMTU anymore. > > As Stefano described in

Re: [PATCH V1 net 2/5] net: ena: fix warning in rmmod caused by double iounmap

2018-10-08 Thread David Miller
From: Date: Mon, 8 Oct 2018 15:28:41 +0300 > From: Arthur Kiyanovski > > Memory mapped with devm_ioremap is automatically freed when the driver > is disconnected from the device. Therefore there is no need to > explicitly call devm_iounmap. > > Signed-off-by: Arthur Kiyanovski > --- >

Re: [PATCH V1 net 0/5] minor bug fixes for ENA Ethernet driver

2018-10-08 Thread David Miller
From: Date: Mon, 8 Oct 2018 15:28:39 +0300 > From: Arthur Kiyanovski > > Arthur Kiyanovski (5): > net: ena: fix indentations in ena_defs for better readability > net: ena: fix warning in rmmod caused by double iounmap > net: ena: fix rare bug when failed restart/resume is followed by >

Re: [PATCH net-next] net/ipv6: stop leaking percpu memory in fib6 info

2018-10-08 Thread David Miller
From: Mike Rapoport Date: Mon, 8 Oct 2018 15:06:03 +0300 > The fib6_info_alloc() function allocates percpu memory to hold per CPU > pointers to rt6_info, but this memory is never freed. Fix it. > > Fixes: a64efe142f5e ("net/ipv6: introduce fib6_info struct and helpers") > Please do not put

Re: [PATCH v2 net-next 00/23] rtnetlink: Add support for rigid checking of data in dump request

2018-10-08 Thread David Miller
From: Christian Brauner Date: Mon, 8 Oct 2018 13:04:13 +0200 > On Sun, Oct 07, 2018 at 08:16:21PM -0700, David Ahern wrote: >> From: David Ahern >> >> There are many use cases where a user wants to influence what is >> returned in a dump for some rtnetlink command: one is wanting data >> for a

Re: [PATCH net-next v2 00/12] net: sched: cls_u32 Various improvements

2018-10-08 Thread David Miller
From: Jamal Hadi Salim Date: Mon, 8 Oct 2018 06:22:32 -0400 > Various improvements from Al. > > Changes from version 1: Add missing commit Series applied.

Re: [PATCH net-next] netdev: remove useless codes of tun_automq_select_queue

2018-10-08 Thread David Miller
From: Wang Li Date: Mon, 8 Oct 2018 16:51:12 +0800 > @@ -1045,15 +1039,12 @@ static void tun_automq_xmit(struct tun_struct *tun, > struct sk_buff *skb) >* RPS hash and save it into the flow_table here. >*/ > __u32 rxhash; > + struct

Re: [PATCH net-next 00/11] net: sched: cls_u32 Various improvements

2018-10-07 Thread David Miller
From: Al Viro Date: Mon, 8 Oct 2018 06:45:15 +0100 > Er... Both are due to missing in the very beginning of the series (well, on > top of "net: sched: cls_u32: fix hnode refcounting") commit All dependencies like this must be explicitly stated. And in such situations you actually should wait

Re: [PATCH] net: vhost: remove bad code line

2018-10-07 Thread David Miller
From: xiangxia.m@gmail.com Date: Sun, 7 Oct 2018 18:41:50 -0700 > From: Tonghao Zhang > > Signed-off-by: Tonghao Zhang Applied.

Re: [PATCH net-next 00/11] net: sched: cls_u32 Various improvements

2018-10-07 Thread David Miller
From: Jamal Hadi Salim Date: Sun, 7 Oct 2018 12:38:00 -0400 > Various improvements from Al. Please submit changes that actually are compile tested: CC [M] net/sched/cls_u32.o net/sched/cls_u32.c: In function ‘u32_delete’: net/sched/cls_u32.c:674:6: error: ‘root_ht’ undeclared (first use in

Re: [PATCH v8 05/15] octeontx2-af: Add mailbox IRQ and msg handlers

2018-10-07 Thread David Miller
From: sunil.kovv...@gmail.com Date: Sun, 7 Oct 2018 20:29:14 +0530 > + req_hdr = (struct mbox_hdr *)(mdev->mbase + mbox->rx_start); I commented in the previous patch series version, for patch #4, that such casts are unnecessary and should be removed. You are in for a very long review

Re: [PATCH net 1/1] net: sched: cls_u32: fix hnode refcounting

2018-10-07 Thread David Miller
From: Jamal Hadi Salim Date: Sun, 7 Oct 2018 07:40:17 -0400 > From: Al Viro > > cls_u32.c misuses refcounts for struct tc_u_hnode - it counts references > via ->hlist and via ->tp_root together. u32_destroy() drops the former > and, in case when there had been links, leaves the sucker on the

Re: [PATCH v7 04/15] octeontx2-af: Add mailbox support infra

2018-10-06 Thread David Miller
From: sunil.kovv...@gmail.com Date: Sat, 6 Oct 2018 11:36:22 +0530 > + tx_hdr = (struct mbox_hdr *)(mdev->mbase + mbox->tx_start); > + rx_hdr = (struct mbox_hdr *)(mdev->mbase + mbox->rx_start); Since mdev->mbase is a void pointer, you do not need these casts, nor the parenthesis, at

Re: [PATCH net-next] rtnetlink: fix rtnl_fdb_dump() for shorter family headers

2018-10-05 Thread David Miller
From: Mauricio Faria de Oliveira Date: Fri, 5 Oct 2018 18:46:47 -0300 > On Fri, Oct 5, 2018 at 6:24 PM David Ahern wrote: >> >> On 10/5/18 3:22 PM, David Miller wrote: >> > From: Mauricio Faria de Oliveira >> > Date: Mon, 1 Oct 2018 22:50:32 -0300 >>

Re: [PATCH net-next] rtnetlink: fix rtnl_fdb_dump() for shorter family headers

2018-10-05 Thread David Miller
From: David Ahern Date: Fri, 5 Oct 2018 15:24:29 -0600 > On 10/5/18 3:22 PM, David Miller wrote: >> From: Mauricio Faria de Oliveira >> Date: Mon, 1 Oct 2018 22:50:32 -0300 >> >>> On Mon, Oct 1, 2018 at 12:38 PM Mauricio Faria de Oliveira >>> wrot

Re: [PATCH net-next 00/20] rtnetlink: Add support for rigid checking of data in dump request

2018-10-05 Thread David Miller
From: David Ahern Date: Fri, 5 Oct 2018 15:18:11 -0600 > One thing I missed in the rfc and v1 versions is strict attribute > parsing -- ie., there should be nothing remaining after nla_parse is > done. I have a new patch that adds an nlmsg_parse_strict and > nla_parse_strict that returns -EINVAL

Re: [PATCH net-next] selftests: net: Clean up an unused variable

2018-10-05 Thread David Miller
From: Jakub Sitnicki Date: Fri, 5 Oct 2018 10:19:57 +0200 > Address compiler warning: > > ip_defrag.c: In function 'send_udp_frags': > ip_defrag.c:206:16: warning: unused variable 'udphdr' [-Wunused-variable] > struct udphdr udphdr; > ^~ > > Signed-off-by: Jakub Sitnicki

Re: [PATCH v6 04/15] octeontx2-af: Add mailbox support infra

2018-10-05 Thread David Miller
From: sunil.kovv...@gmail.com Date: Thu, 4 Oct 2018 23:51:47 +0530 > +int otx2_mbox_init(struct otx2_mbox *mbox, void *hwbase, struct pci_dev > *pdev, > +void *reg_base, int direction, int ndevs) > +{ > + int devid; > + struct otx2_mbox_dev *mdev; Please order local

Re: [PATCH net] ipv6: take rcu lock in rawv6_send_hdrinc()

2018-10-05 Thread David Miller
From: Wei Wang Date: Thu, 4 Oct 2018 10:12:37 -0700 > From: Wei Wang > > In rawv6_send_hdrinc(), in order to avoid an extra dst_hold(), we > directly assign the dst to skb and set passed in dst to NULL to avoid > double free. > However, in error case, we free skb and then do stats update with

Re: [PATCH net-next v3 0/9] vrf: allow simultaneous service instances in default and other VRFs

2018-10-05 Thread David Miller
David, please review this series. Thanks.

Re: [PATCH net-next] socket: Tighten no-error check in bind()

2018-10-05 Thread David Miller
From: Jakub Sitnicki Date: Thu, 4 Oct 2018 11:09:40 +0200 > move_addr_to_kernel() returns only negative values on error, or zero on > success. Rewrite the error check to an idiomatic form to avoid confusing > the reader. > > Signed-off-by: Jakub Sitnicki Applied.

Re: [PATCH net] net: sched: Add policy validation for tc attributes

2018-10-05 Thread David Miller
From: David Ahern Date: Wed, 3 Oct 2018 15:05:36 -0700 > From: David Ahern > > A number of TC attributes are processed without proper validation > (e.g., length checks). Add a tca policy for all input attributes and use > when invoking nlmsg_parse. > > The 2 Fixes tags below cover the latest

Re: [PATCH net-next] rtnetlink: fix rtnl_fdb_dump() for shorter family headers

2018-10-05 Thread David Miller
From: Mauricio Faria de Oliveira Date: Mon, 1 Oct 2018 22:50:32 -0300 > On Mon, Oct 1, 2018 at 12:38 PM Mauricio Faria de Oliveira > wrote: >> Ok, thanks for your suggestions. >> I'll do some research/learning on them, and give it a try for a v2. > > FYI, that is "[PATCH v2 net-next]

Re: [PATCH net-next] fib_tests: Add tests for invalid metric on route

2018-10-05 Thread David Miller
From: David Ahern Date: Fri, 5 Oct 2018 10:01:19 -0700 > From: David Ahern > > Add ipv4 and ipv6 test cases with an invalid metrics option causing > ip_metrics_convert to fail. Tests clean up path during route add. > > Also, add nodad to to ipv6 address add. When running ipv6_route_metrics >

<    2   3   4   5   6   7   8   9   10   11   >