Re: [PATCH net] ipv6: do not leave garbage in rt->fib6_metrics

2018-10-05 Thread David Miller
From: Eric Dumazet Date: Fri, 5 Oct 2018 09:17:50 -0700 > In case ip_fib_metrics_init() returns an error, we better > rewrite rt->fib6_metrics with _default_metrics so that > we do not crash later in ip_fib_metrics_put() > > Fixes: 767a2217533f ("net: common metrics init helper for FIB

Re: [PATCH net-next] udp: gro behind static key

2018-10-05 Thread David Miller
From: Willem de Bruijn Date: Fri, 5 Oct 2018 11:31:40 -0400 > From: Willem de Bruijn > > Avoid the socket lookup cost in udp_gro_receive if no socket has a > udp tunnel callback configured. > > udp_sk(sk)->gro_receive requires a registration with > setup_udp_tunnel_sock, which enables the

Re: pull-request: bpf 2018-10-05

2018-10-05 Thread David Miller
From: Daniel Borkmann Date: Fri, 5 Oct 2018 19:47:13 +0200 > The following pull-request contains BPF updates for your *net* tree. > > The main changes are: > > 1) Fix to truncate input on ALU operations in 32 bit mode, from Jann. > > 2) Fixes for cgroup local storage to reject reserved flags

Re: [PATCH net-next 0/5] net: Consolidate metrics handling for ipv4 and ipv6

2018-10-05 Thread David Miller
From: Eric Dumazet Date: Fri, 5 Oct 2018 06:08:57 -0700 > For some reason I have not received the patch series in my inbox, I > only got your "series applied" message. I see what happened. I did something stupid on vger.kernel.org yesterday which ran a partition out of disk space, and some

Re: [PATCH net-next 02/19] net: usb: aqc111: Add bind and empty unbind callbacks

2018-10-05 Thread David Miller
From: Igor Russkikh Date: Fri, 5 Oct 2018 10:24:42 + > +static int aqc111_bind(struct usbnet *dev, struct usb_interface *intf) > +{ > + int ret; > + struct usb_device *udev = interface_to_usbdev(intf); Please always order local variable declarations from longest to shortest line

Re: [PATCH net-next] cxgb4: use FW_PORT_ACTION_L1_CFG32 for 32 bit capability

2018-10-05 Thread David Miller
From: Ganesh Goudar Date: Fri, 5 Oct 2018 15:04:45 +0530 > when 32 bit port capability is in use, use FW_PORT_ACTION_L1_CFG32 > rather than FW_PORT_ACTION_L1_CFG. > > Signed-off-by: Casey Leedom > Signed-off-by: Ganesh Goudar Applied.

Re: [PATCH v2] net: phy: phylink: fix SFP interface autodetection

2018-10-05 Thread David Miller
From: Baruch Siach Date: Wed, 3 Oct 2018 19:04:49 +0300 > When connecting SFP PHY to phylink use the detected interface. > Otherwise, the link fails to come up when the configured 'phy-mode' > differs from the SFP detected mode. > > Move most of phylink_connect_phy() into

Re: [PATCH net] be2net: don't flip hw_features when VXLANs are added/deleted

2018-10-05 Thread David Miller
From: Davide Caratti Date: Wed, 3 Oct 2018 15:20:58 +0200 > the be2net implementation of .ndo_tunnel_{add,del}() changes the value of > NETIF_F_GSO_UDP_TUNNEL bit in 'features' and 'hw_features', but it forgets > to call netdev_features_change(). Moreover, ethtool setting for that bit > can

Re: [Patch net-next] net_sched: convert idrinfo->lock from spinlock to a mutex

2018-10-05 Thread David Miller
From: Cong Wang Date: Tue, 2 Oct 2018 12:50:19 -0700 > In commit ec3ed293e766 ("net_sched: change tcf_del_walker() to take > idrinfo->lock") > we move fl_hw_destroy_tmplt() to a workqueue to avoid blocking > with the spinlock held. Unfortunately, this causes a lot of > troubles here: > > 1.

Re: [PATCH net-next 20/20] net/bridge: Update br_mdb_dump for strict data checking

2018-10-05 Thread David Miller
From: David Ahern Date: Thu, 4 Oct 2018 14:33:55 -0700 > @@ -162,6 +162,28 @@ static int br_mdb_fill_info(struct sk_buff *skb, struct > netlink_callback *cb, > return err; > } > > +static int br_mdb_valid_dump_req(const struct nlmsghdr *nlh, > + struct

Re: [PATCH net-next] net/neigh: Extend dump filter to proxy neighbor dumps

2018-10-05 Thread David Miller
From: David Ahern Date: Wed, 3 Oct 2018 15:33:12 -0700 > From: David Ahern > > Move the attribute parsing from neigh_dump_table to neigh_dump_info, and > pass the filter arguments down to neigh_dump_table in a new struct. Add > the filter option to proxy neigh dumps as well to make them

Re: [PATCH] net/packet: fix packet drop as of virtio gso

2018-10-04 Thread David Miller
From: Jianfeng Tan Date: Sat, 29 Sep 2018 15:41:27 + > When we use raw socket as the vhost backend, a packet from virito with > gso offloading information, cannot be sent out in later validaton at > xmit path, as we did not set correct skb->protocol which is further used > for looking up the

Re: [PATCH net-next 0/5] net: Consolidate metrics handling for ipv4 and ipv6

2018-10-04 Thread David Miller
From: David Ahern Date: Thu, 4 Oct 2018 20:07:50 -0700 > From: David Ahern > > As part of the IPv6 fib info refactoring, the intent was to make metrics > handling for ipv6 identical to ipv4. One oversight in ip6_dst_destroy > led to confusion and a couple of incomplete attempts at finding and

Re: [PATCH net-next] net: sched: remove unused helpers

2018-10-04 Thread David Miller
From: Jakub Kicinski Date: Thu, 4 Oct 2018 17:07:51 -0700 > tcf_block_dev() doesn't seem to be used anywhere in the tree. > > Signed-off-by: Jakub Kicinski Applied.

Re: [PATCH net 0/4] bnxt_en: Misc. bug fixes.

2018-10-04 Thread David Miller
From: Michael Chan Date: Fri, 5 Oct 2018 00:25:59 -0400 > 4 small bug fixes related to setting firmware message enables bits, possible > memory leak when probe fails, and ring accouting when RDMA driver is loaded. > > Please queue these for -stable as well. Thanks. Series applied and queued

Re: [PATCH net] team: Forbid enslaving team device to itself

2018-10-04 Thread David Miller
From: Ido Schimmel Date: Mon, 1 Oct 2018 12:21:59 +0300 > team's ndo_add_slave() acquires 'team->lock' and later tries to open the > newly enslaved device via dev_open(). This emits a 'NETDEV_UP' event > that causes the VLAN driver to add VLAN 0 on the team device. team's >

Re: [PATCHv2 net-next] geneve: allow to clear ttl inherit

2018-10-04 Thread David Miller
From: Hangbin Liu Date: Sat, 29 Sep 2018 23:06:29 +0800 > As Michal remaind, we should allow to clear ttl inherit. Then we will > have three states: > > 1. set the flag, and do ttl inherit. > 2. do not set the flag, use configured ttl value, or default ttl (0) if >not set. > 3. disable ttl

Re: [PATCH net-next v1 1/1] tc: Add support for configuring the taprio scheduler

2018-10-04 Thread David Miller
From: Vinicius Costa Gomes Date: Fri, 28 Sep 2018 17:59:43 -0700 > This traffic scheduler allows traffic classes states (transmission > allowed/not allowed, in the simplest case) to be scheduled, according > to a pre-generated time sequence. This is the basis of the IEEE > 802.1Qbv

Re: [PATCH v4 net-next 0/9] bnxt_en: devlink param updates

2018-10-04 Thread David Miller
From: Jiri Pirko Date: Thu, 4 Oct 2018 12:39:40 +0200 > Thu, Oct 04, 2018 at 07:43:43AM CEST, vasundhara-v.vo...@broadcom.com wrote: >>This patchset adds support for 3 generic and 1 driver-specific devlink >>parameters. Add documentation for these configuration parameters. >> >>Also, this

Re: icmp6_send() is too expensive

2018-10-04 Thread David Miller
From: Jeff Barnhill <0xeff...@gmail.com> Date: Thu, 4 Oct 2018 15:02:39 -0400 > As mentioned here: > https://www.spinics.net/lists/netdev/msg505054.html > > icmp6_send() can be expensive when there are a lot of devices and > anycast addresses. One solution I've prototyped is adding a global >

Re: [PATCH v2] qed: Avoid implicit enum conversion in qed_ooo_submit_tx_buffers

2018-10-04 Thread David Miller
From: Nathan Chancellor Date: Thu, 4 Oct 2018 09:39:20 -0700 > Clang warns when one enumerated type is implicitly converted to another. > > drivers/net/ethernet/qlogic/qed/qed_ll2.c:799:32: warning: implicit > conversion from enumeration type 'enum core_tx_dest' to different > enumeration type

Re: [PATCH net 0/2] mlxsw: Couple of fixes

2018-10-04 Thread David Miller
From: Ido Schimmel Date: Thu, 4 Oct 2018 15:48:00 + > First patch works around an hardware issue in Spectrum-2 where a field > indicating the event type is always set to the same value. Since there > are only two event types and they are reported using different queues, > we can use the

Re: [pull request][net-next 0/5] Mellanox, mlx5 updates 2018-10-03

2018-10-04 Thread David Miller
From: Saeed Mahameed Date: Thu, 4 Oct 2018 07:31:19 -0700 > The following series includes mlx5 core driver and ethernet netdev updates, > please note there is a small devlink related update to allow extack > argument to eswitch operations, for more information please see tag log > below. > >

Re: pull-request: ieee802154-next 2018-10-04

2018-10-04 Thread David Miller
From: Stefan Schmidt Date: Thu, 4 Oct 2018 13:27:16 +0200 > An update from ieee802154 for *net-next* > > A very quite cycle in the ieee802154 subsystem. We only have two cleanup > patches for this pull request. > Xue removed the platform_data struct handling from the mcr20a driver and >

Re: How to post rxrpc patches for net-next with deps on net?

2018-10-04 Thread David Miller
From: David Miller Date: Wed, 03 Oct 2018 14:47:40 -0700 (PDT) > From: David Howells > Date: Wed, 03 Oct 2018 21:29:19 +0100 > >> I have some rxrpc patches to post for your net-next/master branch, but >> there's >> a dependency in them on the rxrpc-fixes-201809

Re: How to post rxrpc patches for net-next with deps on net?

2018-10-03 Thread David Miller
From: David Howells Date: Wed, 03 Oct 2018 21:29:19 +0100 > I have some rxrpc patches to post for your net-next/master branch, but there's > a dependency in them on the rxrpc-fixes-20180928 tag you pulled into your > net/master branch. > > What's the best way to handle this? > > (1) Wait for

Re: [net-next 00/13][pull request] 10GbE Intel Wired LAN Driver Updates 2018-10-03

2018-10-03 Thread David Miller
From: Jeff Kirsher Date: Wed, 3 Oct 2018 13:24:58 -0700 > This series contains updates to ixgbe/ixgbevf and few fixes for i40e & iavf. Pulled, thanks Jeff.

Re: r8169 tx batching(?) causing performance problems

2018-10-03 Thread David Miller
From: David Howells Date: Wed, 03 Oct 2018 21:19:40 +0100 > David Miller wrote: > >> Probably you are seeing some interrupt mitigation. >> >> It seems there is a difference in how the interrupt mitigation is >> programmed on for 8168 chips vs. others by d

Re: [net] ixgbe: check return value of napi_complete_done()

2018-10-03 Thread David Miller
From: Jeff Kirsher Date: Wed, 3 Oct 2018 11:30:35 -0700 > From: Song Liu > > The NIC driver should only enable interrupts when napi_complete_done() > returns true. This patch adds the check for ixgbe. > > Cc: sta...@vger.kernel.org # 4.10+ > Suggested-by: Eric Dumazet > Signed-off-by: Song

Re: [net-next 00/15][pull request] 100GbE Intel Wired LAN Driver Updates 2018-10-03

2018-10-03 Thread David Miller
From: Jeff Kirsher Date: Wed, 3 Oct 2018 08:48:10 -0700 > This series contains updates to ice and virtchnl. Pulled, thanks Jeff.

Re: [PATCH net-next] cxgb4: remove the unneeded locks

2018-10-03 Thread David Miller
From: Ganesh Goudar Date: Wed, 3 Oct 2018 18:26:32 +0530 > cxgb_set_tx_maxrate will be called holding rtnl lock, > hence remove all unneeded locks. > > Signed-off-by: Ganesh Goudar Applied.

Re: r8169 tx batching(?) causing performance problems

2018-10-03 Thread David Miller
Probably you are seeing some interrupt mitigation. It seems there is a difference in how the interrupt mitigation is programmed on for 8168 chips vs. others by default. Most get all zeros in the IntrMitigate register, whilst for 8168 chips a value of 0x5151 is programmed. You can play with

Re: [PATCH net-next] tls: Add support for inplace records encryption

2018-10-03 Thread David Miller
From: Vakul Garg Date: Sun, 30 Sep 2018 08:04:35 +0530 > Presently, for non-zero copy case, separate pages are allocated for > storing plaintext and encrypted text of records. These pages are stored > in sg_plaintext_data and sg_encrypted_data scatterlists inside record > structure. Further,

Re: [PATCH] net: dsa: lantiq: Fix path in MAINTAINERS file

2018-10-02 Thread David Miller
From: Hauke Mehrtens Date: Sat, 29 Sep 2018 13:26:30 +0200 > The MAINTAINERS file contained the wrong file name of the driver. > > Fixes: 14fceff4771e ("net: dsa: Add Lantiq / Intel DSA driver for vrx200") > Reported-by: Joe Perches > Signed-off-by: Hauke Mehrtens Applied.

Re: [PATCH] hv_netvsc: remove ndo_poll_controller

2018-10-02 Thread David Miller
From: Stephen Hemminger Date: Sat, 29 Sep 2018 14:52:56 +0200 > Similar to other patches from ERic. > > As diagnosed by Song Liu, ndo_poll_controller() can > be very dangerous on loaded hosts, since the cpu > calling ndo_poll_controller() might steal all NAPI > contexts (for all RX/TX queues of

Re: [PATCH net-next] MAINTAINERS: Fix wrong include file path

2018-10-02 Thread David Miller
From: Andrew Lunn Date: Sat, 29 Sep 2018 21:57:02 +0200 > Fix the patch for the mv88e6xxx.h header file in MAINTAINERS > > Reported-by: Joe Perches > Signed-off-by: Andrew Lunn Applied.

Re: pull request: bluetooth-next 2018-09-30

2018-10-02 Thread David Miller
From: Johan Hedberg Date: Sun, 30 Sep 2018 10:36:36 +0300 > Here's the first bluetooth-next pull request for the 4.20 kernel. > > - Fixes & cleanups to hci_qca driver > - NULL dereference fix to debugfs > - Improved L2CAP Connection-oriented Channel MTU & MPS handling > - Added support for

Re: [PATCH net] ipv4: fix use-after-free in ip_cmsg_recv_dstaddr()

2018-10-02 Thread David Miller
From: Eric Dumazet Date: Sun, 30 Sep 2018 11:33:39 -0700 > Caching ip_hdr(skb) before a call to pskb_may_pull() is buggy, > do not do it. > > Fixes: 2efd4fca703a ("ip: in cmsg IP(V6)_ORIGDSTADDR call pskb_may_pull") > Signed-off-by: Eric Dumazet > Cc: Willem de Bruijn > Reported-by: syzbot

Re: [PATCH net-next] ipv6: add vrf table handling code for ipv6 mcast

2018-10-02 Thread David Miller
From: Mike Manning Date: Mon, 1 Oct 2018 09:41:27 +0100 > From: Patrick Ruddy > > The code to obtain the correct table for the incoming interface was > missing for IPv6. This has been added along with the table creation > notification to fib rules for the RTNL_FAMILY_IP6MR address family. >

Re: [PATCH net-next] ipv4: Allow sending multicast packets on specific i/f using VRF socket

2018-10-02 Thread David Miller
From: Mike Manning Date: Mon, 1 Oct 2018 09:40:23 +0100 > From: Robert Shearman > > It is useful to be able to use the same socket for listening in a > specific VRF, as for sending multicast packets out of a specific > interface. However, the bound device on the socket currently takes >

Re: [PATCH net-next 0/4] dpaa2-eth: Add support for Rx flow classification

2018-10-02 Thread David Miller
From: Ioana Radulescu Date: Mon, 1 Oct 2018 13:44:54 +0300 > The Management Complex (MC) firmware initially allowed the > configuration of a single key to be used both for Rx flow hashing > and flow classification. This prevented us from supporting > Rx flow classification independently of the

Re: [pull request][net 0/3] Mellanox, mlx5 fixes 2018-10-01

2018-10-02 Thread David Miller
From: Saeed Mahameed Date: Mon, 1 Oct 2018 10:37:47 -0700 > This pull request includes some fixes to mlx5 driver, > Please pull and let me know if there's any problem. Pulled. > For -stable v4.11: > "6e0a4a23c59a ('net/mlx5: E-Switch, Fix out of bound access when setting > vport rate')" > >

Re: [PATCH net-next] tcp: do not release socket ownership in tcp_close()

2018-10-02 Thread David Miller
From: Eric Dumazet Date: Mon, 1 Oct 2018 23:24:26 -0700 > syzkaller was able to hit the WARN_ON(sock_owned_by_user(sk)); > in tcp_close() > > While a socket is being closed, it is very possible other > threads find it in rtnetlink dump. > > tcp_get_info() will acquire the socket lock for a

Re: [PATCH net 0/3] net: qualcomm: rmnet: Updates 2018-10-02

2018-10-02 Thread David Miller
From: Subash Abhinov Kasiviswanathan Date: Tue, 2 Oct 2018 18:52:00 -0600 > This series is a set of small fixes for rmnet driver > > Patch 1 is a fix for a scenario reported by syzkaller > Patch 2 & 3 are fixes for incorrect allocation flags Series applied and queued up for -stable, thanks.

Re: [PATCH v2 1/9] net: ip_rt_get_source() - use new style struct initializer instead of memset

2018-10-02 Thread David Miller
From: Maciej Żenczykowski Date: Tue, 2 Oct 2018 16:25:39 -0700 >> Please provide a proper "0/N" header posting in furture patch series >> submissions. >> >> Thank you. > > Seeing as all but 2 of these patches were entirely independent should > I have sent them as individual patches instead

Re: [PATCH v2 1/9] net: ip_rt_get_source() - use new style struct initializer instead of memset

2018-10-02 Thread David Miller
All 9 patches applied, thanks. Please provide a proper "0/N" header posting in furture patch series submissions. Thank you.

Re: [PATCH net] rtnl: limit IFLA_NUM_TX_QUEUES and IFLA_NUM_RX_QUEUES to 4096

2018-10-02 Thread David Miller
From: Eric Dumazet Date: Tue, 2 Oct 2018 15:47:35 -0700 > We have an impressive number of syzkaller bugs that are linked > to the fact that syzbot was able to create a networking device > with millions of TX (or RX) queues. > > Let's limit the number of RX/TX queues to 4096, this really should

Re: [PATCH net] bonding: fix warning message

2018-10-02 Thread David Miller
From: Mahesh Bandewar Date: Tue, 2 Oct 2018 12:14:34 -0700 > From: Mahesh Bandewar > > RX queue config for bonding master could be different from its slave > device(s). With the commit 6a9e461f6fe4 ("bonding: pass link-local > packets to bonding master also."), the packet is reinjected into

Re: [PATCH net] inet: make sure to grab rcu_read_lock before using ireq->ireq_opt

2018-10-02 Thread David Miller
From: Eric Dumazet Date: Tue, 2 Oct 2018 12:35:05 -0700 > Timer handlers do not imply rcu_read_lock(), so my recent fix > triggered a LOCKDEP warning when SYNACK is retransmit. > > Lets add rcu_read_lock()/rcu_read_unlock() pairs around ireq->ireq_opt > usages instead of guessing what is done

Re: [net-next 0/9][pull request] 100GbE Intel Wired LAN Driver Updates 2018-10-02

2018-10-02 Thread David Miller
From: Jeff Kirsher Date: Tue, 2 Oct 2018 08:24:38 -0700 > This series contains updates to ice driver only. If there was a problem yo I'll solve it. Check out the hook while my DJ revolves it. Ice ice baby. Ice ice baby. Pulled, thanks Jeff.

Re: [PATCH net-next 0/2] qed*: Driver support for 20G link speed.

2018-10-02 Thread David Miller
From: Sudarsana Reddy Kalluru Date: Tue, 2 Oct 2018 06:16:10 -0700 > From: Sudarsana Reddy Kalluru > > The patch series adds driver support for configuring/reading the 20G link > speed. > > Please consider applying this to "net-next". Series applied.

Re: [PATCH 1/1] net: fec: fix rare tx timeout

2018-10-02 Thread David Miller
From: Date: Tue, 2 Oct 2018 14:49:32 +0200 > From: Rickard x Andersson > > During certain heavy network loads TX could time out > with TX ring dump. > TX is sometimes never restarted after reaching > "tx_stop_threshold" because function "fec_enet_tx_queue" > only tests the first queue. > > In

Re: [PATCH net] ipv6: revert degradation in IPv6 Ready Logo test results

2018-10-02 Thread David Miller
From: Mike Manning Date: Tue, 2 Oct 2018 12:40:30 +0100 > This reverts commit 0ed4229b08c1 ("ipv6: defrag: drop non-last frags > smaller than min mtu"). While one should not get fragments smaller than > the IPv6 minimum MTU, not handling crafted packets in the TAHI IPv6 > conformance test suite

Re: [PATCH net-next] net: drop unused skb_append_datato_frags()

2018-10-02 Thread David Miller
From: Paolo Abeni Date: Tue, 2 Oct 2018 11:03:40 +0200 > This helper is unused since commit 988cf74deb45 ("inet: > Stop generating UFO packets.") > > Signed-off-by: Paolo Abeni Applied.

Re: [PATCH net-next 0/3] ibmvnic: Implement driver-defined queue limits

2018-10-02 Thread David Miller
From: Thomas Falcon Date: Fri, 28 Sep 2018 18:38:23 -0500 > In this patch series, update the ibmvnic driver to use driver-defined > queue limits instead of limits imposed by the Virtual I/O server > management partition. For some deviced, initial max queue size and > amount limits, despite their

Re: [PATCH net 0/3] tun: address two syzbot reports

2018-10-02 Thread David Miller
From: Eric Dumazet Date: Fri, 28 Sep 2018 14:51:46 -0700 > Small changes addressing races discovered by syzbot. > > First patch is a cleanup. > Second patch moves a mutex init sooner. > Third patch makes sure each tfile gets its own napi enable flags. Series applied and queued up for -stable.

Re: [PATCH RESEND] net: phy: Convert to using %pOFn instead of device_node.name

2018-10-02 Thread David Miller
From: Rob Herring Date: Fri, 28 Sep 2018 17:04:59 -0500 > In preparation to remove the node name pointer from struct device_node, > convert printf users to use the %pOFn format specifier. > > Cc: Andrew Lunn > Cc: "David S. Miller" > Cc: netdev@vger.kernel.org > Reviewed-by: Florian Fainelli

Re: [PATCH net v2] r8169: fix network stalls due to missing bit TXCFG_AUTO_FIFO

2018-10-02 Thread David Miller
From: Heiner Kallweit Date: Fri, 28 Sep 2018 23:51:54 +0200 > Some of the chip-specific hw_start functions set bit TXCFG_AUTO_FIFO > in register TxConfig. The original patch changed the order of some > calls resulting in these changes being overwritten by > rtl_set_tx_config_registers() in

Re: bond: take rcu lock in netpoll_send_skb_on_dev

2018-10-02 Thread David Miller
From: Dave Jones Date: Fri, 28 Sep 2018 16:26:08 -0400 > The bonding driver lacks the rcu lock when it calls down into > netdev_lower_get_next_private_rcu from bond_poll_controller, which > results in a trace like: ... > We're also doing rcu dereferences a layer up in netpoll_send_skb_on_dev >

Re: [PATCH net] rtnetlink: Fail dump if target netnsid is invalid

2018-10-02 Thread David Miller
From: David Ahern Date: Fri, 28 Sep 2018 12:28:41 -0700 > From: David Ahern > > Link dumps can return results from a target namespace. If the namespace id > is invalid, then the dump request should fail if get_target_net fails > rather than continuing with a dump of the current namespace. > >

Re: [PATCH net-next] tcp/fq: move back to CLOCK_MONOTONIC

2018-10-02 Thread David Miller
From: Eric Dumazet Date: Fri, 28 Sep 2018 10:28:44 -0700 > In the recent TCP/EDT patch series, I switched TCP and sch_fq > clocks from MONOTONIC to TAI, in order to meet the choice done > earlier for sch_etf packet scheduler. > > But sure enough, this broke some setups were the TAI clock >

Re: [PATCH v2 net-next] net: phy: improve handling delayed work

2018-10-02 Thread David Miller
From: Heiner Kallweit Date: Fri, 28 Sep 2018 08:51:09 +0200 > Using mod_delayed_work() allows to simplify handling delayed work and > removes the need for the sync parameter in phy_trigger_machine(). > Also introduce a helper phy_queue_state_machine() to encapsulate the > low-level delayed work

Re: [PATCH net-next 0/5] net: systemport: Turn on offloads by

2018-10-02 Thread David Miller
From: Florian Fainelli Date: Thu, 27 Sep 2018 15:36:09 -0700 > Up until now, we had added all the code necessary to turn on RX/TX > checksum offloads at runtime, but there is no reason why they have to be > disabled by default given that this gives a slight performance > improvement. Series

Re: [PATCH v2 net-next 0/8] Continue towards using linkmode in phylib

2018-10-01 Thread David Miller
From: Andrew Lunn Date: Sat, 29 Sep 2018 23:04:08 +0200 > These patches contain some further cleanup and helpers, and the first > real patch towards using linkmode bitmaps in phylink. > > The macro magic in the RFC version has been replaced with run time > initialisation. Series applied,

Re: [PATCH net-next] nfp: warn on experimental TLV types

2018-10-01 Thread David Miller
From: Jakub Kicinski Date: Wed, 26 Sep 2018 15:35:31 -0700 > Reserve two TLV types for feature development, and warn in the driver > if they ever leak into production. > > Signed-off-by: Jakub Kicinski > Reviewed-by: Simon Horman Applied.

Re: pull request: bluetooth 2018-09-27

2018-10-01 Thread David Miller
From: Johan Hedberg Date: Thu, 27 Sep 2018 21:28:40 +0300 > Here's one more Bluetooth fix for 4.19, fixing the handling of an > attempt to unpair a device while pairing is in progress. > > Let me know if there are any issues pulling. Thanks. Pulled, thanks Johan.

Re: [PATCH net-next 2/2] tcp: adjust rcv zerocopy hints based on frag sizes

2018-10-01 Thread David Miller
From: Soheil Hassas Yeganeh Date: Wed, 26 Sep 2018 16:57:04 -0400 > From: Soheil Hassas Yeganeh > > When SKBs are coalesced, we can have SKBs with different > frag sizes. Some with PAGE_SIZE and some not with PAGE_SIZE. > Since recv_skip_hint is always set to the full SKB size, > it can

Re: [PATCH net-next 1/2] tcp: set recv_skip_hint when tcp_inq is less than PAGE_SIZE

2018-10-01 Thread David Miller
From: Soheil Hassas Yeganeh Date: Wed, 26 Sep 2018 16:57:03 -0400 > From: Soheil Hassas Yeganeh > > When we have less than PAGE_SIZE of data on receive queue, > we set recv_skip_hint to 0. Instead, set it to the actual > number of bytes available. > > Signed-off-by: Soheil Hassas Yeganeh >

Re: [net 1/1] tipc: ignore STATE_MSG on wrong link session

2018-10-01 Thread David Miller
From: Jon Maloy Date: Wed, 26 Sep 2018 22:28:52 +0200 > From: LUU Duc Canh > > The initial session number when a link is created is based on a random > value, taken from struct tipc_net->random. It is then incremented for > each link reset to avoid mixing protocol messages from different link

Re: [PATCH net] net: sched: act_ipt: check for underflow in __tcf_ipt_init()

2018-10-01 Thread David Miller
From: Dan Carpenter Date: Sat, 22 Sep 2018 16:46:48 +0300 > If "td->u.target_size" is larger than sizeof(struct xt_entry_target) we > return -EINVAL. But we don't check whether it's smaller than > sizeof(struct xt_entry_target) and that could lead to an out of bounds > read. > > Fixes:

Re: pull request (net-next): ipsec-next 2018-10-01

2018-10-01 Thread David Miller
From: Steffen Klassert Date: Mon, 1 Oct 2018 11:16:06 +0200 > 1) Make xfrmi_get_link_net() static to silence a sparse warning. >From Wei Yongjun. > > 2) Remove a unused esph pointer definition in esp_input(). >From Haishuang Yan. > > 3) Allow the NIC driver to quietly refuse xfrm

Re: pull request (net): ipsec 2018-10-01

2018-10-01 Thread David Miller
From: Steffen Klassert Date: Mon, 1 Oct 2018 10:58:49 +0200 > 1) Validate address prefix lengths in the xfrm selector, >otherwise we may hit undefined behaviour in the >address matching functions if the prefix is too >big for the given address family. > > 2) Fix skb leak on local

Re: [pull request][net-next 00/13] Mellanox, mlx5e updates 2018-10-01

2018-10-01 Thread David Miller
From: Saeed Mahameed Date: Mon, 1 Oct 2018 11:56:48 -0700 > The following pull request includes updates to mlx5e ethernet netdevice > driver, for more information please see tag log below. > > Please pull and let me know if there's any problem. Pulled, thank you.

Re: [PATCH net-next] tcp: start receiver buffer autotuning sooner

2018-10-01 Thread David Miller
From: Yuchung Cheng Date: Mon, 1 Oct 2018 15:42:32 -0700 > Previously receiver buffer auto-tuning starts after receiving > one advertised window amount of data. After the initial receiver > buffer was raised by patch a337531b942b ("tcp: up initial rmem to > 128KB and SYN rwin to around 64KB"),

Re: [net-next 0/8][pull request] 100GbE Intel Wired LAN Driver Updates 2018-10-01

2018-10-01 Thread David Miller
From: Jeff Kirsher Date: Mon, 1 Oct 2018 14:14:23 -0700 > This series contains updates to ice driver only. > > Anirudh provides several changes to "prep" the driver for upcoming > features. Specifically, the functions that are used for PF VSI/netdev > setup will also be used in SR-IOV support

Re: [PATCH net] tcp/dccp: fix lockdep issue when SYN is backlogged

2018-10-01 Thread David Miller
From: Eric Dumazet Date: Mon, 1 Oct 2018 15:02:26 -0700 > In normal SYN processing, packets are handled without listener > lock and in RCU protected ingress path. > > But syzkaller is known to be able to trick us and SYN > packets might be processed in process context, after being > queued

Re: [PATCH] r8169: Disable clk during suspend / resume

2018-09-29 Thread David Miller
From: Hans de Goede Date: Wed, 26 Sep 2018 22:12:39 +0200 > Disable the clk during suspend to save power. Note that tp->clk may be > NULL, the clk core functions handle this without problems. > > Reviewed-by: Andy Shevchenko > Tested-by: Carlo Caione > Signed-off-by: Hans de Goede Applied.

Re: [PATCH] netlink: fix typo in nla_parse_nested() comment

2018-09-29 Thread David Miller
From: Johannes Berg Date: Wed, 26 Sep 2018 22:19:42 +0200 > From: Johannes Berg > > Fix a simple typo: attribuets -> attributes > > Signed-off-by: Johannes Berg Applied.

Re: [PATCH net 1/1] qlcnic: fix Tx descriptor corruption on 82xx devices

2018-09-29 Thread David Miller
From: Shahed Shaikh Date: Wed, 26 Sep 2018 12:41:10 -0700 > In regular NIC transmission flow, driver always configures MAC using > Tx queue zero descriptor as a part of MAC learning flow. > But with multi Tx queue supported NIC, regular transmission can occur on > any non-zero Tx queue and from

Re: [PATCH] [PATCH net-next] openvswitch: Use correct reply values in datapath and vport ops

2018-09-29 Thread David Miller
From: Yifeng Sun Date: Wed, 26 Sep 2018 11:40:14 -0700 > This patch fixes the bug that all datapath and vport ops are returning > wrong values (OVS_FLOW_CMD_NEW or OVS_DP_CMD_NEW) in their replies. > > Signed-off-by: Yifeng Sun Applied.

Re: [PATCH net-next] tls: Remove redundant vars from tls record structure

2018-09-29 Thread David Miller
From: Vakul Garg Date: Wed, 26 Sep 2018 16:22:08 +0530 > Structure 'tls_rec' contains sg_aead_in and sg_aead_out which point > to a aad_space and then chain scatterlists sg_plaintext_data, > sg_encrypted_data respectively. Rather than using chained scatterlists > for plaintext and encrypted data

Re: pull-request: ieee802154 for net 2018-09-28

2018-09-29 Thread David Miller
From: Stefan Schmidt Date: Fri, 28 Sep 2018 12:20:42 +0200 > An update from ieee802154 for your *net* tree. > > Some cleanup patches throughout the drivers from the Huawei tag team > Yue Haibing and Zhong Jiang. > Xue is replacing some magic numbers with defines in his mcr20a driver. Applied,

Re: [PATCH net-next v2] tcp: up initial rmem to 128KB and SYN rwin to around 64KB

2018-09-29 Thread David Miller
From: Yuchung Cheng Date: Fri, 28 Sep 2018 13:09:02 -0700 > Previously TCP initial receive buffer is ~87KB by default and > the initial receive window is ~29KB (20 MSS). This patch changes > the two numbers to 128KB and ~64KB (rounding down to the multiples > of MSS) respectively. The patch also

Re: [PATCH net 0/2] s390/qeth: fixes 2019-09-26

2018-09-29 Thread David Miller
From: Julian Wiedmann Date: Fri, 28 Sep 2018 11:05:22 +0200 > On 26.09.2018 19:39, David Miller wrote: >> From: Julian Wiedmann >> Date: Wed, 26 Sep 2018 18:07:08 +0200 >> >>> please apply two qeth patches for -net. The first is a trivial cleanup >>> req

Re: [PATCH net 00/11] netpoll: second round of fixes.

2018-09-28 Thread David Miller
From: Eric Dumazet Date: Thu, 27 Sep 2018 09:31:50 -0700 > As diagnosed by Song Liu, ndo_poll_controller() can > be very dangerous on loaded hosts, since the cpu > calling ndo_poll_controller() might steal all NAPI > contexts (for all RX/TX queues of the NIC). > > This capture, showing one

Re: [net-next 0/8][pull request] 100GbE Intel Wired LAN Driver Updates 2018-09-27

2018-09-28 Thread David Miller
From: Jeff Kirsher Date: Thu, 27 Sep 2018 09:21:53 -0700 > This series contains fixes to the ice driver only. ... > The following are changes since commit > 1042caa79e9351b81ed19dc8d2d7fd6ff51a4422: > net-ipv4: remove 2 always zero parameters from ipv4_redirect() > and are available in the

Re: [PATCH net-next] net: sched: make function qdisc_free_cb() static

2018-09-28 Thread David Miller
From: Wei Yongjun Date: Thu, 27 Sep 2018 14:47:56 + > Fixes the following sparse warning: > > net/sched/sch_generic.c:944:6: warning: > symbol 'qdisc_free_cb' was not declared. Should it be static? > > Fixes: 3a7d0d07a386 ("net: sched: extend Qdisc with rcu") > Signed-off-by: Wei Yongjun

Re: [PATCH net-next] selftests: forwarding: test for bridge sticky flag

2018-09-28 Thread David Miller
From: Nikolay Aleksandrov Date: Thu, 27 Sep 2018 16:35:13 +0300 > This test adds an fdb entry with the sticky flag and sends traffic from > a different port with the same mac as a source address expecting the entry > to not change ports if the flag is operating correctly. > > Signed-off-by:

Re: [PATCH net 1/1] qed: Fix shmem structure inconsistency between driver and the mfw.

2018-09-28 Thread David Miller
From: Sudarsana Reddy Kalluru Date: Thu, 27 Sep 2018 04:12:10 -0700 > The structure shared between driver and the management FW (mfw) differ in > sizes. This would lead to issues when driver try to access the structure > members which are not-aligned with the mfw copy e.g., data_ptr usage in the

Re: [PATCH 1/1] Update maintainers for bnx2/bnx2x/qlge/qlcnic drivers.

2018-09-28 Thread David Miller
From: Sudarsana Reddy Kalluru Date: Wed, 26 Sep 2018 21:57:03 -0700 > Signed-off-by: Sudarsana Reddy Kalluru > Signed-off-by: Ameen Rahman Applied, thank you.

Re: [PATCH] MAINTAINERS: change bridge maintainers

2018-09-28 Thread David Miller
From: Stephen Hemminger Date: Thu, 27 Sep 2018 10:47:01 +0200 > I haven't been doing reviews only but not active development on bridge > code for several years. Roopa and Nikolay have been doing most of > the new features and have agreed to take over as new co-maintainers. > > Signed-off-by:

Re: [PATCH v3 0/5] netlink: nested policy validation

2018-09-28 Thread David Miller
From: Johannes Berg Date: Thu, 27 Sep 2018 10:22:42 +0200 > On Wed, 2018-09-26 at 10:21 -0700, David Miller wrote: >> From: Johannes Berg >> Date: Wed, 26 Sep 2018 11:15:29 +0200 >> >> > This adds nested policy validation, which lets you specify the >> >

Re: [PATCH net-next] qed: Remove set but not used variable 'p_archipelago'

2018-09-28 Thread David Miller
From: YueHaibing Date: Thu, 27 Sep 2018 06:45:06 + > Fixes gcc '-Wunused-but-set-variable' warning: > > drivers/net/ethernet/qlogic/qed/qed_ooo.c: In function 'qed_ooo_delete_isles': > drivers/net/ethernet/qlogic/qed/qed_ooo.c:354:30: warning: > variable 'p_archipelago' set but not used

Re: [PATCH] net-tcp: /proc/sys/net/ipv4/tcp_probe_interval is a u32 not int

2018-09-26 Thread David Miller
From: "Maciej Żenczykowski" Date: Tue, 25 Sep 2018 21:59:28 -0700 > From: Maciej Żenczykowski > > (fix documentation and sysctl access to treat it as such) > > Tested: > # zcat /proc/config.gz | egrep ^CONFIG_HZ > CONFIG_HZ_1000=y > CONFIG_HZ=1000 > # echo $[(1<<32)/1000 + 1] | tee

Re: [PATCH net v2] bnxt_en: Fix TX timeout during netpoll.

2018-09-26 Thread David Miller
From: Michael Chan Date: Wed, 26 Sep 2018 00:41:04 -0400 > The current netpoll implementation in the bnxt_en driver has problems > that may miss TX completion events. bnxt_poll_work() in effect is > only handling at most 1 TX packet before exiting. In addition, > there may be in flight TX

Re: [PATCH 1/2] net-ipv4: remove 2 always zero parameters from ipv4_update_pmtu()

2018-09-26 Thread David Miller
From: "Maciej Żenczykowski" Date: Tue, 25 Sep 2018 20:56:26 -0700 > From: Maciej Żenczykowski > > (the parameters in question are mark and flow_flags) > > Reviewed-by: David Ahern > Signed-off-by: Maciej Żenczykowski Applied.

Re: [PATCH 2/2] net-ipv4: remove 2 always zero parameters from ipv4_redirect()

2018-09-26 Thread David Miller
From: "Maciej Żenczykowski" Date: Tue, 25 Sep 2018 20:56:27 -0700 > From: Maciej Żenczykowski > > (the parameters in question are mark and flow_flags) > > Reviewed-by: David Ahern > Signed-off-by: Maciej Żenczykowski Applied.

Re: [PATCH net] vxlan: fill ttl inherit info

2018-09-26 Thread David Miller
From: Hangbin Liu Date: Wed, 26 Sep 2018 10:35:42 +0800 > When add vxlan ttl inherit support, I forgot to fill it when dump > vlxan info. Fix it now. > > Fixes: 72f6d71e491e6 ("vxlan: add ttl inherit support") > Signed-off-by: Hangbin Liu Applied and queued up for -stable.

Re: [PATCH v2 net] net: phy: sfp: Fix unregistering of HWMON SFP device

2018-09-26 Thread David Miller
From: Andrew Lunn Date: Tue, 25 Sep 2018 01:50:00 +0200 > A HWMON device is only registered is the SFP module supports the > diagnostic page and is complient to SFF8472. Don't unconditionally > unregister the hwmon device when the SFP module is remove, otherwise > we access data structures which

Re: [PATCH net] bonding: avoid possible dead-lock

2018-09-26 Thread David Miller
From: Mahesh Bandewar Date: Mon, 24 Sep 2018 14:40:11 -0700 > From: Mahesh Bandewar > > Syzkaller reported this on a slightly older kernel but it's still > applicable to the current kernel - ... > Signed-off-by: Mahesh Bandewar Applied and queued up for -stable.

<    3   4   5   6   7   8   9   10   11   12   >