Hi Eric,
On 03/29/2018 12:03 PM, Eric Dumazet wrote:
>
>
> On 03/28/2018 08:51 PM, Dongli Zhang wrote:
>> The "BUG_ON(!frag_iter)" in function xenvif_rx_next_chunk() is triggered if
>> the received sk_buff is malformed, that is, when the sk_buff has pattern
>&
n = 352;
skb->tail = 98;
skb->end = 384;
skb_shinfo(skb)->nr_frags = 0;
dev->netdev_ops->ndo_start_xmit(skb, dev);
This patch stops processing sk_buff immediately if it is detected as
malformed, that is, pkt->frag_iter is NULL but there is still remaining
pkt->remaining_len.
dev->netdev_ops->ndo_start_xmit(skb, dev);
return 0;
}
static void __exit test_skb_exit(void)
{
}
MODULE_LICENSE("GPL");
module_init(test_skb_init);
module_exit(test_skb_exit);
Dongli Zhang
On 03/28/2018 07:42 AM, Dongli Zhang wrote:
> The "BUG_ON(!
n = 352;
skb->tail = 98;
skb->end = 384;
dev->netdev_ops->ndo_start_xmit(skb, dev);
This patch stops processing sk_buff immediately if it is detected as
malformed, that is, pkt->frag_iter is NULL but there is still remaining
pkt->remaining_len.
Signed-off-by: Dongli Zhang <dongli.z
IS_ERR_VALUE() in commit 87557efc27f6a50140fb20df06a917f368ce3c66
("xen-netfront: do not cast grant table reference to signed short") would
not return true for error code unless we cast ref first to type int.
Signed-off-by: Dongli Zhang <dongli.zh...@oracle.com>
---
drivers/ne
end a new patch or an incremental
based on previous one at
https://git.kernel.org/cgit/linux/kernel/git/davem/net.git?
Thank you very much!
Dongli Zhang
- Original Message -
From: da...@davemloft.net
To: dongli.zh...@oracle.com
Cc: linux-ker...@vger.kernel.org, xen
red, preventing its later use from causing further damage).
The reason I use warning instead BUG_ON is that Linus suggested use
WARN_ON_ONCE() in a previous email:
http://lkml.iu.edu/hypermail/linux/kernel/1610.0/00878.html
I would change to BUG_ON() if it is OK to you.
Thank you very much!
While grant reference is of type uint32_t, xen-netfront erroneously casts
it to signed short in BUG_ON().
This would lead to the xen domU panic during boot-up or migration when it
is attached with lots of paravirtual devices.
Signed-off-by: Dongli Zhang <dongli.zh...@oracle.com>
---
drive
